From nobody Fri Oct 3 07:39:23 2025 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79675369320; Wed, 3 Sep 2025 18:59:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756925977; cv=none; b=AOKo1snXsNjgfrl3JU7pVSmXq4IP7Kw2MAcXvnyABBemR+iNlFYOo/OQDYG6fayO57wCGRMTVgWTRdD/oA0C3Vfi54rCJpzQT1pTU0amY+vryUP+6A79BIfAJPM1TWHZqBwVzuPzc9ES6Duw4JMwsAYkQwV7s+qUacr7DnEOPvU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756925977; c=relaxed/simple; bh=LTLVF+hMZyPv1dZXihuaUEnmBeqbcuLCGvLuGg2qrsY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IenNKbZziH56MQQdcAqpkcTwzWzPL/J9lraILOjB9+tI2NB57WqU5e8YvEJHgiXPkOHEcYEAzHhMsxUZMBPv2d9tFkutLXS0oe145qhUa2aRSJRXenx5J9UsVSNAJ3yPv5cP/8xxOs/oZ0l891odqNw78Y3m17GO5Lmyrkcs/v0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FUdDmabG; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FUdDmabG" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-24b28de798cso2143785ad.0; Wed, 03 Sep 2025 11:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756925976; x=1757530776; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Cg3vWTOesz5aa5s3lECf1v2j8z5ZoWgWQOpdmwDONGE=; b=FUdDmabGPE+tniO/0FSqPMFzk6UhnldQNdPj+iTXRFlwHhghyCoXBWtQiKzDZuNqdS fTBUHXWXDOWYMegwMDajmhI0o9OXkpPlYqDg6ZgzflUhwht1gHTnPYA6Qw7CvkTW0my6 uZ8CQXtzq3TQrKW+u0EXCgpJ0QOh8NB+H9NDaabmXKORNDic0fatcciAeMHqGVVZpiJr 8XzEO1kN48+RQwJmDZY21Gj4VKeBfOdZBkxewMF9M8iHaLOFX7DtAk+eu800sCNdIwTq Z2xRPPaiOmxdwpnP/8WfnuqoK8TqRAUqNVshyfsRPK5x3lXy8EGKyH8A1Ug/f1vCBQCB vCMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756925976; x=1757530776; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cg3vWTOesz5aa5s3lECf1v2j8z5ZoWgWQOpdmwDONGE=; b=eCSg7I0JWCVZFO6ISp5AIct5XfMyBGZAN8yNDXuKUcjFHloVsGnDEwH4aEkrYOj30L NU1FxiWMreenl0QK8nX5xoC2uubP4m4F1AUnfQcKiYlUkRFuA1pkdBqg9zP6KE1+TGSo LkPtG7/8OK7TCebTtyLQEadr8kPfoNN0MBQFdW3TEqhFzY1XV3N+NaN9AaG2XD39V9CA jhyoO9gtT270YhPZmze03vnopoUEuRrcXmPL9vCxSEalfenUe4pvZdEGuuXtrNwa47bm mkaDzN3iTgCNzPjz1F8T0GqvaJPFJlkbS2Dlo5epk98jRJ4iTWdrYtVbE+uJrlha192j RpnQ== X-Forwarded-Encrypted: i=1; AJvYcCU7sA/WYIQ0OOl3U2zCUGEGfN+IqJebkgA+0QZEutgGlj3VK+5LwpY2yCxkmjt9L3vJlBpLyt6gyTeX@vger.kernel.org, AJvYcCUMugDiufO9KE+ClDdNiVuGQx/wS6o8GNiHxNdbwX/w9aowtXIGN1iXSdia0BEP2RqbpmT+ABCRrtInxA==@vger.kernel.org X-Gm-Message-State: AOJu0YyAEq3eLFXIv+J3eaImlFie0gUsa0KH9l9ndT2/ahxIaZNDUDUY K3ASBg7SncCj2VCHmLcrQur/8ICu1G0ADeFgITrFAyDm5vGrYYPA/LLu X-Gm-Gg: ASbGncsPjSpD103QuuBd5YnbodMLSA5lKPqmNQISjVv4iFMiYxA1D8fjYLV/M8gApbm WOGAgr85ohhd4fNsH2gsRlw9GBeGa1nmZbB1InOTd2OIip9vDzFQd4jkNYbhmj8ZkTsev0dq9Fs tHidHh2EteFoWo0AP2VgHTdX/DSq+JidXrVAqFiIX49wm+RmWFJM7RplTPI7OqCgL4ZhB7SUp/3 VkjoUfqAIbgchkl9kpQ8tDfNJYtKrjF9W8qLuQOo4XfEqruHhkhXqfOpP8Hn2oFRDkYITKHbb/H nlTg/LJrxahjSa1qVp0CF1s015uDpgIHfhHjUC1T9UIm5iW6VQTUITUG/d3QjFGS22+DgTsTXp1 OvGK6nbJDKZ50wIhnZIs3D2BOroEAPISXdDawzdAL5yPqEe7oMafBww== X-Google-Smtp-Source: AGHT+IEDGbdRM9mEhaV+2ag53MUmou+Up6hgUY2vpYZIptsrNmf4dFU9V5zvfqRBlRBpWDsd4n9KQA== X-Received: by 2002:a17:902:d552:b0:248:fbc1:daf6 with SMTP id d9443c01a7336-24944ad55a3mr207897875ad.43.1756925975667; Wed, 03 Sep 2025 11:59:35 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-249065ab343sm169403475ad.126.2025.09.03.11.59.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Sep 2025 11:59:35 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , linux-block@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-efi@vger.kernel.org, virtualization@lists.linux.dev, "Vishal Moola (Oracle)" , "Matthew Wilcox (Oracle)" , SeongJae Park Subject: [PATCH v3 1/7] mm/page_alloc: Add kernel-docs for free_pages() Date: Wed, 3 Sep 2025 11:59:15 -0700 Message-ID: <20250903185921.1785167-2-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250903185921.1785167-1-vishal.moola@gmail.com> References: <20250903185921.1785167-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add kernel-docs to free_pages(). This will help callers understand when to use it instead of __free_pages(). Signed-off-by: Vishal Moola (Oracle) Reviewed-by: Matthew Wilcox (Oracle) Acked-by: SeongJae Park Acked-by: Mike Rapoport (Microsoft) --- mm/page_alloc.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index c2a254d877f8..0277b86b62ac 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5269,6 +5269,15 @@ void free_pages_nolock(struct page *page, unsigned i= nt order) ___free_pages(page, order, FPI_TRYLOCK); } =20 +/** + * free_pages - Free pages allocated with __get_free_pages(). + * @addr: The virtual address tied to a page returned from __get_free_page= s(). + * @order: The order of the allocation. + * + * This function behaves the same as __free_pages(). Use this function + * to free pages when you only have a valid virtual address. If you have + * the page, call __free_pages() instead. + */ void free_pages(unsigned long addr, unsigned int order) { if (addr !=3D 0) { --=20 2.51.0 From nobody Fri Oct 3 07:39:23 2025 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BE3C369349; Wed, 3 Sep 2025 18:59:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756925979; cv=none; b=WEGa3TDQjATu6/kDxg/hhYEL1X9c9apOvbN/avCVdokxDmTZLY0XiDs71X/6xqdJZgOUOe1zWq547fFrGGZaERerkflD+bSA86BaKk0t0JFXqdt5VSJvnpBU6l6azZrDUCTuSw+qWepiwS7PfoWos/RNiijBS087/J2bQW2CiZc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756925979; c=relaxed/simple; bh=L9mBqIG1TiHreIDV8a0dfjkIxduVLSZagZOu8X4AsI0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TXgduMXpaEhkIzUDPUrEArQYSeoQXgIrd76QdbBVFtl0UsQg9B1DWJ3LOcXLYUeY+ZZOYDjq3Box/Yq5dpCWiqYi3gxb62cK5wzPNFVUVAeNFT4pu1TA3erZ24QOI8hs3oOnn+BsjghjtC/vyFItfUYsGDACyQC26RxYABDf/zU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m0Npy9YC; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m0Npy9YC" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-24c863e852aso2620885ad.1; Wed, 03 Sep 2025 11:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756925977; x=1757530777; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p96JFKpspRPKBmH2rgBynj/gu4bh0EGooQeUZ0NhcIU=; b=m0Npy9YC5qUlAeQVQc1BZVsvH5lS6tGTflqjmMmrBPVpz2RXKRSC9yzLaJBvNH3lPY wxoDahz3/Lh1lL4/p4pwOVBEC0t4sOAq6zPoe26fDRrAeBJM+E1yeXL4l6c4Ksc6xP/t tTbBV3YwO+FiWPESBI4yB+EjrkVexZ22Uw0RSYgQblPLYr2Fr9axA4U7RQyB16WMK2Uz P2R50/RBpb6m/KOWMuJ3fEn/iPpf0qzc37M42ZRyXxfvJyLOei2huRMyJgiA6QimoKWr WcSuxoHADZkecbEoGL3Q8wMtFHylwNW+/diLtHCEvOtJYQw4mF6uy2LyMk/Ay7A7tf8G g9RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756925977; x=1757530777; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p96JFKpspRPKBmH2rgBynj/gu4bh0EGooQeUZ0NhcIU=; b=avrzS462eslJmAXLQQt0NQGg5FwqungEIDrzA+/Y+KEaT2p/0uokFCcsQPXU5voGd/ uysob1dEcfdaHy7gp6axmuWYKuaUmE/KTvbxHjyw1NiQLxOVgHMeNXwl0Lk5VVtfBky5 5D/IqhGl76u4vdeaeR8zpEylN1KanONRJf9IB97dsw2OPwfGNdQbAf44L7kaCSWY5T1t pYmamA/nqDxI6GYSIuerCT8RG6BzqMJrJy+G0NCelcuanGPg8nz/H9dCuzkNkt9K/qvF ZhpxJDcviTEcl0tAJ2Uvi9v8Ds1MpprAc04Yo0YBAOkFnDQ6m1HJC1hg5z14/cnAIiJ2 9qnQ== X-Forwarded-Encrypted: i=1; AJvYcCUx9lOsZv5MRCz8+iOXyBgJwBx4encmccTPfh7+BzbglPlb6XilvcLA5lrcgeKHfBqUXoK6hHO6ypUREA==@vger.kernel.org, AJvYcCVkMlOTwwQzyC6mStu/0rtmNs89IRKRhG55q1QQRlIvXi3yz4WfgCW08ZAZUY2DBD2BrNZQVqylOU6O@vger.kernel.org X-Gm-Message-State: AOJu0YwOBEzA6W/vxuUAh1r8uO/+AZ0GNvrTZ669AWNVRDUzYS9S4JD9 EuOKeK4u2cvKF8EeDhH76cDHyCuSXJPn1UISPRdUbmcrCp6WbOMJqCI6iB4XiA== X-Gm-Gg: ASbGnctZvqFo3IFQFJ/9zzSuse6GtiHI6X+Z4VbL+7Rj3CDefVJWEo0pF7ELJvWjvB/ GbV+18pc7x6dSx75SOCx/6J/E7u3IxNzGhDiIYCLTh4BJVgYJIrLr1MEmeSb2b0qeTi2wCCx1Nm Qvqeuu5V8W2AzFKa4qAi+Uc8BSi9C0iqeY91KrotbH6Vcqrguvb3WC4AAdPO5qxMNGZqJHUl2wi fE1cn9HJGNvltYq8NZlQwKLX8XBnNmt1lZQ4OdfPP6767Dbs2KFjKJEVvsyVWNXDrl7/JbGj2r7 8EYeFFD1T69IpiMPwQp+RRmCEwHm7xROX+sKgEgVeOjk5s+9veyF22gQ4Tk6ZRmenhPJHEXTP56 cmBlDF46vxElz6xx5/q6LRnl6ULpR6gAXbR3evs++Rae1lif4lia+jF4TaVpUraUb+/uPFtr8Kf k= X-Google-Smtp-Source: AGHT+IF6bU8SPLeBKOcF3DV0pz3IKcU2SprGWCJIgsDwHZ4utP76U3dUm2BhH0lDWIsPOTFAl0TAFQ== X-Received: by 2002:a17:903:2f8f:b0:234:b743:c7a4 with SMTP id d9443c01a7336-24944b19ea3mr233283115ad.38.1756925977585; Wed, 03 Sep 2025 11:59:37 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-249065ab343sm169403475ad.126.2025.09.03.11.59.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Sep 2025 11:59:36 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , linux-block@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-efi@vger.kernel.org, virtualization@lists.linux.dev, "Vishal Moola (Oracle)" , Justin Sanders , Jens Axboe , "Matthew Wilcox (Oracle)" Subject: [PATCH v3 2/7] aoe: Stop calling page_address() in free_page() Date: Wed, 3 Sep 2025 11:59:16 -0700 Message-ID: <20250903185921.1785167-3-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250903185921.1785167-1-vishal.moola@gmail.com> References: <20250903185921.1785167-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_page() should be used when we only have a virtual address. We should call __free_page() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) Reviewed-by: Matthew Wilcox (Oracle) Acked-by: Mike Rapoport (Microsoft) --- drivers/block/aoe/aoecmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index 6298f8e271e3..a9affb7c264d 100644 --- a/drivers/block/aoe/aoecmd.c +++ b/drivers/block/aoe/aoecmd.c @@ -1761,6 +1761,6 @@ aoecmd_exit(void) kfree(kts); kfree(ktiowq); =20 - free_page((unsigned long) page_address(empty_page)); + __free_page(empty_page); empty_page =3D NULL; } --=20 2.51.0 From nobody Fri Oct 3 07:39:23 2025 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F61636997A; Wed, 3 Sep 2025 18:59:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756925981; cv=none; b=u7pYaUZmcncigXJtMTwzZxQiY/KESpdpgdf9XpuuAsmAcNNrZIy0fL2IIEkQDHO79XtfA9iXpraDIeeGosqfJOLMXgK67BfxfH/nzz1Nijbxq4OUFbiLnwfyOmK1HYN3/z9HeRI2H1mOQSL8fGxR+g4VFa0vq6ArPySXM7V70xo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756925981; c=relaxed/simple; bh=tDJPTP0lhO5ivDTkZpNt7Rd4fQWnznv9kl6iZmQUTXw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Rxv841Ru1z1D1+aipUUg3z5NhleYjAEWnSskKs94n0+NuOTSQocwlCPr95vPgNWIXqJ3ldmYE7USXx8HVwkRcSzlDvdP9yVgJxtBj7X4a7ObgHK8bV2GnynXXmk3Gbmn1bhwQpCvsT4jTsOn+XTUuwFDZF17EPxRZVrUvUB2gfs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mHGxQC1Q; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mHGxQC1Q" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-24b2de2e427so2176565ad.2; Wed, 03 Sep 2025 11:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756925979; x=1757530779; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6wz/bZSqqVx6pRJeL2TZzvIUdrr6/vXiyt+C/9X3zJM=; b=mHGxQC1QnchszG0tFQ5r0hrjrgRv47IbCMa5fXoT/kKzpGrhQ3Gtvnp2/p/zZPGE+/ Lgix8s6VD7vGmMVTj5up26I8wTJIseg7rSZ3GtA7v+ExRB9Qf77WdZjODT0ByefzRhC5 0/g8MbtXyoey/bhmFPAaK57xaW6MuteGLeUOVA21Jzsts64raiukZBqc3PIKgExqfFeI smKCEDFT4MOhjUGsBJJvleB+S7l2ZqLaooORTwp1PZYmcD+12GUMMzSreD+e986JO6Mx ALg7WvUegoPwUJFYezATXZp60iV+RrZ9dY/eLelFDgCgXaOoOw3fOUrrbTuOn3RUsJm2 AVgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756925979; x=1757530779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6wz/bZSqqVx6pRJeL2TZzvIUdrr6/vXiyt+C/9X3zJM=; b=cFtMEIIgL9Be1nSASiPMVLl6TlJJbsMokMJY/WTgzQ/xxOy01OBOOUN2kp8ksYGvk0 znOUvdkIIVoCR7rmX8r0VxQHg5IRSnwjy27yJc30T9Ddk8KLu2xcgNzel3fzq2+UkdMY 1g+tnJswqOtZzNeMRz7ucM7bwVWcBtfWSpfM9sKHZLxxgbTKu7Qj2nJBalOmRWCJyJ5b IRppzBE5S/3lbyuSueMgQJgJ01zAg8IAkN3KU8R1qjhptajxB5Ct80O9NG747F2vDwS9 BtnfhmASfTbAC5ADygkFe8JHU3GZJuoeQwfyKsC2Mw9h1i1iibGqJCerI4tg7UQ08xlP QeiA== X-Forwarded-Encrypted: i=1; AJvYcCUEK+mXq0HhGSz9UFuA/LzlgAulY4ewG/XrrQVLSZgfAdC76GIkVH1dQVXeVuE+TRLeD64kBB37O0Kk@vger.kernel.org, AJvYcCXBssZrXc4woeUmZMhVd56V4uJCTSnhn2OTpbHkZJbmUcV0u6ZSqK7oTSL+OCaWiYo5qDcTDxMRH4lplg==@vger.kernel.org X-Gm-Message-State: AOJu0Yw7NSirHN4IKNG+buVYBLakVLt/1q9yGdWRBO08wmAUXiRgPNfG 8E1Faa+woDgqg54UlW+fcSn7AK0+xecXIUHEEX/vPf5gSQh0kpBGf/Bl X-Gm-Gg: ASbGncsMLWUgUhsE2WO5HBIEy97rc9bu/zEtg+C2KpuJamFAbJtoiR1r9g8kIvEK4Kw X8LcTcGi2fx8f1mobvnAWI/zaq4Caob8fL0uCZclnpdisZgEyfI5mqQXudiQgRPoAAuzLV4Mwfy UvcH2jM1iJ2GgKKABnfFZA7++KWaEllpd1MZKh5kIftajYyaR0BPmgvkfEw3T2X+MUCsKOEtzYN SKN79kbeNx4y2iWARpN0wCOAZbyb0oxzvb58cKJLg/WKolmM7DL7nb7mgUZQyNsfvf5gxxuq/C/ BLxrPIifCFtXIPiGDboHUpmTkqM6SMeRSypHGneS6RpAesyXFOE9ZPhb9dVxTolcBLxeC+/Yf5p c9fBfxQD39YPGn+quNydniCK+fXmpd15hJqUBxmHBMO/uxKqYSwwcWQ== X-Google-Smtp-Source: AGHT+IFLYxGq/uXWczWSmoJ4dYmB1R4jOWZAcKlvb1pf3KqvOH6hTCxx8eQlFrsP54M7TPt133nTbQ== X-Received: by 2002:a17:902:f789:b0:246:d383:3964 with SMTP id d9443c01a7336-249448ac3c8mr239306545ad.18.1756925979423; Wed, 03 Sep 2025 11:59:39 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-249065ab343sm169403475ad.126.2025.09.03.11.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Sep 2025 11:59:38 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , linux-block@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-efi@vger.kernel.org, virtualization@lists.linux.dev, "Vishal Moola (Oracle)" , Dave Hansen , Andy Lutomirski , Peter Zijlstra Subject: [PATCH v3 3/7] x86: Stop calling page_address() in free_pages() Date: Wed, 3 Sep 2025 11:59:17 -0700 Message-ID: <20250903185921.1785167-4-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250903185921.1785167-1-vishal.moola@gmail.com> References: <20250903185921.1785167-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_pages() should be used when we only have a virtual address. We should call __free_pages() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) Acked-by: Dave Hansen Acked-by: Mike Rapoport (Microsoft) --- arch/x86/mm/init_64.c | 2 +- arch/x86/platform/efi/memmap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index b9426fce5f3e..0e4270e20fad 100644 --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c @@ -1031,7 +1031,7 @@ static void __meminit free_pagetable(struct page *pag= e, int order) free_reserved_pages(page, nr_pages); #endif } else { - free_pages((unsigned long)page_address(page), order); + __free_pages(page, order); } } =20 diff --git a/arch/x86/platform/efi/memmap.c b/arch/x86/platform/efi/memmap.c index 061b8ecc71a1..023697c88910 100644 --- a/arch/x86/platform/efi/memmap.c +++ b/arch/x86/platform/efi/memmap.c @@ -42,7 +42,7 @@ void __init __efi_memmap_free(u64 phys, unsigned long siz= e, unsigned long flags) struct page *p =3D pfn_to_page(PHYS_PFN(phys)); unsigned int order =3D get_order(size); =20 - free_pages((unsigned long) page_address(p), order); + __free_pages(p, order); } } =20 --=20 2.51.0 From nobody Fri Oct 3 07:39:23 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2981B369997; Wed, 3 Sep 2025 18:59:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756925983; cv=none; b=JpMvmPGzVLmGW9C1hfx+66N1dKHvXbtxig5kcGTxqUp4qbArbckqFbkDW+oIrYzXUKmjNk7dOWDMe3/XakRsJbV4FAVO2mDPs+96vOEoHwqXkPq3WyqRN/2X/mj9YwxzNJJV9BikGnF26J/euTvCsJ2p29nJmb1HsmuObG8Yduo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756925983; c=relaxed/simple; bh=hMxsFCbfS4FNJ5KpQPQ814MUfYn5DLMes7LkACjORbM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BV9bG+Cf062mEbqkUeHd9Pb/4yL2VJ/lzO/X1kr3MTcq1yZQW1w4r1HlLULuKgRY1XPhLB7Gv5F1i9uaXbLW8iKBUD0KZn4/y29LcgSeFCGdCyr9+MqYR0YULGWuqzsHNiACq11UmGyGgdd3/nCqYhEGyvc0Qb6+FZClSszC8JE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fQ91TEKf; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fQ91TEKf" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-24b2de2e427so2176795ad.2; Wed, 03 Sep 2025 11:59:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756925981; x=1757530781; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tE4h8lAMatl8zOgx47ZsHYZprqFSGIay3bVnFsp5zpE=; b=fQ91TEKfREvSpboYaze1bALYi46Nf8iBiI9aMo9SPouVlVYMlKily/gFKAhiR+3qOh VJmFqI6SJqY5t7yqPn1/sYFBdGT/gRSnXxuO1G/wsjr2KyLt5CIMAD9+0KRhxBk2/edX k6LZzg1ELNL03EczVmc0OWP52kcIV9Fe8qiqED2qHiFTTGd4hryG5WjQLBubuUu1MWbM fZmAwo6kOxWnfzlxhRJfiD/lYeIgV/QwHvrrzWKFoswA9UUQtvP5D3XPDa+nx1BTg3fF d1zfMtcgEknsMQkyqrkc3tMNpKylFCO7P28VSpRVhK5/VWfMwv1X1b8inLxIlNTQdm7J KBDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756925981; x=1757530781; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tE4h8lAMatl8zOgx47ZsHYZprqFSGIay3bVnFsp5zpE=; b=frb2yk8YMtcmUdDi5Rdruq5XKYKOgbVpTpzPW6DvADtjSzWRCVuiZaK9vlDI0lYfbL 4ihyDoVoON8rhKnIOO3Je3Ml+zJ3iu8HE/E/E1CJwqAMprAXYSCdjqK7KPw9BiQ+G29b TLnln1JwrM4O41/FRl8kpykBZDWXCpsyp9qSASX4bDT6hY4eTUiWu3QtB8lgRVwJaI5b ET3IRwqpK+8ONd5cwFy0bsz6+aFhJ4Ejc1pVNsiHGKHOwjLOIeaEmRdbBlYAAM2XR0T9 53W6/QEgBTtFdZml7vTIuvqqungNcwRINmSN1Z9LRBa7Kb3QRe2gufc201dlLiwGKp6e WpJg== X-Forwarded-Encrypted: i=1; AJvYcCU+YaLxq7xSb2P6tzLhJhEu6Rl8q568FXhAVmVUu3x7XjEPyGh0X/bjyUMJELLbNzNFHA3VtjG6Hzmccg==@vger.kernel.org, AJvYcCWUd1NzWmtgw1AetwLN8RaPyeZbA9OSeupkCwNQevHjwDIaG/LTUl6pMGBdstxYYZ1zTI3EK57kBG6t@vger.kernel.org X-Gm-Message-State: AOJu0Yw2bMb0CzCn5EvOgedlHcmRD9w5TsgZ7zMKU3B37wbCd3rAW8Ko 1tubESGBq5J2VFZIOBC++QdUnIyc4aE/CJ764mvdgsxjOnzTzaFDIqvr X-Gm-Gg: ASbGncu+Rwo+iab4cuYtdPEyqCLcRSOP5ywLqAQAf6tRvda4zSKg67n4NN55rElvORN L8FHB7LAvrOc+Om2+r8WtjT/BYlbrGHwtRgRzxA8+3waZsNtBI1Y2SNoNcFQTclnhM0Zz/3VlKg mzB/lYdKx5U+ssGMCrYOE2W6N8jH3eJp3XYDOFwhwifv/JtwU61vkdbeYEJhOJ4a7Kx5Rj1ZRZ7 bxGjgHBmpLQ/p8sHFvge9rIM8ZWofospuWDaCvkompXGKRfTZdepjoxynLnj4G3Nzw/+4cmyaBS Sk/k5g2mM2vqyVPyKioXSkZEHAtNOIDWsMlZW+Km7sHRTW/vpp5e3Lk49ZZVbzWbx7BjkbYXIvN ZJ5oa+9GyqCq1C9XQvIpAiokk6w2iDB/kLKSSVoEwWfaKpgPB6w5/peYUSz2BrddH X-Google-Smtp-Source: AGHT+IFOzZVS9DP4L6Y226muKjeIB1JH5DNA05hxxzbj7ORa/S2amssbHzjMdMYqRSy3xMpxXA++JA== X-Received: by 2002:a17:902:cecc:b0:24a:aeb6:f1c8 with SMTP id d9443c01a7336-24aaeb6f63bmr166407785ad.43.1756925981346; Wed, 03 Sep 2025 11:59:41 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-249065ab343sm169403475ad.126.2025.09.03.11.59.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Sep 2025 11:59:40 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , linux-block@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-efi@vger.kernel.org, virtualization@lists.linux.dev, "Vishal Moola (Oracle)" , Paul Walmsley , Palmer Dabbelt , Albert Ou Subject: [PATCH v3 4/7] riscv: Stop calling page_address() in free_pages() Date: Wed, 3 Sep 2025 11:59:18 -0700 Message-ID: <20250903185921.1785167-5-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250903185921.1785167-1-vishal.moola@gmail.com> References: <20250903185921.1785167-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_pages() should be used when we only have a virtual address. We should call __free_pages() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) Acked-by: Alexandre Ghiti Acked-by: Mike Rapoport (Microsoft) --- arch/riscv/mm/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index 15683ae13fa5..1056c11d3251 100644 --- a/arch/riscv/mm/init.c +++ b/arch/riscv/mm/init.c @@ -1624,7 +1624,7 @@ static void __meminit free_pud_table(pud_t *pud_start= , p4d_t *p4d) if (PageReserved(page)) free_reserved_page(page); else - free_pages((unsigned long)page_address(page), 0); + __free_pages(page, 0); p4d_clear(p4d); } =20 @@ -1646,7 +1646,7 @@ static void __meminit free_vmemmap_storage(struct pag= e *page, size_t size, return; } =20 - free_pages((unsigned long)page_address(page), order); + __free_pages(page, order); } =20 static void __meminit remove_pte_mapping(pte_t *pte_base, unsigned long ad= dr, unsigned long end, --=20 2.51.0 From nobody Fri Oct 3 07:39:23 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAD2136C079; Wed, 3 Sep 2025 18:59:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756925985; cv=none; b=mUsW3T6Es+cefiS9nnOTxmPxraAQOQCOTpr2fGioPK7bHjC55MPLcy+EeDFBmE21N9jMH20QW/15swI7G0qGcZ4d6x8d6ulHT7ygtIEMMekjXG4fdocCS8rdxSsvjp/MuFhMyEOQspiIEJchPTV6t5l0/VSfrrTMuv0VLL7pUwA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756925985; c=relaxed/simple; bh=5/VIQ0YOJj8EBJYFM7fzqfbwO1JII3lxYWLpEwerupo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GLwlMnYfmhv3ZxXzl+HN7H6MUecEC2PxIu1TBSp5rfhw9XzSINuV4VZ1lCWflDCLHLZSMKDp0UtH8V30dmb+mYk6UA2V5OpiQEQvIwZueu1Lddy1aAUA4JOAVb/BiwOA9nGo9l6R6V5mf1gKtnp1KDUXAOPg1jTxuzITS/K+LXk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Je/eXn1s; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Je/eXn1s" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-248d5074ff7so9498375ad.0; Wed, 03 Sep 2025 11:59:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756925983; x=1757530783; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VXRq4apmEamZdvq2d1xSOZY75J3qH8SSfCfS4DJoIVY=; b=Je/eXn1sd7KCB/OSjhKDZCSW5Qi5y2nFFm5S7CrpzGkiMGXjA7uDlXArY+0bZ7pwfu iVyClehBrmD1NFxpBGxHKQkMgPDh9ZOY6QJej21b535p9LbsS442/Zm5trUT4k7dK/b3 ubH/PEzVZ1KCOCmp+lmNEvyWU8j0pRF5blOFuJ91ZDEGKd3GBX4sb26ErAarDQagvdC9 GEutwmyzsaCXGzg0WTegNDgzaJXqGZKccyEtlyvQi/XamguVPDKVFAuc5/OKugVcWOE0 5N5i1tSmvtWAIACxyvNQURKWVoJG1XDrXXOK6n6ngQlP6I3M9Bz/JIb5k7H5YxCcQQbD zxxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756925983; x=1757530783; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VXRq4apmEamZdvq2d1xSOZY75J3qH8SSfCfS4DJoIVY=; b=evYDg7mC5g/uLZnnkgHuXcMt3nufsGAf9pd7aaypMmtDw+YPU08B2syQk6bPyscBWr UMX+5QxMrNMGdGtYiYp4SntTUFfgcAueQTwLcyGzT5CsGFKS+FAH+RXnSvPkZ/iQPVzo hXLmEjAx3pQoR5mrhp5KCA6DZJummcXS+TVN3LUStpAn+xjhVkfswW3P5aRfqZxZ7q9Y pm58Xkvqp/2jgQ31DcKIh6t6aKfw9gaMuclLepM8w39wZmxo06wTliqj4ZdK/7EHkt4N jXfOeLFZYKulYeNKh3Q4HpSEEoE4+oADtUjnj1BifjRIqQyGgMK1wP6AjYSPHyHS2Ks7 rIbQ== X-Forwarded-Encrypted: i=1; AJvYcCXJJ4CG15x11DjMqxREcFQpxWS8RkWUqLO+8TXAValCHtYGucQHlMkRHPAqIaSgh7gok/uyIZ0C6ZbbpQ==@vger.kernel.org, AJvYcCXReZzDaq9bx9KbnbFD0iIHbd3wfNcfFe0zAYAh3NBMWwMyxaYb+1bJ6Zglg4okQcKM+aVLoEUSS1IR@vger.kernel.org X-Gm-Message-State: AOJu0YzzULMFU84vDIn3Ylp4cV9FIOTe6A1Ty3pEiYwbqrP5pVV7md9d +WNXPSS1SAdyG9HrT4p1OI/KKphoc2nqHSwGYSo7ULmmTvxjWy7Ejp3Z X-Gm-Gg: ASbGncs1SPn4VJEwHU4o99ds2zMDTNH7KzHn292SP2Kixs4MqZiMeXHNC/pLbVm1c6E ODdNWn0j4SsDy5oiLBJTljEYjeKSMReKvaYC/vKU0ueyQCmaetO7TU+Yg8hEJGyFa9aP0yAJkSd dBH2GIE3OOR1Bhe64ypC57XzhAqZfFI7lHJ0aZVYxeqFk+B89UnaCp6PcvDTT+GaTK8GpdySRQW wiACleh0Vi96D+pfUS+j4xUH1o97aU0EAQC+IU4pAg12OLL/vGdHLYtJr1DuY39N02U4fhk22K/ MXS4vgX1q0UnqrLuRArSVxP9a3If/ut3TAzpijw/VFkRfHksxZnMZk4C8i+1pPUycgg+4iDEKSV 4ZKY5/ZzP53MBjfusTTXmV2MAq57t2u202ZJOlyCtLScD6wAS8OvODkznRBuBhT+q5c5swxHxl0 g= X-Google-Smtp-Source: AGHT+IGnOdoMz4pWaL7qXoMT+R27TwnQ4+tCeRLJ9HFet8fs0efEGIfh6YbGSI9RHeToTjhpbJgt1A== X-Received: by 2002:a17:902:f688:b0:248:aa0d:bb22 with SMTP id d9443c01a7336-249446d2aa2mr226131105ad.0.1756925983252; Wed, 03 Sep 2025 11:59:43 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-249065ab343sm169403475ad.126.2025.09.03.11.59.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Sep 2025 11:59:42 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , linux-block@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-efi@vger.kernel.org, virtualization@lists.linux.dev, "Vishal Moola (Oracle)" , Madhavan Srinivasan , Michael Ellerman , "Ritesh Harjani (IBM)" Subject: [PATCH v3 5/7] powerpc: Stop calling page_address() in free_pages() Date: Wed, 3 Sep 2025 11:59:19 -0700 Message-ID: <20250903185921.1785167-6-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250903185921.1785167-1-vishal.moola@gmail.com> References: <20250903185921.1785167-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_pages() should be used when we only have a virtual address. We should call __free_pages() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) Reviewed-by: Ritesh Harjani (IBM) Acked-by: Mike Rapoport (Microsoft) Reviewed-by: Christophe Leroy --- arch/powerpc/mm/book3s64/radix_pgtable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/mm/book3s64/radix_pgtable.c b/arch/powerpc/mm/boo= k3s64/radix_pgtable.c index be523e5fe9c5..73977dbabcf2 100644 --- a/arch/powerpc/mm/book3s64/radix_pgtable.c +++ b/arch/powerpc/mm/book3s64/radix_pgtable.c @@ -780,7 +780,7 @@ static void __meminit free_vmemmap_pages(struct page *p= age, while (nr_pages--) free_reserved_page(page++); } else - free_pages((unsigned long)page_address(page), order); + __free_pages(page, order); } =20 static void __meminit remove_pte_table(pte_t *pte_start, unsigned long add= r, --=20 2.51.0 From nobody Fri Oct 3 07:39:23 2025 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A40B336C098; Wed, 3 Sep 2025 18:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756925987; cv=none; b=enw19+TjcrPytOxBiUd4BtRzQvX87m7P5CwPCI64d5lO5R8dYRMWtej2sIYEzJHYEvf6qonC4kITxvarFSHM+l9jGayNYwUPgvBGqCYyynZYkSwEHJe4iMlywmINXTlvPCZSnQ4CLbv+YsxnT4wZyWK1S1Y1C5iyrP1494+rMnw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756925987; c=relaxed/simple; bh=14eY//0sWN84Y1oOt0zSOd+CM/1+X56WmIombu10NEw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XkZm9WAe+zRv5issAI+2F0e/Uhfj7Oq3FpGOBcJklf3No/IY1bj8aUyjZfUlH7S89VRxuPO9Z68GJ+aFDMX1DYBtfmgYTeYOt3ipdbN+yVa8hbjlE40BtQraBjoQ/EWtqdqtd6LvR/n3vuV0I6tmxPwgJQ58YF+S7sKN8+Luj/w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RGPgWjwY; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RGPgWjwY" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7728a8862ccso514504b3a.0; Wed, 03 Sep 2025 11:59:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756925985; x=1757530785; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FA6weTM8vdilC/EIGooLzDUuRuJzTtRM53Ib1Pd9QnA=; b=RGPgWjwYx109SAY3AWLp35vmu0PWnSp0Iw/B6DH6rI6draaNLEfgjzQzzE98LiysrI vR3rBPgjG8QQvuLOthtDh+Jy73rIihlic8mAjxd6I4nzL4O2frPabYwFlZDjlefG0JK/ xmAZwx9DgDSp2TO5nQJU+qn0Lw+OZuGWbBMC3vTQGSCeBAZYENTr0ZukXt2sww3gKjvz zS9LNn7yH2ZuVuz70kXJa6HqoPFZNuXydQaTgSyKPAXuH4EbIT67AbnNiUCK8jguO7pa +MmcnHtyfg61gwjdEttv+sBNBtQSZLSwyE89s9bHJIRpBxtgdJnwu66gDB/Q4oICnXkR yZ2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756925985; x=1757530785; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FA6weTM8vdilC/EIGooLzDUuRuJzTtRM53Ib1Pd9QnA=; b=rWUkDZ1XBJ5LK5cyKSjPRpfiEKxfR5P2Pm8oszSDI0+MiZYZM4I7Kh2nL8HM89Ttr9 BoNl08CgLZgKGaOr3gxG0oqSOUJ4ena3SSbICnfb42E47F1RVHLyuP/FsIC3X2P/5PvV dSRlGofn9J7B+ZAM1g7yQI8fIwdVU64egkXUT4kcejCSwTP1stblmcid2QKz1lLSKR72 fpsvRYMzXKY+FoW71EIoxJirl3UBbCzik/JDMIEA42nESiKI0g7ePhxGDMPtGDIQ4yZW y2D22xL5b8kHvlSFNzOVXFQHrDufDroEmzT8EjaJ+9xFZWeq4Bzp+WCTGX2lASVFbtGj 7o+w== X-Forwarded-Encrypted: i=1; AJvYcCX9+rwf7CmoNfe72dglQcQIziSj4nxNTur5ijU0I9OY2tiFHK5F7dKnOXCSl4BOvbDBMPqTAIMVK338@vger.kernel.org, AJvYcCXAaRKgq04jyNExMLfs2F1iAY6OXmmkj2R6XX3qKhefv2yCRMoXmNcrW0Sp2Jzt8baOr/FudG8d0548iA==@vger.kernel.org X-Gm-Message-State: AOJu0YwgbfPdQzpfqUBz9CzYkmX29oUssnL++6axaaE2zBv3wWY+ifsn kZRDg6oXQJpWh7Nh0ivEES9G8IMnR+xsBc1I2HqWjJnN9Nx2j7aal4te0zkcVQ== X-Gm-Gg: ASbGncso46YcNNojhOYgfjUAgclk/e4pndiZGwplIzmme7ajr8Iq7VSr7hTRhr0K2y+ egmlbmQfXkooFO4fPHavBpNtFTRRSDNCZcl3aXm7s/zu/aPXWKoeTKic+VnzMA1xuwmG1ECvWue /N/9UqhV8wpiU08AaB2pZ/cSfxnzzh2A2ky47+XfAA5wbOrPosmpPyPnK93LQmjgT96+/ElHcII 4pTujILLDKAukW6Qp0ZEpnjqYdkcMQloEdeEKv/Env+wfr/X3wFf+EFV1Gs8Y+S9G86lqL5dP3G EAspLaqPPaEofXeL9Wsk3KS+InANj6QI6tSJS4M1UJm3QeIuxLeDSWFVrVCtAu2Cp6sJkWBXDDC EuqAWgTS+e6yENxDA8+rAeMX2Ox/X/wrc3fVthrBMlxGdAiM84WB2frbjAzFpFc+W X-Google-Smtp-Source: AGHT+IFoYEL3/2HJDWoKxsFsnkPmdjG5vBre6hTTnok3nMNP8kBMsMcFaEho42lHd4bWFQ52X19GJA== X-Received: by 2002:a17:902:d489:b0:240:5bf7:97ac with SMTP id d9443c01a7336-2493ef50b32mr219143675ad.16.1756925984962; Wed, 03 Sep 2025 11:59:44 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-249065ab343sm169403475ad.126.2025.09.03.11.59.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Sep 2025 11:59:44 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , linux-block@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-efi@vger.kernel.org, virtualization@lists.linux.dev, "Vishal Moola (Oracle)" , Catalin Marinas , Will Deacon Subject: [PATCH v3 6/7] arm64: Stop calling page_address() in free_pages() Date: Wed, 3 Sep 2025 11:59:20 -0700 Message-ID: <20250903185921.1785167-7-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250903185921.1785167-1-vishal.moola@gmail.com> References: <20250903185921.1785167-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_pages() should be used when we only have a virtual address. We should call __free_pages() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) Acked-by: Catalin Marinas Acked-by: Mike Rapoport (Microsoft) --- arch/arm64/mm/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index 34e5d78af076..e14a75d0dbd3 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -843,7 +843,7 @@ static void free_hotplug_page_range(struct page *page, = size_t size, vmem_altmap_free(altmap, size >> PAGE_SHIFT); } else { WARN_ON(PageReserved(page)); - free_pages((unsigned long)page_address(page), get_order(size)); + __free_pages(page, get_order(size)); } } =20 --=20 2.51.0 From nobody Fri Oct 3 07:39:23 2025 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A230C36CC85; Wed, 3 Sep 2025 18:59:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756925989; cv=none; b=uwrLtsAMC/TM+aTl9FD2jKRbaN2valjFztAy1iaJ/Uf5F7WO25S1vvO1hLWMB6ntvrl7r0r7HxO3t9v0YsPPYRMf09V49jlsNiJwJeFAgneH74hSFTOHPyruwdveUe830SKmcdWA6t94g4vI2VBrFAq6JSHfoJ0R5Aey+w1qcJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756925989; c=relaxed/simple; bh=9inLvC2KfY6Q8SKkB8WqxnCMttpVG+lmNs2hVN/EM80=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oVPC8/yWbQ2cB+pVaJUAflWjGNSGiAam4Spmo5O3rdKI+pnIrIpKEHKoYqDYKLUpkHkIal96VjVUkDWeh5F16pIww3GvAU/Dm5DqD47kz+2KEkEvpe0Bo6QvVGOLSaKg4GYkp17hNgVnyKmPB7wRBHXpfGd8Ko5Y0eB1Md1oRjQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jH5TZtlt; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jH5TZtlt" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-24cbd9d9f09so2648685ad.2; Wed, 03 Sep 2025 11:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756925987; x=1757530787; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4xP13CUGWmP4Epf7561SmRsYIMeFmCIW416h7MJfMP4=; b=jH5TZtltE3O0HqiVO1QeAg198hhNZjqdEt9nrl5sCyW5GOZGHrnfoPOAbV1rBcQY9r o5xxaYyg8TZdOlFsr83oLnDnvaly56yxV0ILpHgGBnoXO7bXKCIONmOfDObvaGrwKZTd a9KoUdQwY+ukYQMOq2un2QlLuQ/xZJqzGwyqDGJx4zRI4q9p/68sgKaCeryi9JSoOVz/ AeM9ksv8h8iNS+i0U/ApNQVJs3c1XHZxhMaRq8Ls9Xh6OSSY2mEkB5kSrXFvscpZeNbX XtPR/0O1Y1JzbZcX+xKkUehHJ3P8kZb4jYo1pTxkrpKVQD5kNcMbEIlliFBjUoDo0u7B 81XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756925987; x=1757530787; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4xP13CUGWmP4Epf7561SmRsYIMeFmCIW416h7MJfMP4=; b=KV2G/RTYV2JyCq0027bYSybFrG7F1zGo/T47KAc8xnlFEptfLatiODMhPgB3HrxnmI cCQLA3weZrTgH7xVzoJ7NSE6xcuClwwhXWzxIouiRCW++AXPI5Vj2ePeS4DS5T5n30SA Rs/2Gz1FuxkOitOBvfLYNqlOXwDPdj+0rWm2hCaPrzpqOYyC1fCkrc+RAn6clIeIxtdc AcXrkH0eGUB+yhmU1LlmDeWQiRLwuI/HWY8Em22a9fbzcCdptCBEq3drqwbnt6Egn3ZC 5JLgoFWW4USx4Tp0335EgBES3py/+10cRvuTKnidTCxVm4Mlbyn2ziH1zGJmT+LYdW2B zLIw== X-Forwarded-Encrypted: i=1; AJvYcCVGJpufZOa5HXPT0DJFqm4fpHSMdwwJecqRTuCL71S5V1yAanPLBQJsXZQDDcMcRSFUk9BuMnw6wdS0@vger.kernel.org, AJvYcCVwOYa8F9p1g6YWs8RO9xWfvErzNUZo2E8yNn4AHXSx+xd7XGCr1NFPZ23SR/e1/83rzeTWWCxZEvA4hw==@vger.kernel.org X-Gm-Message-State: AOJu0YxKQTE85XYEo2zrXn8uSkoXP+h7H8D8Izi+zCbnyt48nf8Oc2vh YY+eujersF4bERWTez/bixPeJTiRZziD28PlNKt7xNoqeS9V/CNhhIwX X-Gm-Gg: ASbGncuR9KY1bruuFovqn9jFSWdkB3f2L/UyqT6t2XFTV2zkC/ebw7i5QFsv+z1kdpB o+b+kGPKGPFiHKM3rC6g14fzAKRby4xtQeIaTuZ/0ZeEj0dxf2o8DO8y8Xvvs+MbJ9dINAq/k7S Xxh8dUIt7m3Q3/K+QvRE9r3E5owrCAxJdb9B6rFlWpQB24PiIfoTA4YFfD++ktGpHpRHO9o5WWf D9Y84nttKpe6BhS01WHw5jNLVbFyiTtpZ6QdXVAOhpgZhJqPRlrzzG1FiT5aN2JQr5Mn02WNjpC 8Yr9O491VioE0HuNNfX6Xir3LbFdbIadTHB6hxIumomAyd+NI43wjcaULhLkjWy6QCuVymJuzZV ZhQFq7K/pdVWzwltOAsrWYrRi+IHx3oqHN5ZGhpYULyj2WOXRTni73Tr7oYm9gDYK X-Google-Smtp-Source: AGHT+IGWl2NVhEd4Mf3PXgbO9PNmoIZrvx3puV/+d96WnhVgMh+tacbQQZaHLdVwJGJAzq5ejH+5QQ== X-Received: by 2002:a17:902:e5d0:b0:24b:1766:cc70 with SMTP id d9443c01a7336-24b1766d2d6mr89341175ad.39.1756925986861; Wed, 03 Sep 2025 11:59:46 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-249065ab343sm169403475ad.126.2025.09.03.11.59.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Sep 2025 11:59:46 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , linux-block@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-efi@vger.kernel.org, virtualization@lists.linux.dev, "Vishal Moola (Oracle)" , "Michael S. Tsirkin" , David Hildenbrand Subject: [PATCH v3 7/7] virtio_balloon: Stop calling page_address() in free_pages() Date: Wed, 3 Sep 2025 11:59:21 -0700 Message-ID: <20250903185921.1785167-8-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250903185921.1785167-1-vishal.moola@gmail.com> References: <20250903185921.1785167-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_pages() should be used when we only have a virtual address. We should call __free_pages() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) Acked-by: David Hildenbrand Acked-by: Michael S. Tsirkin Acked-by: Mike Rapoport (Microsoft) --- drivers/virtio/virtio_balloon.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloo= n.c index eae65136cdfb..7f3fd72678eb 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -488,8 +488,7 @@ static unsigned long return_free_pages_to_mm(struct vir= tio_balloon *vb, page =3D balloon_page_pop(&vb->free_page_list); if (!page) break; - free_pages((unsigned long)page_address(page), - VIRTIO_BALLOON_HINT_BLOCK_ORDER); + __free_pages(page, VIRTIO_BALLOON_HINT_BLOCK_ORDER); } vb->num_free_page_blocks -=3D num_returned; spin_unlock_irq(&vb->free_page_list_lock); @@ -719,8 +718,7 @@ static int get_free_page_and_send(struct virtio_balloon= *vb) if (vq->num_free > 1) { err =3D virtqueue_add_inbuf(vq, &sg, 1, p, GFP_KERNEL); if (unlikely(err)) { - free_pages((unsigned long)p, - VIRTIO_BALLOON_HINT_BLOCK_ORDER); + __free_pages(page, VIRTIO_BALLOON_HINT_BLOCK_ORDER); return err; } virtqueue_kick(vq); @@ -733,7 +731,7 @@ static int get_free_page_and_send(struct virtio_balloon= *vb) * The vq has no available entry to add this page block, so * just free it. */ - free_pages((unsigned long)p, VIRTIO_BALLOON_HINT_BLOCK_ORDER); + __free_pages(page, VIRTIO_BALLOON_HINT_BLOCK_ORDER); } =20 return 0; --=20 2.51.0