From nobody Fri Oct 3 08:50:25 2025 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBF292F0660 for ; Wed, 3 Sep 2025 08:30:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756888224; cv=none; b=b8D6jzyOsLe4eMk7ap2KzPzbknWRE+hjOH2kXl2RQRAgcB7it6roZD4rXk7HbIpHwgr7r9G9fg287/yp2WB6XJsKK8A+P9nK4L5/sGCftsoe1b7vlfj/P0YYXMReTY8PcY00YuFjryKFjqftrOkYtYmjDi6MKt0lz3mMbRZ/GYQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756888224; c=relaxed/simple; bh=J7D8vkknewXqwkovzKpka5NJnRXgTW5zFlPuneM7dDU=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=JeiJCHnGg3+hvTAzA4iRyNKzc6lU1FKh+VE6PVhUl2P+Y5+ZtUagUmEwndo2SOITvLcUayJXmeKeNJRICowJ+HRm3HvtDfnsjX4iqJCtW5iZOCNPASgoA1ioqQ5UopS5WIgGA1zEP7dUEpUZoNnoxcg1pGue4IPNx5GmtoZR28g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--khtsai.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=wGgpsHhs; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--khtsai.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="wGgpsHhs" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-7723aca1cbcso3692928b3a.2 for ; Wed, 03 Sep 2025 01:30:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1756888221; x=1757493021; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=fZ7j4se1Omhr/Y7LdW2hY2HsKoJ4kz8N5/Bot5alqdA=; b=wGgpsHhs/AAs+WRw2RMf2DptuKUzWc5iMC6jUS0Bd+kG0c5FiyNKsWb3MCQP6xhIUs kB5Tq6ZFCvpu2Pd0coFOUFtNUKYevlwGjr7q5utyQg3x6z/MmY8qvZrp21Lv5SAWdoVb T9b1Y8oQv0eBtGc77QYH1YxyR6dza3S8AoqrQsJRV3+rdTiqkx1GiUn0Nkfcnxph0F97 a7LH4P1Nr5sCAW37DH8ALZqnqQq9ypi5l2ig+kOcqX08LMjJCyRKg+Ck3toNNRfa7wdI J0HmzWDWU+xU3KPVPxmaDUYStmYZSU0jZTWjyCz1hFgfmvieUuPZUjCaJqXFhpYYPRqe T3rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756888221; x=1757493021; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fZ7j4se1Omhr/Y7LdW2hY2HsKoJ4kz8N5/Bot5alqdA=; b=L3Pcf8ny2Y++0VzqgT2JDai8caIvU3j0is83VHwnm5QSh/OKmbEbFM0XSsNi7BBMV5 KRUf0o+EW7aLniEcxTNJdMROLqE9V1qG80eqdb8vFXce1ruYoRazPoSxItQx4ioI1QQj 64YcGwYIozeDG7yj1ThY+zfwVG8dO8dDnzl14pxVJtQzcCb7NAXplweN+oHVOKNjKHOJ PODTK1A0Uo+qgJeUSHvl2bHNbRHjkY84XWfK0NM8X2YStyDDVM+oNWJ9EtMkhGFxwnZ1 EzUhs5vQsBDGILOXIhopmpoiFOhJcxIwUiSwFOTcttEO8rH0KFPM0AGDfv20SEk+FCey WnHw== X-Forwarded-Encrypted: i=1; AJvYcCWIqhX8KmjAQKIWJ2ZZsUcLAPGa3IXZjy18DmowhnirKBmTsvbW4LJmPDYAFqdeC8ECSEG1JpTOsFFxGug=@vger.kernel.org X-Gm-Message-State: AOJu0YxR1LFREHk09bHrfeHYJuOqnc+L+w3+7X5DObJn2WJgVJFQDssR j6wJUOyzmmadUIpV9o5N7IsJsNwFLuO1eDpGjSnXMb4FUiYvu8vZtwYtcDX9ntbRUOZp0IXNnTc bMIB2sg== X-Google-Smtp-Source: AGHT+IECGuG1JyAn+Ycl/1sS/E1Ss4Sbu1q9s8gA4JBtg9nO2+7Bii+IPow+/Sx/8UVzVCE5KsxatOfFfD8= X-Received: from pfbk6.prod.google.com ([2002:a05:6a00:b006:b0:772:3d03:c274]) (user=khtsai job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:10d4:b0:772:84eb:bbf with SMTP id d2e1a72fcca58-77284eb1ce4mr811643b3a.9.1756888221062; Wed, 03 Sep 2025 01:30:21 -0700 (PDT) Date: Wed, 3 Sep 2025 16:30:12 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.51.0.338.gd7d06c2dae-goog Message-ID: <20250903083017.795065-1-khtsai@google.com> Subject: [PATCH] usb: gadget: f_ecm: Fix ecm_opts->bound logic in bind path From: Kuen-Han Tsai To: gregkh@linuxfoundation.org, krzysztof.kozlowski@linaro.org, prashanth.k@oss.qualcomm.com, Thinh.Nguyen@synopsys.com, s.hauer@pengutronix.de Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kuen-Han Tsai , stable@kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The bound flag in ecm_opts is being set to true even if gether_register_netdev() failed. Set ecm_opts->bound to true only upon success. Fixes: d65e6b6e884a ("usb: gadget: f_ecm: Always set current gadget in ecm_= bind()") Cc: stable@kernel.org Signed-off-by: Kuen-Han Tsai --- drivers/usb/gadget/function/f_ecm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_ecm.c b/drivers/usb/gadget/funct= ion/f_ecm.c index 027226325039..9f5ed6f32a62 100644 --- a/drivers/usb/gadget/function/f_ecm.c +++ b/drivers/usb/gadget/function/f_ecm.c @@ -690,13 +690,14 @@ ecm_bind(struct usb_configuration *c, struct usb_func= tion *f) =20 if (!ecm_opts->bound) { status =3D gether_register_netdev(ecm_opts->net); - ecm_opts->bound =3D true; } =20 mutex_unlock(&ecm_opts->lock); if (status) return status; =20 + ecm_opts->bound =3D true; + ecm_string_defs[1].s =3D ecm->ethaddr; =20 us =3D usb_gstrings_attach(cdev, ecm_strings, --=20 2.51.0.338.gd7d06c2dae-goog