From nobody Fri Oct 3 08:51:16 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 725B9270572 for ; Wed, 3 Sep 2025 13:06:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756904787; cv=none; b=MKUnUTrSLL6HX3hPoW0Ro639/xswzVV7eagoBaN7eU0ld0hCjabD572uxvBdWOYxPr46t7iLJifS5c5em6Jg9GkNERyqbhUMahw+/77Itk+Ivdb+DkRwHry55s1COu4382HGoBQLXc6HHRqnmoBbZEk5DT6IXC3C00ppCmuLNvU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756904787; c=relaxed/simple; bh=tQSJBiKibb4DJjgBw5ixcANjVU0K2CDPdBXgX70RmkQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q4RoUgTsU526yn4uWdzdv8WBV4kz1PcXEYASn4cKjBR5uFOh8HjH+OoLTfq1HPPJ0A17RBdSCXWEgOLryyK151MwoXMnEg5laijWd/C+7xs3DVcfIcicFA5XJJLwVjXGPtxaYgMVTMO5lkq3OA4+L3nForHsIE7bTRh1UTc4Kz0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1utnBl-00006Z-MM; Wed, 03 Sep 2025 15:06:13 +0200 From: Marco Felsch Date: Wed, 03 Sep 2025 15:06:11 +0200 Subject: [PATCH 03/11] dmaengine: imx-sdma: cosmetic cleanup Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250903-v6-16-topic-sdma-v1-3-ac7bab629e8b@pengutronix.de> References: <20250903-v6-16-topic-sdma-v1-0-ac7bab629e8b@pengutronix.de> In-Reply-To: <20250903-v6-16-topic-sdma-v1-0-ac7bab629e8b@pengutronix.de> To: Vinod Koul , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jiada Wang Cc: dmaengine@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Marco Felsch X-Mailer: b4 0.14.2 X-SA-Exim-Connect-IP: 2a0a:edc0:0:1101:1d::28 X-SA-Exim-Mail-From: m.felsch@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Make use of local struct device pointer to not dereference the platform_device pointer everytime. Signed-off-by: Marco Felsch Reviewed-by: Frank Li --- drivers/dma/imx-sdma.c | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 422086632d3445b2ce3f2e5df9b2130174a311e8..a85739d279f51fdb517fce90b3d= c67673cf2b56c 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -2234,7 +2234,8 @@ static struct dma_chan *sdma_xlate(struct of_phandle_= args *dma_spec, =20 static int sdma_probe(struct platform_device *pdev) { - struct device_node *np =3D pdev->dev.of_node; + struct device *dev =3D &pdev->dev; + struct device_node *np =3D dev->of_node; struct device_node *spba_bus; const char *fw_name; int ret; @@ -2244,18 +2245,18 @@ static int sdma_probe(struct platform_device *pdev) struct sdma_engine *sdma; s32 *saddr_arr; =20 - ret =3D dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); + ret =3D dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(32)); if (ret) return ret; =20 - sdma =3D devm_kzalloc(&pdev->dev, sizeof(*sdma), GFP_KERNEL); + sdma =3D devm_kzalloc(dev, sizeof(*sdma), GFP_KERNEL); if (!sdma) return -ENOMEM; =20 spin_lock_init(&sdma->channel_0_lock); =20 - sdma->dev =3D &pdev->dev; - sdma->drvdata =3D of_device_get_match_data(sdma->dev); + sdma->dev =3D dev; + sdma->drvdata =3D of_device_get_match_data(dev); =20 irq =3D platform_get_irq(pdev, 0); if (irq < 0) @@ -2265,11 +2266,11 @@ static int sdma_probe(struct platform_device *pdev) if (IS_ERR(sdma->regs)) return PTR_ERR(sdma->regs); =20 - sdma->clk_ipg =3D devm_clk_get(&pdev->dev, "ipg"); + sdma->clk_ipg =3D devm_clk_get(dev, "ipg"); if (IS_ERR(sdma->clk_ipg)) return PTR_ERR(sdma->clk_ipg); =20 - sdma->clk_ahb =3D devm_clk_get(&pdev->dev, "ahb"); + sdma->clk_ahb =3D devm_clk_get(dev, "ahb"); if (IS_ERR(sdma->clk_ahb)) return PTR_ERR(sdma->clk_ahb); =20 @@ -2281,8 +2282,8 @@ static int sdma_probe(struct platform_device *pdev) if (ret) goto err_clk; =20 - ret =3D devm_request_irq(&pdev->dev, irq, sdma_int_handler, 0, - dev_name(&pdev->dev), sdma); + ret =3D devm_request_irq(dev, irq, sdma_int_handler, 0, + dev_name(dev), sdma); if (ret) goto err_irq; =20 @@ -2327,7 +2328,7 @@ static int sdma_probe(struct platform_device *pdev) =20 sdma->iram_pool =3D of_gen_pool_get(np, "iram", 0); if (sdma->iram_pool) - dev_info(&pdev->dev, "alloc bd from iram.\n"); + dev_info(dev, "alloc bd from iram.\n"); =20 ret =3D sdma_init(sdma); if (ret) @@ -2340,7 +2341,7 @@ static int sdma_probe(struct platform_device *pdev) if (sdma->drvdata->script_addrs) sdma_add_scripts(sdma, sdma->drvdata->script_addrs); =20 - sdma->dma_device.dev =3D &pdev->dev; + sdma->dma_device.dev =3D dev; =20 sdma->dma_device.device_alloc_chan_resources =3D sdma_alloc_chan_resource= s; sdma->dma_device.device_free_chan_resources =3D sdma_free_chan_resources; @@ -2363,13 +2364,13 @@ static int sdma_probe(struct platform_device *pdev) =20 ret =3D dma_async_device_register(&sdma->dma_device); if (ret) { - dev_err(&pdev->dev, "unable to register\n"); + dev_err(dev, "unable to register\n"); goto err_init; } =20 ret =3D of_dma_controller_register(np, sdma_xlate, sdma); if (ret) { - dev_err(&pdev->dev, "failed to register controller\n"); + dev_err(dev, "failed to register controller\n"); goto err_register; } =20 @@ -2389,11 +2390,11 @@ static int sdma_probe(struct platform_device *pdev) ret =3D of_property_read_string(np, "fsl,sdma-ram-script-name", &fw_name); if (ret) { - dev_warn(&pdev->dev, "failed to get firmware name\n"); + dev_warn(dev, "failed to get firmware name\n"); } else { ret =3D sdma_get_firmware(sdma, fw_name); if (ret) - dev_warn(&pdev->dev, "failed to get firmware from device tree\n"); + dev_warn(dev, "failed to get firmware from device tree\n"); } =20 return 0; --=20 2.47.2