From nobody Fri Oct 3 07:40:24 2025 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F56C22B8C5 for ; Wed, 3 Sep 2025 15:15:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756912549; cv=none; b=mHGgRxOEpgWVB12RESewO4PiWJ0FY+A1hQ3t/YX28iH7DaoL1m042HosWRZLT3+8Xkez9ObL9OsdD6jE9U8cAfQSmgq/OLs+D8z33kiWv3zTm5H1aCV1fcBfdtvaw0+k4okNEW7kTKk+rqI1B7atdCmEGZkEYZx4yRCsOjjQ4pk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756912549; c=relaxed/simple; bh=oB6YH9stGXXmyWf9fU6U+hcPYGMIbxOjTtbnKUQ/AME=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tccsYfUOPXSGnmCARJXfXPBsF0qDj+H2swnMKqlRToS7v6He8x3pv0oXYmWj0o3Fkawy6xJzRKVf3AEkew54iXCB+SAAGY+oMTgO6ET+LCgesI37jY9RJmG/RHVEUR0zUjz8nxQzSwjNxPlRuGEmiBOoubraNXlSSmf9KwXiuRo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qvjxV+lb; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qvjxV+lb" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-45cb6d8f42cso478255e9.1 for ; Wed, 03 Sep 2025 08:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756912545; x=1757517345; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ETVP+OvG5GLGu2xaJRcK8WzZ71eqDw1aBK23tnlVu0U=; b=qvjxV+lbOJi9x7MxnhjaFUV2Lv25/li2a2aW7BvtnLw8mk1PGrdH8zCwM7PEvnMNp4 7xOSfl23Seq+dLQY1gSziABSfG2RkG8kPFF+kv4edOoXM8xcsLXMZwhhyA3M5xIdaFOT iWqhRD9aGaDhRHduAXNSPCa0uUz4m9WbJQP7mzTJp5eudUiZjMw3MIPwO2FSG7EM3lzI S4jwFoEiusmHq6fQlogrgqg1HPHnnGG+W5WFCOs/GkzCeIjxGaL4Hp6/NN5gZ7b9rcTs c3xe16oUT2Y2gndzz1Qd1f6LJh0jdkQOeVvxOBh4Da70Qgc0HLJcgMfUYdUR2ujpiHy5 0M/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756912545; x=1757517345; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ETVP+OvG5GLGu2xaJRcK8WzZ71eqDw1aBK23tnlVu0U=; b=G0jR9jk8wFQjRRe4D1BA6IBtU4lQZ2jxYM3fvET5Z5hdP5TwHoX/Sua9lomWjST27x 75lp5YJjUsW3qH7hBi8hoxXaaMk1GiK+SNGG9vs/Umstagz3yvaRQv4WoBCGwxjJG+8i vec2oMYPCpKlKtxwY15wKWGB9avpQLb8GFF4cnlAtQNwSCzoAavP/Tdd6RLz6C9NwvLq 1/d/RpuI+3ofACIQu/UgEP07t/hv15n4cxjwu5VOCikpiUiP3+yQ9xFHzHnVBumOvfeP LG/dT9+pwK/2vQytEyymPkshRMvWmr2V5tBnDmdVPDqO0rVw8YRgWsroOGMfIKRyVCk6 B5wA== X-Forwarded-Encrypted: i=1; AJvYcCVY19MISInoS7PjfsclzvPVGa/LNTd4V+7EW1u9NONdUaBf1gRkf95EBFYC02+4d3gDYuIudWUjbJryxfI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2HDCeUhsb11oMY0iqIJSQ22Zj6tZpGJKQIblRvbWK22acnouJ JxLKHcw2hSM8uvijZdtHcAF//tAkOOZ4/k0uQ/3HREMBQQ8pZFQsHXReK+cROOndn6A= X-Gm-Gg: ASbGncu53V7slsfIF5POHppMsJ022jj4VRd5Rzup1JpSwuqoljvUZK3v/VlDsQQtgf0 XmEcrrC3fUO9C6P4gcQQYUbgQxz4TLR4dVelQvTOGFfih/dICmVVMPbb3EVRM+DrRH4YvDyJjfx td+Y2UTpAipBy3imOg7oBl4eLVNGkiOXZmniZoD07N2WanmZ45+q6QcNW1X24jMAocOTv53OxEy HvufrIilIM6y0AQQ+HcFJOuHx+QNIfiiynZTC2CmVHItDTigDWRtPnXQaTfndY+ZsrzZbPcspOJ zo2L4g87d0lZMoVYSFqNvrdLVCB7sMO8Qfl5VT9QGGm9AJ902Ox8+DGSPnYBMzYe9Dg0G03fanS q1B8fwTGaRTAYOBw98+BVqcz/TODzuKPWR29LQINHUg== X-Google-Smtp-Source: AGHT+IGQx37RL3c+ClyXLKbsQA1OFjTpe2lVkHyoUBOyO2DmfYjczXJvj3+g+jXr/QP+2ORQGmopGQ== X-Received: by 2002:a05:600c:1384:b0:45b:7b00:c129 with SMTP id 5b1f17b1804b1-45b8558d694mr136409375e9.35.1756912545579; Wed, 03 Sep 2025 08:15:45 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3d0f85c287fsm22090097f8f.52.2025.09.03.08.15.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Sep 2025 08:15:45 -0700 (PDT) From: James Clark Date: Wed, 03 Sep 2025 16:15:26 +0100 Subject: [PATCH 1/2] perf tests: Fix "PE file support" test build Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250903-james-perf-read-build-id-fix-v1-1-6a694d0a980f@linaro.org> References: <20250903-james-perf-read-build-id-fix-v1-0-6a694d0a980f@linaro.org> In-Reply-To: <20250903-james-perf-read-build-id-fix-v1-0-6a694d0a980f@linaro.org> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Leo Yan Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, James Clark X-Mailer: b4 0.14.0 filename__read_build_id() now takes a blocking/non-blocking argument. The original behavior of filename__read_build_id() was blocking so add block=3Dtrue to fix the build. Fixes: 2c369d91d093 ("perf symbol: Add blocking argument to filename__read_= build_id") Signed-off-by: James Clark Reviewed-by: Arnaldo Carvalho de Melo Reviewed-by: Ian Rogers --- tools/perf/tests/pe-file-parsing.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/tests/pe-file-parsing.c b/tools/perf/tests/pe-file-= parsing.c index 30c7da79e109..8b31d1d05f90 100644 --- a/tools/perf/tests/pe-file-parsing.c +++ b/tools/perf/tests/pe-file-parsing.c @@ -37,7 +37,7 @@ static int run_dir(const char *d) size_t idx; =20 scnprintf(filename, PATH_MAX, "%s/pe-file.exe", d); - ret =3D filename__read_build_id(filename, &bid); + ret =3D filename__read_build_id(filename, &bid, /*block=3D*/true); TEST_ASSERT_VAL("Failed to read build_id", ret =3D=3D sizeof(expect_build_id)); TEST_ASSERT_VAL("Wrong build_id", !memcmp(bid.data, expect_build_id, @@ -49,7 +49,7 @@ static int run_dir(const char *d) !strcmp(debuglink, expect_debuglink)); =20 scnprintf(debugfile, PATH_MAX, "%s/%s", d, debuglink); - ret =3D filename__read_build_id(debugfile, &bid); + ret =3D filename__read_build_id(debugfile, &bid, /*block=3D*/true); TEST_ASSERT_VAL("Failed to read debug file build_id", ret =3D=3D sizeof(expect_build_id)); TEST_ASSERT_VAL("Wrong build_id", !memcmp(bid.data, expect_build_id, --=20 2.34.1 From nobody Fri Oct 3 07:40:24 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4698023F412 for ; Wed, 3 Sep 2025 15:15:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756912550; cv=none; b=LrIWefJ+EIjIbausC6aabGMJrV6t16QePuWjuON5FSR0tcAtSyq/TGqhPDCqOb+Ppc6fF8bW7GBd8Ibhe7bCXewD9XJ0mrv7bV9aqrFRlPj0JVAIS1PBxBNJ8Hgvugbks28OWsz0Gw66+7CP0FyZ3TnSTJaeYHsSXt16iY5mMVE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756912550; c=relaxed/simple; bh=l5JR3+UPUEJ2ClCwj8ex+lrVpnlr8I65tG5mWXGoWUU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SwJROpJhoNXhgVPgoZS9GSdKs/NrgtwzCCKjUaUxIwqb5uYOMLJ6H+Ur2RUxeS8bjLIrPRDBtw8OHW8cKpxMp5dmmosPFAvYDJZhEnyy1F9f0i5MSvi+1p4jvUeVUxV7qItCQpbJcPrzaSSB8vwJMSj4tXqcvHB3cWCFfCpbqds= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GA1sAcT3; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GA1sAcT3" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-45b9814efbcso8250185e9.0 for ; Wed, 03 Sep 2025 08:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756912547; x=1757517347; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fMR5sXuAMQlcJIniIrDARobJ0FFiLjcpiPVUSqhd9zk=; b=GA1sAcT3ccTSs2srYyACOmN28J7qbl1PHVLGf5113S5hPo3R8/WgzMjHTylDPyiwMR rXfTB2/8D/BILYR2lmdC6QjBTH8eIGuQUvgXknfsMDL9fPXnqaBZtEfqMP6gAvcZmQSD Q45srAuWBQ58+9i0LLLRlXy3M6McU96jtu32VAEHmHeEvId0UsG0QNC1Xcap+v0S5FvF DckdgkdZ8Iv0dAjpiio2SHoOsGUCeAinyoNoImuvRJs9E9aqPRanWOTAD1wIVmKH08Qf mWUZED9dbwXbrk481LjVZXs+gkJpZdYxbDiv1BTFQeHS5b3FBG+swqkWHE6/IGna9PPe ICEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756912547; x=1757517347; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fMR5sXuAMQlcJIniIrDARobJ0FFiLjcpiPVUSqhd9zk=; b=n4a/9WV7Ui3n/jUA+P6AJ2vOQ8nApS+gChs/GSn4Kvy+Fr6BJ/hQ4ouJkGICo7GKOW C3S3Ff3VMPvtckphyb+jgfd1T7tYafSDsJ4YY1SzoOwyN9nHe030lVhKMiqzmJG3BGqZ iLul0LFiWtWi1tULs31dLP+Nves2uDFysh5UWcc50ifI9QSWj3RoZif+z6I37EfA2Peu pY4XwrDLhISnd/OafbGV/pUjt71gm8ovlZ91ZZkkDaVCXTr0IMsIWkRs0UVAgnsuuNIE ailznqr3hBVtQMoH0h7LUSIVGOSyGGahxr3bwpbfkFUeH0UQFUZBm1HhiASW9P/ugvYs 5uNw== X-Forwarded-Encrypted: i=1; AJvYcCWsGYljjRmRnmGcqzNyekq9CiHd+hJffUcCnRzPAv4PUjGsw1FxxtCo7mKr/Dx3i7jXQ4tjBb3XsR2m/bU=@vger.kernel.org X-Gm-Message-State: AOJu0YxGwC5liGwsJ/MbW+kZ+9KAohlJqLQXNHiP/w5Swf/95DYD5swb Ab8nqqw6bXyM9bj2mzAf0eNLePRtJCed11olJqfduS93PFVioLkUcZVz3OiZwgHytzUhBdhnKvV vvgX3LrI= X-Gm-Gg: ASbGncur329g+zvDoix5NXezaxiU1Qdbh1/QyLZmdzAMfZ4ixnyjygWzKdq2MTpLKh3 0yjLBWy1eCq45A9Nsv0esP5NhFnoipuakMvrRDTLogkvU6g71etcSqXPQbXlbNqpLVI0Ad06TGv 8ndKPJpnHOMHcswiFCvUWlVuzjlCgyYrmfWBmUc1mpkgO4hjxKOVp8YT6Z6qBwDVq62fXUFlspH VWDbPZmHThjMV3F/CVoPr44wMLeZ31jDzMemUsNFfBZUZdLA36PysSaaChdKucmlV43swSTAdjK N7KQl30kCqWDS9CtDevI5gj+ca/eK8Hvkk4AnzmChsVcM1dk5AO2E0U5Jyo3qgFv+hZsnQH6q9b 1Ph34g6yAh8D/9x91U5fAAHy4zY5Y5BeiwIs2pBYGtQ== X-Google-Smtp-Source: AGHT+IGqmlvtcSgBojPlbYZQhWtD2pJ/2FpKNNBsSoYyGicnvhdImai5K6SAb/1Au4J2gguwRAbk9g== X-Received: by 2002:a05:600c:648a:b0:45c:b523:5a09 with SMTP id 5b1f17b1804b1-45cb5235bfbmr28123975e9.16.1756912546581; Wed, 03 Sep 2025 08:15:46 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3d0f85c287fsm22090097f8f.52.2025.09.03.08.15.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Sep 2025 08:15:46 -0700 (PDT) From: James Clark Date: Wed, 03 Sep 2025 16:15:27 +0100 Subject: [PATCH 2/2] perf symbols: Fix HAVE_LIBBFD_BUILDID_SUPPORT build Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250903-james-perf-read-build-id-fix-v1-2-6a694d0a980f@linaro.org> References: <20250903-james-perf-read-build-id-fix-v1-0-6a694d0a980f@linaro.org> In-Reply-To: <20250903-james-perf-read-build-id-fix-v1-0-6a694d0a980f@linaro.org> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Leo Yan Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, James Clark X-Mailer: b4 0.14.0 read_build_id() now has a blocking argument, but libbfd uses fopen() internally which doesn't support O_NONBLOCK. Fix the build by adding the argument and ignoring it: util/symbol-elf.c:964:8: error: too many arguments to function =E2=80=98r= ead_build_id=E2=80=99 964 | err =3D read_build_id(filename, bid, block); Fixes: 2c369d91d093 ("perf symbol: Add blocking argument to filename__read_= build_id") Signed-off-by: James Clark Reviewed-by: Arnaldo Carvalho de Melo --- tools/perf/util/symbol-elf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c index 033c79231a54..e0d6ff7d0acf 100644 --- a/tools/perf/util/symbol-elf.c +++ b/tools/perf/util/symbol-elf.c @@ -873,7 +873,8 @@ static int elf_read_build_id(Elf *elf, void *bf, size_t= size) =20 #ifdef HAVE_LIBBFD_BUILDID_SUPPORT =20 -static int read_build_id(const char *filename, struct build_id *bid) +static int read_build_id(const char *filename, struct build_id *bid, + bool block __maybe_unused) { size_t size =3D sizeof(bid->data); int err =3D -1; --=20 2.34.1