From nobody Fri Oct 3 10:10:14 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AEFF2ED872; Wed, 3 Sep 2025 08:52:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756889524; cv=none; b=H08PNv/NrC+eGemXAqmy/GsWB2q2na3crR2AI76mxkm4uwN+YyW+KXeCQzXD07dN8YbDZ0+c2Hwc7MygS4/Y8K0Rve/LjfWOA01c6lOn6O6106FWqQEY/HAFOpwD06sDr1rcM7nViSP4RnMBt6S3b5uOi7tgpfIhgDyb+PTWLTQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756889524; c=relaxed/simple; bh=7GXiF2puI9MV0ynLrL3LnDqqLVjv4d6zMPfx4ftHtlY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=k1HeTRonQFYBE8qfDZWJ3r+Zf1+DVflc9u2/APTViftECoBhuK+lKZp1yTLL0W8VV4r7DEBrCRfU6R4Y/iHZA+c/2zqfSrlYj1O7k3D/oA99NMaWQ9YhwTc+TVHLdtdyAQmQ6VgaQ+Ehuh9sZ+8P9QZPJuT+hbt4ASBCkFPgjJM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eExnSCPS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eExnSCPS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAFF9C4CEF7; Wed, 3 Sep 2025 08:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756889524; bh=7GXiF2puI9MV0ynLrL3LnDqqLVjv4d6zMPfx4ftHtlY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=eExnSCPS8E7604a8VyaZRFqnxeBnFkum0U3zluEyMBdUAcXIXxkHDoIPyzzjiPlUV NkoRKZv7s7VlrCSRMrCgdiM9Scx8J3HU7mYEIuzGzSN8IntrAUXV9zXzGhtE7UxjMZ QBxGu+QY5aay14czh3Qk6i8kbdTV/ChwpbK5HVJJH3AduyNcQxQTQKsPVLe3pJ3Ypc kR9oRaTSMDLcZVJykGxzW/Aj/zyycOwQWNdgsEOs2YScf+Oe2Zq8GhBbP5xLPK9O3v YAfrl2yejPCyQA2HUXwc6XV/QjYurMG17aczEgzgU9NSYyhSl2PW1jQm2JeTGRQlcR Il+EiZZPed7Gw== From: Vincent Mailhol Date: Wed, 03 Sep 2025 17:50:02 +0900 Subject: [PATCH 03/21] can: netlink: document which symbols are FD specific Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250903-canxl-netlink-prep-v1-3-904bd6037cd9@kernel.org> References: <20250903-canxl-netlink-prep-v1-0-904bd6037cd9@kernel.org> In-Reply-To: <20250903-canxl-netlink-prep-v1-0-904bd6037cd9@kernel.org> To: Marc Kleine-Budde , Oliver Hartkopp Cc: Vincent Mailhol , =?utf-8?q?St=C3=A9phane_Grosjean?= , Robert Nawrath , Minh Le , Duy Nguyen , linux-can@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2346; i=mailhol@kernel.org; h=from:subject:message-id; bh=7GXiF2puI9MV0ynLrL3LnDqqLVjv4d6zMPfx4ftHtlY=; b=owGbwMvMwCV2McXO4Xp97WbG02pJDBk7GCvjV2s6Xnj96GDskbRYnmWiclJeVqeEMmrvx5xvu N9w879yRykLgxgXg6yYIsuyck5uhY5C77BDfy1h5rAygQxh4OIUgInMWsnIMPHSlVundgmyneNZ 5KC25/STOafb9r1ZF7L0iZ5lbf3PiE2MDLuFVyYU2SvW/nW7UWyWOUfQ+u6Wf6Gtj2L0JjC3eyT 8YwAA X-Developer-Key: i=mailhol@kernel.org; a=openpgp; fpr=ED8F700574E67F20E574E8E2AB5FEB886DBB99C2 The CAN XL netlink interface will also have data bitrate and TDC parameters. The current FD parameters do not have a prefix in their names to differentiate them. Because the netlink interface is part of the UAPI, it is unfortunately not feasible to rename the existing symbols to add an FD_ prefix. The best alternative is to add a comment for each of the symbols to notify the reader of which parts are CAN FD specific. While at it, fix a typo: transiver -> transceiver. Signed-off-by: Vincent Mailhol --- include/uapi/linux/can/netlink.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/uapi/linux/can/netlink.h b/include/uapi/linux/can/netl= ink.h index 02ec32d694742a32b3a51ff8c33616e109cef9f4..ef62f56eaaefda9f2fb39345776= a483734682cd0 100644 --- a/include/uapi/linux/can/netlink.h +++ b/include/uapi/linux/can/netlink.h @@ -101,8 +101,8 @@ struct can_ctrlmode { #define CAN_CTRLMODE_PRESUME_ACK 0x40 /* Ignore missing CAN ACKs */ #define CAN_CTRLMODE_FD_NON_ISO 0x80 /* CAN FD in non-ISO mode */ #define CAN_CTRLMODE_CC_LEN8_DLC 0x100 /* Classic CAN DLC option */ -#define CAN_CTRLMODE_TDC_AUTO 0x200 /* CAN transiver automatically calcul= ates TDCV */ -#define CAN_CTRLMODE_TDC_MANUAL 0x400 /* TDCV is manually set up by user = */ +#define CAN_CTRLMODE_TDC_AUTO 0x200 /* FD transceiver automatically calcu= lates TDCV */ +#define CAN_CTRLMODE_TDC_MANUAL 0x400 /* FD TDCV is manually set up by us= er */ =20 /* * CAN device statistics @@ -129,14 +129,14 @@ enum { IFLA_CAN_RESTART_MS, IFLA_CAN_RESTART, IFLA_CAN_BERR_COUNTER, - IFLA_CAN_DATA_BITTIMING, - IFLA_CAN_DATA_BITTIMING_CONST, + IFLA_CAN_DATA_BITTIMING, /* FD */ + IFLA_CAN_DATA_BITTIMING_CONST, /* FD */ IFLA_CAN_TERMINATION, IFLA_CAN_TERMINATION_CONST, IFLA_CAN_BITRATE_CONST, - IFLA_CAN_DATA_BITRATE_CONST, + IFLA_CAN_DATA_BITRATE_CONST, /* FD */ IFLA_CAN_BITRATE_MAX, - IFLA_CAN_TDC, + IFLA_CAN_TDC, /* FD */ IFLA_CAN_CTRLMODE_EXT, =20 /* add new constants above here */ @@ -145,7 +145,7 @@ enum { }; =20 /* - * CAN FD Transmitter Delay Compensation (TDC) + * CAN FD/XL Transmitter Delay Compensation (TDC) * * Please refer to struct can_tdc_const and can_tdc in * include/linux/can/bittiming.h for further details. --=20 2.49.1