From nobody Fri Oct 3 10:13:14 2025 Received: from mail1.fiberby.net (mail1.fiberby.net [193.104.135.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D457324B07; Tue, 2 Sep 2025 15:47:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.104.135.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756828026; cv=none; b=UVHjbwSUwjsmN61jIss5XrfmIp8xrJqm9jDJA49Opja18EdqCpUWnJIpNgtGqWbRZRSyANDGoTxwLnH+pkSf/vwHF7T589sBYLRDwERG0ZSWGSAerPWS6jqyuzeFTSKiuMswyQNoZL0Muhrie7mfnXAF/g9ia1Uvabl0R3ZK19g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756828026; c=relaxed/simple; bh=Gl9gajoVLzxJmnc1ePJC2X6wmSn5VMF8xSjXsX/13sY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FrmOevqC8vxwg2Cgr3qDhdFYUKHrCG54pmC6JaMQRr2gZuw1pDDbMNn37r1wVVIcVPdfTxbJK2bsP3aiEqrL93I6PYzVJSVjWKc8GI8y01a4WFBJUrH+9P2dzM6loINLBrbfCWLRQBo0/JomZCflHRDC92Jrg050VlB0+7vt2gM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net; spf=pass smtp.mailfrom=fiberby.net; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b=LM6SfkCk; arc=none smtp.client-ip=193.104.135.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fiberby.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b="LM6SfkCk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiberby.net; s=202008; t=1756828014; bh=Gl9gajoVLzxJmnc1ePJC2X6wmSn5VMF8xSjXsX/13sY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LM6SfkCknppZarc359u1pKKMp5FVG/mXGK49GkIr6bOMvk7w9PsJg6y4+l5yPR1kb pgxz8Q7eW12zv+Kzj6zHFTMqy0BTlESPvCF2PH6h3+KNawzByb4QUd9nwQWcscr+mf l85SXavvWQ6vvb0aPSha8m6iP2KDllBlIC+rvR7VWvw6GJdzw9MWc7+PKcBFf7Q8PV I4313zfPaIpsIuFSK4ECG0OUtyK+qPWGv7ZNr9FHQwqJt/gDOlPz4nFWz61w7Phyrl Prk0p+8JnTkab+3r9ftMe59P2A+BNiaDhTjfse0x0rK2q60yrk3A4tdNDdViQWarkV CpRsph9HtmTYg== Received: from x201s (193-104-135-243.ip4.fiberby.net [193.104.135.243]) by mail1.fiberby.net (Postfix) with ESMTPSA id 42FC0600C4; Tue, 2 Sep 2025 15:46:53 +0000 (UTC) Received: by x201s (Postfix, from userid 1000) id E2F0F20226D; Tue, 02 Sep 2025 15:46:42 +0000 (UTC) From: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= , Donald Hunter , Simon Horman , Jacob Keller , "Matthieu Baerts (NGI0)" , David Ahern , Chuck Lever , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 1/3] netlink: specs: fou: change local-v6/peer-v6 check Date: Tue, 2 Sep 2025 15:46:35 +0000 Message-ID: <20250902154640.759815-2-ast@fiberby.net> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250902154640.759815-1-ast@fiberby.net> References: <20250902154640.759815-1-ast@fiberby.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable While updating the binary min-len implementation, I noticed that the only user, should AFAICT be using exact-len instead. In net/ipv4/fou_core.c FOU_ATTR_LOCAL_V6 and FOU_ATTR_PEER_V6 are only used for singular IPv6 addresses, and there are AFAICT no known implementations trying to send more, it therefore appears safe to change it to an exact-len policy. This patch therefore changes the local-v6/peer-v6 attributes to use an exact-len check, instead of a min-len check. Signed-off-by: Asbj=C3=B8rn Sloth T=C3=B8nnesen Reviewed-by: Donald Hunter --- Documentation/netlink/specs/fou.yaml | 4 ++-- net/ipv4/fou_nl.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/netlink/specs/fou.yaml b/Documentation/netlink/s= pecs/fou.yaml index 57735726262ec..8e7974ec453fc 100644 --- a/Documentation/netlink/specs/fou.yaml +++ b/Documentation/netlink/specs/fou.yaml @@ -52,7 +52,7 @@ attribute-sets: name: local-v6 type: binary checks: - min-len: 16 + exact-len: 16 - name: peer-v4 type: u32 @@ -60,7 +60,7 @@ attribute-sets: name: peer-v6 type: binary checks: - min-len: 16 + exact-len: 16 - name: peer-port type: u16 diff --git a/net/ipv4/fou_nl.c b/net/ipv4/fou_nl.c index 3d9614609b2d3..506260b4a4dc2 100644 --- a/net/ipv4/fou_nl.c +++ b/net/ipv4/fou_nl.c @@ -18,9 +18,9 @@ const struct nla_policy fou_nl_policy[FOU_ATTR_IFINDEX + = 1] =3D { [FOU_ATTR_TYPE] =3D { .type =3D NLA_U8, }, [FOU_ATTR_REMCSUM_NOPARTIAL] =3D { .type =3D NLA_FLAG, }, [FOU_ATTR_LOCAL_V4] =3D { .type =3D NLA_U32, }, - [FOU_ATTR_LOCAL_V6] =3D { .len =3D 16, }, + [FOU_ATTR_LOCAL_V6] =3D NLA_POLICY_EXACT_LEN(16), [FOU_ATTR_PEER_V4] =3D { .type =3D NLA_U32, }, - [FOU_ATTR_PEER_V6] =3D { .len =3D 16, }, + [FOU_ATTR_PEER_V6] =3D NLA_POLICY_EXACT_LEN(16), [FOU_ATTR_PEER_PORT] =3D { .type =3D NLA_BE16, }, [FOU_ATTR_IFINDEX] =3D { .type =3D NLA_S32, }, }; --=20 2.50.1 From nobody Fri Oct 3 10:13:14 2025 Received: from mail1.fiberby.net (mail1.fiberby.net [193.104.135.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D2DC31CA71; Tue, 2 Sep 2025 15:47:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.104.135.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756828025; cv=none; b=XFDRft4TMREv68DNCgKvm/UkzbcGurOFQrETLz6OSDZ95xkWNFc12+CLrF/jGkKzxm0I0w94n6bhTq+AVd4UiTNQOQcscgrA+HSPUV/L5g71SHjGwuA/VG4L6SDXQq9Zr4wyLYloorEwJkRHA29qgCYilSTy9YM3LWjqr5kwLRY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756828025; c=relaxed/simple; bh=TPnFZUBGeSXm8HCq9Hzlib3MMWZuwcxYMJUCusHWaC8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GrTJB18bzeQebgkjdoYaL6FOFNQ7JO5SsGy50o+bTMZ7AuXJ4dWulN8Mw5pB0IUeWMWiKvZjzSz3bjVd/yZKqcEJjXNx8O0QM7QI7IK2vWgt/tqn6nXcl7YTLVQga653EQpxXV1XiriZJyETNKb+9kaWBMpiZDuuxsLLEcB3gCs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net; spf=pass smtp.mailfrom=fiberby.net; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b=ALc4rqaH; arc=none smtp.client-ip=193.104.135.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fiberby.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b="ALc4rqaH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiberby.net; s=202008; t=1756828014; bh=TPnFZUBGeSXm8HCq9Hzlib3MMWZuwcxYMJUCusHWaC8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ALc4rqaHiJoiZM9QbljX3AgIEKkb8XknReBjOAzaEnEkRwQDFIxVNB7XS4I8S87yS oBZg+SDdT+IT6yDKYsul7Swa2AFZcRieYsdGeX300gJsBhql/Uzus3+XJj68jCqCCb B6YUCI2P3l05aWtFixnBqagfcIF4hQgYH4bKf1ZBkbJxBfmU5UxSTzt39Aa2SCsq3L u+8FjPfhGNkE24bdqXUs/FmDUcC55hPIr6g+dqX8/bjKKy1ntZ/lWDUtzBcEhkKmId ZU9XXN54sZ5MD2FXTYGIUSwSluhAp5V0Qaqq0/5sKy4+i92yn1dGujmEEd0Y3ohE+D Wma8mxlkFloog== Received: from x201s (193-104-135-243.ip4.fiberby.net [193.104.135.243]) by mail1.fiberby.net (Postfix) with ESMTPSA id 452E560128; Tue, 2 Sep 2025 15:46:53 +0000 (UTC) Received: by x201s (Postfix, from userid 1000) id 70314202271; Tue, 02 Sep 2025 15:46:43 +0000 (UTC) From: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= , Donald Hunter , Simon Horman , Jacob Keller , "Matthieu Baerts (NGI0)" , David Ahern , Chuck Lever , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 2/3] tools: ynl-gen: use macro for binary min-len check Date: Tue, 2 Sep 2025 15:46:36 +0000 Message-ID: <20250902154640.759815-3-ast@fiberby.net> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250902154640.759815-1-ast@fiberby.net> References: <20250902154640.759815-1-ast@fiberby.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This patch changes the generated min-len check for binary attributes to use the NLA_POLICY_MIN_LEN() macro, thereby the generated code supports strict policy validation. With this change TypeBinary will always generate a NLA_BINARY attribute policy. This doesn't change any currently generated code, as it isn't used in any specs currently used for generating code. Signed-off-by: Asbj=C3=B8rn Sloth T=C3=B8nnesen Reviewed-by: Donald Hunter --- tools/net/ynl/pyynl/ynl_gen_c.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/net/ynl/pyynl/ynl_gen_c.py b/tools/net/ynl/pyynl/ynl_gen= _c.py index ef032e17fec44..52f955ed84a7f 100755 --- a/tools/net/ynl/pyynl/ynl_gen_c.py +++ b/tools/net/ynl/pyynl/ynl_gen_c.py @@ -556,7 +556,7 @@ class TypeBinary(Type): elif 'exact-len' in self.checks: mem =3D 'NLA_POLICY_EXACT_LEN(' + self.get_limit_str('exact-le= n') + ')' elif 'min-len' in self.checks: - mem =3D '{ .len =3D ' + self.get_limit_str('min-len') + ', }' + mem =3D 'NLA_POLICY_MIN_LEN(' + self.get_limit_str('min-len') = + ')' elif 'max-len' in self.checks: mem =3D 'NLA_POLICY_MAX_LEN(' + self.get_limit_str('max-len') = + ')' =20 --=20 2.50.1 From nobody Fri Oct 3 10:13:14 2025 Received: from mail1.fiberby.net (mail1.fiberby.net [193.104.135.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D373320CA0; Tue, 2 Sep 2025 15:47:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.104.135.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756828026; cv=none; b=h264pXg+omDLHaEgS6nUi7sKDrkTasHgJkjdvDrEkf0MxdhOIrRJnd2R1jwUV8+EsXxA80Oebpbd/6wAsDHI5sLQlCk6OBb20FYQxxWqIuftZ2sLndy/m0YdLpDvH4IgZAQaszseBSr+SQNy5q+DI+sRlZ8gFtd1LUldU1ik7Ak= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756828026; c=relaxed/simple; bh=2Oj3GeVuGicmnBhIw4fVSO0Bo0tkKjrFOupsr2XCeSw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mSWefx6UOLNFFBxTMuXkxUl1bWo5DajVjpMJ5kijNtx4zjr6/yQXFecZZfM1RuKfhslVcNIFfAGcOj/S2LLikTZXrAcWXwR6H8HlMzylUvVEDZ7FArmdWDx44sFwk0PQGjh9SRuTt31jR51dZezJk2xFyXq+Nw7h4sSyDbMOHOw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net; spf=pass smtp.mailfrom=fiberby.net; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b=fmX9XELa; arc=none smtp.client-ip=193.104.135.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fiberby.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b="fmX9XELa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiberby.net; s=202008; t=1756828014; bh=2Oj3GeVuGicmnBhIw4fVSO0Bo0tkKjrFOupsr2XCeSw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fmX9XELaqBQdxCQ+VVMzKyHYuz+pwU0ZJ/Cb8JQaO2uFuQ1nGTIJKQu5vG7xV1cuS A+sdqtGTGc5GKDPqWsPYmv9veekidtE0Ulrn0WdOp9w0+bZJTAbzo3xSUeVB/dMC77 CR9T/vuhor1sK0Hpztp+H2mlgQm+1My+oxHqLPvo7qMMlwozmx6/a/G+iMiCwztVc7 12BeFKIwOBnVKytFCB8wp7KxUqtMqZMS2ao94gW5LvdFJKZdWj5K3FtPpZswOiaQpu E6xrrQQP9j+B8pRZv1QGmhriaS1iq0YdN2F9HrWL87esQmiIJx2jOMriEUhIOF3fCf xrElpTpegb38w== Received: from x201s (193-104-135-243.ip4.fiberby.net [193.104.135.243]) by mail1.fiberby.net (Postfix) with ESMTPSA id 4744A6012E; Tue, 2 Sep 2025 15:46:53 +0000 (UTC) Received: by x201s (Postfix, from userid 1000) id 03C372022B0; Tue, 02 Sep 2025 15:46:44 +0000 (UTC) From: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= , Donald Hunter , Simon Horman , Jacob Keller , "Matthieu Baerts (NGI0)" , David Ahern , Chuck Lever , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 3/3] genetlink: fix typo in comment Date: Tue, 2 Sep 2025 15:46:37 +0000 Message-ID: <20250902154640.759815-4-ast@fiberby.net> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250902154640.759815-1-ast@fiberby.net> References: <20250902154640.759815-1-ast@fiberby.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable In this context "not that ..." should properly be "note that ...". Signed-off-by: Asbj=C3=B8rn Sloth T=C3=B8nnesen Reviewed-by: Donald Hunter --- include/net/genetlink.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/genetlink.h b/include/net/genetlink.h index a03d567658328..7b84f2cef8b1f 100644 --- a/include/net/genetlink.h +++ b/include/net/genetlink.h @@ -62,7 +62,7 @@ struct genl_info; * @small_ops: the small-struct operations supported by this family * @n_small_ops: number of small-struct operations supported by this family * @split_ops: the split do/dump form of operation definition - * @n_split_ops: number of entries in @split_ops, not that with split do/d= ump + * @n_split_ops: number of entries in @split_ops, note that with split do/= dump * ops the number of entries is not the same as number of commands * @sock_priv_size: the size of per-socket private memory * @sock_priv_init: the per-socket private memory initializer --=20 2.50.1