From nobody Fri Oct 3 12:26:32 2025 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [160.30.148.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76D2F6FC3; Tue, 2 Sep 2025 02:04:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=160.30.148.34 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756778654; cv=none; b=Si/j9gwbCkCjrPhp/Kl8p5SPDHGpP6tactMwDail4OIBOl/gKgS8LJUwLSOtaHagT9wCIkTAMqpnkQq5JxrCZ5r41OFEwfJL0BtNIivJbfXNIcUabPsNDxiiP2x7JkuFyUTE5afz1lcNouDZgrEGCjdbIEkyiVMgBAk1F6scTBM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756778654; c=relaxed/simple; bh=yVkDJCBoZhjmkInVYNZZwsUydbWhTQzviNY/ujQT5r4=; h=Date:Message-ID:In-Reply-To:References:Mime-Version:From:To:Cc: Subject:Content-Type; b=R8UblIVWuhd4g8XLK2h/gONNRVW/D+MfEt976kWrQWtI0OLhSRqgbOOizGNIAaV9G1z/aNCEjO6jNWegDy6bTWvpQ4EInG25Ph7F2+a1lpIrV2mS+qm/VvoKPQU8AcCB/yjbKAfbzXKORaYsGW1bqQsSQI6IDuN1NQ6jPBbO+n8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn; spf=pass smtp.mailfrom=zte.com.cn; arc=none smtp.client-ip=160.30.148.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zte.com.cn Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4cG8Dn0VVHz5PM3D; Tue, 02 Sep 2025 10:04:09 +0800 (CST) Received: from xaxapp05.zte.com.cn ([10.99.98.109]) by mse-fl1.zte.com.cn with SMTP id 58223qi4051390; Tue, 2 Sep 2025 10:03:52 +0800 (+08) (envelope-from fan.yu9@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid32; Tue, 2 Sep 2025 10:03:53 +0800 (CST) Date: Tue, 2 Sep 2025 10:03:53 +0800 (CST) X-Zmail-TransId: 2af968b65089775-7732f X-Mailer: Zmail v1.0 Message-ID: <20250902100353835xyAecL45pVFk1sbaC16f4@zte.com.cn> In-Reply-To: <202509020957458514CMgUiaqPjTURNET_d-w0@zte.com.cn> References: 202509020957458514CMgUiaqPjTURNET_d-w0@zte.com.cn Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 From: To: , Cc: , , , , , Subject: =?UTF-8?B?W1BBVENIIGxpbnV4LW5leHQgMi8zXSB0b29scy9kZWxheXRvcDogYWRkIGZsZXhpYmxlIHNvcnRpbmcgYnkgZGVsYXkgZmllbGQ=?= X-MAIL: mse-fl1.zte.com.cn 58223qi4051390 X-TLS: YES X-SPF-DOMAIN: zte.com.cn X-ENVELOPE-SENDER: fan.yu9@zte.com.cn X-SPF: None X-SOURCE-IP: 10.5.228.132 unknown Tue, 02 Sep 2025 10:04:09 +0800 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 68B65099.000/4cG8Dn0VVHz5PM3D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Fan Yu The delaytop tool only supported sorting by CPU delay, which limited its usefulness when users needed to identify bottlenecks in other subsystems. Users had no way to sort processes by IO, memory, or other delay types to quickly pinpoint specific performance issues. Add -s/--sort option to allow sorting by different delay types: 1) Basic modes: cpu, io, irq, mem =20 2) Detailed modes (-M required): swap, reclaim, thrashing, compact, wpcopy Users can now quickly identify bottlenecks in specific subsystems by sorting processes by the relevant delay metric. Signed-off-by: Fan Yu Reviewed-by: xu xin --- tools/accounting/delaytop.c | 130 +++++++++++++++++++++++++++++++++--- 1 file changed, 121 insertions(+), 9 deletions(-) diff --git a/tools/accounting/delaytop.c b/tools/accounting/delaytop.c index f1e2e1cca4b8..39852cd70bdf 100644 --- a/tools/accounting/delaytop.c +++ b/tools/accounting/delaytop.c @@ -173,7 +173,9 @@ static void usage(void) " -o, --once Display once and exit\n" " -p, --pid=3DPID Monitor only the specified PID\n" " -C, --container=3DPATH Monitor the container at specified cgroup p= ath\n" - " -M, --memverbose Display memory detailed information\n"); + " -M, --memverbose Display memory detailed information\n" + " -s, --sort=3DFIELD Sort by delay field (default: cpu)\n" + " Types: cpu|io|irq|mem|swap|reclaim|thrashing|= compact|wpcopy\n"); exit(0); } @@ -188,6 +190,7 @@ static void parse_args(int argc, char **argv) {"pid", required_argument, 0, 'p'}, {"once", no_argument, 0, 'o'}, {"processes", required_argument, 0, 'P'}, + {"sort", required_argument, 0, 's'}, {"container", required_argument, 0, 'C'}, {"memverbose", no_argument, 0, 'M'}, {0, 0, 0, 0} @@ -206,7 +209,7 @@ static void parse_args(int argc, char **argv) while (1) { int option_index =3D 0; - c =3D getopt_long(argc, argv, "hd:n:p:oP:C:M", long_options, &option_ind= ex); + c =3D getopt_long(argc, argv, "hd:n:p:oP:C:Ms:", long_options, &option_i= ndex); if (c =3D=3D -1) break; @@ -256,11 +259,53 @@ static void parse_args(int argc, char **argv) case 'M': cfg.mem_verbose_mode =3D 1; break; + case 's': + if (strlen(optarg) =3D=3D 0) { + fprintf(stderr, "Error: empty sort field\n"); + exit(1); + } + + if (strncmp(optarg, "cpu", 3) =3D=3D 0) + cfg.sort_field =3D 'c'; + else if (strncmp(optarg, "io", 2) =3D=3D 0) + cfg.sort_field =3D 'i'; + else if (strncmp(optarg, "irq", 3) =3D=3D 0) + cfg.sort_field =3D 'q'; + else if (strncmp(optarg, "mem", 3) =3D=3D 0) + cfg.sort_field =3D 'm'; + else if (strncmp(optarg, "swap", 4) =3D=3D 0) + cfg.sort_field =3D 's'; + else if (strncmp(optarg, "reclaim", 7) =3D=3D 0) + cfg.sort_field =3D 'r'; + else if (strncmp(optarg, "thrashing", 9) =3D=3D 0) + cfg.sort_field =3D 't'; + else if (strncmp(optarg, "compact", 7) =3D=3D 0) + cfg.sort_field =3D 'p'; + else if (strncmp(optarg, "wpcopy", 7) =3D=3D 0) + cfg.sort_field =3D 'w'; + else { + fprintf(stderr, "Error: invalid sort field\n"); + fprintf(stderr, "Try to use cpu|io|irq|mem|"); + fprintf(stderr, "swap|reclaim|thrashing|compact|wpcopy\n"); + exit(1); + } + break; default: fprintf(stderr, "Try 'delaytop --help' for more information.\n"); exit(1); } } + + /* Validate sorting field compatibility with memory verbose mode */ + if (cfg.mem_verbose_mode =3D=3D 0 && + cfg.sort_field =3D=3D 's' || + cfg.sort_field =3D=3D 'r' || + cfg.sort_field =3D=3D 't' || + cfg.sort_field =3D=3D 'p' || + cfg.sort_field =3D=3D 'w') { + fprintf(stderr, "Error: mem verbose mode is off, try to use -M\n"); + exit(1); + } } /* Create a raw netlink socket and bind */ @@ -621,12 +666,77 @@ static int compare_tasks(const void *a, const void *b) case 'c': /* CPU */ avg1 =3D average_ms(t1->cpu_delay_total, t1->cpu_count); avg2 =3D average_ms(t2->cpu_delay_total, t2->cpu_count); - if (avg1 !=3D avg2) - return avg2 > avg1 ? 1 : -1; - return t2->cpu_delay_total > t1->cpu_delay_total ? 1 : -1; + break; + case 'i': /* IO */ + avg1 =3D average_ms(t1->blkio_delay_total, t1->blkio_count); + avg2 =3D average_ms(t2->blkio_delay_total, t2->blkio_count); + break; + case 'q': /* IRQ */ + avg1 =3D average_ms(t1->irq_delay_total, t1->irq_count); + avg2 =3D average_ms(t2->irq_delay_total, t2->irq_count); + break; + case 'm': /* MEM(total) */ + avg1 =3D average_ms(task_total_mem_delay(t1), task_total_mem_count(t1)); + avg2 =3D average_ms(task_total_mem_delay(t2), task_total_mem_count(t2)); + break; + /* Memory detailed display mode */ + case 's': /* swapin (SWAP) */ + avg1 =3D average_ms(t1->swapin_delay_total, t1->swapin_count); + avg2 =3D average_ms(t2->swapin_delay_total, t2->swapin_count); + break; + case 'r': /* freepages (RCL) */ + avg1 =3D average_ms(t1->freepages_delay_total, t1->freepages_count); + avg2 =3D average_ms(t2->freepages_delay_total, t2->freepages_count); + break; + case 't': /* thrashing (THR) */ + avg1 =3D average_ms(t1->thrashing_delay_total, t1->thrashing_count); + avg2 =3D average_ms(t2->thrashing_delay_total, t2->thrashing_count); + break; + case 'p': /* compact (CMP) */ + avg1 =3D average_ms(t1->compact_delay_total, t1->compact_count); + avg2 =3D average_ms(t2->compact_delay_total, t2->compact_count); + break; + case 'w': /* wpcopy (WP) */ + avg1 =3D average_ms(t1->wpcopy_delay_total, t1->wpcopy_count); + avg2 =3D average_ms(t2->wpcopy_delay_total, t2->wpcopy_count); + break; + default: + avg1 =3D average_ms(t1->cpu_delay_total, t1->cpu_count); + avg2 =3D average_ms(t2->cpu_delay_total, t2->cpu_count); + break; + } + + if (avg1 !=3D avg2) + return avg2 > avg1 ? 1 : -1; + + return 0; +} +static const char *get_sort_field(char sort_field) +{ + switch (sort_field) { + case 'c': + return "CPU"; + case 'i': + return "IO"; + case 'q': + return "IRQ"; + /* MEM(total) */ + case 'm': + return "MEM"; + /* Memory detailed display mode */ + case 's': + return "SWAP"; + case 'r': + return "RCL"; + case 't': + return "THR"; + case 'p': + return "CMP"; + case 'w': + return "WP"; default: - return t2->cpu_delay_total > t1->cpu_delay_total ? 1 : -1; + return "UNKNOWN"; /* handle error */ } } @@ -705,6 +815,7 @@ static void display_results(void) { time_t now =3D time(NULL); struct tm *tm_now =3D localtime(&now); + const char *sort_field; FILE *out =3D stdout; char timestamp[32]; bool suc =3D true; @@ -766,8 +877,10 @@ static void display_results(void) container_stats.nr_stopped, container_stats.nr_uninterruptible, container_stats.nr_io_wait); } - suc &=3D BOOL_FPRINT(out, "Top %d processes (sorted by CPU delay):\n", - cfg.max_processes); + + /* Task delay output */ + suc &=3D BOOL_FPRINT(out, "Top %d processes (sorted by %s delay):\n", + cfg.max_processes, get_sort_field(cfg.sort_field)); suc &=3D BOOL_FPRINT(out, "%8s %8s %-17s", "PID", "TGID", "COMMAND"); if (!cfg.mem_verbose_mode) { @@ -787,7 +900,6 @@ static void display_results(void) suc &=3D BOOL_FPRINT(out, "-------------------------\n"); } - count =3D task_count < cfg.max_processes ? task_count : cfg.max_processes; for (i =3D 0; i < count; i++) { --=20 2.25.1