From nobody Fri Oct 3 10:13:21 2025 Received: from sendmail.purelymail.com (sendmail.purelymail.com [34.202.193.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 116E92E8DF5 for ; Tue, 2 Sep 2025 21:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=34.202.193.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756847855; cv=none; b=T6Sa9f9pxEFysuT0o94qvevoBOd513JUyYF5CACPzwGVIKePvsxdb+9FwR/cbkEBU4KThEch/kbfSwMgx301x5+8NbH+oUEnhUx7fDWk4EuIag11/HYW5Fx+vSpQOr3yhFNoYy3YaPMmJmporWnDvHHSxGQ9xJmOCbbf0qTbW50= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756847855; c=relaxed/simple; bh=MnymFkElF/Uhn11l0Bf9kZ+Tutvd7OlP9DS8h1S0JYo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=YSykuDtGeg9tXAu51zfTqfnItTdBW7KysZ5jXEF6Q5RJcPerYK1ahUZC0wAymCK41o7/9mbhaBhr+4vfiwKlB4fPJMcgxpVDE4MVmb0iTW9h7XL89V00ATJahc+7Li9MCwt3lZ4v9b0F0I3KgRgRVuW+KehIRLnenXHZZO8e6JA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=carnegierobotics.com; spf=pass smtp.mailfrom=douglass.dev; arc=none smtp.client-ip=34.202.193.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=carnegierobotics.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=douglass.dev Feedback-ID: 3578:1022:null:purelymail X-Pm-Original-To: linux-kernel@vger.kernel.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1141507836; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 02 Sep 2025 21:17:14 +0000 (UTC) From: Woodrow Douglass To: Liam Girdwood , Mark Brown , Woodrow Douglass , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 1/2] regulator: pf530x: Add a driver for the NXP PF5300 Regulator Date: Tue, 2 Sep 2025 17:17:01 -0400 Message-Id: <20250902-pf530x-v2-1-f105eb073cb1@carnegierobotics.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250902-pf530x-v2-0-f105eb073cb1@carnegierobotics.com> References: <20250902-pf530x-v2-0-f105eb073cb1@carnegierobotics.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.12.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=11163; i=wdouglass@carnegierobotics.com; h=from:subject:message-id; bh=MnymFkElF/Uhn11l0Bf9kZ+Tutvd7OlP9DS8h1S0JYo=; b=owEBbQGS/pANAwAKAewLuLlPNh4UAcsmYgBot16Y/2YhOg2wMEtkRtsQET9eddlO8Si8dbldZ pzh0xpk0IKJATMEAAEKAB0WIQSIUqjrbDLQw0mgxHLsC7i5TzYeFAUCaLdemAAKCRDsC7i5TzYe FOpICACCeY0FjMDKcQhihPUHzvM26yjt68UjTm8bWkCelViQUhkckjeWR70dLSEoeLlVX4S7KQK XBuN4v+do2zhF7WVLwj57C2sIzlxKv7pyjkUaOBZnXqCawlxaMUSLJYZ2RNEbwqiYTrUvQp9DVe 1L5Nf1EJQOCs1kMplBRT21X75iU0Gr9pwRNO7ZpeNNx0Vqg73cfVlP1oEAIsGR8O65JTAgQ2EMN hyigkYCtDPmY2oGAKzUakyGEjE4GhXSz5miZ8LCySC6nzO6nTVM6gFZv6g+a91ivSVkT2RJneIG ghTyX7RKJCG5N0CVYv3I0urAWL9Fma62S2x49yOeBraX+ZCm X-Developer-Key: i=wdouglass@carnegierobotics.com; a=openpgp; fpr=8852A8EB6C32D0C349A0C472EC0BB8B94F361E14 Content-Transfer-Encoding: quoted-printable This driver allows reading some regulator settings and adjusting output voltage. It is based on information from the datasheet at https://www.nxp.com/docs/en/data-sheet/PF5300.pdf Signed-off-by: Woodrow Douglass --- MAINTAINERS | 6 + drivers/regulator/Kconfig | 12 ++ drivers/regulator/Makefile | 1 + drivers/regulator/pf530x-regulator.c | 328 +++++++++++++++++++++++++++++++= ++++ 4 files changed, 347 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6dcfbd11efef..2c2d165a40ff 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18291,6 +18291,12 @@ F: Documentation/devicetree/bindings/clock/*imx* F: drivers/clk/imx/ F: include/dt-bindings/clock/*imx* =20 +NXP PF5300/PF5301/PF5302 PMIC REGULATOR DEVICE DRIVER +M: Woodrow Douglass +S: Maintained +F: Documentation/devicetree/bindings/regulator/nxp,pf530x-regulator.yaml +F: drivers/regulator/pf530x-regulator.c + NXP PF8100/PF8121A/PF8200 PMIC REGULATOR DEVICE DRIVER M: Jagan Teki S: Maintained diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index eaa6df1c9f80..611356bea09d 100644 --- a/drivers/regulator/Kconfig +++ b/drivers/regulator/Kconfig @@ -1006,6 +1006,18 @@ config REGULATOR_PCAP This driver provides support for the voltage regulators of the PCAP2 PMIC. =20 +config REGULATOR_PF530X + tristate "NXP PF5300/PF5301/PF5302 regulator driver" + depends on I2C && OF + select REGMAP_I2C + help + Say y here to support the regulators found on the NXP + PF5300/PF5301/PF5302 PMIC. + + Say M here if you want to support for the regulators found + on the NXP PF5300/PF5301/PF5302 PMIC. The module will be named + "pf530x-regulator". + config REGULATOR_PF8X00 tristate "NXP PF8100/PF8121A/PF8200 regulator driver" depends on I2C && OF diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile index be98b29d6675..60ca55d04aef 100644 --- a/drivers/regulator/Makefile +++ b/drivers/regulator/Makefile @@ -125,6 +125,7 @@ obj-$(CONFIG_REGULATOR_QCOM_USB_VBUS) +=3D qcom_usb_vbu= s-regulator.o obj-$(CONFIG_REGULATOR_PALMAS) +=3D palmas-regulator.o obj-$(CONFIG_REGULATOR_PCA9450) +=3D pca9450-regulator.o obj-$(CONFIG_REGULATOR_PF9453) +=3D pf9453-regulator.o +obj-$(CONFIG_REGULATOR_PF530X) +=3D pf530x-regulator.o obj-$(CONFIG_REGULATOR_PF8X00) +=3D pf8x00-regulator.o obj-$(CONFIG_REGULATOR_PFUZE100) +=3D pfuze100-regulator.o obj-$(CONFIG_REGULATOR_PV88060) +=3D pv88060-regulator.o diff --git a/drivers/regulator/pf530x-regulator.c b/drivers/regulator/pf530= x-regulator.c new file mode 100644 index 000000000000..51c99d68413e --- /dev/null +++ b/drivers/regulator/pf530x-regulator.c @@ -0,0 +1,328 @@ +// SPDX-License-Identifier: GPL-2.0+ + +//documentation of this device is available at +//https://www.nxp.com/docs/en/data-sheet/PF5300.pdf + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/* registers */ +#define PF530X_DEVICEID 0x00 +#define PF530X_REVID 0x01 +#define PF530X_EMREV 0x02 +#define PF530X_PROGID 0x03 +#define PF530X_CONFIG1 0x04 +#define PF530X_INT_STATUS1 0x05 +#define PF530X_INT_SENSE1 0x06 +#define PF530X_INT_STATUS2 0x07 +#define PF530X_INT_SENSE2 0x08 +#define PF530X_BIST_STAT1 0x09 +#define PF530X_BIST_CTRL 0x0a +#define PF530X_STATE 0x0b +#define PF530X_STATE_CTRL 0x0c +#define PF530X_SW1_VOLT 0x0d +#define PF530X_SW1_STBY_VOLT 0x0e +#define PF530X_SW1_CTRL1 0x0f +#define PF530X_SW1_CTRL2 0x10 +#define PF530X_CLK_CTRL 0x11 +#define PF530X_SEQ_CTRL1 0x12 +#define PF530X_SEQ_CTRL2 0x13 +#define PF530X_RANDOM_CHK 0x14 +#define PF530X_RANDOM_GEN 0x15 +#define PF530X_WD_CTRL1 0x16 +#define PF530X_WD_SEED 0x17 +#define PF530X_WD_ANSWER 0x18 +#define PF530X_FLT_CNT1 0x19 +#define PF530X_FLT_CNT2 0x1a +#define PF530X_OTP_MODE 0x2f + +enum pf530x_states { + PF530X_STATE_POF, + PF530X_STATE_FUSE_LOAD, + PF530X_STATE_LP_OFF, + PF530X_STATE_SELF_TEST, + PF530X_STATE_POWER_UP, + PF530X_STATE_INIT, + PF530X_STATE_IO_RELEASE, + PF530X_STATE_RUN, + PF530X_STATE_STANDBY, + PF530X_STATE_FAULT, + PF530X_STATE_FAILSAFE, + PF530X_STATE_POWER_DOWN, + PF530X_STATE_2MS_SELFTEST_RETRY, + PF530X_STATE_OFF_DLY, +}; + +#define PF530_FAM 0x50 +enum pf530x_devid { + PF5300 =3D 0x3, + PF5301 =3D 0x4, + PF5302 =3D 0x5, +}; + +#define PF530x_FAM 0x50 +#define PF530x_DEVICE_FAM_MASK GENMASK(7, 4) +#define PF530x_DEVICE_ID_MASK GENMASK(3, 0) + +#define PF530x_STATE_MASK GENMASK(3, 0) +#define PF530x_STATE_RUN 0x07 +#define PF530x_STATE_STANDBY 0x08 +#define PF530x_STATE_LP_OFF 0x02 + +#define PF530X_OTP_STBY_MODE GENMASK(3, 2) +#define PF530X_OTP_RUN_MODE GENMASK(1, 0) + +#define PF530X_INT_STATUS_OV BIT(1) +#define PF530X_INT_STATUS_UV BIT(2) +#define PF530X_INT_STATUS_ILIM BIT(3) + +struct pf530x_chip { + struct regmap *regmap; + struct device *dev; +}; + +static const struct regmap_config pf530x_regmap_config =3D { + .reg_bits =3D 8, + .val_bits =3D 8, + .max_register =3D PF530X_OTP_MODE, + .cache_type =3D REGCACHE_RBTREE, +}; + +static int pf530x_is_enabled(struct regulator_dev *rdev) +{ + //first get mode + unsigned int state; + unsigned int mode; + int ret; + + ret =3D regmap_read(rdev->regmap, PF530X_STATE, &state); + if (ret !=3D 0) + return ret; + + state &=3D PF530x_STATE_MASK; + + ret =3D regmap_read(rdev->regmap, PF530X_OTP_MODE, &mode); + if (ret !=3D 0) + return ret; + + //are we enabled in that mode? + switch (state) { + case PF530x_STATE_RUN: + ret =3D ((mode & PF530X_OTP_RUN_MODE) =3D=3D 0); + break; + case PF530x_STATE_STANDBY: + ret =3D ((mode & PF530X_OTP_STBY_MODE) =3D=3D 0); + break; + default: + ret =3D -EINVAL; + break; + } + return ret; +} + +static int pf530x_get_status(struct regulator_dev *rdev) +{ + unsigned int state; + int ret; + + ret =3D regmap_read(rdev->regmap, PF530X_STATE, &state); + if (ret !=3D 0) + return ret; + + state &=3D PF530x_STATE_MASK; + + switch (state) { + case PF530x_STATE_RUN: + ret =3D REGULATOR_STATUS_NORMAL; + break; + case PF530x_STATE_STANDBY: + ret =3D REGULATOR_STATUS_STANDBY; + break; + case PF530x_STATE_LP_OFF: + ret =3D REGULATOR_STATUS_OFF; + break; + default: + ret =3D REGULATOR_STATUS_ERROR; + break; + } + return ret; +} + +static int pf530x_get_error_flags(struct regulator_dev *rdev, unsigned int= *flags) +{ + unsigned int status; + int ret; + + ret =3D regmap_read(rdev->regmap, PF530X_INT_STATUS1, &status); + + if (ret !=3D 0) + return ret; + + *flags =3D 0; + + if (status & PF530X_INT_STATUS_OV) + *flags |=3D REGULATOR_ERROR_OVER_VOLTAGE_WARN; + + if (status & PF530X_INT_STATUS_UV) + *flags |=3D REGULATOR_ERROR_UNDER_VOLTAGE; + + if (status & PF530X_INT_STATUS_ILIM) + *flags |=3D REGULATOR_ERROR_OVER_CURRENT; + + return 0; +} + +static const struct regulator_ops pf530x_regulator_ops =3D { + .enable =3D regulator_enable_regmap, + .disable =3D regulator_disable_regmap, + .is_enabled =3D pf530x_is_enabled, + .map_voltage =3D regulator_map_voltage_linear_range, + .list_voltage =3D regulator_list_voltage_linear_range, + .set_voltage_sel =3D regulator_set_voltage_sel_regmap, + .get_voltage_sel =3D regulator_get_voltage_sel_regmap, + .get_status =3D pf530x_get_status, + .get_error_flags =3D pf530x_get_error_flags, + .set_bypass =3D regulator_set_bypass_regmap, + .get_bypass =3D regulator_get_bypass_regmap, +}; + +static struct linear_range vrange =3D REGULATOR_LINEAR_RANGE(500000, 0, 14= 0, 5000); + +static struct regulator_desc pf530x_reg_desc =3D { + .name =3D "SW1", + .of_match =3D of_match_ptr("SW1"), + .regulators_node =3D "regulators", + .ops =3D &pf530x_regulator_ops, + .linear_ranges =3D &vrange, + .n_linear_ranges =3D 1, + .type =3D REGULATOR_VOLTAGE, + .id =3D 0, + .owner =3D THIS_MODULE, + .vsel_reg =3D PF530X_SW1_VOLT, + .vsel_mask =3D 0xFF, + .bypass_reg =3D PF530X_SW1_CTRL2, + .bypass_mask =3D 0x07, + .bypass_val_on =3D 0x07, + .bypass_val_off =3D 0x00, +}; + +static int pf530x_identify(struct pf530x_chip *chip) +{ + unsigned int value; + u8 dev_fam, dev_id; + const char *name =3D NULL; + int ret; + + ret =3D regmap_read(chip->regmap, PF530X_DEVICEID, &value); + if (ret) { + dev_err(chip->dev, "failed to read chip family\n"); + return ret; + } + + dev_fam =3D value & PF530x_DEVICE_FAM_MASK; + switch (dev_fam) { + case PF530x_FAM: + break; + default: + dev_err(chip->dev, + "Chip 0x%x is not from PF530X family\n", dev_fam); + return ret; + } + + dev_id =3D value & PF530x_DEVICE_ID_MASK; + switch (dev_id) { + case PF5300: + name =3D "PF5300"; + break; + case PF5301: + name =3D "PF5301"; + break; + case PF5302: + name =3D "PF5302"; + break; + default: + dev_err(chip->dev, "Unknown pf530x device id 0x%x\n", dev_id); + return -ENODEV; + } + + dev_info(chip->dev, "%s Regulator found.\n", name); + + return 0; +} + +static int pf530x_i2c_probe(struct i2c_client *client) +{ + struct regulator_config config =3D { NULL, }; + struct pf530x_chip *chip; + int ret; + struct regulator_dev *rdev; + + chip =3D devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL); + if (!chip) + return -ENOMEM; + + i2c_set_clientdata(client, chip); + chip->dev =3D &client->dev; + + chip->regmap =3D devm_regmap_init_i2c(client, &pf530x_regmap_config); + if (IS_ERR(chip->regmap)) { + ret =3D PTR_ERR(chip->regmap); + dev_err(&client->dev, + "regmap allocation failed with err %d\n", ret); + return ret; + } + + ret =3D pf530x_identify(chip); + if (ret) + return ret; + + config.dev =3D chip->dev; + config.driver_data =3D &pf530x_reg_desc; + config.regmap =3D chip->regmap; + + //the config parameter gets copied, it's ok to pass a pointer on the stac= k here + rdev =3D devm_regulator_register(&client->dev, &pf530x_reg_desc, &config); + if (IS_ERR(rdev)) { + dev_err(&client->dev, "failed to register %s regulator\n", pf530x_reg_de= sc.name); + return PTR_ERR(rdev); + } + + return 0; +} + +static const struct of_device_id pf530x_dt_ids[] =3D { + { .compatible =3D "nxp,pf5300",}, + { .compatible =3D "nxp,pf5301",}, + { .compatible =3D "nxp,pf5302",}, + { } +}; +MODULE_DEVICE_TABLE(of, pf530x_dt_ids); + +static const struct i2c_device_id pf530x_i2c_id[] =3D { + { "pf5300", 0 }, + { "pf5301", 0 }, + { "pf5302", 0 }, + {}, +}; +MODULE_DEVICE_TABLE(i2c, pf530x_i2c_id); + +static struct i2c_driver pf530x_regulator_driver =3D { + .id_table =3D pf530x_i2c_id, + .driver =3D { + .name =3D "pf530x", + .of_match_table =3D pf530x_dt_ids, + }, + .probe_new =3D pf530x_i2c_probe, +}; +module_i2c_driver(pf530x_regulator_driver); + +MODULE_AUTHOR("Woodrow Douglass "); +MODULE_DESCRIPTION("Regulator Driver for NXP's PF5300/PF5301/PF5302 PMIC"); +MODULE_LICENSE("GPL"); --=20 2.39.5