From nobody Fri Oct 3 11:22:23 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F3332FC864 for ; Tue, 2 Sep 2025 11:51:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756813865; cv=none; b=gpiCCq+Gyi4ZnXftpREfGrACkRYh1yEEWucKDssqEB96YHXfRSy3XalnsWFiqjyswGttF6uUu5jCmyLBDCdINyow8MYnie/BT9AzSLzhnhEUafvODsXUMwZmvbfthbCYeqVfYuvlkEDZbDUmvBqW7Ybl9MX54QACMaN0ipm1owM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756813865; c=relaxed/simple; bh=u+jvzNK2e56X8NgPlWVyKgTqTb6j7//8GPSdT1wszhc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=c13E3J6B7fZxjOdayl48KleAKHjOo8s1BUl+eHK711Fk3qLhZ9EU6K5Yapi4WO4slDkRDBn1x/nVDsLQuQPwCEz9Hasa3GpNxZK5lmEgFNwHqjaLvb5fDU5b/peGv/8FfZHPM+VbvRHpD/yHk+hOpb7TZ/Pda/WI+2dr/Js6nu4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=m0oklpbH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="m0oklpbH" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 582Ancjk016548 for ; Tue, 2 Sep 2025 11:51:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RXbXSoN8+xcQeFZSW7xnjf1gqgKzPw5UBm5otQcCyVc=; b=m0oklpbHMHSvAIv6 e4GB3pxIvHi3cNzY7ndYtkhNsyPO2fsmSPj/2HU8XnmguTPeAGBz0LGdMkny3Mvw Wl+uT2fw4vhblBgRWHPQdKv4UPmKXgC5xd5mbe7i2B6NecSueo+GKCTfzJWnKiPF IDlgS+vt3VPOsTnqgSG+EmwnKBr0bm6lugIWPWAYDzZaunBPVo63b/2mf7Qxgeuy +8DOkuPzU8y3xf0ogyzPYXnEmt2TqdgnBbzhJ4x/8h4Qeg7o+zg65N2hrmx+lc8F dou2AbanwvWOL1mM7igQnDqnO/15dS9/fqmJqVy9p2RIFEL4yX4CAP9NW5eq+8GW fIzS9Q== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48urvyynbh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 02 Sep 2025 11:51:03 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-329d88c126cso934286a91.2 for ; Tue, 02 Sep 2025 04:51:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756813862; x=1757418662; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RXbXSoN8+xcQeFZSW7xnjf1gqgKzPw5UBm5otQcCyVc=; b=fOyaWlKgOyn/oA+FLAbUDk3bhVdGFU1WuQ9UiBVEU5JbVw98lLJ53EmTpdHunCJ1gC 6K6EQC+vD4H9kEWJTKdXlD2e4+GOKWHlSo2KRa3J1AlhbQjLieE1ZFBWsm7AsqUHlt/S pz1sYYmQ6uXH+R3rsmuNYeIueLbzDTYyFhLUAXCLyh6UoIFmv/eLOS7pgBdrLyeab7MW 7BoQkgSTILxj8FJTn3VOITju61/qVE8pBykbIeP4f4mAtd/lZvdjbsHxgj/aCH0x4vlm svfbL/r81qjq0bVgpS8UpCHSZZc3bzU7i706NRc+xdHwKIkXeYXSgm5UtFOiLMjdPLaW tBxQ== X-Forwarded-Encrypted: i=1; AJvYcCXby5uASwpOllmrA3jL4JNRfZqBCcmTBLUN8s1ovwsDyFjxo9pSL2uw8cCFWoum+abYYe+yKhdoSR/YDmc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0OIzkC/Vq0v7tRzz2dcJKgrhYs0rmjcIyr01ZDM1JzvGrEiYs m4mmjwhq8ZYhGtzzrRt6STwudGV5eYjGhLEK72ljiV040Vstq9LrDIUOP7i0WqscuEN/aMxJUKN tURm9JCXoTQwRX6INr26S6yD+ptY/g+ofFxCUHu7OcwvnpITfDxzOBAN/CCWc+GeMYmA= X-Gm-Gg: ASbGnctfET+1Rr4ThUqx0L8Po6C41GRIqDVlg7UsH1xjLKnKbMkoYlDut8MEYkhNIGH m51xmTHSpplWLeYCYe2tOT+eIyV0wuKbegjDJzHPddiZ6XhmVa7R9AHSVyxMooVrBan6yavDLp3 tFQ8gC85gnw1gDNDyoUWu+irFtZVqe8RTh961LKqg8KnUFylA/pE261Z882yroBWK2vfnH7RNik pCeh4y6LT05CheciPYMdOnzXWDIUjXfJRU834V1oWeeC5SvA9QyCYmZ9x/11tTyVlqEIZJgXI4n OQ2FLtkVqeuNHP3V/RYyE5zCr7qorAk4S791+vUDKZF7KpVvbZwv4YTjwr6058eA X-Received: by 2002:a17:90a:e7cc:b0:327:dce5:f644 with SMTP id 98e67ed59e1d1-32815436034mr14083559a91.11.1756813861799; Tue, 02 Sep 2025 04:51:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFoSouSKhDw/XMbQucJtw29inwJa9PXd0lM4uXnFSu8NXWhDmuE8ewb2G9NTAHJCIwa3AK6Vw== X-Received: by 2002:a17:90a:e7cc:b0:327:dce5:f644 with SMTP id 98e67ed59e1d1-32815436034mr14083530a91.11.1756813861277; Tue, 02 Sep 2025 04:51:01 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-329d089395esm3175428a91.1.2025.09.02.04.50.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Sep 2025 04:51:00 -0700 (PDT) From: Akhil P Oommen Date: Tue, 02 Sep 2025 17:20:03 +0530 Subject: [PATCH 4/4] drm/msm/a6xx: Add a comment to acd_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250902-assorted-sept-1-v1-4-f3ec9baed513@oss.qualcomm.com> References: <20250902-assorted-sept-1-v1-0-f3ec9baed513@oss.qualcomm.com> In-Reply-To: <20250902-assorted-sept-1-v1-0-f3ec9baed513@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Jordan Crouse , Jonathan Marek Cc: Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1756813835; l=862; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=u+jvzNK2e56X8NgPlWVyKgTqTb6j7//8GPSdT1wszhc=; b=h1wuLBfHfxcnM6zFAKgRxWdVDGgBm+1UEUHwJUPl+idhjvX3cN7t259RcLJnP/jnGewak+bBJ jWeTxOAo6mMC9ctIPcO0kjFFpFYt5i3C+xqg+hvMMdgsFtncKo35DtR X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-GUID: VqFCeHzeKmue8J86McoUV0wfjd1wXUkT X-Proofpoint-ORIG-GUID: VqFCeHzeKmue8J86McoUV0wfjd1wXUkT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODMwMDAyNyBTYWx0ZWRfX78b7Q00v2Py8 BDeIDT+PH7uGCyQuCQYcfjs3ANFe3asZcz9/kpS68qxWC4ZFZ6+JPmv15oSy/sCUWeC61yVvhcX pg4HZ7iClqT2/soSwfJUaDwSc5f97lPkpaZVrTrrcJYt5JhoPBVSjnr+vq/gN6znj72YI05SNJh yCz2vxgL6cQKBQPV0XVcNe585PMMz/jvFOFpVu0lxmEeRdqNo3ebu6SA4u21dr4JLfewADEm5NA NU5oJwgBNN4mA/TmtdgoHU723E84S+6uORPPqWuzZjpjG1beLiTGar+1bwyR4MjMiSsYDrteasI Kt5Ev/wvlDMP5UK0+dO3mPUGWtsHxu7Ck2jzmNjwSPgctp/6Jkm15UpxzlNiauRYQxSPB/Nvd9q OOVyvHMF X-Authority-Analysis: v=2.4 cv=NrDRc9dJ c=1 sm=1 tr=0 ts=68b6da27 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=7jaC3Q-7aBCS2g4HU_oA:9 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-02_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 malwarescore=0 priorityscore=1501 phishscore=0 impostorscore=0 spamscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508300027 It is not obvious why we can skip error checking of dev_pm_opp_find_freq_exact() API. Add a comment explaining it. Signed-off-by: Akhil P Oommen Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gmu.c index ea52374c9fcd481d816ed9608e9f6eb1c2e3005a..de8f7051402bf0fd931fc065b5c= 4c49e2bfd5dc7 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c @@ -1694,6 +1694,7 @@ static int a6xx_gmu_acd_probe(struct a6xx_gmu *gmu) u32 val; =20 freq =3D gmu->gpu_freqs[i]; + /* This is unlikely to fail because we are passing back a known freq */ opp =3D dev_pm_opp_find_freq_exact(&gpu->pdev->dev, freq, true); np =3D dev_pm_opp_get_of_node(opp); =20 --=20 2.50.1