From nobody Fri Oct 3 10:11:20 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC68E2FB63B for ; Tue, 2 Sep 2025 11:50:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756813850; cv=none; b=MgPEfu9Zsie63Vc0P/dFXMHwKy9AGRvaWVfOELIbV385XS5L7BhL2PB9dJlwSxkZOTB7kEcaE42EQCUoS62E28oMW0sYFUDFQe/0unwUiswK/pfYbype9YHRam6e5YzXrvisJ8dPD6mf7+xDgJg09/1zBfVWqRdiEEBjdeCszOU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756813850; c=relaxed/simple; bh=qPgkL7fQFaE6QyN7pM6ijtnceZa332Ylsl3h67JWyzs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ouiEuAl16vOpt+GH8DKtztgY7YwZKM0URpg6EqVuJSCxz0EEAEhOMUsfVIKNRHZgG3rnnyJKveBEvdz5izWExnM4gHY/iAnIzLhAINDiCgBz4kBQaXu/LYn3L6UopKoA7E2IfGwfZaetuVLxceN8A6DoAkfIGbUL9HPSCJtQDmc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N6zyRUPj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N6zyRUPj" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 582AQANn027558 for ; Tue, 2 Sep 2025 11:50:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= o4Hflc+daQ6IuFv2HVvc4nbRfQYOBNM9H/xWVC9Qnhs=; b=N6zyRUPjVnq1G9ja KcPaq2mtNJM+ZmdKazy0ExicjtvOg/3YKgRUp46jxoqtI6aOeRrVRL1cxGkjpP9h 4FoM4QAM2a82XD8u58ZP6jqXU7pyiq7yG3jiEHMFKEUAgNFh7tYpQkEKByFbivKy XWK1UehNwAqR0tUhFSrI1sqIWyPJ2l+Kh7+vAe/GJzjy4KPBf7OhUpstas/jJeFy ICozRQEoMsmK3zYrr0fwDPqIYECSN2xF/aTrColJQwSYhX2bSGhmLmAf9rexBpLJ nir6kkQeM9dqAy8XvUBHhm7VGXkSceqClia25KR41dNUeDFfGAB5R9Ye9mtMKuxF iqUoMQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48uscuypcc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 02 Sep 2025 11:50:47 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-32811874948so2740767a91.2 for ; Tue, 02 Sep 2025 04:50:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756813846; x=1757418646; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o4Hflc+daQ6IuFv2HVvc4nbRfQYOBNM9H/xWVC9Qnhs=; b=B6E3dQyrYOyPY0oEu9Q+XckquDRBFPCr7hskD2RO77hz9GazMo0DCdjsT7ndZkWib3 KHWNz2gH3Drkt8IJ32DhNw+U1+gjwtYNt25mespAqdqNJb1CpzlJa2Cg08vqYQjAxfxe d14VRjSNmAxViAvojTL8kdAb3s5QYKLs/eeupYvDAhJZUjBsezMykE+HLW+V5QySjcbV AGHQPvjaTN4YK4XBzXvgOsS3AadMoqZrwBZCR/K82l8NRDlxz5YnPzwYrR0aX17O5wcL Oyn9KEuTyfq309JBJ6XI4q6Y1aMdnn1/+RyuhoJ0qtiXwq37yKyxyarFibykxhWgCJU2 Ts6A== X-Forwarded-Encrypted: i=1; AJvYcCUxcToRi/E1AHXZNsfN61h6B+dY+QE2fVyXK9uWFQro1uVktqghnS0Ja+6KsEVu6pFjc+ZeK2q3bEWoamY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywuj68A0crXg9nie2110L7MqT+akXFo1bjkzys+Nt6EDmPexwMz avg3AeIlVQayvEpeXvR19BMupq3YHnRJgYb1TdNZmBMdS04AANMqgon3MK2gRyjZDGj8XeeD/X/ 3F2Fb4UNfKjWY9Rw2F4KSBVf3HMJ3sqPlWghWcxX6UazE3G9C5AtRWMH2b0o+B8yPEHA= X-Gm-Gg: ASbGncuInXh/A9UKqwagSb5hIoliSdPAivmZxfCyfvJvcgUuAovGXavYvxy08Sq+xqb wT3NrkZ1IJilbly8V2fyrsf7fI+q2zOIF301tfCN7OaCjXwDbCWzFgQpuQ8dnpV5e7Lzu4KpnFU dYa5EeAonhlJmf0fhzexaPlg8jP6Q1Zh5eTjpfnjU/9ti33CObhrrcy/e67ZynTr6kEmBUaplbx V090gDXyeLltEGuPMhnAQ9KgkFtvMmbXX4ydOaZhmgC36NTCHpPYKOYylYBILzzsRvUKyvpzdj3 EZbnvzfktfqvvSR/uAz6lVFkxAPoKPvpdOUjHXxgYJX8eYjBqIxqHErLpgfgiRgo X-Received: by 2002:a17:90b:3dcf:b0:327:7220:f579 with SMTP id 98e67ed59e1d1-32815412d5fmr10872183a91.1.1756813846405; Tue, 02 Sep 2025 04:50:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGW99TwUZWxEy45yoetqpbaSq5lJC3JPeKamGQotr5IZQ5SoSdER5YO+EmZCPCjeK1GGCyBuA== X-Received: by 2002:a17:90b:3dcf:b0:327:7220:f579 with SMTP id 98e67ed59e1d1-32815412d5fmr10872157a91.1.1756813845739; Tue, 02 Sep 2025 04:50:45 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-329d089395esm3175428a91.1.2025.09.02.04.50.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Sep 2025 04:50:45 -0700 (PDT) From: Akhil P Oommen Date: Tue, 02 Sep 2025 17:20:00 +0530 Subject: [PATCH 1/4] drm/msm: Fix bootup splat with separate_gpu_drm modparam Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250902-assorted-sept-1-v1-1-f3ec9baed513@oss.qualcomm.com> References: <20250902-assorted-sept-1-v1-0-f3ec9baed513@oss.qualcomm.com> In-Reply-To: <20250902-assorted-sept-1-v1-0-f3ec9baed513@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Jordan Crouse , Jonathan Marek Cc: Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1756813835; l=4562; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=qPgkL7fQFaE6QyN7pM6ijtnceZa332Ylsl3h67JWyzs=; b=KpwHPv5jbU1wG0upN69QN4TU9tLv75znfaMNG/wW/Vr6JMKnE72nr9y8RUcFJA0uol8NLt7B+ 0SEFpVmHcU3An78DGT319SckSxtIIrGYV3cpjSsb3jEmR64RaxyjTRg X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODMwMDAzMSBTYWx0ZWRfX3BF5it9LnoUx Bpg/2LrNDVJRzYQwbgMUEQolgp23t+zyG1Kaf5ohQ88m3kly2DTY3TA6PXPOe94zTPGxtImtqeD mz4Pm8QSj4KWwcP9bakl1XOAccpvP6kwzRA0a8R9KItKRP4qnbhZNU8Fnep+swHiDsIVSAGWS9e qihBDnk+81Vkr6TPsfI7NpOt4uwK7UIfPgUGwb04Qi+OpXHbqdVRnDUFioll8LDgOUvcU/S4vOj O3h9Ah3N9isQQB+RQDEsehVfjHIwCr3q8yVcoxCE8aw+EzXaOS5gOMMmrHfxr2yVuAMmzI0Exal 4chrvVxKnV4+QTJm6DrModtFZhbVZIg7rlHeLGc+Qiby1xQBt2+FWpDV0rXNBBQ20sejZHqqlkX OAHi0dRT X-Authority-Analysis: v=2.4 cv=A8xsP7WG c=1 sm=1 tr=0 ts=68b6da17 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=7L6S3vPEwiY8THHMc4kA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: M7DlT4tO3Nc_uW2tEy1FB8j60a1MkrR5 X-Proofpoint-GUID: M7DlT4tO3Nc_uW2tEy1FB8j60a1MkrR5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-02_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 impostorscore=0 bulkscore=0 clxscore=1015 suspectscore=0 malwarescore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508300031 The drm_gem_for_each_gpuvm_bo() call from lookup_vma() accesses drm_gem_obj.gpuva.list, which is not initialized when the drm driver does not support DRIVER_GEM_GPUVA feature. Enable it for msm_kms drm driver to fix the splat seen when msm.separate_gpu_drm=3D1 modparam is set: [ 9.506020] Unable to handle kernel paging request at virtual address ff= fffffffffffff0 [ 9.523160] Mem abort info: [ 9.523161] ESR =3D 0x0000000096000006 [ 9.523163] EC =3D 0x25: DABT (current EL), IL =3D 32 bits [ 9.523165] SET =3D 0, FnV =3D 0 [ 9.523166] EA =3D 0, S1PTW =3D 0 [ 9.523167] FSC =3D 0x06: level 2 translation fault [ 9.523169] Data abort info: [ 9.523170] ISV =3D 0, ISS =3D 0x00000006, ISS2 =3D 0x00000000 [ 9.523171] CM =3D 0, WnR =3D 0, TnD =3D 0, TagAccess =3D 0 [ 9.523172] GCS =3D 0, Overlay =3D 0, DirtyBit =3D 0, Xs =3D 0 [ 9.523174] swapper pgtable: 4k pages, 48-bit VAs, pgdp=3D0000000ad370f0= 00 [ 9.523176] [fffffffffffffff0] pgd=3D0000000000000000, p4d=3D0000000ad47= 87403, pud=3D0000000ad4788403, pmd=3D0000000000000000 [ 9.523184] Internal error: Oops: 0000000096000006 [#1] SMP [ 9.592968] CPU: 9 UID: 0 PID: 448 Comm: (udev-worker) Not tainted 6.17.= 0-rc4-assorted-fix-00005-g0e9bb53a2282-dirty #3 PREEMPT [ 9.592970] Hardware name: Qualcomm CRD, BIOS 6.0.240718.BOOT.MXF.2.4-00= 515-HAMOA-1 07/18/2024 [ 9.592971] pstate: a1400005 (NzCv daif +PAN -UAO -TCO +DIT -SSBS BTYPE= =3D--) [ 9.592973] pc : lookup_vma+0x28/0xe0 [msm] [ 9.592996] lr : get_vma_locked+0x2c/0x128 [msm] [ 9.763632] sp : ffff800082dab460 [ 9.763666] Call trace: [ 9.763668] lookup_vma+0x28/0xe0 [msm] (P) [ 9.763688] get_vma_locked+0x2c/0x128 [msm] [ 9.763706] msm_gem_get_and_pin_iova_range+0x68/0x11c [msm] [ 9.763723] msm_gem_get_and_pin_iova+0x18/0x24 [msm] [ 9.763740] msm_fbdev_driver_fbdev_probe+0xd0/0x258 [msm] [ 9.763760] __drm_fb_helper_initial_config_and_unlock+0x288/0x528 [drm_= kms_helper] [ 9.763771] drm_fb_helper_initial_config+0x44/0x54 [drm_kms_helper] [ 9.763779] drm_fbdev_client_hotplug+0x84/0xd4 [drm_client_lib] [ 9.763782] drm_client_register+0x58/0x9c [drm] [ 9.763806] drm_fbdev_client_setup+0xe8/0xcf0 [drm_client_lib] [ 9.763809] drm_client_setup+0xb4/0xd8 [drm_client_lib] [ 9.763811] msm_drm_kms_post_init+0x2c/0x3c [msm] [ 9.763830] msm_drm_init+0x1a8/0x22c [msm] [ 9.763848] msm_drm_bind+0x30/0x3c [msm] [ 9.919273] try_to_bring_up_aggregate_device+0x168/0x1d4 [ 9.919283] __component_add+0xa4/0x170 [ 9.919286] component_add+0x14/0x20 [ 9.919288] msm_dp_display_probe_tail+0x4c/0xac [msm] [ 9.919315] msm_dp_auxbus_done_probe+0x14/0x20 [msm] [ 9.919335] dp_aux_ep_probe+0x4c/0xf0 [drm_dp_aux_bus] [ 9.919341] really_probe+0xbc/0x298 [ 9.919345] __driver_probe_device+0x78/0x12c [ 9.919348] driver_probe_device+0x40/0x160 [ 9.919350] __driver_attach+0x94/0x19c [ 9.919353] bus_for_each_dev+0x74/0xd4 [ 9.919355] driver_attach+0x24/0x30 [ 9.919358] bus_add_driver+0xe4/0x208 [ 9.919360] driver_register+0x60/0x128 [ 9.919363] __dp_aux_dp_driver_register+0x24/0x30 [drm_dp_aux_bus] [ 9.919365] atana33xc20_init+0x20/0x1000 [panel_samsung_atna33xc20] [ 9.919370] do_one_initcall+0x6c/0x1b0 [ 9.919374] do_init_module+0x58/0x234 [ 9.919377] load_module+0x19cc/0x1bd4 [ 9.919380] init_module_from_file+0x84/0xc4 [ 9.919382] __arm64_sys_finit_module+0x1b8/0x2cc [ 9.919384] invoke_syscall+0x48/0x110 [ 9.919389] el0_svc_common.constprop.0+0xc8/0xe8 [ 9.919393] do_el0_svc+0x20/0x2c [ 9.919396] el0_svc+0x34/0xf0 [ 9.919401] el0t_64_sync_handler+0xa0/0xe4 [ 9.919403] el0t_64_sync+0x198/0x19c [ 9.919407] Code: eb0000bf 54000480 d100a003 aa0303e2 (f8418c44) [ 9.919410] ---[ end trace 0000000000000000 ]--- Fixes: 217ed15bd399 ("drm/msm: enable separate binding of GPU and display d= evices") Signed-off-by: Akhil P Oommen Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 9dcc7a596a11d9342a515dab694bac93dc2805cb..7e977fec4100792394dccf59097= a01c2b2556608 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -826,6 +826,7 @@ static const struct file_operations fops =3D { =20 #define DRIVER_FEATURES_KMS ( \ DRIVER_GEM | \ + DRIVER_GEM_GPUVA | \ DRIVER_ATOMIC | \ DRIVER_MODESET | \ 0 ) --=20 2.50.1 From nobody Fri Oct 3 10:11:20 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C5172FC029 for ; Tue, 2 Sep 2025 11:50:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756813854; cv=none; b=X+BYvosYrV8Xf92ug34J1E/H8B0SF48hNwHYVEHKfgnKJADOcn/MOzUkQZNfOxDME0v2NhPSSHTAInONOPgCjzNrdV+Zm3MPHf2dGglrySxdwCBBtni+Ij6L8quHmmzlcrRu7gNtl6b1b5JpNN6SGOshfVTqaViqjBoVLA0PrP4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756813854; c=relaxed/simple; bh=twGhxveDnx4sa4AY86Omvzu6sh4ndfEdD71Syjd0rOw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sy/7rhlFFcMZFC2wf7emLCQNQko/rxCGMRefyRYGX5BitaPf8epwldTwJYfpJpjQs88n4Y4xADf40W1WX0M02Zqe+PEInVT6sTIR5PxIfrWrJ9V2xHGQOp7RuTJTba49CPxrDUy6CPbWMAhAH4GL2iYXtygDmDVfinFpqVa1VLU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jjBZ8smv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jjBZ8smv" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 582BIUBl030092 for ; Tue, 2 Sep 2025 11:50:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9Ecf2EnQwQu1LlRGQboGHCRDmSsyxJN4FsdN9WPMXtg=; b=jjBZ8smvY7EzlmxC vLwbTo+R9B1cZ29qygXVBlcbJtWwDCUVOz19v5dySma5+A3B9w21sgDfim6276Kn fzlJkMZ7jao9d22NjRllkIDf4DZvxtekR3zfOqWtLK2PT5dlhjQyST+1EAtJrN9z 4LpgsRPBBZUmRLaWZHehbJ5njdJhmqYZArhY93o1Tf1euzb1F8nQORAdbBTZFp12 AEr+MHCZEXCSw2AgSBAv8jxkrAJzUhEpl/OpsQfwxJddjddjfg54GeiUtRRwJ6sS IAYZ+Gutxpy11BUXbhsvgX22fBznE+JUEFt0hC5PFaaBFsGk3ECyyypeMhiKqM1c Cgwy7g== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48ush2yhqf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 02 Sep 2025 11:50:52 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-248942647c5so70704325ad.0 for ; Tue, 02 Sep 2025 04:50:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756813852; x=1757418652; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9Ecf2EnQwQu1LlRGQboGHCRDmSsyxJN4FsdN9WPMXtg=; b=P54CXiqjVBiWd9V6px/WU5aWBZIotdi7eZvVCsLV/3GVobe/ejHb36QgAtVtqB7Aen RnBPBimT+Fx/2WxuUk9KiSYDCBiCWg18QcaLErCEhPmn4ePDBG+OEvsUtxgvswhYPNoZ Uiex+jfej5TPBH34njLzt/qU4FKh0XjYlHPCuYNrgjOt+A7ZZ5tzPWA6+8V2mAx4KT/d WbH/1h5g3PCCzgZkk5Twi/4XEArklQJquxwWkTlUE67eYjMqZgJI+YJgN+tGNxD+5LMj syfm5kvos+I4/R5USHJTxI88jDJqCnfd/vtCMqsnhPV7PaTKayN/3zQL9FbLd1yMG+zF Hf7A== X-Forwarded-Encrypted: i=1; AJvYcCWcKwOB9Kq2OzERommR0LwzfgBdPBHpQK0z7PD1LTI2wDYAx4cRT8E86RPIHM0Xh3xN4Wo0KX0KHqCAiZM=@vger.kernel.org X-Gm-Message-State: AOJu0YxHdAQ91hq4gU2i228Ehy7e9Z+TXkJApchCtFA+zbUNuO5pzIlM dxcwlaC2nWbBOj2RlJzeo6ekPLber7cI6sTAV2e2xdW702e8t+WyYX+Srh/z3GS68eAaEeNH0HP oMWFog0df33EtVaLTEm+8co4RvHHPOTT8+ZJuN3z4OSJq8MZCIctiGTiQDsBENm1DtUU= X-Gm-Gg: ASbGncsxKcMR0MOwmVloKlrX9p5hlI0uuNDreFCIonz0zaacn8CnsbtgquZhVLOMM2k B96BaY41+z2WhX2NeVFSP4xHnm83/E+L3rNU9K+LyVlwnj7UuA7vqfEQWpi9qcMdHUiXzeU2UPK iCm1M+rE1F7L7DwdZUwQXswczhidymFSl/O0rn0wdfE3oIeBudQ9+ICMOiSQTDf9kmwJf1Z26gr 9EjwO/VtPJuepcZsPjEeDV+3B5n7igyPFitecXInOmYel4k5qUk+C9/OF/KlWKXhuE7krgdGy+4 MQUHaNqqJ7L2ulAlep1vlY0D2M1r7Z3y0+gkpUl88VReKXQRSJqZdZ+Grk06B3/l X-Received: by 2002:a17:902:e891:b0:246:2da9:73a2 with SMTP id d9443c01a7336-2493eff73d7mr150963245ad.27.1756813851562; Tue, 02 Sep 2025 04:50:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFe9tA9MOp9iJjbDEJjzynSMTlN4118IVJo0EM9iKkN4E39bGnaCYGlxUtOV+n/mB9jDr8Myw== X-Received: by 2002:a17:902:e891:b0:246:2da9:73a2 with SMTP id d9443c01a7336-2493eff73d7mr150962885ad.27.1756813851076; Tue, 02 Sep 2025 04:50:51 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-329d089395esm3175428a91.1.2025.09.02.04.50.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Sep 2025 04:50:50 -0700 (PDT) From: Akhil P Oommen Date: Tue, 02 Sep 2025 17:20:01 +0530 Subject: [PATCH 2/4] drm/msm/a6xx: Fix GMU firmware parser Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250902-assorted-sept-1-v1-2-f3ec9baed513@oss.qualcomm.com> References: <20250902-assorted-sept-1-v1-0-f3ec9baed513@oss.qualcomm.com> In-Reply-To: <20250902-assorted-sept-1-v1-0-f3ec9baed513@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Jordan Crouse , Jonathan Marek Cc: Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1756813835; l=1466; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=twGhxveDnx4sa4AY86Omvzu6sh4ndfEdD71Syjd0rOw=; b=9ysrXfc2HgE7q8Ud9ADJPJDqm3SHpwRv9C8hfpR3wt3KFdyZpE+MoLnjKe/XRgWoGg/qtW8Cw xWix1+PIdcwBtueU3gqiqKKj4HINkbU/zQsVGWnSrCRn7qlmE4rb5Sc X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODMwMDAzMiBTYWx0ZWRfX1782nd+bggf7 8vDgT6qgZiq0XSWZrxKE8Bcjxl2UYQd1sosimVHh9FN0StWUiScy6JBSeciwbmuGJu/uHM5JFxE 8addK7TDA/f+Kj3TTZVFD/blNDbZYs9DZCcA5RvfJdnK28KbA261yQ1Bw15Co2IrHZuICgmksLP GuJb8Qjm5w2rK+NLwnjYynKF2FkRic2nDlPuElpyTVixzAyYqhQUiECOLdosek1fdHN0wypYPHQ Udr6E5J8jAmCvew/pqVCT7jYE+900q/ta7GNPWEz00EzdehS9z5r5sMlsS6me8TAxV7QAIwBzyg dJULTSBqsq5G3GGe7hQLFzZ7IEAoKsYebCcgX1Kg4s2UOzNEkMs3J/4vcNK4/+TwD+adWZ89l6v lllWx7OX X-Proofpoint-ORIG-GUID: NaF4tvGSAUXZNnLV_MZQW-uJFU5ctu40 X-Proofpoint-GUID: NaF4tvGSAUXZNnLV_MZQW-uJFU5ctu40 X-Authority-Analysis: v=2.4 cv=M9NNKzws c=1 sm=1 tr=0 ts=68b6da1c cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=gF2G-XVBjaN319PmpW4A:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-02_04,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 spamscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 suspectscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508300032 Current parser logic for GMU firmware assumes a dword aligned payload size for every block. This is not true for all GMU firmwares. So, fix this by using correct 'size' value in the calculation for the offset for the next block's header. Fixes: c6ed04f856a4 ("drm/msm/a6xx: A640/A650 GMU firmware path") Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gmu.c index 28e6705c6da682c7b41c748e375dda59a6551898..ea52374c9fcd481d816ed9608e9= f6eb1c2e3005a 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c @@ -758,6 +758,8 @@ static bool fw_block_mem(struct a6xx_gmu_bo *bo, const = struct block_header *blk) return true; } =20 +#define NEXT_BLK(blk) ((const struct block_header *)((const char *)blk + s= izeof(*blk) + blk->size)) + static int a6xx_gmu_fw_load(struct a6xx_gmu *gmu) { struct a6xx_gpu *a6xx_gpu =3D container_of(gmu, struct a6xx_gpu, gmu); @@ -789,7 +791,7 @@ static int a6xx_gmu_fw_load(struct a6xx_gmu *gmu) =20 for (blk =3D (const struct block_header *) fw_image->data; (const u8*) blk < fw_image->data + fw_image->size; - blk =3D (const struct block_header *) &blk->data[blk->size >> 2]) { + blk =3D NEXT_BLK(blk)) { if (blk->size =3D=3D 0) continue; =20 --=20 2.50.1 From nobody Fri Oct 3 10:11:20 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02BBA2FC00C for ; Tue, 2 Sep 2025 11:50:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756813860; cv=none; b=jxNwaykV21dAepyhbZKJK25qkuWYra/qemnadrBgPZ9Gnm1WEnW83ekr1KY+2LKQzE0cuh7nvOvWJ4HF6wOUcXNhUXGIQqTCWI65TaOuZK54cFCB7TUWalx80hsbGuYNjDjwOy2FHSgf4vpHUriXUAr+Yo4D9L5Yba/VsXcGszA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756813860; c=relaxed/simple; bh=NOwN+cR8tlV/aqnCXaU04cGy/XLeEqERgLf8m3fHuTk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Jycc0XQVqo4kN3jyGr8Kd0WV93JcezOo4SOZbK8UVebyX2yTMQqlw+HwnVYbnSr7LfruCX6yVdcS7V0POdUqv6cUIxmNk2iaMbiFcvqr8MusT92UM2QDWimU6yDEFhi4tZpnvbMCxZqhq53xHmBMFEohsicP0x5cZzND5TojNG8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oNw51qeb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oNw51qeb" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 582AVaLE029702 for ; Tue, 2 Sep 2025 11:50:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uX04f8wmwAHTEoCBwCRpg9tdJXyCAWOIBcQwAGC0LXw=; b=oNw51qeb20gRjh5K SJcSqN5ur9YoYdqRKWm9llbBe3eiVlesT2Fx66WHqOb034ZYy3dxmRjtYb72jMG5 5/0vqw7EPbnbe7QVv+aPp1UWh0KHrSFGohsWTQN1VkfBuqogbs3IXMMwPvITfNDp VKZ4Lm3RH+KU3F0u/iGhPXWx1L2HBjOybiIN4WZnQ6oTmnUNJUX4krJqhzsmifsF uNjxD4q4MCtzk86FBcjDYPDQ76v4d58SfkT/di42x2MaC8ra9vHhOJXTCfZMe9nM 5fiCvpVWJEwVBV9RKzLOgHzsFEpevhoY7FPLszqABuVCn6s+yZVDcUXqQ8UX2Iam tIk+EQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48ura8qmag-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 02 Sep 2025 11:50:58 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-329c76f70cbso1351756a91.0 for ; Tue, 02 Sep 2025 04:50:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756813857; x=1757418657; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uX04f8wmwAHTEoCBwCRpg9tdJXyCAWOIBcQwAGC0LXw=; b=PNTSTEJ6Z6o11bkkXXbAlayLe8JIRguJDDov3Ynphji4aj68abMz5zE2HYbLf82HeB m4ZanxgZpsj+yWquK/cpqLonRlfSjPLNpXpF5GS9dMKrL/x8rBknX8V6G+xoC5HgP0Bl yCi1meEaorRM56r79IKoe2aQ9oR7i0GGswx3sbYQBXbDkqDp8R46Jf7Ypr5yFmJvhiZk jJ1XIBtYJCVDwsw2ZVC+iMNC56DzGyJk6HTnWW7XM+GqgiVb+VAZSD2BKONA0FZ/rwgf TA00iC1BsS1voFcUY/3GeqWu9lCAmChLNk8NQq5riGU/iHhq8EcxW6ySQliRclKl4BqS N9MQ== X-Forwarded-Encrypted: i=1; AJvYcCUe3tjKpZc7Tow8EKFAQ6R9JIZb6sUTnI3UnSIIAv0UBZZ+49uS72SoToobtNHT0m0KVWbmh1N1I7+3q3o=@vger.kernel.org X-Gm-Message-State: AOJu0Yx815GWp/az8u0vtl4yT4Uxpe5tfJGKVcxKhomjVmKxtDSQPF7+ CqXE72qbonQLB7wWFugZbnPdOYw5jrTptg8Uh6cqGkTFXuLruM7BIgjtZIiXXmqAGX25XF5RNuM vWOpx2zt1Fxj+EtiXdbhZ6k35g0W+iaA8t+YEUJ25A5zDljFHX46dvm1UfWZ7gj3BBYo= X-Gm-Gg: ASbGncvaqg7SpoKxgSo/s70wjfUahQtarM5BqVR8JlUuRjo3FDeXFrWNLL17Efc96Xi ENnNG69cHEWY6EFKYFIwlSYBWTFBmVzJYj31CB0YuSnnpE4HYvjxpHQ3HnpO0qWe3XyedGjUnrZ 9fkJKEY7Gst+kN6UZy/k2YaYLJA6OUjy2jbzBpHVxVMl/N3rEOR4u5F+ljmNWm/gqAqeEbI+laJ aQawz3G3eH3Mf5yQJPXtZlAGS5qw/FIW7NIcUmwS/JAlyDMQE8ozwiZU6ogbxKPTJ5ikqfMXLiJ Y+pAI8q1zn8T5sXfjWy7b4Ad4p+GLsJdQWCdY4fjIGvY8NQtkM1qCfcqyQEbCz4Y X-Received: by 2002:a17:90b:17cd:b0:32a:e706:b7b6 with SMTP id 98e67ed59e1d1-32ae706be21mr503234a91.11.1756813856675; Tue, 02 Sep 2025 04:50:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErTRmAFRWJHqjCbxLE3P2bbrtdzC5Cpz+xDsMeCUqIW1F+tMhJ6J1sfw37u0AjKJ9vrGGI6Q== X-Received: by 2002:a17:90b:17cd:b0:32a:e706:b7b6 with SMTP id 98e67ed59e1d1-32ae706be21mr503191a91.11.1756813856183; Tue, 02 Sep 2025 04:50:56 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-329d089395esm3175428a91.1.2025.09.02.04.50.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Sep 2025 04:50:55 -0700 (PDT) From: Akhil P Oommen Date: Tue, 02 Sep 2025 17:20:02 +0530 Subject: [PATCH 3/4] drm/msm/adreno: Add a modparam to skip GPU Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250902-assorted-sept-1-v1-3-f3ec9baed513@oss.qualcomm.com> References: <20250902-assorted-sept-1-v1-0-f3ec9baed513@oss.qualcomm.com> In-Reply-To: <20250902-assorted-sept-1-v1-0-f3ec9baed513@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Jordan Crouse , Jonathan Marek Cc: Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1756813835; l=1742; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=NOwN+cR8tlV/aqnCXaU04cGy/XLeEqERgLf8m3fHuTk=; b=nETh6INr+D/D59TGsO48PohgUoYDADrMA8vDopH+eYwucT0xR9w6Xy9nVRTXxpN6RHUT8Y2cd vj8CoQJRz/+CLeVlmJ41VG+K5uMvPKxvAXahNtEUBILnkPu31iD82g2 X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-ORIG-GUID: 1ZXBRTcV-rd3uvRjPEYciVghz1dWwgUF X-Proofpoint-GUID: 1ZXBRTcV-rd3uvRjPEYciVghz1dWwgUF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODMwMDAyMCBTYWx0ZWRfXwspgUhGUKmgG QvdKUOc38pHxk9ynomgTCgN5PDU6gWyuWN4D7A0FT25CVwDR0UEpEBXjNqjVxbWIPeIXuWEOGiu JX35RjnfH/TaMtOOQVjocpWtqGQeNg+aL8KjVsbiQjiORcQdCooUb1hjIVWFF/bA6IbvPjILkXO RZ/+JIVm6urKxrtQdCV3KItRz6nO/VfPHts9E3brOcsj/UlgQbaaqNzmy9/Qa5BsQiCSRb/494w 242bfV9HMF/VBfpYULSQr9hBcsQMNk/nU/7KqzhIXYcNKVbsSh2ChDuESQ2BuBhLMnwSXPIXhrL kmSJX6VZv1YYYKEr7TOediQ7ZG+QYCDE5GZHDfXnARqDd6udRutnzWEfKcXp3rlEk0YxgNZYGyd 1BEGhGWD X-Authority-Analysis: v=2.4 cv=VNndn8PX c=1 sm=1 tr=0 ts=68b6da22 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=5u7-6dn6khLgd3CzhdsA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-02_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508300020 During bringup of a new GPU support, it is convenient to have knob to quickly disable GPU, but keep the display support. This helps to fallback to 'kms_swrast' in case of bootup issues due to GPU. Add a modparam to support this. Signed-off-by: Akhil P Oommen Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/adreno_device.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/m= sm/adreno/adreno_device.c index 50945bfe9b4992118f23db3cd17ac348be9f9c9d..28f744f3caf7c59412aab06f912= cd09a01e185ea 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -24,6 +24,10 @@ bool disable_acd; MODULE_PARM_DESC(disable_acd, "Forcefully disable GPU ACD"); module_param_unsafe(disable_acd, bool, 0400); =20 +static bool skip_gpu; +MODULE_PARM_DESC(no_gpu, "Disable GPU driver register (0=3Denable GPU driv= er register (default), 1=3Dskip GPU driver register"); +module_param(skip_gpu, bool, 0400); + extern const struct adreno_gpulist a2xx_gpulist; extern const struct adreno_gpulist a3xx_gpulist; extern const struct adreno_gpulist a4xx_gpulist; @@ -184,6 +188,9 @@ bool adreno_has_gpu(struct device_node *node) uint32_t chip_id; int ret; =20 + if (skip_gpu) + return false; + ret =3D find_chipid(node, &chip_id); if (ret) return false; @@ -404,10 +411,16 @@ static struct platform_driver adreno_driver =3D { =20 void __init adreno_register(void) { + if (skip_gpu) + return; + platform_driver_register(&adreno_driver); } =20 void __exit adreno_unregister(void) { + if (skip_gpu) + return; + platform_driver_unregister(&adreno_driver); } --=20 2.50.1 From nobody Fri Oct 3 10:11:20 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F3332FC864 for ; Tue, 2 Sep 2025 11:51:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756813865; cv=none; b=gpiCCq+Gyi4ZnXftpREfGrACkRYh1yEEWucKDssqEB96YHXfRSy3XalnsWFiqjyswGttF6uUu5jCmyLBDCdINyow8MYnie/BT9AzSLzhnhEUafvODsXUMwZmvbfthbCYeqVfYuvlkEDZbDUmvBqW7Ybl9MX54QACMaN0ipm1owM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756813865; c=relaxed/simple; bh=u+jvzNK2e56X8NgPlWVyKgTqTb6j7//8GPSdT1wszhc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=c13E3J6B7fZxjOdayl48KleAKHjOo8s1BUl+eHK711Fk3qLhZ9EU6K5Yapi4WO4slDkRDBn1x/nVDsLQuQPwCEz9Hasa3GpNxZK5lmEgFNwHqjaLvb5fDU5b/peGv/8FfZHPM+VbvRHpD/yHk+hOpb7TZ/Pda/WI+2dr/Js6nu4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=m0oklpbH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="m0oklpbH" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 582Ancjk016548 for ; Tue, 2 Sep 2025 11:51:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RXbXSoN8+xcQeFZSW7xnjf1gqgKzPw5UBm5otQcCyVc=; b=m0oklpbHMHSvAIv6 e4GB3pxIvHi3cNzY7ndYtkhNsyPO2fsmSPj/2HU8XnmguTPeAGBz0LGdMkny3Mvw Wl+uT2fw4vhblBgRWHPQdKv4UPmKXgC5xd5mbe7i2B6NecSueo+GKCTfzJWnKiPF IDlgS+vt3VPOsTnqgSG+EmwnKBr0bm6lugIWPWAYDzZaunBPVo63b/2mf7Qxgeuy +8DOkuPzU8y3xf0ogyzPYXnEmt2TqdgnBbzhJ4x/8h4Qeg7o+zg65N2hrmx+lc8F dou2AbanwvWOL1mM7igQnDqnO/15dS9/fqmJqVy9p2RIFEL4yX4CAP9NW5eq+8GW fIzS9Q== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48urvyynbh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 02 Sep 2025 11:51:03 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-329d88c126cso934286a91.2 for ; Tue, 02 Sep 2025 04:51:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756813862; x=1757418662; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RXbXSoN8+xcQeFZSW7xnjf1gqgKzPw5UBm5otQcCyVc=; b=fOyaWlKgOyn/oA+FLAbUDk3bhVdGFU1WuQ9UiBVEU5JbVw98lLJ53EmTpdHunCJ1gC 6K6EQC+vD4H9kEWJTKdXlD2e4+GOKWHlSo2KRa3J1AlhbQjLieE1ZFBWsm7AsqUHlt/S pz1sYYmQ6uXH+R3rsmuNYeIueLbzDTYyFhLUAXCLyh6UoIFmv/eLOS7pgBdrLyeab7MW 7BoQkgSTILxj8FJTn3VOITju61/qVE8pBykbIeP4f4mAtd/lZvdjbsHxgj/aCH0x4vlm svfbL/r81qjq0bVgpS8UpCHSZZc3bzU7i706NRc+xdHwKIkXeYXSgm5UtFOiLMjdPLaW tBxQ== X-Forwarded-Encrypted: i=1; AJvYcCXby5uASwpOllmrA3jL4JNRfZqBCcmTBLUN8s1ovwsDyFjxo9pSL2uw8cCFWoum+abYYe+yKhdoSR/YDmc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0OIzkC/Vq0v7tRzz2dcJKgrhYs0rmjcIyr01ZDM1JzvGrEiYs m4mmjwhq8ZYhGtzzrRt6STwudGV5eYjGhLEK72ljiV040Vstq9LrDIUOP7i0WqscuEN/aMxJUKN tURm9JCXoTQwRX6INr26S6yD+ptY/g+ofFxCUHu7OcwvnpITfDxzOBAN/CCWc+GeMYmA= X-Gm-Gg: ASbGnctfET+1Rr4ThUqx0L8Po6C41GRIqDVlg7UsH1xjLKnKbMkoYlDut8MEYkhNIGH m51xmTHSpplWLeYCYe2tOT+eIyV0wuKbegjDJzHPddiZ6XhmVa7R9AHSVyxMooVrBan6yavDLp3 tFQ8gC85gnw1gDNDyoUWu+irFtZVqe8RTh961LKqg8KnUFylA/pE261Z882yroBWK2vfnH7RNik pCeh4y6LT05CheciPYMdOnzXWDIUjXfJRU834V1oWeeC5SvA9QyCYmZ9x/11tTyVlqEIZJgXI4n OQ2FLtkVqeuNHP3V/RYyE5zCr7qorAk4S791+vUDKZF7KpVvbZwv4YTjwr6058eA X-Received: by 2002:a17:90a:e7cc:b0:327:dce5:f644 with SMTP id 98e67ed59e1d1-32815436034mr14083559a91.11.1756813861799; Tue, 02 Sep 2025 04:51:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFoSouSKhDw/XMbQucJtw29inwJa9PXd0lM4uXnFSu8NXWhDmuE8ewb2G9NTAHJCIwa3AK6Vw== X-Received: by 2002:a17:90a:e7cc:b0:327:dce5:f644 with SMTP id 98e67ed59e1d1-32815436034mr14083530a91.11.1756813861277; Tue, 02 Sep 2025 04:51:01 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-329d089395esm3175428a91.1.2025.09.02.04.50.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Sep 2025 04:51:00 -0700 (PDT) From: Akhil P Oommen Date: Tue, 02 Sep 2025 17:20:03 +0530 Subject: [PATCH 4/4] drm/msm/a6xx: Add a comment to acd_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250902-assorted-sept-1-v1-4-f3ec9baed513@oss.qualcomm.com> References: <20250902-assorted-sept-1-v1-0-f3ec9baed513@oss.qualcomm.com> In-Reply-To: <20250902-assorted-sept-1-v1-0-f3ec9baed513@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Jordan Crouse , Jonathan Marek Cc: Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1756813835; l=862; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=u+jvzNK2e56X8NgPlWVyKgTqTb6j7//8GPSdT1wszhc=; b=h1wuLBfHfxcnM6zFAKgRxWdVDGgBm+1UEUHwJUPl+idhjvX3cN7t259RcLJnP/jnGewak+bBJ jWeTxOAo6mMC9ctIPcO0kjFFpFYt5i3C+xqg+hvMMdgsFtncKo35DtR X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-GUID: VqFCeHzeKmue8J86McoUV0wfjd1wXUkT X-Proofpoint-ORIG-GUID: VqFCeHzeKmue8J86McoUV0wfjd1wXUkT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODMwMDAyNyBTYWx0ZWRfX78b7Q00v2Py8 BDeIDT+PH7uGCyQuCQYcfjs3ANFe3asZcz9/kpS68qxWC4ZFZ6+JPmv15oSy/sCUWeC61yVvhcX pg4HZ7iClqT2/soSwfJUaDwSc5f97lPkpaZVrTrrcJYt5JhoPBVSjnr+vq/gN6znj72YI05SNJh yCz2vxgL6cQKBQPV0XVcNe585PMMz/jvFOFpVu0lxmEeRdqNo3ebu6SA4u21dr4JLfewADEm5NA NU5oJwgBNN4mA/TmtdgoHU723E84S+6uORPPqWuzZjpjG1beLiTGar+1bwyR4MjMiSsYDrteasI Kt5Ev/wvlDMP5UK0+dO3mPUGWtsHxu7Ck2jzmNjwSPgctp/6Jkm15UpxzlNiauRYQxSPB/Nvd9q OOVyvHMF X-Authority-Analysis: v=2.4 cv=NrDRc9dJ c=1 sm=1 tr=0 ts=68b6da27 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=7jaC3Q-7aBCS2g4HU_oA:9 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-02_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 malwarescore=0 priorityscore=1501 phishscore=0 impostorscore=0 spamscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508300027 It is not obvious why we can skip error checking of dev_pm_opp_find_freq_exact() API. Add a comment explaining it. Signed-off-by: Akhil P Oommen Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gmu.c index ea52374c9fcd481d816ed9608e9f6eb1c2e3005a..de8f7051402bf0fd931fc065b5c= 4c49e2bfd5dc7 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c @@ -1694,6 +1694,7 @@ static int a6xx_gmu_acd_probe(struct a6xx_gmu *gmu) u32 val; =20 freq =3D gmu->gpu_freqs[i]; + /* This is unlikely to fail because we are passing back a known freq */ opp =3D dev_pm_opp_find_freq_exact(&gpu->pdev->dev, freq, true); np =3D dev_pm_opp_get_of_node(opp); =20 --=20 2.50.1