From nobody Fri Oct 3 11:22:29 2025 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF0B24A04; Mon, 1 Sep 2025 16:33:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756744390; cv=none; b=t2hilMeqTvJAp0f/mxmhDJc9AnXEFFxD32NeFjB5laLTd/a4HCIRNrZ0GMIjNA5KDlJEKnKE3OlKzHjL7gFR+rFBBecgP9oxxG9NZw4mMweq8Sl9TVhmDc1Y3OY8OS1xYqS8lzEx0na00+cE8uv5qrS6dj4opNDtwTVVGOHd8KU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756744390; c=relaxed/simple; bh=nQcj10zejJVH/tr1l0+eer09KlIPCTau/PJeVg7QFzI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P1bsfA7/OZwTQaR8FAobgoYZP/XTKvTBAYYVUodNzgQ2+Pnt/+nxAR9pz2RQb+XATRoxv5gdI3DuxfLq9yyqnj95KUK4G51ym9iBOIzGYfLiLEo3xJH3FW/JuYPvq11k8JvGjBS9HiraplhYEvcxXTmKLa2lvPRLvdWanp0HuHI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d9bkBcQ8; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d9bkBcQ8" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-336b071e806so28741781fa.1; Mon, 01 Sep 2025 09:33:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756744387; x=1757349187; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3XMjqWfHnxx+2cq14q67XEqDooplTsFFIcuwaJm5RkY=; b=d9bkBcQ81uMw2Xk4mUOINv+x9gw66aLCjjelsaoJ+P/mNNCZc0uvMTnt1siT2qFsjy QVW4kXiaIe1Jluw0hpLTWTeMSbX09AncFlHmPIxo9se1/xZyUkfrvuC6NuSIEI8fk7jE 8BgDieQKNEyRtm1bf3EPM8kqBpozTOCXJmnI91G3HlT1IbZXatBeTr5zauveMn1Mj7mS IWrw+DJFZWjtNgGNF7eU7vwaGjzvefkd69YA1+2LvgY1ZgkxhDrnAJKjZZ07YEx77zYE ssyY0JEvi/52xzxt3tPpIImyuca5AFY2BTrXmlkGahHam6YOEpUpqFA0tdx5ofDFQdEt szgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756744387; x=1757349187; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3XMjqWfHnxx+2cq14q67XEqDooplTsFFIcuwaJm5RkY=; b=uABdD1v+JC3iHF9/xbgc8JtQs5DO4KwXMSSOouBvjfohfpOV2aD6yRQvz/pwuJ/4aA v2a2XJ5yuWd5inSSupOZ4uewzEAxRQnDfb/vqYEU2nbDvERyU/LCbpxvMejnnysQ+qEM KYpo900O+C1s6TwEWiT/Ltv3dhkLN2yOLjCNj+Pn81Iqtxt6RDOv27FAXJMkamUr0ZrD YOqskoIHDmpU/huHe8H+jJ6HtV4agwWD2bW0y5JIAf0heHCPmxzTrWZJoL3tHVN/J/j/ 0s/wvGiYVYcvdFfSI+nzHgvnrjaQBlYitGDu4L8ymUgKmWjj0XafVT+CgHjsDZzvekAG Fppw== X-Forwarded-Encrypted: i=1; AJvYcCVFyFhu9vcK1oOnPAGt+hSs08CfQkk1WeF3vp36QaShSWAFdsOKMenN+/P7FEYxDzwoh5ahR+h1ew==@vger.kernel.org, AJvYcCXbf02jjF/EeSsuseIThkbLJU+7NroP0vS3JegQcTKdIJyHQ0X+BxRlRxKUl4ZQFcgRfXksSM686S87CO6a@vger.kernel.org X-Gm-Message-State: AOJu0YxZ6FjHgAow4VJ/WJnFm5G4WsCuWDyOdKnKZ9h5t7pcK/NXAgUz rV0E9BEYBmRPACAR2KEc6U+Z+Bn2wS0PmyNlepVHwX1K0sXu4c+OX94v X-Gm-Gg: ASbGncvN1jqDepgNoCn4I1EZzpPGMNJb1j9gLDEkjhLGC+ND2OEZqbDA0WKEDwqq0bJ o5ti8PmLLFu2pPrgSxUTsTBRfYr6aS/rOgb4wlx/mD+6psOt7AASX/S2gI4QvpIfd13OIqaJN9a xSLnPD67kVhVMcYyCDil8xmx5oFqqzqsx25CORmeX1YhYp2YSEUSM+gBC+LF1XY0dfnUdeK9AwO 0bqLOx07B5oS75tBZd+DeTsJY1UqlWd55cvkC+V+GdFOmyRdEqTXFF1q2FurWmBNcecq/B+AN4P OjV15kd5fs86DQfnHu/JXVnwnXe05JfUB+AiM398NlZvPI5L7/7eNaaRpvRjQEtylXiOE6jDa7w BIWc31aRzBtRETEwjpSagwVbYRsqrI2LocdMrEYQHhw== X-Google-Smtp-Source: AGHT+IEVw8ibn5NsZeWB9fEuXwUWCNSL2Z/Kfo1KnKeiipMhJM1r3ia8OLUYuo+3dtfeyeQofbBxIw== X-Received: by 2002:a2e:b8ca:0:b0:336:cee0:d477 with SMTP id 38308e7fff4ca-336cee0d925mr23787551fa.27.1756744386636; Mon, 01 Sep 2025 09:33:06 -0700 (PDT) Received: from NB-6746.corp.yadro.com ([88.201.206.176]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-336d0e78e82sm15291861fa.53.2025.09.01.09.33.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Sep 2025 09:33:06 -0700 (PDT) From: Artem Shimko To: Sudeep Holla , Cristian Marussi Cc: Artem Shimko , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] firmware: arm_scmi: fix alignment in protocol_id_show and debugfs calls Date: Mon, 1 Sep 2025 19:33:00 +0300 Message-ID: <20250901163304.2504493-2-artyom.shimko@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250901163304.2504493-1-artyom.shimko@gmail.com> References: <20250901163304.2504493-1-artyom.shimko@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch fixes minor alignment/indentation issues in the SCMI driver: Adjusts indentation in protocol_id_show function to maintain consistency Fixes alignment in debugfs_create_file_aux_num calls in raw_mode.c Signed-off-by: Artem Shimko --- drivers/firmware/arm_scmi/bus.c | 2 +- drivers/firmware/arm_scmi/raw_mode.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bu= s.c index 24e59ddf85e7..e1e82139997c 100644 --- a/drivers/firmware/arm_scmi/bus.c +++ b/drivers/firmware/arm_scmi/bus.c @@ -298,7 +298,7 @@ static ssize_t modalias_show(struct device *dev, static DEVICE_ATTR_RO(modalias); =20 static ssize_t protocol_id_show(struct device *dev, - struct device_attribute *attr, char *buf) + struct device_attribute *attr, char *buf) { struct scmi_device *scmi_dev =3D to_scmi_dev(dev); =20 diff --git a/drivers/firmware/arm_scmi/raw_mode.c b/drivers/firmware/arm_sc= mi/raw_mode.c index 73db5492ab44..244453d3e7aa 100644 --- a/drivers/firmware/arm_scmi/raw_mode.c +++ b/drivers/firmware/arm_scmi/raw_mode.c @@ -1280,12 +1280,12 @@ void *scmi_raw_mode_init(const struct scmi_handle *= handle, chd =3D debugfs_create_dir(cdir, top_chans); =20 debugfs_create_file_aux_num("message", 0600, chd, - raw, channels[i], - &scmi_dbg_raw_mode_message_fops); + raw, channels[i], + &scmi_dbg_raw_mode_message_fops); =20 debugfs_create_file_aux_num("message_async", 0600, chd, - raw, channels[i], - &scmi_dbg_raw_mode_message_async_fops); + raw, channels[i], + &scmi_dbg_raw_mode_message_async_fops); =20 debugfs_create_file_aux_num("message_poll", 0600, chd, raw, channels[i], --=20 2.43.0 From nobody Fri Oct 3 11:22:29 2025 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1E0D2EC080; Mon, 1 Sep 2025 16:33:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756744391; cv=none; b=FxDzqlgXH20PXUhKHTxOS73cOx1DJuIRKrslJNnA4QC+3BiGbF5cvhM/HwhE2YSWAHRftfIOQdMmQC403rR+3FEBHZMzsQ452/i3hqTY5aH/9iSfRZI8rlAMNPnGJ6osyI5I8YDh9gdlU3FKsKZqJSo45psBQetmrh+qHm/Q6GM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756744391; c=relaxed/simple; bh=wBVV8lCyWpzak5Ahq0TyAHZqwjZBUNzGkG5CgU5NEkA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hLQHKnKcx0E1n7o/QKgi2ZAy7j1n4WAui2RLQD//Kqe/nYKcN8QPzo5/WxQtE9QT2QZKEYQazqbp3ZRFcsAvIUsNRw4J+zFVs4UktHVljqNL39Cw60ah+4bl6Kq/GLkvNJDG9iEjam+X8lj/XvyGCgiLMeX0M9fxicrGnupKvQw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h0Ql04zS; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h0Ql04zS" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-55f72452a8eso2219264e87.3; Mon, 01 Sep 2025 09:33:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756744388; x=1757349188; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QvGFPcLRQG7NDdcutxPYCIPA441LFKGMfIhq/xAeHWw=; b=h0Ql04zSGSubiWQspNo1Vv6iJbISjyVXHC5Ezic2B2CiXcpen+1hNCAQQWjC3JgYFC GaOPhU/GfUv8lRmkGMPEWcwywngegfCpNm5GjKz0r14eeA+wXo4wx7qst3eMSAsFDRbt zU8pQUikBF466bBnwSJiUStGgZ3jI9EwZWPISn5+cFWljsUqEQlgD5uoRQvtp6Ktbeuo Cv0ZPm9SZToJ2NjX8JMml0CKCKEl95CQg8BPPMoiFKrKT0pyFHL9557wZ5Y+sx8wpNp6 stsACoFFMth7pOTUXg9M/5yLQE5lQ/B8Y1U9GLCaw4+lRjrPbCPDHMDkrED2lkFuUAl8 Lh6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756744388; x=1757349188; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QvGFPcLRQG7NDdcutxPYCIPA441LFKGMfIhq/xAeHWw=; b=LD3BGSXxVSR9I9Vlux4Gp7rdML6FOTeQxhhB8gHXsYtcs4eiMokL/sbgc5oESkmrls D619d7J3y5dCjcpZT4fvgFIbt/ME2rEz4XzTgNtn2rhQ28PRo96CNdmIx/4I0weFCCb6 n2XGCvxwo/qxlMYYhLV6PzirY52LhIRgugCWGeW1hQsk0BIWKYbH8qyvcBiFTa91Z3/1 9e/1Oe6d9hb8iPLzGJ5ZNcHyfKox2JKJqxuDkozUauQoTUMIgbQOGXgb0h3pH4ZPUzUr JSY/ikxv0BasP4kt6hDHJ3PQwUrGJ7A/jtYW5oYzOfo70inOXo9ddKeKpKzJtNCgzkk+ Sb3Q== X-Forwarded-Encrypted: i=1; AJvYcCU2R3t1xP4AGP/avXf/lWoaCyKJxN+ROn1eYwluhpBuQlvZ5i7pEuxHCXlKD9nvcuz+g6sdTcU4kA==@vger.kernel.org, AJvYcCV0oqgxI70uCV4hBmKfGP9KCZET8ltW9wBsAqgQ5tyQYSkKAsyVMUMzW1FBzUgnR75pEMyjGT4gAo5lLiNF@vger.kernel.org X-Gm-Message-State: AOJu0Yymnlo/2wv5GOCllc0F9FZGaakFOFVaghoCsBDK/eKfht/dQ3HP /3n2NEZrpyxqylOx6w///frm2tZBNMMrzVXoBqddcsw17Ds8ZAQexVUX X-Gm-Gg: ASbGncu2qxbC04sizlzDk/yLdWmKOFQ3urH4EJqR+GRSjfqa6q/PXAvgYiOiB9e3Dw6 U6cCTpnMWVbVXljCtOeh0GZbIfgTXfrEFCqiffyzx6rNneOY7uGPZQ83LYKu71bHJK6XA4pqWvx 2T5xcYsrDr8+6hD60fKitXh05qWzwTNP0vroOi7wLIXa/V9AZKbWiLF/I7Hb8M+obW/GhjbyH2A Lceqt+32LJgGWuJjIvJQyCDtPJk66AjRdu9MYpr5GhzL6g5BxpgM/XoxqQcppyBFJU/72G73nEk fOS9fDHSHfXommibAGsJAbWgrkWDdnyDwBGYs7i/Pj33Gn0aQScIychl7PNLmAIgNd/EA8tNAil t/ChCSR/EOvDDwP6KAaWFtezbpaC2ZFcx9evhteAvew== X-Google-Smtp-Source: AGHT+IG3UXE73EbhUolTZUA009n6afCvf/c7qZpC2nZYu33/7lnWpLXjusYs+O+48Y7iJdz2RPqajQ== X-Received: by 2002:a05:651c:4183:b0:335:2d39:efe8 with SMTP id 38308e7fff4ca-336cb148b70mr21019411fa.44.1756744388011; Mon, 01 Sep 2025 09:33:08 -0700 (PDT) Received: from NB-6746.corp.yadro.com ([88.201.206.176]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-336d0e78e82sm15291861fa.53.2025.09.01.09.33.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Sep 2025 09:33:07 -0700 (PDT) From: Artem Shimko To: Sudeep Holla , Cristian Marussi Cc: Artem Shimko , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] firmware: arm_scmi: add missing spinlock documentation Date: Mon, 1 Sep 2025 19:33:01 +0300 Message-ID: <20250901163304.2504493-3-artyom.shimko@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250901163304.2504493-1-artyom.shimko@gmail.com> References: <20250901163304.2504493-1-artyom.shimko@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds a missing comment for xfer_lock spinlock in struct scmi_xfers_info. The spinlock protects access to the xfer buffers and transfer allocation mechanism, preventing race conditions in concurrent access scenarios. Signed-off-by: Artem Shimko --- drivers/firmware/arm_scmi/driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi= /driver.c index bd56a877fdfc..6828392152f4 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -76,6 +76,7 @@ static struct dentry *scmi_top_dentry; */ struct scmi_xfers_info { unsigned long *xfer_alloc_table; + /* Protects access to the xfer buffers */ spinlock_t xfer_lock; int max_msg; struct hlist_head free_xfers; --=20 2.43.0