From nobody Fri Oct 3 11:22:52 2025 Received: from mail1.fiberby.net (mail1.fiberby.net [193.104.135.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67871214210; Mon, 1 Sep 2025 14:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.104.135.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756738340; cv=none; b=VV8KaQcmimqVbjahKd3zZvxan51l91AQ8Q8hwIi7JArvpfMaXgSHr808LRdoHW2Fv9xDL14CmzSBJYs/SwZsGzTx/4QDnR4YAcdDWpStDtD8/Cl29cGYEu5DgEUJUbMMev76TwpaZNU9brmxPm8A44k6okTBpA+WDj+RR/TlzMk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756738340; c=relaxed/simple; bh=KRQXLnLWCIStjwU1PJ0qUlA5bTV+OsW/zTXcSrBlAVQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iv0nOl5YMen3CoAQSRqzGaR/OazUV/uyl3qrR/0lb3tbFx1yLeLxiaqiAuS82B1MVfO+rfm0mIPwbdUXJ1kNbcIJaK1gmc/z1eFLA0hPluLeYHQf/QEJX7lz806lV8BAoLGyrCtGEgKOnz6cYRFHvfelDJoeQoW74cV7ULJBID4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net; spf=pass smtp.mailfrom=fiberby.net; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b=lEoyYAZE; arc=none smtp.client-ip=193.104.135.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fiberby.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b="lEoyYAZE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiberby.net; s=202008; t=1756738334; bh=KRQXLnLWCIStjwU1PJ0qUlA5bTV+OsW/zTXcSrBlAVQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lEoyYAZE4LBlNvQLwJDr+z53za758eHXv0ULf741D8USuM3M+5V4EJdihow8dsQBP n2axbvChSsi6Qn8X43XBpwezhTGHy/rojp7OhEokMtUTlJYOWKuYsgFDBBf62vwQKO +iODzQf/LbVokRz8AcM1LwK3aYBPWPTxzUTKEmlPx6EkJ1YzTsnUwkOwYWmk6848L+ fqi/DQuCrwJxV5nLPY7aXX/8O3LRnhKcLtRN2lfc1XnwkLskpU4fIGqntljvbjmfgT HNNg6wIYNcgfdoON75UEgLmLAIjho6ClRd2g3tyGfqkxQ7MrGKQn/f+TcyXuLwpjTT BDrOpsEx/BRRg== Received: from x201s (193-104-135-243.ip4.fiberby.net [193.104.135.243]) by mail1.fiberby.net (Postfix) with ESMTPSA id E873660128; Mon, 1 Sep 2025 14:51:16 +0000 (UTC) Received: by x201s (Postfix, from userid 1000) id EC95420226D; Mon, 01 Sep 2025 14:50:54 +0000 (UTC) From: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= , Donald Hunter , Simon Horman , Jacob Keller , Stanislav Fomichev , "Matthieu Baerts (NGI0)" , David Ahern , Chuck Lever , wireguard@lists.zx2c4.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 1/4] netlink: specs: fou: change local-v6/peer-v6 check Date: Mon, 1 Sep 2025 14:50:20 +0000 Message-ID: <20250901145034.525518-2-ast@fiberby.net> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250901145034.525518-1-ast@fiberby.net> References: <20250901145034.525518-1-ast@fiberby.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable While fixing the binary min-len implementaion, I noticed that the only user, should AFAICT be using exact-len instead. In net/ipv4/fou_core.c FOU_ATTR_LOCAL_V6 and FOU_ATTR_PEER_V6 are only used for singular IPv6 addresses, a exact-len policy, therefore seams like a better fit. AFAICT this was caused by lacking support for the exact-len check at the time of the blamed commit, which was later remedied by c63ad379526 ("tools: ynl-gen: add support for exact-len validation"). This patch therefore changes the local-v6/peer-v6 attributes to use an exact-len check, instead of a min-len check. Fixes: 4eb77b4ecd3c ("netlink: add a proto specification for FOU") Signed-off-by: Asbj=C3=B8rn Sloth T=C3=B8nnesen --- Documentation/netlink/specs/fou.yaml | 4 ++-- net/ipv4/fou_nl.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/netlink/specs/fou.yaml b/Documentation/netlink/s= pecs/fou.yaml index 57735726262ec..8e7974ec453fc 100644 --- a/Documentation/netlink/specs/fou.yaml +++ b/Documentation/netlink/specs/fou.yaml @@ -52,7 +52,7 @@ attribute-sets: name: local-v6 type: binary checks: - min-len: 16 + exact-len: 16 - name: peer-v4 type: u32 @@ -60,7 +60,7 @@ attribute-sets: name: peer-v6 type: binary checks: - min-len: 16 + exact-len: 16 - name: peer-port type: u16 diff --git a/net/ipv4/fou_nl.c b/net/ipv4/fou_nl.c index 3d9614609b2d3..506260b4a4dc2 100644 --- a/net/ipv4/fou_nl.c +++ b/net/ipv4/fou_nl.c @@ -18,9 +18,9 @@ const struct nla_policy fou_nl_policy[FOU_ATTR_IFINDEX + = 1] =3D { [FOU_ATTR_TYPE] =3D { .type =3D NLA_U8, }, [FOU_ATTR_REMCSUM_NOPARTIAL] =3D { .type =3D NLA_FLAG, }, [FOU_ATTR_LOCAL_V4] =3D { .type =3D NLA_U32, }, - [FOU_ATTR_LOCAL_V6] =3D { .len =3D 16, }, + [FOU_ATTR_LOCAL_V6] =3D NLA_POLICY_EXACT_LEN(16), [FOU_ATTR_PEER_V4] =3D { .type =3D NLA_U32, }, - [FOU_ATTR_PEER_V6] =3D { .len =3D 16, }, + [FOU_ATTR_PEER_V6] =3D NLA_POLICY_EXACT_LEN(16), [FOU_ATTR_PEER_PORT] =3D { .type =3D NLA_BE16, }, [FOU_ATTR_IFINDEX] =3D { .type =3D NLA_S32, }, }; --=20 2.50.1 From nobody Fri Oct 3 11:22:52 2025 Received: from mail1.fiberby.net (mail1.fiberby.net [193.104.135.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE5EC2EDD76; Mon, 1 Sep 2025 14:52:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.104.135.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756738339; cv=none; b=clnQpwz1Fp4mwT3MH2DXQ9gyZ0S+3nZYcGWU/ScCw/tS7T9ktAiGP6aW586jCs0Ws5fqQMuJIdFDceOyqg6q8TQK9cr5JYVkxnrA53+936zOHwg2OrfSt/XgwkB9M/ewPUSyr1Z+GMGfO+XNUV4oK457fPXrW7WQAsZvewHaYW0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756738339; c=relaxed/simple; bh=bwutvYte2v5M5foMclZwyKV+peJI6XWuEXuXe4HoaBw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cfo5efzLoP4TSwfIKbZKHkMPmpFT039q/d1c90e/TVbwgafy87LoV2nbRhoHYcDlfS1yc1qx/9j/otdmst4rS5dcQJ3qDSoOvLpd1NiPJEQ4QyonbCporQBaD/nOtu/P3+Xb3nF/lhCu4q5vhW062h5DLQcCKF4X+LoVn6fSzjg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net; spf=pass smtp.mailfrom=fiberby.net; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b=SfTXFqew; arc=none smtp.client-ip=193.104.135.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fiberby.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b="SfTXFqew" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiberby.net; s=202008; t=1756738334; bh=bwutvYte2v5M5foMclZwyKV+peJI6XWuEXuXe4HoaBw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SfTXFqewM4mrjsNbqjjJYpkzNzQSs7ILBxImJU2Q2lcDK1cdNpH0oOh/BRtAGjOvy +telnDst07ECMTXoE312nn9vwMyp6X3wGPj5qjxhBZeX/5zuOSmk0Zf7muQPW8wmgQ nSRlxYeZKCZ7N21bs9DYXi+6ZFjbHLa52GINp5PCyUY4h5filyjlPVzm4V8rFL6qgz szjTmpdfv4rm/y/KomFOD05ixOEbs74pQF72HHQH3SzQ9TY7PbB4ioCChQOCsexwsC TCATXFxr/xnZicSZUWjWdYzqEUGJ1+Jl64mnFRP9uBHxn4cSDlPpwaBJsvRQGkdEnk PGuFwq/cqDh8A== Received: from x201s (193-104-135-243.ip4.fiberby.net [193.104.135.243]) by mail1.fiberby.net (Postfix) with ESMTPSA id EADA26012E; Mon, 1 Sep 2025 14:51:16 +0000 (UTC) Received: by x201s (Postfix, from userid 1000) id 1106A202271; Mon, 01 Sep 2025 14:50:56 +0000 (UTC) From: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= , Donald Hunter , Simon Horman , Jacob Keller , Stanislav Fomichev , "Matthieu Baerts (NGI0)" , David Ahern , Chuck Lever , wireguard@lists.zx2c4.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 2/4] tools: ynl-gen: use macro for binary min-len check Date: Mon, 1 Sep 2025 14:50:21 +0000 Message-ID: <20250901145034.525518-3-ast@fiberby.net> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250901145034.525518-1-ast@fiberby.net> References: <20250901145034.525518-1-ast@fiberby.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This patch changes the generated min-len check for binary attributes to use the NLA_POLICY_MIN_LEN() macro, and thereby ensures that .validation_type is not left at NLA_VALIDATE_NONE. This doesn't change any currently generated code, as it isn't used in any specs currently used for generating code. Fixes: be5bea1cc0bf ("net: add basic C code generators for Netlink") Signed-off-by: Asbj=C3=B8rn Sloth T=C3=B8nnesen --- tools/net/ynl/pyynl/ynl_gen_c.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/net/ynl/pyynl/ynl_gen_c.py b/tools/net/ynl/pyynl/ynl_gen= _c.py index ef032e17fec44..52f955ed84a7f 100755 --- a/tools/net/ynl/pyynl/ynl_gen_c.py +++ b/tools/net/ynl/pyynl/ynl_gen_c.py @@ -556,7 +556,7 @@ class TypeBinary(Type): elif 'exact-len' in self.checks: mem =3D 'NLA_POLICY_EXACT_LEN(' + self.get_limit_str('exact-le= n') + ')' elif 'min-len' in self.checks: - mem =3D '{ .len =3D ' + self.get_limit_str('min-len') + ', }' + mem =3D 'NLA_POLICY_MIN_LEN(' + self.get_limit_str('min-len') = + ')' elif 'max-len' in self.checks: mem =3D 'NLA_POLICY_MAX_LEN(' + self.get_limit_str('max-len') = + ')' =20 --=20 2.50.1 From nobody Fri Oct 3 11:22:52 2025 Received: from mail1.fiberby.net (mail1.fiberby.net [193.104.135.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88B631B4F2C; Mon, 1 Sep 2025 14:52:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.104.135.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756738340; cv=none; b=iGOF/efoDMQ/JQZLqwZVJnB0+Jvbzr/GVz/tgjaW2stY6oiUbJ+ttKSs1oJIOqPi3wvHjKu6co0fA6RQ/ICeM4ZfIskq2qOu7HOMDM7A74yXs5AbhNLBzZeNAFOEnVdt1Ml+rB73Vwj/yCla+eKk2virWKp21++xS2hEUwoN/UQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756738340; c=relaxed/simple; bh=APyzJaKTB6ST0FmLzhCiqv/pck8FVVt3+BQEdNx2Pcg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HggNurqjDPfauYMYGqn5ojxAsHcCZj1aBjN8c8ojyyNvwlBx5fvwC1ZzMklF/v+Nrx+P8CCrUPmI8Cig3bKjI32PE31H0JOBFQNyTP+mh51o/sekLn28jBfKZ59zDvnuo2wX9F2e+tWQ29O5AHwiUycjAqJAi60870LqQ93FO/8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net; spf=pass smtp.mailfrom=fiberby.net; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b=R6g1/hga; arc=none smtp.client-ip=193.104.135.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fiberby.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b="R6g1/hga" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiberby.net; s=202008; t=1756738334; bh=APyzJaKTB6ST0FmLzhCiqv/pck8FVVt3+BQEdNx2Pcg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R6g1/hga27RqGOi1Hn35l6Z9Os5REV0aAX34b2TJmLJAy7sMy5DeyPgDzFMA/kVd4 MPI3/YGcwRc0xey3IsjZkPsOpNf74oc+YOXJxGmIPBWyafs4gfGYuVFuv6kzI+SrVs 3gkUmnSEf0rqQ37E5sQ+EAJLf7zi43bUqXNNtCwFXEKNzC5ukQsh0/pkRxwG416Y+X 9tpNoox0nHLEv7BU8dvHf3o8FHP1PB8mP0Un8ai9p21/pqBEJrIDIkCA/xFibG8Yfw 4g1MX/7RxhWyCu1OXj+Ji/V5p7LsAF9tdDdIiNi2+A63K0USYwacMwrVwVHSoTszBB 8ZzAt9O8aazBQ== Received: from x201s (193-104-135-243.ip4.fiberby.net [193.104.135.243]) by mail1.fiberby.net (Postfix) with ESMTPSA id D8E986000C; Mon, 1 Sep 2025 14:51:16 +0000 (UTC) Received: by x201s (Postfix, from userid 1000) id BFCD72022B0; Mon, 01 Sep 2025 14:50:56 +0000 (UTC) From: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= , Donald Hunter , Simon Horman , Jacob Keller , Stanislav Fomichev , "Matthieu Baerts (NGI0)" , David Ahern , Chuck Lever , wireguard@lists.zx2c4.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 3/4] tools: ynl-gen: fix nested array counting Date: Mon, 1 Sep 2025 14:50:22 +0000 Message-ID: <20250901145034.525518-4-ast@fiberby.net> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250901145034.525518-1-ast@fiberby.net> References: <20250901145034.525518-1-ast@fiberby.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The blamed commit introduced the concept of split attribute counting, and later allocating an array to hold them, however TypeArrayNest wasn't updated to use the new counting variable. Abbreviated example from tools/net/ynl/generated/nl80211-user.c: nl80211_if_combination_attributes_parse(...): unsigned int n_limits =3D 0; [...] ynl_attr_for_each(attr, nlh, yarg->ys->family->hdr_len) if (type =3D=3D NL80211_IFACE_COMB_LIMITS) ynl_attr_for_each_nested(attr2, attr) dst->_count.limits++; if (n_limits) { dst->_count.limits =3D n_limits; /* allocate and parse attributes */ } In the above example n_limits is guaranteed to always be 0, hence the conditional is unsatisfiable and is optimized out. This patch changes the attribute counting to use n_limits++ in the attribute counting loop in the above example. Fixes: 58da455b31ba ("tools: ynl-gen: improve unwind on parsing errors") Signed-off-by: Asbj=C3=B8rn Sloth T=C3=B8nnesen Reviewed-by: Jakub Kicinski --- tools/net/ynl/pyynl/ynl_gen_c.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/net/ynl/pyynl/ynl_gen_c.py b/tools/net/ynl/pyynl/ynl_gen= _c.py index 52f955ed84a7f..fb7e03805a113 100755 --- a/tools/net/ynl/pyynl/ynl_gen_c.py +++ b/tools/net/ynl/pyynl/ynl_gen_c.py @@ -830,7 +830,7 @@ class TypeArrayNest(Type): 'ynl_attr_for_each_nested(attr2, attr) {', '\tif (ynl_attr_validate(yarg, attr2))', '\t\treturn YNL_PARSE_CB_ERROR;', - f'\t{var}->_count.{self.c_name}++;', + f'\tn_{self.c_name}++;', '}'] return get_lines, None, local_vars =20 --=20 2.50.1 From nobody Fri Oct 3 11:22:52 2025 Received: from mail1.fiberby.net (mail1.fiberby.net [193.104.135.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 678DE26FA6F; Mon, 1 Sep 2025 14:52:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.104.135.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756738339; cv=none; b=phq+cIxzo/u/VdbBtof+z3IWOYwnOZV8DmW7G2ANO85lJkgbu+lns1X5TZsqlmCeIZIaDApP6lU5tsg5v1GIO9q4YOM16IAf2vIMdIEv3ou8tIZa28x1fmJzkxRNAdgf6opqS9Yl1kq6Kr783AAJs/HIvTyNMSXspQ3eQUMd1nw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756738339; c=relaxed/simple; bh=A3oQDNtC9t8GXyz1Onu5bXHPGEEu2KnjT/PlSY2LNfQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bb2/g1GlEJ5cZeK8smJ6+dBSxlfcLCmAd18EGA7AQbpQBClUqYT/qu1TdJgHdthI8zwS2ukdVEAKDaIEMVccHg5ndto2YfrcHa5hgugDMuVtmZXsYBFyRAxylmi0tqnZ/0vllMm1o9lQjcMYmFecDN2y7GjP824vorH5xiTC3OQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net; spf=pass smtp.mailfrom=fiberby.net; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b=YZcn32pR; arc=none smtp.client-ip=193.104.135.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fiberby.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b="YZcn32pR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiberby.net; s=202008; t=1756738334; bh=A3oQDNtC9t8GXyz1Onu5bXHPGEEu2KnjT/PlSY2LNfQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YZcn32pRvgCPxUHhdbcid7QSZs4Y0AsQQQOBZ4giN4TxgRTjsm/pQQicMkxrkngsQ +r1+J3vWSQLG4DNXN6ftUKzlB3ZS6ViJCAmDaSBnBPDWtpoN9D3TVtkpbyJhjp9kWq UUZToBMPGAlr+kFkxdPyxQY9njO4xtPk+1BzzCwUwKTVlU5fwlhXvnbaPt66SbFf84 bpXrwF2C8BM9DQy2F+kUynrTgkzaGjn4x2FNNd82oB38Cq9/Uly0g+iKlzqxdh6hA6 6kOKLM/fH9fHPYAYVXYHyF5v7C9bGG0D+P4Ntpak4Q6F//oPAo0HJeT+iHUNhJA1Wh 2nr6CXCZRD5fQ== Received: from x201s (193-104-135-243.ip4.fiberby.net [193.104.135.243]) by mail1.fiberby.net (Postfix) with ESMTPSA id DC5B160078; Mon, 1 Sep 2025 14:51:16 +0000 (UTC) Received: by x201s (Postfix, from userid 1000) id 82082202310; Mon, 01 Sep 2025 14:50:57 +0000 (UTC) From: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= , Donald Hunter , Simon Horman , Jacob Keller , Stanislav Fomichev , "Matthieu Baerts (NGI0)" , David Ahern , Chuck Lever , wireguard@lists.zx2c4.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 4/4] genetlink: fix typo in comment Date: Mon, 1 Sep 2025 14:50:23 +0000 Message-ID: <20250901145034.525518-5-ast@fiberby.net> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250901145034.525518-1-ast@fiberby.net> References: <20250901145034.525518-1-ast@fiberby.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable In this context "not that ..." should properly be "note that ...". Fixes: b8fd60c36a44 ("genetlink: allow families to use split ops directly") Signed-off-by: Asbj=C3=B8rn Sloth T=C3=B8nnesen --- include/net/genetlink.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/genetlink.h b/include/net/genetlink.h index a03d567658328..7b84f2cef8b1f 100644 --- a/include/net/genetlink.h +++ b/include/net/genetlink.h @@ -62,7 +62,7 @@ struct genl_info; * @small_ops: the small-struct operations supported by this family * @n_small_ops: number of small-struct operations supported by this family * @split_ops: the split do/dump form of operation definition - * @n_split_ops: number of entries in @split_ops, not that with split do/d= ump + * @n_split_ops: number of entries in @split_ops, note that with split do/= dump * ops the number of entries is not the same as number of commands * @sock_priv_size: the size of per-socket private memory * @sock_priv_init: the per-socket private memory initializer --=20 2.50.1