From nobody Fri Oct 3 12:16:38 2025 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7D741E868; Mon, 1 Sep 2025 07:38:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756712284; cv=none; b=jKXVUv6EHDLLU4ddmy+wnrF3iiz2O4P9Kchb4yHNsyGKx3D02ESeagmi0NfZMo5I+4XwlBdvrRYv/d5IKK1KhRxbwZPongCOj6uM5CLw6LrBsaDcTFXqSXuXafl2gBhMeUWY+ONypEE0eRZg7S203mF3RaT7Bqj2JYoslVkam2s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756712284; c=relaxed/simple; bh=jAfgCrmovXTASeSG0seHoaOGT+mdDgAHBM64F+u2jtE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fZfKkcJatu3c+AN7RoqYhh0T2RqL9jHhGE652Ms4awlwGzMWTXt3b7RZ82rQ9NVu4d5aqA6TwNwjAYpfYJF8DmGnyb54BC6otsWaYTnO/dvMzS03MiPX/t/nE+x1U02FYgWUxv6nnFuCEp6iJO8YdSvxavS/s1wKh/uQIF08Jk0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Clok89JB; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Clok89JB" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-b4cb3367d87so2032736a12.3; Mon, 01 Sep 2025 00:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756712282; x=1757317082; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QlS6s9xBoj0Gsoj15IeDcSfwqpbtZrjtwfLutLxFrM0=; b=Clok89JBrcjaQ2+Vz9WXFGqDWYhINOBIy7gQMmZ/uk9AkG+hTpKHBBqPaFvxLUKV7i 6q6O7yl5xC1tGMHch+z5+43YpD5Nm9V2YSrLR60rFJgcH6ZFoFqnIesDYgNIjOyx6AOQ rnMoZmpLp79dC++QezqrwZIrYNgBYrtBHyDOLheLUlxcIXAFE/er+i+VITV4lymnaswZ y0zAWFycJ860SjfeBXMjTquUMjjw2tb6gTuc12tLwRmqsS57cGxLNcYJEOns9ZsELzuH pScmLiiHbsrHwW1DBlpW21ltBhv5VPTAYRk+nx8sFAOeDfIlmnUxwWv/FSzi2tbpZ4a4 n0NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756712282; x=1757317082; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QlS6s9xBoj0Gsoj15IeDcSfwqpbtZrjtwfLutLxFrM0=; b=mWFI26v71LklNc82z65tpRDPQ62hCP+V+U4PMthtxMa2BDpzN15vS+8u163xJMiQlv aO/fYva5hBfkk0VHPvyO7Vxtqh5hz4XC11YxQzOeIgYLlxgSINDkhdYPenCUhk0zb5F2 CKuzS/jajP0RBZPIHJLrt7T9kAUcU0n+EU82neoQrQ24D1n2kIIeFnoptO6VqTqYGaVh M6b90EzOo48I2OOVmBoAB2sAChtUm4OO8ZUW0wZ5VfQckE4P+UZWt9KZp8wRg/+d5wjr Z4cRtwfu+cnFVzQIx60jN5xQxbSLVJ81k4q2EbE7SqUCCTqmkAvT6leTa3brhTxiyst5 FAiA== X-Gm-Message-State: AOJu0YypTDQwoqYU0uO5OkS59qL3mvwERlNpQQUtt1mELXX0xfzrDB0w gaj8vWVjHf1JN2fqtzmgmwdoc5rOpoFzG7VNI8g1ATNXSf5Ot2CGBKmQm/nPbA== X-Gm-Gg: ASbGncuM40Nu8WGZMc+1bQGxeILvNbCaFaUZWFjYYRshP1w2XGpSFNKwKIQPiEz1vPS EeMpbyo2KcTsMrXUdgE++vLjPzNYHi3jcwpKLmJqFiFk2LY/l/JWLmUB+6C2wJmN2pStWcbrFPY /Ys87C6j/DgNxc8rC9f1rAAoc3J27QhVFivakT9y4BN9vtbE2bEJZCnvHX+BE/PxlsQbErLaHym M801+P9tzEbWabD6Hx04FApnhIcIS6HBbW21JEfVFfcXARLbhPfnh4ZOU9ebIK7qEWdB9YzWkkY 2YUjZ0TOGORxr2dUuH8egEihIO8cb8AZgp68+Zhh30cn3WVJhEyLlrimLbis1tEe2TfBZVnokNL RenhHHV7zjE1Waa3E4xGtH1nGZGB9IHaFV5gp90S65Cf0PBixNeE= X-Google-Smtp-Source: AGHT+IFBa9YIxUxfvPklfq7ICZ6Mprmrrg84pYsUW/IV/7FZKdeJpVxqGnCn7Cgi5itSIo9WzCI4Zw== X-Received: by 2002:a17:903:1211:b0:246:ceda:ebeb with SMTP id d9443c01a7336-24944aa2848mr85094795ad.33.1756712282012; Mon, 01 Sep 2025 00:38:02 -0700 (PDT) Received: from localhost ([77.111.118.146]) by smtp.gmail.com with UTF8SMTPSA id 41be03b00d2f7-b4de04a9ea7sm6489148a12.16.2025.09.01.00.38.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Sep 2025 00:38:01 -0700 (PDT) From: Mohammad Amin Hosseini To: linux-iio@vger.kernel.org, linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, Mohammad Amin Hosseini Subject: [PATCH v3] staging: iio: adc: ad7816: add mutex to serialize SPI/GPIO operations Date: Mon, 1 Sep 2025 11:07:50 +0330 Message-ID: <20250901073750.22687-1-moahmmad.hosseinii@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The ad7816 driver was accessing SPI and GPIO lines without synchronization, which could lead to race conditions when accessed concurrently from multiple contexts. This might result in corrupted readings or inconsistent GPIO states. Introduce an io_lock mutex in the driver structure to serialize: - SPI transactions in ad7816_spi_read() and ad7816_spi_write() - GPIO pin toggling sequences - Updates to device state via sysfs store functions (mode, channel, oti) The mutex ensures proper mutual exclusion and prevents race conditions under concurrent access. Signed-off-by: Mohammad Amin Hosseini --- Changes in v3: - Restore proper capitalization in From:/Signed-off-by lines - Move v2 changelog below the --- line Changes in v2: - Fixed mismatch between From: and Signed-off-by lines - Verified style compliance with checkpatch.pl --- drivers/staging/iio/adc/ad7816.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index 4774df778de9..06567d048a6d 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -50,6 +50,7 @@ struct ad7816_chip_info { u8 oti_data[AD7816_CS_MAX + 1]; u8 channel_id; /* 0 always be temperature */ u8 mode; + struct mutex io_lock; /* Protects SPI transactions and GPIO toggling */ }; =20 enum ad7816_type { @@ -67,13 +68,13 @@ static int ad7816_spi_read(struct ad7816_chip_info *chi= p, u16 *data) int ret; __be16 buf; =20 + mutex_lock(&chip->io_lock); + gpiod_set_value(chip->rdwr_pin, 1); gpiod_set_value(chip->rdwr_pin, 0); ret =3D spi_write(spi_dev, &chip->channel_id, sizeof(chip->channel_id)); - if (ret < 0) { - dev_err(&spi_dev->dev, "SPI channel setting error\n"); - return ret; - } + if (ret < 0) + goto unlock; gpiod_set_value(chip->rdwr_pin, 1); =20 if (chip->mode =3D=3D AD7816_PD) { /* operating mode 2 */ @@ -92,13 +93,13 @@ static int ad7816_spi_read(struct ad7816_chip_info *chi= p, u16 *data) gpiod_set_value(chip->rdwr_pin, 0); gpiod_set_value(chip->rdwr_pin, 1); ret =3D spi_read(spi_dev, &buf, sizeof(*data)); - if (ret < 0) { - dev_err(&spi_dev->dev, "SPI data read error\n"); - return ret; - } + if (ret < 0) + goto unlock; =20 *data =3D be16_to_cpu(buf); =20 +unlock: + mutex_unlock(&chip->io_lock); return ret; } =20 @@ -107,12 +108,13 @@ static int ad7816_spi_write(struct ad7816_chip_info *= chip, u8 data) struct spi_device *spi_dev =3D chip->spi_dev; int ret; =20 + mutex_lock(&chip->io_lock); + gpiod_set_value(chip->rdwr_pin, 1); gpiod_set_value(chip->rdwr_pin, 0); ret =3D spi_write(spi_dev, &data, sizeof(data)); - if (ret < 0) - dev_err(&spi_dev->dev, "SPI oti data write error\n"); =20 + mutex_unlock(&chip->io_lock); return ret; } =20 @@ -136,6 +138,7 @@ static ssize_t ad7816_store_mode(struct device *dev, struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); =20 + mutex_lock(&chip->io_lock); if (strcmp(buf, "full") =3D=3D 0) { gpiod_set_value(chip->rdwr_pin, 1); chip->mode =3D AD7816_FULL; @@ -143,6 +146,7 @@ static ssize_t ad7816_store_mode(struct device *dev, gpiod_set_value(chip->rdwr_pin, 0); chip->mode =3D AD7816_PD; } + mutex_unlock(&chip->io_lock); =20 return len; } @@ -200,7 +204,9 @@ static ssize_t ad7816_store_channel(struct device *dev, return -EINVAL; } =20 + mutex_lock(&chip->io_lock); chip->channel_id =3D data; + mutex_unlock(&chip->io_lock); =20 return len; } @@ -322,7 +328,9 @@ static inline ssize_t ad7816_set_oti(struct device *dev, if (ret) return -EIO; =20 + mutex_lock(&chip->io_lock); chip->oti_data[chip->channel_id] =3D data; + mutex_unlock(&chip->io_lock); =20 return len; } @@ -363,6 +371,7 @@ static int ad7816_probe(struct spi_device *spi_dev) dev_set_drvdata(&spi_dev->dev, indio_dev); =20 chip->spi_dev =3D spi_dev; + mutex_init(&chip->io_lock); for (i =3D 0; i <=3D AD7816_CS_MAX; i++) chip->oti_data[i] =3D 203; =20 --=20 2.43.0