From nobody Fri Oct 3 12:14:52 2025 Received: from unicom146.biz-email.net (unicom146.biz-email.net [210.51.26.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 760652472AA; Mon, 1 Sep 2025 06:46:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.51.26.146 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756709195; cv=none; b=dYgjgJ52kUtpEo6bWVkSjWdzl14s+gsZ6H7uyi0vA9apWlqdbJauTrBYnTdjiB4tURh28wl091mPMXtIdTJo3OsNAfa9qNKODjLKWVC7T3VGno6EZNqnovBdRLlEaSy5s9ChjtA9/uxBgWhDtxyfM5yMU0qbidLs5UDAv0A+VuU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756709195; c=relaxed/simple; bh=lPUfn0B6m68xQeVnP22kowPxW+j7Mm9qaVRRE/WoGQ4=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=sWc/Nc8jsTK5X1iazgkufCuJalD5QfkQaoGvCtCkQdJ1ka2eBSegesUYS9TtUmvvIyplEOz2YGqlYrGCmgjEwX9gY3Dlyla//I0d56EELuQrfNedBpUVGi0DQuE0BSs4TVZXfeF0ZJ9qFDLnjhLip9LNCbfKxlBdfclFhcp4xGQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=inspur.com; spf=pass smtp.mailfrom=inspur.com; arc=none smtp.client-ip=210.51.26.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=inspur.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inspur.com Received: from jtjnmail201608.home.langchao.com by unicom146.biz-email.net ((D)) with ASMTP (SSL) id 202509011445132046; Mon, 01 Sep 2025 14:45:13 +0800 Received: from locahost.localdomain.com (10.94.9.245) by jtjnmail201608.home.langchao.com (10.100.2.8) with Microsoft SMTP Server id 15.1.2507.57; Mon, 1 Sep 2025 14:45:14 +0800 From: Charles Han To: , , , , CC: , , Charles Han Subject: [PATCH] iio: adc: Fix a null pointer dereference in pac1934_acpi_parse_channel_config Date: Mon, 1 Sep 2025 14:45:11 +0800 Message-ID: <20250901064512.1554-1-hanchunchao@inspur.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable tUid: 2025901144514a21115e7c8012b04e761447f998e6e63 X-Abuse-Reports-To: service@corp-email.com Abuse-Reports-To: service@corp-email.com X-Complaints-To: service@corp-email.com X-Report-Abuse-To: service@corp-email.com Content-Type: text/plain; charset="utf-8" Add check for the return value of devm_kmemdup() to prevent potential null pointer dereference. Fixes: 0fb528c8255b ("iio: adc: adding support for PAC193x") Signed-off-by: Charles Han Reviewed-by: David Lechner --- drivers/iio/adc/pac1934.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/iio/adc/pac1934.c b/drivers/iio/adc/pac1934.c index 2e442e46f679..95c9d14b5529 100644 --- a/drivers/iio/adc/pac1934.c +++ b/drivers/iio/adc/pac1934.c @@ -1108,6 +1108,9 @@ static int pac1934_acpi_parse_channel_config(struct i= 2c_client *client, devm_kmemdup(dev, rez->package.elements[i].string.pointer, (size_t)rez->package.elements[i].string.length + 1, GFP_KERNEL); + if (!info->labels[idx]) + return -ENOMEM; + info->labels[idx][rez->package.elements[i].string.length] =3D '\0'; info->shunts[idx] =3D rez->package.elements[i + 1].integer.value * 1000; info->active_channels[idx] =3D (info->shunts[idx] !=3D 0); --=20 2.43.0