From nobody Fri Oct 3 13:32:35 2025 Received: from c64.rulez.org (c64.rulez.org [79.139.58.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A23AD239E63; Mon, 1 Sep 2025 05:54:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.139.58.36 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756706090; cv=none; b=ZgbbJJPrIfzhdiiuG8CVuThcFdH7g8uXeHSmHX2Oo9jItdVcUa7BP+EuGAblPFU/RKVgslrVu65tniw0a2Rg7dD15PsBXSKSkd2fGAoT3PEnTvhBtaUQmH0e+p29PILBNMeAnD9TzT0xaedwEhd2u0VWkVBGOfL/r14C+xhokwg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756706090; c=relaxed/simple; bh=nJ9BB9Y3VY69GTDVRQiby0kbXG7hz2ESCGjLDKAqxOE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZBbyOFXgPIn+hwqFmFFbzmaK2DSCZpeDH3uLiFsZ+RkXXtzA0bxYtxdr/52wjg9valut3A2SVLIdN3Q2JFJ3sn05jbA7Sy53JGwjgDLNWxy6/a8fWNpFG/F71BlC/muXiaPRYrEFydYOiUEwHAzcsxV//twBLJPQ4afHynbUXzw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=c64.rulez.org; spf=pass smtp.mailfrom=c64.rulez.org; arc=none smtp.client-ip=79.139.58.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=c64.rulez.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=c64.rulez.org Received: by c64.rulez.org (Postfix, from userid 1000) id 6E0A110338; Mon, 1 Sep 2025 07:54:19 +0200 (CEST) From: Zsolt Kajtar To: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: Zsolt Kajtar Subject: [PATCH v2 4/4] tty/vt: use correct attribute mask in do_update_region Date: Mon, 1 Sep 2025 07:26:36 +0200 Message-Id: <20250901052636.8981-5-soci@c64.rulez.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20250901052636.8981-1-soci@c64.rulez.org> References: <20250901052636.8981-1-soci@c64.rulez.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The original code assumes all bits in the attribute byte are for attributes. If 512 glyphs are in use then one is used as the 8th bit of the glyph. This can unnecessarily split up a region of uniform attributes whenever that bit changes. Signed-off-by: Zsolt Kajtar --- drivers/tty/vt/vt.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index 5d458211b..eb60f69f3 100644 --- a/drivers/tty/vt/vt.c +++ b/drivers/tty/vt/vt.c @@ -613,22 +613,23 @@ static void do_update_region(struct vc_data *vc, unsi= gned long start, int count) { unsigned int xx, yy, offset; u16 *p =3D (u16 *)start; + u16 mask =3D 0xff00 & ~vc->vc_hi_font_mask; =20 offset =3D (start - vc->vc_origin) / 2; xx =3D offset % vc->vc_cols; yy =3D offset / vc->vc_cols; =20 for(;;) { - u16 attrib =3D scr_readw(p) & 0xff00; + u16 attrib =3D scr_readw(p) & mask; int startx =3D xx; u16 *q =3D p; while (xx < vc->vc_cols && count) { - if (attrib !=3D (scr_readw(p) & 0xff00)) { + if (attrib !=3D (scr_readw(p) & mask)) { if (p > q) vc->vc_sw->con_putcs(vc, q, p-q, yy, startx); startx =3D xx; q =3D p; - attrib =3D scr_readw(p) & 0xff00; + attrib =3D scr_readw(p) & mask; } p++; xx++; --=20 2.30.2