From nobody Fri Oct 3 11:15:11 2025 Received: from honk.sigxcpu.org (honk.sigxcpu.org [24.134.29.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C28BB2F530A; Mon, 1 Sep 2025 14:22:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=24.134.29.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756736577; cv=none; b=BRzf9cz43GwwzQKXA3MERlcXq11eU1Y7n2jWgPhO6T/I6Ck+u66iqWYTjlr68FHkV6+pkmTaRMNR4CkCXlxY23B6tBg4r5npOH3NeH8+Xlgg+qvm3dqTI5c11C7UTPYBbZpSILlzGz7FSEIYihuBSKRu7PVs45Hq09k2532tLNE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756736577; c=relaxed/simple; bh=/wDNaRwpfprI0Oefud3usSdTs01UZW0/hwWpIqErTtc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aWVlW2UlUngkzJiKYwZ7REVjDVHopSHWY3FMaR497hHS0lnFO1KWsOmjC12xLoGt6YrWF5+oaDq2rhvy5Wj8NnU0PaigSuVx4hhsW2IGOBRG+i+jDj6AuVjl/qnQCTfvFgSlUGkhFjMkqQH9p/YMAAiXi2cIm/wtKo43U7f/598= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sigxcpu.org; spf=pass smtp.mailfrom=sigxcpu.org; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b=OBaxxlON; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b=kL2qzWvb; arc=none smtp.client-ip=24.134.29.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sigxcpu.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sigxcpu.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b="OBaxxlON"; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b="kL2qzWvb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sigxcpu.org; s=2024; t=1756736564; bh=/wDNaRwpfprI0Oefud3usSdTs01UZW0/hwWpIqErTtc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=OBaxxlONGk/XwkoJQE/DWYd70NLNB9TebFcePR/HtbSpOqDLNvi+gnXoNVurJTiAB fCu7Bj+BMnY0jlUvhEi/8pJuTaU4D61p/opscwnsT+6zeG/p7qsOQgxdZKUMMZkkz8 htZCCgbRVqtDjtbQgB4TZECimPTMzWXXGXqbIzwgRu4GTlEhn8ZjVZOcm0D3kfuikx OBQWXa7Ipl0bXJActHA35sz1qSGvtifnGYbfC83uxA0G0rwbdnCyxVza+Ct7awcFXc KXE0V58QZ2MXomDA2JB5ElWpJOXdhbOkGAkh9tbgyjzauaNk+pUX3GpkkUY2HyifaB BFTZak+Z5ziqw== Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id B3CB9FB02; Mon, 1 Sep 2025 16:22:44 +0200 (CEST) Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mVMeH8AlDOGO; Mon, 1 Sep 2025 16:22:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sigxcpu.org; s=2024; t=1756736561; bh=/wDNaRwpfprI0Oefud3usSdTs01UZW0/hwWpIqErTtc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=kL2qzWvbuM+lNFxGgBcX1O3SQHfUCydbO+JgB38RqUYnBK+fFihem5pB+QOKwqLSe JXPK66BVb1XAa/fWWNJIIaPLfgL0AnaB9UgepjCLw++cyJAUWCYg+TFBt+7AAtdi/z BHh85ngIZarzZs8Ls811qSeKNe83/r+gBubPCecBvoLCU413zAeFlnM3RrYkK5zS/9 2yfxChhnGEhu7K9dGF/VcY9B4CnMX4nTKZgf7RDQV48GiCNpprUbwayA0ezMKUk/ur OBKV4Hx0dLGtynqyQ3Hh/ORErIdOBCKYSzxDkgCdCBT48c1Du6XXZcWJJnxnyrs2Ny eKT759oQh5Fnw== From: =?utf-8?q?Guido_G=C3=BCnther?= Date: Mon, 01 Sep 2025 16:22:06 +0200 Subject: [PATCH 1/3] drm/panel: visionox-rm69299: Fix clock frequency for SHIFT6mq Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250901-shift6mq-panel-v1-1-444b4abbfaea@sigxcpu.org> References: <20250901-shift6mq-panel-v1-0-444b4abbfaea@sigxcpu.org> In-Reply-To: <20250901-shift6mq-panel-v1-0-444b4abbfaea@sigxcpu.org> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, =?utf-8?q?Guido_G=C3=BCnther?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=953; i=agx@sigxcpu.org; h=from:subject:message-id; bh=/wDNaRwpfprI0Oefud3usSdTs01UZW0/hwWpIqErTtc=; b=LS0tLS1CRUdJTiBQR1AgTUVTU0FHRS0tLS0tCgpvd0VCYlFLUy9aQU5Bd0FJQVNXL2hsSksvT UhqQWNzbVlnQm90YXdmVFpDb0R6aGM4VC9XMzZCK2ZFU0dTRXArCkp0R0xYUEM4aWVsWWJrOHVZ b2lKQWpNRUFBRUlBQjBXSVFSajlzemZsaUtkQ1NocktzTWx2NFpTU3Z6QjR3VUMKYUxXc0h3QUt DUkFsdjRaU1N2ekI0eGZqRUFDa0dCcS9PRkZBZ1dUNzRBTGFCSkgzOG1Fc0Z4RVVlYU42bWNrWQ o4MHdMTlhSMjRESmkvN0o4MnR0WjI2bEtJcWRKV1lvL3ozZHU3TjlDa056ZHgrd1VqNG1SMzZpR 1JrZlNLcmxQClM4R3QxaFpCc0xRSVREU09pYllFZlBIU2QrTnBOMjh5dXVDR2I2TUloOGgxa0I3 SjdkVmx5bTVsN1NWd3RPZSsKa0htRzNWTzFaOXRVaWdMdTFxZlR5SmUrY05vQjhyK1lIa2JYR0F sZTJVYS9STFQ2S0I2N0ZRT1M3SlpoYVZGLwp3bXpXaVRmdkVmR1BMTENjWTIzd25HTDhPUzFvdE JtdWg3dlRXT1B5cW53M1VvU01uemw2WWpSTmhWaEJNRWtRCkJKaG5kZ0NhUFdCNThPK0xabVRyY lFmVmJRd0NNVmhmZkFsY1ZTSDhYZ1FVdkV0Zy80dWg3RTBkcExobmlDNGcKUGJXWWMxTC9lcFpy aEdoQ2VHMjREcUpMQ1lGeU1RUThFa0NhR3BOZVVVb2pLbUg1MVVZcFBFdHIxM2hJMWZ5QQp0UWJ OczlROXlUa0xxc2REa1FEeW5mdERETjIyZGVsbjBrVHh3OEkvTllydUNBd1BuRzJnNzJGMGpWdm 4wOVFlCmloSHd2alBlbnR5d3JCN0tWYmRPRHBsSGVVSlV4dVFHWmx0U05nSGlvNkt4NVF2ZUNIW GdTa2NKQVVTMVBvVkEKTndRZUdrUTRSMVFoYTVtSDdnUUNUejBnQ2psY3NYQzBieWNpVDJyKzFh dm9EcWx5bWloSThrdi9MNjlWL2srawo3dWZxNEJoclJYSFlJYi9XKzcwR1BrLzZFZG40M1djUWh WdDJOVkRzOVpqTkhXbTQ2b0xibVBTdjJDY0lFcXJGCmg3ZkhRZz09Cj1GYVdECi0tLS0tRU5EIF BHUCBNRVNTQUdFLS0tLS0K X-Developer-Key: i=agx@sigxcpu.org; a=openpgp; fpr=0DB3932762F78E592F6522AFBB5A2C77584122D3 Make the clock frequency match what the sdm845 downstream kernel uses. Otherwise the panel stays black. Signed-off-by: Guido G=C3=BCnther Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/d= rm/panel/panel-visionox-rm69299.c index 909c280eab1fb408a713d84051a1afbb252c45e8..e65697ce6f51c7d64b786da18cf= 44b16de5d6919 100644 --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c @@ -247,7 +247,7 @@ static const struct drm_display_mode visionox_rm69299_1= 080x2248_60hz =3D { }; =20 static const struct drm_display_mode visionox_rm69299_1080x2160_60hz =3D { - .clock =3D 158695, + .clock =3D 149360, .hdisplay =3D 1080, .hsync_start =3D 1080 + 26, .hsync_end =3D 1080 + 26 + 2, --=20 2.51.0 From nobody Fri Oct 3 11:15:11 2025 Received: from honk.sigxcpu.org (honk.sigxcpu.org [24.134.29.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1A85340D94; Mon, 1 Sep 2025 14:22:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=24.134.29.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756736578; cv=none; b=qlnKp3Ml6Rp9RIrHiTyX3kas+RloJ7tTOG8+8j6kKIDOBXaz1lMgp6c09UD8n47TcHH+ZFh90XQaHj8O8Ps5+107bDWa4vQFWeV8w7ChFqy0Y6VuNh5wo0SECcZ+VGihZRG3E4o5WyuMZyWGYi+GTVuaLLYgXmm2twJjUzOFnfs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756736578; c=relaxed/simple; bh=XzP2oIYHCCNvXv897N+EIJB1bCuQBdP71SLZnhgZr94=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=goZmd+XTONmrOgT3xAmMyGTmwdtpe9SqRXppguiHYQB5Rr/XaLnqdVuWovwo+GKA4ol0lG0YwK/Ivkhjsoe5ET3mc30IijJ39hug/78eth8Tf0NHpNkSnu7uMeuZrUkeWUvhrRELMocVDa2fJ9YEYFo+dChmqjcvsmDPOzWXjvk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sigxcpu.org; spf=pass smtp.mailfrom=sigxcpu.org; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b=lHYqxptS; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b=TvvRcH+8; arc=none smtp.client-ip=24.134.29.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sigxcpu.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sigxcpu.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b="lHYqxptS"; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b="TvvRcH+8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sigxcpu.org; s=2024; t=1756736566; bh=XzP2oIYHCCNvXv897N+EIJB1bCuQBdP71SLZnhgZr94=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=lHYqxptS6PBpb57vKPnnuhDE4Gfm9i8QelJuEAVg/3m9NILhievRTGRhhcb+gBOG4 u4cX2RXaonwmEh/rZMa2KF60uz1FotVIdoJ7nWbNvBH0EDh6cC/59+/qoftSSVMtlN OVwTfsqmcI8n0n+BBdylAabgoM3CctGLc5WUkPT350PWgwR0/M1DIlmmsfqKHi6qAH aYxXMPm6EMvsvEEAV5preNP60oS1l33pYs3e4T7x1VuVhL3KcOvAegXRtNrfa7GKiQ OVIOl74dylBcVNby2ybzoZSbr2b8BTMFvx5ySnYahZ7VkSIcbl3kUfVIPF4fhdPQt6 jwdzp3aYxnlSw== Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id CB6EDFB03; Mon, 1 Sep 2025 16:22:46 +0200 (CEST) Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B9AggP_bAkQe; Mon, 1 Sep 2025 16:22:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sigxcpu.org; s=2024; t=1756736561; bh=XzP2oIYHCCNvXv897N+EIJB1bCuQBdP71SLZnhgZr94=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=TvvRcH+8AEsFhIa5PXDIJy2kJP2r2kwcezC/P5QyeO0Ym5nmiFJZCkY7VHzF8NgYd rd1I1Yn22zfi6xA+Ua+826Tv1oOrGw0m4/J005fXNe6M6GF+3iArxL90S10LugiwAd XH/qqvoRawVxhYE4JSdrkTSw0IrslZ0ZUGB7gw941+VANoZ9I+dyaoaX/APHvYh9bU 1BZs9urtxrSsgTxor9l+aeFWQPt0HUlY8jgNkIO2uUTpyGYydnKpp9cYYjOugjIe2D yP7WRnnIgrGJ48C9P3iGgdNUW35Qm/3doCswFOUZciRMC1gDWknuS6Uo/9AB3YYea4 WOYX1Cc19XBwA== From: =?utf-8?q?Guido_G=C3=BCnther?= Date: Mon, 01 Sep 2025 16:22:07 +0200 Subject: [PATCH 2/3] drm/panel: visionox-rm69299: Don't clear all mode flags Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250901-shift6mq-panel-v1-2-444b4abbfaea@sigxcpu.org> References: <20250901-shift6mq-panel-v1-0-444b4abbfaea@sigxcpu.org> In-Reply-To: <20250901-shift6mq-panel-v1-0-444b4abbfaea@sigxcpu.org> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, =?utf-8?q?Guido_G=C3=BCnther?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=918; i=agx@sigxcpu.org; h=from:subject:message-id; bh=XzP2oIYHCCNvXv897N+EIJB1bCuQBdP71SLZnhgZr94=; b=LS0tLS1CRUdJTiBQR1AgTUVTU0FHRS0tLS0tCgpvd0VCYlFLUy9aQU5Bd0FJQVNXL2hsSksvT UhqQWNzbVlnQm90YXdsQUVOMXJSL0VzeXRxT3ZyQVZxdkJ1RkVKCkJjZUtZdHFUbUlSdXNkWXdG ckNKQWpNRUFBRUlBQjBXSVFSajlzemZsaUtkQ1NocktzTWx2NFpTU3Z6QjR3VUMKYUxXc0pRQUt DUkFsdjRaU1N2ekI0d2M2RC85d2ZCMWJhV2ZUYUEwbnl6YVREb3VTcEd6b1RqbElZaTF2RG05Tw pBYTFmcEZ3OTlrUFlhYnV4bXgxeXV0NVpYN2N3K01TQW9Dc05NdVpJY0JPNEN1UEQ2UzZ2bDdGZ ktQNnlmT3JkCnBFMjBkNFdPaVk5ZFY0ajNqYzcxeG01ZG9zZ0s0MDNydUhxRjdhVExOdUNjWGtO UHh0S2JmVkJBZ1RlaG93TDAKWHpTaUxnMU5UWE1uQURiU2JGSGVTVE05cUNkT1FNSHFVRmhtUmF EMy9XWnAzbVN6RGJWamR3STJCdjVvUXhaNApSc1BLWURZM09Ic0ZIMUdId0dOak9jOXBRY0k0bl UzY3NoNVMzY3NROUVRdHAveWl5SEMyQmx6Mjh3MEdpNjFOCkNjSkRFOFY1T0VpNUo2SzJLc2VJQ VA3THgrUEladVNJRmY2bDk3UGp0MEZDWE14ak05WWhma1BHTllDanRLQ2QKNGtsK3lmWGVROXJj bWJBS2Y4QmtwSjIvK0dPOVRKMm4rcnFmN2h6cFRFVnhhQjVZN1Vuc2ZuSXJNazl6ZGhabApsNXB DQkxmdUZ5elRoMEhWeVQvdkh4NThPNlR0NkVsRmM0SGY5cGJ6SE01QTJ1Y0FtWERzditQRllkUF VMYkoxCm15enpIb0ZzckZjOXBwUVV0dmx4eEI2R0h0T0dFR3YvUllFVjBzSmJkNjRCM3hmTWY5c zRCZHhKRnJxcVBpZGIKY3NRaUI2cFM1VUdHelBmNHZxdWhjNktmZG1RRkJpeU1DZ1RJWHNhZ0Ru S0piRXVvdlBNQ0xZRDJ3K3RkNnR6agpDbm5HNzFGd1FkNlhPS2ZJSFdrWCsra3FCK1FrZml3VlF 4NmxOTHdmYXNTREpsYUh1K29lM2oyWnJuVCtEVmxKCmZaSUdIdz09Cj13MEhvCi0tLS0tRU5EIF BHUCBNRVNTQUdFLS0tLS0K X-Developer-Key: i=agx@sigxcpu.org; a=openpgp; fpr=0DB3932762F78E592F6522AFBB5A2C77584122D3 Don't clear all mode flags. We only want to maek sure we use HS mode during unprepare. Signed-off-by: Guido G=C3=BCnther Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/d= rm/panel/panel-visionox-rm69299.c index e65697ce6f51c7d64b786da18cf44b16de5d6919..2216d38366ea37368d15480f9d8= a8ccbfe77ba3b 100644 --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c @@ -192,7 +192,7 @@ static int visionox_rm69299_unprepare(struct drm_panel = *panel) struct visionox_rm69299 *ctx =3D panel_to_ctx(panel); struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D ctx->dsi }; =20 - ctx->dsi->mode_flags =3D 0; + ctx->dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; =20 mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); =20 --=20 2.51.0 From nobody Fri Oct 3 11:15:11 2025 Received: from honk.sigxcpu.org (honk.sigxcpu.org [24.134.29.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1A12340D8A; Mon, 1 Sep 2025 14:22:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=24.134.29.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756736578; cv=none; b=Q8AMMzfN4kKY5E+B3HHo4JMlnUs3bknpZbOA+ktcFOxVclKlFyrCQCEGl+7WFC34b8c3fJpuZaUYsYIjHfo176O4cOM7OvxaKHENRj0TTRmZiASpmKijhXGW/2KFHiw16eqYBdUtMcUeMF+ZGRjTlNU/aLGTXM5riodJDNgSV5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756736578; c=relaxed/simple; bh=k4MLOcFOhWHC/jwwxifpb5LwfdkCPYQ3GUc4Izfhqus=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sTOFncAFU4zEBLnjwouOiT7SyqOlFciUfLfF8txrFQwNfUnyJioal/tBFbfMkuXYmX0Sbd4wMpPHM7KcOlQYgnQ7oq8yJdpRUCRkKY2V+rycraJEtWjMdnD78endlb0WMKpkyYg80QaBiUpWCFqf42ZmB/JlXram7HPmPYtSyG4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sigxcpu.org; spf=pass smtp.mailfrom=sigxcpu.org; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b=nUPkkfdx; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b=CMs9C6Mz; arc=none smtp.client-ip=24.134.29.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sigxcpu.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sigxcpu.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b="nUPkkfdx"; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b="CMs9C6Mz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sigxcpu.org; s=2024; t=1756736568; bh=k4MLOcFOhWHC/jwwxifpb5LwfdkCPYQ3GUc4Izfhqus=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=nUPkkfdxOLR70g/lPMwFvKrXQq6khvw/5VsgM3CWRhntUnpVOY8Eq+d/UqMG8JERy +Q7mZQ7wBkv0D/vVWxKesrHzn1yCpE7K2Qa+b+gsJOnZyO6xHreEDz7tHpNKD1sJKV HTFZtmKW37F0xJUuJnHOi+eQ1O2zsqq7M4f0lIy9MyQl58p9VWfc0NsAwAFXJB8jYf ysaEDUiUrPBv2exh0GQnqvbHL8ie9BvG8938ZitdFm4t7hB+ErLGvbWPb/76m+YacY 1ei/7eN80wXNK/lq5J62zGSIuMqADKLKyq25HUOXL1lxnytG63L4pMsqugLRj1CdRr VthmYYmbC2j3g== Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id A7C5EFB05; Mon, 1 Sep 2025 16:22:48 +0200 (CEST) Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jeMZP9g2j7ej; Mon, 1 Sep 2025 16:22:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sigxcpu.org; s=2024; t=1756736562; bh=k4MLOcFOhWHC/jwwxifpb5LwfdkCPYQ3GUc4Izfhqus=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=CMs9C6Mz9R0W3SJCmdmtHeIHXT/EjwNE8dSAOzOc5Fl4ygKHsxNd1WmkKK0Eguqc6 fz/wdHn75gIZmAfT+sLZDJivBLb+B3/IscvyYdYrv/CO0e/MQ2jWGfmhxb+9NoUo8V ljwMEhRwOyQZYX21/XtNRDt5kmuja9MvohyVdr3p4ryxkV3v/Jlma6yKxd3AsBSEvc CeMOadlbdQ2moQWcYyK2hOQWRsbi9C5YsQjaHXNpSRwzG0FAbnbRzM4adJU0T2TiUi XTqZ0+OqS84wGO4dh9U0kx/ryKPL6ynMVLTDVzInZ6eXwTBK4+CmPobvTgWZ8+4WvC onJrJ1AoicK+A== From: =?utf-8?q?Guido_G=C3=BCnther?= Date: Mon, 01 Sep 2025 16:22:08 +0200 Subject: [PATCH 3/3] drm/panel: visionox-rm69299: Add backlight support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250901-shift6mq-panel-v1-3-444b4abbfaea@sigxcpu.org> References: <20250901-shift6mq-panel-v1-0-444b4abbfaea@sigxcpu.org> In-Reply-To: <20250901-shift6mq-panel-v1-0-444b4abbfaea@sigxcpu.org> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, =?utf-8?q?Guido_G=C3=BCnther?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3633; i=agx@sigxcpu.org; h=from:subject:message-id; bh=k4MLOcFOhWHC/jwwxifpb5LwfdkCPYQ3GUc4Izfhqus=; b=LS0tLS1CRUdJTiBQR1AgTUVTU0FHRS0tLS0tCgpvd0VCYlFLUy9aQU5Bd0FJQVNXL2hsSksvT UhqQWNzbVlnQm90YXdySE9jS2hQUmc0RHhDT2lLUndaZ2dDZi9RCndpWWNwUGhzYW9RK1hDZEJ5 TktKQWpNRUFBRUlBQjBXSVFSajlzemZsaUtkQ1NocktzTWx2NFpTU3Z6QjR3VUMKYUxXc0t3QUt DUkFsdjRaU1N2ekI0eUI5RC8wYlltYnFEcGdwU2hza0g5YURPNlpZaXVrZXJ2RnVERGpnVFNkYw o1dWZtOVdWN2pUeEFkbGJDYVUwWXNBSlZWWUlIODk2NThvQzIxcHNvOTJIYXJNVGhlZHdGZ21yO GhxSjQ1TklkCnluTXJHbW1qOVp5MzgwOEZXcE9CU3BJQnBRYlZwRC9iTVVpWUR2QStKSXkxbHdZ VWtoODJJVklmRm1SSFlkSW0KQUcwbDlxdFRNRzdSTEUybyt2WEVndXBYQVQ3VHg3Z0Juci9EeXE 5Q0lZWk8xaEJNdGF1M2Q4UTlqMEFMNTczUQpkSkNxMmFKSkYwTnVQNzA5NWxXcFZSMjUwcjQ1R0 pCbzFYTE9MUnlYUjRCVGd2Y2dES0FQYlN3ZU43U3I4L3dhCkR6dnh3NmYrRWRrdVN5RTVzMG01U kJKKzdFVHJLTUp1ZGRyeCtWakNOMEVyK3hjWkhCU0JOVXgrNkRSRzhscDUKWEhJL3EvNWg1WS9i WWhrbCtab21tTWdsSElPaGtRZWp2b0ZuUUdsekpNWFZxOGpueFpQbWZHZVZpaVRpYWVVZAphSTR XaE1PaW5yZGJtejRlNTVGSk9rT2x5ZDZrQnVZNkJvaW41eWZMYWZiZlV2dTZoK0FCaFQvYU9UZl lrOWhPCnVxazYrZjFqMFp1TzhSK080TVBUSWVkTTZYNzZZN1Vndng1Mk55ZUNRcU13ZWlwNnU4O EpwRmJHRVZTQzdLYUkKWU1rZG10VWlrcmYvemZhclQxRjNYNjZxcFFxZ1ZGV3A5dlFSMnNEOWNE RXpHNUJTWXduQVREeXBPWU83QVlWcApIbDBPNkdEc1FpbVdWdHNCVjBDdVZDU1RacTFkODFYZzZ oWlZOcXh6eGFsdFluMHI3Z0t5N0ZvMk53MDlNOUVsCmsreC9Bdz09Cj1NcDE1Ci0tLS0tRU5EIF BHUCBNRVNTQUdFLS0tLS0K X-Developer-Key: i=agx@sigxcpu.org; a=openpgp; fpr=0DB3932762F78E592F6522AFBB5A2C77584122D3 The shift6mq's variant supports controlling the backlight via DSI commands. Use that if a max_brightness is set in the device specific data. Signed-off-by: Guido G=C3=BCnther Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 67 ++++++++++++++++++++++= ++++ 1 file changed, 67 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/d= rm/panel/panel-visionox-rm69299.c index 2216d38366ea37368d15480f9d8a8ccbfe77ba3b..5e5ff6056c80e67a5bf8fe4911c= dbc588db5d03b 100644 --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c @@ -3,6 +3,7 @@ * Copyright (c) 2019, The Linux Foundation. All rights reserved. */ =20 +#include #include #include #include @@ -20,6 +21,8 @@ struct visionox_rm69299_panel_desc { const struct drm_display_mode *mode; const u8 *init_seq; unsigned int init_seq_len; + int max_brightness; + int initial_brightness; }; =20 struct visionox_rm69299 { @@ -285,6 +288,63 @@ static const struct drm_panel_funcs visionox_rm69299_d= rm_funcs =3D { .get_modes =3D visionox_rm69299_get_modes, }; =20 +static int visionox_rm69299_bl_get_brightness(struct backlight_device *bl) +{ + struct mipi_dsi_device *dsi =3D bl_get_data(bl); + u16 brightness; + int ret; + + dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; + + ret =3D mipi_dsi_dcs_get_display_brightness(dsi, &brightness); + if (ret < 0) + return ret; + + dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; + + return brightness; +} + +static int visionox_rm69299_bl_update_status(struct backlight_device *bl) +{ + struct mipi_dsi_device *dsi =3D bl_get_data(bl); + u16 brightness =3D backlight_get_brightness(bl); + int ret; + + dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; + + ret =3D mipi_dsi_dcs_set_display_brightness(dsi, brightness); + if (ret < 0) + return ret; + + dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; + + return 0; +} + +static const struct backlight_ops visionox_rm69299_bl_ops =3D { + .update_status =3D visionox_rm69299_bl_update_status, + .get_brightness =3D visionox_rm69299_bl_get_brightness, +}; + +static struct backlight_device * +visionox_rm69299_create_backlight(struct visionox_rm69299 *ctx) +{ + struct device *dev =3D &ctx->dsi->dev; + const struct backlight_properties props =3D { + .type =3D BACKLIGHT_RAW, + .brightness =3D ctx->desc->initial_brightness, + .max_brightness =3D ctx->desc->max_brightness, + }; + + if (!ctx->desc->max_brightness) + return 0; + + return devm_backlight_device_register(dev, dev_name(dev), dev, ctx->dsi, + &visionox_rm69299_bl_ops, + &props); +} + static int visionox_rm69299_probe(struct mipi_dsi_device *dsi) { struct device *dev =3D &dsi->dev; @@ -316,6 +376,11 @@ static int visionox_rm69299_probe(struct mipi_dsi_devi= ce *dsi) return PTR_ERR(ctx->reset_gpio); } =20 + ctx->panel.backlight =3D visionox_rm69299_create_backlight(ctx); + if (IS_ERR(ctx->panel.backlight)) + return dev_err_probe(dev, PTR_ERR(ctx->panel.backlight), + "Failed to create backlight\n"); + drm_panel_add(&ctx->panel); =20 dsi->lanes =3D 4; @@ -353,6 +418,8 @@ const struct visionox_rm69299_panel_desc visionox_rm692= 99_shift_desc =3D { .mode =3D &visionox_rm69299_1080x2160_60hz, .init_seq =3D (const u8 *)visionox_rm69299_1080x2160_60hz_init_seq, .init_seq_len =3D ARRAY_SIZE(visionox_rm69299_1080x2160_60hz_init_seq), + .max_brightness =3D 255, + .initial_brightness =3D 50, }; =20 static const struct of_device_id visionox_rm69299_of_match[] =3D { --=20 2.51.0