From nobody Fri Oct 3 12:14:28 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9626263F2D for ; Mon, 1 Sep 2025 10:01:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756720915; cv=none; b=LlVqNX12U/CcYHQ0iPWATnXPdEmae9rQPxznRulHhz3B19V02Y9L1Q2EUHYgOFYdPdTafEa6JIDbu5LzeDFo+p5J1YVH0iStaBgee2vPjVZDYLAy5Ry0v5UPZ/6WS8RphwQjtuWxCSpDTLGTziEeavZ+BHGRoR8ItLQnwAGX0ls= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756720915; c=relaxed/simple; bh=X+Tp/RgBOAXJDPg8M+jMZCaUbGdx0ODDY68KszLl/ck=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=AY/JMEX0PgFYUYLgXuELgFVoKjdTpZQEGjMfmU+HMKFyXadnU/Gw4A6mTiTnvwg/jc1yxeyXYCt40vVB5FcMwdkKr7Q7fvQZq60BfBvp+eqHx7faezYr3aAqwHSmXzz0LHTkBBmfCDvFTbkrdNSsOsk4xn2wPFrFpvQZC9mGcQM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RC9P9Oeh; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RC9P9Oeh" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5819eQ3p004505 for ; Mon, 1 Sep 2025 10:01:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=qQgwpgTjtkLJU+HAWiUzei zRHRiOnurR4p2VY8u2JAI=; b=RC9P9Oehzy3AdgflD/E3cj+jUtfRXA6kdEm7xA EVOdyhC5Xd6rO3HjZ8NQ/v6zK4wdMzm0EbZEI52abfM6j17bxzZZu+JNTOr3c0hh y2D+qAFLCtx1u1syOQ6m7dVo/1oubVehXW2EAUnJUa6aUstK+MmVJUTYsTZfjT6k ZHv2Wle/nMnLVl+kDXmG9hVDB2lEnKlqPsKjlD4FFc75p8InD0r85vhIBxpvqe6K XEzLSSpVqIgswceb3zNHQznZkpp+IH2j0X0T2ytHKIzrtKMYwpnR0PcukIGnyiXK 7OVZ4TmxmMUZGs2eU2XC6CsjLO0x8iXIznZSYSxp6/FjaHmg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48ut2fc89n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 01 Sep 2025 10:01:52 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-327b016a1f3so4357519a91.1 for ; Mon, 01 Sep 2025 03:01:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756720912; x=1757325712; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qQgwpgTjtkLJU+HAWiUzeizRHRiOnurR4p2VY8u2JAI=; b=dS5zIJXPOPHjZ/7LDtApAEAVN3wBH9XCQ5Ho+3+kW3P6rFHIPlP35t3cAdXuOGvc20 cvSxNwrU2tTzB/pz+MwqnKKSJmhQTLuTXID3DqS4iRMF+btvrSdGNl74ijumfR10fW2i H5LMab53Vpr4wc0/OStbUF1qbTviJVq3IqkMGJjxGekkuUc1b96FVioMwVzPtmG1yQmu FGN3VmfOlcBEXGOUcoobs1crD58drgq6iQUGA6Y3BcORuCgUK+ytSmyvUVJ9bwL7yU95 VfFpAPlw68LjwpTBYXh325GQCvQLki7WIyimMSReaZyo/bNG8T+SftGidyxP4RkHrpq2 R9uA== X-Forwarded-Encrypted: i=1; AJvYcCWH7usoBlfdUMayEUVkI/h80tvFIFVHWBlCqQZWaMzhRMdiepn585BwBpJbUrZ3l5Xit57BLC4Dk631iGE=@vger.kernel.org X-Gm-Message-State: AOJu0YwXSRtFKHDo/lYfy5r3CTvMB/pSvLkv271ll7LLYPPA20rfONw7 dTtHms5P2LXK//ZRhkm7g+jUcHOcQMQEHyndLtXmzVIXK1ny3ZGC2PltNgOlxXrd0LdayvLSdIW 43rYynNkuOHn31fWuHqlROmG/8Xz7qRpCOMygmZU5PH7u166LZHgGarjPa/n4a4cI+no= X-Gm-Gg: ASbGnctpobNrBJZyVTxIsCc4ZmDWDz2hJZFPQB1mCIg4e6SRlGzvcX4QNPcbTCY/Cet dkqbUVwCp4AALnNF/f0KFOedDwmG7rL7iQ5RLZiiowsIg4IObH0vJWuC+Ggvz+vZEByc3rz9zlf /KFLS23dHZk7s/Ec+2btzUItaItcWQ574vxxQGZeBreu2or/90Kk4Do6GqrOf6nadvKhTyk+oDZ 6tVD+2/BOSx8t4Z86I8NMeLRnGvOpu7hv+neX8kECt+86BPKmGzu17l2UKqawiRm/1uRU4GxKgt ZCJfFnDmv836U7hvIsfY4Kvk8MUg9gBQZqTBGhsp+XnEsIO5iS658Q3dxGMTUkvonyx5+f18k6I YFv87jxsFL602ThbK2zgdhcbrmRw37SX1bDZR X-Received: by 2002:a17:90b:52cf:b0:325:15bf:4dc2 with SMTP id 98e67ed59e1d1-3281531d3femr10322020a91.0.1756720911591; Mon, 01 Sep 2025 03:01:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG1Jx0Jsm3pv79yInlxMD+8W/VppGUVhsqwbSB34wrfl77W1ukxVuajcczW1H+8VH9LiCTvhA== X-Received: by 2002:a17:90b:52cf:b0:325:15bf:4dc2 with SMTP id 98e67ed59e1d1-3281531d3femr10321969a91.0.1756720911094; Mon, 01 Sep 2025 03:01:51 -0700 (PDT) Received: from jinlmao-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b4e673ad423sm6012525a12.50.2025.09.01.03.01.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Sep 2025 03:01:50 -0700 (PDT) From: Yingchao Deng Date: Mon, 01 Sep 2025 18:01:45 +0800 Subject: [PATCH] KVM: arm64: Fix NULL pointer access issue Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250901-etm_crash-v1-1-ce65e44c137c@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAAhvtWgC/3WMQQrCMBBFr1KyNiWTNjZ15T2kSIhTG7CNZmpRS u/utFuVgQ/vM//NgjAFJHHIZpFwChTiwAC7TPjODVeU4cIstNJG1Qokjv3ZJ0edVIi1LpDTesH /94RteG2uU8PcBRpjem/qCdb2l2UCyef3BVRGgTH2GInyx9PdfOz7nGN1/xuWla8ttLZ0qv0eN suyfAAlzbqP4gAAAA== X-Change-ID: 20250901-etm_crash-0ee923eee98c To: Marc Zyngier , Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , James Clark Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, quic_yingdeng@quicinc.com, jinlong.mao@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, Yingchao Deng X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1756720907; l=2171; i=yingchao.deng@oss.qualcomm.com; s=20250901; h=from:subject:message-id; bh=X+Tp/RgBOAXJDPg8M+jMZCaUbGdx0ODDY68KszLl/ck=; b=0hURcY7VKduAxWJqet9HVBB0Tztm1vwxHVJRsJrYuafgrjeyxcryvuyzEQCF5cYxXr7GiT3cR Hpi+c1kAlhRAj1DhVjCRr2MJL11P7TKvmGA6lC/3cAGyL8mg1vvfLXK X-Developer-Key: i=yingchao.deng@oss.qualcomm.com; a=ed25519; pk=xilq+l2r3MI2IvgF26j2OwmdNb/TQNeJMQ3VdJi8C4U= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODMwMDAzOCBTYWx0ZWRfX8Mo/h+jbHMG7 aUjgTteXfypHDuKymtcx0zbZrz7us6bwJK2Yed+hwH/2pHZOKC8ZRgxqEhQV46Epipk4v28cZ6+ F5u4pr6qPlXEwO+nd4gpgFHMM/d20uEe9IeBmrxy0PW4MKAtXY3byJg75EmgjRlVlY2IzE1ABmU TciBWfEmqTTYZFRQ2c/TyFu9LXc48+CkZQagfmB/CGq10ScQzaDnmr2M9Ny9ZpyfdDxXti9I0tz oIDVWvftYSqZRbNn3Gokw8xvHR4LUKhzh4/ZdICU5E6F6CI2Z8PuteWlUk6nSJ6NdV/fUciucFf XV7J6HpgdqOoxi7vRJydpj2Ia5rEKm4Ozzpe258WUYP4Sq87FOteU+i9KFKZY8etdoceUqN5/zZ 6zJTbmoY X-Proofpoint-ORIG-GUID: 3ALrZiPku1sfqJBEBrEpFaXkB7Hf8yIh X-Proofpoint-GUID: 3ALrZiPku1sfqJBEBrEpFaXkB7Hf8yIh X-Authority-Analysis: v=2.4 cv=U7iSDfru c=1 sm=1 tr=0 ts=68b56f10 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=ZDfnslOjjdbEBvoarX8A:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-01_04,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 clxscore=1011 impostorscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508300038 When linux is booted in EL1, macro "host_data_ptr()" is a wrapper that resolves to "&per_cpu_ptr_nvhe_sym(kvm_host_data, cpu)", is_hyp_mode_available() return false during kvm_arm_init, the per-CPU base pointer __kvm_nvhe_kvm_arm_hyp_percpu_base[cpu] remains uninitialized. Consequently, any access via per_cpu_ptr_nvhe_sym(kvm_host_data, cpu) will result in a NULL pointer. Add is_kvm_arm_initialised() condition check to ensure that kvm_arm_init completes all necessary initialization steps, including init_hyp_mode. Fixes: 054b88391bbe2 ("KVM: arm64: Support trace filtering for guests") Signed-off-by: Yingchao Deng Reviewed-by: James Clark --- Add a check to prevent accessing uninitialized per-CPU data. --- arch/arm64/kvm/debug.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/arm64/kvm/debug.c b/arch/arm64/kvm/debug.c index 381382c19fe4741980c79b08bbdab6a1bcd825ad..add58056297293b4eb337028773= b1b018ecc9d35 100644 --- a/arch/arm64/kvm/debug.c +++ b/arch/arm64/kvm/debug.c @@ -233,7 +233,7 @@ void kvm_debug_handle_oslar(struct kvm_vcpu *vcpu, u64 = val) void kvm_enable_trbe(void) { if (has_vhe() || is_protected_kvm_enabled() || - WARN_ON_ONCE(preemptible())) + WARN_ON_ONCE(preemptible()) || !is_kvm_arm_initialised()) return; =20 host_data_set_flag(TRBE_ENABLED); @@ -243,7 +243,7 @@ EXPORT_SYMBOL_GPL(kvm_enable_trbe); void kvm_disable_trbe(void) { if (has_vhe() || is_protected_kvm_enabled() || - WARN_ON_ONCE(preemptible())) + WARN_ON_ONCE(preemptible()) || !is_kvm_arm_initialised()) return; =20 host_data_clear_flag(TRBE_ENABLED); @@ -252,7 +252,8 @@ EXPORT_SYMBOL_GPL(kvm_disable_trbe); =20 void kvm_tracing_set_el1_configuration(u64 trfcr_while_in_guest) { - if (is_protected_kvm_enabled() || WARN_ON_ONCE(preemptible())) + if (is_protected_kvm_enabled() || WARN_ON_ONCE(preemptible()) || + !is_kvm_arm_initialised()) return; =20 if (has_vhe()) { --- base-commit: 8cd53fb40a304576fa86ba985f3045d5c55b0ae3 change-id: 20250901-etm_crash-0ee923eee98c Best regards, --=20 Yingchao Deng