From nobody Fri Oct 3 13:32:06 2025 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6FF936124; Sat, 30 Aug 2025 09:11:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756545094; cv=none; b=jDO4m906tbknFALavwgL+fvo3SXMsDrz6fiv8RXDKHwbyWafKDjyC+wER7EOKkKYYiIdLNCOaNFQe/YRKTw6APHvz6Rz239Rec1Ue4o1s3SsCbP5A2U+UbZ69LUnuRtVfsGmjtIAeswQcwanFDZnfr20v/u7aJCrxo+1EDTRaZA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756545094; c=relaxed/simple; bh=f1b/4amQMKPWaM434ApARpUsCSUkb/F7/lZRqywz9NY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=gtyOWo/SISBGAOus5DNkFDsl5VnoYcrPx1kjJB1EdMZ31NSVfsxOCYerA6brg6V5LPpn5NegaBL8A0Kb5iZrlC9tW99lTsmpB44KbraXNt6qLkB393UPRdFMSmQNa/860QLcfjbKTxohCAhSHF7RbqRRoPB876313ZvDXOdeyZI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4cDTsF1DsTzYQvmD; Sat, 30 Aug 2025 17:11:29 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id A9F021A0A4C; Sat, 30 Aug 2025 17:11:27 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP4 (Coremail) with SMTP id gCh0CgD3QY49wLJo3KYrAw--.7400S4; Sat, 30 Aug 2025 17:11:27 +0800 (CST) From: linan666@huaweicloud.com To: song@kernel.org, yukuai3@huawei.com Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, linan666@huaweicloud.com, yangerkun@huawei.com, yi.zhang@huawei.com Subject: [PATCH] md: prevent incoreect update of resync/recovery offset Date: Sat, 30 Aug 2025 17:02:42 +0800 Message-Id: <20250830090242.4067003-1-linan666@huaweicloud.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: gCh0CgD3QY49wLJo3KYrAw--.7400S4 X-Coremail-Antispam: 1UD129KBjvdXoW7Gr48Gw18Gry3WrWfAryxKrg_yoWDZFg_ua y7ZF97Gr93GF9rWr1aqr4avrW3tF4DXr48Xw1fKw1ayFWktanF93Z0k3Wruwn5K3y7Wr90 q340v34a9wsF9jkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbT8FF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAac4AC62xK8xCEY4vEwIxC4wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC 0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr 1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IE rcIFxwAKzVCY07xG64k0F24lc7CjxVAaw2AFwI0_JF0_Jw1l42xK82IYc2Ij64vIr41l4I 8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AK xVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcV AFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8I cIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r 4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfU5g4SUUUUU X-CM-SenderInfo: polqt0awwwqx5xdzvxpfor3voofrz/ Content-Type: text/plain; charset="utf-8" From: Li Nan In md_do_sync(), when md_sync_action returns ACTION_FROZEN, subsequent call to md_sync_position() will return MaxSector. This causes 'curr_resync' (and later 'recovery_offset') to be set to MaxSector too, which incorrectly signals that recovery/resync has completed even though disk data has not actually been updated. To fix this issue, skip updating any offset values when the sync acion is either FROZEN or IDLE. Fixes: 7d9f107a4e94 ("md: use new helpers in md_do_sync()") Signed-off-by: Li Nan --- drivers/md/md.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/md/md.c b/drivers/md/md.c index e78f80d39271..6828a569e819 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -9397,6 +9397,9 @@ void md_do_sync(struct md_thread *thread) } =20 action =3D md_sync_action(mddev); + if (action =3D=3D ACTION_FROZEN || action =3D=3D ACTION_IDLE) + goto skip; + desc =3D md_sync_action_name(action); mddev->last_sync_action =3D action; =20 --=20 2.39.2