From nobody Fri Oct 3 13:30:15 2025 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 667DE2749C5 for ; Sat, 30 Aug 2025 10:19:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756549150; cv=none; b=KR34pHDb2sbVm1XoaBjsXO+qbsE6UOljEPkLlIioiMDxrR6inusZitzMBy7CLAKw0eG+1HAVl2OREyRHybedouXrJq9FJKngfg5ndsKFJpo4NQ8RvlHTKXK0KBCUcv238zO//u5Wo7XKYw6l18VwC8/ON6AZRILov5Le1UHd82U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756549150; c=relaxed/simple; bh=phCIU7qXQwzL9ywXevhpCuLOX4bC84K3Yg163SS2Jhc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=K1wKgyGVLtDoIyLyF107LbyZ63Ydzw8joGtQ7zdvsgyBfd3krWQEKcplm90pC45bvOeXkR4cGb8yQ5i8RksVoOZMnpNKtY4K/8w21npMT+Tmd1lnCMhDTGTJLunPjfVMpuZTYujkxweR/h+12x/cyBrFVbxPzSV65uLMqnZZjRE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qBDkISE4; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qBDkISE4" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3d323be1617so9795f8f.1 for ; Sat, 30 Aug 2025 03:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756549147; x=1757153947; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Lc4VvtndTdQUwu9NAMxU40diYp84hx+fKTxM5CnEC0U=; b=qBDkISE4rNvm6z2ws3zYdpEkoJs5FkfrcwKPndZK/qmYbtU5o7qk8DRH7ucRTGyMk6 i+4e3hJl3v1YLG/u23OqBdvXG6g2m5Yd4o9l8zL/3LPzIVUlEXWibqhvQqRiOUifF1Pp b9qO79VluTGD3RWRvWLtep2BVHgAgwAVdASKFvsVe2pISMV9B9sW2Hy9zXm+2nYZ2mow hTigNAOMggitrsxbw/4lb8toItcZ8giBsIKEytmW/Ry9GaaxorJuN8AVGuk6Na/Tuc3w y+B0OiK+KBx8SnaiM7xqggG5SG7BtOlDyU65REClCvHA9LD3bRqdy9ky3REbJGFFcZ+Q M8VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756549147; x=1757153947; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Lc4VvtndTdQUwu9NAMxU40diYp84hx+fKTxM5CnEC0U=; b=ezeEbVw719QVEyPEjtmVsz1jMTQyQu1HPJTlNOxCIRtREm7pe3SsvSqoLK7SnO/Tgi YVlB04oUq+sYRBKADgrb39aZYQc6QEs0zFdGZgiAxjKo37+QNZmB/aeKfD8T1pbmd6M4 0pnhtasx84Z7EV1COjitNf+UTlM1uwNTx+7PNCjunI5CnnTxJBhfLrT3AZPBtf+f8dUy BwzK8YHYzZhTsds2iCrUDerezkDdpE9z3RXpM1GxVMdsM59PPoKhtA55Kl1VhUg54GRw rQUyS43BOfcdBlXQBrw5MGU5amLM6m5pzR0lryp0mwkeZQyeqsTttCkm6hSLXqBk3YdQ qsvg== X-Forwarded-Encrypted: i=1; AJvYcCXAg/e4UTZgQKxxurQOtBT7PmLbBYZrjo+esmQ7aR5ZjHndUAfIbXNZfuNJx6Uh68VWa5cZn/id7pLw64g=@vger.kernel.org X-Gm-Message-State: AOJu0YxDwq+q+jdHG0XPneKRM0zuVR+GIgOvLEbeo0YU/0saN6kPrG88 /SmGZ2kfTKRAdznp1APAeaKSR3OzwC919kYS//UCKpFKMjcnQLTfdaymZoUl1TLihmQ= X-Gm-Gg: ASbGnctG1fLyNTgBFkJyt5oVj/xAhabbUU7NQp9nFSYMFmkM5ZY0nxJK5c2zia7t2YY HyqPS0iChWDiN2rtqICXg5eoKdASAnoVMkdch9ugSEzpRb7psfOxVXCu5bmB5fAWK+NlQRjRnNI VgEovQ0wV2y4SNR46KiX5lPn3Q5/4zRo3swKt2SwGVepA9n/cVDUm/okbJLG8MI8+MrMGHkT++p hRnqj7ZM9xK/JjylKU91jk9Y/2gLLuiyMytgL8++D2P1K2lD7bUgBIhcqLqVjd5H8WIAO691mNH H44RyafP3rBK7gsrU63iWdrVIubPh7eaPsZqSPdz+mNzKj34DzaxbWdZZ/p6c4vHevWRBCx49gx e0DVM+KpDrFv126xWbEPNG2c1z9A1XwN7Wic4zcg= X-Google-Smtp-Source: AGHT+IElyjWIDdnRLs09FR+6PzPMYJ0mBBOSNWeVs5b3fm069jnqc4HgASV/Qa+IsKi3cpsKc2Birw== X-Received: by 2002:a5d:5d0d:0:b0:3c9:1b91:71e5 with SMTP id ffacd0b85a97d-3d06606301emr1956916f8f.7.1756549146595; Sat, 30 Aug 2025 03:19:06 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf276c8eccsm6547492f8f.20.2025.08.30.03.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Aug 2025 03:19:06 -0700 (PDT) From: Krzysztof Kozlowski Date: Sat, 30 Aug 2025 12:18:57 +0200 Subject: [PATCH 1/4] dt-bindings: watchdog: samsung-wdt: Define cluster constraints top-level Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250830-watchdog-s3c-cleanup-v1-1-837ae94a21b5@linaro.org> References: <20250830-watchdog-s3c-cleanup-v1-0-837ae94a21b5@linaro.org> In-Reply-To: <20250830-watchdog-s3c-cleanup-v1-0-837ae94a21b5@linaro.org> To: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar Cc: Krzysztof Kozlowski , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1227; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=phCIU7qXQwzL9ywXevhpCuLOX4bC84K3Yg163SS2Jhc=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBostATWdrpdUjx7iDa4Cq4mMsNQm8U0vKHMo27y uln7YNtvyaJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaLLQEwAKCRDBN2bmhouD 1/u9D/91m8aRXiwMrNQqYcDCDbp+fzpNTIX1p0ufDEiWmRJdp4r9vOLcLqClJ0ZrIN0QPFKfV8A ZwN7RWtY9x658v8E8l1eosqy3gwhoba2WgKC0cZpVltv8wEqCPATPk6Z4wNAl5ALIIXDSM3blgW FFoLip9pEF7F94wca7cKsdIdLKtkOiklZ3c7c8EmI11uiGgV/rm3JtbTaUdtZubMCcNoj7/KF3c R9fP6FnjwFbXwUC+DmDegoOBKKmdMvioZVjsFX1RDGhVwULF5J0A+XtzqYVFJFv5LsQPrUTNyqK 5eIyaXy20Qmm50YIauobjAYV4JSwL+4BMyQt2L/TIx8D7cy8ZtFybxjbJ8/vp+pbhU4vbWG99K0 xmn6JzcqHSt9uAeL+majTJPB7v94/DLdXRpbzFMQ6TPvTHHJRrjB2A8jmiqNXGvstRiYPNIBSP2 DqXlm2K7X8uaZ/Xr7F6cWeCRy3nypZ4G/xZFD8klLD36PDbJJJkhoksqaAPcV1OfZJIhrkrj5QW omWsoukJVFDZw1nBJeZOnIb1o+fxpzHsyk58xPOTQBxNRKl1XhioEzQLW6m6BAdrTVkxNvVOpfV lRXtKh/Mlqcm0Hes1AsZ92NTSStjpD/H6651y+S7P0oyqZgrrAqfobIQXEidlDzAqsYhK996DtQ /ylTuDAV9xIAy5g== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Properties should be always constrained in top-level part of the bindings, so move the samsung,cluster-index constrain from if: block. Signed-off-by: Krzysztof Kozlowski Acked-by: Guenter Roeck Acked-by: Rob Herring (Arm) --- Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/= Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml index 53fc64f5b56d33f910395d32b35e0905b8b9aa53..445c5271879f002f2b05645a0e7= 48dd9be5aaf72 100644 --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml @@ -49,6 +49,7 @@ properties: =20 samsung,cluster-index: $ref: /schemas/types.yaml#/definitions/uint32 + enum: [0, 1, 2] description: Index of CPU cluster on which watchdog is running (in case of Exynos= 850, Exynos990 or Google gs101). @@ -104,8 +105,6 @@ allOf: items: - const: watchdog - const: watchdog_src - samsung,cluster-index: - enum: [0, 1, 2] required: - samsung,cluster-index else: --=20 2.48.1 From nobody Fri Oct 3 13:30:15 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E964E26E714 for ; Sat, 30 Aug 2025 10:19:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756549151; cv=none; b=VQ2pfuhi4T2uoPgs2QFPpxiTjzBE4NQ+kV+NcdR5x0qusjim7+v17iNXBFP7bR2G+bEasC2Bx41/Q4dOE7UFO94NSxwHAZgPG1HPAVjfTGUqVQGLOsCuWy9TdBGkc9mHgX6gvC4e0lLe6Bq6nIXpUkisjfz7gRzSJ6UKP0Dtgfc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756549151; c=relaxed/simple; bh=tzOQaWmU4Y2kJdGcyusF9g24SdvfScKvIrSTOFMPkHE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FcZUieQ3nrGcuFRTwpb5StbdzF+hfyv2XJH9bqpYuuqFijntYcRwsJehpKpKl8K+ixSktaejGhxFU+brgXDsjOkS89SIM+1gjpvWbj3lhI4y5ljA6DN5BbMc8pnmCF/p/29hfaX1enjrlLvxgwgV2x+GT1LHluTweWEuvhi+6As= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Uzxp6n4N; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Uzxp6n4N" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3cef2c300afso301010f8f.1 for ; Sat, 30 Aug 2025 03:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756549148; x=1757153948; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dZnyvhWBfuOE2HRHqZcb3d7aQZKVvQuhqPXuSlkPMk0=; b=Uzxp6n4NFwlvx43R8pXzHOxIIURYB/4IbfyaaPq4tdRKUqjSXzp2b0zZ/+DzUBkcvq Iy0HAE5ysIDJfUFwy/nfwEOEFXXz8dP0lW3JgyP7mv7Ed4Op9oFTWQ0AKjlRhWNNpQkH S1+YNN1SpCBGKiCNZxuIn7bK4W6GuSZQrh/xWQw+AvMQZf291YVtc2tbJo01mI7Zoz4+ J+lpK6uHfcKYYVbHDjf7v8/3orplItMfB/nt/J8X/4RNC+W1er+9RbNPW6kMZ9bVNW/I F0KlTuF4LT37JG9cHhEZJqjYePdvQvr4MlFQnu2o0hWYsjMjzUebn0W7Dy15iMYvPctc M1jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756549148; x=1757153948; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dZnyvhWBfuOE2HRHqZcb3d7aQZKVvQuhqPXuSlkPMk0=; b=JewIwUCpaJiBQVxsbztibhwy0pTbpkl8m2G+dwuehuTVUq6sLAHHA6gNujNOLdxskD viSa3VStynPmXbf1xgILb8z48b9YN7M7+CxRxEXCTl0Q13RJs3Cg4pJ1RT5hEi6yNiNu 9xxINmtPTautwQvsvFom6D3TegPX74DRReoBJROKuDDyHqPVKZofcmFjnNsHxvZtyhUC aDgp2+DHdB6TFljT0NV9dli9+tUSwFdBEigLMIt12k3Uuw0DgVFr3f5ft7KPBlzK3d8n 6bcWqmBuy+9VeLPfVmnHpoQXiOgveuR+Ry6n6C7dMjnYhtJ5tjyHbqk2tZQPuvR4cx0p QiSA== X-Forwarded-Encrypted: i=1; AJvYcCXV4FmwZ62mZPkEXzECnASv+lCgYvGjp3I6ogxAmUWcCjhJDX3ZECJE6mcLW6LKV+XnBUVVMruHEG2yVPc=@vger.kernel.org X-Gm-Message-State: AOJu0YxKrFOjLwIoHFRgfEhnYV9ua7RbT82YHVHX/x3pk054qep86JAO YS3K3OCIagGR90rd83MrNTzqxKEYDuIX2bRD+4ZSvNUlNc/ugrAo1MroO9eMrHNQSdA= X-Gm-Gg: ASbGncuCAW94NkS6hxeRiyE/fMrcmnIL8IK3h1nk8lDF2jGyRBeIoDepTv2j3X10qr3 WyZScgIPHKK/C88NBmYKgydBMFWVnERk6CB1EefBBQehYZ/MskfQ/lZsOEtaUR7VJvKIygaKqoo zxgv+/LpdKhVzraO0P/rWaAZfVRHkfKg56KHR/v3P6YNV01tUbu+9K2pwOQqjfV0ftYUJ2TNj1a 31oOZx33nJGXcsyhwRObo+dRYipPiP5ZG//lDtqbFzSQcRiEEMa+0mA/RnbZYeX1AZWFFsj1sYe hkv9madO0paKqAd6ZeGKUKPEIKQd0it2u2a01e9A0bXpdIkrsjyakhdSwi5jU8PnTUPssr3jQiM uv5KCe8NJvPPBFU7bvD5nFdxvZHcSeW3+6L+2kOhG66P8w2gXLIA0De6UZi/q X-Google-Smtp-Source: AGHT+IFygDyjBigp6iZ69YDdQmrabcSS3QXu7NjqRTS+fEAREpf4yRLclbJcT/wkaR/57d/WiRMZ7A== X-Received: by 2002:a05:6000:26c9:b0:3cf:6a9:f3dc with SMTP id ffacd0b85a97d-3d0fc3b630fmr1581151f8f.10.1756549148299; Sat, 30 Aug 2025 03:19:08 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf276c8eccsm6547492f8f.20.2025.08.30.03.19.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Aug 2025 03:19:07 -0700 (PDT) From: Krzysztof Kozlowski Date: Sat, 30 Aug 2025 12:18:58 +0200 Subject: [PATCH 2/4] watchdog: s3c2410_wdt: Drop S3C2410 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250830-watchdog-s3c-cleanup-v1-2-837ae94a21b5@linaro.org> References: <20250830-watchdog-s3c-cleanup-v1-0-837ae94a21b5@linaro.org> In-Reply-To: <20250830-watchdog-s3c-cleanup-v1-0-837ae94a21b5@linaro.org> To: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar Cc: Krzysztof Kozlowski , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2907; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=tzOQaWmU4Y2kJdGcyusF9g24SdvfScKvIrSTOFMPkHE=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBostAUEYwVAJtWM+2isVc7f3o+wMUKCm0EagDjU aZ+JOri5seJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaLLQFAAKCRDBN2bmhouD 19uCD/9CaCFnhAJlqwZJknBdZ3Sgef20JhK7F0OVjmhy2NesYaYZyETjCt/5O33RFCN9lVnK8+l r8tud3DpSBL5Xyq4zqA1Fcuy5iKSpMuWigJ7LqDzquDawxoXtDcZ31/th4ZAg2Kpr0ONMCONsPx D8FjGLFmNJEGV0VDDcBKe3Dpv9fmAdvw89yHLwOpoEXPMboThA+eIUeOcH3lViARsaaI5taVPhU vDvo7xQOBXdSuzFNKsKrSis4pSoSa6/BTHoVAQX/UeVPK7uR+UnUow5LhLBCgck0ylZCU0Ey2e/ +xFb7ptteGXzDJs36WyeCzmvqUgsEIDI6IEGdVOwE7PvZLc5Ho+PSsQ/Ij+28dDvZqv8+4yMf2M vFA7r+QD520/OAFmEePSx8QzVbFMkXse1EF73AnRYW7SEqS3I+gCYTIPRjflEmMqATuRoQR1NED m+72P3imsoEOus4/JdSRV+rXVuEYSK/sK1aUjdrTnT7+y3/CUSMDml1xuaxxHWttgkbHoCuJs10 Mjm749ZzlD7bOY1J7GWBDI3IYaBquJX85jLKnxz8GpNZ/fXQKO7gLa2bP9eK9h9p5Eo2v7SXKXc QVgbwskQ2yQN7pnh+5oeGSaYhU395mJhe6AiPZ7NvNesoE+8d9N7tPq972tjXOlc3G8twG0IkSH m2aSXlbDucyrD0w== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Samsung S3C2410 SoC was removed from Linux kernel in the commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support"), in January 2023. There are no in-kernel users of samsung,s3c2410-wdt compatible and s3c2410-wdt platform device name, so drop both. This leaves the driver boundable only via compatibles, so drop any CONFIG_OF ifdefs. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Guenter Roeck --- drivers/watchdog/s3c2410_wdt.c | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c index 40901bdac42613458f93c09654353190785ff072..f65f25fcce3ecbb1739ff98245b= 69601dc5353d8 100644 --- a/drivers/watchdog/s3c2410_wdt.c +++ b/drivers/watchdog/s3c2410_wdt.c @@ -200,11 +200,6 @@ struct s3c2410_wdt { struct regmap *pmureg; }; =20 -static const struct s3c2410_wdt_variant drv_data_s3c2410 =3D { - .quirks =3D 0 -}; - -#ifdef CONFIG_OF static const struct s3c2410_wdt_variant drv_data_s3c6410 =3D { .quirks =3D QUIRK_HAS_WTCLRINT_REG, }; @@ -368,8 +363,6 @@ static const struct s3c2410_wdt_variant drv_data_exynos= autov920_cl1 =3D { static const struct of_device_id s3c2410_wdt_match[] =3D { { .compatible =3D "google,gs101-wdt", .data =3D &drv_data_gs101_cl0 }, - { .compatible =3D "samsung,s3c2410-wdt", - .data =3D &drv_data_s3c2410 }, { .compatible =3D "samsung,s3c6410-wdt", .data =3D &drv_data_s3c6410 }, { .compatible =3D "samsung,exynos5250-wdt", @@ -389,16 +382,6 @@ static const struct of_device_id s3c2410_wdt_match[] = =3D { {}, }; MODULE_DEVICE_TABLE(of, s3c2410_wdt_match); -#endif - -static const struct platform_device_id s3c2410_wdt_ids[] =3D { - { - .name =3D "s3c2410-wdt", - .driver_data =3D (unsigned long)&drv_data_s3c2410, - }, - {} -}; -MODULE_DEVICE_TABLE(platform, s3c2410_wdt_ids); =20 /* functions */ =20 @@ -705,7 +688,6 @@ s3c2410_get_wdt_drv_data(struct platform_device *pdev, = struct s3c2410_wdt *wdt) platform_get_device_id(pdev)->driver_data; } =20 -#ifdef CONFIG_OF /* Choose Exynos850/ExynosAutov9 driver data w.r.t. cluster index */ if (variant =3D=3D &drv_data_exynos850_cl0 || variant =3D=3D &drv_data_exynosautov9_cl0 || @@ -741,7 +723,6 @@ s3c2410_get_wdt_drv_data(struct platform_device *pdev, = struct s3c2410_wdt *wdt) return dev_err_probe(dev, -EINVAL, "wrong cluster index: %u\n", index); } } -#endif =20 wdt->drv_data =3D variant; return 0; @@ -929,11 +910,10 @@ static DEFINE_SIMPLE_DEV_PM_OPS(s3c2410wdt_pm_ops, static struct platform_driver s3c2410wdt_driver =3D { .probe =3D s3c2410wdt_probe, .shutdown =3D s3c2410wdt_shutdown, - .id_table =3D s3c2410_wdt_ids, .driver =3D { .name =3D "s3c2410-wdt", .pm =3D pm_sleep_ptr(&s3c2410wdt_pm_ops), - .of_match_table =3D of_match_ptr(s3c2410_wdt_match), + .of_match_table =3D s3c2410_wdt_match, }, }; =20 --=20 2.48.1 From nobody Fri Oct 3 13:30:15 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B60E5275AF2 for ; Sat, 30 Aug 2025 10:19:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756549153; cv=none; b=T9k4EWsvmBe3hV/Xmor4CWam5kG2nCQyqQ8WYx7LrP5+lmMukiG8hMKo/b5WFShUUhHYuYskTEI/AjziCwfDRStz3tvBVzCWC22BRCD/Vd8fAbOe7gIKf7OR2SdnwzUV+gGN42KPtBaCcpBnm9Jb1eUafx3IoEvnDZohnL6gayU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756549153; c=relaxed/simple; bh=NvFVk53JPURQUDV8Y4c/VLoYIsxRD0yXmhCyTafaDzY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Emb6pm63bgaXMeSRBkHV9lGFHQN2XXmd96JX69fCSdOaFeiLm54YtWTjI5Ho7CJzZW4UVpbeTrjL8F6koyFp6XfWIzjahoOegZvdgwJoDVbTKG0GYf5q9pNG+xmzvbwoOg4oTwfCQPFhyrWPv6NmkX7hZFhtUkzFhcr2BBybQcQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=i4bYN35Z; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="i4bYN35Z" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3d12c5224abso168847f8f.0 for ; Sat, 30 Aug 2025 03:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756549150; x=1757153950; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RQkwG3esvRsRXcGjq0nlDl6dBfzj0vcyqIdzAb+t90U=; b=i4bYN35ZLZDD0Nzhk/bhLF4zakj4gmtbBh9AquJ7r16P1tCgrJRcBgSGaesVnKHdpo eqks+zDij/eehE1a7xhPhYfuGeONd1YzaRvpMqwtjkFsh8KGhwutB//r7UOqyFPckXws L3Vsck4BGlzwlLWGw3ku9Re7QN9Ai0ekYwe9cFvnV3iq2dtohoc43QOkePvmIGNbAB6z xkUsb0LQv9MMtHES9WYFVNspFJiz9haIQXECzw9ihQm5CxnKXou+sX3YAa8kFO9WYJYd dbOQ2hQkZiZC3Ro56XL0dv9JUJ33ZN51xqRbJzoIfwUO0d76YkPHIHN5JPLouH5nUMKx Rz1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756549150; x=1757153950; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RQkwG3esvRsRXcGjq0nlDl6dBfzj0vcyqIdzAb+t90U=; b=t985Ktu2QsusIJV+SJxslUAo/l7Em3W2Qxh5X7Kh5s7epg+LYjjXd0xLooQ6wzHHZH vwHdZV8HergB23a+v/QWqU3PjcSCh4a1o5pjUvOP3YaBH/9IsnpT37axXV9E9CcFppNp 49pj7acu84+1QoHrCb4a3Nz5r/4B8q6Trb0atFBOb6lAdy44yvDYJdiBx1kffocEcmmj 4WphsIoq2Nrnv3VSwfca4AFQIwfSYBgrExcSexYstVVplzcDAHh27vcSUuAL9wyfz/Ln Jj99wGd+ntsbRNRlsvDpyrKAABWBzDcKk9tnOcthVi52AAMhDk/wzt01Dfr1zNMURLio VLHw== X-Forwarded-Encrypted: i=1; AJvYcCUElAV7j8CujGWTbZn7HBG53lxphFteXBH+aiWMoDFi+qP7QZDzbV6ffxPef/oHODSpgBHABlWb/phKUCg=@vger.kernel.org X-Gm-Message-State: AOJu0YwVMSMNKoIKiylWQkgNaNXFYjf3AkoYC8rt8vH9P77lr2TSKyRN ICK8c4S44sqTeJshw2nl2Nio+ZreU21K1WA4QMF/fjDfVyK6JCb4EsMQP09gnTbpLa8= X-Gm-Gg: ASbGncseow0MesB5ISZCAGKA977AhU4/WOBsAD4CygyxfyOyYJi2FU7IZ+XWDiy+blc B7V752XH5l0FzKwYhQ7BPmAtI9xRwPw2l57mM/pem/t3GiQ6QlIW14fLzN2CQ4Q7k3rCGwak08t 11lccl+htn7aNoZ34qjF4uU/MYfkx49GBMLKHwlP/oZHXiAykBLZ9TuOfMtsWX000mBcuzx2tTL Wrs8PVItpSjXmj8BoxwNHR9dgmHBSfNY2QVKR6Y/iSAONKVcmFkOehA50Z3McUU+VXOWVGRln14 WC2KcrvTbUYpx0L34tjmXbwd9aNoVPcih0fa2QEf+R6/gi5RovJzIAnM9s2OADoAlZyTrCBtO/g OLl8AHZ+ZCQQKehcSpvRkLYc1eztVM1a7vIiF91/l0L76ao7s7w== X-Google-Smtp-Source: AGHT+IGvK4zWnlaCkD0f/IQFYVOmByD4kqH4uguG0N/BCo4r6RwhrUrDJK8xeOPyv5jvg1TSq2X0mQ== X-Received: by 2002:a05:600c:444f:b0:459:d7c4:9e14 with SMTP id 5b1f17b1804b1-45b800cecd5mr22607935e9.0.1756549150034; Sat, 30 Aug 2025 03:19:10 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf276c8eccsm6547492f8f.20.2025.08.30.03.19.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Aug 2025 03:19:09 -0700 (PDT) From: Krzysztof Kozlowski Date: Sat, 30 Aug 2025 12:18:59 +0200 Subject: [PATCH 3/4] dt-bindings: watchdog: samsung-wdt: Drop S3C2410 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250830-watchdog-s3c-cleanup-v1-3-837ae94a21b5@linaro.org> References: <20250830-watchdog-s3c-cleanup-v1-0-837ae94a21b5@linaro.org> In-Reply-To: <20250830-watchdog-s3c-cleanup-v1-0-837ae94a21b5@linaro.org> To: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar Cc: Krzysztof Kozlowski , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1400; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=NvFVk53JPURQUDV8Y4c/VLoYIsxRD0yXmhCyTafaDzY=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBostAVi1bpYXyeIxAn9++1KZjZ2KpRpiB3xHjRF uAMEVQ8RMaJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaLLQFQAKCRDBN2bmhouD 1xxQD/4ii3iTngoFf9A4Dgol3h6dIma/GS0zpvssmtqke8BXY3xVZWg+j4w7cvobY7VQckDxOMN ZFnQ9kmddkcXTuKB33VdUlZLd2qnZiGZohnl0EEdDzQRJj99lfwINF9GdMgxuX9urIcCV7bXLV2 rNmOLdOfoyTOl7NJjQvBVGyN5dAk/dEPbzqcHkKSSVxuu13deyIZhOQwhagA1j3JKhIYZPUwf9b k4bPN0yBvoC8bz474FsU/awElM4pRLcqAObicKeyMhzLZ33U0C0+vQvfp30YF+GIP9HVw7OoufF WxE93XppZpgXfHnXgMoph9qXjMycTUkipcX9hpvs2Vt82bfBUlKaSxlz815RMpQ3VgluSoNNS7D q9SjLMj6Nnm5AdreDm2wQLpJQ1HM05jlEPU4wYgK/NBDUrF6UCmEeFjBbIJGnUNnHRO6r+xb4y+ A2njgktciBlZ9ZbtyZ/GAvm5tcorVl5ztTRAkWGFgDaFV4HGhQfqDAaNklgkdwFwT79KwLNodLV YrPI48t4HlPiPNk7TbpUBJObPFc9qYgSQmWDB5sBVcZ5Q55sL1/T5VPPlFTG01BNDz3S4qF0tyy XinK4XV82zUsIa8JyFcfsqlGlf5VzO4bVfrZ0Knwr6CJ5ZgR/PZpKm3XBz7gISM2seUqrvy2pF2 XbheD6X0aTBjwDA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Samsung S3C2410 SoC was removed from Linux kernel in the commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support"), in January 2023. There are no in-kernel users of samsung,s3c2410-wdt compatible anymore and platform is so old, that there should be no out-of-tree users. If such existed, they would have enough of time to object dropping Samsung S3C2410 SoC removal from the kernel (which did not happen). Signed-off-by: Krzysztof Kozlowski Acked-by: Guenter Roeck Acked-by: Rob Herring (Arm) --- Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/= Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml index 445c5271879f002f2b05645a0e748dd9be5aaf72..51e597ba7db2615da41f5d3b6dc= 4e70f6bb72bb6 100644 --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml @@ -19,7 +19,6 @@ properties: oneOf: - enum: - google,gs101-wdt # for Google gs101 - - samsung,s3c2410-wdt # for S3C2410 - samsung,s3c6410-wdt # for S3C6410, S5PV210 a= nd Exynos4 - samsung,exynos5250-wdt # for Exynos5250 - samsung,exynos5420-wdt # for Exynos5420 --=20 2.48.1 From nobody Fri Oct 3 13:30:15 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45711277038 for ; Sat, 30 Aug 2025 10:19:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756549156; cv=none; b=lVzwVocjl5AJXUQ3AXkzQifK9sQ5gEVujL9/5F4jPefXJXcXW63S5ulEwpJhbUhcDqNPy6SoHV7XELjhLMrD+qnMi97MW0BHC0Ml5WGaAiziRDN4Bs0E1c5V3A/wDRnABmsIAHE6F4m9FjreRcvdCKUZX0cYbq/RW590GjBh0Wg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756549156; c=relaxed/simple; bh=X4WEqjDsxEfbxQW5piC8N1hdhc/VRxO6TIqCp9uqtgU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Bsx4dCfLygOG5AAwgtvffOIJ+I4yEoLpBlYcZ7gUiWql5vO8keN5y1u9ElIWBXhQF7nmqMhJ/4+PgGRSu6Umc1UgRPvouN4a/QInJ4rW2oJN1fRTOcq0OM73Bc0XdNf4efYMvKpOIat/bTjQKQgY3MXpfHzhW+MG8hiTK6hOzkU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Vro7Wlxd; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vro7Wlxd" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3cea1388486so140141f8f.1 for ; Sat, 30 Aug 2025 03:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756549152; x=1757153952; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xXv42D6IasHB/AaS0CVhCn6HxB1qNyKePPGDfeN311k=; b=Vro7WlxdmfgHmRtEZMFT0Aq9xSCGQVJsdi+MOV03urHytjOgioR9nB9rvUb31lqv43 e1ZdgmS61SSbdi8NJfb7BUkAxWBmTX4G7rHQAQgpQBt0uaAqxlj8v8cum50Q/4Lwo3yD m4Hyq8SgXuHS9jiEwJtcA1HkDZLxUJDXsXRGweStgnBXYxahd3M1DsvaQ4yIVT+9qRI3 929rXs86HaUGToD8JzZeTotNsbRBgegXHTy2VZMh/5N7LCFx04SaoPs47KEpiEYZKs1D 6QrH7XbebwEp54UwRUNtqNPU2Ms4LCSSAWhalwA69iU/uF7nuGYNrcmnn+OgJo3nk5Lv JhGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756549152; x=1757153952; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xXv42D6IasHB/AaS0CVhCn6HxB1qNyKePPGDfeN311k=; b=aZuR/6++D+U5NyrVXni4ueb5Qv0qWBkIHrkez0kZ238deC2zY95x4m650snFad+lkl fodVgplFv3dGSqnRzyMJ00Eni27IfUcE7W4xIO8Hu43QNqlKwx7csDhLN0myHdw5vhN+ eWQzhWLfXcOOfBzrbEJlUZE4mpfltmgNjej9s8Kw4tJNWSDpR2p7olnO6+zV6rDceSOs YuGounG2vzN26ctBcSdnX5IuLaY0lgVQVEaHqNE4dlCuwkM9wPshQk4e4JzoYQvNHb04 l0+tgri55dA3uYIfrFL/71YPCYzWZ2x0Qy15Nlqw4UPvcWz4BK0gCCA0Be/U4JKNeVOp Gv5A== X-Forwarded-Encrypted: i=1; AJvYcCWLhYdtykNMuxQcpgwGOvbw5F/D68UbRFwG4NsB/kaQb4iT4+uOrn3FN46lH3fK5eRGZql6Vn/BgKVHe6A=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3l+RW9BMVq+aaHO4rcjIX8v9bF+Xd/k0y0trPgiQFH9IMc9ot MHbNP5yYLXFY9fxKLzfZDdN0F+ahn4uZxZra1YLLL8UMf0bjKJ+IdGhQU3FzvRBXrMg= X-Gm-Gg: ASbGncu8W49mRvtImU23tmAHGWPd4USwcxjWlH96SViA5Q3OsMc9xrZtepJoA1IzRRJ CkfiCWFs/IpcEof7/C6fFC9t2fhvO3Y4PuemNKfLjo5p47S9Xa2jmnY8K+YUjIURLOsZ12kBMzp cBUi79CDOapDwGnYQY6FPdKGFcs72PiIeWobVufLGpIY2mrP6KHMuKhh5/ab1nhgdscAena4toH Aydf6icBsVWboJauto88yHPacBiBYCrcoJtH3v1xuG0/hVgvINjebJohvXUNkcX8XTPB1GqA4aR +BCs4pXS26UtORN1ONqAhmoNw6dGy4VAid8XDYoXEpLM4J6rWt6yEpzVLiJcbEYJ8EN5a862FZB zbRG73kdh875NSkoEEaQGI7w4UvZkiB3biARkI0c0SF135ib2Ww== X-Google-Smtp-Source: AGHT+IFLBqkvSILcmyvRV7c8Yxt6Oeamg/J6CxZ30pz6zRS3XCq3IAwZdXSdCt7ZFipQzams4ailVQ== X-Received: by 2002:a05:600c:3ba6:b0:439:88bb:d00b with SMTP id 5b1f17b1804b1-45b81f23df6mr19954015e9.5.1756549151588; Sat, 30 Aug 2025 03:19:11 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf276c8eccsm6547492f8f.20.2025.08.30.03.19.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Aug 2025 03:19:11 -0700 (PDT) From: Krzysztof Kozlowski Date: Sat, 30 Aug 2025 12:19:00 +0200 Subject: [PATCH 4/4] dt-bindings: watchdog: samsung-wdt: Split if:then: and constrain more Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250830-watchdog-s3c-cleanup-v1-4-837ae94a21b5@linaro.org> References: <20250830-watchdog-s3c-cleanup-v1-0-837ae94a21b5@linaro.org> In-Reply-To: <20250830-watchdog-s3c-cleanup-v1-0-837ae94a21b5@linaro.org> To: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar Cc: Krzysztof Kozlowski , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3834; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=X4WEqjDsxEfbxQW5piC8N1hdhc/VRxO6TIqCp9uqtgU=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBostAW/yJv5XJd7fLze1+/dmluWrrNtXl9d1W6K Jo9u6soSDeJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaLLQFgAKCRDBN2bmhouD 1/LxD/wLNsNpbl5CvNPmAKy0p6N2E3ZHvQjlbWti4Bu+yHut5d2rMIMj9iGBSrXxgY9UE1876Lr ci6HXpPWV6XIG+OJfat4fqZghFLEkxUFuI95WgCe3rUmYy33aSu8h4S8+qN83lfcJJXLMZHKbNI dUs2vV/UIMfVeRmtfkbWRK4SVazimfKQ++VXW8LYAGiE1/XY8fcSdmal0PJheh64hxZe4OLMJQ3 TBTpTA65Dyx+/xbQ/Lyi855tgaRyyWOfsXCwavGOCqkKFJ7kXPEuY0/sI85Q19jclnaTlnig60v gz3CI0H0+BO5ErKSiGh3xBiY1BY0YLZ5laPwUZs3puPoDRP+ENANFa3DTMiaHnEN6P4uEIDsvDg o2+xStp/Nic+nSNM9fQ2Cpp4sJpxQbDL8iS9hSO4vmTRrO39xwNK9guyH1g0WfVducgPT1VhNad SiyGvEeUXA6/9X5PSxW0AFuMLPVNEYGsskrpeUZNELfQUokKtVQOmgg5EHDVUfp4OIxExrNcR2g 5WQqTyPc3WFEQfYbkiOI7cGPW/yqdRXmp4CbsPGiqO16xhZtq64e1qBbQmTVY1MWfwZQoBc9WuV OSZmIVWjdTqRYROZxNKLxjeFVT7xT0e1s1dFzt5TeAQvbcqdQ70S/JDjL+K/GEqGrMsxReLOJSE noQXO3qWK6Re3jg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Binding defined two if:then: blocks covering different conditions but not fully constraining the properties per each variant: 1. "if:" to require samsung,syscon-phandle, 2. "if:" with "else:" to narrow number of clocks and require or disallow samsung,cluster-index. This still did not cover following cases: 1. Disallow samsung,syscon-phandle when not applicable, 2. Narrow samsung,cluster-index to [0, 1], for SoCs with only two clusters. Solving this in current format would lead to spaghetti code, so re-write entire "if:then:" approach into mutually exclusive cases so each SoC appears only in one "if:" block. This allows to forbid samsung,syscon-phandle for S3C6410, and narrow samsung,cluster-index to [0, 1]. Signed-off-by: Krzysztof Kozlowski Acked-by: Guenter Roeck Acked-by: Rob Herring (Arm) Reviewed-by: Alim Akhtar --- .../devicetree/bindings/watchdog/samsung-wdt.yaml | 70 ++++++++++++++++--= ---- 1 file changed, 52 insertions(+), 18 deletions(-) diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/= Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml index 51e597ba7db2615da41f5d3b6dc4e70f6bb72bb6..41aee1655b0c22a6dce212a63fa= 4849089253f09 100644 --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml @@ -74,24 +74,7 @@ allOf: contains: enum: - google,gs101-wdt - - samsung,exynos5250-wdt - - samsung,exynos5420-wdt - - samsung,exynos7-wdt - samsung,exynos850-wdt - - samsung,exynos990-wdt - - samsung,exynosautov9-wdt - - samsung,exynosautov920-wdt - then: - required: - - samsung,syscon-phandle - - if: - properties: - compatible: - contains: - enum: - - google,gs101-wdt - - samsung,exynos850-wdt - - samsung,exynos990-wdt - samsung,exynosautov9-wdt - samsung,exynosautov920-wdt then: @@ -104,9 +87,41 @@ allOf: items: - const: watchdog - const: watchdog_src + samsung,cluster-index: + enum: [0, 1] required: - samsung,cluster-index - else: + - samsung,syscon-phandle + + - if: + properties: + compatible: + contains: + enum: + - samsung,exynos990-wdt + then: + properties: + clocks: + items: + - description: Bus clock, used for register interface + - description: Source clock (driving watchdog counter) + clock-names: + items: + - const: watchdog + - const: watchdog_src + required: + - samsung,cluster-index + - samsung,syscon-phandle + + - if: + properties: + compatible: + contains: + enum: + - samsung,exynos5250-wdt + - samsung,exynos5420-wdt + - samsung,exynos7-wdt + then: properties: clocks: items: @@ -115,6 +130,25 @@ allOf: items: - const: watchdog samsung,cluster-index: false + required: + - samsung,syscon-phandle + + - if: + properties: + compatible: + contains: + enum: + - samsung,s3c6410-wdt + then: + properties: + clocks: + items: + - description: Bus clock, which is also a source clock + clock-names: + items: + - const: watchdog + samsung,cluster-index: false + samsung,syscon-phandle: false =20 unevaluatedProperties: false =20 --=20 2.48.1