From nobody Fri Oct 3 14:41:45 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ADCE2C21D5 for ; Fri, 29 Aug 2025 22:43:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756507428; cv=none; b=onYOu/CJCWFE4DdZyRvU7XJZNs8sEnOuz8pCsqV14uAkssqBMNkjMIrgjp1agEeuOSLT9e5jPrf0sDAIEezY+Qrmz2Qf+COLYl7gKZKuSrusEpALvGfsdL35o6+yNdJ+itZ0wwjtSOt1oBflrRU5XQEI0keTXFOm+l0pdhQ4UHk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756507428; c=relaxed/simple; bh=kzqGDyWPM45AEnQWZknAN3s48rr9rv65Xi6dreboiSs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=D4U1pBa1Nlsz+D2wENTL97yXBC6ugA7cso89oB60qH88UaEcVupQPTv69y83Lk7HSeaFGt+pOI4/q232ngDiH4bbHvqBU+EO7iFuzeHbPu4c0aQJumn/oVv7eqTFCyD4XWkYg0lb5p30x3JQo+2eivWPgyzWz+RQHAtlal17OuU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=V+z89RFG; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="V+z89RFG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756507425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+gdTOKk1/eH4mNU8bIQIDKd1Df4IdxKppBOHckOsbo8=; b=V+z89RFGfo+8t1rT0jRXrDmy6p1LLjQR6GnfFg8aDpLSJ7vq9ZpWHSla5d+BohijLaXXbF rABDP5q6suCkr8p9s7U/J4GJVKDRIcVjYOIHATAjSqwEdaC2RMqAHpO5u/Lrl/0KJ2tHja de2KLu39URYKxtXuDEqN1nWRgys6ACw= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-161-ZGNqGcuWNoi4PuuZYo_gnw-1; Fri, 29 Aug 2025 18:41:46 -0400 X-MC-Unique: ZGNqGcuWNoi4PuuZYo_gnw-1 X-Mimecast-MFC-AGG-ID: ZGNqGcuWNoi4PuuZYo_gnw_1756507304 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B77E519560A6; Fri, 29 Aug 2025 22:41:43 +0000 (UTC) Received: from chopper.redhat.com (unknown [10.22.80.78]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1D2DC1800280; Fri, 29 Aug 2025 22:41:38 +0000 (UTC) From: Lyude Paul To: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Cc: David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Asahi Lina Subject: [PATCH v3 02/14] rust: drm: gem: Add DriverFile type alias Date: Fri, 29 Aug 2025 18:35:17 -0400 Message-ID: <20250829224116.477990-3-lyude@redhat.com> In-Reply-To: <20250829224116.477990-1-lyude@redhat.com> References: <20250829224116.477990-1-lyude@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Just to reduce the clutter with the File<=E2=80=A6> types in gem.rs. Signed-off-by: Lyude Paul Reviewed-by: Daniel Almeida --- V3: * Rename ObjectFile to DriverFile Signed-off-by: Lyude Paul --- rust/kernel/drm/gem/mod.rs | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/rust/kernel/drm/gem/mod.rs b/rust/kernel/drm/gem/mod.rs index 31c5799d995c5..80940ed11368d 100644 --- a/rust/kernel/drm/gem/mod.rs +++ b/rust/kernel/drm/gem/mod.rs @@ -14,6 +14,13 @@ }; use core::{mem, ops::Deref, ptr::NonNull}; =20 +/// A type alias for retrieving a [`Driver`]s [`DriverFile`] implementatio= n from its +/// [`DriverObject`] implementation. +/// +/// [`Driver`]: drm::Driver +/// [`DriverFile`]: drm::file::DriverFile +pub type DriverFile =3D drm::File<<::Driver as drm::= Driver>::File>; + /// GEM object functions, which must be implemented by drivers. pub trait DriverObject: Sync + Send + Sized { /// Parent `Driver` for this object. @@ -23,19 +30,12 @@ pub trait DriverObject: Sync + Send + Sized { fn new(dev: &drm::Device, size: usize) -> impl PinInit; =20 /// Open a new handle to an existing object, associated with a File. - fn open( - _obj: &::Object, - _file: &drm::File<::File>, - ) -> Result { + fn open(_obj: &::Object, _file: &DriverFi= le) -> Result { Ok(()) } =20 /// Close a handle to an existing object, associated with a File. - fn close( - _obj: &::Object, - _file: &drm::File<::File>, - ) { - } + fn close(_obj: &::Object, _file: &DriverF= ile) {} } =20 /// Trait that represents a GEM object subtype @@ -79,7 +79,8 @@ extern "C" fn open_callback( raw_file: *mut bindings::drm_file, ) -> core::ffi::c_int { // SAFETY: `open_callback` is only ever called with a valid pointer to= a `struct drm_file`. - let file =3D unsafe { drm::File::<::File>::f= rom_raw(raw_file) }; + let file =3D unsafe { DriverFile::::from_raw(raw_file) }; + // SAFETY: `open_callback` is specified in the AllocOps structure for = `DriverObject`, // ensuring that `raw_obj` is contained within a `DriverObject` let obj =3D unsafe { <::Object as IntoGEMObj= ect>::from_raw(raw_obj) }; @@ -95,7 +96,7 @@ extern "C" fn close_callback( raw_file: *mut bindings::drm_file, ) { // SAFETY: `open_callback` is only ever called with a valid pointer to= a `struct drm_file`. - let file =3D unsafe { drm::File::<::File>::f= rom_raw(raw_file) }; + let file =3D unsafe { DriverFile::::from_raw(raw_file) }; =20 // SAFETY: `close_callback` is specified in the AllocOps structure for= `Object`, ensuring // that `raw_obj` is indeed contained within a `Object`. --=20 2.50.0