From nobody Fri Oct 3 14:28:45 2025 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06E8C304BC5; Fri, 29 Aug 2025 09:48:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.187 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756460901; cv=none; b=VJHUba1nKSk5KlP5aB0FMuANeVdP2MoAzwTdj9OTVRNkc/QMfcYJVfl5QlyLDe4TM3QIomIqQPq6h6fC32kzYzx9lhz83aSFUspfUoHxLMC7Ab0nsQtYclPc4JJpv4DeIaZFNGqHSV8fbxgdF7kluV0C6sbCtBywbTjD+32mj5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756460901; c=relaxed/simple; bh=rKIfyf7OZLG60FeXtoxQm8F4ElczVNB4MBc232ht5aA=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=mmtvn6S6c5cWm+L8+ZFKN1h4criHvGps0UBJzxTlaiNNLLrm4xXxTOfdZUJGCvdpcgkcovyi/YLH31AiuTrV6aEyH44k1RWflG+71K10D59JCcMR/ah5OHVrDQIHezSiwlkzgeW9XfZGpcoEPHRo2IlJwbuo+GaI1/pL8y1gum0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4cCtjz1P5Vz14MRD; Fri, 29 Aug 2025 17:48:07 +0800 (CST) Received: from dggpemf500002.china.huawei.com (unknown [7.185.36.57]) by mail.maildlp.com (Postfix) with ESMTPS id 0AD62180495; Fri, 29 Aug 2025 17:48:15 +0800 (CST) Received: from huawei.com (10.50.159.234) by dggpemf500002.china.huawei.com (7.185.36.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 29 Aug 2025 17:48:14 +0800 From: Yue Haibing To: , , , , , CC: , , , Subject: [PATCH v2 net-next] ipv6: sit: Add ipip6_tunnel_dst_find() for cleanup Date: Fri, 29 Aug 2025 18:09:46 +0800 Message-ID: <20250829100946.3570871-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To dggpemf500002.china.huawei.com (7.185.36.57) Content-Type: text/plain; charset="utf-8" Extract the dst lookup logic from ipip6_tunnel_xmit() into new helper ipip6_tunnel_dst_find() to reduce code duplication and enhance readability. No functional change intended. On a x86_64, with allmodconfig object size is also reduced: ./scripts/bloat-o-meter net/ipv6/sit.o net/ipv6/sit-new.o add/remove: 5/3 grow/shrink: 3/4 up/down: 1841/-2275 (-434) Function old new delta ipip6_tunnel_dst_find - 1697 +1697 __pfx_ipip6_tunnel_dst_find - 64 +64 __UNIQUE_ID_modinfo2094 - 43 +43 ipip6_tunnel_xmit.isra.cold 79 88 +9 __UNIQUE_ID_modinfo2096 12 20 +8 __UNIQUE_ID___addressable_init_module2092 - 8 +8 __UNIQUE_ID___addressable_cleanup_module2093 - 8 +8 __func__ 55 59 +4 __UNIQUE_ID_modinfo2097 20 18 -2 __UNIQUE_ID___addressable_init_module2093 8 - -8 __UNIQUE_ID___addressable_cleanup_module2094 8 - -8 __UNIQUE_ID_modinfo2098 18 - -18 __UNIQUE_ID_modinfo2095 43 12 -31 descriptor 112 56 -56 ipip6_tunnel_xmit.isra 9910 7758 -2152 Total: Before=3D72537, After=3D72103, chg -0.60% Signed-off-by: Yue Haibing Reviewed-by: Alexander Lobakin --- v2: add newlines before return in ipip6_tunnel_dst_find() add bloat-o-meter info in commit log --- net/ipv6/sit.c | 95 ++++++++++++++++++++++++-------------------------- 1 file changed, 45 insertions(+), 50 deletions(-) diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c index 12496ba1b7d4..60bd7f01fa09 100644 --- a/net/ipv6/sit.c +++ b/net/ipv6/sit.c @@ -848,6 +848,49 @@ static inline __be32 try_6rd(struct ip_tunnel *tunnel, return dst; } =20 +static bool ipip6_tunnel_dst_find(struct sk_buff *skb, __be32 *dst, + bool is_isatap) +{ + const struct ipv6hdr *iph6 =3D ipv6_hdr(skb); + struct neighbour *neigh =3D NULL; + const struct in6_addr *addr6; + bool found =3D false; + int addr_type; + + if (skb_dst(skb)) + neigh =3D dst_neigh_lookup(skb_dst(skb), &iph6->daddr); + + if (!neigh) { + net_dbg_ratelimited("nexthop =3D=3D NULL\n"); + return false; + } + + addr6 =3D (const struct in6_addr *)&neigh->primary_key; + addr_type =3D ipv6_addr_type(addr6); + + if (is_isatap) { + if ((addr_type & IPV6_ADDR_UNICAST) && + ipv6_addr_is_isatap(addr6)) { + *dst =3D addr6->s6_addr32[3]; + found =3D true; + } + } else { + if (addr_type =3D=3D IPV6_ADDR_ANY) { + addr6 =3D &ipv6_hdr(skb)->daddr; + addr_type =3D ipv6_addr_type(addr6); + } + + if ((addr_type & IPV6_ADDR_COMPATv4) !=3D 0) { + *dst =3D addr6->s6_addr32[3]; + found =3D true; + } + } + + neigh_release(neigh); + + return found; +} + /* * This function assumes it is being called from dev_queue_xmit() * and that skb is filled properly by that function. @@ -867,8 +910,6 @@ static netdev_tx_t ipip6_tunnel_xmit(struct sk_buff *sk= b, __be32 dst =3D tiph->daddr; struct flowi4 fl4; int mtu; - const struct in6_addr *addr6; - int addr_type; u8 ttl; u8 protocol =3D IPPROTO_IPV6; int t_hlen =3D tunnel->hlen + sizeof(struct iphdr); @@ -878,28 +919,7 @@ static netdev_tx_t ipip6_tunnel_xmit(struct sk_buff *s= kb, =20 /* ISATAP (RFC4214) - must come before 6to4 */ if (dev->priv_flags & IFF_ISATAP) { - struct neighbour *neigh =3D NULL; - bool do_tx_error =3D false; - - if (skb_dst(skb)) - neigh =3D dst_neigh_lookup(skb_dst(skb), &iph6->daddr); - - if (!neigh) { - net_dbg_ratelimited("nexthop =3D=3D NULL\n"); - goto tx_error; - } - - addr6 =3D (const struct in6_addr *)&neigh->primary_key; - addr_type =3D ipv6_addr_type(addr6); - - if ((addr_type & IPV6_ADDR_UNICAST) && - ipv6_addr_is_isatap(addr6)) - dst =3D addr6->s6_addr32[3]; - else - do_tx_error =3D true; - - neigh_release(neigh); - if (do_tx_error) + if (!ipip6_tunnel_dst_find(skb, &dst, true)) goto tx_error; } =20 @@ -907,32 +927,7 @@ static netdev_tx_t ipip6_tunnel_xmit(struct sk_buff *s= kb, dst =3D try_6rd(tunnel, &iph6->daddr); =20 if (!dst) { - struct neighbour *neigh =3D NULL; - bool do_tx_error =3D false; - - if (skb_dst(skb)) - neigh =3D dst_neigh_lookup(skb_dst(skb), &iph6->daddr); - - if (!neigh) { - net_dbg_ratelimited("nexthop =3D=3D NULL\n"); - goto tx_error; - } - - addr6 =3D (const struct in6_addr *)&neigh->primary_key; - addr_type =3D ipv6_addr_type(addr6); - - if (addr_type =3D=3D IPV6_ADDR_ANY) { - addr6 =3D &ipv6_hdr(skb)->daddr; - addr_type =3D ipv6_addr_type(addr6); - } - - if ((addr_type & IPV6_ADDR_COMPATv4) !=3D 0) - dst =3D addr6->s6_addr32[3]; - else - do_tx_error =3D true; - - neigh_release(neigh); - if (do_tx_error) + if (!ipip6_tunnel_dst_find(skb, &dst, false)) goto tx_error; } =20 --=20 2.34.1