From nobody Fri Oct 3 14:28:59 2025 Received: from PNYPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11020091.outbound.protection.outlook.com [52.101.225.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E86A2E8B6B; Fri, 29 Aug 2025 09:10:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.225.91 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756458652; cv=fail; b=gwxD6hzpi3O7aAS4OsZQV2MW6Fg51ggBALdz/0QrjlrBnEmGXT9eqP4OA4oNc/mrphpQljquPW6RW3cnE+S7ocCR0x2NS06YsHAQ3GN1gwWANt/BAlh88/wjVrp9wymx4M57iAoaqoQaGG7vkbXdo9gLrPK57NCIBOMYmosoLr0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756458652; c=relaxed/simple; bh=CDucjZNrv6M6FGCx5xs6suolUsrDeQjGDAlYnZNce9c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=ietT8VlvgofwqCVM09G4lVf4FcfFL1yOak6ITu+4TvVOYtdz4VBORmFNq/bMOgtWmlVQrd1f/tzzW9EdFMW0NIbKGHyssZ15LW8+lk+x8ttwI//9EYEXuMHC1FVRdYHFxwHFGoqDBc9TgrG1KilXb9jHBj1H2mCt7L+j0hWcE1U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io; spf=fail smtp.mailfrom=siliconsignals.io; arc=fail smtp.client-ip=52.101.225.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=siliconsignals.io ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fzL8I96uX1wQ14+Bd8m2eOql230nmizSPLf0SmIiBSn67NKPfbgeehuoaUlc8fErluewJ0ufXT74URYd8KxTMxxqdsJOFeJrJMR3L3tEt3oWHcA0BPNMxoIU/XC6gr4gFE5cGJqldW8fVvcTuGDAtbWJk0rrsxxawT+c8qh3y00I5dxGndE5EaHqUdf2rx1ieZgQljRoass4c1SA1Q08dghAz42ZL6OZyKHHmF4H1r/AA/l/hYB29Jsj7cb9tiuAN7t9cQyhw/JhrwUxUO3vNnjQjGyv26bd06lHkBCd6v2dwXECw5GcLAhLY8aMFUtEJT0YjknmC1AnPmL2CR8hGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=exxbg9V03EZS2QRPmocIux1xDUZIZFxm52GUvWcmP6Q=; b=FYoLox1DrfJOmYWfNqCCdStaJILOqHorBqZ8Y5QyqCLNLFWqFftajkTN1GkrYSvZub3Hj+dJ5hvZshlVgiUlx4LCTirFxXFJaDNQfrv3RaJlvWStHOknuIrrF2odLgZrUcyiZPA6N+r2Yja7oNg+tm8BX++ZW0cdD17cJknCnBUshP+UJ+gTDRymjMo7xVil3r1CmefOcagdC3EV8ySzPRL8K21ABZWAXb1JMTmYVVkWbeVK2am1OYVZ7WpPcu2TSJFAa/swjlHYHy/f1QAQn1RMLHmn2OHB6HcGknXvt/HAUEQ6IKI7ajsFwAiQWPNlhy+69Vzerlgc6C3FW/vrgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) by MA0P287MB0801.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:e4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.19; Fri, 29 Aug 2025 09:10:46 +0000 Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418]) by PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418%6]) with mapi id 15.20.9073.017; Fri, 29 Aug 2025 09:10:46 +0000 From: Hardevsinh Palaniya To: sakari.ailus@linux.intel.com Cc: Himanshu Bhavani , Hardevsinh Palaniya , Krzysztof Kozlowski , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , "Bryan O'Donoghue" , Ricardo Ribalda , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Sylvain Petinot , Matthias Fend , Tarang Raval , Dongcheng Yan , Benjamin Mugnier , Jingjing Xiong , Andy Shevchenko , Arnd Bergmann , Hans de Goede , Jim Lai , Heimir Thor Sverrisson , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v9 1/2] dt-bindings: media: i2c: Add ov2735 sensor Date: Fri, 29 Aug 2025 14:39:50 +0530 Message-Id: <20250829090959.82966-2-hardevsinh.palaniya@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250829090959.82966-1-hardevsinh.palaniya@siliconsignals.io> References: <20250829090959.82966-1-hardevsinh.palaniya@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0029.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:273::15) To PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB3519:EE_|MA0P287MB0801:EE_ X-MS-Office365-Filtering-Correlation-Id: 9b39c356-2ee9-45c1-72f0-08dde6dbf08b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|52116014|7416014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?PUs7C9b6YzWf/pXYB1J7mDcyvmlphx444x5m5mfbOUDwld26nQFX8LWEW2ss?= =?us-ascii?Q?ZAJHruVBYTcOKKRYDsmLoxXyuxMimjV4mjdt/dKEz+ne9X9yrDp1GcxoblVS?= =?us-ascii?Q?noVUQGrE400jwnp0MNi2hEwoJTzm+XjiKtnnhEqRqt5h1YiepC/MToIsNFas?= =?us-ascii?Q?H0p4FLm3wZvxtcwkoFjhTrJQPnF/Zw5KKh96JaKHVfnQUhBxY6DrPcvQkpYv?= =?us-ascii?Q?s3J5XagD3EyHSSRt4ABLdFJEFg1zkgcOKmtYGEoYfoXHZdvHTVOB/tNNKIjb?= =?us-ascii?Q?BI2l9cZwAXS+ebi0+3kyPMSbbF5aomLRDyemFfSpIRNYeLirPF3KU3x/wbuO?= =?us-ascii?Q?rbOD90A0VIFtKHjBRv0oG6U63mPlxWIWLAeP8ZPhyrAYM3x52aukFPHWXAhC?= =?us-ascii?Q?ZeiSoCCkTblfAyRAWSpRozeHA3JvLg0K7BF8sWgM/0bK3f63xT2ByMYlQAgD?= =?us-ascii?Q?zt+GiwjTGqtpbA5mvYYqjpkEzyAtMqCwu8qqSjWyYYYJ1h+J/WV1vEyzcHQk?= =?us-ascii?Q?eE+Kv+XaB0mqApsRIgtroxTyHeO0UKDGG+/Jg3snnmkEZmIQln9W2JgB6kS7?= =?us-ascii?Q?nnu7eURthsVxBmta2RFQDbTLmLJUXUHkXQUXfQtjp6JGgMvcPFMGsLA0HQN+?= =?us-ascii?Q?OOOmmLQtebgSi4/pmrd2Uu8WeYH6ElDYn9/sn5d4hk5Q4N20wFuhwGnkZl7w?= =?us-ascii?Q?945S20En+8uvsxLeH1YiQwbGZHdqRXqxoqqjSCQ4KhaurHOg3tjY4rXgA77p?= =?us-ascii?Q?eisTljWY5Nt8rZg51nEN5fnz+qIqPr/JTteEKLTYheqW8MHWdjQ+btdhZvA4?= =?us-ascii?Q?kYQuhnF4dcYfSi+lX99Ycon+0FLZJLAUIYfQAKuwp0BIiAGszdvg+2GZG1af?= =?us-ascii?Q?Rd9PLmPWpPQp30cwl3Ocx3X15s9UzoWQYiVMeqAROT2Ac62Hy17HrI/ag+2H?= =?us-ascii?Q?ZgupTnc+Hx2IxWTYABDoDjyItCUQp+8/lU2ldT+ZsmgavYqY0NO7m1eqhDU0?= =?us-ascii?Q?Sgm4tYI9yp2+Q+/Ht2Mbca6jm3BqivwegLuMKlYJK7gQh+vNofPlbKNaS+Li?= =?us-ascii?Q?tRlikAFwePs1eoWn9kvAArrd82/9/RHznVdAwjzBXNSXFnnEfwkS2W0XTlNw?= =?us-ascii?Q?aM3RIxk99F8pW4Nw9qtqmnpL+jfEdcHqD0fjRWanjxpXZUvZX4DFElu/A1Jk?= =?us-ascii?Q?9RycuIbCunrPqfUUPcTun58FWOuvo3iJaZdUDOSB8RBBfXaPxc3tNqjVbC3r?= =?us-ascii?Q?GfaecbyDSHJA2g3eTw4vHGcFZHpjWAB4bg4kJV1NyDqvlNaSpVe/uUldswdZ?= =?us-ascii?Q?qWLnbeKK1OvSHdSCNpVIBRA93NuVywAwGSfHvzdflensxbDYXtU7ybx8pbrq?= =?us-ascii?Q?UmifCK6w0K9Uxke/TMH4ZGTKTes7myove/Dn3GdRgxxRpW9zkVSq5LJQm6Ia?= =?us-ascii?Q?+PX5bm8g03k=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB3519.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(52116014)(7416014)(376014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dLL9MuWPIRKfUGHvjvNgAukt0HNOpSXjKNqmHfE/Kt4H4Dl6WVpfIyKSN4YH?= =?us-ascii?Q?saHhUmcGUrwcSiNAzBsxyWu2QshMslKS8iT4IIEK8TVgABB6bdfLOVTbS9EI?= =?us-ascii?Q?TaJQ2g1Lq9wql2fo1HvHjHQSzeqdVOU7KQkyL0JjOdL4GKfrienClTp6vYRN?= =?us-ascii?Q?PoQtecZIoaEiPJYxX7iOFrJXI++CSSi/bGhPmEcLUPycVyR1sXtdLJkBVj43?= =?us-ascii?Q?lD+MuHH3FgaylwPXoTC3cJWa+T7R4LYEXa+v4DMfbhpX0PUMI9vb4WA6NFdJ?= =?us-ascii?Q?y+db4mpMWAzQxC2J7dbR2CnZJAjc4B6/OWJALlweQynZRjFP6ptDyiML2mNQ?= =?us-ascii?Q?8UDnIET5uoxFVmK82T4Yp+qBB5EHxVjAW6r8BNKXf+W4Z9WToFVec0Cp+nN7?= =?us-ascii?Q?K/DUEX6Sc3YeHpnVSdzQXvxndryY7tpPwgJPFVcOa7QATQbi2OGTIxsfq7R6?= =?us-ascii?Q?23Y4FZHR3cdFOnaR6MoVLEuf0Y6B2+ZwHXq30gSzg2Z8ssH3sTMM7siISjlr?= =?us-ascii?Q?Breo/kfl7FVqUFUGMs7GUcumfTrHkZyj8xn5zYnA9DjS/e+nqj0/1hvW0imI?= =?us-ascii?Q?pjhKhdxVNLhna9R/aSsZda4F+RqC2jhKn4LdyN1aHeE6UL3+aFqQLu9FXK1a?= =?us-ascii?Q?M7V69fojCz5MqcR+g8bIkkHbCgwNjqzvXOQQ0nT1RsdASAVYjjxqTTk7lCXf?= =?us-ascii?Q?+dgda+ubcntg/zJ2ze1VDiQhiZ5B0ZbDD8W6GPMbV1tH7pfly1huCewEvfU+?= =?us-ascii?Q?6WSyNtPVGnaTxhYiFk6fVnFe7yhaICbKIqOLqPFWwAUKsbEKdhzYgx8N4a3y?= =?us-ascii?Q?FVZaVNzz9tY7h+92gSS4UlHNqxQ/q8Bv3uwQZcSqqoux09JyxAjm/Er8tbSU?= =?us-ascii?Q?6ZnaS7MS70btklHftZ77fyNJYub8LUPGVTcKxwQ+KdPk8ZmiU9SWaudPbbld?= =?us-ascii?Q?u9blRperMOD8sEY/eTUxRt36qGx0if2VT57wCEq/BDhClrKaXKTvzygXzCBN?= =?us-ascii?Q?lzOoIF0OtOyYePBwCQbq0XdzyTRI855DxtIpyIJDZ+wXHh3b6B+ev7Io0OV9?= =?us-ascii?Q?G+eUPfa7hUIbO2B2n0ZPpaJezkyNXkEVnnOiDZR+sieUjied+T2aLYOWfk4L?= =?us-ascii?Q?HJH7eJhyZHW3UsJnar8GUsnQgCHHRhfAxsURX524yzPbwDt/lgbv4Zsgav9i?= =?us-ascii?Q?P2s5ynxjS+YlqbJFjKU6etbZLsgvhPGlf7MDRRSd2DaOTkY3PA75eJnW317T?= =?us-ascii?Q?y1LVnEitRjuS+YDQHbpnM99uWzGwZM9VxKqtqzt2/F8yOp34yxNQcGWUYzQ7?= =?us-ascii?Q?7D7kMHRspitTSQkkxRba4KtUABspQDrz2Fa1l0wdZM22o6U+LTRgjKB1sgcz?= =?us-ascii?Q?nsGFekFWrYhiq6zabrh0lUcutvw+kmRf1lByKMqWWBLqVDk0UAVeYeNjMUOD?= =?us-ascii?Q?clLZ1n4nZpnDh0+GnU67gaoa9Z/nqJ/YJKEdoKNkOW0PNB7cI/JJl+Qvemtr?= =?us-ascii?Q?yfilyhfT1/XN3or/U1T/Tjnd7ORUHhXc0eHw2ICyQ+203rAMDfTbTz46mxJ8?= =?us-ascii?Q?w7a2bJ2oI9Do7ypwK61zITQPj0WyG9RButml9E0fpPUYMnrNPkcopk4dJ7yi?= =?us-ascii?Q?52Q8xmMlmT3iF978SL2CX3E=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: 9b39c356-2ee9-45c1-72f0-08dde6dbf08b X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB3519.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2025 09:10:46.5632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oyUKSkSW58Aw0T0FhBqtEOu67Q7Vlb6SEIIj3br15XybhJP6aiIwc55ydxGgWzm4H5sJcAez7LZK3Jw9tIzp1IqzW6SQmBhRQX6kY0VYRS3fKzAetCeBQO4Wu0d0uW/h X-MS-Exchange-Transport-CrossTenantHeadersStamped: MA0P287MB0801 Content-Type: text/plain; charset="utf-8" From: Himanshu Bhavani Add bindings for Omnivision OV2735 sensor. Add MAINTAINERS entry for Omnivision OV2735 binding documentation Signed-off-by: Himanshu Bhavani Signed-off-by: Hardevsinh Palaniya Reviewed-by: Krzysztof Kozlowski --- .../bindings/media/i2c/ovti,ov2735.yaml | 108 ++++++++++++++++++ MAINTAINERS | 7 ++ 2 files changed, 115 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov2735= .yaml diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml b= /Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml new file mode 100644 index 000000000000..bb34f21519c8 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml @@ -0,0 +1,108 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ovti,ov2735.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: OmniVision OV2735 Image Sensor + +maintainers: + - Himanshu Bhavani + +description: + The OmniVision OV2735 is a 2MP (1920x1080) color CMOS image sensor contr= olled + through an I2C-compatible SCCB bus. it outputs RAW10 format and uses a 1= /2.7" + optical format. + +properties: + compatible: + const: ovti,ov2735 + + reg: + maxItems: 1 + + clocks: + items: + - description: XVCLK clock + + avdd-supply: + description: Analog Domain Power Supply + + dovdd-supply: + description: I/O Domain Power Supply + + dvdd-supply: + description: Digital Domain Power Supply + + reset-gpios: + maxItems: 1 + description: Reset Pin GPIO Control (active low) + + enable-gpios: + maxItems: 1 + description: + Active-low enable pin. Labeled as 'PWDN' in the datasheet, but acts = as + an enable signal. During power rail ramp-up, the device remains powe= red + down. Once power rails are stable, pulling this pin low powers on the + device. + + port: + description: MIPI CSI-2 transmitter port + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false + + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + items: + - const: 1 + - const: 2 + + required: + - data-lanes + - link-frequencies + +required: + - compatible + - reg + - clocks + - avdd-supply + - dovdd-supply + - dvdd-supply + - port + +additionalProperties: false + +examples: + - | + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + camera-sensor@3c { + compatible =3D "ovti,ov2735"; + reg =3D <0x3c>; + clocks =3D <&ov2735_clk>; + + avdd-supply =3D <&ov2735_avdd>; + dovdd-supply =3D <&ov2735_dovdd>; + dvdd-supply =3D <&ov2735_dvdd>; + + reset-gpios =3D <&gpio1 6 GPIO_ACTIVE_LOW>; + enable-gpios =3D <&gpio2 11 GPIO_ACTIVE_LOW>; + + port { + cam_out: endpoint { + remote-endpoint =3D <&mipi_in_cam>; + data-lanes =3D <1 2>; + link-frequencies =3D /bits/ 64 <420000000>; + }; + }; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 92e9d8c7708f..710f2b2e5fc8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18471,6 +18471,13 @@ T: git git://linuxtv.org/media.git F: Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml F: drivers/media/i2c/ov2685.c =20 +OMNIVISION OV2735 SENSOR DRIVER +M: Hardevsinh Palaniya +M: Himanshu Bhavani +L: linux-media@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml + OMNIVISION OV2740 SENSOR DRIVER M: Tianshu Qiu R: Sakari Ailus --=20 2.34.1 From nobody Fri Oct 3 14:28:59 2025 Received: from PNYPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11020135.outbound.protection.outlook.com [52.101.225.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72FFF2ECE82; Fri, 29 Aug 2025 09:11:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.225.135 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756458671; cv=fail; b=sDhWlXw4rwwcS2kob4oH/z982DZP+aSHlNZAR3Ly+Jmcau6fQb3evCd8IXpi3mau4E4Vf2OuHWXMTy2j6lEN4s0vZlxwCTiJFUL1DlfFBkEFVEQq3jgi5S9Ss02R/i+XCcnmyh3bvLPdiO1U04v2OgBHTCxzXvPmtDOsopEIx9g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756458671; c=relaxed/simple; bh=13+qLm3JQXEu9gGYnAOOzsVeqb/iyWbpKWOb8ODRHoc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=aqpaJH9gyBT5rscE5sTEEr7i2H+4JEC1883TH0DZwO6yrQEayjUMJgqVZQFvw/gijDJeFhJJK/8tIJj6eC5qTD0k/CU3O2gkC2j4ym8JkHrrL1099hEj/02KMxe9uB4hQRvxjNaRAk2nkYPxtozz2ivDNP7na5tUCqtW93BQ4oQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io; spf=fail smtp.mailfrom=siliconsignals.io; arc=fail smtp.client-ip=52.101.225.135 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=siliconsignals.io ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VG6eS4BPHB92m/Baqk7Ra82hUnxFnT2twQ+CEqYBLubCR5tXnJRjiLfXaDUeUyM354xmMSKQ9MSKYpBRuJExZ2yCzvOhk+8QujsWTQZ13bX6L8P1zIx2Uokie2Ct6K2oozuuLwUXbXne8DSanx1nVx/KJxV+02Aj/WpYUA5jt/Uep/Rug3Ok5P4hEAq7TnBiFGcOBvbUaUPFQJ80snvjKd+4cU9Ya4mqo8OHzeoZ/yyKgqsbrypIl+hDd0yiljfGTTzYDscvQSstqRIanOdSyS3Vca1Dc2O8R0fOVCM2HmZI602ODZsFF8zCnpjxLi1LrMVlFmG1mclR0illWcmHQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XCitms2wZyprAZCcNmbXBPerg+dVaRZAEwe8juKQL/Q=; b=FrxmWY6SbMxjp44V11o9FllmvB6vzORrlBHCufv+GJwL+FCBTdZuZzetooGH3V883CeuCZ1mfUn0iUxjXFq9L4l7LznzTSUKtEO9cM0Hpm7Dwt7B/QDBgvuTWV3yPiwAuveR6ztQbz5sew8zcRtRomhZ817oP41yiqcsg2UT/lHzny/WbHrtGTJoF1t//OAaAsYSMxTK5PWKsJ9a1grDN5RbTJ9FwJbZ3gj+0OvMTEVStdF+LVGt6SqMAwZDMHqSW3YkuOJ3CFAVJ+wfRWnprhEfGVlg3c71d8OYXBNrxBm6W5vRDB2nDTIm6aF0wSHjZWFblAiwPSexmMBH0pvoMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) by MA0P287MB0801.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:e4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.19; Fri, 29 Aug 2025 09:11:04 +0000 Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418]) by PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418%6]) with mapi id 15.20.9073.017; Fri, 29 Aug 2025 09:11:04 +0000 From: Hardevsinh Palaniya To: sakari.ailus@linux.intel.com Cc: Hardevsinh Palaniya , Himanshu Bhavani , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , Ricardo Ribalda , "Bryan O'Donoghue" , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Heimir Thor Sverrisson , Benjamin Mugnier , Matthias Fend , Dongcheng Yan , Sylvain Petinot , Arnd Bergmann , Andy Shevchenko , Hans de Goede , Jingjing Xiong , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v9 2/2] media: i2c: add ov2735 image sensor driver Date: Fri, 29 Aug 2025 14:39:51 +0530 Message-Id: <20250829090959.82966-3-hardevsinh.palaniya@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250829090959.82966-1-hardevsinh.palaniya@siliconsignals.io> References: <20250829090959.82966-1-hardevsinh.palaniya@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0029.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:273::15) To PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB3519:EE_|MA0P287MB0801:EE_ X-MS-Office365-Filtering-Correlation-Id: fc34e776-251d-49d1-a39f-08dde6dbfa9e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|52116014|7416014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bGWCOS8Vpm1oAlpcFxPErXi3WkU8POovoWf/5AOtZnF2YopyuMxin2UOiXMv?= =?us-ascii?Q?qqGPB1t4JkuAa9QDXmU4ZLpKdH+sLKRpkvAkX5G6d9gb3zYCVUILugomPabn?= =?us-ascii?Q?mr2RfITWJc1fkk+pOcIR2tlrc/OZ65zCaMadLkuDTi34XJgMuqXSY2c6QWpp?= =?us-ascii?Q?F9DyG1+1vKkr2OY1Sge8HfH5/iWb/nqRmHUW90MdLrIlXPaXmn0IQP+wt0CI?= =?us-ascii?Q?0VnpB2HwIJewZ/EGj5h9C1YrBwpD8h0roEgHQXVp0pyRtEDpDCcaZ0G0VeXv?= =?us-ascii?Q?gf59B3uIkViMGkCMzLlahSNp6aS/XL7TNZF9r+Uvij03MG38QbVT5Umb/J+K?= =?us-ascii?Q?KV9IzAUEfI9v7K5h0w0K379jTa3al/RFVWM9Cd7GYodP2j3PZ/8LM1dAVYDT?= =?us-ascii?Q?kdt8ki9PDeRlp2eRA4KO1HerW0c9l02UX57fbbymHd/E4WMAIShv3WdfTPvl?= =?us-ascii?Q?ouabXU9+Ew0QH2Ixv16FOPAYngssESAlrtRITdmV67zELofFx8ZIhHjTM3e4?= =?us-ascii?Q?2i6NxgNV4eAE9rzVRDqFKkX4FtcxhqI6k23nFHdS2k2Qupx61qtnNzDOlVlG?= =?us-ascii?Q?/YO8KL5ktqGb/QImaJ3a7ElzWf8eMQ5JLUUzFaeiBu0sjdKt9Q5QNVXOifX/?= =?us-ascii?Q?82elXs/5W8WLTKH2uukI1L6sfvuHlIORXksCIJeROTt8AweWA12KzkfRvy4g?= =?us-ascii?Q?y7+4crxTtrVzurmWnE9he6wpkj7dr7iTIxnqR5azrxQUnEon63eznpFTr3aE?= =?us-ascii?Q?W2MAcCCYuCFeRbKPEOPAhh88+suyrCXHKXkAMlfn5lnoVE5MJQvESyqxeaB/?= =?us-ascii?Q?r/k390xeU7sjcBiuo6jcM2/RcVT2PnlcCqKhNShDPMAro2OHVcoUtI0vUN8Q?= =?us-ascii?Q?Rtq692yasjFV39BbS/HNlKFW4rhBRMUPLV6Ed5M145ATYNc2UOM2GTBidB1a?= =?us-ascii?Q?Kq8wT0ZYhtVw6eJQe1sGbEXEoErMyR5rrSrlMiavtStYVYSC6UZFEXJaqFtd?= =?us-ascii?Q?ZWMrgaqbZ9tTv440UmLdIpFDqqLZ2vvQ644b5sCmhT2+KUWhlixkIGrFGT3C?= =?us-ascii?Q?dZd8h8a5R+e5K+ZueT6+TvUG7ydVufxiF+SZCdcI8orDrn5aFjtzDD20prNd?= =?us-ascii?Q?Q0yFxKg+eM+CJQpl4yfFbFV/5TiMJhMqnAR9oYxP71hsVqXw5jSs4I3peza3?= =?us-ascii?Q?7xnkgqy4KG845PXNzbK+kDATtXkGGDvZuNU8TleLSZ5GFn0L1+SkDWh181Rh?= =?us-ascii?Q?trCejVRrnkCNbwSQwm+dfrJiVn8aZVskKZPUbq5rFL1KRawXblnBDpQmbMSy?= =?us-ascii?Q?3A9n2EagrnWfty4fuO9QafpAGUjOpVt+b2SfRWmz4aM3bUjIxd9Ik+MZWgip?= =?us-ascii?Q?7NwwfCPe1j70VrbydaktwZM2GoG460SChZBKfimGO4SfBDtenNGZJBlQr3QS?= =?us-ascii?Q?1YyXtFmmpCyYsZUQovrbhJetJyCkMhOyqbG9DlRrUWnh5eGnqNScow=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB3519.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(52116014)(7416014)(376014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?63un/xHzyi/PQKMuSBpgcJKTPmGBuyaRhbXyfAkAOuTyHywTIVrBmyDudBAL?= =?us-ascii?Q?ou7tvtSOPniOkitddXSaP0QeXrYe415VWzHWJS4GDcrA5CDlsv7TOLIqkhVJ?= =?us-ascii?Q?INfIEBMmAeYnNeYx0ML1d9bR1WmAl7M04b7n7oIi3j4aSk9p7lArJlsyVZHn?= =?us-ascii?Q?Orogu3ykeBkJc76Ofe4QkkCtR5vsH7aDtmc05QZ/fzxyGiKaXeo7YIGXWQ5I?= =?us-ascii?Q?Jc6U6HJuwKhW3wIyqmeBr+SXq5nzmBnAE2v66jPLk1q/a9d07NwwFdTSKNe8?= =?us-ascii?Q?BsMu/8SyVPBKrxtQip0RpinzJTyyNYRoKPVgJm2W0ebQ2IGuiDpSIcIfcMmV?= =?us-ascii?Q?kDxoTMlYK2niTt60XUwV9KxzAJT9l79YesFiRtp7X8zweg/8RaZsKQj4ZY+y?= =?us-ascii?Q?9xD9+5pl9q0fNAH81mE80kPzwmycAEFf+YfhUqvWOrTe/uGMTyR79d+Zo0su?= =?us-ascii?Q?U7uBpMKDbhiiWDmYmSclyGeT/0RMQo0Cw4YepVGlXz9Ve2Dwum29TpIzWD8I?= =?us-ascii?Q?Jexlx/EyMoteIZw+xgFidgJUzNMROUJzpyE8BvvymSQDyEBeH6oErEGbalai?= =?us-ascii?Q?Th8XpdYyvBJyIzjSDbCTsCgV61jb0ffkww87zlVZBVhcK4VPO6qXnSCQyjxk?= =?us-ascii?Q?krbRbCeATyzyfgBgul9BnsrFFWI2YQT+hy/TKJfz1UCC0z9Ukst8MKhxEz1P?= =?us-ascii?Q?NW+G8f3P0GXw78uFpOL476zMDq1yFO8hA2PAWBIQ7xg9GTQYurcmkYBN1mJv?= =?us-ascii?Q?BNARzRmNN7fEvmvN721N7KrA0YRQGu4IlTE//u7UgkrpejXZBSltE0HiZ8tv?= =?us-ascii?Q?oyGx3fVdIdU0v+5OpULUR/lAuemhpFwM5Zzd3M15R2kGSa6dZ2yOmBEPYpw5?= =?us-ascii?Q?1l64JTuOgwqVa1CSSkf2vHpHljIkFbGf9bWJrgU4q2pTRDx6Zsq3WUqb7VUV?= =?us-ascii?Q?bYJE+8elLTg55CmNn/DUFlx8Iu9hfQPq78U+Q/emBkUats8WONLkXdr6V66f?= =?us-ascii?Q?EFud5Ee/l0q54PEw4wJ+uNHKl+ddq/qzr1wXZQ78vkKCRt810zUQwKZMOKN9?= =?us-ascii?Q?kkeMRwj+BWlRTWqmTiL4Px1MEzK6eUpOx3kQ04bVJLrjsMZqLYXyYd0eZo/K?= =?us-ascii?Q?USixqwaksH1RxuuLLW7Za9haMPf2oPRmKZ7A+jSRS2Q7g7LhGiBv6hxLlmY4?= =?us-ascii?Q?bb+foDIYw5Z6GVlEFSr+JwJf9knybMEEWszflQLK6ykbV7iIvQ07v/vYfRr+?= =?us-ascii?Q?YRaKdmkqHlYYCLLbbXnj4iN/wr6FsqITXnIhYQZm/WsJTUnNG1b6RqpNiy0Y?= =?us-ascii?Q?I77aDEfdSu3vM2NQ5PgSbpoRiZ/g062f3wx45GWalH2khhvAg1fl3MWFv4E9?= =?us-ascii?Q?rmBKmYazxbuZnFnQBmL07HO0GbNA3dEixMX5tyc9EPSeHEstYBydJoC85zZR?= =?us-ascii?Q?eVtMv1g+GzQockJ8ID0lh1U3n4k1lKeE0EYFd7Zz9HqqdiUeV6iNaDNJhmu5?= =?us-ascii?Q?Oqag5+IRbJUO9AclOrvbpbQdjLVAyBvR7YcClFy8o4UwxeEqa8lCxN4tRPUz?= =?us-ascii?Q?KnR0pyQ3CpYrE7tGO5RBGiwecfMRB0lehCjA0HZSCL0ld9cjCrD4g4GeDC9D?= =?us-ascii?Q?9jQ1qslsT5ssJczWPDThzog=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: fc34e776-251d-49d1-a39f-08dde6dbfa9e X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB3519.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2025 09:11:04.2591 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Cbd+58ykhGGgse2QGGJQEquxVj6+nI/ihvvwS1dERdvTOd9EpYwliCkSwmEO4g4NinwqZgxOuAbmsLip/eKOEFbOoiIgcepParKUK1RH7ZJXByHucZuFtTm8pYDs59cc X-MS-Exchange-Transport-CrossTenantHeadersStamped: MA0P287MB0801 Content-Type: text/plain; charset="utf-8" Add a v4l2 subdevice driver for the Omnivision OV2735 sensor. The Omnivision OV2735 is a 1/2.7-Inch CMOS image sensor with an active array size of 1920 x 1080. The following features are supported: - Manual exposure an gain control support - vblank/hblank control support - Test pattern support control - Supported resolution: 1920 x 1080 @ 30fps (SGRBG10) Co-developed-by: Himanshu Bhavani Signed-off-by: Himanshu Bhavani Signed-off-by: Hardevsinh Palaniya --- MAINTAINERS | 1 + drivers/media/i2c/Kconfig | 10 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/ov2735.c | 1109 ++++++++++++++++++++++++++++++++++++ 4 files changed, 1121 insertions(+) create mode 100644 drivers/media/i2c/ov2735.c diff --git a/MAINTAINERS b/MAINTAINERS index 710f2b2e5fc8..4bebdef83a62 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18477,6 +18477,7 @@ M: Himanshu Bhavani L: linux-media@vger.kernel.org S: Maintained F: Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml +F: drivers/media/i2c/ov2735.c =20 OMNIVISION OV2740 SENSOR DRIVER M: Tianshu Qiu diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index 4b4c199da6ea..9646eab1b177 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -446,6 +446,16 @@ config VIDEO_OV2685 To compile this driver as a module, choose M here: the module will be called ov2685. =20 +config VIDEO_OV2735 + tristate "OmniVision OV2735 sensor support" + select V4L2_CCI_I2C + help + This is a Video4Linux2 sensor driver for the Sony + OV2735 camera. + + To compile this driver as a module, choose M here: the + module will be called ov2735. + config VIDEO_OV2740 tristate "OmniVision OV2740 sensor support" depends on ACPI || COMPILE_TEST diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile index 5873d29433ee..1adb27743fa1 100644 --- a/drivers/media/i2c/Makefile +++ b/drivers/media/i2c/Makefile @@ -93,6 +93,7 @@ obj-$(CONFIG_VIDEO_OV2640) +=3D ov2640.o obj-$(CONFIG_VIDEO_OV2659) +=3D ov2659.o obj-$(CONFIG_VIDEO_OV2680) +=3D ov2680.o obj-$(CONFIG_VIDEO_OV2685) +=3D ov2685.o +obj-$(CONFIG_VIDEO_OV2735) +=3D ov2735.o obj-$(CONFIG_VIDEO_OV2740) +=3D ov2740.o obj-$(CONFIG_VIDEO_OV4689) +=3D ov4689.o obj-$(CONFIG_VIDEO_OV5640) +=3D ov5640.o diff --git a/drivers/media/i2c/ov2735.c b/drivers/media/i2c/ov2735.c new file mode 100644 index 000000000000..da5978b96146 --- /dev/null +++ b/drivers/media/i2c/ov2735.c @@ -0,0 +1,1109 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * V4L2 Support for the OV2735 + * + * Copyright (C) 2025 Silicon Signals Pvt. Ltd. + * + * Based on Rockchip ov2735 Camera Driver + * Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd. + * + * Inspired from ov8858, imx219, imx283 camera drivers. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +#define OV2735_XCLK_FREQ (24 * HZ_PER_MHZ) + +/* Add page number in CCI private bits [31:28] of the register address */ +#define OV2735_PAGE_REG8(p, x) (((p) << CCI_REG_PRIVATE_SHIFT) | CCI_REG8(= x)) +#define OV2735_PAGE_REG16(p, x) (((p) << CCI_REG_PRIVATE_SHIFT) | CCI_REG1= 6(x)) + +#define OV2735_REG_PAGE_SELECT CCI_REG8(0xfd) + +/* Page 0 */ +#define OV2735_REG_CHIPID OV2735_PAGE_REG16(0x00, 0x02) +#define OV2735_CHIPID 0x2735 + +#define OV2735_REG_SOFT_RESET OV2735_PAGE_REG8(0x00, 0x20) + +/* Clock Settings */ +#define OV2735_REG_PLL_CTRL OV2735_PAGE_REG8(0x00, 0x2f) +#define OV2735_PLL_CTRL_ENABLE 0x7f +#define OV2735_REG_PLL_OUTDIV OV2735_PAGE_REG8(0x00, 0x34) +#define OV2735_REG_CLK_MODE OV2735_PAGE_REG8(0x00, 0x30) +#define OV2735_REG_CLOCK_REG1 OV2735_PAGE_REG8(0x00, 0x33) +#define OV2735_REG_CLOCK_REG2 OV2735_PAGE_REG8(0x00, 0x35) + +/* Page 1 */ +#define OV2735_REG_STREAM_CTRL OV2735_PAGE_REG8(0x01, 0xa0) +#define OV2735_STREAM_CTRL_ON 0x01 +#define OV2735_STREAM_CTRL_OFF 0x00 + +#define OV2735_REG_UPDOWN_MIRROR OV2735_PAGE_REG8(0x01, 0x3f) +#define OV2735_REG_BINNING_DAC_CODE_MODE OV2735_PAGE_REG8(0x01, 0x30) +#define OV2735_REG_FRAME_LENGTH OV2735_PAGE_REG16(0x01, 0x0e) +#define OV2735_FRAME_LENGTH_MAX 0x0fff +#define OV2735_REG_FRAME_EXP_SEPERATE_EN OV2735_PAGE_REG8(0x01, 0x0d) +#define OV2735_FRAME_EXP_SEPERATE_EN 0x10 +#define OV2735_REG_FRAME_SYNC OV2735_PAGE_REG8(0x01, 0x01) + +#define OV2735_REG_HBLANK OV2735_PAGE_REG16(0x01, 0x09) + +#define OV2735_REG_HS_MIPI OV2735_PAGE_REG8(0x01, 0xb1) +#define OV2735_REG_MIPI_CTRL1 OV2735_PAGE_REG8(0x01, 0x92) +#define OV2735_REG_MIPI_CTRL2 OV2735_PAGE_REG8(0x01, 0x94) +#define OV2735_REG_MIPI_CTRL3 OV2735_PAGE_REG8(0x01, 0xa1) +#define OV2735_REG_MIPI_CTRL4 OV2735_PAGE_REG8(0x01, 0xb2) +#define OV2735_REG_MIPI_CTRL5 OV2735_PAGE_REG8(0x01, 0xb3) +#define OV2735_REG_MIPI_CTRL6 OV2735_PAGE_REG8(0x01, 0xb4) +#define OV2735_REG_MIPI_CTRL7 OV2735_PAGE_REG8(0x01, 0xb5) +#define OV2735_REG_HIGH_SPEED OV2735_PAGE_REG8(0x01, 0x9d) +#define OV2735_REG_PREPARE OV2735_PAGE_REG8(0x01, 0x95) +#define OV2735_REG_R_HS_ZERO OV2735_PAGE_REG8(0x01, 0x96) +#define OV2735_REG_TRAIL OV2735_PAGE_REG8(0x01, 0x98) +#define OV2735_REG_R_CLK_ZERO OV2735_PAGE_REG8(0x01, 0x9c) +#define OV2735_REG_MIPI_COLOMN_NUMBER OV2735_PAGE_REG16(0x01, 0x8e) +#define OV2735_REG_MIPI_LINE_NUMBER OV2735_PAGE_REG16(0x01, 0x90) + +/* Timing control registers */ +#define OV2735_REG_TIMING_CTRL2 OV2735_PAGE_REG8(0x01, 0x1a) +#define OV2735_REG_TIMING_CTRL3 OV2735_PAGE_REG8(0x01, 0x1c) +#define OV2735_REG_TIMING_CTRL1 OV2735_PAGE_REG8(0x01, 0x16) +#define OV2735_REG_RST_NUM OV2735_PAGE_REG16(0x01, 0x10) +#define OV2735_REG_RST_NUM2 OV2735_PAGE_REG16(0x01, 0x32) +#define OV2735_REG_BOOST_EN OV2735_PAGE_REG8(0x01, 0xd0) +#define OV2735_REG_B2_NUM OV2735_PAGE_REG16(0x01, 0xd1) +#define OV2735_REG_B4_NUM OV2735_PAGE_REG16(0x01, 0xd3) +#define OV2735_REG_PIXEL_CYCLE_P0 OV2735_PAGE_REG8(0x01, 0x50) +#define OV2735_REG_PIXEL_CYCLE_P1 OV2735_PAGE_REG8(0x01, 0x51) +#define OV2735_REG_PIXEL_CYCLE_P2 OV2735_PAGE_REG8(0x01, 0x52) +#define OV2735_REG_PIXEL_CYCLE_P3 OV2735_PAGE_REG8(0x01, 0x53) +#define OV2735_REG_PIXEL_CYCLE_P5 OV2735_PAGE_REG8(0x01, 0x55) +#define OV2735_REG_PIXEL_CYCLE_P7 OV2735_PAGE_REG16(0x01, 0x57) +#define OV2735_REG_PIXEL_CYCLE_P9 OV2735_PAGE_REG8(0x01, 0x5a) +#define OV2735_REG_PIXEL_CYCLE_P10 OV2735_PAGE_REG8(0x01, 0x5b) +#define OV2735_REG_PIXEL_CYCLE_P12 OV2735_PAGE_REG8(0x01, 0x5d) +#define OV2735_REG_PIXEL_CYCLE_P18 OV2735_PAGE_REG8(0x01, 0x64) +#define OV2735_REG_PIXEL_CYCLE_P20 OV2735_PAGE_REG8(0x01, 0x66) +#define OV2735_REG_PIXEL_CYCLE_P22 OV2735_PAGE_REG8(0x01, 0x68) +#define OV2735_REG_PIXEL_CYCLE_P33 OV2735_PAGE_REG16(0x01, 0x74) +#define OV2735_REG_PIXEL_CYCLE_P34 OV2735_PAGE_REG8(0x01, 0x76) +#define OV2735_REG_PIXEL_CYCLE_P35_P36 OV2735_PAGE_REG8(0x01, 0x77) +#define OV2735_REG_PIXEL_CYCLE_P37_P38 OV2735_PAGE_REG8(0x01, 0x78) +#define OV2735_REG_PIXEL_CYCLE_P31 OV2735_PAGE_REG8(0x01, 0x72) +#define OV2735_REG_PIXEL_CYCLE_P32 OV2735_PAGE_REG8(0x01, 0x73) +#define OV2735_REG_PIXEL_CYCLE_P44 OV2735_PAGE_REG8(0x01, 0x7d) +#define OV2735_REG_PIXEL_CYCLE_P45 OV2735_PAGE_REG8(0x01, 0x7e) +#define OV2735_REG_PIXEL_BIAS_CTRL_RH_RL OV2735_PAGE_REG8(0x01, 0x8a) +#define OV2735_REG_PIXEL_BIAS_CTRL_SH_SL OV2735_PAGE_REG8(0x01, 0x8b) + +/* Analog Control registers */ +#define OV2735_REG_ICOMP OV2735_PAGE_REG8(0x01, 0x19) +#define OV2735_REG_PCP_RST_SEL OV2735_PAGE_REG8(0x01, 0x21) +#define OV2735_REG_VNCP OV2735_PAGE_REG8(0x01, 0x20) +#define OV2735_REG_ANALOG_CTRL3 OV2735_PAGE_REG8(0x01, 0x25) +#define OV2735_REG_ANALOG_CTRL4 OV2735_PAGE_REG8(0x01, 0x26) +#define OV2735_REG_ANALOG_CTRL5 OV2735_PAGE_REG8(0x01, 0x29) +#define OV2735_REG_ANALOG_CTRL6 OV2735_PAGE_REG8(0x01, 0x2a) +#define OV2735_REG_ANALOG_CTRL8 OV2735_PAGE_REG8(0x01, 0x2c) + +/* BLC registers */ +#define OV2735_REG_BLC_GAIN_BLUE OV2735_PAGE_REG8(0x01, 0x86) +#define OV2735_REG_BLC_GAIN_RED OV2735_PAGE_REG8(0x01, 0x87) +#define OV2735_REG_BLC_GAIN_GR OV2735_PAGE_REG8(0x01, 0x88) +#define OV2735_REG_BLC_GAIN_GB OV2735_PAGE_REG8(0x01, 0x89) +#define OV2735_REG_GB_SUBOFFSET OV2735_PAGE_REG8(0x01, 0xf0) +#define OV2735_REG_BLUE_SUBOFFSET OV2735_PAGE_REG8(0x01, 0xf1) +#define OV2735_REG_RED_SUBOFFSET OV2735_PAGE_REG8(0x01, 0xf2) +#define OV2735_REG_GR_SUBOFFSET OV2735_PAGE_REG8(0x01, 0xf3) +#define OV2735_REG_BLC_BPC_TH_P OV2735_PAGE_REG8(0x01, 0xfc) +#define OV2735_REG_BLC_BPC_TH_N OV2735_PAGE_REG8(0x01, 0xfe) +#define OV2735_REG_ABL OV2735_PAGE_REG8(0x01, 0xfb) + +#define OV2735_REG_TEST_PATTERN OV2735_PAGE_REG8(0x01, 0xb2) +#define OV2735_TEST_PATTERN_ENABLE 0x01 +#define OV2735_TEST_PATTERN_DISABLE 0xfe + +#define OV2735_REG_LONG_EXPOSURE OV2735_PAGE_REG16(0x01, 0x03) +#define OV2735_EXPOSURE_MIN 4 +#define OV2735_EXPOSURE_STEP 1 +#define OV2735_EXPOSURE_MARGIN 4 + +#define OV2735_REG_ANALOG_GAIN OV2735_PAGE_REG8(0x01, 0x24) +#define OV2735_ANALOG_GAIN_MIN 0x10 +#define OV2735_ANALOG_GAIN_MAX 0xff +#define OV2735_ANALOG_GAIN_STEP 1 +#define OV2735_ANALOG_GAIN_DEFAULT 0x10 + +/* Page 2 */ +#define OV2735_REG_V_START OV2735_PAGE_REG16(0x02, 0xa0) +#define OV2735_REG_V_SIZE OV2735_PAGE_REG16(0x02, 0xa2) +#define OV2735_REG_H_START OV2735_PAGE_REG16(0x02, 0xa4) +#define OV2735_REG_H_SIZE OV2735_PAGE_REG16(0x02, 0xa6) + +#define OV2735_LINK_FREQ_420MHZ (420 * HZ_PER_MHZ) +#define OV2735_PIXEL_RATE (168 * HZ_PER_MHZ) + +/* OV2735 native and active pixel array size */ +static const struct v4l2_rect ov2735_native_area =3D { + .top =3D 0, + .left =3D 0, + .width =3D 1936, + .height =3D 1096, +}; + +static const struct v4l2_rect ov2735_active_area =3D { + .top =3D 8, + .left =3D 8, + .width =3D 1920, + .height =3D 1080, +}; + +static const char * const ov2735_supply_name[] =3D { + "avdd", /* Analog power */ + "dovdd", /* Digital I/O power */ + "dvdd", /* Digital core power */ +}; + +/* PLL_OUT =3D [PLL_IN * (pll_nc +3)] / [(pll_mc + 1) * (pll_outdiv + 1)] = */ +struct ov2735_pll_parameters { + u8 pll_nc; + u8 pll_mc; + u8 pll_outdiv; +}; + +struct ov2735 { + struct device *dev; + struct regmap *cci; + struct v4l2_subdev sd; + struct media_pad pad; + struct clk *xclk; + struct gpio_desc *reset_gpio; + struct gpio_desc *enable_gpio; + struct regulator_bulk_data supplies[ARRAY_SIZE(ov2735_supply_name)]; + + /* V4L2 Controls */ + struct v4l2_ctrl_handler handler; + struct v4l2_ctrl *link_freq; + struct v4l2_ctrl *pixel_rate; + struct v4l2_ctrl *hblank; + struct v4l2_ctrl *vblank; + struct v4l2_ctrl *gain; + struct v4l2_ctrl *exposure; + struct v4l2_ctrl *test_pattern; + + u32 link_freq_index; + + u8 current_page; + struct mutex page_lock; +}; + +struct ov2735_mode { + u32 width; + u32 height; + u32 hts_def; + u32 vts_def; + u32 exp_def; + struct v4l2_rect crop; +}; + +static const struct cci_reg_sequence ov2735_common_regs[] =3D { + { OV2735_REG_CLK_MODE, 0x15 }, + { OV2735_REG_CLOCK_REG1, 0x01 }, + { OV2735_REG_CLOCK_REG2, 0x20 }, + { OV2735_REG_BINNING_DAC_CODE_MODE, 0x00 }, + { OV2735_REG_ABL, 0x73 }, + { OV2735_REG_FRAME_SYNC, 0x01 }, + + /* Timing ctrl */ + { OV2735_REG_TIMING_CTRL2, 0x6b }, + { OV2735_REG_TIMING_CTRL3, 0xea }, + { OV2735_REG_TIMING_CTRL1, 0x0c }, + { OV2735_REG_RST_NUM, 0x0063 }, + { OV2735_REG_RST_NUM2, 0x006f }, + { OV2735_REG_BOOST_EN, 0x02 }, + { OV2735_REG_B2_NUM, 0x0120 }, + { OV2735_REG_B4_NUM, 0x042a }, + { OV2735_REG_PIXEL_CYCLE_P0, 0x00 }, + { OV2735_REG_PIXEL_CYCLE_P1, 0x2c }, + { OV2735_REG_PIXEL_CYCLE_P2, 0x29 }, + { OV2735_REG_PIXEL_CYCLE_P3, 0x00 }, + { OV2735_REG_PIXEL_CYCLE_P5, 0x44 }, + { OV2735_REG_PIXEL_CYCLE_P7, 0x0029 }, + { OV2735_REG_PIXEL_CYCLE_P9, 0x00 }, + { OV2735_REG_PIXEL_CYCLE_P10, 0x00 }, + { OV2735_REG_PIXEL_CYCLE_P12, 0x00 }, + { OV2735_REG_PIXEL_CYCLE_P18, 0x2f }, + { OV2735_REG_PIXEL_CYCLE_P20, 0x62 }, + { OV2735_REG_PIXEL_CYCLE_P22, 0x5b }, + { OV2735_REG_PIXEL_CYCLE_P33, 0x0046 }, + { OV2735_REG_PIXEL_CYCLE_P34, 0x36 }, + { OV2735_REG_PIXEL_CYCLE_P35_P36, 0x4f }, + { OV2735_REG_PIXEL_CYCLE_P37_P38, 0xef }, + { OV2735_REG_PIXEL_CYCLE_P31, 0xcf }, + { OV2735_REG_PIXEL_CYCLE_P32, 0x36 }, + { OV2735_REG_PIXEL_CYCLE_P44, 0x0d }, + { OV2735_REG_PIXEL_CYCLE_P45, 0x0d }, + { OV2735_REG_PIXEL_BIAS_CTRL_RH_RL, 0x77 }, + { OV2735_REG_PIXEL_BIAS_CTRL_SH_SL, 0x77 }, + + /* Analog ctrl */ + { OV2735_REG_ANALOG_CTRL4, 0x5a }, + { OV2735_REG_ANALOG_CTRL5, 0x01 }, + { OV2735_REG_ANALOG_CTRL6, 0xd2 }, + { OV2735_REG_ANALOG_CTRL8, 0x40 }, + { OV2735_REG_PCP_RST_SEL, 0x00 }, + { OV2735_REG_ICOMP, 0xc3 }, + + { OV2735_REG_HS_MIPI, 0x83 }, + { OV2735_REG_MIPI_CTRL5, 0x0b }, + { OV2735_REG_MIPI_CTRL6, 0x14 }, + { OV2735_REG_HIGH_SPEED, 0x40 }, + { OV2735_REG_MIPI_CTRL3, 0x05 }, + { OV2735_REG_MIPI_CTRL2, 0x44 }, + { OV2735_REG_PREPARE, 0x33 }, + { OV2735_REG_R_HS_ZERO, 0x1f }, + { OV2735_REG_TRAIL, 0x45 }, + { OV2735_REG_R_CLK_ZERO, 0x10 }, + { OV2735_REG_MIPI_CTRL7, 0x70 }, + { OV2735_REG_ANALOG_CTRL3, 0xe0 }, + { OV2735_REG_VNCP, 0x7b }, + + /* BLC */ + { OV2735_REG_BLC_GAIN_BLUE, 0x77 }, + { OV2735_REG_BLC_GAIN_GB, 0x77 }, + { OV2735_REG_BLC_GAIN_RED, 0x74 }, + { OV2735_REG_BLC_GAIN_GR, 0x74 }, + { OV2735_REG_BLC_BPC_TH_P, 0xe0 }, + { OV2735_REG_BLC_BPC_TH_N, 0xe0 }, + { OV2735_REG_GB_SUBOFFSET, 0x40 }, + { OV2735_REG_BLUE_SUBOFFSET, 0x40 }, + { OV2735_REG_RED_SUBOFFSET, 0x40 }, + { OV2735_REG_GR_SUBOFFSET, 0x40 }, +}; + +static const struct ov2735_mode supported_modes[] =3D { + { + .width =3D 1920, + .height =3D 1080, + .exp_def =3D 399, + .hts_def =3D 2200, + .vts_def =3D 2545, + .crop =3D { + .top =3D 8, + .left =3D 8, + .width =3D 1920, + .height =3D 1080, + }, + }, +}; + +static const s64 link_freq_menu_items[] =3D { + OV2735_LINK_FREQ_420MHZ, +}; + +static const struct ov2735_pll_parameters pll_configs[] =3D { + /* For 420MHz pll_configs */ + { + .pll_nc =3D 4, + .pll_mc =3D 0, + .pll_outdiv =3D 1, + }, +}; + +static const char * const ov2735_test_pattern_menu[] =3D { + "Disabled", + "Vertical Color", +}; + +static int ov2735_page_access(struct ov2735 *ov2735, u32 reg, int *err) +{ + u8 page =3D reg >> CCI_REG_PRIVATE_SHIFT; + int ret =3D 0; + + if (err && *err) + return *err; + + guard(mutex)(&ov2735->page_lock); + + /* Perform page access before read/write */ + if (ov2735->current_page =3D=3D page) + return ret; + + ret =3D cci_write(ov2735->cci, OV2735_REG_PAGE_SELECT, page, err); + if (!ret) + ov2735->current_page =3D page; + + return ret; +} + +static int ov2735_read(struct ov2735 *ov2735, u32 reg, u64 *val, int *err) +{ + u32 addr =3D reg & ~CCI_REG_PRIVATE_MASK; + int ret; + + ret =3D ov2735_page_access(ov2735, reg, err); + if (ret) + return ret; + + return cci_read(ov2735->cci, addr, val, err); +} + +static int ov2735_write(struct ov2735 *ov2735, u32 reg, u64 val, int *err) +{ + u32 addr =3D reg & ~CCI_REG_PRIVATE_MASK; + int ret; + + ret =3D ov2735_page_access(ov2735, reg, err); + if (ret) + return ret; + + return cci_write(ov2735->cci, addr, val, err); +} + +static int ov2735_multi_reg_write(struct ov2735 *ov2735, + const struct cci_reg_sequence *regs, + unsigned int num_regs, int *err) +{ + unsigned int i; + int ret; + + for (i =3D 0; i < num_regs; i++) { + ret =3D ov2735_write(ov2735, regs[i].reg, regs[i].val, err); + if (ret) + return ret; + } + + return 0; +} + +static inline struct ov2735 *to_ov2735(struct v4l2_subdev *_sd) +{ + return container_of(_sd, struct ov2735, sd); +} + +static int ov2735_enable_test_pattern(struct ov2735 *ov2735, u32 pattern) +{ + int ret; + u64 val; + + ret =3D ov2735_read(ov2735, OV2735_REG_TEST_PATTERN, &val, NULL); + if (ret) + return ret; + + switch (pattern) { + case 0: + val &=3D ~OV2735_TEST_PATTERN_ENABLE; + break; + case 1: + val |=3D OV2735_TEST_PATTERN_ENABLE; + break; + } + + return ov2735_write(ov2735, OV2735_REG_TEST_PATTERN, val, NULL); +} + +static int ov2735_set_ctrl(struct v4l2_ctrl *ctrl) +{ + struct ov2735 *ov2735 =3D container_of(ctrl->handler, struct ov2735, + handler); + struct v4l2_mbus_framefmt *fmt; + struct v4l2_subdev_state *state; + u64 vts; + int ret =3D 0; + + state =3D v4l2_subdev_get_locked_active_state(&ov2735->sd); + fmt =3D v4l2_subdev_state_get_format(state, 0); + + if (ctrl->id =3D=3D V4L2_CID_VBLANK) { + /* Honour the VBLANK limits when setting exposure */ + s64 max =3D fmt->height + ctrl->val - OV2735_EXPOSURE_MARGIN; + + ret =3D __v4l2_ctrl_modify_range(ov2735->exposure, + ov2735->exposure->minimum, max, + ov2735->exposure->step, + ov2735->exposure->default_value); + if (ret) + return ret; + } + + if (pm_runtime_get_if_in_use(ov2735->dev) =3D=3D 0) + return 0; + + switch (ctrl->id) { + case V4L2_CID_EXPOSURE: + ov2735_write(ov2735, OV2735_REG_LONG_EXPOSURE, ctrl->val, &ret); + break; + case V4L2_CID_ANALOGUE_GAIN: + ov2735_write(ov2735, OV2735_REG_ANALOG_GAIN, ctrl->val, &ret); + break; + case V4L2_CID_HBLANK: + ov2735_write(ov2735, OV2735_REG_HBLANK, ctrl->val, &ret); + break; + case V4L2_CID_VBLANK: + vts =3D ctrl->val + fmt->height; + ov2735_write(ov2735, OV2735_REG_FRAME_EXP_SEPERATE_EN, + OV2735_FRAME_EXP_SEPERATE_EN, &ret); + ov2735_write(ov2735, OV2735_REG_FRAME_LENGTH, vts, &ret); + break; + case V4L2_CID_TEST_PATTERN: + ret =3D ov2735_enable_test_pattern(ov2735, ctrl->val); + break; + default: + ret =3D -EINVAL; + break; + } + ov2735_write(ov2735, OV2735_REG_FRAME_SYNC, 0x01, &ret); + + pm_runtime_put(ov2735->dev); + + return ret; +} + +static const struct v4l2_ctrl_ops ov2735_ctrl_ops =3D { + .s_ctrl =3D ov2735_set_ctrl, +}; + +static int ov2735_init_controls(struct ov2735 *ov2735) +{ + struct v4l2_ctrl_handler *ctrl_hdlr; + struct v4l2_fwnode_device_properties props; + const struct ov2735_mode *mode =3D &supported_modes[0]; + u64 hblank_def, vblank_def, exp_max; + int ret; + + ctrl_hdlr =3D &ov2735->handler; + v4l2_ctrl_handler_init(ctrl_hdlr, 9); + + ov2735->pixel_rate =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_PIXEL_RATE, 0, + OV2735_PIXEL_RATE, 1, + OV2735_PIXEL_RATE); + + ov2735->link_freq =3D v4l2_ctrl_new_int_menu(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_LINK_FREQ, + ov2735->link_freq_index, + 0, link_freq_menu_items); + if (ov2735->link_freq) + ov2735->link_freq->flags |=3D V4L2_CTRL_FLAG_READ_ONLY; + + hblank_def =3D mode->hts_def - mode->width; + ov2735->hblank =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_HBLANK, hblank_def, + hblank_def, 1, hblank_def); + + vblank_def =3D mode->vts_def - mode->height; + ov2735->vblank =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_VBLANK, vblank_def, + OV2735_FRAME_LENGTH_MAX - mode->height, + 1, vblank_def); + + exp_max =3D mode->vts_def - OV2735_EXPOSURE_MARGIN; + ov2735->exposure =3D + v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_EXPOSURE, + OV2735_EXPOSURE_MIN, exp_max, + OV2735_EXPOSURE_STEP, mode->exp_def); + + ov2735->gain =3D + v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_ANALOGUE_GAIN, OV2735_ANALOG_GAIN_MIN, + OV2735_ANALOG_GAIN_MAX, OV2735_ANALOG_GAIN_STEP, + OV2735_ANALOG_GAIN_DEFAULT); + + ov2735->test_pattern =3D + v4l2_ctrl_new_std_menu_items(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_TEST_PATTERN, + ARRAY_SIZE(ov2735_test_pattern_menu) - 1, + 0, 0, ov2735_test_pattern_menu); + + if (ctrl_hdlr->error) { + ret =3D ctrl_hdlr->error; + dev_err(ov2735->dev, "control init failed (%d)\n", ret); + goto err_handler_free; + } + + ret =3D v4l2_fwnode_device_parse(ov2735->dev, &props); + if (ret) + goto err_handler_free; + + ret =3D v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, + &ov2735_ctrl_ops, &props); + if (ret) + goto err_handler_free; + + ov2735->sd.ctrl_handler =3D ctrl_hdlr; + + return 0; + +err_handler_free: + v4l2_ctrl_handler_free(ctrl_hdlr); + + return ret; +} + +static int ov2735_set_pll_ctrl(struct ov2735 *ov2735) +{ + const struct ov2735_pll_parameters *pll_parameters; + u8 pll_ctrl; + u8 pll_outdiv; + int ret =3D 0; + + pll_parameters =3D &pll_configs[ov2735->link_freq_index]; + + /* BIT[7]: pll_clk_sel, BIT[6:2]: pll_nc, BIT[1:0]: pll_mc */ + pll_ctrl =3D ((pll_parameters->pll_nc << 2) | (pll_parameters->pll_mc << = 0)) & + OV2735_PLL_CTRL_ENABLE; + + pll_outdiv =3D pll_parameters->pll_outdiv; + + ov2735_write(ov2735, OV2735_REG_PLL_CTRL, pll_ctrl, &ret); + ov2735_write(ov2735, OV2735_REG_PLL_OUTDIV, pll_outdiv, &ret); + + return ret; +} + +static int ov2735_set_framefmt(struct ov2735 *ov2735, + struct v4l2_subdev_state *state) +{ + const struct v4l2_mbus_framefmt *format; + const struct v4l2_rect *crop; + int ret =3D 0; + + format =3D v4l2_subdev_state_get_format(state, 0); + crop =3D v4l2_subdev_state_get_crop(state, 0); + + ov2735_write(ov2735, OV2735_REG_V_START, crop->top, &ret); + ov2735_write(ov2735, OV2735_REG_V_SIZE, format->height, &ret); + ov2735_write(ov2735, OV2735_REG_MIPI_LINE_NUMBER, format->height, &ret); + ov2735_write(ov2735, OV2735_REG_H_START, crop->left, &ret); + /* OV2735_REG_H_SIZE: Image half horizontal size */ + ov2735_write(ov2735, OV2735_REG_H_SIZE, (format->width / 2), &ret); + ov2735_write(ov2735, OV2735_REG_MIPI_COLOMN_NUMBER, format->width, &ret); + + return ret; +} + +static int ov2735_enable_streams(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state, u32 pad, + u64 streams_mask) +{ + struct ov2735 *ov2735 =3D to_ov2735(sd); + int ret; + + ret =3D pm_runtime_resume_and_get(ov2735->dev); + if (ret < 0) + return ret; + + /* Apply pll settings */ + ret =3D ov2735_set_pll_ctrl(ov2735); + if (ret) { + dev_err(ov2735->dev, "failed to set frame format: %d\n", ret); + goto err_rpm_put; + } + + ret =3D ov2735_multi_reg_write(ov2735, ov2735_common_regs, + ARRAY_SIZE(ov2735_common_regs), NULL); + if (ret) { + dev_err(ov2735->dev, "failed to write common registers\n"); + goto err_rpm_put; + } + + /* Apply format settings */ + ret =3D ov2735_set_framefmt(ov2735, state); + if (ret) { + dev_err(ov2735->dev, "failed to set frame format: %d\n", ret); + goto err_rpm_put; + } + + /* Apply customized values from user */ + ret =3D __v4l2_ctrl_handler_setup(ov2735->sd.ctrl_handler); + if (ret) + goto err_rpm_put; + + ret =3D ov2735_write(ov2735, OV2735_REG_STREAM_CTRL, + OV2735_STREAM_CTRL_ON, NULL); + if (ret) + goto err_rpm_put; + + return 0; + +err_rpm_put: + pm_runtime_put(ov2735->dev); + return ret; +} + +static int ov2735_disable_streams(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state, u32 pad, + u64 streams_mask) +{ + struct ov2735 *ov2735 =3D to_ov2735(sd); + int ret; + + ret =3D ov2735_write(ov2735, OV2735_REG_STREAM_CTRL, + OV2735_STREAM_CTRL_OFF, NULL); + if (ret) + dev_err(ov2735->dev, "%s failed to set stream\n", __func__); + + pm_runtime_put(ov2735->dev); + + return ret; +} + +static int ov2735_get_selection(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_selection *sel) +{ + switch (sel->target) { + case V4L2_SEL_TGT_CROP: + sel->r =3D *v4l2_subdev_state_get_crop(sd_state, 0); + return 0; + case V4L2_SEL_TGT_NATIVE_SIZE: + sel->r =3D ov2735_native_area; + return 0; + case V4L2_SEL_TGT_CROP_DEFAULT: + case V4L2_SEL_TGT_CROP_BOUNDS: + sel->r =3D ov2735_active_area; + return 0; + default: + return -EINVAL; + } +} + +static int ov2735_enum_mbus_code(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_mbus_code_enum *code) +{ + if (code->index >=3D 0) + return -EINVAL; + + code->code =3D MEDIA_BUS_FMT_SGRBG10_1X10; + + return 0; +} + +static int ov2735_enum_frame_size(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_frame_size_enum *fse) +{ + if (fse->index >=3D ARRAY_SIZE(supported_modes)) + return -EINVAL; + + if (fse->code !=3D MEDIA_BUS_FMT_SGRBG10_1X10) + return -EINVAL; + + fse->min_width =3D supported_modes[fse->index].width; + fse->max_width =3D fse->min_width; + fse->min_height =3D supported_modes[fse->index].height; + fse->max_height =3D fse->min_height; + + return 0; +} + +static int ov2735_set_framing_limits(struct ov2735 *ov2735, + const struct ov2735_mode *mode) +{ + u32 hblank, vblank_def; + int ret; + + hblank =3D mode->hts_def - mode->width; + ret =3D __v4l2_ctrl_modify_range(ov2735->hblank, hblank, hblank, 1, + hblank); + if (ret) + return ret; + + vblank_def =3D mode->vts_def - mode->height; + return __v4l2_ctrl_modify_range(ov2735->vblank, vblank_def, + OV2735_FRAME_LENGTH_MAX - mode->height, + 1, vblank_def); +} + +static int ov2735_set_pad_format(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_format *fmt) +{ + struct v4l2_mbus_framefmt *format; + const struct ov2735_mode *mode; + struct v4l2_rect *crop; + struct ov2735 *ov2735 =3D to_ov2735(sd); + int ret; + + format =3D v4l2_subdev_state_get_format(sd_state, 0); + + mode =3D v4l2_find_nearest_size(supported_modes, + ARRAY_SIZE(supported_modes), + width, height, + fmt->format.width, fmt->format.height); + + fmt->format.width =3D mode->width; + fmt->format.height =3D mode->height; + fmt->format.field =3D V4L2_FIELD_NONE; + fmt->format.colorspace =3D V4L2_COLORSPACE_RAW; + fmt->format.quantization =3D V4L2_QUANTIZATION_FULL_RANGE; + fmt->format.xfer_func =3D V4L2_XFER_FUNC_NONE; + + if (fmt->which =3D=3D V4L2_SUBDEV_FORMAT_ACTIVE) { + ret =3D ov2735_set_framing_limits(ov2735, mode); + if (ret) + return ret; + } + + *format =3D fmt->format; + + /* Initialize crop rectangle */ + crop =3D v4l2_subdev_state_get_crop(sd_state, 0); + *crop =3D mode->crop; + + return 0; +} + +static int ov2735_init_state(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state) +{ + struct v4l2_subdev_format fmt =3D { + .which =3D V4L2_SUBDEV_FORMAT_TRY, + .format =3D { + .code =3D MEDIA_BUS_FMT_SGRBG10_1X10, + .width =3D supported_modes[0].width, + .height =3D supported_modes[0].height, + }, + }; + + ov2735_set_pad_format(sd, state, &fmt); + + return 0; +} + +static const struct v4l2_subdev_video_ops ov2735_video_ops =3D { + .s_stream =3D v4l2_subdev_s_stream_helper, +}; + +static const struct v4l2_subdev_pad_ops ov2735_pad_ops =3D { + .enum_mbus_code =3D ov2735_enum_mbus_code, + .get_fmt =3D v4l2_subdev_get_fmt, + .set_fmt =3D ov2735_set_pad_format, + .get_selection =3D ov2735_get_selection, + .enum_frame_size =3D ov2735_enum_frame_size, + .enable_streams =3D ov2735_enable_streams, + .disable_streams =3D ov2735_disable_streams, +}; + +static const struct v4l2_subdev_ops ov2735_subdev_ops =3D { + .video =3D &ov2735_video_ops, + .pad =3D &ov2735_pad_ops, +}; + +static const struct v4l2_subdev_internal_ops ov2735_internal_ops =3D { + .init_state =3D ov2735_init_state, +}; + +static int ov2735_power_on(struct device *dev) +{ + struct v4l2_subdev *sd =3D dev_get_drvdata(dev); + struct ov2735 *ov2735 =3D to_ov2735(sd); + int ret; + + ret =3D regulator_bulk_enable(ARRAY_SIZE(ov2735_supply_name), + ov2735->supplies); + if (ret) { + dev_err(ov2735->dev, "failed to enable regulators\n"); + return ret; + } + + gpiod_set_value_cansleep(ov2735->enable_gpio, 1); + /* T4: delay from PWDN pulling low to RSTB pulling high */ + fsleep(4 * USEC_PER_MSEC); + + ret =3D clk_prepare_enable(ov2735->xclk); + if (ret) { + dev_err(ov2735->dev, "failed to enable clock\n"); + goto err_regulator_off; + } + + gpiod_set_value_cansleep(ov2735->reset_gpio, 0); + /* T5: delay from RSTB pulling high to first I2C command */ + fsleep(5 * USEC_PER_MSEC); + + return 0; + +err_regulator_off: + regulator_bulk_disable(ARRAY_SIZE(ov2735_supply_name), ov2735->supplies); + return ret; +} + +static int ov2735_power_off(struct device *dev) +{ + struct v4l2_subdev *sd =3D dev_get_drvdata(dev); + struct ov2735 *ov2735 =3D to_ov2735(sd); + + gpiod_set_value_cansleep(ov2735->enable_gpio, 0); + clk_disable_unprepare(ov2735->xclk); + gpiod_set_value_cansleep(ov2735->reset_gpio, 1); + regulator_bulk_disable(ARRAY_SIZE(ov2735_supply_name), ov2735->supplies); + + return 0; +} + +static int ov2735_get_regulators(struct ov2735 *ov2735) +{ + unsigned int i; + + for (i =3D 0; i < ARRAY_SIZE(ov2735_supply_name); i++) + ov2735->supplies[i].supply =3D ov2735_supply_name[i]; + + return devm_regulator_bulk_get(ov2735->dev, + ARRAY_SIZE(ov2735_supply_name), + ov2735->supplies); +} + +static int ov2735_identify_module(struct ov2735 *ov2735) +{ + u64 chip_id; + int ret; + + ret =3D ov2735_read(ov2735, OV2735_REG_CHIPID, &chip_id, NULL); + if (ret) + return dev_err_probe(ov2735->dev, ret, + "failed to read chip id %x\n", + OV2735_CHIPID); + + if (chip_id !=3D OV2735_CHIPID) + return dev_err_probe(ov2735->dev, -EIO, + "chip id mismatch: %x!=3D%llx\n", + OV2735_CHIPID, chip_id); + + return 0; +} + +static int ov2735_parse_endpoint(struct ov2735 *ov2735) +{ + struct v4l2_fwnode_endpoint bus_cfg =3D { + .bus_type =3D V4L2_MBUS_CSI2_DPHY, + }; + struct fwnode_handle *ep; + unsigned long link_freq_bitmap; + int ret; + + ep =3D fwnode_graph_get_next_endpoint(dev_fwnode(ov2735->dev), NULL); + if (!ep) + return dev_err_probe(ov2735->dev, -ENXIO, + "Failed to get next endpoint\n"); + + ret =3D v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg); + fwnode_handle_put(ep); + if (ret) + return ret; + + if (bus_cfg.bus.mipi_csi2.num_data_lanes !=3D 2) { + ret =3D dev_err_probe(ov2735->dev, -EINVAL, + "only 2 data lanes are supported\n"); + goto error_out; + } + + ret =3D v4l2_link_freq_to_bitmap(ov2735->dev, bus_cfg.link_frequencies, + bus_cfg.nr_of_link_frequencies, + link_freq_menu_items, + ARRAY_SIZE(link_freq_menu_items), + &link_freq_bitmap); + if (ret) { + ret =3D dev_err_probe(ov2735->dev, -EINVAL, + "only 420MHz frequency is available\n"); + goto error_out; + } + + ov2735->link_freq_index =3D __ffs(link_freq_bitmap); + +error_out: + v4l2_fwnode_endpoint_free(&bus_cfg); + + return ret; +}; + +static int ov2735_probe(struct i2c_client *client) +{ + struct ov2735 *ov2735; + unsigned int xclk_freq; + int ret; + + ov2735 =3D devm_kzalloc(&client->dev, sizeof(*ov2735), GFP_KERNEL); + if (!ov2735) + return -ENOMEM; + + ov2735->dev =3D &client->dev; + + v4l2_i2c_subdev_init(&ov2735->sd, client, &ov2735_subdev_ops); + ov2735->sd.internal_ops =3D &ov2735_internal_ops; + + ov2735->cci =3D devm_cci_regmap_init_i2c(client, 8); + if (IS_ERR(ov2735->cci)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->cci), + "failed to initialize CCI\n"); + + /* Set Current page to 0 */ + ov2735->current_page =3D 0; + + ret =3D devm_mutex_init(ov2735->dev, &ov2735->page_lock); + if (ret) + return dev_err_probe(ov2735->dev, ret, + "Failed to initialize lock\n"); + + /* Get system clock (xvclk) */ + ov2735->xclk =3D devm_v4l2_sensor_clk_get(ov2735->dev, NULL); + if (IS_ERR(ov2735->xclk)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->xclk), + "failed to get xclk\n"); + + xclk_freq =3D clk_get_rate(ov2735->xclk); + if (xclk_freq !=3D OV2735_XCLK_FREQ) + return dev_err_probe(ov2735->dev, -EINVAL, + "xclk frequency not supported: %u Hz\n", + xclk_freq); + + ret =3D ov2735_get_regulators(ov2735); + if (ret) + return dev_err_probe(ov2735->dev, ret, + "failed to get regulators\n"); + + ret =3D ov2735_parse_endpoint(ov2735); + if (ret) + return dev_err_probe(ov2735->dev, ret, + "failed to parse endpoint configuration\n"); + + ov2735->reset_gpio =3D devm_gpiod_get_optional(ov2735->dev, + "reset", GPIOD_OUT_LOW); + if (IS_ERR(ov2735->reset_gpio)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->reset_gpio), + "failed to get reset GPIO\n"); + + ov2735->enable_gpio =3D devm_gpiod_get_optional(ov2735->dev, + "enable", GPIOD_OUT_LOW); + if (IS_ERR(ov2735->enable_gpio)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->enable_gpio), + "failed to get enable GPIO\n"); + + ret =3D ov2735_power_on(ov2735->dev); + if (ret) + return ret; + + ret =3D ov2735_identify_module(ov2735); + if (ret) + goto error_power_off; + + ret =3D ov2735_init_controls(ov2735); + if (ret) + goto error_power_off; + + /* Initialize subdev */ + ov2735->sd.flags |=3D V4L2_SUBDEV_FL_HAS_DEVNODE; + ov2735->sd.entity.function =3D MEDIA_ENT_F_CAM_SENSOR; + ov2735->pad.flags =3D MEDIA_PAD_FL_SOURCE; + + ret =3D media_entity_pads_init(&ov2735->sd.entity, 1, &ov2735->pad); + if (ret) { + dev_err_probe(ov2735->dev, ret, "failed to init entity pads\n"); + goto error_handler_free; + } + + ov2735->sd.state_lock =3D ov2735->handler.lock; + ret =3D v4l2_subdev_init_finalize(&ov2735->sd); + if (ret) { + dev_err_probe(ov2735->dev, ret, "subdev init error\n"); + goto error_media_entity; + } + + ret =3D devm_pm_runtime_get_noresume(ov2735->dev); + if (ret) { + dev_err_probe(ov2735->dev, ret, + "failed to get runtime PM noresume\n"); + goto error_subdev_cleanup; + } + + ret =3D devm_pm_runtime_set_active_enabled(ov2735->dev); + if (ret) { + dev_err_probe(ov2735->dev, ret, + "failed to set runtime PM active+enabled\n"); + goto error_subdev_cleanup; + } + + ret =3D v4l2_async_register_subdev_sensor(&ov2735->sd); + if (ret) { + dev_err_probe(ov2735->dev, ret, + "failed to register ov2735 sub-device\n"); + goto error_subdev_cleanup; + } + + return 0; + +error_subdev_cleanup: + v4l2_subdev_cleanup(&ov2735->sd); + +error_media_entity: + media_entity_cleanup(&ov2735->sd.entity); + +error_handler_free: + v4l2_ctrl_handler_free(ov2735->sd.ctrl_handler); + +error_power_off: + ov2735_power_off(ov2735->dev); + + return ret; +} + +static void ov2735_remove(struct i2c_client *client) +{ + struct v4l2_subdev *sd =3D i2c_get_clientdata(client); + struct ov2735 *ov2735 =3D to_ov2735(sd); + + v4l2_async_unregister_subdev(sd); + v4l2_subdev_cleanup(&ov2735->sd); + media_entity_cleanup(&sd->entity); + v4l2_ctrl_handler_free(ov2735->sd.ctrl_handler); +} + +static DEFINE_RUNTIME_DEV_PM_OPS(ov2735_pm_ops, + ov2735_power_off, ov2735_power_on, NULL); + +static const struct of_device_id ov2735_id[] =3D { + { .compatible =3D "ovti,ov2735" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, ov2735_id); + +static struct i2c_driver ov2735_driver =3D { + .driver =3D { + .name =3D "ov2735", + .pm =3D pm_ptr(&ov2735_pm_ops), + .of_match_table =3D ov2735_id, + }, + .probe =3D ov2735_probe, + .remove =3D ov2735_remove, +}; +module_i2c_driver(ov2735_driver); + +MODULE_DESCRIPTION("OV2735 Camera Sensor Driver"); +MODULE_AUTHOR("Hardevsinh Palaniya = "); +MODULE_AUTHOR("Himanshu Bhavani "); +MODULE_LICENSE("GPL"); --=20 2.34.1