From nobody Fri Oct 3 14:34:25 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 354CC2D6626; Fri, 29 Aug 2025 08:49:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756457391; cv=none; b=DglwVnn6+9BDI4LXALaqE4KbOSMlV8duVHwXo2GNJ+drulPQnZlePmF1Lyf4S69ecQjd00jGroOD+bwSYoYe8AN+MINF2kw3eEgRwarlBh9vxaqbltbWE3VyUmGszyZmUYFSqDzSDDsnSpYVx1UbrduH+F5p2ltEAsnE6Ol+q7M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756457391; c=relaxed/simple; bh=CNNW8H+2jwpH7GuBz/IxBha2q6AgpHxi1qIELosPvSU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eBbkVQ5D1gqfMuto8xMpqaI0y/Tum4HE4t+5sUtl/5cS6Lta75U3FdIDKXJUJKF+qro6b8f4X3h2OKnGoCWPSxNtrakoFbp+2LASkzI3AryXS7H0RICUN8say13Y/t7A4VKl9zqZje+cSi8DT8b6+gFLvJD/S7CqUbjhoqLbrRE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ll5lfdNY; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ll5lfdNY" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-248c676a2eeso12966645ad.2; Fri, 29 Aug 2025 01:49:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756457389; x=1757062189; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V9HlGwGT0pLc+kAXQgdPzsVmtLcDrXDu6GbAvNPTmaE=; b=Ll5lfdNYshAIf04296poDM13qZG5bNffLd8rWmdUSG6TOvJwGhaAZfT+1sa2LU8wnj KUfu0BKvDvwMiPieSdR5LKMo8kQFhdwzEdfMpQW4CZN0cZWmZcxr3X49cWzsSS/++ndp +NFwwYLkHifkVkDjTfLJbiP6vSP/ONJZvVHwUZcAQwtgq0lLGvoNyHcD9cAZBFuRxVGg sZBiiAvBITz/QB7thyPTYhpTfBxVx9++rf/raHmaCQyHtpDf2x6tI6nV+mHjWafeNLho Gt6c8IImD56rx7kNkD9/ayKQRuOJmDtoU2m1lYzfz8pN021BD+/Bf6Z7jEAcSW4kmviH WFQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756457389; x=1757062189; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V9HlGwGT0pLc+kAXQgdPzsVmtLcDrXDu6GbAvNPTmaE=; b=QQRUMVKpIdrgOvu1gidSrW3bR/isW/BcogYhc2qc6+ID50qdH9yaase04FlC5VuEMw 37owrBoCH+P/I4FoSACSoGWpN7nXKWw3v/rVi6vVF6gniVGp+noo930HDDKX29Ci7oQI rCLTeGDqDsNhETP1VIAFYeS+xywT+ciR5jdl1KWTCiJmRYGV7x+ZjaNWhM/0Gjmp1L0U EXmhSJtMtZHEHxL/S/j5Wl9VO7waNoTYodJl+NM16GoGME/FXtDxtEgtzYgy+TACbhXo Guvs/itg9vrgWTp5W/5SYmMK1tYwi1ghaRfKCn634e6kARz1fWDV1wyKcTR4K2uzNK0k WwTg== X-Forwarded-Encrypted: i=1; AJvYcCWgKSDce9jAkRj+r0RFe0UCZDZEayKAxUfNo/9X0D1/5RryIURW+Y+4zmomW5KqE9K4M1Nv1D8Ly/yLrBd9Ig==@vger.kernel.org, AJvYcCX5k8Acy7QwsKULfz83kJlQdYZgjbuv2dXKAEJcM/5EzaQY5lFiRZ8hTZhNcUTTkaH0T7PFjITaF+Nm+aw=@vger.kernel.org X-Gm-Message-State: AOJu0YxToUdCRnB0oIRG9xoFoIK04Xy39q+9R5e6M5u4v0XXF6RjzG4O yRZ06FsXz5+YzlCnsn+Ixc+yp1qtv9qnfZqWm4pWsZkDuPutKN6XU9kP X-Gm-Gg: ASbGnctjQKILcVnMVV2xn1DaaqfXDGg+CLpvPDIPqYuKijJndh+0qxENMoJqBoapblv AY+xRFqfEgxY4Xqz4P20OoU1HKL3/HDBLSMncl/HZtfKp6KtUokR/yLGO6rrb3zqYFBj/fh9HLL p2/+D2fky08lxaBc6QoTD8RoYl77y3xAbHLd1Qv5WDVBngQQIAaDRsLVTS2zf9k3BuZu22//IQk 94OqRFxd3LQMPz2+vx+nRHY/lgWk9AKvXAotuiTGvImLxdkLnud9vOZSqwlofwfUNdZOsfl/0T2 DsdaK2HrW02cOyhvFbxD0TEgtvy7kDewpW0fdoWs5XYbVhwtHkI7Oe9ep+dxmnyii1Ao+8EtMxc UhwQBUWnUNcVzTIHPjiK5nube0r1BIX2+GwOpFWiLfwLuq2Myzg== X-Google-Smtp-Source: AGHT+IFgFKZjtkTGAQrCNbDLl/t8Xm+woykXRRL4Y+VDxejV2v0MdiwV7pzV45adAFsKVLM1cU+0aw== X-Received: by 2002:a17:902:ec82:b0:247:7e9:110d with SMTP id d9443c01a7336-24707e91239mr256840525ad.6.1756457389252; Fri, 29 Aug 2025 01:49:49 -0700 (PDT) Received: from localhost.localdomain ([103.88.46.62]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-24903702980sm18561865ad.13.2025.08.29.01.49.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Aug 2025 01:49:48 -0700 (PDT) From: Jinchao Wang To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v3 1/4] module: signing: Use pr_err for signature rejection Date: Fri, 29 Aug 2025 16:49:10 +0800 Message-ID: <20250829084927.156676-2-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250829084927.156676-1-wangjinchao600@gmail.com> References: <20250829084927.156676-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make module signature rejection messages more visible by using pr_err instead of pr_notice. Signed-off-by: Jinchao Wang Reviewed-by: Petr Pavlu --- kernel/module/signing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/module/signing.c b/kernel/module/signing.c index a2ff4242e623..557cb795fa31 100644 --- a/kernel/module/signing.c +++ b/kernel/module/signing.c @@ -117,7 +117,7 @@ int module_sig_check(struct load_info *info, int flags) } =20 if (is_module_sig_enforced()) { - pr_notice("Loading of %s is rejected\n", reason); + pr_err("Loading of %s is rejected\n", reason); return -EKEYREJECTED; } =20 --=20 2.43.0 From nobody Fri Oct 3 14:34:25 2025 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBDAD2D77E3; Fri, 29 Aug 2025 08:49:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756457396; cv=none; b=GujijVqCqT/UJ5Qi7EtpZlW657FHcYby+/74p7GTNvU1jklZ2fYSl79lZr9JLzbhu3LvKnwXCAEcWmoqV+ma4n2MaN/THazRsSb92odrpd3BDzoNWNGVCXMv2i5ey5n4oOEGdZl5CAnPJCFPU2f7pbc1X/5ioB+CTs5c2qgsOyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756457396; c=relaxed/simple; bh=G6Dd1uqb37z6zSbzhuNpcxLh9MKP3I+uJo5S26l1UeU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ouFtp2kizvJabb1OiOe/2rkIPPakCtBfk/FYs7hJ3r+5aogWSRbjl9j2bMu/D0z7jSoh8ldN4HmbxFiM7jD2NaINP/dD3z2AXStZrBLJcPFPM9EJER7dZGwPK4sL2MSpP4FsnYf44fpLIrkEorbgPTgT+tM/kzKDf0aFT7vogVA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BOEpH3vo; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BOEpH3vo" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-b471737b347so1259289a12.1; Fri, 29 Aug 2025 01:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756457394; x=1757062194; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jaClGvcV3jmxIulwFuFHgeLeNjTELgbREuj9VBnH4uc=; b=BOEpH3voKkKC/s6XHhagdo9yZcdvekz8StzOS+WTMarCAG4slaVXVt/5llLcIzY1bJ L07gxtTLto5ebTZ+FQb1DpMARmG6bI2s0zNOjWpz72dmBPGlYnWbM+qdke5n/vm9Eks+ HZN+91zjd+r+xkrkijN7szI6UWo/Y/NGuTLQ4SSYFVPr0qftL/Ph3aySZvYsQZOj3tGt zjU9mtXIE5fsvZWclaQQ+mniVTLLMcoDPyXVCVs7JrAnQUJwzd4GH4KXsVPdE+ciPdmo ZB1dSbDcYpxTT3ai2TzbyWqr6xrxLW67QXF/0zxuvZjskoiX7gwG7n60RrJS6Ry5MUrf wOkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756457394; x=1757062194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jaClGvcV3jmxIulwFuFHgeLeNjTELgbREuj9VBnH4uc=; b=Z6/biPwge9VeawWqoK/YfRkMcDyMMpQRU+9Q3dIvasPHcBc6Bg87MEV5ooqCyxzNdE zyuzU5Loa8+00Gw4RE9/MXuOS4JSRjddoOZ4UJPRv3GojDgF7G4vwKqIIHuvIaYXOJl6 YoVWczspjstKvQp0HgURg/Hnwj29KqsWn4imCu76uimYCYmPlrlG/p3PMtTATYF2R5G8 9pMkbGxmtKjn3myAcNvxZvtRyGiGlTOU0LILDOKMRO3Vi5Z3XgH4BPegHEIQ/N2+Q9Qp yDgkxcQO8oJ92BPIvrdda+pY7oYSZx87vLVldurRwp+6KMo7P60cmKphjVHrZAwCadFF BxxA== X-Forwarded-Encrypted: i=1; AJvYcCXIkDSrplmK33xJ0uVQqdmjpbq4B0W7X4jjcL02Bc4DLCZPbhZBPsJprnZFzbJmEmu7px3P1kTmz02XB0DL3g==@vger.kernel.org, AJvYcCXabFc5Di3V4CbUj4/BISjGUcul7bruL6VDiNtkMV27mIusf+yWlXJLwxdu+A2Y27nwtyzvZUes4AJmdRg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywz0txyCrNsG1kwUL1RiyaywMVSttT+qkbpiLiO1MQlKlu/wWXN UWK5AVE9N+2bBrt+OpULZwYb/Qxz9MWR6JM/jfggcy0i2x5IGHbjGAIq X-Gm-Gg: ASbGncsC05v3ANapvIRDe1xuHfj/mGwDPk2qxDVj+XpS2afrAExJDRMg9AlFU0bl+N0 p/hJjupYqQKV+XklHy1kzMixs07eHzDglfeGefbNZRBe+TMbkpF+7tc4qf99ktaVQZ1d17GB4p4 w1OHFapdXkKjLmNnecrq5P25LcvZDMi7IePV2xK3+iThBHqrodINCROrHdT2eLIfHt9VKqrFnxW UgE79EVSeN8/IW08lMTaMHsAijy5JJcW1+A9Lz58yb7lRbOuV7twzq/EH2exl0a7QKVcg02Ahh5 HZsdvzFNpoh5pL0WIKrbobbIzyvRh6ylbMvSfF1wcVMUslJMgnPOhzD8En7HB4YQftl7q5f3obC Wbs/PTbEhsCLM2wj6EzsyjCpW10G9CiSNMQ4dDS2j2x419VZR1zpBMNCKyloc9a2mLStkxlE= X-Google-Smtp-Source: AGHT+IFEyhZkAgy6mOMidTOL0WB2kvEKN3fZkModigxlDVFNLiE7scoqcUc8a94lCh8zpqLFUA6UYQ== X-Received: by 2002:a17:902:f542:b0:249:2360:6af2 with SMTP id d9443c01a7336-249236075e4mr4297385ad.16.1756457394091; Fri, 29 Aug 2025 01:49:54 -0700 (PDT) Received: from localhost.localdomain ([103.88.46.62]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-24903702980sm18561865ad.13.2025.08.29.01.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Aug 2025 01:49:53 -0700 (PDT) From: Jinchao Wang To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v3 2/4] module: show why force load fails Date: Fri, 29 Aug 2025 16:49:11 +0800 Message-ID: <20250829084927.156676-3-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250829084927.156676-1-wangjinchao600@gmail.com> References: <20250829084927.156676-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Include reason in error message when force loading is disabled. Signed-off-by: Jinchao Wang Reviewed-by: Petr Pavlu --- kernel/module/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/module/main.c b/kernel/module/main.c index c66b26184936..e7484c6ce6e3 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -1083,6 +1083,7 @@ int try_to_force_load(struct module *mod, const char = *reason) add_taint_module(mod, TAINT_FORCED_MODULE, LOCKDEP_NOW_UNRELIABLE); return 0; #else + pr_err("%s: %s, force load is not supported\n", mod->name, reason); return -ENOEXEC; #endif } --=20 2.43.0 From nobody Fri Oct 3 14:34:25 2025 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54A3A2D8396; Fri, 29 Aug 2025 08:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756457399; cv=none; b=kR0beKQl4t9CCNlqh7PFadDnJMAP3Mw/Pe66w/myfXREsfQ9aQ3US7pB+K9IoUzl7ZJ8ZYRASLt8IXkc0lS7xa/eWDflNxU10ErwBDqfNnHchx+oiYEv5NflVLEIEmYapHLWKrBaxI+tL7Nfk5cUt4RP+SWqbkKF50UVBkux7/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756457399; c=relaxed/simple; bh=hjGrDsr3uC83afBLDyQ974R48yYRN7PzN3GHmDLxfyk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NwqaqGtSb2HnGC6nk7I4ws6zQsT79tIp7Ce3FJkSjitmwinpPlCFm79zSvXD5XH5UIEciSivXZoxTdI39fgKuPK1BPJrk8zHZK2c0l16jR5GN6t2giCOcTO3cjh6BLIC7EhcE4fmFvciObyd60WkdMQQzstnXCABrRBCD/TSZOw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N+W4CiPM; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N+W4CiPM" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-24646202152so22892315ad.0; Fri, 29 Aug 2025 01:49:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756457397; x=1757062197; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wxqSnIoWMjfZQAuq/ccEkan01OYjIRKDD3nXH4XpB/g=; b=N+W4CiPMmAY7iqjJHle8mzRppeocG9bs+WgYJceC/erA6Pqo6+SEKaS+AbuMHVXzt/ 5Sl9yYCBKA7uHYeUPu0/lEqZ3GT63UGHFf85GgVA7gG8zD9zlwMUVALRJ6uzIPUPIpZE aAIysma655Vr6LMzbOZ84mjgbB1gm8mY//xxhaHb4WgoV27CNqaF+zEolOyQLvxbgeTk mVK7zG1l1Q+LVNWEIy5/DaZuajiDxdVEaH8w5bdC6oYRYTO5EyGK8xtWLOtHcT3nMSpZ GyHLBS0N0mYYiCGOZkhwwDUFTAYVsrfWMhG8zftIlCdNr16rmObF9PjF1reg23mlsfg0 /HGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756457397; x=1757062197; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wxqSnIoWMjfZQAuq/ccEkan01OYjIRKDD3nXH4XpB/g=; b=m3dYqk1UfJllytA0XdxJbZyTkFUKHvXxP4lDyjy9sLXBlE/L2G3iBuy10chM4Hl5eO zsqKHvl759WDi0UWskej8/SEXelFZ4QY0MUIvA0qtc+pXi7nokZJQUTp/WN7ekXSN0EZ 3NULu85Te0e6PAdEalbVZld5DnHyf4+XNOjAbA1TOJLIAvx6KNq+MKGmNkz0yGE9x02V zZz1T55W9eI0S41sRqwRgOovLBPMLGLhmUJzypyufEqBpD7DkS68FxC/ivMlTXwIxohS uubzDj0iiJd0BxU9lwxWPqbHjkN50Q1GKSWeUXvLxHyNuYvud6rkfo4eGo+gggE456KS n6CA== X-Forwarded-Encrypted: i=1; AJvYcCUeKsERBSKkFhokXro+yRoBIuHiSF6iV5aRALHeJLY9XFtY1pJemtEGm6jADbvIykp+gLbIDSHsB4DTbgU=@vger.kernel.org, AJvYcCWjYFcac1byyz4D9L+WvsHZQF6OG4uAL/tfmbPxrjtj2bnJKGpuYx5C4jgJg5xhs/3Occob0acNyrkImB2OFQ==@vger.kernel.org X-Gm-Message-State: AOJu0YzPlEqCf/KTc5edq0vxVlIlcd+WiDRsTvbkG32hAHFrbzdXriOt ZqO08+ZWS1UxrE7SmXZ9kmSYIVDjPZHMK2s5I6tFCZSLXyKd5BnT6M94 X-Gm-Gg: ASbGncsykc3ok9ejD1Kk/USZUvzKuU2EsJsnV/d4LV2YqTniF44Od8ingXtX8YVGYwb 30VyF+ipnjfxAiy+ov/qAVf3j5T/h5S0po6L9AnRzgIcc9ZWDmcE0B9OA6cFSdNWtf2FZeaWFqF p7iN5iyMI8pCSRZhw2qeV6Z9rqybwUhLT/Z3mWKS3J0S48P7IIsjPSA4IObVX0BbEhlfqBljpLD ZThtHfMJbyYoCjqzJf7MG8v616yAe78XBdYrUbtDKUC1W+3VaVyImoC2cLqD9QmRxjzZKyeAXDI Fk9UVdAMJ8PnjpkSCK8Chhsm6SH25VRO55mXG9pdrn/DFmrDgLCwuYzlvSrNV1qQMGcBMLLd/fn Fw8IwP5+G5gwyVHbAVral5d+Hlx12z8/s2n1b7Jv5+JdhBJ2iiMseFuyHXP3Pr7EKp/xVH1s= X-Google-Smtp-Source: AGHT+IEIefFei2RlDSwEzatGN0qI66i5+W36h8pnrkIZNHDFd+IIkhhRd3zlZgt/QZ1suX8vEunFeg== X-Received: by 2002:a17:903:1a45:b0:246:ddd6:f8b9 with SMTP id d9443c01a7336-246ddd6fd04mr245733245ad.43.1756457397448; Fri, 29 Aug 2025 01:49:57 -0700 (PDT) Received: from localhost.localdomain ([103.88.46.62]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-24903702980sm18561865ad.13.2025.08.29.01.49.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Aug 2025 01:49:57 -0700 (PDT) From: Jinchao Wang To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v3 3/4] module: centralize no-versions force load check Date: Fri, 29 Aug 2025 16:49:12 +0800 Message-ID: <20250829084927.156676-4-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250829084927.156676-1-wangjinchao600@gmail.com> References: <20250829084927.156676-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move try_to_force_load() call from check_version() to check_modstruct_version() to handle "no versions" case only once before other version checks. Suggested-by: Petr Pavlu Signed-off-by: Jinchao Wang Reviewed-by: Petr Pavlu --- kernel/module/version.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/kernel/module/version.c b/kernel/module/version.c index 2beefeba82d9..7a458c681049 100644 --- a/kernel/module/version.c +++ b/kernel/module/version.c @@ -41,9 +41,9 @@ int check_version(const struct load_info *info, return 1; } =20 - /* No versions at all? modprobe --force does this. */ + /* No versions? Ok, already tainted in check_modstruct_version(). */ if (versindex =3D=3D 0) - return try_to_force_load(mod, symname) =3D=3D 0; + return 1; =20 versions =3D (void *)sechdrs[versindex].sh_addr; num_versions =3D sechdrs[versindex].sh_size @@ -80,6 +80,7 @@ int check_modstruct_version(const struct load_info *info, .gplok =3D true, }; bool have_symbol; + char *reason; =20 /* * Since this should be found in kernel (which can't be removed), no @@ -90,6 +91,11 @@ int check_modstruct_version(const struct load_info *info, have_symbol =3D find_symbol(&fsa); BUG_ON(!have_symbol); =20 + /* No versions at all? modprobe --force does this. */ + if (!info->index.vers && !info->index.vers_ext_crc) { + reason =3D "no versions for imported symbols"; + return try_to_force_load(mod, reason) =3D=3D 0; + } return check_version(info, "module_layout", mod, fsa.crc); } =20 --=20 2.43.0 From nobody Fri Oct 3 14:34:25 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A84D72D878D; Fri, 29 Aug 2025 08:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756457407; cv=none; b=pJLaRNCyi7K+ZwYjxzoey2q2S7gDHQyxkX90SYTcMkPMF68pWtcJNTQtKLhrsQN4vekpatHdpf6CpgkJjlsrECBEWpKOH5h4nGisAdx0HDTZ67noRl+0JPUN6wL1uNCgiaQ/Vm47xeEd57ClNes6L/R4MhTpeVlHpVLLZrhcpTE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756457407; c=relaxed/simple; bh=fpaE0d595CwgrDFlhfV+X1m/1hWBH32tbRMD/0YcFiU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nl0AivRyRmquD3TLAbloztrTAVDMMnOPfvUTn1DsCQtWWKRWyI274EDBcnK3Qdf/rniStWN2U3Q6NxSoFRh4wYwEzE6uac38rKL0TlliBGcvSzlkOyx2pKVo7LZIspdhgE92YDmItYo2qAJT8jnpeGMAVtHNTIPIkKJhgIIBgnQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C+xC8hKv; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C+xC8hKv" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2445806df50so15326845ad.1; Fri, 29 Aug 2025 01:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756457403; x=1757062203; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/Ud+6Xa1z1jB5TLuiA3lgD5kenmdYlZUP1Al5nUROhw=; b=C+xC8hKvVDIAOR43Wn5Q6D/W8OJcNwUXj13YpN0ChTBWWRc6TsGKqlWR9EZr45hHHq 9SZzup5BkaT63acvSdaCmFSbYMFWRCh24o5znl8qEf8kxhUYkdaEM34yO1pjCla1M4AU fSeIdNELjBfIH3HY1wkGTEcncVpdywe79E24DAvkKVMDmSzCnK2VKAd2//szFCcQVSVw U0as2AbYD+y3ZEavYEk113JdSBJdwj3/C388w10rD/M2EWAOYGUNeRHO4M00DEhrtshr qGg0T4p0i76VhkTOKeJl89qeHgPOG2bokPPipqv1jPOZ6h9LBwhbKz+pmVa1pXlUFZal nRDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756457403; x=1757062203; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Ud+6Xa1z1jB5TLuiA3lgD5kenmdYlZUP1Al5nUROhw=; b=xPOI3oxkA4FccHenvDT2eGQSKbP5NLQiGTiqfMkV6+wH6A1vlwR0Ej9eVcqqIQ+5JS x5tdOlwCpPuBhRFJQBt32BmdNlx282+YrxQ8/VSFgWBrs+/zlLBJapp8oB5kgggOej41 hbJ+0n9Kz+LkeNuecwrzVLTqwIYHU9pRMuOTBoft55y7x294abx54pcnkyxCzrc2IK5a JgD/qECeUstyJTjGseN2LY3wj+OYjAdghaX/gZhr4lT3t8bbtuzVAWClIXMDYWpVJbrV 4yWQMfuJIGuviBTwC8saUHVoylKV9VhaQPLWChH6qVFYcp//wEQgAhXnnW4JCzEyw3Xk zzGA== X-Forwarded-Encrypted: i=1; AJvYcCU8yUw1JT6QI1JOTElX2RMI2ld0NkTemd9dCdqRTdG/hKTiT6mA6x1Qy0pn6ny5h3Ez7PVlC7k7VwFEmuw=@vger.kernel.org, AJvYcCUkmcWNIjLj3VSlKkzEROVOqPUts9ofMN9U2jCO+zOEAu0uwRtCZU8xd62vHDTHcSpqFku7G9/dQJQe2MNt0w==@vger.kernel.org X-Gm-Message-State: AOJu0YwTZjFaFci7pSqUZg4GIm3NEFzBqp7BD5A85bZlzvlEjfBkwdnB 7SeHXjBkWNe0ct+7DdJVa7hQtc1HsR/0bAssRw6R6ls7sEqso67njhZX X-Gm-Gg: ASbGncsZKwHt6XPl99v0egO4930T1zXjGXkmb/nEbwt1IFB5qK0vjMqUdgrp6tpD5zV LthZdS8mxZ6bY1+0XwibWn2SinryHGGM6F7e59XcAdYxQFWju5d480NxJDTzNzNZIqJfgZHlIsp 9eKjaX9EMqCag9hs+5+jOSglRGtRW+QfvdZlu72ZBJnaXpqr1K3uhOMZt60VuOz62gLzg+DSHwj n+QNsyJndtkBD2S9QU0CESYA4F2ZruJ+riA2gcRbjuh8SFh+ChrmzX6ghxEumkmu28CLVoMFbd+ HQeJ8SBxVDa47zD2ERhM1Qa4awLoo8SnO+WtC+W1HE7svqXAlscjIb1DvthWZcQIN8oHJKo3WVD CI21NPIBLMdJDWg5H2dmz5S/7syPA2+G73/5lOSAartnfxCiZNpqAwbF3q0fP X-Google-Smtp-Source: AGHT+IGJjVrZjcGLD+aYNVVvBsvvvll4RulQAnH99m3XElYYX9NlW09W3j3ChREh88K6yxVOoh/PQQ== X-Received: by 2002:a17:902:f607:b0:248:e0a2:aa2d with SMTP id d9443c01a7336-248e0a2b173mr64242025ad.25.1756457402912; Fri, 29 Aug 2025 01:50:02 -0700 (PDT) Received: from localhost.localdomain ([103.88.46.62]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-24903702980sm18561865ad.13.2025.08.29.01.49.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Aug 2025 01:50:02 -0700 (PDT) From: Jinchao Wang To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v3 4/4] module: separate vermagic and livepatch checks Date: Fri, 29 Aug 2025 16:49:13 +0800 Message-ID: <20250829084927.156676-5-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250829084927.156676-1-wangjinchao600@gmail.com> References: <20250829084927.156676-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename check_modinfo() to check_modinfo_vermagic() to clarify it only checks vermagic compatibility. Move livepatch check to happen after vermagic check in early_mod_check(), creating proper separation of concerns. No functional changes, just clearer code organization. Signed-off-by: Jinchao Wang Reviewed-by: Petr Pavlu --- kernel/module/main.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/kernel/module/main.c b/kernel/module/main.c index e7484c6ce6e3..98a678a18300 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -2571,7 +2571,8 @@ static void module_augment_kernel_taints(struct modul= e *mod, struct load_info *i =20 } =20 -static int check_modinfo(struct module *mod, struct load_info *info, int f= lags) +static int check_modinfo_vermagic(struct module *mod, struct load_info *in= fo, + int flags) { const char *modmagic =3D get_modinfo(info, "vermagic"); int err; @@ -2590,10 +2591,6 @@ static int check_modinfo(struct module *mod, struct = load_info *info, int flags) return -ENOEXEC; } =20 - err =3D check_modinfo_livepatch(mod, info); - if (err) - return err; - return 0; } =20 @@ -3334,7 +3331,11 @@ static int early_mod_check(struct load_info *info, i= nt flags) if (!check_modstruct_version(info, info->mod)) return -ENOEXEC; =20 - err =3D check_modinfo(info->mod, info, flags); + err =3D check_modinfo_vermagic(info->mod, info, flags); + if (err) + return err; + + err =3D check_modinfo_livepatch(info->mod, info); if (err) return err; =20 --=20 2.43.0