From nobody Fri Oct 3 15:34:23 2025 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94829220686 for ; Fri, 29 Aug 2025 05:32:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756445572; cv=none; b=aw7P/ya8STOb2TraGauKHiVEPrTW1hScKheRH9Z738EgB/AFJ0vFqIECYV+ituuZoX8n3BQ3rxgOAi1nBafBUnXclZhoSIdNre24TnI6oXacPl9RHlKsri1krijf+RYUBqngnZb67ukWZV32AoGbaMOPs3V0A2Qw/0Wsp1uvOSc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756445572; c=relaxed/simple; bh=it8j8dZw2hH3hfJIzrCp2+2K3wRWlp/OcQFxPc0uJwc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=cIc/nNVPs1pAx/0b6Np8k0b0enxvx9j4SuQNtCKetyLCoPol2cEvvDUOPK/IiMogM+N25W3QdKEsteLYgRlsegy16YRLgq/wbKbju0M7kX+opW7W16UumtNIKr1rkBItkcO6R6jzzmpclxNaKIYOGhu7+b48pX5+vNVRHGIorUk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=2ZfCnwGA; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="2ZfCnwGA" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-248942647c5so29631615ad.0 for ; Thu, 28 Aug 2025 22:32:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1756445570; x=1757050370; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=SzE0wXAU7cnYqxcpRkXupDScvkyCa8YNaf8qlEhk8pI=; b=2ZfCnwGAY4B91DspBeY9wuLWRJECuYxUKzVWZDXD9L3nmaBWkuohAjRnf49I3j2U/q pKcxOqsuWnySgakEq6P8wd31ftxLU3uDAIqlSynDyGSePvOEpjcE4EGqoqnIWOduxZ1l 6Fc+9hTntfDOaLWJAWh2UhjsscTpEqgD5qpmHxX4S/mAwxwo0hN6k7DTbXpPnUCy3KUu /o+uxosGaT5U2sSMi/7tWthQgX/K1Yd+PHD+sofKNWZ9pSK0A1vxlsy7yPfazu6gbJAH s+oNmEQ8ZcwsWFkbIFtWRNQtFl6gu1TbXqm++Zh3r1QZh46xz+14PJ0oJ6SVevEjtjVo ifhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756445570; x=1757050370; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SzE0wXAU7cnYqxcpRkXupDScvkyCa8YNaf8qlEhk8pI=; b=qPooOU2r1k1oxZE51ETlCvJvcG0AEqKN9Itzkhx8QD+9yq6TBSUXhkx8QGbkDlddC0 YtGJPKRMeWXHkDxW/ssCMbyEkgWDWI7RNVfDtlXVyG7LijlM357vnxjuuFKlyvE7uEqf gz9BooQjh0w7WYhvUUhAOwaBGQbUaf+MTIrUxPm4Lum1laWNWwZibajpWgWh82EAbojF xSI0W3UcAzHSeuz1oIUPUgjs1y0dRgdxZSnn2WOdkexqx4hs3WRhAP+IhEjEnuOEW1VL NDdw4ASHfOgZlqiWNgs+PjGS5PtuJKXGq+s8Tccet+bLMmsdyMq50AsIYbGi4dNTb50B RSUA== X-Forwarded-Encrypted: i=1; AJvYcCUatj2AHhxnKDj04VpX7n5Htv0orkxSUKK/XuKqpf4zDOTDyb7lPQIFlXPiM57Ri66udzYqe1Svogb8v1M=@vger.kernel.org X-Gm-Message-State: AOJu0YzPPZlxdN3NoepsQi1JoNXNOgFqXq+2No2XD047e7TypdaaL9m3 wkTg5+FqzTIuI7rLHxnYBf78z6BeOvK1VaUeuf7/G2Qex+WpQPxbTsFbuQ2KyHniDXz2fze287l UUUc+Mg28uA== X-Google-Smtp-Source: AGHT+IHyWL6/xZiKJHFYuVy4cbafKY/q5bdEKjNpIn0+uzqogCQZ4/QSuzN08I0TigrmzzWWT6/hXMsxRzw/ X-Received: from plez4.prod.google.com ([2002:a17:902:ccc4:b0:249:1128:5827]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:da84:b0:246:80ef:8808 with SMTP id d9443c01a7336-248753ada95mr153418385ad.3.1756445569918; Thu, 28 Aug 2025 22:32:49 -0700 (PDT) Date: Thu, 28 Aug 2025 22:32:34 -0700 In-Reply-To: <20250829053235.21994-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250829053235.21994-1-irogers@google.com> X-Mailer: git-send-email 2.51.0.318.gd7df087d1a-goog Message-ID: <20250829053235.21994-3-irogers@google.com> Subject: [PATCH v5 2/3] perf jevents: Add cycles breakdown metric for arm64/AMD/Intel From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Xu Yang , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, John Garry , Jing Zhang , Sandipan Das , Benjamin Gray , Leo Yan Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Breakdown cycles to user, kernel and guest. Add a common_metrics.py file for such metrics. Signed-off-by: Ian Rogers --- tools/perf/pmu-events/Build | 2 +- tools/perf/pmu-events/amd_metrics.py | 3 +++ tools/perf/pmu-events/arm64_metrics.py | 2 ++ tools/perf/pmu-events/common_metrics.py | 18 ++++++++++++++++++ tools/perf/pmu-events/intel_metrics.py | 2 ++ tools/perf/pmu-events/metric.py | 1 + 6 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 tools/perf/pmu-events/common_metrics.py diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build index 366cd720659a..b2c557ad9964 100644 --- a/tools/perf/pmu-events/Build +++ b/tools/perf/pmu-events/Build @@ -43,7 +43,7 @@ $(LEGACY_CACHE_JSON): $(LEGACY_CACHE_PY) $(call rule_mkdir) $(Q)$(call echo-cmd,gen)$(PYTHON) $(LEGACY_CACHE_PY) > $@ =20 -GEN_METRIC_DEPS :=3D pmu-events/metric.py +GEN_METRIC_DEPS :=3D pmu-events/metric.py pmu-events/common_metrics.py =20 # Generate AMD Json ZENS =3D $(shell ls -d pmu-events/arch/x86/amdzen*) diff --git a/tools/perf/pmu-events/amd_metrics.py b/tools/perf/pmu-events/a= md_metrics.py index d51f4c3fe0cb..2252894633b0 100755 --- a/tools/perf/pmu-events/amd_metrics.py +++ b/tools/perf/pmu-events/amd_metrics.py @@ -4,6 +4,7 @@ from metric import (d_ratio, has_event, max, Event, JsonEnc= odeMetric, JsonEncodeMetricGroupDescriptions, Literal, LoadEvents, Metric, MetricGroup, Select) import argparse +from common_metrics import Cycles import json import math import os @@ -594,6 +595,7 @@ def AmdUpc() -> Metric: return Metric("lpm_upc", "Micro-ops retired per core cycle (higher is be= tter)", upc, "uops/cycle") =20 + def Idle() -> Metric: cyc =3D Event("msr/mperf/") tsc =3D Event("msr/tsc/") @@ -676,6 +678,7 @@ def main() -> None: AmdSwpf(), AmdUopCache(), AmdUpc(), + Cycles(), Idle(), Rapl(), UncoreL3(), diff --git a/tools/perf/pmu-events/arm64_metrics.py b/tools/perf/pmu-events= /arm64_metrics.py index 067ebbad1adf..5e9b37693a8d 100755 --- a/tools/perf/pmu-events/arm64_metrics.py +++ b/tools/perf/pmu-events/arm64_metrics.py @@ -3,6 +3,7 @@ from metric import (d_ratio, Event, JsonEncodeMetric, JsonEncodeMetricGrou= pDescriptions, LoadEvents, Metric, MetricGroup) import argparse +from common_metrics import Cycles import json import os from typing import Optional @@ -172,6 +173,7 @@ def main() -> None: =20 all_metrics =3D MetricGroup("",[ Arm64Topdown(), + Cycles(), ]) =20 if _args.metricgroups: diff --git a/tools/perf/pmu-events/common_metrics.py b/tools/perf/pmu-event= s/common_metrics.py new file mode 100644 index 000000000000..6a44e5756cbb --- /dev/null +++ b/tools/perf/pmu-events/common_metrics.py @@ -0,0 +1,18 @@ +# SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) +from metric import (d_ratio, Event, Metric, MetricGroup) + +def Cycles() -> MetricGroup: + cyc_k =3D Event("cpu\-cycles:kHh") # exclude user and guest + cyc_g =3D Event("cpu\-cycles:G") # exclude host + cyc_u =3D Event("cpu\-cycles:uH") # exclude kernel, hypervisor and guest + cyc =3D cyc_k + cyc_g + cyc_u + + return MetricGroup("lpm_cycles", [ + Metric("lpm_cycles_total", "Total number of cycles", cyc, "cycles"), + Metric("lpm_cycles_user", "User cycles as a percentage of all cycles= ", + d_ratio(cyc_u, cyc), "100%"), + Metric("lpm_cycles_kernel", "Kernel cycles as a percentage of all cy= cles", + d_ratio(cyc_k, cyc), "100%"), + Metric("lpm_cycles_guest", "Hypervisor guest cycles as a percentage = of all cycles", + d_ratio(cyc_g, cyc), "100%"), + ], description =3D "cycles breakdown per privilege level (users, kernel,= guest)") diff --git a/tools/perf/pmu-events/intel_metrics.py b/tools/perf/pmu-events= /intel_metrics.py index 7250e8c8eeba..eab69474e141 100755 --- a/tools/perf/pmu-events/intel_metrics.py +++ b/tools/perf/pmu-events/intel_metrics.py @@ -5,6 +5,7 @@ from metric import (d_ratio, has_event, max, source_count, = CheckPmu, Event, Literal, LoadEvents, Metric, MetricConstraint, MetricG= roup, MetricRef, Select) import argparse +from common_metrics import Cycles import json import math import os @@ -1069,6 +1070,7 @@ def main() -> None: LoadEvents(directory) =20 all_metrics =3D MetricGroup("", [ + Cycles(), Idle(), Rapl(), Smi(), diff --git a/tools/perf/pmu-events/metric.py b/tools/perf/pmu-events/metric= .py index b77485b47666..315350f3b6ed 100644 --- a/tools/perf/pmu-events/metric.py +++ b/tools/perf/pmu-events/metric.py @@ -23,6 +23,7 @@ def LoadEvents(directory: str) -> None: "duration_time", "instructions", "l2_itlb_misses", + "cpu\-cycles", } for file in os.listdir(os.fsencode(directory)): filename =3D os.fsdecode(file) --=20 2.51.0.318.gd7df087d1a-goog