From nobody Fri Oct 3 13:32:31 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81798239E6C for ; Fri, 29 Aug 2025 19:33:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756496039; cv=none; b=X3i4Pa8LIxBvaCn4tB7YjJU4blgiiElQo+LebxcsWjOhfsZ5/JuhI/j/Zq7TC7bnRYo8cUjVkcMgOr9bMJQmM3Tlq/Np1aLQpueVzKenIDTo+N/WWQSvKPFWejuj+VOgMh5vnOu6HgTgmT45UJcC3J8Kz/q6nIr0KMMsxO7H6fg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756496039; c=relaxed/simple; bh=OArcrcPJKctf7kyzhyu5N9o4Z5m1mtDS835/OiICaDA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=CNS+Pfe5KZu0OtD7BFztwV0qFSyu3WjMPm1kyUIlqTCMl8400KsYqc4o+Z3WOQnPB4+9Q+zMUoIiglok9Lh1FSIHFRe8scvuPBztFu3HuJbCxR5aixzkp8Ru6zCvOTVlUAJkZyFeTLmjife7fikysiHrIFD/gvy4DZGDjP/fjxI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=NmUET5/X; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="NmUET5/X" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3d0b6008a8bso486438f8f.0 for ; Fri, 29 Aug 2025 12:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1756496035; x=1757100835; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=10aYLv6x+nousnJCn+LNWW0LkPPpH+PRdELXD4FgtcI=; b=NmUET5/X3U8sj2gncXKyFCnU5CVXnxTD2YGhtvVi8DHQg6+yBIW+pbrP9bCZaDtY9T CnRAMaYFNBKYoa1T6b+uRj+omG/LIAvoPUMk1NU3eni5IiBhv0ZbvJCKeLCi5+QQwf1F PCF8ayZgHuxI4dE7FRFuNLDvNy6OV2n4mYejFLNVg+p4Cdzj/chxFTxcZ4BPWSVN/Jck V1hMFJeTQcHGflCsvCfxLv07pjCWX9p0qZU9MnmFiJ0Ove++lVsi6WW1qf6aGsK9uit/ zfeqHBfG5PzYsvEefpsBCsCDj/YoZ8omUh0ArMSz0SLlNp2SB97cKo6B1EraCdW5regL F0oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756496035; x=1757100835; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=10aYLv6x+nousnJCn+LNWW0LkPPpH+PRdELXD4FgtcI=; b=bkPDtEufAdLKa6vPBaozwGSR8+mT4yPfOQsZv2Q90uWoJjuQNB5MMBKNNeuu/Xfuks GshKhHZhIOEaFiVB1fVpHA8xhJFRMtNOa+NmS1d3s1f8496E51EjF0XIUmG02BjP8AAy x2u7cjZMgTqxL9Z2PM9wy2NxJNqXqb3/GPn/3XwoJ0QAt7zgrYYKWu/5YQbfGFss1An7 PY/oD7WubokbL1IQlxX9dYRZgVv9NVvor37nRR+HL+LHN+G8nbmaj1LcuxakB6EIAzAU 6FtQfuhBG8JAk2n6kun+Jpp7Ot+AveZfxDINVtTB9PQ2IZRLcd1w7RHWUtOcIZZW+URS I/Ig== X-Forwarded-Encrypted: i=1; AJvYcCXf2f/Zd+Qp05orYMU3DaCzMagtdfb+y4V258FuErw3dw4/Z+9hCAotRoGcZ0CWvVeGgQkX31OsU0Y2Kdk=@vger.kernel.org X-Gm-Message-State: AOJu0YwFOQaiH9S0Qov+QuhddkuQeLAY7bygDqMwJaf04KKh39gUS8lz Q4oNoM7wjNTLPOFJgtiTmMDqnGbKYNWhnhgkX0SZLYeo40kSZ7AP00Xt4tpgLqM1STA= X-Gm-Gg: ASbGncv2bdtAQ+Z6u3ReT4JHcuW0Zlza7vbZ9yyCiB+IbSV/rnAI50PDC5iExxYDyXZ sxvkFBpI+En16pUxO7rH1viMd8lla4N8huEVJWmjQops3Btc1LOsxZa8zXLBBfTL553K4kVpmMo tMrEgRb2rCJCnQqRGC1ygBsbJO7DoSziXs12FpAiwEfzNrxijVn6ujILAXTJb3jJsSiO5eEHWJz Cykkbj5HCAxMLFrp+IhqyF6TYxFcRGOPsdcPpHVegSeAiGsB9uJ+Kw48sqBXbKV/1U5ihN63BbH rK5hFJTljot6cdD0Hv1+AbD/o8/COxJ40gX9mvvU4RMZB016KF/qDivV4+7oy/wzInjZ6ctyBZN caD2RhKHX3g== X-Google-Smtp-Source: AGHT+IGd9CKACvtLyrQHHdrX6nttBshhd3uTSHt7m/xqpIEz2JTGn2U407DsxW/ZcIqykVDLTwW6Yg== X-Received: by 2002:a05:6000:250e:b0:3b7:8268:8335 with SMTP id ffacd0b85a97d-3c5dcc0dd86mr22855026f8f.42.1756496034796; Fri, 29 Aug 2025 12:33:54 -0700 (PDT) Received: from localhost ([177.94.120.255]) by smtp.gmail.com with UTF8SMTPSA id 3f1490d57ef6-e9847da0a06sm981166276.18.2025.08.29.12.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Aug 2025 12:33:54 -0700 (PDT) From: =?utf-8?B?UmljYXJkbyBCLiBNYXJsacOocmU=?= Date: Fri, 29 Aug 2025 16:33:49 -0300 Subject: [PATCH] selftests/bpf: Fix count write in testapp_xdp_metadata_copy() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250829-selftests-bpf-xsk_regression_fix-v1-1-5f5acdb9fe6b@suse.com> X-B4-Tracking: v=1; b=H4sIAJwAsmgC/x2N2wqDMBBEf0X2uQEberO/UkpIdKKhJcpuKAHx3 7v6sswZmLMrCThB6NmsxPglSXNWOJ8a6iefR5g0KJNt7bV92M4IvrFAipiwRFPl4xgjQ/ahi6m a2/0y2M5CryfVLAytjxevt3LwAhPY537axbsloxYXZz4CbdsfmUQplpYAAAA= X-Change-ID: 20250829-selftests-bpf-xsk_regression_fix-674d292e4d2a To: =?utf-8?q?Bj=C3=B6rn_T=C3=B6pel?= , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Stanislav Fomichev , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Tushar Vyavahare Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Ricardo_B=2E_Marli=C3=A8re?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2049; i=rbm@suse.com; h=from:subject:message-id; bh=OArcrcPJKctf7kyzhyu5N9o4Z5m1mtDS835/OiICaDA=; b=owEBiQJ2/ZANAwAIAckLinxjhlimAcsmYgBosgCeMkw0JmQH1sVx8Ie24sG2wxN+m6s3zrnNT QJL2G/SuGiJAk8EAAEIADkWIQQDCo6eQk7jwGVXh+HJC4p8Y4ZYpgUCaLIAnhsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMSwyLDIACgkQyQuKfGOGWKbbOg//aeQgH/RaZl6hnKGr9Y4sJQ8C7y5Ef9L pKIgXrcSFWHne+BBmxu20oK8ZUuAD25iR5lKX3D/11k5ybUB4SlP0+QLrSfdHIOv0chE+ughqDs gw3jWuyAeA9v8soWdvIyH626+aeT1rE401v1cfeO6C6Hs+CRHYoevxGB6vDeQ2BAWC2hGJ7ZT7A 7PoiE5qzR7WeKuECK5A+lSTk0dpt2Pa+tOwAmed4Vs/spWNEhVk/qV3o2cRzZ7p/5i9T7JHQCBT 89EzHrHG9UlfryoKgUh5e0PZqSblqEdtMg1dK0+hX2HgDUGkt3Z0TkcA8/kwwBjEQC0zGiOuI8h Rdf7qbl7f1h+K/xChY0/T6ovJArR+UCT3RVlglJwvBkiNze5emFqIvSHZNpL/kknbCnNAir/lVe y2VA17wsd8OgDpQDLtkLNVYxXr4FBA8EDHSDOp/rKHJnUyLOLUOEEp2U7oyGLSltha9L2T1qKyY jQ0QShWjWnRfcWTz/1XFLaHiWUOVnAWZ2g8N3WP6VfUenbAq42bS4CGtzTOj3xJpULNOhBWISjU gd4B+yycWRArtnKg9wcdiDCaIhW+aU5+PAQyX3kdZnSLdfzrmaq+PV0p2esjLFZpqFjxV44Fn/B Wb9CB7BGcbz0m96feLJdcU6jjQVeWByWzq1G7Jm9M8vJ7zg1q4zE= X-Developer-Key: i=rbm@suse.com; a=openpgp; fpr=030A8E9E424EE3C0655787E1C90B8A7C638658A6 Commit 4b302092553c ("selftests/xsk: Add tail adjustment tests and support check") added a new global to xsk_xdp_progs.c, but left out the access in the testapp_xdp_metadata_copy() function. Since bpf_map_update_elem() will write to the whole bss section, it gets truncated. Fix by writing to skel_rx->bss->count directly. Fixes: 4b302092553c ("selftests/xsk: Add tail adjustment tests and support = check") Signed-off-by: Ricardo B. Marli=C3=A8re --- tools/testing/selftests/bpf/xskxceiver.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/tools/testing/selftests/bpf/xskxceiver.c b/tools/testing/selft= ests/bpf/xskxceiver.c index a29de0713f19f05ef49a52e3824bb58a30565e87..352adc8df2d1cd777c823c5a89f= 1720ee043f342 100644 --- a/tools/testing/selftests/bpf/xskxceiver.c +++ b/tools/testing/selftests/bpf/xskxceiver.c @@ -2276,25 +2276,13 @@ static int testapp_xdp_metadata_copy(struct test_sp= ec *test) { struct xsk_xdp_progs *skel_rx =3D test->ifobj_rx->xdp_progs; struct xsk_xdp_progs *skel_tx =3D test->ifobj_tx->xdp_progs; - struct bpf_map *data_map; - int count =3D 0; - int key =3D 0; =20 test_spec_set_xdp_prog(test, skel_rx->progs.xsk_xdp_populate_metadata, skel_tx->progs.xsk_xdp_populate_metadata, skel_rx->maps.xsk, skel_tx->maps.xsk); test->ifobj_rx->use_metadata =3D true; =20 - data_map =3D bpf_object__find_map_by_name(skel_rx->obj, "xsk_xdp_.bss"); - if (!data_map || !bpf_map__is_internal(data_map)) { - ksft_print_msg("Error: could not find bss section of XDP program\n"); - return TEST_FAILURE; - } - - if (bpf_map_update_elem(bpf_map__fd(data_map), &key, &count, BPF_ANY)) { - ksft_print_msg("Error: could not update count element\n"); - return TEST_FAILURE; - } + skel_rx->bss->count =3D 0; =20 return testapp_validate_traffic(test); } --- base-commit: 5b6d6fe1ca7b712c74f78426bb23c465fd34b322 change-id: 20250829-selftests-bpf-xsk_regression_fix-674d292e4d2a Best regards, --=20 Ricardo B. Marli=C3=A8re