From nobody Fri Oct 3 16:42:43 2025 Received: from mail-yw1-f225.google.com (mail-yw1-f225.google.com [209.85.128.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 701A6313E2D for ; Thu, 28 Aug 2025 13:19:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756387152; cv=none; b=LpkYhwoqslDg2/gGHY67c7zmnTSpTL9Bv8zr8D/dtPIITgyd3lF/rM2QgtEC4bPVtSoRy/K+If2LoRzbGoGhxyvwrNEMM+/OzGm8BkVR0nIeJmFJGXkMpgd9FKFlfB6FNrHUfNo89DvRbttUa16dnj1E3doqxPN7uDdzfWcI8Q0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756387152; c=relaxed/simple; bh=H7JoMIILAhGUgjcUXQyHFBWQ8k2DHQByyC1Q5/bQTDQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tCBDbZHFfzwoxdAyMWjC+1su4m/qVX0avJ5Ab9ncKRNSb9xibMb/YCp0n4HlEOk//M4Hepcu2bEJqSH/VmzbpVFVg6vKiexo/vPrQhxNjviOgeZQApzXRAJ+S+hGhQkiPRg3COQxzp8X9/ZLHl5a/Pj6ULRqcY6LCQW08wsJt6M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=aHagub5n; arc=none smtp.client-ip=209.85.128.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="aHagub5n" Received: by mail-yw1-f225.google.com with SMTP id 00721157ae682-71d6014810fso7071477b3.0 for ; Thu, 28 Aug 2025 06:19:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756387148; x=1756991948; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R/9NtnykLFlbdwq/BFwbqCg1JY7GaLggRNo0Kw7S3VI=; b=HjFToYtRRLiv9c1gzR8HLlCFrprWEk0pvd1Q4MgS0Qkq6MCqTCK6xcvPauA30Gs/iC GUArntIOtXUdESd4oOBkDxzHVDlHjnXGueuss51v3Xo3y5p+tuBth1Z/SLR5j+I+PWm+ e6z6YidzO5lEqprpoInK1e8BWeUzpMWTAQmqwEe9R0LC/5m1NpXJCreo6HFK/05uyD3Q UNMi6UTmjelva/RTT0hDGfYlvHL05+sssIP3xIcGOjdzgPY01r0YVUyDvmkqXv+Itgj0 o6TduHPg6gXT84D9x4nqU7yftetrAcp39g8NI99YhzDZPojVAHNrd0R65A8TQxxA6gsT aS0Q== X-Forwarded-Encrypted: i=1; AJvYcCXwLMg0FrvPp7udTbzzXgS7aZT8CWViQ3zAGea1hWgY2O5U9imySDq5plCtDM9qnvf/opegK+uqGPxvgaY=@vger.kernel.org X-Gm-Message-State: AOJu0YyVZJdeUURzyBMftnkchvYKWv+bmG9WMZhRQKAcsnr6fGN9ucf5 /rJP8p8UCSl18drJaQilLzDD20ByAm/EP5B5qXz2gCLcB4CBYNFlZHQBEsIlOa0a4w8siiM3zEJ UqAWMr4nliadEeXsyskKHqSFT99VZdEBeUIRtcCQQ7QOJ624ByGyvOCNxzjfNyQIGzzL+gUlXYT 22CGSvHyXvHY6pRjoGC4NPBlB5a5xDot3yTcho/lOWvUgdkV9dY9KYPvRpfor8B0ZTkrwqrfXOU IrFOOvsNNPPWeSM1DDqsGBI6g== X-Gm-Gg: ASbGnctVY3vFyNawsuMcM5pCebgHRCMN2wfPvjUNi7H3WueTvd0kA4C23hNkh77D+bD UyNpLuEQsN7d4G5p+0JgBXF93CV4HzDKoIYfxB+7VK0PVvvOHQTsgpz69WvKZTZFRHtpX4wAfVj hErI8jpywTlMD2zuCMBtpMEYk80CGs7/T8WrPIDyJO0HuhtEaPsrWZcglL/mB4rH6TsxRDF/w/E U/EECIbjHG4CgeDAWC5BLuhFVjvn2clxXm8oRpd8icSrlYUPCIk70Fkb7ka0ewqfIMjokUZWVGL 6/tzFo9upTTBBUwm3KzCRZiIm6Q5zkp5H7ehntw76R8AieNel2xyYYcX96S5G8tFYW8k6RWGr9o 3zwVyfpkMn3q9oMN8MEurepr5fmc6kq3gWmvLD05o7+3I6RIsd4oJi9wmn+lC8G5rfjJJ+3TyKH NDy5AKK2rj X-Google-Smtp-Source: AGHT+IG8yfS2NI8OPhywdJp91PjIZNpU9lPHM/urwUAxmn9s2mcJOKLRtbuIpiWnvxYN/Y/6+7/fKTLBjDWp X-Received: by 2002:a05:690c:9c0e:b0:71a:234c:aaa8 with SMTP id 00721157ae682-71fdc2b0946mr283528047b3.2.1756387148089; Thu, 28 Aug 2025 06:19:08 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-100.dlp.protect.broadcom.com. [144.49.247.100]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-71ff16a43a5sm9453047b3.10.2025.08.28.06.19.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Aug 2025 06:19:08 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2445803f0cfso12358035ad.1 for ; Thu, 28 Aug 2025 06:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1756387147; x=1756991947; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R/9NtnykLFlbdwq/BFwbqCg1JY7GaLggRNo0Kw7S3VI=; b=aHagub5newfmYfUftcXrXpTIaVB2prJS3YwIdO5TQYsNTYhkJ4jCxDwR3AeZnvKB6k S4ONQyE24LgTRB0FwP5B48Aug7gM204wo5WW3/B7AtxfVM97AxbtiK7ENBe7+Dy92rgP NUsREo34vhHAXSa+uvOQQI2hAEmMDk/oNHL7g= X-Forwarded-Encrypted: i=1; AJvYcCULbvypCWuyjWo1qoHMZxM/uD2sD8GVDGsamokuS59YIUD4qvr47E/wK+o8uR01fsdksVOicF3XzU3Xrx4=@vger.kernel.org X-Received: by 2002:a17:903:240e:b0:248:df64:ec6a with SMTP id d9443c01a7336-248df64fa0fmr27643645ad.15.1756387146772; Thu, 28 Aug 2025 06:19:06 -0700 (PDT) X-Received: by 2002:a17:903:240e:b0:248:df64:ec6a with SMTP id d9443c01a7336-248df64fa0fmr27643165ad.15.1756387146310; Thu, 28 Aug 2025 06:19:06 -0700 (PDT) Received: from hyd-csg-thor2-h1-server2.dhcp.broadcom.net ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-248b6a16ae3sm36468705ad.137.2025.08.28.06.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Aug 2025 06:19:05 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, Bhargava Marreddy , Vikas Gupta , Rajashekar Hudumula Subject: [v5, net-next 3/9] bng_en: Introduce VNIC Date: Thu, 28 Aug 2025 18:45:41 +0000 Message-ID: <20250828184547.242496-4-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250828184547.242496-1-bhargava.marreddy@broadcom.com> References: <20250828184547.242496-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Add the VNIC-specific structures and DMA memory necessary to support UC/MC and RSS functionality. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 129 ++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 30 ++++ 2 files changed, 159 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index dd56e8b5eee9..59357b89ac29 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -435,6 +435,122 @@ static int bnge_alloc_tx_rings(struct bnge_net *bn) return 0; } =20 +static void bnge_free_vnic_attributes(struct bnge_net *bn) +{ + struct pci_dev *pdev =3D bn->bd->pdev; + struct bnge_vnic_info *vnic; + int i; + + if (!bn->vnic_info) + return; + + for (i =3D 0; i < bn->nr_vnics; i++) { + vnic =3D &bn->vnic_info[i]; + + kfree(vnic->uc_list); + vnic->uc_list =3D NULL; + + if (vnic->mc_list) { + dma_free_coherent(&pdev->dev, vnic->mc_list_size, + vnic->mc_list, vnic->mc_list_mapping); + vnic->mc_list =3D NULL; + } + + if (vnic->rss_table) { + dma_free_coherent(&pdev->dev, vnic->rss_table_size, + vnic->rss_table, + vnic->rss_table_dma_addr); + vnic->rss_table =3D NULL; + } + + vnic->rss_hash_key =3D NULL; + vnic->flags =3D 0; + } +} + +static int bnge_alloc_vnic_attributes(struct bnge_net *bn) +{ + struct bnge_dev *bd =3D bn->bd; + struct bnge_vnic_info *vnic; + int i, rc =3D 0, size; + + for (i =3D 0; i < bn->nr_vnics; i++) { + vnic =3D &bn->vnic_info[i]; + + if (vnic->flags & BNGE_VNIC_UCAST_FLAG) { + int mem_size =3D (BNGE_MAX_UC_ADDRS - 1) * ETH_ALEN; + + if (mem_size > 0) { + vnic->uc_list =3D kmalloc(mem_size, GFP_KERNEL); + if (!vnic->uc_list) { + rc =3D -ENOMEM; + goto out; + } + } + } + + if (vnic->flags & BNGE_VNIC_MCAST_FLAG) { + vnic->mc_list_size =3D BNGE_MAX_MC_ADDRS * ETH_ALEN; + vnic->mc_list =3D + dma_alloc_coherent(bd->dev, + vnic->mc_list_size, + &vnic->mc_list_mapping, + GFP_KERNEL); + if (!vnic->mc_list) { + rc =3D -ENOMEM; + goto out; + } + } + + /* Allocate rss table and hash key */ + size =3D L1_CACHE_ALIGN(BNGE_MAX_RSS_TABLE_SIZE); + + vnic->rss_table_size =3D size + HW_HASH_KEY_SIZE; + vnic->rss_table =3D dma_alloc_coherent(bd->dev, + vnic->rss_table_size, + &vnic->rss_table_dma_addr, + GFP_KERNEL); + if (!vnic->rss_table) { + rc =3D -ENOMEM; + goto out; + } + + vnic->rss_hash_key =3D ((void *)vnic->rss_table) + size; + vnic->rss_hash_key_dma_addr =3D vnic->rss_table_dma_addr + size; + } + + return 0; + +out: + return rc; +} + +static int bnge_alloc_vnics(struct bnge_net *bn) +{ + int num_vnics; + + /* Allocate only 1 VNIC for now + * Additional VNICs will be added based on RFS/NTUPLE in future patches + */ + num_vnics =3D 1; + + bn->vnic_info =3D kcalloc(num_vnics, sizeof(struct bnge_vnic_info), + GFP_KERNEL); + if (!bn->vnic_info) + return -ENOMEM; + + bn->nr_vnics =3D num_vnics; + + return 0; +} + +static void bnge_free_vnics(struct bnge_net *bn) +{ + kfree(bn->vnic_info); + bn->vnic_info =3D NULL; + bn->nr_vnics =3D 0; +} + static void bnge_free_ring_grps(struct bnge_net *bn) { kfree(bn->grp_info); @@ -443,11 +559,13 @@ static void bnge_free_ring_grps(struct bnge_net *bn) =20 static void bnge_free_core(struct bnge_net *bn) { + bnge_free_vnic_attributes(bn); bnge_free_tx_rings(bn); bnge_free_rx_rings(bn); bnge_free_nq_tree(bn); bnge_free_nq_arrays(bn); bnge_free_ring_grps(bn); + bnge_free_vnics(bn); kfree(bn->tx_ring_map); bn->tx_ring_map =3D NULL; kfree(bn->tx_ring); @@ -535,6 +653,10 @@ static int bnge_alloc_core(struct bnge_net *bn) txr->bnapi =3D bnapi2; } =20 + rc =3D bnge_alloc_vnics(bn); + if (rc) + goto err_free_core; + rc =3D bnge_alloc_nq_arrays(bn); if (rc) goto err_free_core; @@ -553,6 +675,13 @@ static int bnge_alloc_core(struct bnge_net *bn) if (rc) goto err_free_core; =20 + bn->vnic_info[BNGE_VNIC_DEFAULT].flags |=3D BNGE_VNIC_RSS_FLAG | + BNGE_VNIC_MCAST_FLAG | + BNGE_VNIC_UCAST_FLAG; + rc =3D bnge_alloc_vnic_attributes(bn); + if (rc) + goto err_free_core; + return 0; =20 err_free_core: diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 8041951da187..7c56786f5a71 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -178,6 +178,8 @@ struct bnge_net { =20 /* grp_info indexed by napi/nq index */ struct bnge_ring_grp_info *grp_info; + struct bnge_vnic_info *vnic_info; + int nr_vnics; int total_irqs; }; =20 @@ -302,4 +304,32 @@ struct bnge_napi { struct bnge_tx_ring_info *tx_ring[BNGE_MAX_TXR_PER_NAPI]; }; =20 +#define INVALID_STATS_CTX_ID -1 +#define BNGE_VNIC_DEFAULT 0 +#define BNGE_MAX_UC_ADDRS 4 + +struct bnge_vnic_info { + u8 *uc_list; + dma_addr_t rss_table_dma_addr; + __le16 *rss_table; + dma_addr_t rss_hash_key_dma_addr; + u64 *rss_hash_key; + int rss_table_size; +#define BNGE_RSS_TABLE_ENTRIES 64 +#define BNGE_RSS_TABLE_SIZE (BNGE_RSS_TABLE_ENTRIES * 4) +#define BNGE_RSS_TABLE_MAX_TBL 8 +#define BNGE_MAX_RSS_TABLE_SIZE \ + (BNGE_RSS_TABLE_SIZE * BNGE_RSS_TABLE_MAX_TBL) + + u8 *mc_list; + int mc_list_size; + int mc_list_count; + dma_addr_t mc_list_mapping; +#define BNGE_MAX_MC_ADDRS 16 + + u32 flags; +#define BNGE_VNIC_RSS_FLAG 1 +#define BNGE_VNIC_MCAST_FLAG 4 +#define BNGE_VNIC_UCAST_FLAG 8 +}; #endif /* _BNGE_NETDEV_H_ */ --=20 2.47.3