From nobody Fri Oct 3 16:38:20 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 021F1341646; Thu, 28 Aug 2025 17:12:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756401175; cv=none; b=k3eLlzElerlPQv9clPaEUGmXMEL4Y6udkjfS9djqevwbnblIjNGFeU/P5S+r80NYVEY6+s2ZcLw39WqTClBQJoLEGlAAiU82A78pP55UnpjzdRzhCK6jMSydI4eTk1ArfT+hKX2wv1k//gV83GzhS/rNQeR47Xf0W0x+QLpcR/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756401175; c=relaxed/simple; bh=BBbyydnwAs+XoNN413vvEKNIDBGc2IkMvtIzus1iybo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Mjk6Y81/LtN8JqrSNXiyUBQYSOOnHg8VS1rNshC5oItF+BWTn8mio+Peu0TgjMIxdv+XgV4Ne88rGR+OV+hbfFZBjG3021uehUYloAaqA7kQ1FaWeRrb3lqvZHRSybkjKyxKt68E55mKp4Xp942Or4CnKiHHUkwdTjnnVgGMZ/k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UH9OD/nH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UH9OD/nH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9F37C4CEEB; Thu, 28 Aug 2025 17:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756401174; bh=BBbyydnwAs+XoNN413vvEKNIDBGc2IkMvtIzus1iybo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UH9OD/nHql8BkKwDV6clvDMyCvuuDAVn4QXQrqdQgRCKAn45/yaH7ZhIXJq4NhQe8 X/tdfyGZamgbpDx/dAKScIx+v2emHEdN2YPtXEJD7YpGWlxqVFmaQ/r9xNyiH2jBAG 7tfe/iEM6vmp3ObBIaU9/2zq+j2SPO5jYkHOJl+imDDd69SJlU75QICwwHm8mDkaTM vhQmWqTFd166GJDhalcloBfgmonSjiB0eKeMruetNgXIqJMhel5N5MIsrUc3vHMhIS cjQh2fUImtoMjxJCuA3kZphZ9QHS4DYyQfPI/w6mGSeqZq2zsYSq8MvZUirLElBHho zoQWAbeUV/arA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Quanmin Yan , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, wangkefeng.wang@huawei.com, zuoze1@huawei.com Subject: [PATCH v3 07/11] mm/damon/sysfs: implement addr_unit file under context dir Date: Thu, 28 Aug 2025 10:12:38 -0700 Message-Id: <20250828171242.59810-8-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250828171242.59810-1-sj@kernel.org> References: <20250828171242.59810-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Only DAMON kernel API callers can use addr_unit parameter. Implement a sysfs file to let DAMON sysfs ABI users use it. Additionally, addr_unit must be set to a non-zero value. Signed-off-by: SeongJae Park Signed-off-by: Quanmin Yan Reviewed-by: SeongJae Park --- mm/damon/sysfs.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index 6d2b0dab50cb..98bf15d403b2 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -834,6 +834,7 @@ static const struct damon_sysfs_ops_name damon_sysfs_op= s_names[] =3D { struct damon_sysfs_context { struct kobject kobj; enum damon_ops_id ops_id; + unsigned long addr_unit; struct damon_sysfs_attrs *attrs; struct damon_sysfs_targets *targets; struct damon_sysfs_schemes *schemes; @@ -849,6 +850,7 @@ static struct damon_sysfs_context *damon_sysfs_context_= alloc( return NULL; context->kobj =3D (struct kobject){}; context->ops_id =3D ops_id; + context->addr_unit =3D 1; return context; } =20 @@ -997,6 +999,32 @@ static ssize_t operations_store(struct kobject *kobj, return -EINVAL; } =20 +static ssize_t addr_unit_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct damon_sysfs_context *context =3D container_of(kobj, + struct damon_sysfs_context, kobj); + + return sysfs_emit(buf, "%lu\n", context->addr_unit); +} + +static ssize_t addr_unit_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count) +{ + struct damon_sysfs_context *context =3D container_of(kobj, + struct damon_sysfs_context, kobj); + unsigned long input_addr_unit; + int err =3D kstrtoul(buf, 0, &input_addr_unit); + + if (err) + return err; + if (!input_addr_unit) + return -EINVAL; + + context->addr_unit =3D input_addr_unit; + return count; +} + static void damon_sysfs_context_release(struct kobject *kobj) { kfree(container_of(kobj, struct damon_sysfs_context, kobj)); @@ -1008,9 +1036,13 @@ static struct kobj_attribute damon_sysfs_context_ava= il_operations_attr =3D static struct kobj_attribute damon_sysfs_context_operations_attr =3D __ATTR_RW_MODE(operations, 0600); =20 +static struct kobj_attribute damon_sysfs_context_addr_unit_attr =3D + __ATTR_RW_MODE(addr_unit, 0600); + static struct attribute *damon_sysfs_context_attrs[] =3D { &damon_sysfs_context_avail_operations_attr.attr, &damon_sysfs_context_operations_attr.attr, + &damon_sysfs_context_addr_unit_attr.attr, NULL, }; ATTRIBUTE_GROUPS(damon_sysfs_context); @@ -1397,6 +1429,7 @@ static int damon_sysfs_apply_inputs(struct damon_ctx = *ctx, err =3D damon_select_ops(ctx, sys_ctx->ops_id); if (err) return err; + ctx->addr_unit =3D sys_ctx->addr_unit; err =3D damon_sysfs_set_attrs(ctx, sys_ctx->attrs); if (err) return err; --=20 2.39.5