From nobody Fri Oct 3 15:37:01 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0023B1A5B8B; Thu, 28 Aug 2025 13:33:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756388020; cv=none; b=pWB2bLwZBY+QiGyXdmtNVMzDU1IxdlDKTsFWHJ3aCFT1FjVzspJFMTbZKkBxhlHk/iKoCRDCHuU+9Xm5LT58VuKArpCpPcse+9FJnaSjWXkqFzlNI1t09bwCTiKrXoMG747qtWX4o7PwCu2vr49seXjq9xmIt0CD9mX+olKR0QM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756388020; c=relaxed/simple; bh=AvZ7MAaja1vU90oIimXqqhaRqe3btMk1ANyYmRTsYac=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KhmuPx8LZHfblezHlv0bCWUX1wosoph05HltdY2ggt9QOmtE2n+JBcSp+CfNkUimhoDka+Aox6fgDNtZLD5SNUrP0YhmYcMVOivuXg2NTVXuA0UQT7muwVyLqTe8KuoexvPvVbSbSQpQcp45Nl+CIyvRkTQS16/iXs2QMD5714U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SMVrYIV/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SMVrYIV/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8624C4CEF5; Thu, 28 Aug 2025 13:33:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756388019; bh=AvZ7MAaja1vU90oIimXqqhaRqe3btMk1ANyYmRTsYac=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SMVrYIV/ij41z7MWnpB63VSrkEBLKoCAvsw+nR26v35J5uJ4SSypC1L/pvInGiMV5 Y+lkSYrFC6rU5aeacEb4FcPBod06YUjkz79RCekbdSNjMVr2gZ/H5CEyYQhxv/iVtY E910wjMajmmaCPcK52m6gojq6C4AXs/4MH8cJrneQVvR76cVTzXsBLyMmqzyUGfsTg 9K89OfmiI2ot8+SvkEtMBm8cbeRQc3RYDeFU76Fxamu0w3n/Q/d1CxjNUmt1rSQH/J MGZWgKydvwdZraeP9DykuZ7Ido60gnGDW7eYbAqyuyb61Z0GYRIokoBhheBUuyB/tq tb6q6p6uC6dyw== From: Danilo Krummrich To: akpm@linux-foundation.org, ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, abdiel.janulgue@gmail.com, acourbot@nvidia.com, jgg@ziepe.ca, lyude@redhat.com, robin.murphy@arm.com, daniel.almeida@collabora.com Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Danilo Krummrich Subject: [PATCH v4 1/5] rust: dma: implement DataDirection Date: Thu, 28 Aug 2025 15:32:14 +0200 Message-ID: <20250828133323.53311-2-dakr@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250828133323.53311-1-dakr@kernel.org> References: <20250828133323.53311-1-dakr@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add the `DataDirection` struct, a newtype wrapper around the C `enum dma_data_direction`. This provides a type-safe Rust interface for specifying the direction of DMA transfers. Reviewed-by: Alice Ryhl Reviewed-by: Alexandre Courbot Reviewed-by: Daniel Almeida Reviewed-by: Lyude Paul Signed-off-by: Danilo Krummrich --- rust/bindings/bindings_helper.h | 1 + rust/kernel/dma.rs | 68 +++++++++++++++++++++++++++++++++ 2 files changed, 69 insertions(+) diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helpe= r.h index 0e140e07758b..c2cc52ee9945 100644 --- a/rust/bindings/bindings_helper.h +++ b/rust/bindings/bindings_helper.h @@ -47,6 +47,7 @@ #include #include #include +#include #include #include #include diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs index 2bc8ab51ec28..27b25f041f32 100644 --- a/rust/kernel/dma.rs +++ b/rust/kernel/dma.rs @@ -244,6 +244,74 @@ pub mod attrs { pub const DMA_ATTR_PRIVILEGED: Attrs =3D Attrs(bindings::DMA_ATTR_PRIV= ILEGED); } =20 +/// DMA data direction. +/// +/// Corresponds to the C [`enum dma_data_direction`]. +/// +/// [`enum dma_data_direction`]: srctree/include/linux/dma-direction.h +#[derive(Copy, Clone, PartialEq, Eq, Debug)] +#[repr(u32)] +pub enum DataDirection { + /// The DMA mapping is for bidirectional data transfer. + /// + /// This is used when the buffer can be both read from and written to = by the device. + /// The cache for the corresponding memory region is both flushed and = invalidated. + Bidirectional =3D Self::const_cast(bindings::dma_data_direction_DMA_BI= DIRECTIONAL), + + /// The DMA mapping is for data transfer from memory to the device (wr= ite). + /// + /// The CPU has prepared data in the buffer, and the device will read = it. + /// The cache for the corresponding memory region is flushed before de= vice access. + ToDevice =3D Self::const_cast(bindings::dma_data_direction_DMA_TO_DEVI= CE), + + /// The DMA mapping is for data transfer from the device to memory (re= ad). + /// + /// The device will write data into the buffer for the CPU to read. + /// The cache for the corresponding memory region is invalidated befor= e CPU access. + FromDevice =3D Self::const_cast(bindings::dma_data_direction_DMA_FROM_= DEVICE), + + /// The DMA mapping is not for data transfer. + /// + /// This is primarily for debugging purposes. With this direction, the= DMA mapping API + /// will not perform any cache coherency operations. + None =3D Self::const_cast(bindings::dma_data_direction_DMA_NONE), +} + +impl DataDirection { + /// Casts the bindgen-generated enum type to a `u32` at compile time. + /// + /// This function will cause a compile-time error if the underlying va= lue of the + /// C enum is out of bounds for `u32`. + const fn const_cast(val: bindings::dma_data_direction) -> u32 { + // CAST: The C standard allows compilers to choose different integ= er types for enums. + // To safely check the value, we cast it to a wide signed integer = type (`i128`) + // which can hold any standard C integer enum type without truncat= ion. + let wide_val =3D val as i128; + + // Check if the value is outside the valid range for the target ty= pe `u32`. + // CAST: `u32::MAX` is cast to `i128` to match the type of `wide_v= al` for the comparison. + if wide_val < 0 || wide_val > u32::MAX as i128 { + // Trigger a compile-time error in a const context. + build_error!("C enum value is out of bounds for the target typ= e `u32`."); + } + + // CAST: This cast is valid because the check above guarantees tha= t `wide_val` + // is within the representable range of `u32`. + wide_val as u32 + } +} + +impl From for bindings::dma_data_direction { + /// Returns the raw representation of [`enum dma_data_direction`]. + fn from(direction: DataDirection) -> Self { + // CAST: `direction as u32` gets the underlying representation of = our `#[repr(u32)]` enum. + // The subsequent cast to `Self` (the bindgen type) assumes the C = enum is compatible + // with the enum variants of `DataDirection`, which is a valid ass= umption given our + // compile-time checks. + direction as u32 as Self + } +} + /// An abstraction of the `dma_alloc_coherent` API. /// /// This is an abstraction around the `dma_alloc_coherent` API which is us= ed to allocate and map --=20 2.51.0 From nobody Fri Oct 3 15:37:01 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22AB71553A3; Thu, 28 Aug 2025 13:33:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756388024; cv=none; b=kbqxnlGxPjMvwD1MuPIDd7SENO6fLJskbpMQ62uS754H+ZTvrdOBQH5h9bOcIJp5yB+fuJs4E+rgXeAEvOInOz70V18/U7Jjtvc8MaG0dltroJR7IeZzy59WbKvMc0H33bGjLpcLSfY9H2TGr6/FCo3sKWLuz3GlV5akm69vxIE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756388024; c=relaxed/simple; bh=1eVR8B7I7cMnlhpIgV25ShNPsNcgbDpJApOvTLkQaS0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D0PksXhoL3U/eiNio88+PoF4yTLhG5PmvglGzSJPH3Ob+0ITbvuGXIFaol7Eab9AM1Wt/UskS70y3fw3bfdrDJP6pCTE9LWn/e55xYIY+KKt05nCIOo5PE5JIj/sUvIqtnvnR0TyGco9aX7Y0bzXwcy1UJ1/6ZmJdXA8kwynnxs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=luRaM2bk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="luRaM2bk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E61B4C4CEEB; Thu, 28 Aug 2025 13:33:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756388023; bh=1eVR8B7I7cMnlhpIgV25ShNPsNcgbDpJApOvTLkQaS0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=luRaM2bk63f9kX9DJVHWptxNGnOVZvjUkzhJVvAEDxdicgue7qM9d70PvOi6sxhzl tOSD+jQ/mEWh39bvXRwqwRJ2zxh9Ry6waeDiDYLIwamxnlOPdyhwak7I4qWmZ4R9nx hfWa5qvqzYNL9p089XGen9Ctd1hFBOdAxQPm7c8zeTDRnCwp2QOInfalRlImMhz/sl Cg/nJUvzHztIEXBvz8wx9fwH1CYwp0cN/OHmlkXin3Lyn/t5ij2MVOyO+MdJFLFtCP 4xJ1++bEC03iNRel0RyqlQlmOgjy/qcPNNkat3cLfsPgNBaQ+xtZ805YyEAvOEE0vR FB/6EX77FFTSw== From: Danilo Krummrich To: akpm@linux-foundation.org, ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, abdiel.janulgue@gmail.com, acourbot@nvidia.com, jgg@ziepe.ca, lyude@redhat.com, robin.murphy@arm.com, daniel.almeida@collabora.com Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Danilo Krummrich Subject: [PATCH v4 2/5] rust: dma: add type alias for bindings::dma_addr_t Date: Thu, 28 Aug 2025 15:32:15 +0200 Message-ID: <20250828133323.53311-3-dakr@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250828133323.53311-1-dakr@kernel.org> References: <20250828133323.53311-1-dakr@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a type alias for bindings::dma_addr_t (DmaAddress), such that we do not have to access bindings directly. Reviewed-by: Alice Ryhl Reviewed-by: Alexandre Courbot Reviewed-by: Daniel Almeida Reviewed-by: Lyude Paul Suggested-by: Alice Ryhl Signed-off-by: Danilo Krummrich --- drivers/gpu/nova-core/falcon.rs | 4 ++-- rust/kernel/dma.rs | 18 ++++++++++++++---- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/nova-core/falcon.rs b/drivers/gpu/nova-core/falcon= .rs index 50437c67c14a..aa36ed8c04ed 100644 --- a/drivers/gpu/nova-core/falcon.rs +++ b/drivers/gpu/nova-core/falcon.rs @@ -4,8 +4,8 @@ =20 use core::ops::Deref; use hal::FalconHal; -use kernel::bindings; use kernel::device; +use kernel::dma::DmaAddress; use kernel::prelude::*; use kernel::time::Delta; use kernel::types::ARef; @@ -443,7 +443,7 @@ fn dma_wr>( fw.dma_handle_with_offset(load_offsets.src_start as usize)= ?, ), }; - if dma_start % bindings::dma_addr_t::from(DMA_LEN) > 0 { + if dma_start % DmaAddress::from(DMA_LEN) > 0 { dev_err!( self.dev, "DMA transfer start addresses must be a multiple of {}", diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs index 27b25f041f32..b2a6282876da 100644 --- a/rust/kernel/dma.rs +++ b/rust/kernel/dma.rs @@ -13,6 +13,16 @@ types::ARef, }; =20 +/// DMA address type. +/// +/// Represents a bus address used for Direct Memory Access (DMA) operation= s. +/// +/// This is an alias of the kernel's `dma_addr_t`, which may be `u32` or `= u64` depending on +/// `CONFIG_ARCH_DMA_ADDR_T_64BIT`. +/// +/// Note that this may be `u64` even on 32-bit architectures. +pub type DmaAddress =3D bindings::dma_addr_t; + /// Trait to be implemented by DMA capable bus devices. /// /// The [`dma::Device`](Device) trait should be implemented by bus specifi= c device representations, @@ -343,7 +353,7 @@ fn from(direction: DataDirection) -> Self { // entire `CoherentAllocation` including the allocated memory itself. pub struct CoherentAllocation { dev: ARef, - dma_handle: bindings::dma_addr_t, + dma_handle: DmaAddress, count: usize, cpu_addr: *mut T, dma_attrs: Attrs, @@ -444,7 +454,7 @@ pub fn start_ptr_mut(&mut self) -> *mut T { =20 /// Returns a DMA handle which may be given to the device as the DMA a= ddress base of /// the region. - pub fn dma_handle(&self) -> bindings::dma_addr_t { + pub fn dma_handle(&self) -> DmaAddress { self.dma_handle } =20 @@ -452,13 +462,13 @@ pub fn dma_handle(&self) -> bindings::dma_addr_t { /// device as the DMA address base of the region. /// /// Returns `EINVAL` if `offset` is not within the bounds of the alloc= ation. - pub fn dma_handle_with_offset(&self, offset: usize) -> Result { + pub fn dma_handle_with_offset(&self, offset: usize) -> Result { if offset >=3D self.count { Err(EINVAL) } else { // INVARIANT: The type invariant of `Self` guarantees that `si= ze_of:: * count` fits // into a `usize`, and `offset` is inferior to `count`. - Ok(self.dma_handle + (offset * core::mem::size_of::()) as b= indings::dma_addr_t) + Ok(self.dma_handle + (offset * core::mem::size_of::()) as D= maAddress) } } =20 --=20 2.51.0 From nobody Fri Oct 3 15:37:01 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C03130FF37; Thu, 28 Aug 2025 13:33:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756388028; cv=none; b=mM1LoSZ8sxmhLDR+4HA/tndAMjDUDXva8GnWcPb7T25iT1xjmZ2pE6CSjWbCKxgBSeMkE/zhnWojxAOz1el2Y5t2DvQHzOioP9RUs7bh2ukjaFvDft+WodI9YIqGuTmIHUNi/oPdj34SGH0sdpeKejIATs3vW8SN6pmkheCzJcs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756388028; c=relaxed/simple; bh=OycfU14rolhydNbfahfYiuxKkUX1zgvhgCX5P6luYUI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j8dkskMuyUpwG3U2p38rOveTKnIes/UBohd7/7+w68kV5CCPDFwfectP8+IYFOZu486hpP9GhFB3NvChC2GLcsRydTWZeCe2sGz17vZurxyNY5D0iGrZUmI+/Jp7F+y1VzrKgLLHzbqq6k+b+uw7afCTENTZgfh1rLddav9ChfM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KG18BgDc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KG18BgDc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0089FC4CEED; Thu, 28 Aug 2025 13:33:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756388027; bh=OycfU14rolhydNbfahfYiuxKkUX1zgvhgCX5P6luYUI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KG18BgDce7dHkzNrQ+PiPyQbtr/S2PSBJNSY25wTKpkMcnf9T4te/33zzamLPwwt8 b+f1tFbQ5KuYlzJ4lf6Ayycc7CmPEsdQkB3sHONOJlWJ2c0P8k+rfghNh8/7TKriQG TjsO8xwHk38xnJim2kSbczfm9F4Log4pZdCWPMXxOQZ5tUjt6h0n6dHgmrkk/wti1c kosdj9qhNFbk7JODucg74AxxLSx8sMLoTNHiDx2EUBiVp7j3PDJ6GBrwVvjuZvYxPH 6SVme4YO2N1pnfhEAFaHEXomtVmL4+ircYSi6hEKxRZWQBXaTmWZhRmO4jA4PhNCgV q8+EAH1UxPeCA== From: Danilo Krummrich To: akpm@linux-foundation.org, ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, abdiel.janulgue@gmail.com, acourbot@nvidia.com, jgg@ziepe.ca, lyude@redhat.com, robin.murphy@arm.com, daniel.almeida@collabora.com Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Danilo Krummrich Subject: [PATCH v4 3/5] rust: scatterlist: Add abstraction for sg_table Date: Thu, 28 Aug 2025 15:32:16 +0200 Message-ID: <20250828133323.53311-4-dakr@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250828133323.53311-1-dakr@kernel.org> References: <20250828133323.53311-1-dakr@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a safe Rust abstraction for the kernel's scatter-gather list facilities (`struct scatterlist` and `struct sg_table`). This commit introduces `SGTable`, a wrapper that uses a generic parameter to provide compile-time guarantees about ownership and lifetime. The abstraction provides two primary states: - `SGTable>`: Represents a table whose resources are fully managed by Rust. It takes ownership of a page provider `P`, allocates the underlying `struct sg_table`, maps it for DMA, and handles all cleanup automatically upon drop. The DMA mapping's lifetime is tied to the associated device using `Devres`, ensuring it is correctly unmapped before the device is unbound. - `SGTable` (or just `SGTable`): A zero-cost representation of an externally managed `struct sg_table`. It is created from a raw pointer using `SGTable::from_raw()` and provides a lifetime-bound reference (`&'a SGTable`) for operations like iteration. The API exposes a safe iterator that yields `&SGEntry` references, allowing drivers to easily access the DMA address and length of each segment in the list. Reviewed-by: Alice Ryhl Reviewed-by: Alexandre Courbot Tested-by: Alexandre Courbot Reviewed-by: Daniel Almeida Reviewed-by: Lyude Paul Co-developed-by: Abdiel Janulgue Signed-off-by: Abdiel Janulgue Signed-off-by: Danilo Krummrich --- rust/helpers/helpers.c | 1 + rust/helpers/scatterlist.c | 24 ++ rust/kernel/lib.rs | 1 + rust/kernel/scatterlist.rs | 491 +++++++++++++++++++++++++++++++++++++ 4 files changed, 517 insertions(+) create mode 100644 rust/helpers/scatterlist.c create mode 100644 rust/kernel/scatterlist.rs diff --git a/rust/helpers/helpers.c b/rust/helpers/helpers.c index 7cf7fe95e41d..e94542bf6ea7 100644 --- a/rust/helpers/helpers.c +++ b/rust/helpers/helpers.c @@ -39,6 +39,7 @@ #include "rcu.c" #include "refcount.c" #include "regulator.c" +#include "scatterlist.c" #include "security.c" #include "signal.c" #include "slab.c" diff --git a/rust/helpers/scatterlist.c b/rust/helpers/scatterlist.c new file mode 100644 index 000000000000..80c956ee09ab --- /dev/null +++ b/rust/helpers/scatterlist.c @@ -0,0 +1,24 @@ +// SPDX-License-Identifier: GPL-2.0 + +#include + +dma_addr_t rust_helper_sg_dma_address(struct scatterlist *sg) +{ + return sg_dma_address(sg); +} + +unsigned int rust_helper_sg_dma_len(struct scatterlist *sg) +{ + return sg_dma_len(sg); +} + +struct scatterlist *rust_helper_sg_next(struct scatterlist *sg) +{ + return sg_next(sg); +} + +void rust_helper_dma_unmap_sgtable(struct device *dev, struct sg_table *sg= t, + enum dma_data_direction dir, unsigned long attrs) +{ + return dma_unmap_sgtable(dev, sgt, dir, attrs); +} diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs index ed53169e795c..55acbc893736 100644 --- a/rust/kernel/lib.rs +++ b/rust/kernel/lib.rs @@ -113,6 +113,7 @@ pub mod rbtree; pub mod regulator; pub mod revocable; +pub mod scatterlist; pub mod security; pub mod seq_file; pub mod sizes; diff --git a/rust/kernel/scatterlist.rs b/rust/kernel/scatterlist.rs new file mode 100644 index 000000000000..9709dff60b5a --- /dev/null +++ b/rust/kernel/scatterlist.rs @@ -0,0 +1,491 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Abstractions for scatter-gather lists. +//! +//! C header: [`include/linux/scatterlist.h`](srctree/include/linux/scatte= rlist.h) +//! +//! Scatter-gather (SG) I/O is a memory access technique that allows devic= es to perform DMA +//! operations on data buffers that are not physically contiguous in memor= y. It works by creating a +//! "scatter-gather list", an array where each entry specifies the address= and length of a +//! physically contiguous memory segment. +//! +//! The device's DMA controller can then read this list and process the se= gments sequentially as +//! part of one logical I/O request. This avoids the need for a single, la= rge, physically contiguous +//! memory buffer, which can be difficult or impossible to allocate. +//! +//! This module provides safe Rust abstractions over the kernel's `struct = scatterlist` and +//! `struct sg_table` types. +//! +//! The main entry point is the [`SGTable`] type, which represents a compl= ete scatter-gather table. +//! It can be either: +//! +//! - An owned table ([`SGTable>`]), created from a Rust memory b= uffer (e.g., [`VVec`]). +//! This type manages the allocation of the `struct sg_table`, the DMA m= apping of the buffer, and +//! the automatic cleanup of all resources. +//! - A borrowed reference (&[`SGTable`]), which provides safe, read-only = access to a table that was +//! allocated by other (e.g., C) code. +//! +//! Individual entries in the table are represented by [`SGEntry`], which = can be accessed by +//! iterating over an [`SGTable`]. + +use crate::{ + alloc, + alloc::allocator::VmallocPageIter, + bindings, + device::{Bound, Device}, + devres::Devres, + dma, error, + io::resource::ResourceSize, + page, + prelude::*, + types::{ARef, Opaque}, +}; +use core::{ops::Deref, ptr::NonNull}; + +/// A single entry in a scatter-gather list. +/// +/// An `SGEntry` represents a single, physically contiguous segment of mem= ory that has been mapped +/// for DMA. +/// +/// Instances of this struct are obtained by iterating over an [`SGTable`]= . Drivers do not create +/// or own [`SGEntry`] objects directly. +#[repr(transparent)] +pub struct SGEntry(Opaque); + +// SAFETY: `SGEntry` can be sent to any task. +unsafe impl Send for SGEntry {} + +// SAFETY: `SGEntry` has no interior mutability and can be accessed concur= rently. +unsafe impl Sync for SGEntry {} + +impl SGEntry { + /// Convert a raw `struct scatterlist *` to a `&'a SGEntry`. + /// + /// # Safety + /// + /// Callers must ensure that the `struct scatterlist` pointed to by `p= tr` is valid for the + /// lifetime `'a`. + #[inline] + unsafe fn from_raw<'a>(ptr: *mut bindings::scatterlist) -> &'a Self { + // SAFETY: The safety requirements of this function guarantee that= `ptr` is a valid pointer + // to a `struct scatterlist` for the duration of `'a`. + unsafe { &*ptr.cast() } + } + + /// Obtain the raw `struct scatterlist *`. + #[inline] + fn as_raw(&self) -> *mut bindings::scatterlist { + self.0.get() + } + + /// Returns the DMA address of this SG entry. + /// + /// This is the address that the device should use to access the memor= y segment. + #[inline] + pub fn dma_address(&self) -> dma::DmaAddress { + // SAFETY: `self.as_raw()` is a valid pointer to a `struct scatter= list`. + unsafe { bindings::sg_dma_address(self.as_raw()) } + } + + /// Returns the length of this SG entry in bytes. + #[inline] + pub fn dma_len(&self) -> ResourceSize { + #[allow(clippy::useless_conversion)] + // SAFETY: `self.as_raw()` is a valid pointer to a `struct scatter= list`. + unsafe { bindings::sg_dma_len(self.as_raw()) }.into() + } +} + +/// The borrowed generic type of an [`SGTable`], representing a borrowed o= r externally managed +/// table. +#[repr(transparent)] +pub struct Borrowed(Opaque); + +// SAFETY: `Borrowed` can be sent to any task. +unsafe impl Send for Borrowed {} + +// SAFETY: `Borrowed` has no interior mutability and can be accessed concu= rrently. +unsafe impl Sync for Borrowed {} + +/// A scatter-gather table. +/// +/// This struct is a wrapper around the kernel's `struct sg_table`. It man= ages a list of DMA-mapped +/// memory segments that can be passed to a device for I/O operations. +/// +/// The generic parameter `T` is used as a generic type to distinguish bet= ween owned and borrowed +/// tables. +/// +/// - [`SGTable`]: An owned table created and managed entirely by = Rust code. It handles +/// allocation, DMA mapping, and cleanup of all associated resources. S= ee [`SGTable::new`]. +/// - [`SGTable`} (or simply [`SGTable`]): Represents a table w= hose lifetime is managed +/// externally. It can be used safely via a borrowed reference `&'a SGT= able`, where `'a` is the +/// external lifetime. +/// +/// All [`SGTable`] variants can be iterated over the individual [`SGEntry= `]s. +#[repr(transparent)] +#[pin_data] +pub struct SGTable { + #[pin] + inner: T, +} + +impl SGTable { + /// Creates a borrowed `&'a SGTable` from a raw `struct sg_table` poin= ter. + /// + /// This allows safe access to an `sg_table` that is managed elsewhere= (for example, in C code). + /// + /// # Safety + /// + /// Callers must ensure that: + /// + /// - the `struct sg_table` pointed to by `ptr` is valid for the entir= e lifetime of `'a`, + /// - the data behind `ptr` is not modified concurrently for the durat= ion of `'a`. + #[inline] + pub unsafe fn from_raw<'a>(ptr: *mut bindings::sg_table) -> &'a Self { + // SAFETY: The safety requirements of this function guarantee that= `ptr` is a valid pointer + // to a `struct sg_table` for the duration of `'a`. + unsafe { &*ptr.cast() } + } + + #[inline] + fn as_raw(&self) -> *mut bindings::sg_table { + self.inner.0.get() + } + + /// Returns an [`SGTableIter`] bound to the lifetime of `self`. + pub fn iter(&self) -> SGTableIter<'_> { + // SAFETY: `self.as_raw()` is a valid pointer to a `struct sg_tabl= e`. + let nents =3D unsafe { (*self.as_raw()).nents }; + + let pos =3D if nents > 0 { + // SAFETY: `self.as_raw()` is a valid pointer to a `struct sg_= table`. + let ptr =3D unsafe { (*self.as_raw()).sgl }; + + // SAFETY: `ptr` is guaranteed to be a valid pointer to a `str= uct scatterlist`. + Some(unsafe { SGEntry::from_raw(ptr) }) + } else { + None + }; + + SGTableIter { pos, nents } + } +} + +/// Represents the DMA mapping state of a `struct sg_table`. +/// +/// This is used as an inner type of [`Owned`] to manage the DMA mapping l= ifecycle. +/// +/// # Invariants +/// +/// - `sgt` is a valid pointer to a `struct sg_table` for the entire lifet= ime of the +/// [`DmaMappedSgt`]. +/// - `sgt` is always DMA mapped. +struct DmaMappedSgt { + sgt: NonNull, + dev: ARef, + dir: dma::DataDirection, +} + +// SAFETY: `DmaMappedSgt` can be sent to any task. +unsafe impl Send for DmaMappedSgt {} + +// SAFETY: `DmaMappedSgt` has no interior mutability and can be accessed c= oncurrently. +unsafe impl Sync for DmaMappedSgt {} + +impl DmaMappedSgt { + /// # Safety + /// + /// - `sgt` must be a valid pointer to a `struct sg_table` for the ent= ire lifetime of the + /// returned [`DmaMappedSgt`]. + /// - The caller must guarantee that `sgt` remains DMA mapped for the = entire lifetime of + /// [`DmaMappedSgt`]. + unsafe fn new( + sgt: NonNull, + dev: &Device, + dir: dma::DataDirection, + ) -> Result { + // SAFETY: + // - `dev.as_raw()` is a valid pointer to a `struct device`, which= is guaranteed to be + // bound to a driver for the duration of this call. + // - `sgt` is a valid pointer to a `struct sg_table`. + error::to_result(unsafe { + bindings::dma_map_sgtable(dev.as_raw(), sgt.as_ptr(), dir.into= (), 0) + })?; + + // INVARIANT: By the safety requirements of this function it is gu= aranteed that `sgt` is + // valid for the entire lifetime of this object instance. + Ok(Self { + sgt, + dev: dev.into(), + dir, + }) + } +} + +impl Drop for DmaMappedSgt { + #[inline] + fn drop(&mut self) { + // SAFETY: + // - `self.dev.as_raw()` is a pointer to a valid `struct device`. + // - `self.dev` is the same device the mapping has been created fo= r in `Self::new()`. + // - `self.sgt.as_ptr()` is a valid pointer to a `struct sg_table`= by the type invariants + // of `Self`. + // - `self.dir` is the same `dma::DataDirection` the mapping has b= een created with in + // `Self::new()`. + unsafe { + bindings::dma_unmap_sgtable(self.dev.as_raw(), self.sgt.as_ptr= (), self.dir.into(), 0) + }; + } +} + +/// A transparent wrapper around a `struct sg_table`. +/// +/// While we could also create the `struct sg_table` in the constructor of= [`Owned`], we can't tear +/// down the `struct sg_table` in [`Owned::drop`]; the drop order in [`Own= ed`] matters. +#[repr(transparent)] +struct RawSGTable(Opaque); + +// SAFETY: `RawSGTable` can be sent to any task. +unsafe impl Send for RawSGTable {} + +// SAFETY: `RawSGTable` has no interior mutability and can be accessed con= currently. +unsafe impl Sync for RawSGTable {} + +impl RawSGTable { + /// # Safety + /// + /// - `pages` must be a slice of valid `struct page *`. + /// - The pages pointed to by `pages` must remain valid for the entire= lifetime of the returned + /// [`RawSGTable`]. + unsafe fn new( + pages: &mut [*mut bindings::page], + size: usize, + max_segment: u32, + flags: alloc::Flags, + ) -> Result { + // `sg_alloc_table_from_pages_segment()` expects at least one page= , otherwise it + // produces a NPE. + if pages.is_empty() { + return Err(EINVAL); + } + + let sgt =3D Opaque::zeroed(); + // SAFETY: + // - `sgt.get()` is a valid pointer to uninitialized memory. + // - As by the check above, `pages` is not empty. + error::to_result(unsafe { + bindings::sg_alloc_table_from_pages_segment( + sgt.get(), + pages.as_mut_ptr(), + pages.len().try_into()?, + 0, + size, + max_segment, + flags.as_raw(), + ) + })?; + + Ok(Self(sgt)) + } + + #[inline] + fn as_raw(&self) -> *mut bindings::sg_table { + self.0.get() + } +} + +impl Drop for RawSGTable { + #[inline] + fn drop(&mut self) { + // SAFETY: `sgt` is a valid and initialized `struct sg_table`. + unsafe { bindings::sg_free_table(self.0.get()) }; + } +} + +/// The [`Owned`] generic type of an [`SGTable`]. +/// +/// A [`SGTable`] signifies that the [`SGTable`] owns all associate= d resources: +/// +/// - The backing memory pages. +/// - The `struct sg_table` allocation (`sgt`). +/// - The DMA mapping, managed through a [`Devres`]-managed `DmaMappedSgt`. +/// +/// Users interact with this type through the [`SGTable`] handle and do no= t need to manage +/// [`Owned`] directly. +#[pin_data] +pub struct Owned

{ + // Note: The drop order is relevant; we first have to unmap the `struc= t sg_table`, then free the + // `struct sg_table` and finally free the backing pages. + #[pin] + dma: Devres, + sgt: RawSGTable, + _pages: P, +} + +// SAFETY: `Owned` can be sent to any task if `P` can be send to any task. +unsafe impl Send for Owned

{} + +// SAFETY: `Owned` has no interior mutability and can be accessed concurre= ntly if `P` can be +// accessed concurrently. +unsafe impl Sync for Owned

{} + +impl

Owned

+where + for<'a> P: page::AsPageIter =3D VmallocPageIter<'a>> + 'stati= c, +{ + fn new( + dev: &Device, + mut pages: P, + dir: dma::DataDirection, + flags: alloc::Flags, + ) -> Result + '_> { + let page_iter =3D pages.page_iter(); + let size =3D page_iter.size(); + + let mut page_vec: KVec<*mut bindings::page> =3D + KVec::with_capacity(page_iter.page_count(), flags)?; + + for page in page_iter { + page_vec.push(page.as_ptr(), flags)?; + } + + // `dma_max_mapping_size` returns `size_t`, but `sg_alloc_table_fr= om_pages_segment()` takes + // an `unsigned int`. + // + // SAFETY: `dev.as_raw()` is a valid pointer to a `struct device`. + let max_segment =3D match unsafe { bindings::dma_max_mapping_size(= dev.as_raw()) } { + 0 =3D> u32::MAX, + max_segment =3D> u32::try_from(max_segment).unwrap_or(u32::MAX= ), + }; + + Ok(try_pin_init!(&this in Self { + // SAFETY: + // - `page_vec` is a `KVec` of valid `struct page *` obtained = from `pages`. + // - The pages contained in `pages` remain valid for the entir= e lifetime of the + // `RawSGTable`. + sgt: unsafe { RawSGTable::new(&mut page_vec, size, max_segment= , flags) }?, + dma <- { + // SAFETY: `this` is a valid pointer to uninitialized memo= ry. + let sgt =3D unsafe { &raw mut (*this.as_ptr()).sgt }.cast(= ); + + // SAFETY: `sgt` is guaranteed to be non-null. + let sgt =3D unsafe { NonNull::new_unchecked(sgt) }; + + // SAFETY: + // - It is guaranteed that the object returned by `DmaMapp= edSgt::new` won't out-live + // `sgt`. + // - `sgt` is never DMA unmapped manually. + Devres::new(dev, unsafe { DmaMappedSgt::new(sgt, dev, dir)= }) + }, + _pages: pages, + })) + } +} + +impl

SGTable> +where + for<'a> P: page::AsPageIter =3D VmallocPageIter<'a>> + 'stati= c, +{ + /// Allocates a new scatter-gather table from the given pages and maps= it for DMA. + /// + /// This constructor creates a new [`SGTable`] that takes owner= ship of `P`. + /// It allocates a `struct sg_table`, populates it with entries corres= ponding to the physical + /// pages of `P`, and maps the table for DMA with the specified [`Devi= ce`] and + /// [`dma::DataDirection`]. + /// + /// The DMA mapping is managed through [`Devres`], ensuring that the D= MA mapping is unmapped + /// once the associated [`Device`] is unbound, or when the [`SGTable`] is dropped. + /// + /// # Parameters + /// + /// * `dev`: The [`Device`] that will be performing the DMA. + /// * `pages`: The entity providing the backing pages. It must impleme= nt [`page::AsPageIter`]. + /// The ownership of this entity is moved into the new [`SGTable`]. + /// * `dir`: The [`dma::DataDirection`] of the DMA transfer. + /// * `flags`: Allocation flags for internal allocations (e.g., [`GFP_= KERNEL`]). + /// + /// # Examples + /// + /// ``` + /// use kernel::{ + /// device::{Bound, Device}, + /// dma, page, + /// prelude::*, + /// scatterlist::{SGTable, Owned}, + /// }; + /// + /// fn test(dev: &Device) -> Result { + /// let size =3D 4 * page::PAGE_SIZE; + /// let pages =3D VVec::::with_capacity(size, GFP_KERNEL)?; + /// + /// let sgt =3D KBox::pin_init(SGTable::new( + /// dev, + /// pages, + /// dma::DataDirection::ToDevice, + /// GFP_KERNEL, + /// ), GFP_KERNEL)?; + /// + /// Ok(()) + /// } + /// ``` + pub fn new( + dev: &Device, + pages: P, + dir: dma::DataDirection, + flags: alloc::Flags, + ) -> impl PinInit + '_ { + try_pin_init!(Self { + inner <- Owned::new(dev, pages, dir, flags)? + }) + } +} + +impl

Deref for SGTable> { + type Target =3D SGTable; + + #[inline] + fn deref(&self) -> &Self::Target { + // SAFETY: + // - `self.inner.sgt.as_raw()` is a valid pointer to a `struct sg_= table` for the entire + // lifetime of `self`. + // - The backing `struct sg_table` is not modified for the entire = lifetime of `self`. + unsafe { SGTable::from_raw(self.inner.sgt.as_raw()) } + } +} + +mod private { + pub trait Sealed {} + + impl Sealed for super::Borrowed {} + impl

Sealed for super::Owned

{} +} + +/// An [`Iterator`] over the DMA mapped [`SGEntry`] items of an [`SGTable`= ]. +/// +/// Note that the existence of an [`SGTableIter`] does not guarantee that = the [`SGEntry`] items +/// actually remain DMA mapped; they are prone to be unmapped on device un= bind. +pub struct SGTableIter<'a> { + pos: Option<&'a SGEntry>, + /// The number of DMA mapped entries in a `struct sg_table`. + nents: c_uint, +} + +impl<'a> Iterator for SGTableIter<'a> { + type Item =3D &'a SGEntry; + + fn next(&mut self) -> Option { + let entry =3D self.pos?; + self.nents =3D self.nents.saturating_sub(1); + + // SAFETY: `entry.as_raw()` is a valid pointer to a `struct scatte= rlist`. + let next =3D unsafe { bindings::sg_next(entry.as_raw()) }; + + self.pos =3D (!next.is_null() && self.nents > 0).then(|| { + // SAFETY: If `next` is not NULL, `sg_next()` guarantees to re= turn a valid pointer to + // the next `struct scatterlist`. + unsafe { SGEntry::from_raw(next) } + }); + + Some(entry) + } +} --=20 2.51.0 From nobody Fri Oct 3 15:37:01 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B113312801; Thu, 28 Aug 2025 13:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756388032; cv=none; b=fMoPDeojyqoet2aaM2kJahvCGth/0bsJSa3Wo6+D98gPFraIXwLFQ/nYhCQljOrh7ysepJSgf11wTn0gAUWfzPG39TADaNx6Ck0NtEUQIR0xp5llRNNwiWTHx4o+yXWyT0qw7CV6yVJeZkb7ztkzNuroKOdVcAv06hTsPwH2yWQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756388032; c=relaxed/simple; bh=VEhwm2ECodQvAWIjeH0MwqDVbP+hyzKhO930qjxxU1A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LQfw8V675D9Xt6ZG8SIZMiJdcWSHyPuJDoiGaBqCN9pCwfCNCE/Llwy+xVUXdFVqPs9nw6wu65GkJaYjq5wDH5ralXVakmNBXg1Lq0g5OG8q74CEmiIUe9v37/NZNVHUDmoYWspGJN4NBzJ5FTQftWcFflaO2bWMno1vZDFr4wI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DKFmqw4v; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DKFmqw4v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FE53C4CEEB; Thu, 28 Aug 2025 13:33:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756388031; bh=VEhwm2ECodQvAWIjeH0MwqDVbP+hyzKhO930qjxxU1A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DKFmqw4vHZE3XIx4IzYfKMHP+tE7nV74nfHX6QUmksGkulG5Hf4D4SUcGuIoXxCbO u3/9SoGDwdfE1dj1sQvhZqEdCm08XSER6Rspz3CvV5rb/cDUBue8AiiT0UTI7J9BFW MwjpcyrHY8DE/CE04AZ0kvuaHbfRecJzzzTf1tNGVpcoOO0sr6QGzDR+yg2WlGz60a jngBes+6Ca0otclavUZXmic8LDttT7uST2iko5URrjIA0PE+iTVCfm2d3rL4tMprnl EWmciYqXvvJyTfhoq7F6TRfQTDKf3ZH7qwvrkaYPlOmqhKHXfbfatHZNtzDp2rg+dy BUw5FMi0H4daA== From: Danilo Krummrich To: akpm@linux-foundation.org, ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, abdiel.janulgue@gmail.com, acourbot@nvidia.com, jgg@ziepe.ca, lyude@redhat.com, robin.murphy@arm.com, daniel.almeida@collabora.com Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Danilo Krummrich Subject: [PATCH v4 4/5] samples: rust: dma: add sample code for SGTable Date: Thu, 28 Aug 2025 15:32:17 +0200 Message-ID: <20250828133323.53311-5-dakr@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250828133323.53311-1-dakr@kernel.org> References: <20250828133323.53311-1-dakr@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add sample code for allocating and mapping a scatter-gather table (`SGTable`). Reviewed-by: Alexandre Courbot Reviewed-by: Daniel Almeida Reviewed-by: Lyude Paul Co-developed-by: Abdiel Janulgue Signed-off-by: Abdiel Janulgue Signed-off-by: Danilo Krummrich Reviewed-by: Alice Ryhl --- samples/rust/rust_dma.rs | 35 ++++++++++++++++++++++++++--------- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git a/samples/rust/rust_dma.rs b/samples/rust/rust_dma.rs index c5e7cce68654..04007e29fd85 100644 --- a/samples/rust/rust_dma.rs +++ b/samples/rust/rust_dma.rs @@ -7,15 +7,19 @@ use kernel::{ bindings, device::Core, - dma::{CoherentAllocation, Device, DmaMask}, - pci, + dma::{CoherentAllocation, DataDirection, Device, DmaMask}, + page, pci, prelude::*, + scatterlist::{Owned, SGTable}, types::ARef, }; =20 +#[pin_data(PinnedDrop)] struct DmaSampleDriver { pdev: ARef, ca: CoherentAllocation, + #[pin] + sgt: SGTable>>, } =20 const TEST_VALUES: [(u32, u32); 5] =3D [ @@ -70,21 +74,30 @@ fn probe(pdev: &pci::Device, _info: &Self::IdInfo= ) -> Result) { + let dev =3D self.pdev.as_ref(); + + dev_info!(dev, "Unload DMA test driver.\n"); =20 for (i, value) in TEST_VALUES.into_iter().enumerate() { let val0 =3D kernel::dma_read!(self.ca[i].h); @@ -99,6 +112,10 @@ fn drop(&mut self) { assert_eq!(val1, value.1); } } + + for (i, entry) in self.sgt.iter().enumerate() { + dev_info!(dev, "Entry[{}]: DMA address: {:#x}", i, entry.dma_a= ddress()); + } } } =20 --=20 2.51.0 From nobody Fri Oct 3 15:37:01 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27E7D1D5150; Thu, 28 Aug 2025 13:33:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756388036; cv=none; b=uXTLBpqNyxsxOKcD1qa4uLAU+g7q3dqnZS0Scun3WQk3iUyBAZKmGY6dNfI9Pmq+WIaO32Bdv6XLF6U2mJ9gbd3nOYpRzK7ey3HWk0sZQmdhdaU0pwCT6Cbu609TDDYNCUojHkLMmMmr1OcKMCcx+DpxpmIz2OU4tDxZ9ZQ5nXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756388036; c=relaxed/simple; bh=yR4vSi5k8JEVq7aDA45SJHV0W+6kRG5djMrcwSLEFzk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oGiFGJdviZx8rzW4n1eJ2sM/Fl1eSvoX43BqeZfy4uhjmt4Cd1hH3M5tr61Oyi8it3Gu09ljxCIj/0Fb1IRal2gr34nmdtQ+WYIIMkzGRgxAIUNJaWpF+7pCvc4Qzagz1DhGV7VhhpJLU3aB9oHIezOyZFJ5XI5OIe3eXJTU9sA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tufBIF0c; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tufBIF0c" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DDAEC4CEED; Thu, 28 Aug 2025 13:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756388035; bh=yR4vSi5k8JEVq7aDA45SJHV0W+6kRG5djMrcwSLEFzk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tufBIF0cGNzlNoU2ZMC4o1c8khlWEr2mM7SKrAoh4FpFzQ2qigODozUjtVO6Q7HtA 242xRCMpuAioK6trHHP2pkZaPdQWHzQ9xJGSP55p+YAliVd8IhSS2D+n6TN43OIXb7 OOHB7RA2qOvr26E5v7S7/AyPftwc8LcuPzyYojItKfiYCrPKMmCQT9HSVYddPuHLFG lDNK7bOTOD1JHIRQJNDbVfBnLFQuihBdqtSu8B9itP6UFvIgGWARg2JT/3YegIyoRu VPQgb+Wf7dKzsLtaIsD33oFpIMQcRMyRaEqlyQhQ+TLDOgvz00Lzp6S3IPTZtgaAOg 1HWTtQ1nJF35w== From: Danilo Krummrich To: akpm@linux-foundation.org, ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, abdiel.janulgue@gmail.com, acourbot@nvidia.com, jgg@ziepe.ca, lyude@redhat.com, robin.murphy@arm.com, daniel.almeida@collabora.com Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Danilo Krummrich Subject: [PATCH v4 5/5] MAINTAINERS: rust: dma: add scatterlist files Date: Thu, 28 Aug 2025 15:32:18 +0200 Message-ID: <20250828133323.53311-6-dakr@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250828133323.53311-1-dakr@kernel.org> References: <20250828133323.53311-1-dakr@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the "DMA MAPPING HELPERS DEVICE DRIVER API [RUST]" maintainers entry to "DMA MAPPING & SCATTERLIST API [RUST]" and add the corresponding scatterlist files. Reviewed-by: Lyude Paul Acked-by: Miguel Ojeda Signed-off-by: Danilo Krummrich --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index fe168477caa4..65f676b2c304 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7238,7 +7238,7 @@ F: include/linux/dma-mapping.h F: include/linux/swiotlb.h F: kernel/dma/ =20 -DMA MAPPING HELPERS DEVICE DRIVER API [RUST] +DMA MAPPING & SCATTERLIST API [RUST] M: Abdiel Janulgue M: Danilo Krummrich R: Daniel Almeida @@ -7249,7 +7249,9 @@ S: Supported W: https://rust-for-linux.com T: git https://github.com/Rust-for-Linux/linux.git alloc-next F: rust/helpers/dma.c +F: rust/helpers/scatterlist.c F: rust/kernel/dma.rs +F: rust/kernel/scatterlist.rs F: samples/rust/rust_dma.rs =20 DMA-BUF HEAPS FRAMEWORK --=20 2.51.0