From nobody Fri Oct 3 16:41:51 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FF6A2E8882 for ; Thu, 28 Aug 2025 10:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756376129; cv=none; b=X2uHhv5P3o8La0ue/lntuW5gkwVdNK8ikkfDOsxNI2oZjyqHUjZzdt5YjLdOBFVnSV8634dp4I7PEn+DtRUnYqSK3iWEH1jgKsyvBgSaggmyAsG5MUtRdsHYoQ48iIIXtfk54QQ/1vxIgcAprXNQiQkyITcipeqKukolg+zZm8M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756376129; c=relaxed/simple; bh=xyKYNfQ/SYdt2+/QXl/uiVJkm+ZD9FCpFhATvHlCaY4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QQqHQQYY8C7/1QxbXwtr+CnQOV0SxEQGf3g/kmk2mrOFfGBiZAtFzPkIUYPVkUb/If2acZ+ngGjV2PwV8a3cOx8IcmOS6lxZlW6Ya2NYHjaqs6B+P891pj8UuRu/5/inHZwF3dOqZljaJMn2VZez7eREBHqo1MkuGaf+fLvE/cg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uarylZE7; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uarylZE7" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-45b55ed86b9so3862915e9.0 for ; Thu, 28 Aug 2025 03:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756376125; x=1756980925; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GF7goOQZfjJy/n1Nlvaz/a0ipflIe4W5tqv+WNMdl/E=; b=uarylZE7asKDXui7KS0hpucZJh0M7GliwSvhiLCeDH1zXNj3rdHbLA8rHXjaTbcQVr 96rl3XNCNh9Bx5nZBIHcqrnWgHNxDN2Xf3ed16D1SaT1GxD3uUnzEGpn0VkTqgGHlvud WR2Hu42VQN12B0oRdYwG28IdN7jSsqJtvFIDclyj+vCqiJlkrIqFEpBxiyG45mS+yuSZ fSPMBhHEpt9Gizq4hJulRNa3Xd2p2Yuf/wrhwQULYcj1qVENi8cY8wrFFkl0br/rVgcH f1mrswZpSycZfmt9XbmetwkwjgSvX1bJqVVmIo4/t5yK5178uhjxe9piEdJ2xB5ZG5CY wo0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756376125; x=1756980925; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GF7goOQZfjJy/n1Nlvaz/a0ipflIe4W5tqv+WNMdl/E=; b=pq6LpIlBZBZgKT1SaN3wCYhhMo6sLd0yoWCJXbN6rbe7huFVRudKYq5I4PQj/L+JQZ RPOZatElS19IWZCQ91p+L6YVjnjEoHyho6KYnC3nxeb5eNFszelqNlEQGUzMf6Ra01/N mXEBWWM9agGB4LMF33l5/9lNR1/zF8visdKhfgDBUYZg0sgzHHyTNPZ2SUA98baEE+Ul 6AQafaiO1mGNGbf5m3/8MLsH4ZWRj84tsCTrRiJg2IJMn5SIh46pFTU36w2IaVk7s9Xj 2Z44V5m6rHaECCdx4J1/UmpiPX/9BQFiC5M7XNjLdOSekys+Vwo6IbDITJC7KHjyoOkD Zafg== X-Forwarded-Encrypted: i=1; AJvYcCVUnc9kGLDmtjmMYle+YDbabrPv7EesjereYeRz8aZHp7uiPwza8WpvQNB3NhZLaQnJvN4G+QhFjiThqr8=@vger.kernel.org X-Gm-Message-State: AOJu0YxoFC6Cg9whxfAkSfItuoH6ub9HRWNVSMn7Q2gb3w7GjgzwleOi aWrySGMBnWDZxqeeDWv6gM/76bhoA8MExgu7Gct8NJL6OVmIG3/wTtHbNtdBeTOQ7aM= X-Gm-Gg: ASbGncvWeJylrwqdU25su+yYZi84O0P2qwhyG+ug8P8EsLrv6P9kFRyRlYLEDE+9K/T jFtfUFbJAAX0DGiRol0ysY0BXw3SdJ9VE2yxgar/cp5BCyT7om6764lcA/VP1BJEfjEHbp9kBgi 38YJy6zdV88ybQBWCcNW1PcXkh/8X4hpHmlg/yaR6Y2k8oP0CvXExhYW0DSvXXuyiRWoygatVBd 7xPJrbYufyYwlUAU3M+pCQtldc/N5yj3Skj/WnqSbOeiMftqXaXGOazJ22n8VMODCmOfqW6RjBu eVDl6LgqberROKt+Y8X+fadXku6ns4bBulmQzEXult+8lDAEIL4v3U4DPCBHHS45RFoDhNR6GKN 0/lfwELjbCYVNkel5lGpcvFj6VdtVrNKtxylK/0ngKQ== X-Google-Smtp-Source: AGHT+IGEnzU63OfzICnb/K9gMn/j3/S0WtT5qqEXBUUstBaHlJHuR/FdnvKe65O/hXpHlmO922euyg== X-Received: by 2002:a05:600c:1c17:b0:45b:72a6:4861 with SMTP id 5b1f17b1804b1-45b72a64b3dmr50996335e9.24.1756376125382; Thu, 28 Aug 2025 03:15:25 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b66f2041fsm49976305e9.5.2025.08.28.03.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Aug 2025 03:15:25 -0700 (PDT) From: James Clark Date: Thu, 28 Aug 2025 11:14:40 +0100 Subject: [PATCH v2 1/9] spi: spi-fsl-lpspi: Fix transmissions when using CONT Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250828-james-nxp-lpspi-v2-1-6262b9aa9be4@linaro.org> References: <20250828-james-nxp-lpspi-v2-0-6262b9aa9be4@linaro.org> In-Reply-To: <20250828-james-nxp-lpspi-v2-0-6262b9aa9be4@linaro.org> To: Frank Li , Mark Brown , Clark Wang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com Cc: James Clark , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.0 From: Larisa Grigore Commit 6a130448498c ("spi: lpspi: Fix wrong transmission when don't use CONT") breaks transmissions when CONT is used. The TDIE interrupt should not be disabled in all cases. If CONT is used and the TX transfer is not yet completed yet, but the interrupt handler is called because there are characters to be received, TDIE is replaced with FCIE. When the transfer is finally completed, SR_TDF is set but the interrupt handler isn't called again. Fixes: 6a130448498c ("spi: lpspi: Fix wrong transmission when don't use CON= T") Signed-off-by: Larisa Grigore Signed-off-by: James Clark Reviewed-by: Frank Li --- drivers/spi/spi-fsl-lpspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 313e444a34f3..eaa6bade61a6 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -3,7 +3,7 @@ // Freescale i.MX7ULP LPSPI driver // // Copyright 2016 Freescale Semiconductor, Inc. -// Copyright 2018 NXP Semiconductors +// Copyright 2018, 2023, 2025 NXP =20 #include #include @@ -785,7 +785,7 @@ static irqreturn_t fsl_lpspi_isr(int irq, void *dev_id) if (temp_SR & SR_MBF || readl(fsl_lpspi->base + IMX7ULP_FSR) & FSR_TXCOUNT) { writel(SR_FCF, fsl_lpspi->base + IMX7ULP_SR); - fsl_lpspi_intctrl(fsl_lpspi, IER_FCIE); + fsl_lpspi_intctrl(fsl_lpspi, IER_FCIE | (temp_IER & IER_TDIE)); return IRQ_HANDLED; } =20 --=20 2.34.1