From nobody Fri Oct 3 15:37:03 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9B4F224891 for ; Fri, 29 Aug 2025 00:38:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756427939; cv=none; b=T7/3mhUEebgeN48+/ttTFgXI/aI4CRD/Gv+yFwBRtZNXp7JTHC6ndWurkdwgWdpup4uFfnHBZ6+fxCF73ZYhZO+SVAjXZfjpP4KPOzgQD4ZEiqdkgYJq+KOo4GGWLXWccc+y19dEoNuwMYJpgX/B8mhJ5cJkTNvH4OL5+4DKy8U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756427939; c=relaxed/simple; bh=WJxAzEZ/y8gMiDjK9rGa4K/3JOojl4uHZ0X5uecFxfU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dalpQqV4DuyyfT9JxW0tRsKwaxEF7Ly94nTiyDVMgNbQyUJ7tdMZ0EauHnm1sFFpLPr5w1enAtc4hxxLHmtqbPBf40OUqunqfgN21vfgUUIw1stbwxpWOOkQAcWgZDVPSmLuSeSVNdkfyfln+vJPgBg76HAEv6vVIq/gPR9W+Gw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KAut4dIs; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KAut4dIs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756427937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dhN2zcFUEER4o0mfl+Pf8YKEeY54fmHrDhnJHsDDNpg=; b=KAut4dIsJZ+L8rjcjn91zhxYgeEUBOYlBhmkMyuF/NWwuppZ8Pq5L36CGO9YcZXX6NFZs7 Ty5oFmgfsJc36g+uh1Y05okrbegLgNKmMnP/tuApBRJ+3ouXeCaSeUliCgefudAzrpV/z1 wbMMnIYFtnywwpKvMVY0LJ9/rhkKIsw= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-547--DO_PqgUMcupH3ZO5nvLCw-1; Thu, 28 Aug 2025 20:38:55 -0400 X-MC-Unique: -DO_PqgUMcupH3ZO5nvLCw-1 X-Mimecast-MFC-AGG-ID: -DO_PqgUMcupH3ZO5nvLCw_1756427935 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-70ddbb81696so30355006d6.1 for ; Thu, 28 Aug 2025 17:38:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756427935; x=1757032735; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dhN2zcFUEER4o0mfl+Pf8YKEeY54fmHrDhnJHsDDNpg=; b=GXkhKm+2PQjYrEoc5HLkb28r1clcH+fa3IOjfzrSUeVqfb/S9ng/3uLYevjbTrn2Gi j/3u8f2ixmntuCPsekMhWCb9czc+Q8hVjaH+wHNT3yHLY2Hy0MVGwQPz6ySNWGBjJVQ0 mNk+oGla/MJnNyfg9VWYcbNQtAVcwnqYj4iNYJpxbdJa9zP/Vyt5KmFcGDe9Z64On3IS 4Ukx1u2wK0wcconCxh2PejX6aatW4WOfnbLhnAn/8+SWsobyr5JHiq5Vf3NrPXinRfUp zY082wu7xe2vYQZ5I0sCYuxlxsAVY3E11Io5+Zke9B9VN8RirINsrfNLSStPr58S5k9q tSeQ== X-Forwarded-Encrypted: i=1; AJvYcCW5rjCmFY7OY05gee12OVBMKOoQkvR4H2ycTeqyjakRBHrmNC7m090cD1dDlA5qROdMv/9ETRheUM49f3U=@vger.kernel.org X-Gm-Message-State: AOJu0Yxwno57Ge5x4MFLfxWReMY0ntDgdKj5rnKLxIt1wDu15Q7JD0z9 /4J4k7h12/mfG5iz6szcPhmJab86t8Yke1YbeQ/OL0pi/6R+GwaZYSBv6qzdiWZjTFiPlC9ztfv DQpxcT2I7MVqVrBpTa54XY3GMzDijEux3cma8OMEl4Ur+ErBuvFD/9UchYyhVMHkiaQ== X-Gm-Gg: ASbGncvy1e94W29mOp2TybOScgW8PZeISqJ8+rK+HjEway5mymJP8giKib8nJmE74VC bZYpcHMKFDvgXDMcCYZi/s6+beXrz8UqfHCJBHULdmErW6nY2alDVgteIIRvL1ZiW+b5DmN+2rn goKgqRUX/LgC2slhypS6xnWvWiYCzPZQ8+6sTtxbOXIIeCtEj6fBgb4D6pTS/lhQh92j6juA5Yp XAf6N89JhXK13Dak/MF3uaT2FxhTyT6ug/GuPssykqmT23mnBrtSaU5UkG7WTSBK7OmyCJ1y4lD SfqsvZYpZTJ2lRwx8rzQjLgbrr/zio8Gu+8WYWUEB5Hw2ltBmxnvK7YYXaVF/iAY+E1nKS2TP1g DXJ9vSsVDOervLlKsBEwT9XPbryL0q5Cg9Q== X-Received: by 2002:a05:6214:48f:b0:70d:fd53:7256 with SMTP id 6a1803df08f44-70dfd53763bmr29827666d6.3.1756427934550; Thu, 28 Aug 2025 17:38:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEijYzk7GkyvAnuURsnBocI4vkkc9uguNYcxLJSHaK49JimJzbCk2zB1vtZtqve+KQwqSmw3A== X-Received: by 2002:a05:6214:48f:b0:70d:fd53:7256 with SMTP id 6a1803df08f44-70dfd53763bmr29827556d6.3.1756427934193; Thu, 28 Aug 2025 17:38:54 -0700 (PDT) Received: from [192.168.1.2] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70e6264141asm5588696d6.65.2025.08.28.17.38.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Aug 2025 17:38:53 -0700 (PDT) From: Brian Masney Date: Thu, 28 Aug 2025 20:38:26 -0400 Subject: [PATCH 7/8] clk: x86: cgu: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250828-clk-round-rate-v2-v1-7-b97ec8ba6cc4@redhat.com> References: <20250828-clk-round-rate-v2-v1-0-b97ec8ba6cc4@redhat.com> In-Reply-To: <20250828-clk-round-rate-v2-v1-0-b97ec8ba6cc4@redhat.com> To: Michael Turquette , Stephen Boyd , Vladimir Zapolskiy , Piotr Wojtaszczyk , Chen Wang , Inochi Amaoto , Michal Simek , Bjorn Andersson , Heiko Stuebner , Andrea della Porta , Maxime Ripard Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1756427914; l=3470; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=WJxAzEZ/y8gMiDjK9rGa4K/3JOojl4uHZ0X5uecFxfU=; b=FRh6Dtp6Qu3xMrqG77h69FKmubrcLmD1DaQdhlvkUw0E6UlxV5Rv3RQ4Eg7iODuTrLGqcr72p gQO+ywq9rn/BM+b5lX8Ga2Eu2EAvxju51YKn1XwPasJWhPgQyJz0Qba X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/clk/x86/clk-cgu.c | 35 ++++++++++++++++++++--------------- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/drivers/clk/x86/clk-cgu.c b/drivers/clk/x86/clk-cgu.c index 89b53f280aee03b7838e4656eae3571f00eaa263..d099667355f8d80785b0f43097a= d10c274dd61ea 100644 --- a/drivers/clk/x86/clk-cgu.c +++ b/drivers/clk/x86/clk-cgu.c @@ -132,14 +132,15 @@ lgm_clk_divider_recalc_rate(struct clk_hw *hw, unsign= ed long parent_rate) divider->flags, divider->width); } =20 -static long -lgm_clk_divider_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int lgm_clk_divider_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct lgm_clk_divider *divider =3D to_lgm_clk_divider(hw); =20 - return divider_round_rate(hw, rate, prate, divider->table, - divider->width, divider->flags); + req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, d= ivider->table, + divider->width, divider->flags); + + return 0; } =20 static int @@ -182,7 +183,7 @@ static void lgm_clk_divider_disable(struct clk_hw *hw) =20 static const struct clk_ops lgm_clk_divider_ops =3D { .recalc_rate =3D lgm_clk_divider_recalc_rate, - .round_rate =3D lgm_clk_divider_round_rate, + .determine_rate =3D lgm_clk_divider_determine_rate, .set_rate =3D lgm_clk_divider_set_rate, .enable =3D lgm_clk_divider_enable, .disable =3D lgm_clk_divider_disable, @@ -487,15 +488,14 @@ lgm_clk_ddiv_set_rate(struct clk_hw *hw, unsigned lon= g rate, return 0; } =20 -static long -lgm_clk_ddiv_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int lgm_clk_ddiv_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct lgm_clk_ddiv *ddiv =3D to_lgm_clk_ddiv(hw); u32 div, ddiv1, ddiv2; u64 rate64; =20 - div =3D DIV_ROUND_CLOSEST_ULL((u64)*prate, rate); + div =3D DIV_ROUND_CLOSEST_ULL((u64)req->best_parent_rate, req->rate); =20 /* if predivide bit is enabled, modify div by factor of 2.5 */ if (lgm_get_clk_val(ddiv->membase, ddiv->reg, ddiv->shift2, 1)) { @@ -503,14 +503,17 @@ lgm_clk_ddiv_round_rate(struct clk_hw *hw, unsigned l= ong rate, div =3D DIV_ROUND_CLOSEST_ULL((u64)div, 5); } =20 - if (div <=3D 0) - return *prate; + if (div <=3D 0) { + req->rate =3D req->best_parent_rate; + + return 0; + } =20 if (lgm_clk_get_ddiv_val(div, &ddiv1, &ddiv2) !=3D 0) if (lgm_clk_get_ddiv_val(div + 1, &ddiv1, &ddiv2) !=3D 0) return -EINVAL; =20 - rate64 =3D *prate; + rate64 =3D req->best_parent_rate; do_div(rate64, ddiv1); do_div(rate64, ddiv2); =20 @@ -520,7 +523,9 @@ lgm_clk_ddiv_round_rate(struct clk_hw *hw, unsigned lon= g rate, rate64 =3D DIV_ROUND_CLOSEST_ULL(rate64, 5); } =20 - return rate64; + req->rate =3D rate64; + + return 0; } =20 static const struct clk_ops lgm_clk_ddiv_ops =3D { @@ -528,7 +533,7 @@ static const struct clk_ops lgm_clk_ddiv_ops =3D { .enable =3D lgm_clk_ddiv_enable, .disable =3D lgm_clk_ddiv_disable, .set_rate =3D lgm_clk_ddiv_set_rate, - .round_rate =3D lgm_clk_ddiv_round_rate, + .determine_rate =3D lgm_clk_ddiv_determine_rate, }; =20 int lgm_clk_register_ddiv(struct lgm_clk_provider *ctx, --=20 2.50.1