From nobody Fri Oct 3 16:47:21 2025 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 190042D481D; Wed, 27 Aug 2025 22:00:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756332010; cv=none; b=ZFa4yhTQCb5VVZ2OX7yrIQpSvx8ZnwxyLni1FibVdpYJmXQj9yuclUlbp86TtBzZlF5pBogWkJYVCBSE2sBytjd3fXFTlPNimPk+yznyS6SN22dsukzUijT0gZESJ8GjiPsFS4gPTc/Vow+HmF8Cqfyi9H1NVzScg1pASF/iaLs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756332010; c=relaxed/simple; bh=uqpDtgYEsH/2teiN26HjR0864oP2Dn+Pu3LOHffYlZc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hI4Fn9LIQO/UMxpSGZy9iF/CoQ0bZ9p9sWU1fEiJGtbjex8WOaPHe9GpZ/DHkeWX8TNEGBwkBaiYgTWPXMWWUB3mqoTi3jJ8i7oou5hMu7D8QnuhaRUd1ZzbKtyEoAbsQfwj/xziQUOTSFMi0WhUSQOyGY1ZJ2w4fy8cerZW5nU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZBBidJS5; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZBBidJS5" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-77057c4d88bso357686b3a.2; Wed, 27 Aug 2025 15:00:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756332008; x=1756936808; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=azT5/Oxy5nI5gMRz7mftyiFsz2F/SySsnSiyz7a6cX4=; b=ZBBidJS5G0SVbYfzW1Hl/7/Z/uxedeSGxzifFZhT0iDzlU7t9kXCUuSgJwDRirZlR4 l73n72vF4emrm0yObKV7/kcqp3KE3qFrK9BVhdhqFd5P2SuI4HgGNKrWDyURISO/QPTs HV3topPi3mBFLxJgltb6XiVHdm1rPrPu0JABid+Z6hnIaafWfYSB+VLELLaZfd3yBA7M sfVOMcaO64/X+sCRpfgH9ERhMVU0ELqTjdqkkuCAcGFhg3N/6oPawP+zeqI2vpiGvV0M 5FBAgWwLZ0SGxA/QqbkCjb0aaH2URTPSSyJdKb+MySmRdzt7lqaXZW8wOaZdncnohMAc hddA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756332008; x=1756936808; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=azT5/Oxy5nI5gMRz7mftyiFsz2F/SySsnSiyz7a6cX4=; b=i7NLe/mEc8mJF+MFKKHdQ7uPGfP19kCpiFDN2PJ7pVlA/shARY8wZANWoaZKW48+NG ghwXSXisz46NgcFeBWlYonufiiFxePH1yo9F7BNcbXJRx7QywTcp9dozfEtmvxpazoyv C/plurnTIcaWTfU6Uj/6aUfo74AyqSrNwX3kHPgpexyIiE9YL34Iydh+aPzVJJqq/G0v +U5g7+ex/UmziCsPIcDwgLLUQtlQ3I0YF1fH/JR/bVFYf7hVBW8heiTcVMIjLh2AhNFu /wpNqO7noghBvOJ2LQp49EoxDd1gPJDlI9BfYqXZ33Lt6rYrKPYZ7bZGzB/nOYn6SXgk V8gA== X-Forwarded-Encrypted: i=1; AJvYcCVp0ObXaQtb6VpbnvJjfARrhzesmYnEcdAKTcxIQaGOJKVoDW010Y7gzOOMsL5v4sEVg08RN/a+UYAmYr8=@vger.kernel.org X-Gm-Message-State: AOJu0YyRHtYycpfEYaTnqqoY/J9CekHeUTkqlNUC3dpJiISw1oNfm6Rn ZNHUAdeDq/ICV76NmK9WNYPLymqYrhfrFcBJ/KSPeQVjwLvWCYeaG04DNPSSaA== X-Gm-Gg: ASbGncuKfjy3xC7whfSsWB+vyRn/jXUMI38W6oL9Evpun93zjvBa+MD7xbxMWYNvNWX pzFq1Z7spuDqmEyyHLDsYuf56afC9aPKZk8+LswRxRsXdBkHejYIlNOF8pb9IkxBw7kc0P7lrLN PIttECGKLZSuOTcrpVmSnTghf+broi/cGK8E12wX5SO3yy0vmkMbFtIGe9vS0py/QdU165fuocu Rwq9xjBxm9FnzGTRso5/l0pOCV1c75YlwJFU8rWiciEc8amG1571S6/nkqiJ8sru8x3FPFpX1Dx BiHsZk/g12+ti78tXkBoHnw7BMU72mrrz7rcikI7bKCyJgQ0H/2nal0tquttGYWrHU9c9h6Q4BJ AybAtTNzXwX1HISC+IAmV5V1EIcySbFHObwNHGyu4EtJdoVmu0cZiD83Jl+VxbOq0Kw== X-Google-Smtp-Source: AGHT+IEQRThp7GAmIznOv/UYVBsPTlJTmslelWrkx9sKxgT+03gMoMvwkdEtOtQvtV80/gOp3Dn3Rg== X-Received: by 2002:a05:6a21:328c:b0:243:a5be:c4a8 with SMTP id adf61e73a8af0-243a5bec653mr3165617637.22.1756332008058; Wed, 27 Aug 2025 15:00:08 -0700 (PDT) Received: from archlinux.lan ([2601:644:8200:acc7::1f6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b49cbb7bf2dsm12389128a12.31.2025.08.27.15.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Aug 2025 15:00:07 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv3 1/3] dmaengine: mv_xor: use devm_platform_ioremap_resource Date: Wed, 27 Aug 2025 15:00:03 -0700 Message-ID: <20250827220005.82899-2-rosenp@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250827220005.82899-1-rosenp@gmail.com> References: <20250827220005.82899-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplifies probe slightly by removing explicit struct resource pointers and platform_get_resource calls. Signed-off-by: Rosen Penev --- drivers/dma/mv_xor.c | 23 ++++++----------------- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index 5e8386296046..3597ad8d1220 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -1309,7 +1309,6 @@ static int mv_xor_probe(struct platform_device *pdev) const struct mbus_dram_target_info *dram; struct mv_xor_device *xordev; struct mv_xor_platform_data *pdata =3D dev_get_platdata(&pdev->dev); - struct resource *res; unsigned int max_engines, max_channels; int i, ret; =20 @@ -1319,23 +1318,13 @@ static int mv_xor_probe(struct platform_device *pde= v) if (!xordev) return -ENOMEM; =20 - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; + xordev->xor_base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(xordev->xor_base)) + return PTR_ERR(xordev->xor_base); =20 - xordev->xor_base =3D devm_ioremap(&pdev->dev, res->start, - resource_size(res)); - if (!xordev->xor_base) - return -EBUSY; - - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 1); - if (!res) - return -ENODEV; - - xordev->xor_high_base =3D devm_ioremap(&pdev->dev, res->start, - resource_size(res)); - if (!xordev->xor_high_base) - return -EBUSY; + xordev->xor_high_base =3D devm_platform_ioremap_resource(pdev, 1); + if (IS_ERR(xordev->xor_high_base)) + return PTR_ERR(xordev->xor_high_base); =20 platform_set_drvdata(pdev, xordev); =20 --=20 2.51.0 From nobody Fri Oct 3 16:47:21 2025 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 405EA2DA746; Wed, 27 Aug 2025 22:00:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756332011; cv=none; b=FNVSqu/xQBms+/oJGC03wlyQl5rDW9SOxfr4YgUWHUF0qlXw1BGoDz7i5hdiAi2smLleXWorgngGQ7L4+fxonhaVJbE28X4jlzpXoemP8Y/VoDzTUvtM6lC4rfTDTHcjTvsK0G6b+ZlrVzByxGUBjnFhyN8OEkvNU0rMaiiowKo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756332011; c=relaxed/simple; bh=A8WjhC3DiGRPvZ4pZueH9qgpb6iZD/fWWPlcc96PZiw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TdpiaHO0YwFgbHZ71QzEX59bWttfVOMsoKfR7Yg0be8JpnPXK7lAsGF4E8LOEsSVk8++kZGCJ8jMAMENjozagr3mnaRdV5Iwnwo2nOtjIrf7b61i9DFSWkPXhEl+n+6mKp1NUlGYBv/M4kX9GL0LdyYRO7TWbFW1chL9S9ZwnFA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZAhCzDM1; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZAhCzDM1" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-77201f3d389so380597b3a.2; Wed, 27 Aug 2025 15:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756332009; x=1756936809; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8f/5fComQOV6WzBxL6f+7JPmlog+dx/PN5RQ28Vh8mo=; b=ZAhCzDM1TCwL0W1KxlJw9AmI3Oq1+dabPLaaeT/kBj767Y/UnEYERK2+8isPUnFRg6 7LJX19HQYTk0OkZDQA0ONAVcxu7yRRHsgZuWkeus43KdpUPdkWDgWCTferO1hLbF1Uiw jCGSDOQbyIIuvjQprqgz3JqnnjQr7N8K0akqe49CtaOC7B4COela05WiEAjBHFIHKl8y rF6++4nly88u+XZ7lj/VNBjBVvIps5eeA4zccI8fyXaD6sAQNMP24rR+YONCkpoJnd6X NrdAGGwmURLzVFUJWLhSPm8xaD4BWSyKcF1mxVFPIYxSwhWhnJX2UxxkYQ3qk8Vz5Im5 B6ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756332009; x=1756936809; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8f/5fComQOV6WzBxL6f+7JPmlog+dx/PN5RQ28Vh8mo=; b=BobSzt/3a662dxeMW9nljHol4vDqB3t4N7ewS6QwsQ4Tu0cdazvgxsUyew6+IMJd/J CT7EHPnGvFvlUtRBYSfKfqc58Lg0WXhISvMk2xYiJQ2L+Hwu5Je1ghOnryHyJIairhy/ gxZZSU+HKzZQDGky3McPsDzx1SAq1fAADJEeH2SrhtdqyHQ5YcPZ7uBb76/Sc76hsyjp 0u8iBXEpnCQ2iLwJR9r1kiCUfcRIL8SK8Wp5Fu196bPNk8nPxjasNQQ6kP2fvxclEX2+ CpMd2kfswmzAfIMTw3oRsXOT+WTZMwkIq2nze0XU8b+rq24wALNWpaUUsrncoEcjWNqI bF3Q== X-Forwarded-Encrypted: i=1; AJvYcCX9RrcIlNpHi1plUbvEWymz2PGfTvPlhAB8cQT8nr9/7Uhjzk8ZmKdAfVtEwBh8N/AfMl9rTVhXr5ZPEJ8=@vger.kernel.org X-Gm-Message-State: AOJu0YzerCgBpMC8O3i6/CeWz1ZoMQopBBVllOoa6Ebxv4tGAPn37LHi JKdbC+1TK2ITW2o8uQjVh2nAj+SirTjgqGxiA5XPTT1P2ZPvMgqEDBIIpBgoUw== X-Gm-Gg: ASbGncthy+cII/dNh0Hs4BNgOak9o2s3xLZcKbW5W1iMOELu/Jv90rEBT+u7G0eLi5g vxdYrKCmrR0Mmd8FojGA2okvVl600+ZKGil5t8QNGIRPRq2Fn8BZ1Vcna7HfAqUJtmXBGwE9bZa rIeCfcIGF2UqdrcLyEHpjXUij1rt9FCaxwh7KDh+ADZI6MRaIsyupnnhUkPncgkjDOC16ZjSJme xfBikxq7Akt6G7uvXGb1VATXtmNL60OJsXr4iEkTvoEaQyWNj5PSW5Pwt/uFHf68AJyXQdF8vO/ jtQOy5u70brnN3GxsYNzORRKptWBuWe+FtW/Fqe09GlzRvKV0r2Q7HucLyEPBjOMGJPIV0SGTIY 4naXzHBjqnUAm/Lgy66KsvTGp9fPOFhvnO6i1bw93QHJRHMrUDFOpkHru5p/ROp9l7UW44uxBfg 4a X-Google-Smtp-Source: AGHT+IF5zpen7OiNCMFlimI7ZUGU+Y1BQ/eUePehYyHOFL9jX68xvb0k+exxRfLo1/2Ot4Zqnos2vA== X-Received: by 2002:a05:6a20:a11d:b0:243:98b1:3960 with SMTP id adf61e73a8af0-24398b13ce4mr7419295637.35.1756332009085; Wed, 27 Aug 2025 15:00:09 -0700 (PDT) Received: from archlinux.lan ([2601:644:8200:acc7::1f6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b49cbb7bf2dsm12389128a12.31.2025.08.27.15.00.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Aug 2025 15:00:08 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv3 2/3] dmaengine: mv_xor: use devm_clk_get_optional_enabled Date: Wed, 27 Aug 2025 15:00:04 -0700 Message-ID: <20250827220005.82899-3-rosenp@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250827220005.82899-1-rosenp@gmail.com> References: <20250827220005.82899-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver was written before this was available. Simplifies code slightly. Actually also a bugfix. clk_disable_unprepare is missing in _remove, which is also missing. Signed-off-by: Rosen Penev --- drivers/dma/mv_xor.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index 3597ad8d1220..d15a1990534b 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -1351,9 +1351,9 @@ static int mv_xor_probe(struct platform_device *pdev) /* Not all platforms can gate the clock, so it is not * an error if the clock does not exists. */ - xordev->clk =3D clk_get(&pdev->dev, NULL); - if (!IS_ERR(xordev->clk)) - clk_prepare_enable(xordev->clk); + xordev->clk =3D devm_clk_get_optional_enabled(&pdev->dev, NULL); + if (IS_ERR(xordev->clk)) + return PTR_ERR(xordev->clk); =20 /* * We don't want to have more than one channel per CPU in @@ -1441,11 +1441,6 @@ static int mv_xor_probe(struct platform_device *pdev) irq_dispose_mapping(xordev->channels[i]->irq); } =20 - if (!IS_ERR(xordev->clk)) { - clk_disable_unprepare(xordev->clk); - clk_put(xordev->clk); - } - return ret; } =20 --=20 2.51.0 From nobody Fri Oct 3 16:47:21 2025 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30F262F3C26; Wed, 27 Aug 2025 22:00:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756332012; cv=none; b=eh0JnRTtS34Qf8qy40LYUpl25TFsuL+IWoOTfM+q+8NZjlT9u09F+T5wb9LQCN93Ykn7VR8PxE9ww/GvhvC40rbHlQ8nyjyFQONn51SbNDIVH5LWFv8Z0K1PedpB45YmcwsxmuYwVPqAtihhOMmlVXINArstQf7+w6u/SrhGxvE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756332012; c=relaxed/simple; bh=xMvW1NipylYcAHgDeiDS1bLvbSfKOIuwb8djTDKxS2k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WOYteVz0zeGAx1O/3x4Go6Qm8/sTCZ02JTV0Y9YMYEKzSJvmPDXCeQOhJrHDocXnhS3CvfTUEpdAqv5477JXQX7Ub14n5RfUFvmSHbhrkfR0kuEo7ytku2FEAgCehwvqnipLX7C8e0bgzD4LHIwEb1yrcEW+L08qLFWbXAcqXI0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NWK3COZs; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NWK3COZs" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-77057c4d88bso357712b3a.2; Wed, 27 Aug 2025 15:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756332010; x=1756936810; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wqTPmWovOAbxl0W7h/uTcQKLLpK3p7MDInPfhhT7a8M=; b=NWK3COZss/cDTcgqwMXV4SQIJpVyq70xw9I9C6ayPlvCDzbqxFIJDslY+X6oSFadTX 2YvolGQMen/iFeyYj7iSN7PTsUK/a8toKscjjevEmBu1fzMOJ/jxM8Ku3FHn07OKPEKL 7ASzTRnb+YlZzL62E27BlXsDS9G/tO9BG9OGrMM5qr34zJhQVL9LQBkedlnnViYvjJ9h GKOOw0mSlI83IX6COx9kjqDEFRyyQPrGSopnxGb2nb4ESlNcxhwWHBa4IX9TL4dycsOm zawUtcd5xtBIhL6MnEKc4fkounBff2Ukpqf0uuhNGKkK9f2yYCazH4GZvvx2IiNprc+G NDpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756332010; x=1756936810; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wqTPmWovOAbxl0W7h/uTcQKLLpK3p7MDInPfhhT7a8M=; b=fHXWCA3O5lCGNSrMT3AwW6zBxfgU5SELsGN0CcsOzNHaGoLxb0DmJ5cvDpF41eZJL+ 5UsUI9gxb2RF02+HsgxvfHlWsgoVra+pZeylUPUAVxmpMnQ7NOymctzIhZnVxLlUWE7O 2bjGl8deG++CkAHUjCPG2b/kyF0XGE9GiwNICsXzSVK89iN0Sfu071cV6mcfrNvXnaiE ChovXb2sWSBVnTYaW/7ZmTnY7qfey5mITAQW/wc+gRudRf8kZfzsyi8ODosqiDNL4meW rm7W40RkojuStadOdQ1OhhRkPiHprN43tsizv0r7uc3Zn4a9Btk6mWTdcLuBnfUfM6W9 zK8g== X-Forwarded-Encrypted: i=1; AJvYcCXk6z1teeUYHKwpfdgqArRu1LkhAx/rtj7nZbpZdAhT4+7lam9ieFiL8/iMD63fVn4nZyQk49oKt1F/c/Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3zXUsxC5/ggDFttZz2UJETFz8wooLnlnrkVgiQfmYzWHZeNug +H/pvqA5NLPx9KGbUfWla5fHVml5aZ3swnPr9aPAEPwntiaUEsKYkcSXhPNurg== X-Gm-Gg: ASbGnctH9mnzfaaBuiRUaGbJXSO/cTwcT1+PTrw7s0Pafps6+XkgI0bZBu5ndtAX/gu VPFyF0AijdZj8XKcoyLe/85jKe5Yq+vKN3U1507VK/mGECqogGmpUoHf6mWPDbJO421EdIesMeO KuXDm0EC6xNISXzGG7Dv1OoUXvlRkxzKCryDh5ORDPknJJMSXHoBki7jf1JoNILq55m+9lo3LhS zAgSbMaONVjQ5a+SOGqn2MTCtPhj7UoSbHlDYoQ5qu/R7939i+nPrbP/7tkpkqzh1KXi+K+lptv +dIN3lRrnF6PJuEiLk2Vbc2QDKoLfbfWMckh3QMXVMoBKfTrxvDcn+PfEdZFUzfX8BRMyYpuX03 2nBNTTzjWu57OtYpiPHV0Gp1MjU0KHF7Uxe2BGWKqR3Ydjfu1Qoj7x4Hg/cC5Ic/jqg== X-Google-Smtp-Source: AGHT+IGsQQhZ8dCdCkdTAdovOy5g8N/ZObZRNN6qP9PgpHQ1/3MLGdIeMA1Cjn6OSRaayZRDCI/1cA== X-Received: by 2002:a05:6a21:328c:b0:243:a5be:c4a8 with SMTP id adf61e73a8af0-243a5bec653mr3165832637.22.1756332010190; Wed, 27 Aug 2025 15:00:10 -0700 (PDT) Received: from archlinux.lan ([2601:644:8200:acc7::1f6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b49cbb7bf2dsm12389128a12.31.2025.08.27.15.00.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Aug 2025 15:00:09 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv3 3/3] dmaengine: mv_xor: use devm for request_irq Date: Wed, 27 Aug 2025 15:00:05 -0700 Message-ID: <20250827220005.82899-4-rosenp@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250827220005.82899-1-rosenp@gmail.com> References: <20250827220005.82899-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is only called in _probe. Removes the need to manually free_irq. Same with irq_dispose_mapping. Signed-off-by: Rosen Penev --- drivers/dma/mv_xor.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index d15a1990534b..81799ac2f48b 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -1025,8 +1025,6 @@ static int mv_xor_channel_remove(struct mv_xor_chan *= mv_chan) list_del(&chan->device_node); } =20 - free_irq(mv_chan->irq, mv_chan); - return 0; } =20 @@ -1112,8 +1110,9 @@ mv_xor_channel_add(struct mv_xor_device *xordev, /* clear errors before enabling interrupts */ mv_chan_clear_err_status(mv_chan); =20 - ret =3D request_irq(mv_chan->irq, mv_xor_interrupt_handler, - 0, dev_name(&pdev->dev), mv_chan); + ret =3D devm_request_irq(&pdev->dev, mv_chan->irq, + mv_xor_interrupt_handler, 0, + dev_name(&pdev->dev), mv_chan); if (ret) goto err_free_dma; =20 @@ -1138,14 +1137,14 @@ mv_xor_channel_add(struct mv_xor_device *xordev, ret =3D mv_chan_memcpy_self_test(mv_chan); dev_dbg(&pdev->dev, "memcpy self test returned %d\n", ret); if (ret) - goto err_free_irq; + goto err_free_dma; } =20 if (dma_has_cap(DMA_XOR, dma_dev->cap_mask)) { ret =3D mv_chan_xor_self_test(mv_chan); dev_dbg(&pdev->dev, "xor self test returned %d\n", ret); if (ret) - goto err_free_irq; + goto err_free_dma; } =20 dev_info(&pdev->dev, "Marvell XOR (%s): ( %s%s%s)\n", @@ -1156,12 +1155,10 @@ mv_xor_channel_add(struct mv_xor_device *xordev, =20 ret =3D dma_async_device_register(dma_dev); if (ret) - goto err_free_irq; + goto err_free_dma; =20 return mv_chan; =20 -err_free_irq: - free_irq(mv_chan->irq, mv_chan); err_free_dma: dma_free_wc(&pdev->dev, MV_XOR_POOL_SIZE, mv_chan->dma_desc_pool_virt, mv_chan->dma_desc_pool); @@ -1400,7 +1397,6 @@ static int mv_xor_probe(struct platform_device *pdev) cap_mask, irq); if (IS_ERR(chan)) { ret =3D PTR_ERR(chan); - irq_dispose_mapping(irq); goto err_channel_add; } =20 @@ -1435,11 +1431,8 @@ static int mv_xor_probe(struct platform_device *pdev) =20 err_channel_add: for (i =3D 0; i < MV_XOR_MAX_CHANNELS; i++) - if (xordev->channels[i]) { + if (xordev->channels[i]) mv_xor_channel_remove(xordev->channels[i]); - if (pdev->dev.of_node) - irq_dispose_mapping(xordev->channels[i]->irq); - } =20 return ret; } --=20 2.51.0