From nobody Fri Oct 3 16:45:45 2025 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012009.outbound.protection.outlook.com [52.101.126.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7DFC3176E5; Wed, 27 Aug 2025 12:39:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.9 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756298380; cv=fail; b=XntvkvBfWdWkophp0ckUOD3oewqqipOHQJqVVdVQRE736ENOSvYv38dK+H8hy3mxdnJxYDXbsWSB1mjSlWttG6+qV8pgOV+y+ilvRCl/YyFAAWYj2BVNmUBCiZeEqH5R44ZsokqZD/05suX4Dbdqz3tW0nf/ZB0sEW4Hm+RqvTk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756298380; c=relaxed/simple; bh=dAztA65K0hVQx4pY92tRN/PzoBgDd3gWNUro6Qq4Isk=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=gRun1TYvcFZxppQA8KyL+ozLFE1o99HsV3AIprR86WHkXVPIKPZACOssJSwtkVMtw3yD5S8YIaycwxmJMfgoxfKtORJm15Ptx3pVvdck5kLUoO7fAV+WJU0ke9AvtqP9sK27aKILAu3FcSGQQQLlr8r88bU+v4SxA7aSX22ffLM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=fRHPPHm9; arc=fail smtp.client-ip=52.101.126.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="fRHPPHm9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=glkXkrdvKSAuQM6oT8gj3NGyBI5Mscgot7zJOtEExGTUp1kkIMnS9CfVQzA8uUE8i48/rw3YZBqiRTQB+KDpAEHYe90Txx9xb9yfj8zwR8VqMx8MPx9DCUZaHFj5/vu3Ci8ikfd5UMgvwoGy5z6kLjP0IDF4d5r6lutB5H/aRppau/LyJrGrwb8k5TGLVVMGCxxn0IdE2sLHqhVqPP2nOgqfFedQHj1yNGfVZ6U+ur6iGNySOt4atRJ28Df1KBDLOVcq5WytExIr8sKEpHC72wbPOtIkkcBpwCiBMjTo/7jUN0ojTSJD4T71A07aogLEpVCq67aDx3sarnXPV6s1RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uuyuslQ7F+S/CuQBz8Y3QCm0JVmoFRYywvsGcfZmS48=; b=jsL1753s/R747CiyVM/y6EJChlqiXoyc0KRSvPaKXUYFy1CEtP1opvCbMH27XbvYpzCAYhILVplv7e0XTXvoGzubsx6/WfLeBN9+noTWhlifvudU7U63bzIO7E1ZDlfLozFB9PSMZVCKg2tEJ8TvHv5F7Q66L72GCfLodYBorIgieUUpyLY4f/IxxOKSB4pn0GsVuyoJ3KUWJfO3wVJ5qGbWS54bASuf93N3rLImAhhkQjveaBZkmGAOyycf0b+xum+6zP/fvZWhnNEnXQDlCkCCtaLnK2+KGlpAjJPtEPxeCzZQxnZhzeVbNG+GymtU9y3/OWefjW62YQLEJBAL8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uuyuslQ7F+S/CuQBz8Y3QCm0JVmoFRYywvsGcfZmS48=; b=fRHPPHm9OeN4y2lKcOlx6DOnKXi7gCZgxQcgovIrKJ6vj+yfd/O7U9Lj51wrAJK81jcMnQ4t2TgeBYMdQra+BFIEoR90sFp+MlEtXpyJHUl6Mhe2T5wh2bWTc95Hgrmqp8vSw8/W5PuPtPBD8Qkj5gKyi4xzzaSp6kyby+NE6lYELqGSRV0flCm6YY3rXOhNsLsCUIq08PDL+n9EsjS+GIZDaOggZ5NIDMN22FHsCVanjCw5qUE4udTzJZOiRgFtO6tuJAMELzxg1oDDDuc4om4Ph7BoA0oCcYZdTyc2QlWiDc8y3QNST9Y+1Gl/MBUNsRrxdoIE8VrVia5/tlC5nw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) by KL1PR06MB7285.apcprd06.prod.outlook.com (2603:1096:820:145::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.15; Wed, 27 Aug 2025 12:39:37 +0000 Received: from SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666]) by SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666%5]) with mapi id 15.20.9073.010; Wed, 27 Aug 2025 12:39:37 +0000 From: Qianfeng Rong To: Abylay Ospan , Mauro Carvalho Chehab , Qianfeng Rong , linux-media@vger.kernel.org (open list:MEDIA DRIVERS FOR CXD2841ER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/5] media: dvb: Use int type to store negative error codes Date: Wed, 27 Aug 2025 20:39:09 +0800 Message-Id: <20250827123916.504189-2-rongqianfeng@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250827123916.504189-1-rongqianfeng@vivo.com> References: <20250827123916.504189-1-rongqianfeng@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR01CA0049.apcprd01.prod.exchangelabs.com (2603:1096:4:193::13) To SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SI2PR06MB5140:EE_|KL1PR06MB7285:EE_ X-MS-Office365-Filtering-Correlation-Id: 375f489c-c1b5-40e7-ec7e-08dde566c882 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?+C8py2PaGimZdHl+xd1w9KXzP1fKdTQlqdaPqflT1jjbJmmP75exd2NN7Idn?= =?us-ascii?Q?8FWE3wujrWqfPgO5YKcCFUC/ltlZBf/+IPQXdfi4KDKxzAnYuNPoY1IQiFYp?= =?us-ascii?Q?fuhLpXnE2WcnFaiX1TNNv9fZwwtQTI4/ZLYaPITn7aBbTemEeDdtwGyqo8nC?= =?us-ascii?Q?t8tBOcHKW5DQERQ4LXjCFMde4spD0TONOcMqwcY+iv5FYjbvlUaaBENOERu8?= =?us-ascii?Q?XyDua15x/l9h+wDnnqHMGyCmvAgI0sNausnmTvcShV6eXqxkeHfJhkooWW91?= =?us-ascii?Q?BJ7atlOqNMKCTZSg7SCGhpJDOVGJf2dyDIASoFvHJvFeo8W2oqBvLJJ6SqwV?= =?us-ascii?Q?V8hAXZku+Lm5G5o7gmKYs7plIF77G60UsnAKtB28hfAagh+XRPHDBtoDm+wV?= =?us-ascii?Q?bW1NaBKnCdCuAbKI2aPLfMgBlHm8Etgjrw4XyPvNqPM2at8DTwT6mWKQdHwV?= =?us-ascii?Q?3Un1VsXd7V4TlLdqWbOqKPZnDh2d7bEfrnP6txSWb/SmnZ8lYA5/dgjSGeT/?= =?us-ascii?Q?Wa0woHhgW6NSDjyq9AtFqeMn2JUSElaFMzWirON7//g1966/Ngjyv2VeYqPX?= =?us-ascii?Q?fINgZ9n38HvG2ZUTGZzXfxWzU7KjOfj6h+QgHEqNb5cGDG6Y07hEQo6euPc1?= =?us-ascii?Q?VVn7/vMeClwrQtULzIFTz94eGKdZwSej6CR0lkzijEkFCb8x3wgRLjIjw75o?= =?us-ascii?Q?sVSG7b7bdVsf9hTsBoVW40EjLatNEF0Te3/cM+8oJ7LlWmbB1+k+8+Zy+63p?= =?us-ascii?Q?/EUFMtOM7FSU7wE9PVKq24tx7GjDeBLt4Tdm0MHibQZbo33ZjhWMhJIU26jq?= =?us-ascii?Q?AUhaJwydAQ80tst7V0+CHSL4nxOjZrbUVBTfBmKBomThb5W6BmMLo/bRt+JR?= =?us-ascii?Q?83YJ4PJGDIiMRon1YET3dRrT0Hygj9mS9GfQBrWdQpm8T14brkwb6AuYi7v5?= =?us-ascii?Q?hKcelheufAYoAic3mnYDDs+SW7ntCGS2rE/V63LFDQvNWLhvvWKh6j5wg4Z5?= =?us-ascii?Q?8AcjVf3Eo1FbeN9gaBMg/mM3D10s/mX2Hx7FUz79oB5PxhhH4h0pOQ/QMC51?= =?us-ascii?Q?eNnCDKWDiGJBb3VV3/eIu/wGbOLyrQLlSlWWl+KsYX8lkjcxLp7eEZ9R+t1A?= =?us-ascii?Q?xctYJYojvDOs1+tzrr03pg1jS2SaYhgc+L1a1xp28fmX5VbPYVj0t4I4KDn2?= =?us-ascii?Q?9h/DA69+ChRbxeR2VT2SNjKhg9YAgvXv7buMAIh3Hi6WzxrlAtWk+eNDB7SJ?= =?us-ascii?Q?gApV5OPKAVgiOCVne7UkoZMOAwxHrpeLJloty0Oipk2UUUEbVh9lPCZCMxWD?= =?us-ascii?Q?wpNPvgP3CSekMCTQfvaHE5mfg36144MrWIhhXX/HsZ/Fu6awAHV5eXd6ci3G?= =?us-ascii?Q?Z8VGgGIhUABV9wB3xUlxbGUyZMxTGTK9ZVwlQ1xPFKjGbiJo1C4hYZhOunt2?= =?us-ascii?Q?4aUzxJo7Lq9YdgyCS+5kUubEKUXObvZsusuFPSSJ0Vn0A80CwyqP0g=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SI2PR06MB5140.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nnVVaPGY7tAUGD008NAl/WKfjBCDvwvSJU/yYH1LWeDpfamP0ogKk38ssk5Y?= =?us-ascii?Q?SGDloJM8w04Ja89pq9qcK7OTcljYz6fRw5xqw1GI4Azx2wri1gviTWB4lf2e?= =?us-ascii?Q?o/opD1BEBYy61FPBE90KpBNESP3OpntYEim6KNC+UmWYCTzdBXjbp72jl1z/?= =?us-ascii?Q?qHn8lRuftB2hO1keGG4QETvoYWCgtpwE49xXGvhr3KTzrEz0aerkOsGBA16Y?= =?us-ascii?Q?9uBhaAO5ANAomd62+N3XAW+d+tLV6afJJbtZTRxoZnlvj+dUW6K+1Ld/05bg?= =?us-ascii?Q?RNo7S6lyWkUfBiMQ6zjGLfTutBXCLXlrzfHXSXpBUGAAvDAbJSFkeDZ6lgAD?= =?us-ascii?Q?m+4X8OD0zFEsv21L9JuxE73MKIiovB5tyrR4HMSVJQovkaMqGkA2yE2ux0vs?= =?us-ascii?Q?bPOogIrbN2AWNe9pl2GSmsgJvpZSHo7VFZTvQyVT/iJEYaEkuUHaMFCrIOgg?= =?us-ascii?Q?ElQzlyfa3TiON3PskH5lWt0X7S4gfuQVi5BmY4RnwNuFMVjTQvYR26iCaJBb?= =?us-ascii?Q?AR8vNPlWUk2So2NgEv8hANg/XZwJWu127vTmcdmUoRiB/vO8U7dI4HtmRSTD?= =?us-ascii?Q?LxKWnM4YskYwWpyTt9IMFWqLliGazvLiqPcdXlDNTDpeg5L9Mp1Gn1gabbYH?= =?us-ascii?Q?2tFWb1ZgoLqMI6VyeXxadoZo+o5VFRjvbqtnlpfNzdxfVhMWbHieh56+1GsG?= =?us-ascii?Q?zZjjJpmW32kUEZ8asffCCE364i3d+0LEyoBTwa5XBEcCgSrSnoKYNbVHxpdr?= =?us-ascii?Q?McdhtHuxJEGuoAM0wjSac76hfkcsxZ1Q/xmLelj3GYxcVd1F8LqRiCOh0WmT?= =?us-ascii?Q?01+kBUNCvZK2oWivy0TNHOPQn/BunmiBFZfu26u44kKCjcNgdX/8aBZOhEBQ?= =?us-ascii?Q?29yqRdWRxRp6HKKgvCU4Cb/vXHtFj4g8LxksXKsSY01jICcmNvZnC01IXx5O?= =?us-ascii?Q?JCZ0K78IO1RwziReB4LBBUJPAf+hppLs2TKag3kFOHDW+rUXgPjuefYXSZli?= =?us-ascii?Q?Tp+ztaUfS3MIawiCLwRFhZtCSx+VT7opZR8GnHw+PInAQV38+P1eQ1JktXzp?= =?us-ascii?Q?dNUZtAnAIbHkAcBSbbYhVwZhNJDEDxjvwrdivG4YOBmKaKd6AgkBFSOUhRoS?= =?us-ascii?Q?rpQ3nAGQUoP/dSVzW7zGzqksv7lgAVH2GqeSW3f33SAcaPo2T+MKWq+fnPoA?= =?us-ascii?Q?oMwo1xLlzlx2l6Z1PQizqfPt5NBD82Xutu6vI2t9qinYWj+IoqYc3A7TNGgO?= =?us-ascii?Q?3UjO/nKfuKyTjxNM+fAUnoyyxm6Xri3kSfe89LIkcje/1ttT5E26fkGjP6QF?= =?us-ascii?Q?RHlhTOpK8l84fxZr3+jbJL5n2GFA0D8SkqQS/0PNIy3nKDjm8X2Arg9MuJ/0?= =?us-ascii?Q?NjSDwkZOOCGUWLime2/d27LNvtHEromIFfdg9EqCXZ6kMeBbHJMwnz2mbArg?= =?us-ascii?Q?0Rs8ekOpVAGoRDclAbHpWXjOk53oecuaDP8CXq7UnEFDlzZ3QpYyzkpHZ0fj?= =?us-ascii?Q?PiFUis3dsiwMqiWKJ6hTqxo4Jx4VOcCQDXGZY9mCxezEdaNGfyaZyexyOSws?= =?us-ascii?Q?tVKhfi7uPJFY0egC20O+Eok7CKN5A3VCjX29/oE2?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 375f489c-c1b5-40e7-ec7e-08dde566c882 X-MS-Exchange-CrossTenant-AuthSource: SI2PR06MB5140.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2025 12:39:37.1525 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sGN+gEk2OxPC5yVpIZeN7Es8J6vSi+bUnzNcTn/78mZBhf9vXmckciqjYKpHtjgCVzCgmSvSG/s3qplr3H62wQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB7285 Content-Type: text/plain; charset="utf-8" Change the 'ret' variable from u8/u32 to int to store zero or negative error codes returned by other functions. Storing the negative error codes in unsigned type, doesn't cause an issue at runtime but it's ugly as pants. No effect on runtime. Signed-off-by: Qianfeng Rong --- drivers/media/dvb-frontends/cxd2841er.c | 3 ++- drivers/media/dvb-frontends/lgdt330x.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-frontends/cxd2841er.c b/drivers/media/dvb-fr= ontends/cxd2841er.c index 415f1f91cc30..8fcb4417ba22 100644 --- a/drivers/media/dvb-frontends/cxd2841er.c +++ b/drivers/media/dvb-frontends/cxd2841er.c @@ -1936,7 +1936,8 @@ static void cxd2841er_read_ber(struct dvb_frontend *f= e) { struct dtv_frontend_properties *p =3D &fe->dtv_property_cache; struct cxd2841er_priv *priv =3D fe->demodulator_priv; - u32 ret, bit_error =3D 0, bit_count =3D 0; + u32 bit_error =3D 0, bit_count =3D 0; + int ret; =20 dev_dbg(&priv->i2c->dev, "%s()\n", __func__); switch (p->delivery_system) { diff --git a/drivers/media/dvb-frontends/lgdt330x.c b/drivers/media/dvb-fro= ntends/lgdt330x.c index cab442a350a5..8c34a5b850bc 100644 --- a/drivers/media/dvb-frontends/lgdt330x.c +++ b/drivers/media/dvb-frontends/lgdt330x.c @@ -124,7 +124,6 @@ static int i2c_read_demod_bytes(struct lgdt330x_state *= state, /* Software reset */ static int lgdt3302_sw_reset(struct lgdt330x_state *state) { - u8 ret; u8 reset[] =3D { IRQ_MASK, /* @@ -133,6 +132,7 @@ static int lgdt3302_sw_reset(struct lgdt330x_state *sta= te) */ 0x00 }; + int ret; =20 ret =3D i2c_write_demod_bytes(state, reset, sizeof(reset)); @@ -147,11 +147,11 @@ static int lgdt3302_sw_reset(struct lgdt330x_state *s= tate) =20 static int lgdt3303_sw_reset(struct lgdt330x_state *state) { - u8 ret; u8 reset[] =3D { 0x02, 0x00 /* bit 0 is active low software reset */ }; + int ret; =20 ret =3D i2c_write_demod_bytes(state, reset, sizeof(reset)); --=20 2.34.1 From nobody Fri Oct 3 16:45:45 2025 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012009.outbound.protection.outlook.com [52.101.126.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB26C33EAFF; Wed, 27 Aug 2025 12:39:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.9 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756298382; cv=fail; b=AQI7dteFXr7DfP6WvbkxBsV3gy7xL54BzjOkHmuRv89FMo6/73BNABcPojLyyKClKGl9u5RuA0S77lOeV9bKC+aeAl63xqwu+O2JxW/GRJg6c3WqNfZFzrZyJ4z2BJVF1MlZ4Xv+Z3vpW9tDsHe7/nchhL8bKa8DgmnUekCCS1A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756298382; c=relaxed/simple; bh=JINE1CERO6fv6BStIe3ntJjCT8o2XKM4C1ypAHo4yrU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=i+SmtFDrhAUwLiKdNsWE7zT14rfInI7hBjVhlskbHaU8eUAInd8b86yvnzJReKm7Is8yTa5u4z6EN2JWB06P3SHr0NrgT5UF3Z5GTndndjLct0hnJMSj//SgdiuwFwJesQ+cd5GlrqUmVCc5qWiE9uJdXAzXrBa/XgUKAS9bCo0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=VVHLteJx; arc=fail smtp.client-ip=52.101.126.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="VVHLteJx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DX0ZH9frkzdulcOso3lvSiVHNBMUpFHhnbo+zsycbdHCGAAC7/VnfyQqekOdzt9ijm1f3pvvB1/RfJp0FdD4EAzS3bXC2UAVaujaf4JOTQaF8uU27RGxoavy81Vs1ojl+BrvW5PuwZoQwLXg5L1+8Eqet9gIFgOKlnhsdP5fyGySIjnNzwvuWxEnFTt0Fco5VcwXLX84v2/roliMqtmWysqdBGijysTNgG1C5+GP3+PiRXDfP1ch1DYArWPhBRbq9HCOyyw6Gr1qWcJJH2d9C9a3OWxgcENOeSO52XZBR/eTmHIoU6/3mwqKseLTHsyKhdIHPX8nuUtTjCp18qTIVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nf5DIGHoNIS5bLjn60h21foCkBGAHjnkH3z/TgcHr9Y=; b=TklEv/PHfZ1WlF/BMQ5vOs0uKB0ZR/96aEFrZI38tpFw3OqO3eB1x88uKCy0WBGPqb2BjihGQb9MgFjgbQeWg5ikRe4Zb+t+wP+p0PM7y3+wp+Z70XZlvWGPfdDU6w45OaOBKQVLoJUSfe0acLdAcSC5yH0cIFJnNn4iMgcXhSM5/Z10RF4WjrpdJQbC+qVHIOjpAZFeyhuENN854IFMIxdkG6YFmFwjmj5t2XavfHX1cHdo74GmW50eZmbFaFi7+8OBWvUtLvbAgm1qJymc0M1/7MuJD/HuLYUH3fo4QLEWj2OW1Vm+XjFKfk8k4StSznVPdpPuKIXe3yrij2My0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nf5DIGHoNIS5bLjn60h21foCkBGAHjnkH3z/TgcHr9Y=; b=VVHLteJxXnvpWIxOejsrItMKUT0qNuBFlqiNuALZRSbCtRRKvn1IMuiT8uzUwv1UQ9IzDWGiFu02uKC67F7S1u8xgL9QxOlrKxUnkgD5wiRf45U4lk7aKRNao2LWyyo+1IYJBjqQOE7ulNmiJ/c/bP35IvKZRqcEQHb2sI6deN9LfPkeGMMf8UxW0lgIQtDU+m8C8LmG7YCj4ZSzMomSm9eBmX+RcEwscdCy5uhjimkgEjD3HXDz2oeQTl6Fs914Tppe60S1fe22POKz+wqq5FwraRbY46n/cykYmMDnfxW2q9VvYzTsEazi60p0R0AL0/yXIiXvPkZzNk5GE6cUfg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) by KL1PR06MB7285.apcprd06.prod.outlook.com (2603:1096:820:145::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.15; Wed, 27 Aug 2025 12:39:39 +0000 Received: from SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666]) by SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666%5]) with mapi id 15.20.9073.010; Wed, 27 Aug 2025 12:39:39 +0000 From: Qianfeng Rong To: Jacopo Mondi , Sakari Ailus , Mauro Carvalho Chehab , linux-media@vger.kernel.org (open list:MT9V111 APTINA CAMERA SENSOR), linux-kernel@vger.kernel.org (open list) Cc: Qianfeng Rong Subject: [PATCH 2/5] media: i2c: mt9v111: fix incorrect type for ret Date: Wed, 27 Aug 2025 20:39:10 +0800 Message-Id: <20250827123916.504189-3-rongqianfeng@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250827123916.504189-1-rongqianfeng@vivo.com> References: <20250827123916.504189-1-rongqianfeng@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR01CA0049.apcprd01.prod.exchangelabs.com (2603:1096:4:193::13) To SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SI2PR06MB5140:EE_|KL1PR06MB7285:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d4939e6-e81c-427a-5f3b-08dde566c9c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4UMAavYMGUHnbJb4KiJUh9JbJuh2vOJ8v8i+tRYOSPl9GHgpq5vsTceVFsHG?= =?us-ascii?Q?VgG/AuQhe4A2d5z7e6VtlD5Z6W+t1oSwtkxP1VUr4DeKioE1B2fKAQy4A63n?= =?us-ascii?Q?U0Sf+izgpSw6/fXhnLIPw0dmv/g2h/PvpqB1WdtZs5z6Xv9G9ZIjLRyABFhM?= =?us-ascii?Q?9OYKPLwqJuvVATbje0EFv0XA6n1N1GObi5BV0vIKrVjEiE3NFAs9DfyBJ/OX?= =?us-ascii?Q?SPYedOZ3TNYFsJP8jvg3r2CcjquZ52lwIXWZvyOeYBd3VSyOejs0/GT7WP5b?= =?us-ascii?Q?MrBuh3gS1N6MMCYsSKuZw8ToiW9mKAENxWv1h4obSxEykuVE+azSUMnK5EFy?= =?us-ascii?Q?OwzcFjQDNWw1CisjZSLp/JPJJeNWZ9OXeJFpi/ipwqSPeAUUTUr7VmRMrCft?= =?us-ascii?Q?m0Ir8OizxcwrYL9EARLRmhttvkzgZi0PjpGGlhDpOEmnSpk2l2iHHIXHiimg?= =?us-ascii?Q?BstAe3QgzZDLctCtYZ9n2CHGGs49UQNQj0pbpU47c7DZ1lgJbaG/BDEK6MD1?= =?us-ascii?Q?dtLXjU+v+MxHvcVdeCR7CWHgMPyS2R43xtwI2C0v8OpCkFxwACMB6O0W6+sz?= =?us-ascii?Q?vn390QKK9SVKIU4jt68U7Nbg4/l3SOJfsOv6d2QE9kHKwRMhiyKHdnvyVn8w?= =?us-ascii?Q?FHs0saY3ZJHGLy1x0w4NBk8xlULeNFg6kNYY0gNE4sgkUC9NjRn7DDGyJN+Z?= =?us-ascii?Q?U2pfz0qg0yMknYS1c/jsb1f6ib65VsNT1eQBrBUTobmRy+SucIlDfGi72z+W?= =?us-ascii?Q?d7rBikGOb22Dz1Yt0RckRUtecxEGWlYlPocamz8W7EngBUakT72LAqNCMyMb?= =?us-ascii?Q?kHriFXsgRpuzMPPBAW4tzLhT9qVOOthBfSqkAxfoJWApY52QYTiFflQjDJrk?= =?us-ascii?Q?0y83o8x+nRytx4z986NISXlWwOuZh2EU749AKbI7ojBtVsUJa9W/N02RmE1E?= =?us-ascii?Q?c0ofnf3T0M8+jLBIbosN6DAI6E96jJU9lfrFf7eQbm5WrBOXKsfPp3HDYbv7?= =?us-ascii?Q?Ep2jT+g7KenYJ74JadEDSPda30V3UfhsP+oxwoDuosjDNX0inCjU2NPLX6tc?= =?us-ascii?Q?dWIJSec8NK/eAMGkd1vJVGqg+xrjUKredxxcpo3RzQ0rOXjnVpb+TzooM9mw?= =?us-ascii?Q?8s+qkqt6AAfuKSiljlrznS34fYA5lKuTxkNd748xki4GDidiAPTSc9/dW5/k?= =?us-ascii?Q?4NOEGyPMVCyOC2M1qOHiLgOe2/CEhZbE9Ymi8v7kfVEtjubS4EBcBtfAbOyW?= =?us-ascii?Q?7Wdo667OrLV0J7h9eowz4bsUu0kB8ZETWSQzClGSbxMoBzZQV96qsF6c0zSN?= =?us-ascii?Q?B3DrdVqqxdwngVMsgkMsjIRFW50k0LupN7willeOTAXLJdUY7MnqcbXfvsCf?= =?us-ascii?Q?d4/keKMCWSEN9ff7u1V5U+AMlvgJzcrhfG7J50kZnrrSeEOVEoH6J81W733s?= =?us-ascii?Q?/K8jCOtcXROjk6KpOZx/CeNiO5cyLr24nD+7xIlHO1YJYRNKyheDcQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SI2PR06MB5140.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xp1xb4Pgh7tEbBXU2B9yKU2y1l/YKVGO+epBnAtI7P6xAwCTB1+lPl7SAJgO?= =?us-ascii?Q?ye41ArqLk9IuAtDVZLTDHh/eHGwGW20WPzCSI5LZMttjFJBPaMyGP14KYE++?= =?us-ascii?Q?ShvLcDfWek3riYlGpsjx8bKMWlfAfMdXUpxoWRQxOIaMBnhC/+EEaJ8pbpmK?= =?us-ascii?Q?1NTpMPdVFfdD1g/MrlzbvK1HxBPbE8Ft6JXfBgE13nOCHoTk2zaYyyIofdhU?= =?us-ascii?Q?0pdJ78WR8nzvg7DGk3SYZeg3RukC2oOssHX60XijdF7iUhLEpcMHyeWySUYD?= =?us-ascii?Q?VudRdM/ETLgFHMB6/B4dD1YWku/wsTsrDInTCv9KXkZ4TV/RZv6zMvydP3Ks?= =?us-ascii?Q?xVsugN6ctO4me0XGyu3cGhXvBvo2iZl7bu91lgFALj9Aj19QC82VOI6TADMD?= =?us-ascii?Q?CkgBb/ymur7wIi+z1CrkA/f4dg/fbzbFT6vXTAJ8J9X2NSPe408vJm3IAhfS?= =?us-ascii?Q?hOAC3/zteNxAwlT/1LivMlCSauFYrIWaFnwYFYZRKgi3VYNolMyxPNiTgq3d?= =?us-ascii?Q?EwOmOYg2UI9kA7EW3v7URXtQNaZFvbm3kw76B/H8+AbUCEZhppwUE0ppyr0g?= =?us-ascii?Q?t78d5nE6htCHn6COHj1NqcgiK/3Tv3WwirVHWtI6pRsX1EiKyJzf7RFnkO5C?= =?us-ascii?Q?wsW0DPWJCbWIJyFhGWDqXrcoXqLUpO3Mz1w29jrEM7FdFBZLlVVHuh5ZfuVU?= =?us-ascii?Q?fE/HWy6I21E+bGicFfcrOSoRLOT2LE3St+BbpBZS8Oz470HKB7V8f34tHbjh?= =?us-ascii?Q?VRtj2nmeWkVKn5h1RkZF3vuz/swQmkEX4o9SYTNKC6VgAKKwuIkMVic0YXbp?= =?us-ascii?Q?cNec+3YiH4Nd0Kudp6focnoXp4MR6Z9ZVvqg9AFyDq+b+nNjpmH+g5F2VBgS?= =?us-ascii?Q?pkD1xA5zEnJbbsiXtXPLMLyzuzWZKkJylR9jUi6f5ytjubOboUrfSlCUd4aP?= =?us-ascii?Q?QjaQmPF8AxsUhdMpNisxy4ycnq/FsB+nIU8vMrLsUZLfp5Fc2abYd6DleRbZ?= =?us-ascii?Q?mLpGneDigtuVq0B6CPAgoo6LwuNLlvgyyiQdYXhr0n2uBdCRQR1YtqqY7Sov?= =?us-ascii?Q?0WQH5lQJku+T10bzG7o9/hePYDF7ayKqXMpss9C5yXTXdfxZfjM05zEilEj5?= =?us-ascii?Q?zYm0IsKcIEJBtjYuqSCCpNiWtCWo++HkED/BCracu8S66cur6je+H5Ea046c?= =?us-ascii?Q?zBk5xdPEqoOBH2NjRP1KPdWAOBViDEnSlYeaUZxbU8mhX/c+5aejA7c+WyB0?= =?us-ascii?Q?Z+cA0r5A/bgqfLdxrkB7f0MRd0e6bwQ0E1O+NgG2zeXgK5v8UuAS43qaTKT3?= =?us-ascii?Q?es+XcsriWFiqcqHMWHzfgJqfrlgPZ6+WZHx1OGFuiQUxcArUPOFd1vSMdnzq?= =?us-ascii?Q?ibiNe9fcv+gzR8gcJY5pwI8BRchXqWU9vsoWX9YS+iHpquF6sq1uxWc5HJUD?= =?us-ascii?Q?Pa40BnScSnsvbvxubF50bvBEbcgG0UmIm8SlmSOXan+6x8aKq6BOmdM6dpzR?= =?us-ascii?Q?nmaRNp49F/oeO1SScHEm12k7q49Zm11sRqd27kNYLNeoR4jNPBivjfIAhqgL?= =?us-ascii?Q?nc4IuwVly5Gsbkfs6Q72zPC0KL+4wam+/2VgEeQB?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d4939e6-e81c-427a-5f3b-08dde566c9c5 X-MS-Exchange-CrossTenant-AuthSource: SI2PR06MB5140.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2025 12:39:39.3648 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BuSQpz0ATcOCL87qhrWQj58SAbNkxO9uZ+7dPUMZQGRgWDUbv5ZTwdEG09QeisxUKauMzqTv+O6flJSKvd1kIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB7285 Content-Type: text/plain; charset="utf-8" Change "ret" from unsigned int to int type in mt9v111_calc_frame_rate() to store negative error codes or zero returned by __mt9v111_hw_reset() and other functions. Storing the negative error codes in unsigned type, doesn't cause an issue at runtime but it's ugly as pants. No effect on runtime. Signed-off-by: Qianfeng Rong Reviewed-by: Jacopo Mondi --- drivers/media/i2c/mt9v111.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c index 6aa80b504168..9d724a7cd2f5 100644 --- a/drivers/media/i2c/mt9v111.c +++ b/drivers/media/i2c/mt9v111.c @@ -532,8 +532,8 @@ static int mt9v111_calc_frame_rate(struct mt9v111_dev *= mt9v111, static int mt9v111_hw_config(struct mt9v111_dev *mt9v111) { struct i2c_client *c =3D mt9v111->client; - unsigned int ret; u16 outfmtctrl2; + int ret; =20 /* Force device reset. */ ret =3D __mt9v111_hw_reset(mt9v111); --=20 2.34.1 From nobody Fri Oct 3 16:45:45 2025 Received: from OS8PR02CU002.outbound.protection.outlook.com (mail-japanwestazon11012042.outbound.protection.outlook.com [40.107.75.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73C8235082E; Wed, 27 Aug 2025 12:39:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.75.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756298387; cv=fail; b=WqiI76I7xLYenW/UWgflqjg77nAZzJW33t+8ZAYQ+BO5xed30fAddmKkV+zDzuY8E8TznxD5hy2mzo+CfVO9EXZCHkoTIqEr3hJOcW0nr2LfnvfO7yGdG0gX2aI8tw1QcAZmY9qcCg/snwJFwVGpZrnyd3RAl3BPo/lVeW1JnBQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756298387; c=relaxed/simple; bh=n4wfPKi/8unXx3hQa6juv4MI5wFoFqfBghOwAYyyHbE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Dr7zhag0fc+RQTywjbCqVPZam6MDQuvzlHZp+L0td30NncrcTyX1uRRyV/6MyNyLGZ+o460RxHz8zWKlscxDPrl3OipIZ6p0fTA1VgW2WfmzvnoIlVoxQ23iJ86vCjfuddguERzJaXuZUigegmiRgDnPcqU+x3Y0Hq38FT1e114= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=ZnDRoHD+; arc=fail smtp.client-ip=40.107.75.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="ZnDRoHD+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=phLOmAzVbR8SZ075qpcCjMuk9DRiXfwK8os05pP0rORGI+GN3l8yVyOtlU/Rydg0OmRb4VZOncI+Hp+mBPboPK0ANVFPVybDGnpr77AzQM4nq8SVan9V2/kUfHXAXsEAnnZ7PxxPYJDldD9y5ri+2QBoZRsFjRBQcItHE47QZghVfJemtA3TpzJtcEPba9Hj1xNlN58yXf24reG83Iq3AsNkUk8hKq2r6DdSnYJSBS9ANrTILhBdlEqfFZaO2Ox4KF2eXw53nILjSMbaruiIGWclFZkxjaievwLmDAmLpHkBMVfT+J9Id4sHXahO1nk9dYkRhaF+2JeXYsecVVR0dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MxoCh3ecuwz4cLiPho1kgLVK1G/WMmhcVhK4HenrsFg=; b=L2k0jM63YyreYg8QNwkiHPxlXOLPshrpE+gOu9H84S7YV7+pMneYqgqTvIOv0/exils5V95Hj2R56IFrATCkw9U3jlS5b2ljTJXSewnszpJkbiZhobAF/aFP7YzrOxp8p4J+RxrF+9BPeDBgk4hH4swbpfbdMDZMUcxXjvHMcesGHHsnwvgrdGqM6FoV1eTA4UvGdGsNjiZZXxn03ONAk9hw5j42WriI96sHX8yLVt3P1wQ9k51WEj9IylXHliOyuNkyBi3lng0UFsuXGyFblQ32Emdygn3NwHa9jQ4znAEUyJJxMQTGm53uVUj9VcIeeDWCROExXTsj+HAyHdYTYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MxoCh3ecuwz4cLiPho1kgLVK1G/WMmhcVhK4HenrsFg=; b=ZnDRoHD+dROZPlX1c3hVO8RNyNs6ivGcTjru8C4ZOHZ/9XxmzF42mR0oDGwWYBnlGCMwpWJ9dcgU3UOFURStqA2df/wZ90tfazrbbY6Kv4apVAsmkVqHHUS3rm4JnqpkMGwEop328VSlhdGjbsSkABuESioV+WAXrRjAX7i52rx2op0FKHR41/+U6Fa4MorzuJmjZYcCynCvo1e7tKJOShiCW2mRxu6NPctTy3hb0a2/Enkb5Sk2J3BtqU05+8X+G6uFfo2pmwmLYzSi3MqO/CPEkLrF0qZgfsxjpiuwfbR7wdroo0DvTVVoUS5+DdAz9KAe3X5bwVABwKYZwpXI9Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) by KL1PR06MB7285.apcprd06.prod.outlook.com (2603:1096:820:145::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.15; Wed, 27 Aug 2025 12:39:41 +0000 Received: from SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666]) by SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666%5]) with mapi id 15.20.9073.010; Wed, 27 Aug 2025 12:39:41 +0000 From: Qianfeng Rong To: Tomi Valkeinen , Raspberry Pi Kernel Maintenance , Mauro Carvalho Chehab , Florian Fainelli , Broadcom internal kernel review list , linux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)), linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Cc: Qianfeng Rong Subject: [PATCH 3/5] media: raspberrypi: use int type to store negative error codes Date: Wed, 27 Aug 2025 20:39:11 +0800 Message-Id: <20250827123916.504189-4-rongqianfeng@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250827123916.504189-1-rongqianfeng@vivo.com> References: <20250827123916.504189-1-rongqianfeng@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR01CA0049.apcprd01.prod.exchangelabs.com (2603:1096:4:193::13) To SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SI2PR06MB5140:EE_|KL1PR06MB7285:EE_ X-MS-Office365-Filtering-Correlation-Id: fc12da85-e484-4729-f477-08dde566cb3c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?M9gGSu7kp5q/+7lJ5NG0/uGoeFdobYedVs/g/2tXoENnJs42q1+9F1lNNNiL?= =?us-ascii?Q?AssKw3J1Vx8hTREmSUZsmEPsfM1StfddTWkZU5htTBG+Q/k2CTMdxeD/yvAi?= =?us-ascii?Q?/A/iLSkHPqlmqSMXOTcz2fBuCHIU9GDff1ZFkpPryfie3i1DixIGliUld3uD?= =?us-ascii?Q?SRKttUuMwyjXRuYaqEnu/9x79FbeEkon3QdwmSHH0TgGFWPgOCyhjy6A+d5w?= =?us-ascii?Q?pLjfScSblBfg1Qd0EEzNe9QRbzy7d+dxE0agWQnCAb4zRC9XixgTKa/pznMz?= =?us-ascii?Q?bagkKk2Sfxac6Lr3tT9hvU9HhyVVg13Es8xiN+vfSe9HnUgzEAPfSHuMpZQJ?= =?us-ascii?Q?qnzvWXB8UqV4/F9+Vb3Ul3s/+GhRg9cmKAPzFUfYV2V9vr8JPtDlynRJFdYr?= =?us-ascii?Q?WQ2YOhgn8cB30pgr5FBkGrBep04stHRkwBcZ8h6z5oDmc3qhFg/n686q5Dx1?= =?us-ascii?Q?pb8C7ITKVrfLOPPDpjUCzVeJttnRjRFQ1fCbofWoLWC9diTY6IA21vn8eB6O?= =?us-ascii?Q?j328lXRTd38JqVPOu70Jdkkcl+H5RlJHl+VC826pMYG6dHoNtgG1VBUfA+na?= =?us-ascii?Q?veXsWOKgfCRTExZUo8JETcojeWgemh+jpk9N9CI55T8EPMS/D49yD896fpxp?= =?us-ascii?Q?o7rs9kDj1H967uBkoGakClbh8MaDsYPNNhtNtFfBFhATEpCX68O1cxo7qtbM?= =?us-ascii?Q?Yt9o9YnWeaRJrY12xVw6exP+6qkKA5Vn+aEXZ7GUZHecFYK8WjquKZ0bpU8K?= =?us-ascii?Q?nG20SKiFe3hKF3wwwU82I0+4rWAgz799FXgPmAd5mWd4+lEjaQZHkuFOKJhW?= =?us-ascii?Q?+HB97nBy/QKKFl9wtj8eI/iZgdrqV2qLvDGgA9q16QvvtBzAXpPiJydWdq8Y?= =?us-ascii?Q?u+S75vHXkQ8OpUp/Vioj8Pv7RqaA+J8GlH/RGVOtjA4oI+61pOQ5x0flTzhn?= =?us-ascii?Q?z6FJC+znI86l2Gj4o/sLcoJl4n9cFAMYt9yNawLuQUosTkFJatC7zBrdkldR?= =?us-ascii?Q?3+5ogk0ZTW77ahGAsAumMnFKCXGrekPXmF+z4vAj5wjCGZay2C+yTmY5Lct7?= =?us-ascii?Q?VHbbdIvK+07Oawtxa5M7GQvJHpA9ooIrcrjVQWHnGmAkYrBtod+f3Q6v+Kgk?= =?us-ascii?Q?DKg9UDu5Al7rAMghGL0DZPHRhD8rb99Tn+PVWosHX8VoRZ5FTIkoK3bSuC3Z?= =?us-ascii?Q?mp6GPya4X89gCBdyPBDWbaig6G12nLlsQV45FV8lebc86BXcdTTjlNRnXtPh?= =?us-ascii?Q?tY3lv8ua9bvhCRw6Bsa4OYCqCv8EqUGyZbnvRFyCczuFm1Zi0khIGWj6bBVJ?= =?us-ascii?Q?I63UtzNfHimDKFPHJgKRpKB7ZmX1kb7JFkJdBKxa1LLKcai4hiGj0CKx3Ca8?= =?us-ascii?Q?MQ0Q+0w4p5TbhP1EHMXNs3HI0Ak/Z/3GZpfI99xWjuzKw7volfSy5mGU4G4D?= =?us-ascii?Q?22g3xd1dpJknzGUpJiz3rxes2AjiaAjpXYpv+VOdlyWZUrEeYEiwaA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SI2PR06MB5140.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2LiZYK/23a2FFvX3ZP4zUWy4Kz4LsO/f+sxFHFuWs+YiRj/NuCn+4BZCauin?= =?us-ascii?Q?1xRjbWxxpGDlqcIF2pezAyCLhb1yZd49e9RhXFqU+QZFAzkufLTxjHGPbbot?= =?us-ascii?Q?XYD0tc65Df939ijoK4MfI1YRn29l59FEb0+AcTnghaT3YkEE3vN9MMggLe9C?= =?us-ascii?Q?TtgZiVmk2VWhOd61e9mGsfd+f03T/VkdH/hSkoIYkgLCpeO6ccgwGgjtAaNO?= =?us-ascii?Q?coTyzSyGubF2d0saqCnBTVHhzH1d0l9Tv4C/Zn6E8PItmrTluIyD4udpeizS?= =?us-ascii?Q?c8gNDhcHotMPWv+xPV2BjPLwH3KF4uJZ/1t2WKLXIa56Zt4qwJREnJF69/La?= =?us-ascii?Q?b+HQZAsAsIWPl0EuoOMN1xQ3Qvc7OpxShbio3NjDUucd5UXCkuml6o5yZUpe?= =?us-ascii?Q?wqZz2+HyQt5cqvjKVyF1ffnNvK++Vo3YqY/M2RIdEH59KoEaZqO8PhDeb63m?= =?us-ascii?Q?cM/nvU4b/BwmvMvBd3li38eZY43Uhd5jWU3G3wrjIk7cIne3Tj6IuXHbylaZ?= =?us-ascii?Q?sva7vnnY3yycoaLLwz0lTo+rsfHJ4+03Khyl2YMqU8f4ziirJxicUUYOvmjN?= =?us-ascii?Q?9GhabxlD3f4nb3G4vL/BnVavfHZJCQ0fj9ZY6JeyifmcEbR5zVr/1Zg31Hth?= =?us-ascii?Q?Bi9tLQ1Yj/yqFDuC9OSFL2sK4zaTq/xR1+PdTHLvNAD5kfoDa21MoPFUOunD?= =?us-ascii?Q?HvqTjtE+uXt74+n19f5XNu/33831/AyjyoGPzieH1199Jex7Yrb3N+WCsy7F?= =?us-ascii?Q?0qhvUb6I+gitxTLtL9Mop5jNTNDUnzH4guaAWQDWq+wlz4MwaZPl1Uso0DYA?= =?us-ascii?Q?LM9R+ZEiFJa7h0KQZ/AnDLHj5zn9L91aOpH8m2LopFaPv7MJBh13s51RtVxN?= =?us-ascii?Q?V4BPwOoF7SA7omYA+agYCvTb7k5uHm55ECb1zcBOh++ugAnVJmeuQ05yGKDI?= =?us-ascii?Q?5YzGuFsZnnMPTRF3leu0XX341cxwUQblnZ2vzYHAtjgBhtLeeui3hekFfmPO?= =?us-ascii?Q?Ub3lLSM7nWf9oDtT9sHUHplA4YlDlyLG1/F+RXKKUbXNozBfGdsZKAi1lE+y?= =?us-ascii?Q?9CqKjpps+ibCUM+YikTC0DmNoPqKfmdjHOli94eGyQIZCt5MTAx3v7gyN2Tk?= =?us-ascii?Q?i1+0DO1eYIFNLQ0+scRWDkO9DrLZ0Iso0iwgt6vF2cJrzQLdnry0YnVR7nM+?= =?us-ascii?Q?8CQCNzOypoUjc1QCMMrGskKDtaJkUR4ZgXia2d0gFx7S8DU4eTaibA3SpCgq?= =?us-ascii?Q?U3dP9SySl3GjlrBzkhkIEPvsD3pKn5BsaWw74rqW489GAMslTZrFjJ1uMBoB?= =?us-ascii?Q?ZOWI9u17v1LFbpKBvnkmz5ClhsV3Jk9V+VqUqr3V09pwy0Xb/xUzBIALwwSo?= =?us-ascii?Q?2r+Zb4kdZ7O3kSg3vqtFP1pRt1gPaQAPFjLYffMz7y3UBKlQNCkg6RMMttKj?= =?us-ascii?Q?cjlmLAZh0QhXcHV/VEiiYLchbYZwSme6BoYeL/Y3N1YhqgCllgrrYFvXMtXa?= =?us-ascii?Q?QG6QQsRaYxnIDTAZpUH3mIQgAISrNemry+1fkSH2/PZQXilMSWo37Be+puwp?= =?us-ascii?Q?YJD797jk7A/tkkUJduyZxOsbOvu2D0aeYE/51t5+?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc12da85-e484-4729-f477-08dde566cb3c X-MS-Exchange-CrossTenant-AuthSource: SI2PR06MB5140.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2025 12:39:41.8161 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xLFWh1MW8Mbkm3c9jn0uw1fIZZNzkvwLcRwFv10+kDjQRzBY92VAHqVZVmmyItkamj2mi7qqFFMR1W+h927L/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB7285 Content-Type: text/plain; charset="utf-8" Use int instead of unsigned int for the 'ret' variable in csi2_init() to store negative error codes or zero returned by media_entity_pads_init(). No effect on runtime. Signed-off-by: Qianfeng Rong --- drivers/media/platform/raspberrypi/rp1-cfe/csi2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/csi2.c b/drivers/me= dia/platform/raspberrypi/rp1-cfe/csi2.c index 35c2ab1e2cd4..2c5b4d24b4e6 100644 --- a/drivers/media/platform/raspberrypi/rp1-cfe/csi2.c +++ b/drivers/media/platform/raspberrypi/rp1-cfe/csi2.c @@ -525,7 +525,7 @@ static const struct v4l2_subdev_internal_ops csi2_inter= nal_ops =3D { =20 int csi2_init(struct csi2_device *csi2, struct dentry *debugfs) { - unsigned int ret; + int ret; =20 spin_lock_init(&csi2->errors_lock); =20 --=20 2.34.1 From nobody Fri Oct 3 16:45:45 2025 Received: from OS8PR02CU002.outbound.protection.outlook.com (mail-japanwestazon11012042.outbound.protection.outlook.com [40.107.75.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6FFB350D60; Wed, 27 Aug 2025 12:39:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.75.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756298393; cv=fail; b=oD+kSPF2nUxyLXsEzKD28e9zBYz2GjrbhfUoPIJSS4Rn31Tow/XDG/sUt41gMiPAAHk71YBXm+86qHKODXqlubdYEW+0Ii8bwNOn1tXnLEvur3FvOw/aMrZzxCC5tw7uQ3hrRea2AWO2pHEgwhBNCutwREzjmrGFuEkRJmD4HUM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756298393; c=relaxed/simple; bh=CjKzQSz8711fNqK5805WnCU2VwIyQYB5cdar1AnXsPM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=etbLpP6vEL1fVZZGwj3ogK3jqdjMOOAK54sz+qKGhV8gN9NLsT9s/2I5LM1HaNLau34Y15eNNUBAyIzbQz0ga3XpttOSpSu1swQ2VEwCA3jdPhnYOXozk1A/KsSQw2nVXD2tTW+ptwxNiQmqwHXqpRJCA/VPZ4ZGfVwnOyurwCE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=YLOLptXb; arc=fail smtp.client-ip=40.107.75.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="YLOLptXb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZNY+H5NKw9WErU0KaWMRakk5KyOkTH1DXKPFUUEYNphjc+okLa6SWvn+AW77YLMn0QRlifND7wyfVl2766wagvcSktYnwr7/9VqW8ENfb3D8yfrGtS62+kAf3fYwpCM6csQIsoZzblWL7zRJb1jSlu/rO0Z+oBYy6NrBec1dXNDnoVZxPyDM7t07Xl6LwoIOTamrCnljZb0HdIounw1CiIdkXpXBG4qJ6ZyloGaCve0n8ziWt1kY/GXeQZx3yKeUgPEPfSQaRuEZ++z+ZPiqqpXDJdKGOVOKl+e3M06MxBZQ1GJyGTTyX9DJU4UBZu+7b+DwR091CgoVZ9k4mcgjUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=whso1J2BaMBiQxxKxN08xWN3/B0cVCWKBccNBJihp7w=; b=Huh/oH8F7lbsYVXSNDU5J9dQoFoIbpRPZ0m69n2nP/Ko3TkysBkfJAxFIf+Rzd4wNvlIlKShtcrXsY2RJiqoSRO7Ua9CQmY0kr4107JLY87WFq/+8ioxnJeh3OnhasbsPCXqEi+SqLBSSmHiw/L08lEBr7CxKoLQ2ckfQReuE9y/qriYTmK1nslLYFmbSr6Tgzmg1xWJhP4zAP7V1bk8m/4zyPSNFst3YHcas//QP8v4932zQ2bSx0G866OlkI9KrRXmS+spm1D44erXpOtviTYTEPQVEdl25lmmJq7jmICxzXcV+xl99/b3CzqbP99w2/MIYpD8rETg9OsMnYsvPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=whso1J2BaMBiQxxKxN08xWN3/B0cVCWKBccNBJihp7w=; b=YLOLptXbqsVbYsGTf+s8xrnIY5Hz05XxoFeBBcg+OdDXcUyD7N4fjgvoeqISyW/5jfjlnmhkuauOf/OQQA+iLaZR8YLf3J+QPGR8ZTacY9J2TeQls8mlqElaQNLpaeMgsYntu3/Z10gM+MvTx55A+Z7yGdcV8Lfr1Ns70U4C3wRWfdXZrlJoAZ+IZfHIW9CbcrQ1PK/aVwGQTheScFYGrX+Q7Ls2TnbJzYyLJJVVyja5/uL0Di2KI+zWJmzU85X8Di7blsFs+U2t76J5fFOHjIz6xeRsZ2Q1AoRs3jwoZuh28Vfh+Luwn36ud1K45W3z7r/5R5EbJ5bEzZEQiHZLpg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) by KL1PR06MB7285.apcprd06.prod.outlook.com (2603:1096:820:145::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.15; Wed, 27 Aug 2025 12:39:44 +0000 Received: from SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666]) by SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666%5]) with mapi id 15.20.9073.010; Wed, 27 Aug 2025 12:39:44 +0000 From: Qianfeng Rong To: Hugues Fruchet , Alain Volmat , Mauro Carvalho Chehab , Maxime Coquelin , Alexandre Torgue , linux-media@vger.kernel.org (open list:MEDIA DRIVERS FOR STM32 - DCMI / DCMIPP), linux-stm32@st-md-mailman.stormreply.com (moderated list:ARM/STM32 ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:ARM/STM32 ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Cc: Qianfeng Rong Subject: [PATCH 4/5] media: stm32-dcmi: use int type to store negative error codes Date: Wed, 27 Aug 2025 20:39:12 +0800 Message-Id: <20250827123916.504189-5-rongqianfeng@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250827123916.504189-1-rongqianfeng@vivo.com> References: <20250827123916.504189-1-rongqianfeng@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR01CA0049.apcprd01.prod.exchangelabs.com (2603:1096:4:193::13) To SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SI2PR06MB5140:EE_|KL1PR06MB7285:EE_ X-MS-Office365-Filtering-Correlation-Id: d33811b3-63e7-4cc8-6317-08dde566ccc0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?tDF8v98OEx2q76tFjCZQIuEACokeUBye7QfFNgrVIfrHKu2AxBI9FfW0goPb?= =?us-ascii?Q?l/+/njPC7q05EfAILgCT1k7ikAZjgrO6mB5LpLWbxRI9356a2VFP/7svPlyZ?= =?us-ascii?Q?pqvyHE2ElTHRJeKJuAU5hw+QU0j0EmPDl4RgtLwpXnZw+mLc5RPWYXwRzR59?= =?us-ascii?Q?56RUtD1lyNASrJ++5wcfeOoWBBPsSVg4GRJ3FaKlV78mpQVe8s42Dd5Y1xyT?= =?us-ascii?Q?8lXR6rzzFtf8VrpXlvkwFNrK/62eRLZ4lVeZH5VCaSzUCKNqpR+EOHHjAHeg?= =?us-ascii?Q?R8K7ay4hg5iREF5TVUDhyYa2oZR7qCGzc3XikFEcWXwWF7DTzeZ+SgP2ZN0W?= =?us-ascii?Q?/eeaWGhL9kDqoRsVc/GCZ7kR6ltTUv2peC5oiV9G3LzG4XuILK6pQ+kHMi0e?= =?us-ascii?Q?4L0QMTkdkzKakByYzqPns+QF3ESS7lwLDSL0RDuwB8QBr/usjt9uUTjw/P5y?= =?us-ascii?Q?U4mo3rAt/WbU9xWtXmGQPlkyW2c1TzAUZTnMFB/gmATPG1E7gAl0+V1BRjyT?= =?us-ascii?Q?yuOxSL21zlOwQYvTgA1STx2PKuzPjKr+ju8e79PcBJgoqqMsfsHdob+1nvsM?= =?us-ascii?Q?zFZiUu2et+ADtD+fBZnnAWX3IYzekoTD0eDTOXlh3d10vn7DCdBYJNkmUaxZ?= =?us-ascii?Q?C7sdIGCtqVdtlXvCn0X2bbr1XWWNmJI43/EKfNtmSZEXvjrKkYdC/PjX9w1l?= =?us-ascii?Q?jkJPc2sv0BtjdtUtpgLqycdHLOldXd1TxEhkd7eQu6xmBcqbQiqvNSWxPm9F?= =?us-ascii?Q?euPA5BLHkZrqegwQBSDpIAH5qPPpZjoMFGQpZZfXVGl1sPASxIVpPUmN9Y75?= =?us-ascii?Q?rQid1S3M97fja3OIin8EFKvc9/Kl5tXdhGNBNno7wOS1B9QAZi+UpMtx6siu?= =?us-ascii?Q?bQX3v/EyuVPntIn+Uy6oHOWF2zpUkfwbUyBQDOh6TUNK7DGKFOq8gbbQtsLe?= =?us-ascii?Q?gLWfy4gWbbxXOubcohsG6RIr/83SIIiOsmksj+e28m/lei0LEMMGiZ+fsbvW?= =?us-ascii?Q?oq+VbIgGLrEy2JvmduB1yfsDb/XR0rFxim8vKQ/xqJtyNnyntKF873AhotcE?= =?us-ascii?Q?MNKp0EkiHQPeCNlWhazuZTKr2qi0KPNEHHxfnLT5y+EQ1mVPJ9ioO+Ub4xi4?= =?us-ascii?Q?aAwK3PMphobi/lqVqH6xaA9lXvzmUX9O2dHiVgttwK5/IvAnyE7N/k53lHH1?= =?us-ascii?Q?VgGJMcjEP4lFvOh/I8ock2O+fZC5Vuntg9gXSeU5Tf/xPH5C8YoV+/XwTj/4?= =?us-ascii?Q?IH3GYIUPw4nRrVFRhZgCcUrHtAhP8TRYbuEEkK2PKSMaY/n1ePi0t0zXcHB8?= =?us-ascii?Q?wGufasYbwZZkBvT0hDg9E1CFxh3Ba6aPWY7dwfYK9t/9nnezP82nH0jdRtd6?= =?us-ascii?Q?Jd3zPu9v5sHwa6AvTAKUmxXrrOsJwj0+w+dea3sx4V/B7NlYdaMIpADkwTp+?= =?us-ascii?Q?HwN0p9FibBWGdTgde6Bx0zn/JlSBBwO3a5qNgMJJiRM8KsurF5VerQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SI2PR06MB5140.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zjLu3+q6xvXA9onWykDi6HTV9tG39v/EDsowKjrUs/3OzE2toh8FBCir8uuC?= =?us-ascii?Q?mXW1UJe5wtcnOorbjgfgVId7b9YLonwLjPTplj0x5hDr2zT3cvbeF/ft7yYd?= =?us-ascii?Q?w7Z26vYTPmJ3QR4IGvK0IID2DsqsyGlvYHtf/g+giU5h3v+Zz+jiU9VqkWjP?= =?us-ascii?Q?11XnK8pWFtZ36J1tz/NlaH1MOanqndiRTUr1LKwqp1EoyK+/scXVhQveDNn5?= =?us-ascii?Q?GP/1KDSBGUHxX7ty7RWK0qtRqcv8VWrH0A5JWS1RdsKKHGhQ04xrHQ9w3fd4?= =?us-ascii?Q?sVnxVqyhb+ZDg3YiMLak4QAQYqRHX71GBOhpn7V9gnL6t7uJfKvZDvSGiLrf?= =?us-ascii?Q?StWoiOdkjZxqwWSJxocRkIDhQSolmImJApWbGgSNUWNPE6EQ79rY0+NOVLr2?= =?us-ascii?Q?b55h4bHisAELRsRtcXCxuFNW9QkBOmxVJZCFavxsvyOlmiJk21UMXaGq6o1z?= =?us-ascii?Q?qOrhOd68t5Ii4QudkeU6mfqnBVFhFWOnPSQYei3T4O+SPU/hrtELqsypRXsZ?= =?us-ascii?Q?tB3DnOKadzKNz6eSTcvVIQy2UTdi6d1kw4JGOI0lTm9WFFlksbB17F+bTgiF?= =?us-ascii?Q?wzv3lzN+L9cOZd1rqVrNNPOYChUG+/LGuQt+WAroKWUXuRciEpysdc23WZ4U?= =?us-ascii?Q?fcvFwj4hPzwFngDVj9LJa1V1neV2AoyfpNCVxhX5LAbtICWPoZ9Jj8rYvvKv?= =?us-ascii?Q?7COotd9nzTGJlogZEKpXeAVySXBQH6vHGtiiTCNqHz/6u6vtgps6XV/tVJ6d?= =?us-ascii?Q?OZ35ycE7RGJT3vQPNAPtRBd5mXimVY/KdYvRGfCHCDrmzbPBMznbepG4cDw0?= =?us-ascii?Q?WDkjyS6xJad1lp9IXAu90hsJxKF9OgMp+u/HzFPUm9FYux9MBZZ5GBOk8gUS?= =?us-ascii?Q?NqNKDW/aap+rPBpErYQuSj/OsrAEMH0xKohMA3SsqDQVkyMYXLhvTPZ8pW70?= =?us-ascii?Q?OZtzLKpNODnmL6WE7qHvDY/SFNdiB5Xkn+cYUbV/zFOzTNfEN4OuzbWDTZKc?= =?us-ascii?Q?JmMydSfwvSZmQpe5GTs/07SfBZQPq1k4zfW3f8BrUw3jkWDw5kKfOya/pu8j?= =?us-ascii?Q?Ooc6HWE1Wsp3GSiyeR9qhFw7gdmTqKGar475kivj888ukwYOs1KbrH7XOQe9?= =?us-ascii?Q?DxGNEftTGZqVFu7mo0TxeoxGIxmiyHDZie6pGv7xuBHf7UJHzp0EVGYZnyaj?= =?us-ascii?Q?z5knhydM+gIzyMX5yLgLqqOF6AQZq1T4Of59gU1HhBupD7Uc4k2Fr0Z2vZRI?= =?us-ascii?Q?RVGxQPlqHjP/NlHJkZ9tOPvwdpcpzgEciGEYmQ7uiwVObOPVokwKvJg3mNPZ?= =?us-ascii?Q?puWMS1Fgl7+h7d8bVhw+c5gDpEXy7PSMSRT5yc3gjVeixxrtvWeUwIEiLeH3?= =?us-ascii?Q?kGarKHkrDQ8inYrr9Q8KeKk4aktJbj1KFg9r70rj1cZirLm3a7fPQ4WBvm7q?= =?us-ascii?Q?kFNKEsqi0C/BMgtXU3LpCnEU1jWhFc83zITBmkhof5OhIOW906QiZonlDsYl?= =?us-ascii?Q?V4r1+CCT8S9ltLHY3iR2gL/2JXi78qJpPFi4l8qQeazGH4aug/GyE20TJ+77?= =?us-ascii?Q?pg9/LFjULKaK5O7iWOpSVzSKpyda9+0yAomNFW5Q?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: d33811b3-63e7-4cc8-6317-08dde566ccc0 X-MS-Exchange-CrossTenant-AuthSource: SI2PR06MB5140.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2025 12:39:44.2717 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sYh8czlyEeO/f9DLjZ6mHyxLV0AHsJ+c+QOvPoSjSpevAYM1fXONxePOKJX3cpfgKg3Dnouf8s1Y97UEmckPPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB7285 Content-Type: text/plain; charset="utf-8" Change "ret" from unsigned int to int type in dcmi_framesizes_init() and dcmi_graph_notify_bound() to store negative error codes or zero returned by v4l2_subdev_call() and media_create_pad_link() - this better aligns with the coding standards and maintains code consistency. No effect on runtime. Signed-off-by: Qianfeng Rong --- drivers/media/platform/st/stm32/stm32-dcmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/p= latform/st/stm32/stm32-dcmi.c index d94c61b8569d..13762861b769 100644 --- a/drivers/media/platform/st/stm32/stm32-dcmi.c +++ b/drivers/media/platform/st/stm32/stm32-dcmi.c @@ -1701,8 +1701,8 @@ static int dcmi_framesizes_init(struct stm32_dcmi *dc= mi) .which =3D V4L2_SUBDEV_FORMAT_ACTIVE, .code =3D dcmi->sd_format->mbus_code, }; - unsigned int ret; unsigned int i; + int ret; =20 /* Allocate discrete framesizes array */ while (!v4l2_subdev_call(subdev, pad, enum_frame_size, @@ -1808,8 +1808,8 @@ static int dcmi_graph_notify_bound(struct v4l2_async_= notifier *notifier, struct v4l2_async_connection *asd) { struct stm32_dcmi *dcmi =3D notifier_to_dcmi(notifier); - unsigned int ret; int src_pad; + int ret; =20 dev_dbg(dcmi->dev, "Subdev \"%s\" bound\n", subdev->name); =20 --=20 2.34.1 From nobody Fri Oct 3 16:45:45 2025 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012038.outbound.protection.outlook.com [52.101.126.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4C3535082E; Wed, 27 Aug 2025 12:39:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.38 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756298393; cv=fail; b=OfOxGDquB8AUkWVDQHpXEfyDyYMcPfRltoIra/IhkXOBP752DV4oyk2sIbOJas8LMFhSj8TRqxqD4cDhALv5orJNc+YlNT5KbOySpduHfAOeuCICv6zSFTHaelFKo+sZnWP6T0XzPXoumY1bSHvCHQ4jUhVtiAc9ztLsbXfhzAE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756298393; c=relaxed/simple; bh=N1J/uYqQQt64J/LboJWKLPHp76oKij4AJgkX3KczFSo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=mHglu0RnQZsuiBIKgqNdkDmQjIaawYI2WjvDY6oKf7vnvupTzMEbF9rjc4YmBaNsxfFCI/95xX1VY6uzONjEWKCO9IK5AbwX7qAFM1RqV3cpC1UjO4dswcBe45ZYQ3tT+AUSPsT6mNLaGFecC5nPoA4GGXweiD0u/u+lDKyWMxs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=marJK7Hv; arc=fail smtp.client-ip=52.101.126.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="marJK7Hv" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fRYdkAnAUGh3xFiGgLLSjYdwE3D3IT3c/RIVMnZN0HOMgqRCpO+aO8WCxR1GMI3ATckOrnNfyTzqgt/TBXl/s0bukvLftTeVQUzwvWlgfeAH01Tb6PVr1G5RKvDwNDTzsTyAVaJfu6kInP9l0gttAuu6865n+Ro29aWrvU53fvw0zqajgSe4RPjoO/hI8Eo1Grht5vxSoC/bunHHGnnOk5tOuiLQiZL0FWYYi9Ej01qnTBrgbFwXaTS+S9FRLaDvGyyYh6aPjQsFtjYg3rIEZW4X8R1vd56VfV41xajkbV1o4mE6aLSolMd8Bd9NZ9Z336LnIV8i29RULX6aRbOhKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GPSaDWZ5UWJp40FE2AerA/TeUScRIKV4FkeX02TeZi4=; b=MjeDPPHFDLJWoM3XSXsZudoPhMFU2IjVrvgm8NuA//QX9ZloJuM0ws9F1dSZ7T+nAvGZA9sbLA9BuJcwEPtt89KGArr1+NSNDV/uIoXYELKWjWhia89VvXPyR313NgwZuwsu2V5+arwoizgit0b/CBFQqqeCGoXQSgQlJDtpZp4TivnqJNp/ZvNNtiZ0j9XbFZtIPyUT1O4sfnuBX9irX7T2oXhr25RotFebCWF3AkR2V4gJIjcCJ+cCoYLxw0F5xO2Jzl/UzCwUDDEGUCdiGexUcAnWBP9u6exvxgiFjbNqQWRXu4vYbB6Q6OYjZ+4XzBoqHa/nzX3AQHLvbxRZfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GPSaDWZ5UWJp40FE2AerA/TeUScRIKV4FkeX02TeZi4=; b=marJK7HvmyxJg6zwulC3R7HLVfwUuyfrUr2isrXcLo3aaG3HSRPPqFSaqB71b4R2CJbia0FV3wYzHsDsHcJwlEowwEOUUZU0ivq0oUqbFhtzcRqSqsVRPpAdSRGacbgtNPKu4FQgfN3immhZ2cScKKsvADa93anSOIjmXSVBohHA9yr8bMeNAcF6fDd2EoH+KBDkX4bGbAE2h+W5s7E4S19OwaRJYnf8YtptNpQzYDXz8Z0zN1H9NWdya2P0rH2DbZMjliU1VP/nPf1C0En7oQrDRZwTrciqBhF5oi4gnr/nG1J1kzvjVe9DYzbZTsfgdhTpluYtn//IyAFEm+6rRw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) by PUZPR06MB5539.apcprd06.prod.outlook.com (2603:1096:301:e9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.13; Wed, 27 Aug 2025 12:39:47 +0000 Received: from SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666]) by SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666%5]) with mapi id 15.20.9073.010; Wed, 27 Aug 2025 12:39:46 +0000 From: Qianfeng Rong To: Sean Young , Mauro Carvalho Chehab , linux-media@vger.kernel.org (open list:RC-CORE / LIRC FRAMEWORK), linux-kernel@vger.kernel.org (open list) Cc: Qianfeng Rong Subject: [PATCH 5/5] media: redrat3: use int type to store negative error codes Date: Wed, 27 Aug 2025 20:39:13 +0800 Message-Id: <20250827123916.504189-6-rongqianfeng@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250827123916.504189-1-rongqianfeng@vivo.com> References: <20250827123916.504189-1-rongqianfeng@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR01CA0049.apcprd01.prod.exchangelabs.com (2603:1096:4:193::13) To SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SI2PR06MB5140:EE_|PUZPR06MB5539:EE_ X-MS-Office365-Filtering-Correlation-Id: fde2d42a-43d9-4e49-ead6-08dde566cde8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?9t2M25kPj3cqasS/nxqJGumEaDzxE56u6Ywnxh1NFG6YsmBTU2ISXN53ppD/?= =?us-ascii?Q?wEqV6hy+ZUhzhE2JWRL8A99kncjcQnRd7ZW4hwKBe0bCzJJbZahewLqqdmYc?= =?us-ascii?Q?7H8qGxyzZ8PeTffbaLh23JgwbEnYc4fSNawuOQWo5MpgFdUrHkJeJBi17x2Y?= =?us-ascii?Q?Xs82GXR3+mQyb+Bx6SIJMNp6D/fV08cKYQndVvsoLZuKYecvON04CU8jlPCi?= =?us-ascii?Q?uHkJ3sGjCGbfeFABPqIoRBzvB5EdGBZDFOXc9EcL9bC5ABkoAOkD4S6vbyHZ?= =?us-ascii?Q?Hwv4fomS4bMxjmDbQWSJH7AbnFST6kvdx+nRK+rMYN2PO8R6BYgNocm4Hlxa?= =?us-ascii?Q?jsDxbC1OrVqqBI45qC5WQnh6wQvEx8EPezOhoniFnZFb16uiMNOYIaXztwpW?= =?us-ascii?Q?WRe5eIrV+BViueHIY6g2URJ9dRXG0M5v2+tUFGeHTawPxCwzAwSH3kba0XFt?= =?us-ascii?Q?p+dTaf5shy3IPVnWSi6ZGNgHl7ccvKNnffPzk9GkH4sXc1rYy1tlFEcZChBp?= =?us-ascii?Q?Ciz9o7lBnimTaf7Z3UoiRBR6zuDIJeNNJXBj2VEKPZ4PKoy9MMIu/krA/Uqq?= =?us-ascii?Q?nFO2ptV8QgrTCoLo3zsNliv3jq228FDhnKTt89eADSM2S5j2XduHFKANZXK5?= =?us-ascii?Q?szmr+TEwh5AXurZ9v5Ps9vL1K64wSdevhY1npIzgfDODSIbe9I9HLP271ebp?= =?us-ascii?Q?3n89aLNw28q3cM2MJCNhleMtiRlz5YEFg0TaZT97MnGgFVMZjDtVEcyp8oFK?= =?us-ascii?Q?BnzJBcXoUaVBPhc+C8R7SVK9kObO67ZSi0dyZwIbd/TbVPc6dKR4JLsZ61Tc?= =?us-ascii?Q?13RqpldZUh6Cw5lrnZkOTsFtPKPqB0RABZSA/aGHXZqcVsBff9TzJ96RwSKd?= =?us-ascii?Q?pKt+S3rOwPQkmgJkPpOP1DiZO4uduNAuc5NE/oDp9uEiVtIi7wS6OH1R6YHi?= =?us-ascii?Q?fTQHS736zG0FJwiyyYathsuqq7+W/OzPTxmxMXoypq2cezrGa6vYe35x1jvE?= =?us-ascii?Q?mS6gL0CacBS3Un9n6c138/ev/yHIy3mjGrJquNx0MwG6vHGna0OZU4KaAaEJ?= =?us-ascii?Q?+iiu8YcteM8j935oxtOomWxfnvVaaarLtqzCnad3PIyH0ShP/a5H8qePhHgT?= =?us-ascii?Q?YB3Trr7hM+xQ7GkBR4FpB3UoQ70nOp5wsQrSKRu+/xCOv1Ag1iNCIMt5m9bZ?= =?us-ascii?Q?JmeHxOundeJfxVOB4roLNaj6OCh0xQx3K5cPUdsnDO4R6sP0J0VTmgOiQ4zu?= =?us-ascii?Q?AZY+vruGy4S1Py0UG9M+xUFdkOEo3Fl3Vh1lESWKUFakA+jyYOMvmE7fia+N?= =?us-ascii?Q?8Xwu5NzWJN9pYfRizCO4qtp4C6NqvHgxSK2mQOcfJ9ovRoH4YX/bLQPALsju?= =?us-ascii?Q?zijlwdqY5qz2SN0BDNJEnzMTDmjBR+xlFVJ2PPMcjrpm9JVW1kQLE9MRea7s?= =?us-ascii?Q?1U2e3rt3miAIxjXAbI5gHzyw2v5xwP0WmN9J4JiO4AHi+xEugKbNAQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SI2PR06MB5140.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Nm2TBP2Xo5frC/G674a89VURFcWDz4gNN/O8RgLI2MjJGOuE7LYom5L5gQKY?= =?us-ascii?Q?x17xudHrUgWJm3K5BZtHiJ49TBKbHLdip8k2GEQ964CbZa6edI2TG+R2pNwo?= =?us-ascii?Q?AxRk75MGdn7/vZG06dQgS04jwuFEM8VdS1mLZixYZ/kR+N4YEhz8lpdOVWvl?= =?us-ascii?Q?WwcvjxtDd7TlnEyTdP02TaLT7WDWd0uatG/CFSKYpT2vsKZS/cWLX9Fe+cAe?= =?us-ascii?Q?HoRimftAwoPVgrjEM/mfiwGv1Mbca++mZ8X6SliTS0EeKZyhJdK/PPWeVqPX?= =?us-ascii?Q?Et+u7WddgGlL9grUJdLkV1Apm1NvBIwtw+4pveCHNs2UqaipkiHewoN61Mcb?= =?us-ascii?Q?+CwzgcN/JC85asPnZw9XFEJNWWa9rt5+Vz1PvOW59z//m+/9wGC/bDKupfFa?= =?us-ascii?Q?zlOxpcXOrzSBQIZlgZanTPgL1Mqs9CKrD7CYnhHVE231Bb9/tVkuvfsFRBbx?= =?us-ascii?Q?ECUX9B9WZvDyd+uMk9noMbWwKi/FJu3xN6fNjwITDCRiKn6lUJgoPGfyN1VO?= =?us-ascii?Q?P3Ku5QFqmP/NVqjIeQkmp+Dm3crWJ3ZiWSgiqJtBh7fgpPF3uRchxGiIZmp8?= =?us-ascii?Q?St1ugKJwoj8qZxm7PPvCu0T+KoWdcLTVJUjWj0Ug2Tbz+iED5B2mCgOS5kVb?= =?us-ascii?Q?b1hGuPlB+GhH6SHYniFOnNM55DjzUAWmlGL6IhHAsj+zQNARXmMLz3/t5XAY?= =?us-ascii?Q?6PI1oiE5GkFhTFsUxIjXbNuJEt0jPkFmQO4A664Fp0kBYgf57JgnaEjECuEr?= =?us-ascii?Q?BxLtQPIDgcpXM1ir6uhgQKOJf9QdVIXDBy5Yu/ld4ojgXybkrtHDgQJFgi70?= =?us-ascii?Q?vu7NBdnokRjvMWZV1r+YO+7Ovs4Xb3NPyBbv9OXuK2xl+Q29pTjnMuwcA5in?= =?us-ascii?Q?hvHe/aLp8nJ5Cozk9F07bxsMCv1KNyvuio2yOYmB8pru6w694L9aHB24PRp/?= =?us-ascii?Q?Wfsrxavn9KFxvGyYEHUcjbQ2UGIXTzVP0sHt6jKD0y8bQ7kx3y/YtuIDBszW?= =?us-ascii?Q?6hyhC80BU9MPnsLgQoJ1CINwGtA8haCCaA8bpvUWuP0YliDeVYCGPeVuvodO?= =?us-ascii?Q?+XNJPjap9wtuI4nD8pLoX/ea3udHd7Ta8HmBwW6+vxpSW78MlNLHGxwOE34Z?= =?us-ascii?Q?IosmWs2XnHqP0/OdzoUqwsGX51xlN/+8V1MgkUhjcY4uSq6B1JUWpn3OBY+R?= =?us-ascii?Q?CwuHFjZNQa0uCc/LoNzUfMERbva+BBF4viOIt/EkC+dEiAx4svDwbnXS/yXy?= =?us-ascii?Q?j1ajaprfoV9ePmil4k6pHfKcFaZiNGAn4e6IG51v3BEkD9MOkRxsM8mEzoNZ?= =?us-ascii?Q?ndtp8dCloH6qpaoWYkP1xVRC8mSAEa53tSMo5iv8ZCsxJthQ/4eBRcpNoT9F?= =?us-ascii?Q?aP6x3FYTGrQuUqYxIfo7QQ5PJcNe2z0tGz4o40AJvNS6p79NUJsQ8ynjmb84?= =?us-ascii?Q?DbAbcsmQnkVknCv+YsoU36kA8+fy0YijqtWonHvgjsebFygmAIb+mIEa1k3u?= =?us-ascii?Q?qoWozEoc15vrkXrmz72QIJWYbvxmfQpIffetvAgv9EAIuSvpKTq2js6NuLGG?= =?us-ascii?Q?+1GhWwK4hJT+7LyJPCcwSbgURqfXtBcUJ7guzLWn?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: fde2d42a-43d9-4e49-ead6-08dde566cde8 X-MS-Exchange-CrossTenant-AuthSource: SI2PR06MB5140.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2025 12:39:46.4469 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BW73GaX9z1p65Q5yOd72b6numt0SQIJQYcjw8OhZt+hecLREj5GmpkFD3hMse63lJOlLGshX0n6h1C4vssBrEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5539 Content-Type: text/plain; charset="utf-8" Change "ret" from u8 to int type in redrat3_enable_detector() to store negative error codes or zero returned by redrat3_send_cmd() and usb_submit_urb() - this better aligns with the coding standards and maintains code consistency. No effect on runtime. Signed-off-by: Qianfeng Rong --- drivers/media/rc/redrat3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c index d89a4cfe3c89..a49173f54a4d 100644 --- a/drivers/media/rc/redrat3.c +++ b/drivers/media/rc/redrat3.c @@ -422,7 +422,7 @@ static int redrat3_send_cmd(int cmd, struct redrat3_dev= *rr3) static int redrat3_enable_detector(struct redrat3_dev *rr3) { struct device *dev =3D rr3->dev; - u8 ret; + int ret; =20 ret =3D redrat3_send_cmd(RR3_RC_DET_ENABLE, rr3); if (ret !=3D 0) --=20 2.34.1