From nobody Fri Oct 3 18:10:02 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 423A134DCD7 for ; Wed, 27 Aug 2025 10:55:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756292158; cv=none; b=f6tUmhA9jtpz9e4KALLXP2q8SXO7h/kWTQMJt1648mdta7DGI8b63sKdBfkO1h3y6uGq3j1ZmKt2OEigs4y307YeFfWtw9jbUjxEcQAtGzO1+ONG8SZazmd84JEnMmkI/SYW2BD2EUrVXbFWYJOIRa1uRu/j3SWdjW8RUK7hvXA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756292158; c=relaxed/simple; bh=rQ96BiidjdZVuBuCVbJxZGaP06pW4XgFOoystzoRyOU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=C2yGxWKwYpsxT75RgIFP8v5O3t8qi88K1urJjm/68zw6UOYoHwuNTo66UX7U9Io11mteJzITmJR+4TCCM+YQpeGUivRUxarHiBaVwrTPFhxdKEG83qeWw5FsFktjUKqOKqkb3E6hZipMbOXzjU0Nqqo7DWdmlFwXRjQOATaJjNw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Pdc9mhhc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Pdc9mhhc" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57R6kCr4027275 for ; Wed, 27 Aug 2025 10:55:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=bGRCpbWuoAe XmlM4HsvMzttpVGFxmROnmfvnhtF/ofc=; b=Pdc9mhhc+g4ivIAx4v6EF8zsslv JNn/tXx/+Sk9x1sSVrDxlf+lyCJVlOTRVLb92CEmZAzlOWS2SVgdwSKlVX4aDtf2 Xvqx2nVW4CqN+e2Wj6/CWICsEpLSvIKcs+QCidMofcBq/P8LA9u5oRYR+2Njs2Fz DfCLZQgJe4T6dUVdAaPHP3WRiqY0DU4VlYcL0DjJCYmz7pTdXs16TMgfYU6sC/Hv rCswUowmKqdih/9GofNk5aJZrf3VSN62bIopzY36FX4DnctjlK0BrKjgK4QJ9/z/ XUptk6V9YWhMTeEqx0o88aY0JPx1gTjvJzZcbWnNH2K2dAh63dPcacrsB/w== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48se16udet-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 27 Aug 2025 10:55:55 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-32326e72dfbso9721862a91.3 for ; Wed, 27 Aug 2025 03:55:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756292154; x=1756896954; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bGRCpbWuoAeXmlM4HsvMzttpVGFxmROnmfvnhtF/ofc=; b=Pe9TAdeFc2ryAvegHjXzL2A6GBlMAoSXhKb24oDcnH0uCSVb15JWwQHnWE0zABk496 VOp6scJ7mDIe2y55h5HlATdI+bpn5KG1wRhGxUnkyqupf3fY6oSt9069zqIFDaPbekGQ StNTJbcEsBzs7RGxpy8JHvV1iPAUzRoiy1vXGi35t+5kUwO3Mi5zt/EVNwJ1U9u6uu04 8aNkH5856pnZPenejZHyW/WMH7QIXF0YVeeg7iU7EkgniXoZX75o+dD3F8MvykDmxUHa Jk3zUgDVKkCqTsjA+j2JAajNEGJ5P2aExYLn/6xykY/J0uIREEGFyBU7+m0WwpBm1ct3 GpEA== X-Forwarded-Encrypted: i=1; AJvYcCWiYZwD0p0VSvphGnUJ7o7ufl2YpJFjFpcJp2LwRQ9DmWMy1AtcBWeAAtPGRxbCrgzeHxXw/OVWuof5UvE=@vger.kernel.org X-Gm-Message-State: AOJu0YwWkoT5gJuC40GqlZ4SLIi1VRF9f9tmlRXMTqXpakOHi9TFp+wK VVmdAUybOMqqsPQsvkIddrU6thqCLt2kRlfhmsRiASdjziktiTxhRO+BIswXmT1CTx4XtMhnAwy nDxg0yfyQBTeKgmrUYyyqjQ4HJu7sLVy9iF6fD45CPTci0DejcJYyon6sN3CfAxPhqcc= X-Gm-Gg: ASbGncu0jQCWAZjOcgo8SvCuHMKvVKXcv7py0y0wF+AzkxyxUxG4fJqnyeQDUl/Y8HT PQq4NokDyeUjP8jt/t+Q6o7+svZV3V1eXGMXzJPvLZkq8eJmduNBlM1Xn8876EAWpp+qc0CXCvg 8s99oHKnN4C65pTQws+vJZu/F2wrAJD1OHQAwmBPxUXMKSwy+XLYUumAjk3Yhb42J93htbSid+R QbTXSyl8Z3o2KOUPHsQ5xew2NrKmuTTohtFs5nzO62BqEDW9poLuC03AEXm5EZ0qaGCiwZBS1W9 z10OkRxOfcZ2RBA4cvxodosQEBxHxFVCMmpiqAlxXFFreYNrKW87O2dRInTJbxUL0Ns7ThLU0sv 92CEB8L7rE2QqeUADHDIF X-Received: by 2002:a17:90b:38c3:b0:321:2b8a:4304 with SMTP id 98e67ed59e1d1-32515ef77admr24278197a91.10.1756292154209; Wed, 27 Aug 2025 03:55:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwNMyZcrQVPEWGkwnWvs7YNOYO9VEeBd6cV+tfHxFoasx2pAFKCLu2F1SMsovpNElVALzM/w== X-Received: by 2002:a17:90b:38c3:b0:321:2b8a:4304 with SMTP id 98e67ed59e1d1-32515ef77admr24278165a91.10.1756292153622; Wed, 27 Aug 2025 03:55:53 -0700 (PDT) Received: from jiegan.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-771f2f2ac7dsm5573035b3a.43.2025.08.27.03.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Aug 2025 03:55:53 -0700 (PDT) From: Jie Gan To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Tingwei Zhang Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 1/3] coresight: tpda: add sysfs nodes for tpda cross-trigger configuration Date: Wed, 27 Aug 2025 18:55:43 +0800 Message-Id: <20250827105545.7140-2-jie.gan@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250827105545.7140-1-jie.gan@oss.qualcomm.com> References: <20250827105545.7140-1-jie.gan@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: S-lbfBPVNZY5-z6BhgjKG16sC6wmGyKx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI2MDEyMCBTYWx0ZWRfX6V4mv7ttGfaU EY6oTowl2JT3eTVuirZGbAGj0vB+7/NV5MHQvYcxI0H7uNuk8QSYkPDZCN/DzFZv02fuyOpaiMy aE6JsuRjCzDyQSgiLsZ7Xrb3EfRGANQUHCRZmCisHSSWO3ythppaxg1dE+3jSf6aLMRfEwOs/l3 PmqzKORuXUvqFc891QB2HhC9rsQ1JLyI64DGOFGZ6BXPf0Y2DUjKcSid90YevqfS1jDuXQsXb9h oDbraVx9tu/xMZJMmtiPqCCHjFv5I8UXIDk+LXr9xuuyy3KxcRa4wZouMlnaIQZ7FatjRAC2T+c DRi82aEhoMh15qZYy8ye//3i68g8HpxtVMq8d94jcI3ttCr3/M9FQTINi0S3/5lY5yis7w82e3e MAk43WEk X-Proofpoint-ORIG-GUID: S-lbfBPVNZY5-z6BhgjKG16sC6wmGyKx X-Authority-Analysis: v=2.4 cv=CNYqXQrD c=1 sm=1 tr=0 ts=68aee43b cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=Hl4cRc3ft4hpfJdQRooA:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-27_02,2025-08-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 priorityscore=1501 adultscore=0 spamscore=0 phishscore=0 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508260120 Content-Type: text/plain; charset="utf-8" From: Tao Zhang Introduce sysfs nodes to configure cross-trigger parameters for TPDA. These registers define the characteristics of cross-trigger packets, including generation frequency and flag values. Signed-off-by: Tao Zhang Co-developed-by: Jie Gan Signed-off-by: Jie Gan Reviewed-by: James Clark --- .../testing/sysfs-bus-coresight-devices-tpda | 43 ++++ drivers/hwtracing/coresight/coresight-tpda.c | 230 ++++++++++++++++++ drivers/hwtracing/coresight/coresight-tpda.h | 27 +- 3 files changed, 299 insertions(+), 1 deletion(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-t= pda diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda b/D= ocumentation/ABI/testing/sysfs-bus-coresight-devices-tpda new file mode 100644 index 000000000000..fb651aebeb31 --- /dev/null +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda @@ -0,0 +1,43 @@ +What: /sys/bus/coresight/devices//trig_async_enable +Date: August 2025 +KernelVersion: 6.17 +Contact: Jinlong Mao , Tao Zhang , Jie Gan +Description: + (RW) Enable/disable cross trigger synchronization sequence interface. + +What: /sys/bus/coresight/devices//trig_flag_ts_enable +Date: August 2025 +KernelVersion: 6.17 +Contact: Jinlong Mao , Tao Zhang , Jie Gan +Description: + (RW) Enable/disable cross trigger FLAG packet request interface. + +What: /sys/bus/coresight/devices//trig_freq_enable +Date: August 2025 +KernelVersion: 6.17 +Contact: Jinlong Mao , Tao Zhang , Jie Gan +Description: + (RW) Enable/disable cross trigger FREQ packet request interface. + +What: /sys/bus/coresight/devices//freq_ts_enable +Date: August 2025 +KernelVersion: 6.17 +Contact: Jinlong Mao , Tao Zhang , Jie Gan +Description: + (RW) Enable/disable the timestamp for all FREQ packets. + +What: /sys/bus/coresight/devices//global_flush_req +Date: August 2025 +KernelVersion: 6.17 +Contact: Jinlong Mao , Tao Zhang , Jie Gan +Description: + (RW) Set global (all ports) flush request bit. The bit remains set until= a + global flush request sequence completes. + +What: /sys/bus/coresight/devices//cmbchan_mode +Date: August 2025 +KernelVersion: 6.17 +Contact: Jinlong Mao , Tao Zhang , Jie Gan +Description: + (RW) Configure the CMB/MCMB channel mode for all enabled ports. + Value 0 means raw channel mapping mode. Value 1 means channel pair marki= ng mode. diff --git a/drivers/hwtracing/coresight/coresight-tpda.c b/drivers/hwtraci= ng/coresight/coresight-tpda.c index 4e93fa5bace4..d4d1def5ec15 100644 --- a/drivers/hwtracing/coresight/coresight-tpda.c +++ b/drivers/hwtracing/coresight/coresight-tpda.c @@ -156,9 +156,37 @@ static void tpda_enable_pre_port(struct tpda_drvdata *= drvdata) u32 val; =20 val =3D readl_relaxed(drvdata->base + TPDA_CR); + val &=3D ~TPDA_CR_MID; val &=3D ~TPDA_CR_ATID; val |=3D FIELD_PREP(TPDA_CR_ATID, drvdata->atid); + if (drvdata->trig_async) + val |=3D TPDA_CR_SRIE; + else + val &=3D ~TPDA_CR_SRIE; + if (drvdata->trig_flag_ts) + val |=3D TPDA_CR_FLRIE; + else + val &=3D ~TPDA_CR_FLRIE; + if (drvdata->trig_freq) + val |=3D TPDA_CR_FRIE; + else + val &=3D ~TPDA_CR_FRIE; + if (drvdata->freq_ts) + val |=3D TPDA_CR_FREQTS; + else + val &=3D ~TPDA_CR_FREQTS; + if (drvdata->cmbchan_mode) + val |=3D TPDA_CR_CMBCHANMODE; + else + val &=3D ~TPDA_CR_CMBCHANMODE; writel_relaxed(val, drvdata->base + TPDA_CR); + + /* + * If FLRIE bit is set, set the master and channel + * id as zero + */ + if (drvdata->trig_flag_ts) + writel_relaxed(0x0, drvdata->base + TPDA_FPID_CR); } =20 static int tpda_enable_port(struct tpda_drvdata *drvdata, int port) @@ -274,6 +302,206 @@ static const struct coresight_ops tpda_cs_ops =3D { .link_ops =3D &tpda_link_ops, }; =20 +static ssize_t trig_async_enable_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->trig_async); +} + +static ssize_t trig_async_enable_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t size) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (kstrtoul(buf, 0, &val)) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + drvdata->trig_async =3D !!val; + + return size; +} +static DEVICE_ATTR_RW(trig_async_enable); + +static ssize_t trig_flag_ts_enable_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->trig_flag_ts); +} + +static ssize_t trig_flag_ts_enable_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t size) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (kstrtoul(buf, 0, &val)) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + drvdata->trig_flag_ts =3D !!val; + + return size; +} +static DEVICE_ATTR_RW(trig_flag_ts_enable); + +static ssize_t trig_freq_enable_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->trig_freq); +} + +static ssize_t trig_freq_enable_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t size) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (kstrtoul(buf, 0, &val)) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + drvdata->trig_freq =3D !!val; + + return size; +} +static DEVICE_ATTR_RW(trig_freq_enable); + +static ssize_t freq_ts_enable_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->freq_ts); +} + +static ssize_t freq_ts_enable_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t size) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (kstrtoul(buf, 0, &val)) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + drvdata->freq_ts =3D !!val; + + return size; +} +static DEVICE_ATTR_RW(freq_ts_enable); + +static ssize_t global_flush_req_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (!drvdata->csdev->refcnt) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + CS_UNLOCK(drvdata->base); + val =3D readl_relaxed(drvdata->base + TPDA_CR); + CS_LOCK(drvdata->base); + /* Only read value for bit 0 */ + val &=3D BIT(0); + + return sysfs_emit(buf, "%lu\n", val); +} + +static ssize_t global_flush_req_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t size) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (kstrtoul(buf, 0, &val)) + return -EINVAL; + + if (!drvdata->csdev->refcnt || !val) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + CS_UNLOCK(drvdata->base); + val =3D readl_relaxed(drvdata->base + TPDA_CR); + /* Only set bit 0 */ + val |=3D BIT(0); + writel_relaxed(val, drvdata->base + TPDA_CR); + CS_LOCK(drvdata->base); + + return size; +} +static DEVICE_ATTR_RW(global_flush_req); + +static ssize_t cmbchan_mode_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->cmbchan_mode); +} + +static ssize_t cmbchan_mode_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t size) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (kstrtoul(buf, 0, &val)) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + drvdata->cmbchan_mode =3D !!val; + + return size; +} +static DEVICE_ATTR_RW(cmbchan_mode); + +static struct attribute *tpda_attrs[] =3D { + &dev_attr_trig_async_enable.attr, + &dev_attr_trig_flag_ts_enable.attr, + &dev_attr_trig_freq_enable.attr, + &dev_attr_freq_ts_enable.attr, + &dev_attr_global_flush_req.attr, + &dev_attr_cmbchan_mode.attr, + NULL, +}; + +static struct attribute_group tpda_attr_grp =3D { + .attrs =3D tpda_attrs, +}; + +static const struct attribute_group *tpda_attr_grps[] =3D { + &tpda_attr_grp, + NULL, +}; + static int tpda_init_default_data(struct tpda_drvdata *drvdata) { int atid; @@ -289,6 +517,7 @@ static int tpda_init_default_data(struct tpda_drvdata *= drvdata) return atid; =20 drvdata->atid =3D atid; + drvdata->freq_ts =3D true; return 0; } =20 @@ -332,6 +561,7 @@ static int tpda_probe(struct amba_device *adev, const s= truct amba_id *id) desc.ops =3D &tpda_cs_ops; desc.pdata =3D adev->dev.platform_data; desc.dev =3D &adev->dev; + desc.groups =3D tpda_attr_grps; desc.access =3D CSDEV_ACCESS_IOMEM(base); drvdata->csdev =3D coresight_register(&desc); if (IS_ERR(drvdata->csdev)) diff --git a/drivers/hwtracing/coresight/coresight-tpda.h b/drivers/hwtraci= ng/coresight/coresight-tpda.h index c6af3d2da3ef..0be625fb52fd 100644 --- a/drivers/hwtracing/coresight/coresight-tpda.h +++ b/drivers/hwtracing/coresight/coresight-tpda.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved. + * Copyright (c) 2023,2025 Qualcomm Innovation Center, Inc. All rights res= erved. */ =20 #ifndef _CORESIGHT_CORESIGHT_TPDA_H @@ -8,6 +8,19 @@ =20 #define TPDA_CR (0x000) #define TPDA_Pn_CR(n) (0x004 + (n * 4)) +#define TPDA_FPID_CR (0x084) + +/* Cross trigger FREQ packets timestamp bit */ +#define TPDA_CR_FREQTS BIT(2) +/* Cross trigger FREQ packet request bit */ +#define TPDA_CR_FRIE BIT(3) +/* Cross trigger FLAG packet request interface bit */ +#define TPDA_CR_FLRIE BIT(4) +/* Cross trigger synchronization bit */ +#define TPDA_CR_SRIE BIT(5) +/* Packetize CMB/MCMB traffic bit */ +#define TPDA_CR_CMBCHANMODE BIT(20) + /* Aggregator port enable bit */ #define TPDA_Pn_CR_ENA BIT(0) /* Aggregator port CMB data set element size bit */ @@ -19,6 +32,8 @@ =20 /* Bits 6 ~ 12 is for atid value */ #define TPDA_CR_ATID GENMASK(12, 6) +/* Bits 13 ~ 19 is for mid value */ +#define TPDA_CR_MID GENMASK(19, 13) =20 /** * struct tpda_drvdata - specifics associated to an TPDA component @@ -29,6 +44,11 @@ * @enable: enable status of the component. * @dsb_esize Record the DSB element size. * @cmb_esize Record the CMB element size. + * @trig_async: Enable/disable cross trigger synchronization sequence inte= rface. + * @trig_flag_ts: Enable/disable cross trigger FLAG packet request interfa= ce. + * @trig_freq: Enable/disable cross trigger FREQ packet request interface. + * @freq_ts: Enable/disable the timestamp for all FREQ packets. + * @cmbchan_mode: Configure the CMB/MCMB channel mode. */ struct tpda_drvdata { void __iomem *base; @@ -38,6 +58,11 @@ struct tpda_drvdata { u8 atid; u32 dsb_esize; u32 cmb_esize; + bool trig_async; + bool trig_flag_ts; + bool trig_freq; + bool freq_ts; + bool cmbchan_mode; }; =20 #endif /* _CORESIGHT_CORESIGHT_TPDA_H */ --=20 2.34.1 From nobody Fri Oct 3 18:10:02 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04D8434F465 for ; Wed, 27 Aug 2025 10:55:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756292161; cv=none; b=J7OrXGySX7/EJ2fnanf13MCFaoNLuvcccreWXLqi1U062mNZHs4dv4fiaKMuWT+bPiL792BTiJwnPrZnwZkSf361F4/oZFrwN1yutnWjDjlHr8xG/UspZj3zRRz5e/DdrzVV1A3maMbWUFEjGwRthY0Y06pUVmKwC3z/AA5xY88= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756292161; c=relaxed/simple; bh=1PtJIWLhL4yQWXU3zlGTNITTKz5VrZgF3PzojoCmc58=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=C59J6LB1OEcYmLZ0xI8Lh6rPV+zanfwg/z2QBBtfbNdDSjovpp0tZ1arM9ecNsVjzxDWtvMEbzzp/G/cRMBdmM9Z7Kch5WT0KYE7STEsKVN//wHX6X5+CX+p15JLJ35MGYq5DyWg9uz0AxUewwwuKhFPrcEld7/rk/LITobI/yg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=k/fQwBny; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="k/fQwBny" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57R6kDxj022886 for ; Wed, 27 Aug 2025 10:55:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=QrIK6tX2IWK GLbKUtBQLQ4aPT6fPCczMhEz00/Q0PUw=; b=k/fQwBnyW9PjS0ma6JrGdD3HiC3 /Oo34XL1IZJWz3FP68nVd8oRghlU8w8+rRi/DxDOmcYKgfHIv4yc1YwP2PL/gWeL baOD7rBbumE4Tqaamwlh3g8hobuwZSlwgCApRj8T4fQlI0GxycGCl3Z4q8ZhR4B/ JlqI0kQw1/nNit5XZYHKsxpHwRHzZs4wlBjcHg2elko/RwajKTm+RSPucxfgpHw3 gmPFGxxi3EPKl/Ar15kVCdGaIRHM1nHHQGbAM86PLU9bS5XxCb+alHsJfWC/T82x UFwDGdl9/zusH2u/H7opQV1Lg8AGRjHG1SxQDe6gU52HnLqpK37i7HomL6A== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48q5y5m7cr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 27 Aug 2025 10:55:58 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b47630f9aa7so5194646a12.1 for ; Wed, 27 Aug 2025 03:55:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756292157; x=1756896957; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QrIK6tX2IWKGLbKUtBQLQ4aPT6fPCczMhEz00/Q0PUw=; b=KhmIIGBEIruHM/PCBY9IfeHNHSUwEkM27qrcbY34xZVSjJz+W8hsk1uaQXYML3N9gt NPD3GQz++RD/E1dIurZyjRFI5dt+zrV3XldWOflceWHQv4tKBgY66gHBOTx+4AKnw1J4 jwKq5PZVHYFzX3x0KOlmTDxso/ugvSRL6a7zA7vWMIZ7KsLL2Fp7UBMqCkTDKOf9hgV7 RHMHN4IDoLDELGSrkGFnPr2KsHT57s0PIofmYcPr0RKKMXRcGvfOO/7uGkk9uLegesr3 Sb3Vw47huHrQ+M0gIu5BffSzzjltfuWsJFwjEvJcvq6pADEHJ6ekifg6phcdAerWVcmo E/+g== X-Forwarded-Encrypted: i=1; AJvYcCWy1zKqjGPy+0d0ufRTVMFFUJSJ889J+drdWVgsoP9KfXVrZLtN5hu3JzB1+zKtGSS463ZEKRPus692X9g=@vger.kernel.org X-Gm-Message-State: AOJu0YzPqWE1CAax8ekZKqzzIEWJodLX78Qt3Nga0zA93ye/xuw4MoHv j5H2giKK2TY/0jViIpAxJumYTheZyZNPa7jdGDPhrfCgeMTQXtLCSljmgNDOqqIW1JLebcBWHQS +oCVHjP8d3n8GXrSXn0u+ikikRTpnjfCUcr1eOjVU0VQdYMKzk77SSj+s6Hqgnvfjuoc= X-Gm-Gg: ASbGncsdh65H/b6sd6xYDs7vjlYnv1JVPyftTo4DK2pSxaqp8AEGvvDyvrnY+x+pL5F RsRSuMCOu+YHjSqG/4Z4tQkFgKyUp1MeC9K2GANWhqnOOjWqGG8x/eV1J2DD2IXisXu+bl4oUbI 5r0FOnha7HhZNrrhaqY3iXJTW19EB/W4ypvebyhIf+rNFsikzNahCqFt3+PT5dKt4fEyReotI32 fNnXBHId7O4O5f7pQdkGdHyDRN4ix95OdXtaZ+hZsF3CouxJ8YrudEQxL7zaaqAJ7X8vI3/EaWk XrfR/E/WVcKXdfhv8gKX/5u2wBxprEGe5SBTJUiDbOHBlYlPj6IF8ARa141phOVEsrxRD875EpJ AOMZKQSNi+VPm4F6II6vu X-Received: by 2002:a05:6a20:7345:b0:240:195a:8333 with SMTP id adf61e73a8af0-24340bff9bfmr31909509637.14.1756292157444; Wed, 27 Aug 2025 03:55:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHyCThp3Fh3qi/ShzD68kw87pJ8DTWN/foHp2PaSMbiSxKV4gSMLtSUTOVTg8XBGz//N7OcSA== X-Received: by 2002:a05:6a20:7345:b0:240:195a:8333 with SMTP id adf61e73a8af0-24340bff9bfmr31909480637.14.1756292156944; Wed, 27 Aug 2025 03:55:56 -0700 (PDT) Received: from jiegan.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-771f2f2ac7dsm5573035b3a.43.2025.08.27.03.55.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Aug 2025 03:55:56 -0700 (PDT) From: Jie Gan To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Tingwei Zhang Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 2/3] coresight: tpda: add logic to configure TPDA_SYNCR register Date: Wed, 27 Aug 2025 18:55:44 +0800 Message-Id: <20250827105545.7140-3-jie.gan@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250827105545.7140-1-jie.gan@oss.qualcomm.com> References: <20250827105545.7140-1-jie.gan@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIzMDAzMyBTYWx0ZWRfXxesnBZCiVee0 vGfUIYTc2szfVemc7S+yTigWEbMPWLcBytz/tZZB4jIQISu39n6c1AhpjUmd1VhRSVIRLLpwdWE fwwfcjRHCekydBy3GSufNdAVlgEosRjicBZQ2PPjtGFP3ht1gPM3dDsRAhxrR1accYn+eyTcC8m Xcrt8hxReAGumxHiczGBJSHt6kmC6NmMknJ1kcTmq09jn6DRZooWj+tOEnMCm3pkrIMsKY9pzmp ky7gEXwyZpee5cijzRGnIC/Wq6E9nNIS+rhkY4dTr2CKG2FTSFwOIlaDep20/O4nXNrYRAX/uJ6 aYSUKzhefeeKDFzK2qS7A1BqH3swXmzGrC5T4RLq3HvZa8sYE/1yqq0nuX86Abew+Jq2uZE2Ioi flDLuE+v X-Authority-Analysis: v=2.4 cv=Lco86ifi c=1 sm=1 tr=0 ts=68aee43e cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=6Dbyrv6SX_ztr3m6kfUA:9 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: gwzg21rKzxrKU1t3Iv-ZlIhgO_mCZPMY X-Proofpoint-ORIG-GUID: gwzg21rKzxrKU1t3Iv-ZlIhgO_mCZPMY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-27_02,2025-08-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 clxscore=1015 malwarescore=0 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508230033 Content-Type: text/plain; charset="utf-8" From: Tao Zhang The TPDA_SYNCR register defines the frequency at which TPDA generates ASYNC packets, enabling userspace tools to accurately parse each valid packet. Signed-off-by: Tao Zhang Co-developed-by: Jie Gan Signed-off-by: Jie Gan Reviewed-by: James Clark --- drivers/hwtracing/coresight/coresight-tpda.c | 7 +++++++ drivers/hwtracing/coresight/coresight-tpda.h | 5 +++++ 2 files changed, 12 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-tpda.c b/drivers/hwtraci= ng/coresight/coresight-tpda.c index d4d1def5ec15..a1393962b04d 100644 --- a/drivers/hwtracing/coresight/coresight-tpda.c +++ b/drivers/hwtracing/coresight/coresight-tpda.c @@ -187,6 +187,13 @@ static void tpda_enable_pre_port(struct tpda_drvdata *= drvdata) */ if (drvdata->trig_flag_ts) writel_relaxed(0x0, drvdata->base + TPDA_FPID_CR); + + /* Program the counter value for TPDA_SYNCR */ + val =3D readl_relaxed(drvdata->base + TPDA_SYNCR); + /* Clear the mode */ + val &=3D ~TPDA_SYNCR_MODE_CTRL; + val |=3D TPDA_SYNCR_COUNTER_MASK; + writel_relaxed(val, drvdata->base + TPDA_SYNCR); } =20 static int tpda_enable_port(struct tpda_drvdata *drvdata, int port) diff --git a/drivers/hwtracing/coresight/coresight-tpda.h b/drivers/hwtraci= ng/coresight/coresight-tpda.h index 0be625fb52fd..0c9bf2fade56 100644 --- a/drivers/hwtracing/coresight/coresight-tpda.h +++ b/drivers/hwtracing/coresight/coresight-tpda.h @@ -9,6 +9,7 @@ #define TPDA_CR (0x000) #define TPDA_Pn_CR(n) (0x004 + (n * 4)) #define TPDA_FPID_CR (0x084) +#define TPDA_SYNCR (0x08C) =20 /* Cross trigger FREQ packets timestamp bit */ #define TPDA_CR_FREQTS BIT(2) @@ -27,6 +28,10 @@ #define TPDA_Pn_CR_CMBSIZE GENMASK(7, 6) /* Aggregator port DSB data set element size bit */ #define TPDA_Pn_CR_DSBSIZE BIT(8) +/* TPDA_SYNCR mode control bit */ +#define TPDA_SYNCR_MODE_CTRL BIT(12) +/* TPDA_SYNCR counter mask */ +#define TPDA_SYNCR_COUNTER_MASK GENMASK(11, 0) =20 #define TPDA_MAX_INPORTS 32 =20 --=20 2.34.1 From nobody Fri Oct 3 18:10:02 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7AB134F48C for ; Wed, 27 Aug 2025 10:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756292165; cv=none; b=Wv73LtrZG076FTysFniUTP/js1KcMhKCzJC9UecwG5p3gQ8qVgrXpiCeGzJ+GeKWdwx5zYT1qiJznr4x65uKD/rfAGvsSuvDB6dgJkFUxJ1PVEgrcfrTWLMbTfnMPmtnkOfpGSlG/QnTh6B+dp0WTd6DJF9GCimq9IKsNwu/zZE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756292165; c=relaxed/simple; bh=RHUVtvl2N2hTcYc4uv0VBvz2bqswq9gFM3vRic01nmI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qatFQUHxmbbIbbOJmhUo3kI7+XQ7XxVMbzjL6D7gDfN3NUCbEEW53Uj94FmERXT6KfKzhWbMsM7upzr2LxwLdYVYsGIkY73nZUyBacPrfRiuvdxx3wBHronXoRz8tzmMYywS9iT3KC4ozRxm73e7X+L602igANX656gZDD+9bjc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QDPzOQ8S; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QDPzOQ8S" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57R6kC2n008130 for ; Wed, 27 Aug 2025 10:56:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=g7hLmo2qiXQ EzJFCc6UYcx4UE905+BBd64HJXeuLne8=; b=QDPzOQ8STAnHmoQU03fFs+srCfh COlQt6Z8xqJ9t0Pmtw1zKsrs3VaxRg6by4f3B1G1555vpL8KRMqmfUmeqEm8OMkb T6E4j4pZO2wbiPMlYuWO0DrgqzTr171bMjTIdWkXcgAekWmUI5vaADnEYm5+e/tr a5X+Ufe7+h4uCSxynPNbWA4egj0bR1izJfKLBx5zo+r5fQ6OIf92bZ2dCtVue8KN jJnC8q/lpC15llGGkuSPJ1phtUssCS95wFz+ajjG1kjusnJdi2LVmTFNQoqRaZRz IY3L5D8/6dhB8Ihx76JrasRzQqs/w5RKTdMwnBsotCi9EvSuJfQkHTefJug== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48sh8ajm5a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 27 Aug 2025 10:56:01 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3276af4de80so1245002a91.1 for ; Wed, 27 Aug 2025 03:56:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756292161; x=1756896961; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g7hLmo2qiXQEzJFCc6UYcx4UE905+BBd64HJXeuLne8=; b=LeXuqytDMJBF6lRaHtqvJUeGYqNeS70AC1v8v59RhXSNZKi0fqDmh8PbfRD6mkUGHI PyO5/5Yi0Eb4cb3x7gQ+olDqw5u3Wyh5U6q1zFu2V9JtSeQDCCz7sfIPfY0C0YQYo5b0 Y0mbRHnRkAFwZUMK7x+MI/1j38GgP3v39K/7bI49SDTZrYcEcSgpKG00No04/lJ/sP64 fpQ+HFKQ00H+hx73u2YexJOMEMsvC1Sn/CuLDCIr7MYoyow+wbePtGPjZ/eiajxqiuxI Xqf0sNd2iSI8RuhfgVySYOBqAYu3P0dE6vreHiLUAuAnUUQ5sHijtKHJLyPlFIUw6y1i VFDw== X-Forwarded-Encrypted: i=1; AJvYcCUap/EXk/6nDISLkXrtuy1VvZP5AXWS/XhamaANZI0sJmOYnXNXtbsOhVFMokXM0DN3d4ctPLAphjy46og=@vger.kernel.org X-Gm-Message-State: AOJu0YxklNpBIu7bbZqLwyeuL65ZpQwMBbay8rmbdHgwJ6FKmzwaBCpC ryUl8X0sCGrIQSnkwDCuE9eEhf2Ug5f1FSG56UWFkD120zJ4wKBfUPi4p21oPwtZEPaDCqXJOfs KKSFqnymTtSBUBfl/8yrh1imqVn+RwUI/g/Oa7GlMOJHj183WdHD9pp7EIRbV7Sv0lhQ= X-Gm-Gg: ASbGncsMvLgNsN92947WEZYyhNYa/Heyw4YRPph4YjlrTTq+Gj6Px1skN/nVvjX19EA 2FlqU9bSHkWghw0yNuKZYiJndHbgkMfUdSduznCseO0ONBZhSZuD18c5Z9cQicS2SYr6LPJGS9m PMmFvIhgH70y8HYhc0hJgeX9cdjnOdK3urnFE4jzT66pGi2X9wY3QKXYOo7j54wzLrAzefkKBsU /6i+QP/PeJfZt4SuJrPuYLYSX9xGLArNnv8l9tmdkw6faxQjSvmEAqM3XzfRkm/suK2PINLXsnE GWDL4RByHhJ4e+oNL9M8Wpe0R+h5DPbXmRUbExT89pzilh/Fg1dcz21NtWMVhOyaul/lpKnhf/U 6tDKze875KZ8y54c2pDmB X-Received: by 2002:a17:90b:528d:b0:321:cfbf:cbd6 with SMTP id 98e67ed59e1d1-32515e3cba6mr25542447a91.6.1756292160751; Wed, 27 Aug 2025 03:56:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwG5WKh/9Jju6a954+EE3Y3ki8sM2PuzrKsD/hmGK39N6A3Kp8fKVEhHRvsLYEuBcOG1Or/g== X-Received: by 2002:a17:90b:528d:b0:321:cfbf:cbd6 with SMTP id 98e67ed59e1d1-32515e3cba6mr25542421a91.6.1756292160259; Wed, 27 Aug 2025 03:56:00 -0700 (PDT) Received: from jiegan.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-771f2f2ac7dsm5573035b3a.43.2025.08.27.03.55.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Aug 2025 03:55:59 -0700 (PDT) From: Jie Gan To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Tingwei Zhang Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 3/3] coresight: tpda: add sysfs node to flush specific port Date: Wed, 27 Aug 2025 18:55:45 +0800 Message-Id: <20250827105545.7140-4-jie.gan@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250827105545.7140-1-jie.gan@oss.qualcomm.com> References: <20250827105545.7140-1-jie.gan@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=cLDgskeN c=1 sm=1 tr=0 ts=68aee441 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=tK8iAimETgkDkOB5pRoA:9 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI2MDE1MyBTYWx0ZWRfXyYl8e5Nmv5rb y8UVSSZ32TnZT9plmB4Y8A+IO1MlA2QX907mmS7MFF3fDf9Dau3pJBJY/1HJp10u4Pg535npLm4 NOsaSaeZvvecwIaNRXArWFgupruC5BRsta9SCjGMdWRRyA974NV54fqcRbfqCcnb0+iGc0kaG4B E2rKn1eIu+LKI5ArnCj4BgmSS/4OkeVg3PuywYwsuxOesIWZwuB6rT5APyOzhwKAyoK6NJRA8Ey QkJBLXxKjbvB58sHweojL7+oCQ87wGWmrjqTEpwzMv2/4YBUP4MvBkexxXmGDQZrki3c/5v1V/i qjrNJN2qu05jRxSgXZ1rFhxIz40ztie0SM7erXhwgiT5tui7C9pFFqpytMD9WO2H9dwjsoE0me9 Z4zwcCwv X-Proofpoint-GUID: lExViJt-tsHUNMzZP1GbZ-nFr4f4nGOv X-Proofpoint-ORIG-GUID: lExViJt-tsHUNMzZP1GbZ-nFr4f4nGOv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-27_02,2025-08-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 malwarescore=0 spamscore=0 adultscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508260153 Content-Type: text/plain; charset="utf-8" From: Tao Zhang Setting bit i in the TPDA_FLUSH_CR register initiates a flush request for port i, forcing the data to synchronize and be transmitted to the sink device. Signed-off-by: Tao Zhang Co-developed-by: Jie Gan Signed-off-by: Jie Gan Reviewed-by: James Clark --- .../testing/sysfs-bus-coresight-devices-tpda | 7 ++++ drivers/hwtracing/coresight/coresight-tpda.c | 41 +++++++++++++++++++ drivers/hwtracing/coresight/coresight-tpda.h | 1 + 3 files changed, 49 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda b/D= ocumentation/ABI/testing/sysfs-bus-coresight-devices-tpda index fb651aebeb31..2cf2dcfc13c8 100644 --- a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda @@ -41,3 +41,10 @@ Contact: Jinlong Mao , Tao= Zhang /port_flush_req +Date: August 2025 +KernelVersion: 6.17 +Contact: Jinlong Mao , Tao Zhang , Jie Gan +Description: + (RW) Configure the bit i to requests a flush operation of port i on the = TPDA. diff --git a/drivers/hwtracing/coresight/coresight-tpda.c b/drivers/hwtraci= ng/coresight/coresight-tpda.c index a1393962b04d..e9e2736071fb 100644 --- a/drivers/hwtracing/coresight/coresight-tpda.c +++ b/drivers/hwtracing/coresight/coresight-tpda.c @@ -490,6 +490,46 @@ static ssize_t cmbchan_mode_store(struct device *dev, } static DEVICE_ATTR_RW(cmbchan_mode); =20 +static ssize_t port_flush_req_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (!drvdata->csdev->refcnt) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + CS_UNLOCK(drvdata->base); + val =3D readl_relaxed(drvdata->base + TPDA_FLUSH_CR); + CS_LOCK(drvdata->base); + return sysfs_emit(buf, "0x%lx\n", val); +} + +static ssize_t port_flush_req_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t size) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + u32 val; + + if (kstrtou32(buf, 0, &val)) + return -EINVAL; + + if (!drvdata->csdev->refcnt || !val) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + CS_UNLOCK(drvdata->base); + writel_relaxed(val, drvdata->base + TPDA_FLUSH_CR); + CS_LOCK(drvdata->base); + + return size; +} +static DEVICE_ATTR_RW(port_flush_req); + static struct attribute *tpda_attrs[] =3D { &dev_attr_trig_async_enable.attr, &dev_attr_trig_flag_ts_enable.attr, @@ -497,6 +537,7 @@ static struct attribute *tpda_attrs[] =3D { &dev_attr_freq_ts_enable.attr, &dev_attr_global_flush_req.attr, &dev_attr_cmbchan_mode.attr, + &dev_attr_port_flush_req.attr, NULL, }; =20 diff --git a/drivers/hwtracing/coresight/coresight-tpda.h b/drivers/hwtraci= ng/coresight/coresight-tpda.h index 0c9bf2fade56..284ac63699ad 100644 --- a/drivers/hwtracing/coresight/coresight-tpda.h +++ b/drivers/hwtracing/coresight/coresight-tpda.h @@ -10,6 +10,7 @@ #define TPDA_Pn_CR(n) (0x004 + (n * 4)) #define TPDA_FPID_CR (0x084) #define TPDA_SYNCR (0x08C) +#define TPDA_FLUSH_CR (0x090) =20 /* Cross trigger FREQ packets timestamp bit */ #define TPDA_CR_FREQTS BIT(2) --=20 2.34.1