From nobody Wed Dec 17 16:21:55 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B4AD29AAE3 for ; Wed, 27 Aug 2025 04:20:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756268456; cv=none; b=tmlprbtjh/qoEGAyTjc47+4QbMMFTyvN3LWj7wYjuyhz1MvjCYg5tDzHO6Lt8wRwV+1imnEehCp4OqSckZVuKnCIuUYh6IrZqTutNrl52PBHiiDAPSlAEdXxYE7fApexBSJUmJ9c1XIC6pFF9nP8YpMgRakGOLIv8yQdPprTW1Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756268456; c=relaxed/simple; bh=2H3pty48o/VWNYdAx0EAhpd4AWGjCw1PLz46zbPOLUA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=W2cm10SVPeLMzbIxF4E2WnWMcShjMKS9w4WPWxzbGMRDltEggEHH6q1Ov20kegwQ4UNokxqnp5NabVWCLNOzWIaJQ4hDwZbWeQuBSfHfY50hCe9bqZ08XZvs1WcGh96cyHZne28Y4DnnG67KPk49db9jFhkyma1vXXl3XPzHNyM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=euMJ2t7s; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="euMJ2t7s" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57QJrPf9029602 for ; Wed, 27 Aug 2025 04:20:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=s5viB26d9og A7bSXQQ+AjGcC0mWZNZTo//V2CNZ/xps=; b=euMJ2t7sHGm6rq00oGtYpiYKFRU WumgUA7ncKXcFRzxao2wHgrH6d1Ed/28HV/tDgV+DSlK3BJK+6QVNCiWG4mz0fdv OIusO8OzS/O/1KPXKaBbByX9KcIJPMvh0H0QoP6RO3xDqhH7arFW7+RvqqshbX70 t3/Yk2hCfGAAxnCG91AD3JrM80wX1IDVarsGxr+cOeB/RxvMsgi3bW1CJZnwOXRg ow+i3sjNtmsj63h0SlS0s7uOa8SY4Ne9CJHyPdw+alNP0rFxzyQu6fq7thP2q+4l DBoDgTtfVsSZintDw7o7+24cd8AC8sYjgU/k1Jzi/CWFIgBgcL2KEmGeY1g== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48q5unu876-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 27 Aug 2025 04:20:53 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7720c7cc099so27231b3a.3 for ; Tue, 26 Aug 2025 21:20:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756268452; x=1756873252; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s5viB26d9ogA7bSXQQ+AjGcC0mWZNZTo//V2CNZ/xps=; b=Aiw3T0SaLIY8sjaLR0y/ZQmjPLRnjIUidmSQY2lYMD9bsMflpVSh8jsJ4ZnyJAa+lW l6uY1jsNyDP6U1rStsFJV8Wj6VGlHg7Kf6CcxE4+6noH3njF0y//bXk4pn9qjiDDbbfk 5EjhsfRRubcItg2i0NaDY2eRjTlmeikkQyLUPYAjGN4k9i7g0/Km9y0z6/wlyZ6Y5+ut f0XW+iQMVkEa7J3cZjAkYgtc1ZyzdmFmFu/Nq1Y/vcwkow1keN7Y+GpMT2BdOqaRUcHz 84vKIz5lEC5CoQQbSdjReeINKvUOb370AIJbnSXzc95k0ztqvU34OibkA2tI5HtNNDap 21tw== X-Forwarded-Encrypted: i=1; AJvYcCWKGPbOfIOhGwL3zHGXB5E6HaaBG9qpWdcWKW9QfDNacxCNrhfIkfo/3ZjgplHTQvEm41trytYXrJXt9SM=@vger.kernel.org X-Gm-Message-State: AOJu0YzCpl2PM0fQSB1OaAKwohgwWUiBpyRG2qDo0/Cfdp44KcszjK6i Qc2oq+jV5OS/aa016IoK/sUz8Z1rlUiYERTzFtXyu0TJjGeUbvIMHgwRvKQR0hZU+84nMAcoM13 ys1rp3SI416rXj5qVojRCG8Ba/owr4v8SonfM8EPFcrp9EjBBnJU5GAMNh6qWoWdw+U4= X-Gm-Gg: ASbGnct1Cs/iusRoz8BfyKwvBkMPVntPQqCysAMhhvlHNL+BUWVdRaIjW+YoeCLtfE9 rPPVXPNhzf2+oVnemlHSLnvA0P4kewL4h8ceGwpa7Rsw3Dz9Q0MAbDfXq9SfEPn8YYhEEp+6GL7 Q3aRJdE+QlSQbGiYSQ8Jg5LGSTDgzKcMmeQaan0OwN4E7dYduekWJQFAW2Qmrh85VesaRpWoSk1 mVqN1ioPwJWIQIyNyVLREU2M+0AlZEkyNtiE/871+YONz1/9nAyyx8vwWXJNqOoOm7R7ZaQkaMq eyi6PuGtU7WQiCaipB8VYw4Z63F4FJQD8y9GxIh5b/CTtNgrXmtP4Jt6E4nrwhuotw7OYWKSjYk A869uP9D3LissWKor9ggP X-Received: by 2002:a05:6a00:3a07:b0:76e:8cf4:7bc4 with SMTP id d2e1a72fcca58-7702fc0a0c1mr20314498b3a.26.1756268452083; Tue, 26 Aug 2025 21:20:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHWdD4SzItB5SoQXCaoV9DamJae3Xr2kC0zbdTuIzRmptB4vtCRfGd9dS3ojRxh9VDY4bzDoA== X-Received: by 2002:a05:6a00:3a07:b0:76e:8cf4:7bc4 with SMTP id d2e1a72fcca58-7702fc0a0c1mr20314434b3a.26.1756268450914; Tue, 26 Aug 2025 21:20:50 -0700 (PDT) Received: from jiegan.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-771f4072ac4sm4323076b3a.34.2025.08.26.21.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 21:20:50 -0700 (PDT) From: Jie Gan To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Tingwei Zhang Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 1/3] coresight: tpda: add sysfs nodes for tpda cross-trigger configuration Date: Wed, 27 Aug 2025 12:20:40 +0800 Message-Id: <20250827042042.6786-2-jie.gan@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250827042042.6786-1-jie.gan@oss.qualcomm.com> References: <20250827042042.6786-1-jie.gan@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: a_mXvRLWlSu6IvyFKeXJkW42Xqotu2gN X-Proofpoint-ORIG-GUID: a_mXvRLWlSu6IvyFKeXJkW42Xqotu2gN X-Authority-Analysis: v=2.4 cv=JJo7s9Kb c=1 sm=1 tr=0 ts=68ae87a5 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=Hl4cRc3ft4hpfJdQRooA:9 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIzMDAzMSBTYWx0ZWRfXwDfvDrFUCgC4 u21yT6JIU7OiFxdG+rfXBamFtyICoBv8/lYv362+N15SmMJAHNNzJZTd3UHGUDp2HZPcn5JUJOu Psl4UJrvTwAtJiB2OfiNV2aYDRuJ7guGXxWDffpX4RZKZC7xpOiVoUbxjlxfjdniXIPo/fwvlZn CgcoSdGOYwdh96HMEi2jjdzdb1WeDmdLje3BT2waoZW1XHtv4MV5a+QOdruTKpXPdjo9phcSGGM o8p64xjTZDH2EJC66jU5MhxsIyQpX/37j7qWNOJ4M2fmWrJizptstyK3A2JlbiVLTk5PjhUYWXG HLzKkNs9WbHlkK2xsLnSdPlf5tnXgUGMb2EgDZyqe64NOPXt/jyeJtzRioPy0Aq95WWZ4no2xIz fQJ23VWL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-26_02,2025-08-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 bulkscore=0 spamscore=0 impostorscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508230031 Content-Type: text/plain; charset="utf-8" From: Tao Zhang Introduce sysfs nodes to configure cross-trigger parameters for TPDA. These registers define the characteristics of cross-trigger packets, including generation frequency and flag values. Signed-off-by: Tao Zhang Co-developed-by: Jie Gan Signed-off-by: Jie Gan --- .../testing/sysfs-bus-coresight-devices-tpda | 43 ++++ drivers/hwtracing/coresight/coresight-tpda.c | 227 ++++++++++++++++++ drivers/hwtracing/coresight/coresight-tpda.h | 27 ++- 3 files changed, 296 insertions(+), 1 deletion(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-t= pda diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda b/D= ocumentation/ABI/testing/sysfs-bus-coresight-devices-tpda new file mode 100644 index 000000000000..fb651aebeb31 --- /dev/null +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda @@ -0,0 +1,43 @@ +What: /sys/bus/coresight/devices//trig_async_enable +Date: August 2025 +KernelVersion: 6.17 +Contact: Jinlong Mao , Tao Zhang , Jie Gan +Description: + (RW) Enable/disable cross trigger synchronization sequence interface. + +What: /sys/bus/coresight/devices//trig_flag_ts_enable +Date: August 2025 +KernelVersion: 6.17 +Contact: Jinlong Mao , Tao Zhang , Jie Gan +Description: + (RW) Enable/disable cross trigger FLAG packet request interface. + +What: /sys/bus/coresight/devices//trig_freq_enable +Date: August 2025 +KernelVersion: 6.17 +Contact: Jinlong Mao , Tao Zhang , Jie Gan +Description: + (RW) Enable/disable cross trigger FREQ packet request interface. + +What: /sys/bus/coresight/devices//freq_ts_enable +Date: August 2025 +KernelVersion: 6.17 +Contact: Jinlong Mao , Tao Zhang , Jie Gan +Description: + (RW) Enable/disable the timestamp for all FREQ packets. + +What: /sys/bus/coresight/devices//global_flush_req +Date: August 2025 +KernelVersion: 6.17 +Contact: Jinlong Mao , Tao Zhang , Jie Gan +Description: + (RW) Set global (all ports) flush request bit. The bit remains set until= a + global flush request sequence completes. + +What: /sys/bus/coresight/devices//cmbchan_mode +Date: August 2025 +KernelVersion: 6.17 +Contact: Jinlong Mao , Tao Zhang , Jie Gan +Description: + (RW) Configure the CMB/MCMB channel mode for all enabled ports. + Value 0 means raw channel mapping mode. Value 1 means channel pair marki= ng mode. diff --git a/drivers/hwtracing/coresight/coresight-tpda.c b/drivers/hwtraci= ng/coresight/coresight-tpda.c index 4e93fa5bace4..647ab49a98d7 100644 --- a/drivers/hwtracing/coresight/coresight-tpda.c +++ b/drivers/hwtracing/coresight/coresight-tpda.c @@ -156,9 +156,37 @@ static void tpda_enable_pre_port(struct tpda_drvdata *= drvdata) u32 val; =20 val =3D readl_relaxed(drvdata->base + TPDA_CR); + val &=3D ~TPDA_CR_MID; val &=3D ~TPDA_CR_ATID; val |=3D FIELD_PREP(TPDA_CR_ATID, drvdata->atid); + if (drvdata->trig_async) + val |=3D TPDA_CR_SRIE; + else + val &=3D ~TPDA_CR_SRIE; + if (drvdata->trig_flag_ts) + val |=3D TPDA_CR_FLRIE; + else + val &=3D ~TPDA_CR_FLRIE; + if (drvdata->trig_freq) + val |=3D TPDA_CR_FRIE; + else + val &=3D ~TPDA_CR_FRIE; + if (drvdata->freq_ts) + val |=3D TPDA_CR_FREQTS; + else + val &=3D ~TPDA_CR_FREQTS; + if (drvdata->cmbchan_mode) + val |=3D TPDA_CR_CMBCHANMODE; + else + val &=3D ~TPDA_CR_CMBCHANMODE; writel_relaxed(val, drvdata->base + TPDA_CR); + + /* + * If FLRIE bit is set, set the master and channel + * id as zero + */ + if (drvdata->trig_flag_ts) + writel_relaxed(0x0, drvdata->base + TPDA_FPID_CR); } =20 static int tpda_enable_port(struct tpda_drvdata *drvdata, int port) @@ -274,6 +302,203 @@ static const struct coresight_ops tpda_cs_ops =3D { .link_ops =3D &tpda_link_ops, }; =20 +static ssize_t trig_async_enable_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->trig_async); +} + +static ssize_t trig_async_enable_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t size) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (kstrtoul(buf, 0, &val)) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + drvdata->trig_async =3D !!val; + + return size; +} +static DEVICE_ATTR_RW(trig_async_enable); + +static ssize_t trig_flag_ts_enable_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->trig_flag_ts); +} + +static ssize_t trig_flag_ts_enable_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t size) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (kstrtoul(buf, 0, &val)) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + drvdata->trig_flag_ts =3D !!val; + + return size; +} +static DEVICE_ATTR_RW(trig_flag_ts_enable); + +static ssize_t trig_freq_enable_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->trig_freq); +} + +static ssize_t trig_freq_enable_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t size) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (kstrtoul(buf, 0, &val)) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + drvdata->trig_freq =3D !!val; + + return size; +} +static DEVICE_ATTR_RW(trig_freq_enable); + +static ssize_t freq_ts_enable_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->freq_ts); +} + +static ssize_t freq_ts_enable_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t size) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (kstrtoul(buf, 0, &val)) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + drvdata->freq_ts =3D !!val; + + return size; +} +static DEVICE_ATTR_RW(freq_ts_enable); + +static ssize_t global_flush_req_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (!drvdata->csdev->refcnt) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + CS_UNLOCK(drvdata->base); + val =3D readl_relaxed(drvdata->base + TPDA_CR); + CS_LOCK(drvdata->base); + + return sysfs_emit(buf, "%lx\n", val); +} + +static ssize_t global_flush_req_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t size) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (kstrtoul(buf, 0, &val)) + return -EINVAL; + + if (!drvdata->csdev->refcnt || !val) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + CS_UNLOCK(drvdata->base); + val =3D readl_relaxed(drvdata->base + TPDA_CR); + val |=3D BIT(0); + writel_relaxed(val, drvdata->base + TPDA_CR); + CS_LOCK(drvdata->base); + + return size; +} +static DEVICE_ATTR_RW(global_flush_req); + +static ssize_t cmbchan_mode_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + + return sysfs_emit(buf, "%u\n", (unsigned int)drvdata->cmbchan_mode); +} + +static ssize_t cmbchan_mode_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t size) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (kstrtoul(buf, 0, &val)) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + drvdata->cmbchan_mode =3D !!val; + + return size; +} +static DEVICE_ATTR_RW(cmbchan_mode); + +static struct attribute *tpda_attrs[] =3D { + &dev_attr_trig_async_enable.attr, + &dev_attr_trig_flag_ts_enable.attr, + &dev_attr_trig_freq_enable.attr, + &dev_attr_freq_ts_enable.attr, + &dev_attr_global_flush_req.attr, + &dev_attr_cmbchan_mode.attr, + NULL, +}; + +static struct attribute_group tpda_attr_grp =3D { + .attrs =3D tpda_attrs, +}; + +static const struct attribute_group *tpda_attr_grps[] =3D { + &tpda_attr_grp, + NULL, +}; + static int tpda_init_default_data(struct tpda_drvdata *drvdata) { int atid; @@ -289,6 +514,7 @@ static int tpda_init_default_data(struct tpda_drvdata *= drvdata) return atid; =20 drvdata->atid =3D atid; + drvdata->freq_ts =3D true; return 0; } =20 @@ -332,6 +558,7 @@ static int tpda_probe(struct amba_device *adev, const s= truct amba_id *id) desc.ops =3D &tpda_cs_ops; desc.pdata =3D adev->dev.platform_data; desc.dev =3D &adev->dev; + desc.groups =3D tpda_attr_grps; desc.access =3D CSDEV_ACCESS_IOMEM(base); drvdata->csdev =3D coresight_register(&desc); if (IS_ERR(drvdata->csdev)) diff --git a/drivers/hwtracing/coresight/coresight-tpda.h b/drivers/hwtraci= ng/coresight/coresight-tpda.h index c6af3d2da3ef..0be625fb52fd 100644 --- a/drivers/hwtracing/coresight/coresight-tpda.h +++ b/drivers/hwtracing/coresight/coresight-tpda.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved. + * Copyright (c) 2023,2025 Qualcomm Innovation Center, Inc. All rights res= erved. */ =20 #ifndef _CORESIGHT_CORESIGHT_TPDA_H @@ -8,6 +8,19 @@ =20 #define TPDA_CR (0x000) #define TPDA_Pn_CR(n) (0x004 + (n * 4)) +#define TPDA_FPID_CR (0x084) + +/* Cross trigger FREQ packets timestamp bit */ +#define TPDA_CR_FREQTS BIT(2) +/* Cross trigger FREQ packet request bit */ +#define TPDA_CR_FRIE BIT(3) +/* Cross trigger FLAG packet request interface bit */ +#define TPDA_CR_FLRIE BIT(4) +/* Cross trigger synchronization bit */ +#define TPDA_CR_SRIE BIT(5) +/* Packetize CMB/MCMB traffic bit */ +#define TPDA_CR_CMBCHANMODE BIT(20) + /* Aggregator port enable bit */ #define TPDA_Pn_CR_ENA BIT(0) /* Aggregator port CMB data set element size bit */ @@ -19,6 +32,8 @@ =20 /* Bits 6 ~ 12 is for atid value */ #define TPDA_CR_ATID GENMASK(12, 6) +/* Bits 13 ~ 19 is for mid value */ +#define TPDA_CR_MID GENMASK(19, 13) =20 /** * struct tpda_drvdata - specifics associated to an TPDA component @@ -29,6 +44,11 @@ * @enable: enable status of the component. * @dsb_esize Record the DSB element size. * @cmb_esize Record the CMB element size. + * @trig_async: Enable/disable cross trigger synchronization sequence inte= rface. + * @trig_flag_ts: Enable/disable cross trigger FLAG packet request interfa= ce. + * @trig_freq: Enable/disable cross trigger FREQ packet request interface. + * @freq_ts: Enable/disable the timestamp for all FREQ packets. + * @cmbchan_mode: Configure the CMB/MCMB channel mode. */ struct tpda_drvdata { void __iomem *base; @@ -38,6 +58,11 @@ struct tpda_drvdata { u8 atid; u32 dsb_esize; u32 cmb_esize; + bool trig_async; + bool trig_flag_ts; + bool trig_freq; + bool freq_ts; + bool cmbchan_mode; }; =20 #endif /* _CORESIGHT_CORESIGHT_TPDA_H */ --=20 2.34.1 From nobody Wed Dec 17 16:21:55 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3109A2773C1 for ; Wed, 27 Aug 2025 04:20:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756268457; cv=none; b=NvGOsgSexRFZLA6vP2VoZTntqAZv9IpytVeZGRY9Ecdm/qKqE+FQS3hmngVDYrmGOWLbUwCOoIY0EvetYsdRHDPVTDZGsbQnup9rpBuQM67/AK54z42cH/Ol4LsDFdtaI851Mz2WTGyLPHXIdKklbgwXvS9xk5LiSvxPOmO/EJ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756268457; c=relaxed/simple; bh=xN5aoKqkzdNrpFq90kBel8vDcXnD6KFAzDt9yvkGQSE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rWC/79JksUEG48jvgjfRG4ggkZVSpQ6V8TOaX1xSHUghEl4uYklBzwWUuY3NmOI4vtomwLi2Fxi5VAhnqVTA47opMpk90HFwNf/nwf0BJ77+HxMam0sZ1/RiT2VbdZqkJbjhHZFgdO/qjX74X4WFceowJ0I0vIb/ND2kj2ivLG4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OWp6PEmf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OWp6PEmf" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57QJjDPP010324 for ; Wed, 27 Aug 2025 04:20:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=cgG9jC0fRhi ZdyvHtCvfrzjfO+AU/dNPrDX32M3A0k4=; b=OWp6PEmfY8HzuLFpF7XPI6Hutvn 383bVACz2Qb5cExMcKHEYsA4bCqcXvZo/rpaZ6kmFl15rQ+qRcYfgFSU5zeseDIN qr2AwTQJj5TwgXDwyxRU4i/HRWBp31nWBAJl0rBWWhBhric1WHFEPaGA0893oUa6 C2uPPs4Rb1eDdR3dTMGYPZ4I1gg97LBbv41ZUV4aqed8AiK6izXE4Z7SF1sy0rpw hYaevd+vWiz8kxE4e0PNZwyjdwN4/jKkmDjOdGS9pTqfhhJ+CMaRto7Qi1UfKMkO DuV9RuHGKN53m/SXh3LcLnpTYMal8JN+tZNup67bpPt3CFuOD4D5lwH9SlQ== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48q5w2uh1r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 27 Aug 2025 04:20:55 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-771d7aa1470so2542299b3a.2 for ; Tue, 26 Aug 2025 21:20:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756268455; x=1756873255; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cgG9jC0fRhiZdyvHtCvfrzjfO+AU/dNPrDX32M3A0k4=; b=bNuFvXHPKlpG3/oaMXaQJZjOpOtakGcuubFzEIZ7yFnKpdQ5KruBpnJUKdvDGzqSGP X/JtCis7aQ5+6SpW//Rmq2iFwrx2oSyFFwp9yKj31uqT3b2+QGjTrewQW5YQjGjo3k8y C+pxwjle0rDOKbECSWdkYogzLxSBP6IVxEQF2SzCiFUOl2T0JlIX9oqE1ZzXizioi64W BpT68r6Ysjifjabv4lzwJoYCxkoynqJtuVf7Lr/6RpAazUWU2HgIXIoeSs7dAQfZwmcn AqvemNqicsZFh5MVAElBiPj4wQwN/UEj2FUNWDr9D+dNCBPjhmCVLpmHpl6/zvYB76Gn xbGw== X-Forwarded-Encrypted: i=1; AJvYcCU8D3dZm0mhWhMWJdJNXhWJQATfx+x2QmSbBpcSMjztVSl6VStBtjlqkAB3HR6qOoov20loGJQNOhtXoZw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2xIs5FJQr8jMVQGA85C4t/JrwnOos+rcppQyHiAJVAEChHcnZ jUUm1cZcXMLLh/AZs69mbx55KvTz12ynXMc/dNx+T9JX974xFLCkUT5rAGf0SjhYt98AhYqWwUH WkTXq3GPR+AwTyn0Gj6s7LsdDGFvpCKkzf1411sHh9oztLH2iWrzDz2Dnthn2MUDl2Rk= X-Gm-Gg: ASbGncvU28fsarBUMsD57pWiphb0dkHKxv2sK+c9LBu2oTMM+wkj/1K0qMyEHs3q8Q7 9Y9tdeKKUUA1AByYlcURSbFOu1ytoxXbHRmZmgHKfiyjjROSfPOdenEF9Lc615jz65wxm8MzikL wVOvnk95SFOXs3Fd0CAoN7iNoOZYUJB0R7M9zsrRC8DzncCXMg23ZK5mR8hradYBeE9W+19Bd+s 6tSXhXjt+xFUde8AQZHT3pxllfInq2z2yEC42gk2Rh2x9fVnnfol7DBWjJASCVi3TG0oK3e1o8u ZuZWUyJOp2gM0PgkX8xWgjwBkQ7r4nMUUu7DbCQkCiKEkgG9I9vj7DTQWJ9zNz/0rtsrLXZj1YJ nXlPKvJk3p+P2yOtyhHpb X-Received: by 2002:a05:6a00:b4f:b0:771:e10d:813d with SMTP id d2e1a72fcca58-771e10d83f6mr11712090b3a.21.1756268454717; Tue, 26 Aug 2025 21:20:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFbYYxd6uRKJhXpbWdWQeevt5PKMUN9Cf+ngWv6eWh3hbHw3ZL94CizAJIrwirDo4XyosfX/g== X-Received: by 2002:a05:6a00:b4f:b0:771:e10d:813d with SMTP id d2e1a72fcca58-771e10d83f6mr11712066b3a.21.1756268454230; Tue, 26 Aug 2025 21:20:54 -0700 (PDT) Received: from jiegan.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-771f4072ac4sm4323076b3a.34.2025.08.26.21.20.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 21:20:53 -0700 (PDT) From: Jie Gan To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Tingwei Zhang Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 2/3] coresight: tpda: add logic to configure TPDA_SYNCR register Date: Wed, 27 Aug 2025 12:20:41 +0800 Message-Id: <20250827042042.6786-3-jie.gan@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250827042042.6786-1-jie.gan@oss.qualcomm.com> References: <20250827042042.6786-1-jie.gan@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=Z/vsHGRA c=1 sm=1 tr=0 ts=68ae87a7 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=6Dbyrv6SX_ztr3m6kfUA:9 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIzMDAzMyBTYWx0ZWRfX9pUUJGFTeeCp qvOlR3/bo/KWyRlSSv0xLUxDu9kRDoLzew/AQwPwNnFazKvD0/SOY0DlPOQWDL3QGg3S5ojCU7R 1peYCkoM5XdSUGy4IMmtG9J/F299aHZRmwPwS9mxOmYuGHwpNf8TmQlAVxo8+Y8n78+YN8OTKIF 2EVJGiD2jGTi3OoNBX0OUuMd5w15Wm2uNWgq6Jepq5t40cEH/SnDC+lt/Rd0aw/MQwTzqTU6bVY LNOWKOlaSD61FyTmfyGAkxPY2l3eUQPs7H1pcXkxEyh+apiT8tPQdVQQ0obq0MNhC5mlrbxTCNl rQDYpaPw0KY/4fW1A1yLAnFqIWPohlYt7kjcNi9ox8c/r8TkMOYaIOtRfTfjpxTfU8boDR8IrtM tROESlik X-Proofpoint-GUID: 5KSxhqbyjMq_CsQBGKmNP2g7ssSB11o1 X-Proofpoint-ORIG-GUID: 5KSxhqbyjMq_CsQBGKmNP2g7ssSB11o1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-26_02,2025-08-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 phishscore=0 clxscore=1015 suspectscore=0 impostorscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508230033 Content-Type: text/plain; charset="utf-8" From: Tao Zhang The TPDA_SYNCR register defines the frequency at which TPDA generates ASYNC packets, enabling userspace tools to accurately parse each valid packet. Signed-off-by: Tao Zhang Co-developed-by: Jie Gan Signed-off-by: Jie Gan --- drivers/hwtracing/coresight/coresight-tpda.c | 7 +++++++ drivers/hwtracing/coresight/coresight-tpda.h | 6 ++++++ 2 files changed, 13 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-tpda.c b/drivers/hwtraci= ng/coresight/coresight-tpda.c index 647ab49a98d7..430f76c559f2 100644 --- a/drivers/hwtracing/coresight/coresight-tpda.c +++ b/drivers/hwtracing/coresight/coresight-tpda.c @@ -187,6 +187,13 @@ static void tpda_enable_pre_port(struct tpda_drvdata *= drvdata) */ if (drvdata->trig_flag_ts) writel_relaxed(0x0, drvdata->base + TPDA_FPID_CR); + + /* Program the counter value for TPDA_SYNCR */ + val =3D readl_relaxed(drvdata->base + TPDA_SYNCR); + /* Clear the mode */ + val &=3D ~TPDA_SYNCR_MODE_CTRL; + val |=3D FIELD_PREP(TPDA_SYNCR_COUNTER_MASK, TPDA_SYNCR_MAX_COUNTER_VAL); + writel_relaxed(val, drvdata->base + TPDA_SYNCR); } =20 static int tpda_enable_port(struct tpda_drvdata *drvdata, int port) diff --git a/drivers/hwtracing/coresight/coresight-tpda.h b/drivers/hwtraci= ng/coresight/coresight-tpda.h index 0be625fb52fd..8e1b66115ad1 100644 --- a/drivers/hwtracing/coresight/coresight-tpda.h +++ b/drivers/hwtracing/coresight/coresight-tpda.h @@ -9,6 +9,7 @@ #define TPDA_CR (0x000) #define TPDA_Pn_CR(n) (0x004 + (n * 4)) #define TPDA_FPID_CR (0x084) +#define TPDA_SYNCR (0x08C) =20 /* Cross trigger FREQ packets timestamp bit */ #define TPDA_CR_FREQTS BIT(2) @@ -27,6 +28,11 @@ #define TPDA_Pn_CR_CMBSIZE GENMASK(7, 6) /* Aggregator port DSB data set element size bit */ #define TPDA_Pn_CR_DSBSIZE BIT(8) +/* TPDA_SYNCR mode control bit */ +#define TPDA_SYNCR_MODE_CTRL BIT(12) +/* TPDA_SYNCR counter mask */ +#define TPDA_SYNCR_COUNTER_MASK GENMASK(11, 0) +#define TPDA_SYNCR_MAX_COUNTER_VAL (0xFFF) =20 #define TPDA_MAX_INPORTS 32 =20 --=20 2.34.1 From nobody Wed Dec 17 16:21:55 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 534D52C15AE for ; Wed, 27 Aug 2025 04:21:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756268461; cv=none; b=fpTWSHubnFBcn1qVyErsXlz6D1UASumz8DJSFRKzaGUKbsC9Nn1rhRWSnXbdJvMf0jki66+wLzZc1P47uuZyVxTgDTf5M+cDpAYa1BJk6lwr6TfDx09uTZkH7vvYRXmgyV1ehy0kqSn0m22Id0sGFIbR+9MhN241gC5ZkVMysBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756268461; c=relaxed/simple; bh=ocp4EtIWT0yQZJx2kabJRwppCpqBBhc20itvLNY7cW4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sinXy7EAyn9FYLi8EngWCJf+XMIi/Z3yZ9VIxrQnoFK+axieYZ3CSFUc91VCbEO7bfh2jRwgxpS9XnJe2sgwr2sQaFc09lKVkmgmT9iHAxs6HtCYG/pNG6C+yrXXU6F2l7399CV1z5rEyw3UxU9UKvzPjCmMXF1bzHZlLmntLb8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iNhbMWaJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iNhbMWaJ" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57QL1RfQ021722 for ; Wed, 27 Aug 2025 04:20:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=LFgzrZAixnT qFsEdbAYjDQONQ2mnmA9c8+kXB2USXhQ=; b=iNhbMWaJDlRl7uFXPhJdTn/l/sK oVXznRwiU+6nBM+5O1M8eEXZJDPjaY8C3tr1MgdcUTFUL4FXZhyjk1fg8a0BFisD /04GkXfCopoJ1xjouI4i2/2TwdzY0PquJaJARlyivNCPc2R8Miezam0CnTG6WKor ruRJy2p38cQ1aF8+HmMEQa1Y4l6N2HAmrJDn94r7W/Lt41qx5wZvMsMnUJLx3wI4 E7HN24cgv2/E4a7koHRewY1SzgJFaXh90IbfR4H2yOqWDA3gYIrnBjDAawTk6Rk3 SFTcAe20c1eh87dxOvntLL9FfjgZGuolCrREc4gfMyIquCHjmYRyr31l+IA== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48q615ka8h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 27 Aug 2025 04:20:59 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b471737c5efso4728885a12.1 for ; Tue, 26 Aug 2025 21:20:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756268458; x=1756873258; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LFgzrZAixnTqFsEdbAYjDQONQ2mnmA9c8+kXB2USXhQ=; b=rL33uW+9/TEwIYWwDL9dIu1D57txkQmsSMJP4HyfiixQAW77RMTw0CDTVZbax5fTft nV4kwRmOmpSBHOLOhjFGJzJOyGH1JP4xfZFIS3cCsGi9+dNpyiaqQpov1pB0g1KNotqY 0NauVMtox22BfUeTSnS7emJmTRobQ5H/Ji3IaLSUAwXK9Uh++i7KBa4mULE2RSPFc6LD y7XoI/OqDRffw4f0/G/cwCM8xRGTp1AmgSmr2irYQm5R1TggBgDTdOjeIW5iKpUuCtOc rh5IIFOZnSWeKByeTDvvfb3PHqx6Lq4K0ewLcoWXSjf1UGIokjc3K3nE7EhQIB6tD31z tlWg== X-Forwarded-Encrypted: i=1; AJvYcCWtMeHC3fI9UqYGiZ8jneF6d33403BX/9kT/1Iyl5vZSuRuB+B5MerTsX/WDgBsqJfVTG9038CtUYJePcw=@vger.kernel.org X-Gm-Message-State: AOJu0YyaPY1gKO4Zb/dfqr/MekOlOG8Jg3zAQo1pRmeKmShvc8yUxKHI R7dMICzd8Cg0ijCXgBHufIHJuDVWdwLDUZWRCIoEw/kzibBUhicpMDKwhJccQBX+JSZJfihWG5m pNBkdshReIn/8dGsDKIIOv1ADlZ14aGLVnEj1/P31EiFQz/rDHudeDaAofLABOy9UyJA= X-Gm-Gg: ASbGncvyhGMW9lJhj5lMn3NFg8X16CYyh1ghf+SxHbTxUpZswx4mMIp2NDPDJA9tnH/ PkUQ2yhvr+ShbHCOdvWXVm79wZNae3HdLaHp2fAqSQW/kz4GZT1O37biccH9bkmZDvrVLhwitjr P88hZFxvpCEc7VtpIPrmeln79AYzX3+usem9ZCvFQV+nxTot1qWWLKyoH8gsamc27AG3IFC8k+e Eab/DaiJ/HtdcaQxfl6DXPbquVtg99n/+K8/8sejFbJPBJd3YPMuUbzxfl9NLQ/HMeb2Ua55LBN YHj+QRwSOUGQ7eCsaRWasCIs9dehGbU8J0yy4W6hgRo9JXfghBag9BoCenP2gP6BZNcN8CiNR+c NoPO6X7u/PPhrYlXJQ0Uj X-Received: by 2002:a05:6a20:244f:b0:230:3710:9aa9 with SMTP id adf61e73a8af0-24340bce30emr25026146637.4.1756268457889; Tue, 26 Aug 2025 21:20:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdCRcL4yrE9XGANFjJJjHieROHuyk+4KHF1iEmPx2C2KpvsxbNZ36c7SUdVsYPPF6S/m2zyw== X-Received: by 2002:a05:6a20:244f:b0:230:3710:9aa9 with SMTP id adf61e73a8af0-24340bce30emr25026121637.4.1756268457424; Tue, 26 Aug 2025 21:20:57 -0700 (PDT) Received: from jiegan.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-771f4072ac4sm4323076b3a.34.2025.08.26.21.20.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 21:20:57 -0700 (PDT) From: Jie Gan To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Tingwei Zhang Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 3/3] coresight: tpda: add sysfs node to flush specific port Date: Wed, 27 Aug 2025 12:20:42 +0800 Message-Id: <20250827042042.6786-4-jie.gan@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250827042042.6786-1-jie.gan@oss.qualcomm.com> References: <20250827042042.6786-1-jie.gan@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIzMDAzNCBTYWx0ZWRfXx0P4ImRJEnHN nzKpL8U83xC/K82/iAC7ddhS+hTteRk0Y1g/0mbzbrPmaxNkouPxW/MtVtdS/Kew19QTMV6Lm9R ttMhVjkVV1zkrGhum1skmGj+OrR2Y1jg/2aZ/VNiXzNS9Q/gzsOvOksizuXtqCMqqUYDye6ohZz 2AkGRzi+DNbqC9EcjYLzkegMZ8/TCBgSE6OhRN2M8QgMCyW8xMNPH66+ZRGKLs+FCE5UGFBLD7Z gV7Mec/jBPI8Fp3bqB4x3dKjq7eW39f9z6/3/WJMUQWWdzrIdgynIVqmUsXttJWG0+8Z5ePfQbb 1S2RIRAin76eTgOrnMxLorEEaA0cCOKioQz57BzUmrN5wiqtp1GYItPEaD2KxJFDRrh7klT1Z0i MqCgOPLX X-Proofpoint-GUID: Ac0iCg-0YYQO7uApZoeasRAri5ls8ndX X-Authority-Analysis: v=2.4 cv=K+AiHzWI c=1 sm=1 tr=0 ts=68ae87ab cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=l6kBNUb3cY0M__Xq7_0A:9 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-ORIG-GUID: Ac0iCg-0YYQO7uApZoeasRAri5ls8ndX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-26_02,2025-08-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 bulkscore=0 clxscore=1015 adultscore=0 impostorscore=0 priorityscore=1501 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508230034 Content-Type: text/plain; charset="utf-8" From: Tao Zhang Setting bit i in the TPDA_FLUSH_CR register initiates a flush request for port i, forcing the data to synchronize and be transmitted to the sink device. Signed-off-by: Tao Zhang Co-developed-by: Jie Gan Signed-off-by: Jie Gan --- .../testing/sysfs-bus-coresight-devices-tpda | 7 ++++ drivers/hwtracing/coresight/coresight-tpda.c | 42 +++++++++++++++++++ drivers/hwtracing/coresight/coresight-tpda.h | 2 + 3 files changed, 51 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda b/D= ocumentation/ABI/testing/sysfs-bus-coresight-devices-tpda index fb651aebeb31..2cf2dcfc13c8 100644 --- a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda @@ -41,3 +41,10 @@ Contact: Jinlong Mao , Tao= Zhang /port_flush_req +Date: August 2025 +KernelVersion: 6.17 +Contact: Jinlong Mao , Tao Zhang , Jie Gan +Description: + (RW) Configure the bit i to requests a flush operation of port i on the = TPDA. diff --git a/drivers/hwtracing/coresight/coresight-tpda.c b/drivers/hwtraci= ng/coresight/coresight-tpda.c index 430f76c559f2..8b1fe128881d 100644 --- a/drivers/hwtracing/coresight/coresight-tpda.c +++ b/drivers/hwtracing/coresight/coresight-tpda.c @@ -487,6 +487,47 @@ static ssize_t cmbchan_mode_store(struct device *dev, } static DEVICE_ATTR_RW(cmbchan_mode); =20 +static ssize_t port_flush_req_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (!drvdata->csdev->refcnt) + return -EINVAL; + + guard(spinlock)(&drvdata->spinlock); + CS_UNLOCK(drvdata->base); + val =3D readl_relaxed(drvdata->base + TPDA_FLUSH_CR); + CS_LOCK(drvdata->base); + return sysfs_emit(buf, "%lx\n", val); +} + +static ssize_t port_flush_req_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t size) +{ + struct tpda_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + unsigned long val; + + if (kstrtoul(buf, 0, &val)) + return -EINVAL; + + if (!drvdata->csdev->refcnt || !val) + return -EINVAL; + + val |=3D FIELD_PREP(TPDA_MAX_INPORTS_MASK, val); + guard(spinlock)(&drvdata->spinlock); + CS_UNLOCK(drvdata->base); + writel_relaxed(val, drvdata->base + TPDA_FLUSH_CR); + CS_LOCK(drvdata->base); + + return size; +} +static DEVICE_ATTR_RW(port_flush_req); + static struct attribute *tpda_attrs[] =3D { &dev_attr_trig_async_enable.attr, &dev_attr_trig_flag_ts_enable.attr, @@ -494,6 +535,7 @@ static struct attribute *tpda_attrs[] =3D { &dev_attr_freq_ts_enable.attr, &dev_attr_global_flush_req.attr, &dev_attr_cmbchan_mode.attr, + &dev_attr_port_flush_req.attr, NULL, }; =20 diff --git a/drivers/hwtracing/coresight/coresight-tpda.h b/drivers/hwtraci= ng/coresight/coresight-tpda.h index 8e1b66115ad1..56d3ad293e46 100644 --- a/drivers/hwtracing/coresight/coresight-tpda.h +++ b/drivers/hwtracing/coresight/coresight-tpda.h @@ -10,6 +10,7 @@ #define TPDA_Pn_CR(n) (0x004 + (n * 4)) #define TPDA_FPID_CR (0x084) #define TPDA_SYNCR (0x08C) +#define TPDA_FLUSH_CR (0x090) =20 /* Cross trigger FREQ packets timestamp bit */ #define TPDA_CR_FREQTS BIT(2) @@ -35,6 +36,7 @@ #define TPDA_SYNCR_MAX_COUNTER_VAL (0xFFF) =20 #define TPDA_MAX_INPORTS 32 +#define TPDA_MAX_INPORTS_MASK GENMASK(31, 0) =20 /* Bits 6 ~ 12 is for atid value */ #define TPDA_CR_ATID GENMASK(12, 6) --=20 2.34.1