From nobody Fri Oct 3 18:10:11 2025 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F89E2857DF; Wed, 27 Aug 2025 10:42:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756291358; cv=none; b=Cdui2DJqwJiZ06Ky4YrQ2EidbKRwDjlX+s257h8GHVeL+TmYUaCtYNUJHitrGrbNO/AhULXcXpvQMx9kkOELjzwDWcagZzkf50Hs/My3M1dSDntIyaOOO1wdweJ184FH4w+PA08YaWRCjSqoVQdEZjIc4ajyvncmt/InNqxlTIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756291358; c=relaxed/simple; bh=ZtBIdZnCHZQ12LtgRqgW3EI2B93ul2ZH8koIDN46ZQM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nxvs/vRltA3CY/VYmR2UNWVxvmAsMAD0bbYo70pbwkhYuGwwIIa1Z5l9+29fPVyfBXlFeh8UC29rnjtg7qtCCxP2x3HMaR3EwJfqrmdk1x6FfafDaSY9r0salbNSO79mTUMwg95EkvGCwrywEjkfN9EyTtYpJqff82PeVK+F1Ig= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-afec56519c4so60515566b.0; Wed, 27 Aug 2025 03:42:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756291355; x=1756896155; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G79AwsSEkP9NYp/OkHMwA+Hki4uOuwUkISdhI+Igu/o=; b=fi+ISCrcnk+pzj6AMEFq0LcCBthTD5k7JwkSWFMCSSiQ/FRQyrV5dxf8WrVyFxADiD bssL++6n6C6gVuTjPjTm3xd+gpmpJQgk/TPDqNgAvSubEyG9dhWswPTLMT5ORFneB9Qa syDPLg4ZtCllG3XxIEFsaCyao3LGiT9CJfatpyecv13GF8dTnM7eXl7F7CNSvHiD82sH ceSKVRoi8GuTbF5T+6KFtOpT9SiuYQ2r4p7bgJq/KlOBLcze6avdyS8J/CeQ9bL6kIzJ TZx15JkBSW5YnVlaL6B+lEr76OsNCMt7xNhF3ZxpIbg2zeAN2fO66lkzPjnssCryMDN+ ljYg== X-Forwarded-Encrypted: i=1; AJvYcCUlinTxvvKIXyNOxtI8lRLPEtCRnhhwDsEI+R6Z9LDOXjAR5Fe1fZpFx0GjjPct7OK3paTuTLs42xMIgA==@vger.kernel.org, AJvYcCWTh+tqMOGGywge0DagzDr48OC9mnr+Qb3pbP3aGQ7Ur9QFtAAkV827BAg6+2OblmnpzPW8D5kLRbx4j50=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9i4OQjTgRHN+tZuFnqQdI57CDpUW1rA50RzhcF4N+OSEfd3MA y9odofeLu1xCOW1R4IBSv8ISMfeZJ5Ej/X4n1QSL11I4V6w8vxDpNepI X-Gm-Gg: ASbGncv/Lkznrv58dnbbKwphIPEztmC0ui3qK2IxKaDWQYZVYYmu8VubgHd0WDvC0k5 RAeVudoc6zghASh1bqDMWQjNWDJ41PfKgdhq76t4JIZOjD+TKtL03Pxa3MLgf5B4kqDeQpAvEeJ ns5G0GiQzYNTFjpVmE4rEOB4eK++995GPfeNN8BLwhCzCbPAVkZGvianiUnsi83U509O5EIHbCY K8PecIaJzpkiWq1jqD02GCmCKX58cR2k1VQpbNkmwANjTJcImg3mMZd3Eg7bxBG3frtcVtu6UUn qmNv5K5ebGuMp076LYoh4EzhKU9j4ioA31jk7dmPFHBze9JL1r3LDPig17tPy9/HZaSP6WuZg1e Mct+uyBdtQCBmGA== X-Google-Smtp-Source: AGHT+IGCNXjZVRJSHl42HEXN59RSgLMpGNWQpTXxDCqtsTc88Oi0JVJAK4fEp5EBAEbzQTdpR/dOjg== X-Received: by 2002:a17:906:eecc:b0:afa:1d2c:2dc7 with SMTP id a640c23a62f3a-afe296ec4acmr1912007166b.57.1756291354609; Wed, 27 Aug 2025 03:42:34 -0700 (PDT) Received: from localhost ([2a03:2880:30ff:73::]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe8e77c6aasm519657866b.56.2025.08.27.03.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Aug 2025 03:42:34 -0700 (PDT) From: Breno Leitao Date: Wed, 27 Aug 2025 03:42:21 -0700 Subject: [PATCH 1/3] arm64: kexec: Initialize kexec_buf struct in load_other_segments() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250827-kbuf_all-v1-1-1df9882bb01a@debian.org> References: <20250827-kbuf_all-v1-0-1df9882bb01a@debian.org> In-Reply-To: <20250827-kbuf_all-v1-0-1df9882bb01a@debian.org> To: Catalin Marinas , Will Deacon , Andrew Morton , Baoquan He , Coiby Xu , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, Breno Leitao , kernel-team@meta.com X-Mailer: b4 0.15-dev-dd21f X-Developer-Signature: v=1; a=openpgp-sha256; l=1445; i=leitao@debian.org; h=from:subject:message-id; bh=ZtBIdZnCHZQ12LtgRqgW3EI2B93ul2ZH8koIDN46ZQM=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBoruEXEz5/jNTGfDniMg/ZnAHUi/RMcmE+6R2RF hCO9Exf9kWJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCaK7hFwAKCRA1o5Of/Hh3 bfYLEACXBlAx2lnDz27xwPzW4zjmn2zElcwunujZrWs1v4Z9od/NKARCH6tvNwN20afKpZ4gIW3 ySL5qOqXCFGmp8SICmUgtEu27vihwQi5mE912eHGfaowVn6ehUpfu+PzplkMA1smdOaHKHkJElB 3rTziKVwLCCkKaGmYFL8sw+IHAxJySOHATGacXbu1CE60eGYgDk5d2A+aa8BgAml1iuEuCNP1vY Z/6VWe5imGd5Fv1lua0SdlFkQ9vWpntT1gXLqKVUospwxDgz/H7D3hcuiTZm5/ggqr9hvD8+4LB 7GkcMPs57t1luyhKi3limgE818GFrnBJT3CNwqxIFy3pEUO+hjdtbtGWwwj0oT5pxu2HUCBe+Jl pLWp7tIEqg5IMLdERqOPKfcyojA2U6l/qSLx6WX84Pk+AT6jI84silv6NNYzG5XAnJQgvRCvY0x SgPs4xSMmkgeztXFOcuGg1jUU0m9VJEELoU9TIUAef07ss+dwSXMRzmNbf/hoRp5LlOCwUgr1KM cyI4eLuldyoxD039e+c2KuUsITIwwDgJXtNeqo3vzpJKU127Iu+anDRICtyp4mRZVACnKmo+nFw D75fz0VAeYQ4+jVEtiG5Sn2CSzpUejInwoTSc5s38P1brzQ0Lz62qtytjJI+IdB1lmT8vQwx2hQ opV5AljUUPp0+hA== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D The kexec_buf structure was previously declared without initialization. commit bf454ec31add ("kexec_file: allow to place kexec_buf randomly") added a field that is always read but not consistently populated by all architectures. This un-initialized field will contain garbage. This is also triggering a UBSAN warning when the uninitialized data was accessed: ------------[ cut here ]------------ UBSAN: invalid-load in ./include/linux/kexec.h:210:10 load of value 252 is not a valid value for type '_Bool' Zero-initializing kexec_buf at declaration ensures all fields are cleanly set, preventing future instances of uninitialized memory being used. Signed-off-by: Breno Leitao Fixes: bf454ec31add ("kexec_file: allow to place kexec_buf randomly") Acked-by: Baoquan He --- arch/arm64/kernel/machine_kexec_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/machine_kexec_file.c b/arch/arm64/kernel/mac= hine_kexec_file.c index af1ca875c52ce..410060ebd86df 100644 --- a/arch/arm64/kernel/machine_kexec_file.c +++ b/arch/arm64/kernel/machine_kexec_file.c @@ -94,7 +94,7 @@ int load_other_segments(struct kimage *image, char *initrd, unsigned long initrd_len, char *cmdline) { - struct kexec_buf kbuf; + struct kexec_buf kbuf =3D {}; void *dtb =3D NULL; unsigned long initrd_load_addr =3D 0, dtb_len, orig_segments =3D image->nr_segments; --=20 2.47.3 From nobody Fri Oct 3 18:10:11 2025 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D976734A33B; Wed, 27 Aug 2025 10:42:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756291359; cv=none; b=JA80iP2Twg7krDxiVq1ywrtz1RYAML79FjLaqlJbNEYTGUlKIfSBUbKmTFrvnmmkzDiv4R4Fx1kYAGZsOvDukzOcSPJZYcaQZiqC7H/HM/usmR/lwqM6S+bnhskO2nS7O5MCtgYHtAdUrgppblpxPNoNJtnRcM9HmUZ83NIEAcE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756291359; c=relaxed/simple; bh=IQ8+TZrjuX8E+tz3NRY5WCQpnNUScYml/MBeP7a4Wmc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AmUbiyfPyadfupPNbbSwFQRT6oW893pEgeQ0+hrTUFjogBmoDvqqaQkH3JlR1NAQCIFf6ONFidmGtsLqECIWZ+ltcXCGGoLjYSRY00pNmnwLooMS5hjLzE5ZdGmvUJd7RXGfrXkuWeVr/srj/gJcpZGKS55TVTAGVhiYpzktjLE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-61caa266828so2063806a12.1; Wed, 27 Aug 2025 03:42:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756291356; x=1756896156; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vz82D6BOYc+hOsftCgRBc9qqs8ilQdlP6vhzKVwGwAc=; b=GVg3bp2KXGIle/sxL7aPvL/q1gMp+VP2Sd54UIn/pS6wGGiWQyentnwaGFHaJQp3PT jCyaoBDqQQ/APFe55qXQEQRN82S693ARmbq2v0cZtrmhCIDxH1G+6I14JM8fJHgBj7IG JruB8bQo0M7ZFcCmkd0zr7LWYdZrkMbUqt2V5CZ1UZlp0SYJ/Vxa8ZZFhtn0WTX2tIIv wXaoy1e8Q0LjRv1DgT6HuEjmsYAnU/0shNbKO8OB8mcQjGGZvlan2jr2AYBKCsdFUSB3 Bt5djqlQS2A0vWnKSIpSps8uN63t8QYdFFPa92xDmMDstjp++pTe7YY4MXDoNAAJ39jE d7NA== X-Forwarded-Encrypted: i=1; AJvYcCUmGwu3jEUjgBxPloODkNbhPlsSzGRl1e6yF8lCxK/hJaG2Vw5BHfkcWWdjdT6WAox5glJx627u9Xv9kYo=@vger.kernel.org, AJvYcCUt4boTqaPu/c1sYjxE+cpbrxLt5uSDL0tmP/CLqfrYCnZ7SD9o39RNmVwo7QYqGeX28yRdIi95gObc9w==@vger.kernel.org X-Gm-Message-State: AOJu0YyfRE0bUCE8u7hctmNhh5c+JqP35Dipz4uZWv9vsW82GsMMCwV5 f5XYT5M7bj5v601Z+eCL6dT/P3F++wkiyPIQwVU5wfT5H4vIJ4idxXQD X-Gm-Gg: ASbGncvYEM9TKLfzOOFolXZW43h3fNNhpFX8k1q48+gGeSXXWYuHM8ljo/ov4KrENMd I28zQbl4jXrfHytwaKdQmvQfT/tXZ7liaA5fWbLDmWo9lIUzoyFOQNYwl3fnqxZV4pNDz0Y4X+j 563b96ZgdFgcRipcaoKuPaNfsMlCEwvF8C8Wjh76E46iJsNw1YiIUnwtwU7Ktm9KAjsNzN7qtx3 Xz9B8MjCqcaMu7daFeqhGPY5B8l4SO1y4sz+WBplnNFkp7bXpqFM3KB8Wc1blfMSmP67bEp8on2 9C/n8b3Y6K4hPBfZCtLDkqub4UQ7Tf+iCRJuzlz0UfiS/8qH3HXJyGl6IwteonhGXt5LbdTpp1V UUgp7cr+BnVYceOCs0QDn7JQ= X-Google-Smtp-Source: AGHT+IEYI41/g63i4kVWPeSOO7OZr1ZHqICmy0ei+m3f2f0i5tZ7DszcfvtA7dEeGXLX8TV7bTpnew== X-Received: by 2002:a05:6402:5111:b0:61c:9970:a860 with SMTP id 4fb4d7f45d1cf-61c9970aca7mr3662005a12.21.1756291356044; Wed, 27 Aug 2025 03:42:36 -0700 (PDT) Received: from localhost ([2a03:2880:30ff:8::]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-61c3119f79asm8721745a12.5.2025.08.27.03.42.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Aug 2025 03:42:35 -0700 (PDT) From: Breno Leitao Date: Wed, 27 Aug 2025 03:42:22 -0700 Subject: [PATCH 2/3] riscv: kexec: Initialize kexec_buf struct Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250827-kbuf_all-v1-2-1df9882bb01a@debian.org> References: <20250827-kbuf_all-v1-0-1df9882bb01a@debian.org> In-Reply-To: <20250827-kbuf_all-v1-0-1df9882bb01a@debian.org> To: Catalin Marinas , Will Deacon , Andrew Morton , Baoquan He , Coiby Xu , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, Breno Leitao , kernel-team@meta.com X-Mailer: b4 0.15-dev-dd21f X-Developer-Signature: v=1; a=openpgp-sha256; l=2695; i=leitao@debian.org; h=from:subject:message-id; bh=IQ8+TZrjuX8E+tz3NRY5WCQpnNUScYml/MBeP7a4Wmc=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBoruEX/cLWQmBEx19TP+43KNp8/V/9NjghgKQHY biMCHC9P2KJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCaK7hFwAKCRA1o5Of/Hh3 bZGzEACTv4Ns6J18i5vlqvkPmMxPbS8OBx9r2ReDTMJxi756yor2IOcJDgdV/O8CKL55E9CRL0r nv/XIqSPzCN6gLyLBoSlVRa3b8tTWp+amtioyjKmntVPKgpvv7gXyFFkQivC5YMH7cuC9iA5/iD fXa6VZP+rjMAIHij//GwyA3rb4qVjkioYseCO6N80FvE5HcA3ySipv02Mg0/XvQshQ6Jrhyf2+3 EhFY0r0GAOFiZb4PidqHVyMFum1AhhFW1b0Ly97AofCw5ToGm7KT81vsRvFEkzKynizg8UcagMZ G+7iI0xmcgtEYDi6EEc87GX96VC16Q0b3hHY8B4Q0ccaU8SPq9cNYDtsjCmk/F2pK4mOsNqV5ML ftkUDrSYiS3PbB1iHE/s3yYfpEm3WcpOx53IQLXjBCesYQbvLwBn/31zd0JzrKpJPfgjJxqlDlG DkU4We+SpE1VBkKIFA4ZaP+FsQLNUBAJQg29JTcxUIb+TRyLdDhcXGf/Ls1Iugmu0fqvYZQJEdZ frSwQybk7ZO5+ZUGrIh78SpVDG0rTGydc9HSFEKrFS3ewQL8h+T5R6DJY2MP44Ji7iWbgyUTd5f c3n2NrWCCumDrX+3wBnhGTzxP+lM9I1ZjmJF4PF5HD5KX1gWD02qdTpSk2AOf8miz9alFrvMbPL ShqGSeZDkQoYvcQ== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D The kexec_buf structure was previously declared without initialization. commit bf454ec31add ("kexec_file: allow to place kexec_buf randomly") added a field that is always read but not consistently populated by all architectures. This un-initialized field will contain garbage. This is also triggering a UBSAN warning when the uninitialized data was accessed: ------------[ cut here ]------------ UBSAN: invalid-load in ./include/linux/kexec.h:210:10 load of value 252 is not a valid value for type '_Bool' Zero-initializing kexec_buf at declaration ensures all fields are cleanly set, preventing future instances of uninitialized memory being used. Fixes: bf454ec31add ("kexec_file: allow to place kexec_buf randomly") Signed-off-by: Breno Leitao Acked-by: Baoquan He --- arch/riscv/kernel/kexec_elf.c | 4 ++-- arch/riscv/kernel/kexec_image.c | 2 +- arch/riscv/kernel/machine_kexec_file.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/riscv/kernel/kexec_elf.c b/arch/riscv/kernel/kexec_elf.c index 56444c7bd34eb..531d348db84d7 100644 --- a/arch/riscv/kernel/kexec_elf.c +++ b/arch/riscv/kernel/kexec_elf.c @@ -28,7 +28,7 @@ static int riscv_kexec_elf_load(struct kimage *image, str= uct elfhdr *ehdr, int i; int ret =3D 0; size_t size; - struct kexec_buf kbuf; + struct kexec_buf kbuf =3D {}; const struct elf_phdr *phdr; =20 kbuf.image =3D image; @@ -66,7 +66,7 @@ static int elf_find_pbase(struct kimage *image, unsigned = long kernel_len, { int i; int ret; - struct kexec_buf kbuf; + struct kexec_buf kbuf =3D {}; const struct elf_phdr *phdr; unsigned long lowest_paddr =3D ULONG_MAX; unsigned long lowest_vaddr =3D ULONG_MAX; diff --git a/arch/riscv/kernel/kexec_image.c b/arch/riscv/kernel/kexec_imag= e.c index 26a81774a78a3..8f2eb900910b1 100644 --- a/arch/riscv/kernel/kexec_image.c +++ b/arch/riscv/kernel/kexec_image.c @@ -41,7 +41,7 @@ static void *image_load(struct kimage *image, struct riscv_image_header *h; u64 flags; bool be_image, be_kernel; - struct kexec_buf kbuf; + struct kexec_buf kbuf =3D {}; int ret; =20 /* Check Image header */ diff --git a/arch/riscv/kernel/machine_kexec_file.c b/arch/riscv/kernel/mac= hine_kexec_file.c index e36104af2e247..b9eb41b0a9751 100644 --- a/arch/riscv/kernel/machine_kexec_file.c +++ b/arch/riscv/kernel/machine_kexec_file.c @@ -261,7 +261,7 @@ int load_extra_segments(struct kimage *image, unsigned = long kernel_start, int ret; void *fdt; unsigned long initrd_pbase =3D 0UL; - struct kexec_buf kbuf; + struct kexec_buf kbuf =3D {}; char *modified_cmdline =3D NULL; =20 kbuf.image =3D image; --=20 2.47.3 From nobody Fri Oct 3 18:10:11 2025 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A268F34DCE8; Wed, 27 Aug 2025 10:42:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756291361; cv=none; b=kMErJ7zV78gzipb/DELPTeZno+ZHyr4JSFU86rtas/H+DBzpf/7a3cN4bhS9X2cEbcj9HWkWq4VWWetYl06DccQyj+knCrGrgjiJzHdUBdT6tUefy8MXHCAHVi1iHin/aCh8PwwSKcfM2AyjEFgPzQGhmyIsPSELaznfoX6VH6Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756291361; c=relaxed/simple; bh=GxK8Y/l6QMpHsSC5/lKRcWUThT3tPFQypyafdn6KEZQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MEGfm5tPJNSsMIwc6pIf1rLWEG44YB3h3GZI323xpwUyqVFr+nTLCkfzOMvLQeJEeN9SQnHXsOfHK7M2XInWbPWIVBCmqcrIxa4BZ4g0nPdnEv6n+Ss0+/9zBMqwsdMIIgpgdSZQLdZMH4ymjmJSo0wjwTNLZwjZvpqI+lCDtuw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-afcb7a16441so1039589266b.2; Wed, 27 Aug 2025 03:42:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756291358; x=1756896158; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6X/wDuwMGXHolRz+V9ennd5Bffj6ymv9Jrzy1lUthU8=; b=TnX1Lni4pC80AArMqk35JkaJ8Q7l1UUImHFGQM3N7n3EP3tP+Kl/1vlVpBWxcH26zt DNYkEOTYPiJccIOclA8VGV4a/AwkGJYNS63oKPr8+4QYXrP3dZgUSXZThNqjcYOuNkBQ yJ7vfXPDXHU4RpLlX3a6NH6bXS8PJ6FUi+fDptWI8I0h6Bv2gfw8vkd90nEe10eUohzR A/U7tN5S/rENMckucQXgMmAo1Hd8g7taRJVojvq55kKks+LuszcFPDK+ap2PuCeGopnX wat749RuA7GqYm7cxUVEngXzkp4mLZeruzJCoe2+8Bi3CEUUl5Cwq0a8RSmNA6dOCTTY 0oPA== X-Forwarded-Encrypted: i=1; AJvYcCU+HKxoZ7NYoSpPSw6vh2TR5jR75zihRPg7FWOBlGUZf5IXg9MS4hApHsRD7w+uwUex1TRCw9tC0U+26DM=@vger.kernel.org, AJvYcCUfvAnKTbS8lW/zPwBUCRZ7EUMWijk3/q6x4Ae/GZFkYPTadKRaesSOieQp5FZdOydCWsQoNZ2Ax2hTTA==@vger.kernel.org X-Gm-Message-State: AOJu0YxJa+Qb2JY9hBflJjaoK9uhxBjvnb8WWbIhSHyEwbSVmoFM45Lb QqEmMn0pIVWyssVF37e3GjPA1d5wDwi1t/gVkYBT++qoXaEUZVBJ6tgM X-Gm-Gg: ASbGncvRk0Q8RRunv5FmplxdqQcaRDk4124hD+6DJ2RS5NKzKYVs3J1PejCnzerx24a h4nbpAzrVn3H67Fzj80eDMObbnR1BAPV9bUzDkMKyiy87KpoVZR0NU3h2UF7xc3euSflVCNlsL5 +5VUct9PpPZ84+KRizjj3IPjqULoVzZHEJdBRn7/bFLc26G1UqC/GrF50beOHhvYsWuuEer4/J/ 1xwFlz3ZMp0NOThccCACp5dYsMv9dSz2CR0cnCqo/lVxugN7jqS18FMXszk/15bfQOeeC5ZAfkY 6NHM3pnjqMQ0xZ8ZC4sWqMWpNjLnmRqn6L/RB3mfFLQtLfLBO7z5qGmEBYF4ZhqLZoWcREzrey9 Vedfu+/xpd7f5Mfa1sY52L9o= X-Google-Smtp-Source: AGHT+IEt7HUfyMYn7wwTTBfAgAlW9baMBm2buHWzgRksugd2fL7uEBallbmWq6FW+jaBEaqaNP9fhw== X-Received: by 2002:a17:907:934c:b0:add:fe17:e970 with SMTP id a640c23a62f3a-afe28fbaffcmr1737084966b.14.1756291357601; Wed, 27 Aug 2025 03:42:37 -0700 (PDT) Received: from localhost ([2a03:2880:30ff:7::]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afea4b5eafcsm365786666b.9.2025.08.27.03.42.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Aug 2025 03:42:37 -0700 (PDT) From: Breno Leitao Date: Wed, 27 Aug 2025 03:42:23 -0700 Subject: [PATCH 3/3] s390: kexec: Initialize kexec_buf struct Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250827-kbuf_all-v1-3-1df9882bb01a@debian.org> References: <20250827-kbuf_all-v1-0-1df9882bb01a@debian.org> In-Reply-To: <20250827-kbuf_all-v1-0-1df9882bb01a@debian.org> To: Catalin Marinas , Will Deacon , Andrew Morton , Baoquan He , Coiby Xu , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, Breno Leitao , kernel-team@meta.com X-Mailer: b4 0.15-dev-dd21f X-Developer-Signature: v=1; a=openpgp-sha256; l=2880; i=leitao@debian.org; h=from:subject:message-id; bh=GxK8Y/l6QMpHsSC5/lKRcWUThT3tPFQypyafdn6KEZQ=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBoruEXRx0x/sg5L8lF842+++ptuDPjC3oj8dadJ uKgX0JY7+mJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCaK7hFwAKCRA1o5Of/Hh3 bf5WEACRmffaU59y0c07C3h33TU9GzbJO9HOZxapXThAtEqn33XPo4si1FFGv6sTYNargSr6Lzs MJosdJiWDHRZaXSxFawvJvBq5XBTfFYs+4tW2EiAU19diAu5I3J5dfl8lqww3GI6zzZIrB5wA4B r71V3ZUJK3cZ8l4gTpGp2zWNvG7Q+121ozv4yRD5kfazvucI93HIth7LZcXGKfNkpz+1aW8Y+Bo CECDcsH4Z4ZHW/73m7w0ThVouXFEkSIxWhyzVtYPFMWF/MmktJ0t7niZfKNMTRyu++v37nlGcmY uWpa1o6LmJUU93AJFkXojU93ztyTZZ2RC7FupVqYsQy5ZqvoIJ37Zd7oPpAULS1x5FX2xzbe7s4 PYhfG2kBSlHriVV/gT/wRX6SMyVLWK0NQOszrjhZoQUHCkTPzfBdtRkf06wYGOoZHY8VV70IOSX fxXgT6OPXyi7xResv3bkLI4vLyEvNWjbQXsAOX3L/ZLQwvYKEpMDSd2eaoO2TSKIBnuQnArR846 uDq8NSU+HoTOGc4chbxXxwQZH2qpGuNnndVelTsFCmtlb9I7yVtrk/qCAN/9fdHnGjVmU9f6grm TWCAnmqakjCXdNYLT+OhBxkDcorfJgKFH/44W4AXsfhUTjdTaRNM+uGkGeRohC2Vx/EUGQTChd+ UYUwpwtf+a6rOTg== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D The kexec_buf structure was previously declared without initialization. commit bf454ec31add ("kexec_file: allow to place kexec_buf randomly") added a field that is always read but not consistently populated by all architectures. This un-initialized field will contain garbage. This is also triggering a UBSAN warning when the uninitialized data was accessed: ------------[ cut here ]------------ UBSAN: invalid-load in ./include/linux/kexec.h:210:10 load of value 252 is not a valid value for type '_Bool' Zero-initializing kexec_buf at declaration ensures all fields are cleanly set, preventing future instances of uninitialized memory being used. Fixes: bf454ec31add ("kexec_file: allow to place kexec_buf randomly") Signed-off-by: Breno Leitao Acked-by: Baoquan He --- arch/s390/kernel/kexec_elf.c | 2 +- arch/s390/kernel/kexec_image.c | 2 +- arch/s390/kernel/machine_kexec_file.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/s390/kernel/kexec_elf.c b/arch/s390/kernel/kexec_elf.c index 4d364de437992..143e34a4eca57 100644 --- a/arch/s390/kernel/kexec_elf.c +++ b/arch/s390/kernel/kexec_elf.c @@ -16,7 +16,7 @@ static int kexec_file_add_kernel_elf(struct kimage *image, struct s390_load_data *data) { - struct kexec_buf buf; + struct kexec_buf buf =3D {}; const Elf_Ehdr *ehdr; const Elf_Phdr *phdr; Elf_Addr entry; diff --git a/arch/s390/kernel/kexec_image.c b/arch/s390/kernel/kexec_image.c index a32ce8bea745c..9a439175723ca 100644 --- a/arch/s390/kernel/kexec_image.c +++ b/arch/s390/kernel/kexec_image.c @@ -16,7 +16,7 @@ static int kexec_file_add_kernel_image(struct kimage *image, struct s390_load_data *data) { - struct kexec_buf buf; + struct kexec_buf buf =3D {}; =20 buf.image =3D image; =20 diff --git a/arch/s390/kernel/machine_kexec_file.c b/arch/s390/kernel/machi= ne_kexec_file.c index c2bac14dd668a..a36d7311c6683 100644 --- a/arch/s390/kernel/machine_kexec_file.c +++ b/arch/s390/kernel/machine_kexec_file.c @@ -129,7 +129,7 @@ static int kexec_file_update_purgatory(struct kimage *i= mage, static int kexec_file_add_purgatory(struct kimage *image, struct s390_load_data *data) { - struct kexec_buf buf; + struct kexec_buf buf =3D {}; int ret; =20 buf.image =3D image; @@ -152,7 +152,7 @@ static int kexec_file_add_purgatory(struct kimage *imag= e, static int kexec_file_add_initrd(struct kimage *image, struct s390_load_data *data) { - struct kexec_buf buf; + struct kexec_buf buf =3D {}; int ret; =20 buf.image =3D image; @@ -184,7 +184,7 @@ static int kexec_file_add_ipl_report(struct kimage *ima= ge, { __u32 *lc_ipl_parmblock_ptr; unsigned int len, ncerts; - struct kexec_buf buf; + struct kexec_buf buf =3D {}; unsigned long addr; void *ptr, *end; int ret; --=20 2.47.3