From nobody Fri Oct 3 18:02:34 2025 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2082.outbound.protection.outlook.com [40.107.100.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B696E2FF67B; Tue, 26 Aug 2025 23:12:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.100.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756249955; cv=fail; b=edBCPEvnDyNZtU3rS+fK+3F8gNH6cSgyj49jdz1EalR5FlLyOuXPxWQHfTz05t4KepopNoA7J5EsbIhac7mpfzX3Q0jwQJWR+h012463zM8B8qfuuPj7GUuX7cmDoIy1QbPge6uG7VJ3Ul/hSwjWrujttdChb30zm5ta5f/kLYE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756249955; c=relaxed/simple; bh=Q+NSQw48o4qk1v1XN4EONwTkSodhNTnfiS19CFfqdqg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=uMylnhBdNHs5G95qZcwjRWmtZCjkoL8bIZZFyE2yh8bBmeX8ypkrkMwyUPXVx9ERL1hJXFW8yGflkTzEIJT0FEAceeV+qpKLX7lVQ1wzVlEysVRftDepuXvxpxFrBIcqftTGef7NTITPwrA/SFIeY+xtm/0/gOR1+zA0RJVpic8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=PrJsxDqK; arc=fail smtp.client-ip=40.107.100.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="PrJsxDqK" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fXP3VABydRDL6obVKdBJvMPITjMYZdOlbf/5W28yO3HcEnheVZ7rQI0JWZWoh7LiO0HoWRCZdgkSArsbNi43x8S9Ks4R8qFShyvPmjCltMIO97rL4SAGD2w3b696tYl5Q4PQqRdvEQl7LI+wonMvxdDRft0hfo9TJzprHUFHvH9jN4xRdxGPlsQzrjuk6VnKNCVefdyb86K0yfYoTH8JKqgzeACRV4hGTLqmfC7zTdF3PCJ47U6zdJsNdZXjfvqc+XQxQf3Vu8LCyflDPSqWbVia8FLf5YxSOsxeYfIfDyBOMCUVXxvineXjBMVci9Cj6S59i4w/HD8JdGUSgvnmUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HgjUKMxmXFpMqaGScf71Evk1ExQBQ7XxgjkBuqzd3yY=; b=kx3n2dtgk8GkIi0JzWyAmOiT3QgK0NAu8hMcZ1a+CZ89rAtNVbDs09Iwv2rU1JSI2GhTARtEPnCKFky7MBizCt+2Qufb8nbvbb90BuL7CwNijgLkLg5o9Vet0oKvBtB9doru2/XSPz4bEvrBof7ulh/ZYAzONCANdrRi+fBJ4URb3yMkQAm7aoi7gPMjrs0s54J6W1oB1EOYMCsOCC7fsws672iDoD11aq+39/n+ii5nrlQOs7oJlth5RLwqBxJ11TySTsUt4ZzuU/ken1DDFZyh6K+ajrJcizKelI2hFrS9gBpQeExHwl5XMqTArZ9clQ4y6TqIjb51lNZfxiskRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HgjUKMxmXFpMqaGScf71Evk1ExQBQ7XxgjkBuqzd3yY=; b=PrJsxDqKYsYn7z0N5Js52HlT8ty+rUfzWaTg0Q/ooktnVxto3tJ9thPB6tsP4XKqkHt+zPxWOGzdwn4pFm/4wuIZeMrec/CXxBUcwQpFHzfbTgZmglTHVsTKNLTmYRHdw3eQa2MI254MgEjsQPtYVoVYPLqeAEgbcUGUQDYbtDlnT3nWn9aQ8QMiJ+hue2dT6RgQfiaUZ5Fw7E8riouGNDXnHzaMBkxBSUZL/HVd20Y4hVuCCeodXxVXYduV8n7uLSuOcXjjNpepw6vDO0nqFV3+fso+bVwc7APTeOOBjTig4uZzTvY24TKszUcolj/ZF7NeSYsDwiwuk2mvsx1wvA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) by PH7PR12MB7913.namprd12.prod.outlook.com (2603:10b6:510:27b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.13; Tue, 26 Aug 2025 23:12:29 +0000 Received: from LV2PR12MB5968.namprd12.prod.outlook.com ([fe80::e6dd:1206:6677:f9c4]) by LV2PR12MB5968.namprd12.prod.outlook.com ([fe80::e6dd:1206:6677:f9c4%6]) with mapi id 15.20.9073.010; Tue, 26 Aug 2025 23:12:29 +0000 From: John Hubbard To: Danilo Krummrich Cc: Alexandre Courbot , Joel Fernandes , Timur Tabi , Alistair Popple , David Airlie , Simona Vetter , Bjorn Helgaas , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , nouveau@lists.freedesktop.org, linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, LKML , John Hubbard , Elle Rhumsaa Subject: [PATCH v7 1/6] rust: pci: provide access to PCI Class and Class-related items Date: Tue, 26 Aug 2025 16:12:19 -0700 Message-ID: <20250826231224.1241349-2-jhubbard@nvidia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826231224.1241349-1-jhubbard@nvidia.com> References: <20250826231224.1241349-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BYAPR07CA0099.namprd07.prod.outlook.com (2603:10b6:a03:12b::40) To LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5968:EE_|PH7PR12MB7913:EE_ X-MS-Office365-Filtering-Correlation-Id: bbf243c2-d6da-4688-d07a-08dde4f6073f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/UPpt9QF24KU1s7UjSqJG9zAV1xa+sZaCahzzZw69JTsVniZqeCgO2WoEkRv?= =?us-ascii?Q?9BAPZ3DcgQet1Q5IgM/87OeGfocMmc29qO1K4MA9V0qNlZ8B++buR5CyNNQ5?= =?us-ascii?Q?ZSw8lEVvyqU0fjfodJnqsedYrk0U3MShs4pY3cUSqpXNAhhXDl+wvaqf/fpw?= =?us-ascii?Q?xq1xKDykXLSV5cUXdVbmOGzNLj3m7E3NOS9VQLt2Fu1IMZL4C4zf6w3yteSx?= =?us-ascii?Q?qafNGR5TiQPwmugwtURkX34ENvtg5RWnx59M/4S+uMTGgrbZ8ndb5RBdYQDG?= =?us-ascii?Q?Hwcjcp5MpjGbptUI2y3sb8PCp2LEzKdhQA9Izn+X/DIDLqpyVdfxkt7jy/0U?= =?us-ascii?Q?a6l8FWo/HG+p9i9GI8cryaODU14S4z3DGaMgY4cEROcX+/atkQs4PUPr3H2X?= =?us-ascii?Q?aNJcnBBBMlp1XYzGav888gyCY/tvCaEItkJZ6SZr3arbkJazco9ZqNhFgm4X?= =?us-ascii?Q?Y6C/qqHmWqoDXG7mb8qKwOSCnkUbj0hd9hVkT8r/bnSpWEypCsjxmrLD27RU?= =?us-ascii?Q?LK5vGmkMUsXnd3PkJ3LUZUYPsiaMSjJUY0IYJn7S7vX/xyOvT8K/4qAR5nCm?= =?us-ascii?Q?7E/WrYO1OnyD4inMXDwBWKoZUuUayXyZmFALz64mQsf/JC5WaeusbdeQXAiM?= =?us-ascii?Q?0yEp3jLovujsJMTGzk5M02X1ALLmzVUr0OsgjSZ7sj2yoqhAbSmJZ9jQBXrf?= =?us-ascii?Q?RDySRH8hwTRf31EPCwq2a0A1tHmplic9jaxsgJqxcg+uDqNLBYqRthDFcRvu?= =?us-ascii?Q?fFw9vbAJG+uXGxmrSFr6F4YQjtPKHF4RgWMiRNIWuuIq83gbD/CU3Y/EN/DQ?= =?us-ascii?Q?D2U8gJV5kvTdyFl+H/14vEYi1elFnnzCqKNHyvq7GPr9jnjPNIl0ynsSeeMv?= =?us-ascii?Q?Y7IBmxnJ9ZbwwIbZ03vA2jl4FtwJb9VD1XUP2szW8Jvn9Up6VKzcpYOygoCs?= =?us-ascii?Q?X+lJ6TxX5NgsdxS9UG/HeHFM1mmvaapFWCXhGXL5bPOSZsz8j/eArUdUhcqq?= =?us-ascii?Q?ZSPoFEPMuE2AHNqkw3iTXTmpyrHo3svFvv2mENprZBFsMT1Z/V3sAxiuOjg5?= =?us-ascii?Q?DH4Ug8QTqjOoVZAHBuXWTW0lovQOW4GeQuMKU0xyKS9M6AxCW3/QAWXf3bXg?= =?us-ascii?Q?4eH2qEuBCnyKjFGoEz00JNgk5UOmGLRXb8WSSI0KRVEn+PpaNgx1JOYr8xzR?= =?us-ascii?Q?MD3SLZSKsOqgBP/35tpJKxEk+u8O5hf22PYPyjwPKoPYTHuGjIEuhsX0z6ra?= =?us-ascii?Q?gatejs2SxpjZBuRSMMkfJFVM7w4CI4qIS3YB7EWQ3lG7JhHx+/+ZH5OERIDn?= =?us-ascii?Q?4jtSuOffGhyvOan1PRFAMtum3zz0zme9M7Xzg4Rd3mGu9ddMHO9VdIbDFCzy?= =?us-ascii?Q?0PbgUmVuVAO+4OmFIwkQavjdpyMOhvPx+8j5VBKTQwsin2p/AYi+mnEq0AFS?= =?us-ascii?Q?7U1jt8OUbdk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5968.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m/JNz4HT++7gGcDvFOjRTF2875wZAEnsAkttpfIdcNrK6XzyCiWlgbaMkosl?= =?us-ascii?Q?8gJn0iIvHiAcvxIldL3jxiozAulTrUgp5HTP2SWPzr4ncL/QSTp1e73QcSEu?= =?us-ascii?Q?nwbnqUxWgdC1VBHHmQBQx5gVSabe5shrRvvf3DJDt/c2lerwI5G6vTXO2fyC?= =?us-ascii?Q?uOy7Wcf0MQdUQjTAWyGEP95KePHOQTqCXXtXo+dc7vKjnxbMuYp4145SLjIR?= =?us-ascii?Q?NR6roQipngNVhaURWj0B/G24cV24b9+uIQcer9wSA+iUy0AoR+TEbvU/1t0O?= =?us-ascii?Q?Tl2cMmYLDz0Ply4hVcHTb1fDSksLoa5lQ9ljx4U3SlThmQhGn1z89rWjkMdk?= =?us-ascii?Q?EGIZdJ8pS/P1nmZ9+AsX4M1mF3xMDo0kWskkekoy2XF1Jjo43RMpoFAXwl6U?= =?us-ascii?Q?mxXOPM81M0FROuHST1UtBav51rs2POsBvwryRBd8GqsXN3omPVb72FScrpXE?= =?us-ascii?Q?dysmg+qWtN5IgJlkCq4/150dNywhUj61duFQJYg1KWRS01/3BDX1bcEARprj?= =?us-ascii?Q?16e34X5cLMQE00O7507/oggUN+N6qC/G7cPXmqnqzEcL146Y5KeMa7VhinEr?= =?us-ascii?Q?vg2zgWYkp9G/4GnZrY33QUwv85n4pcxLDpMsM3mvwvt8gKgSJDYn2H2Br7sp?= =?us-ascii?Q?p2ibF1cewNX2v91MT0+nAnB5bfSVGFpYXTZaBk5D1ZgvTz09nq/WeZ8ZqecL?= =?us-ascii?Q?y6vnqUX+3rtUcfwfb+6VzLK5zk9zhim06MeITjn/LqY4HphfztM4B7KFlnAR?= =?us-ascii?Q?qMNwlNlvVRE7KiZ413osm6JXew03DGEPxj2lcTUwvGPLXS6FzzuwibWAAWZj?= =?us-ascii?Q?kJK0BLzCsu+umTGvvvCtjt9ycsb6GFImcu/lCQL6OS1c4hKVawZ9AJGulq6L?= =?us-ascii?Q?3wt8pKN4B3n1/Hv23MSn5uQR4tuGyH9kuIfHC+E7aGrS71p8Qz9JWtao12zY?= =?us-ascii?Q?dci4+RZTajm0ZYPNgEG57MEbrOKM5nS15pL73zTH65zoSPI3oyUp/BstJoHV?= =?us-ascii?Q?EwvIhEgQhC4kpf6ITFSSgWb57bH3o0azYbJfaWHHfwB+G5inlNok+1ZYJWO2?= =?us-ascii?Q?BTf0nvwFyq9wIcVqqvIznTFxDUWHtq6cZPaaX/BNSrsr2sPJTiLvhzxvTmEC?= =?us-ascii?Q?AqzTMyuNj1/Bis1bw7B/15aRd5a7MKZMo2tGgsi5z5rWuFwaHv5aF75AapDF?= =?us-ascii?Q?7DKlWaw4qNxQ8iIcJ1tBlZ8sqJF1DcNR1PKHlEkL03mEVKXPza4nARDBRkm4?= =?us-ascii?Q?8P3YXPrQDd9W5WJudEeYOAnOUbFim3xwNJNGzHQ3cNjpsW2V36xAHCEi3tji?= =?us-ascii?Q?9ir7654IqvQz8Paznq9M1sfk9gRyF+qHMP8aQ3/wL/P4AiW4R+o7WjEnkUy8?= =?us-ascii?Q?qb9bSJYu+oEO/B8jTcmev3YvWHsiTU1Zjr2Ip/i9mA4kaizUp+V/vWayPBBw?= =?us-ascii?Q?pRzPgUw0BB+pwCh81N/Vh96x0EVYcttSbLVKsRJ3v1XZv4VNT2HEtONC0EkI?= =?us-ascii?Q?lEkD2Ngfjv/Nxvlw2w2gB4RjNZkbWXEWbN726bzS8kFpF13ru1PDdnSBlKB2?= =?us-ascii?Q?SieR6GsD3cpuK0QN6v9mbhj0vK6XB+T80WbZCMnP?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbf243c2-d6da-4688-d07a-08dde4f6073f X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5968.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2025 23:12:29.2496 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q3tAPqwijSx7uOb4vM1laYWmwJ6Ky25Ie7nZ4MbnVqaEGXevXdkgL44ACX3W+LQlAq6hZdEwnU8j3zvEWWimzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7913 Content-Type: text/plain; charset="utf-8" Allow callers to write Class::STORAGE_SCSI instead of bindings::PCI_CLASS_STORAGE_SCSI, for example. New APIs: Class::STORAGE_SCSI, Class::NETWORK_ETHERNET, etc. Class::from_raw() -- Only callable from pci module. Class::as_raw() ClassMask: Full, ClassSubclass Device::pci_class() Cc: Danilo Krummrich Cc: Alexandre Courbot Cc: Elle Rhumsaa Signed-off-by: John Hubbard Reviewed-by: Alexandre Courbot --- MAINTAINERS | 1 + rust/kernel/pci.rs | 11 ++ rust/kernel/pci/id.rs | 232 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 244 insertions(+) create mode 100644 rust/kernel/pci/id.rs diff --git a/MAINTAINERS b/MAINTAINERS index fe168477caa4..28e200fa9423 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19532,6 +19532,7 @@ C: irc://irc.oftc.net/linux-pci T: git git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git F: rust/helpers/pci.c F: rust/kernel/pci.rs +F: rust/kernel/pci/ F: samples/rust/rust_driver_pci.rs =20 PCIE BANDWIDTH CONTROLLER diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs index 887ee611b553..212c4a6834fb 100644 --- a/rust/kernel/pci.rs +++ b/rust/kernel/pci.rs @@ -23,6 +23,10 @@ }; use kernel::prelude::*; =20 +mod id; + +pub use self::id::{Class, ClassMask}; + /// An adapter for the registration of PCI drivers. pub struct Adapter(T); =20 @@ -410,6 +414,13 @@ pub fn resource_len(&self, bar: u32) -> Result { // - by its type invariant `self.as_raw` is always a valid pointer= to a `struct pci_dev`. Ok(unsafe { bindings::pci_resource_len(self.as_raw(), bar.try_into= ()?) }) } + + /// Returns the PCI class as a `Class` struct. + #[inline] + pub fn pci_class(&self) -> Class { + // SAFETY: `self.as_raw` is a valid pointer to a `struct pci_dev`. + Class::from_raw(unsafe { (*self.as_raw()).class }) + } } =20 impl Device { diff --git a/rust/kernel/pci/id.rs b/rust/kernel/pci/id.rs new file mode 100644 index 000000000000..55d9cdcc6658 --- /dev/null +++ b/rust/kernel/pci/id.rs @@ -0,0 +1,232 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! PCI device identifiers and related types. +//! +//! This module contains PCI class codes and supporting types. + +use crate::{bindings, error::code::EINVAL, error::Error, prelude::*}; +use core::fmt; + +/// PCI device class codes. Each entry contains the full 24-bit PCI +/// class code (base class in bits 23-16, subclass in bits 15-8, +/// programming interface in bits 7-0). +/// +/// # Examples +/// +/// ``` +/// # use kernel::{device::Core, pci::{self, Class}, prelude::*}; +/// fn probe_device(pdev: &pci::Device) -> Result<()> { +/// // Get the PCI class for this device +/// let pci_class =3D pdev.pci_class(); +/// dev_info!( +/// pdev.as_ref(), +/// "Detected PCI class: {}\n", +/// pci_class +/// ); +/// Ok(()) +/// } +/// ``` +#[derive(Debug, Clone, Copy, PartialEq, Eq)] +#[repr(transparent)] +pub struct Class(u32); + +/// PCI class mask constants for matching class codes. +#[repr(u32)] +#[derive(Debug, Clone, Copy, PartialEq, Eq)] +pub enum ClassMask { + /// Match the full 24-bit class code. + Full =3D 0xffffff, + /// Match the upper 16 bits of the class code (base class and subclass= only) + ClassSubclass =3D 0xffff00, +} + +macro_rules! define_all_pci_classes { + ( + $($variant:ident =3D $binding:expr,)+ + ) =3D> { + + impl Class { + $( + #[allow(missing_docs)] + pub const $variant: Self =3D Self(Self::to_24bit_class($bi= nding)); + )+ + } + }; +} + +/// Once constructed, a `Class` contains a valid PCI Class code. +impl Class { + /// Create a Class from a raw 24-bit class code. + /// Only accessible from the parent pci module. + #[inline] + pub(super) fn from_raw(class_code: u32) -> Self { + Self(class_code) + } + + /// Get the raw 24-bit class code value. + #[inline] + pub const fn as_raw(self) -> u32 { + self.0 + } + + // Converts a PCI class constant to 24-bit format. + // + // Many device drivers use only the upper 16 bits (base class and subc= lass), but some + // use the full 24 bits. In order to support both cases, store the cla= ss code as a 24-bit + // value, where 16-bit values are shifted up 8 bits. + const fn to_24bit_class(val: u32) -> u32 { + if val > 0xFFFF { + val + } else { + val << 8 + } + } +} + +impl fmt::Display for Class { + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { + write!(f, "0x{:06x}", self.0) + } +} + +impl ClassMask { + /// Get the raw mask value. + #[inline] + pub const fn as_raw(self) -> u32 { + self as u32 + } +} + +impl TryFrom for ClassMask { + type Error =3D Error; + + fn try_from(value: u32) -> Result { + match value { + 0xffffff =3D> Ok(ClassMask::Full), + 0xffff00 =3D> Ok(ClassMask::ClassSubclass), + _ =3D> Err(EINVAL), + } + } +} + +define_all_pci_classes! { + NOT_DEFINED =3D bindings::PCI_CLASS_NOT_DEFINED, = // 0x000000 + NOT_DEFINED_VGA =3D bindings::PCI_CLASS_NOT_DEFINED_VGA, = // 0x000100 + + STORAGE_SCSI =3D bindings::PCI_CLASS_STORAGE_SCSI, = // 0x010000 + STORAGE_IDE =3D bindings::PCI_CLASS_STORAGE_IDE, = // 0x010100 + STORAGE_FLOPPY =3D bindings::PCI_CLASS_STORAGE_FLOPPY, = // 0x010200 + STORAGE_IPI =3D bindings::PCI_CLASS_STORAGE_IPI, = // 0x010300 + STORAGE_RAID =3D bindings::PCI_CLASS_STORAGE_RAID, = // 0x010400 + STORAGE_SATA =3D bindings::PCI_CLASS_STORAGE_SATA, = // 0x010600 + STORAGE_SATA_AHCI =3D bindings::PCI_CLASS_STORAGE_SATA_AHCI, = // 0x010601 + STORAGE_SAS =3D bindings::PCI_CLASS_STORAGE_SAS, = // 0x010700 + STORAGE_EXPRESS =3D bindings::PCI_CLASS_STORAGE_EXPRESS, = // 0x010802 + STORAGE_OTHER =3D bindings::PCI_CLASS_STORAGE_OTHER, = // 0x018000 + + NETWORK_ETHERNET =3D bindings::PCI_CLASS_NETWORK_ETHERNET, = // 0x020000 + NETWORK_TOKEN_RING =3D bindings::PCI_CLASS_NETWORK_TOKEN_RING,= // 0x020100 + NETWORK_FDDI =3D bindings::PCI_CLASS_NETWORK_FDDI, = // 0x020200 + NETWORK_ATM =3D bindings::PCI_CLASS_NETWORK_ATM, = // 0x020300 + NETWORK_OTHER =3D bindings::PCI_CLASS_NETWORK_OTHER, = // 0x028000 + + DISPLAY_VGA =3D bindings::PCI_CLASS_DISPLAY_VGA, = // 0x030000 + DISPLAY_XGA =3D bindings::PCI_CLASS_DISPLAY_XGA, = // 0x030100 + DISPLAY_3D =3D bindings::PCI_CLASS_DISPLAY_3D, = // 0x030200 + DISPLAY_OTHER =3D bindings::PCI_CLASS_DISPLAY_OTHER, = // 0x038000 + + MULTIMEDIA_VIDEO =3D bindings::PCI_CLASS_MULTIMEDIA_VIDEO, = // 0x040000 + MULTIMEDIA_AUDIO =3D bindings::PCI_CLASS_MULTIMEDIA_AUDIO, = // 0x040100 + MULTIMEDIA_PHONE =3D bindings::PCI_CLASS_MULTIMEDIA_PHONE, = // 0x040200 + MULTIMEDIA_HD_AUDIO =3D bindings::PCI_CLASS_MULTIMEDIA_HD_AUDIO= , // 0x040300 + MULTIMEDIA_OTHER =3D bindings::PCI_CLASS_MULTIMEDIA_OTHER, = // 0x048000 + + MEMORY_RAM =3D bindings::PCI_CLASS_MEMORY_RAM, = // 0x050000 + MEMORY_FLASH =3D bindings::PCI_CLASS_MEMORY_FLASH, = // 0x050100 + MEMORY_CXL =3D bindings::PCI_CLASS_MEMORY_CXL, = // 0x050200 + MEMORY_OTHER =3D bindings::PCI_CLASS_MEMORY_OTHER, = // 0x058000 + + BRIDGE_HOST =3D bindings::PCI_CLASS_BRIDGE_HOST, = // 0x060000 + BRIDGE_ISA =3D bindings::PCI_CLASS_BRIDGE_ISA, = // 0x060100 + BRIDGE_EISA =3D bindings::PCI_CLASS_BRIDGE_EISA, = // 0x060200 + BRIDGE_MC =3D bindings::PCI_CLASS_BRIDGE_MC, = // 0x060300 + BRIDGE_PCI_NORMAL =3D bindings::PCI_CLASS_BRIDGE_PCI_NORMAL, = // 0x060400 + BRIDGE_PCI_SUBTRACTIVE =3D bindings::PCI_CLASS_BRIDGE_PCI_SUBTRACT= IVE, // 0x060401 + BRIDGE_PCMCIA =3D bindings::PCI_CLASS_BRIDGE_PCMCIA, = // 0x060500 + BRIDGE_NUBUS =3D bindings::PCI_CLASS_BRIDGE_NUBUS, = // 0x060600 + BRIDGE_CARDBUS =3D bindings::PCI_CLASS_BRIDGE_CARDBUS, = // 0x060700 + BRIDGE_RACEWAY =3D bindings::PCI_CLASS_BRIDGE_RACEWAY, = // 0x060800 + BRIDGE_OTHER =3D bindings::PCI_CLASS_BRIDGE_OTHER, = // 0x068000 + + COMMUNICATION_SERIAL =3D bindings::PCI_CLASS_COMMUNICATION_SERIA= L, // 0x070000 + COMMUNICATION_PARALLEL =3D bindings::PCI_CLASS_COMMUNICATION_PARAL= LEL, // 0x070100 + COMMUNICATION_MULTISERIAL =3D bindings::PCI_CLASS_COMMUNICATION_MULTI= SERIAL, // 0x070200 + COMMUNICATION_MODEM =3D bindings::PCI_CLASS_COMMUNICATION_MODEM= , // 0x070300 + COMMUNICATION_OTHER =3D bindings::PCI_CLASS_COMMUNICATION_OTHER= , // 0x078000 + + SYSTEM_PIC =3D bindings::PCI_CLASS_SYSTEM_PIC, = // 0x080000 + SYSTEM_PIC_IOAPIC =3D bindings::PCI_CLASS_SYSTEM_PIC_IOAPIC, = // 0x080010 + SYSTEM_PIC_IOXAPIC =3D bindings::PCI_CLASS_SYSTEM_PIC_IOXAPIC,= // 0x080020 + SYSTEM_DMA =3D bindings::PCI_CLASS_SYSTEM_DMA, = // 0x080100 + SYSTEM_TIMER =3D bindings::PCI_CLASS_SYSTEM_TIMER, = // 0x080200 + SYSTEM_RTC =3D bindings::PCI_CLASS_SYSTEM_RTC, = // 0x080300 + SYSTEM_PCI_HOTPLUG =3D bindings::PCI_CLASS_SYSTEM_PCI_HOTPLUG,= // 0x080400 + SYSTEM_SDHCI =3D bindings::PCI_CLASS_SYSTEM_SDHCI, = // 0x080500 + SYSTEM_RCEC =3D bindings::PCI_CLASS_SYSTEM_RCEC, = // 0x080700 + SYSTEM_OTHER =3D bindings::PCI_CLASS_SYSTEM_OTHER, = // 0x088000 + + INPUT_KEYBOARD =3D bindings::PCI_CLASS_INPUT_KEYBOARD, = // 0x090000 + INPUT_PEN =3D bindings::PCI_CLASS_INPUT_PEN, = // 0x090100 + INPUT_MOUSE =3D bindings::PCI_CLASS_INPUT_MOUSE, = // 0x090200 + INPUT_SCANNER =3D bindings::PCI_CLASS_INPUT_SCANNER, = // 0x090300 + INPUT_GAMEPORT =3D bindings::PCI_CLASS_INPUT_GAMEPORT, = // 0x090400 + INPUT_OTHER =3D bindings::PCI_CLASS_INPUT_OTHER, = // 0x098000 + + DOCKING_GENERIC =3D bindings::PCI_CLASS_DOCKING_GENERIC, = // 0x0a0000 + DOCKING_OTHER =3D bindings::PCI_CLASS_DOCKING_OTHER, = // 0x0a8000 + + PROCESSOR_386 =3D bindings::PCI_CLASS_PROCESSOR_386, = // 0x0b0000 + PROCESSOR_486 =3D bindings::PCI_CLASS_PROCESSOR_486, = // 0x0b0100 + PROCESSOR_PENTIUM =3D bindings::PCI_CLASS_PROCESSOR_PENTIUM, = // 0x0b0200 + PROCESSOR_ALPHA =3D bindings::PCI_CLASS_PROCESSOR_ALPHA, = // 0x0b1000 + PROCESSOR_POWERPC =3D bindings::PCI_CLASS_PROCESSOR_POWERPC, = // 0x0b2000 + PROCESSOR_MIPS =3D bindings::PCI_CLASS_PROCESSOR_MIPS, = // 0x0b3000 + PROCESSOR_CO =3D bindings::PCI_CLASS_PROCESSOR_CO, = // 0x0b4000 + + SERIAL_FIREWIRE =3D bindings::PCI_CLASS_SERIAL_FIREWIRE, = // 0x0c0000 + SERIAL_FIREWIRE_OHCI =3D bindings::PCI_CLASS_SERIAL_FIREWIRE_OHC= I, // 0x0c0010 + SERIAL_ACCESS =3D bindings::PCI_CLASS_SERIAL_ACCESS, = // 0x0c0100 + SERIAL_SSA =3D bindings::PCI_CLASS_SERIAL_SSA, = // 0x0c0200 + SERIAL_USB_UHCI =3D bindings::PCI_CLASS_SERIAL_USB_UHCI, = // 0x0c0300 + SERIAL_USB_OHCI =3D bindings::PCI_CLASS_SERIAL_USB_OHCI, = // 0x0c0310 + SERIAL_USB_EHCI =3D bindings::PCI_CLASS_SERIAL_USB_EHCI, = // 0x0c0320 + SERIAL_USB_XHCI =3D bindings::PCI_CLASS_SERIAL_USB_XHCI, = // 0x0c0330 + SERIAL_USB_CDNS =3D bindings::PCI_CLASS_SERIAL_USB_CDNS, = // 0x0c0380 + SERIAL_USB_DEVICE =3D bindings::PCI_CLASS_SERIAL_USB_DEVICE, = // 0x0c03fe + SERIAL_FIBER =3D bindings::PCI_CLASS_SERIAL_FIBER, = // 0x0c0400 + SERIAL_SMBUS =3D bindings::PCI_CLASS_SERIAL_SMBUS, = // 0x0c0500 + SERIAL_IPMI_SMIC =3D bindings::PCI_CLASS_SERIAL_IPMI_SMIC, = // 0x0c0700 + SERIAL_IPMI_KCS =3D bindings::PCI_CLASS_SERIAL_IPMI_KCS, = // 0x0c0701 + SERIAL_IPMI_BT =3D bindings::PCI_CLASS_SERIAL_IPMI_BT, = // 0x0c0702 + + WIRELESS_RF_CONTROLLER =3D bindings::PCI_CLASS_WIRELESS_RF_CONTROL= LER, // 0x0d1000 + WIRELESS_WHCI =3D bindings::PCI_CLASS_WIRELESS_WHCI, = // 0x0d1010 + + INTELLIGENT_I2O =3D bindings::PCI_CLASS_INTELLIGENT_I2O, = // 0x0e0000 + + SATELLITE_TV =3D bindings::PCI_CLASS_SATELLITE_TV, = // 0x0f0000 + SATELLITE_AUDIO =3D bindings::PCI_CLASS_SATELLITE_AUDIO, = // 0x0f0100 + SATELLITE_VOICE =3D bindings::PCI_CLASS_SATELLITE_VOICE, = // 0x0f0300 + SATELLITE_DATA =3D bindings::PCI_CLASS_SATELLITE_DATA, = // 0x0f0400 + + CRYPT_NETWORK =3D bindings::PCI_CLASS_CRYPT_NETWORK, = // 0x100000 + CRYPT_ENTERTAINMENT =3D bindings::PCI_CLASS_CRYPT_ENTERTAINMENT= , // 0x100100 + CRYPT_OTHER =3D bindings::PCI_CLASS_CRYPT_OTHER, = // 0x108000 + + SP_DPIO =3D bindings::PCI_CLASS_SP_DPIO, = // 0x110000 + SP_OTHER =3D bindings::PCI_CLASS_SP_OTHER, = // 0x118000 + + ACCELERATOR_PROCESSING =3D bindings::PCI_CLASS_ACCELERATOR_PROCESS= ING, // 0x120000 + + OTHERS =3D bindings::PCI_CLASS_OTHERS, = // 0xff0000 +} --=20 2.51.0 From nobody Fri Oct 3 18:02:34 2025 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2082.outbound.protection.outlook.com [40.107.100.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A39DC3019BE; Tue, 26 Aug 2025 23:12:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.100.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756249961; cv=fail; b=EtPNXXqoorUjHZF9nLYoLmQ+r4YRYX0cCOnfxCQII4X6FAcgmVU9Yh8VMqOdd1dShZbrDxxM6kHWS6DAD771d+Jcx6gdadnCRv9KxtapVWIjop6zzxYOyyuQjexoNP3CuTcjJpx7GqlawqX1pQaQk7C3RvovIYvPRHa+SzyuPTA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756249961; c=relaxed/simple; bh=6Yon5ncw3z0t2rd/LCavqsxbWMKbrj8KIWWTRsVPFNs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=j/wUj0riu8vk83UYXKbADC0TY+1QNkxU1Nyxl7FywTZDYSLBtxu9rBaIGCK9G7olo25hOBBmAthTtVvVhiSfeM09jPiTpKolQeAj+qJgBLdPw5cvy5KEi/D6exgNQhybB5ozBN+LmC8w32SyltgP3KmBYUo4SNk/VT2z3EJ9gHU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=QYHI8fnD; arc=fail smtp.client-ip=40.107.100.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="QYHI8fnD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ye4XEiGllLAis2NIDjmU5tlZJTDc259sPZZjxdPGpOGhAKN64JYYNmvk1BRonlulj/8Y/Smhq87mfOEcFPKxW7YqhVBnXEL8F3TZhsu7vPvGODiN+xVJc5sUodZO5VKbwb7c0WcdJ65IP5PasaqLfaCtBQMnc63PVjeZshI8PZH3xUOpUlhCEPZBJwCxWq8G5C4Hss/rnl6wDmNDyjLUFdA+NpnERRC3kYJNDcfSCuMs66UtDcsHi/TPDfVTvQXzUzlB0UvAXS5fWj8rnZ7S+XGXRBJyrejmprBxtR8auAR9IukFH5oDnEqhAJQDSY7XN/v63nHO2TkHga7RQBmVlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KYc38GG/aX4kIJvpxdB6+EmSnZl1hEeOytFsGITgOmI=; b=kqT6Uw1oO9o9frm4dkD5sc/ztbVQOrdFrqxRfU4xNQmKC7H24d3HI+KdROLrFeNC4O5w8PXJbL9qjjrvUSMp2xUzbEFc44yiXhPB95npJTQkTS1b5xyM2SpQoPLbrjkz0sAtqf4eWXXytKo80s0CpvHb5WfVd5EkzgB4d1ONzbu82OlU7iv5ncyR1iNSvo/OB5PwJd5v0DrStq7JdUNNVS8RCywqgTpdqHh5Yh11CLdk1Z0A5QulBNSMxdjyCQ/e+7yjK0VK40fMRI+OzQJHcmlweaH5EAh9QccTjvVNhCOb4R65ZUNfXgDr5Yed6OBxXHMKuLcSN+M+MPPfpUVeJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KYc38GG/aX4kIJvpxdB6+EmSnZl1hEeOytFsGITgOmI=; b=QYHI8fnDglLqfWL6BpC4Bx9KujQIpPL/P8rCPn5AG7A/6tBrqfwK2C03kqRuxsjmmx/AHpzOa6GCKJLpNtfkzVf+TDNdQlJVSCSljLTmsvNa6WsKRO8izfprAcwuO1RsnMbT4ePiYZPpfgWXYqLV/XX3Q/eHppN7Tx2INt0T1j07tFAxrpaM9EOxR5dabeSVX89xBMjLdCYk2H3cWeJ4/fAJccA5gDDt14wQbajUDGIe00rJEiTX1a8pudZrdxEmFAWsVyA9AUWMgwW1zTkl+PbcI/sbeyyvrZFa/cvPKohOIGsAobnjStwir5NLut7z1C//tHTpCe/biwFFB4F6kw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) by PH7PR12MB7913.namprd12.prod.outlook.com (2603:10b6:510:27b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.13; Tue, 26 Aug 2025 23:12:31 +0000 Received: from LV2PR12MB5968.namprd12.prod.outlook.com ([fe80::e6dd:1206:6677:f9c4]) by LV2PR12MB5968.namprd12.prod.outlook.com ([fe80::e6dd:1206:6677:f9c4%6]) with mapi id 15.20.9073.010; Tue, 26 Aug 2025 23:12:30 +0000 From: John Hubbard To: Danilo Krummrich Cc: Alexandre Courbot , Joel Fernandes , Timur Tabi , Alistair Popple , David Airlie , Simona Vetter , Bjorn Helgaas , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , nouveau@lists.freedesktop.org, linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, LKML , John Hubbard , Elle Rhumsaa Subject: [PATCH v7 2/6] rust: pci: provide access to PCI Vendor values Date: Tue, 26 Aug 2025 16:12:20 -0700 Message-ID: <20250826231224.1241349-3-jhubbard@nvidia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826231224.1241349-1-jhubbard@nvidia.com> References: <20250826231224.1241349-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0114.namprd03.prod.outlook.com (2603:10b6:a03:333::29) To LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5968:EE_|PH7PR12MB7913:EE_ X-MS-Office365-Filtering-Correlation-Id: f4265460-a5aa-4daf-33f6-08dde4f60826 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?zHwaJnzJMzqocCo69sq2V+ZApmKhzfqQX5+rJJmenWBT7zan0pBuUbx+RD+b?= =?us-ascii?Q?MTHbixJnc1Mo5jXsH8w0iOqSp2mb5CkG4SdCU6i1O/vpVv88avQw7gr/E1CG?= =?us-ascii?Q?sKX/mQ+iKpJUaFsLsHGNJCKOV6Gf1Xo79IbOyaAUdclHZL7bc+00BWHtXHp9?= =?us-ascii?Q?/bP/RB6EuNR8OpjleaMhKyHx2Df69SsxhdGaKXqACKlpMK6lb3zncGwN5iAw?= =?us-ascii?Q?ZOZ9ZeUIUVpq54IMPP5PIkClqbP7dTqrlFCNjjgCOnz90Sc4NSAumsD+9YCX?= =?us-ascii?Q?E5lYkM2mb4ZNxiQdJFbN7cAm3kXTVS8RccSyPuQwwEIDk1HgooFCJEpEjc+e?= =?us-ascii?Q?AuUFF/w7WkYOSgERhDhlCBqUUiI7Tzk4ogcBWeTUnkCd5EnncRKXZRv5zRWz?= =?us-ascii?Q?oAIcTOQgQQrQ+SHzqHfW4vypmePXQUprbbDu69EX8QEFG71Isf19PCgjWUo8?= =?us-ascii?Q?kmdqcbf3h8kN6Sp9p4c5qIXWA0Gmuk8RUiJL4K553X0tUoTSV67UriFvY4oh?= =?us-ascii?Q?9LgQ86fCgV7MW8LgEpwxGbcEli/QHrGy/y/S7hyCZh5+KFmk0HdRTrUiZSCg?= =?us-ascii?Q?KZD7IDJi7Yib0KRNZbyqyYjy0WF2yb2vJDKTOvlfgex0NQWe36DWwU4hiRIj?= =?us-ascii?Q?Jg1plHvh5jzhaCvFiXxF2XDe4OvRLGzv0DyF0wlFBTP1HQNSfHF8Bjdtstp6?= =?us-ascii?Q?66tdhB0T7aDhoIKFL6wmdAaeOfuMIcPEZoDxyjBejr6Q4vbmUInslP8CR9lF?= =?us-ascii?Q?+Mb7egXAcKJEXJM08Wl50tFKgRzQLhen6aT6ALtZL/e5qrDkovbGNHiejRcn?= =?us-ascii?Q?GnGp0/ugAkZzccicBPKXhXoanYgzmJTpJvzAuDqiQBs5v3VibZtWcaibdLTV?= =?us-ascii?Q?XEmq97PPiBa6CoScGDohUnhrqzFUGftAMZr7hni3Y6L741WvlFo0jPvEjkva?= =?us-ascii?Q?PdeBwd1SqcNtR5D/T+13vGkzkXEBl9y+IUdUwTzWOmmvHf+bQpA286X3WCo4?= =?us-ascii?Q?+hMmOouxRrXtrXJh3+MTrSgsdTqlG9w+zXCO7KbXBrWZj+4y0U+KMOrOXRMw?= =?us-ascii?Q?v3VO5QVvvn5nRmkgVZPSVT63+1+soBZkn11iPJqIwKo+HlQ2WNn+18CxPzjM?= =?us-ascii?Q?CVOfK0g84jMpVzY92QX9bpd5G3uElaW9XQihVKrJNxYjqozarMi1vNpA692K?= =?us-ascii?Q?75c+SY2nAzie34e89fJf5axh+1QZe/n3u5ks2Lbg45t0KbwB1y/NieKc5Aiz?= =?us-ascii?Q?9RsNJ2E07aafLvHQtZgq0NadJo40F11KHKTkufrMhpORc+pc0LHKyvh2VSsD?= =?us-ascii?Q?oxomyq8V1KkOXWIWtbUAm2lTrYbHFxVKMbcVz9ZjfSufD9lZWBAWceHKZxZj?= =?us-ascii?Q?srbVIELAjLJZvkvKVmKZLnJLW9iWDOkAAt+GljvHJeZq5wMDslA4B7aeg8zl?= =?us-ascii?Q?1mCGaDWvKZY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5968.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kR6uWHJ6kuWmpWvPVzkP69jEdgOABae+pHF6sRaAwA4IOQtMsrQ/gEkzsiZI?= =?us-ascii?Q?u3PX4+WMlvzXYa3M6a0JWbbwHvzLNYVt2DMEyXxKrXSWEIuO1KpbEsVoHj5D?= =?us-ascii?Q?L40oPdPDbONXaf2x8PnbZuNFOfd8QK5iTXrsFaUUhWr1llpV01zKUaJU2dzm?= =?us-ascii?Q?VNsdxsOHx/wEEI7RHhFP2uEkzuigFhYOjWBNCDAYdUCKELFwGFSAAO992R5v?= =?us-ascii?Q?s/gDlacn/Wl1+hcwgIq0VMnjZ87ceAM1riIZ9QXTh/VkooVbHOc1uHLJZP4L?= =?us-ascii?Q?CbXQugQISmZXwfWdCGZzn95Rtj3ulz4y9Z2H8q9ZdfCS06n4hvgUqKS1PcSc?= =?us-ascii?Q?IhkGtL5oP8M3ulQH+ioNKnOdZSqnw+KwEIZsP0FGypJd9SZLdNWNlYwEcUOh?= =?us-ascii?Q?x95WcYDogrw9qTW7cVEvSeiAY/BKnOJACzFyNnJWX6LrO7FX3yEjKRW5OSEt?= =?us-ascii?Q?Ct6kVMPTeOWvQu4u67QB8MHyOfWOMI9nzvstKM9XffSmW7anPOEbS3p3OLn4?= =?us-ascii?Q?lrTZASYs/DqjeQf6wpJ6FRNSVR0UJqKn60yjl9gVMYryjpBwIheUKN9vTM6h?= =?us-ascii?Q?rK8UIwQzM4l9bEno8HBfRbH8Tdiz593STLufOGDc0gpTsXtShXPc7qIUxsAu?= =?us-ascii?Q?7nGci98aTlzY06MJLMJA7MXrbhYtW+MeWa8qaxxKyLr0mk+0F3HOUW1sv383?= =?us-ascii?Q?xMB8NWaxj+AonjNpa/qdFcRH9QQX5/hUSkxddvTbnVLEKFemt7b9vyl+3JKv?= =?us-ascii?Q?yISux60tWMZ43PZVSKCSQ68AJ8p54+8CSL+v7FlT7PE1wB6/Kdew6uVdNRGz?= =?us-ascii?Q?GzVHB8LuRSSUULKoX0W/xlQ79BuPxhe6lL11HSaYcOjzeG4zAiHz/XnY1B0c?= =?us-ascii?Q?L9e2DB6FVAzwhmRyF4/+pQlQRXmNHz/ZH1Wi1PApRGKGAXEgnUguU+Ot2C7Y?= =?us-ascii?Q?F23GY/4MwAdMh6onsgasaaV8DPLm1T5eglFLAS7M/laPJN1/0LpAWIk6iOO+?= =?us-ascii?Q?DufTTJBtvEA5265H3vq3CIUnFlq1aiGcEKXQLEEBQRaVPfAfCT7RJXdrTnVx?= =?us-ascii?Q?ynJMAiqoI1/fJD+xJOo8fOo9xKWR+Ef9Z8AIH1lftU7O0KzFjkB+R6NV+yQW?= =?us-ascii?Q?YpZj28KSKIRAuLns3iNHCNFtp2JhsRZjZ1o3CnI88D+R8OrJbFUnRqn/U+1a?= =?us-ascii?Q?pL2RfWoexhg1bsCvHqghbfwmpGH5MqVgIIRgoeFscx841lTo3roK1XXk4GAC?= =?us-ascii?Q?FfmXGUureMrbFXbpB29CZyg3+dW4zLb0ZOcm4nw0mT/P/7vCIrbgce3pFvRd?= =?us-ascii?Q?cigPVKB9NzT603QhC17/ZW2ChIPGepBjp3e7gAMYtN2AAlW0geR2rfG7UdaQ?= =?us-ascii?Q?rlcKOYMwvTLWCPSA3LcptteFBFUtjk3o3I/h3irpDkYoecFCDbOY+FCIscZY?= =?us-ascii?Q?mOjEJCZhE1ic71n7bFe5CBuCxLgt7rT8jKx782dKu6TTVy/t+GMwyyEE+9cp?= =?us-ascii?Q?pfcXnvpTgtlk71tooVmwoevIy8atwIrzV2ZRkoYfiqRAMl8LumDoJzadqRss?= =?us-ascii?Q?iyW6tlKveFgEY5C+OtO53eM1YC23uxRRq3dCkiFC?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4265460-a5aa-4daf-33f6-08dde4f60826 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5968.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2025 23:12:30.8636 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q//dYg+HebMsu8jIIZwxJeZH2JkHzkgNXwpwgSyJCV6CIyPCyknaptbNB5qppDpEMO4mce/pLvfoGzvcouwRAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7913 Content-Type: text/plain; charset="utf-8" This allows callers to write Vendor::SOME_COMPANY instead of bindings::PCI_VENDOR_ID_SOME_COMPANY. New APIs: Vendor::SOME_COMPANY Vendor::from_raw() -- Only accessible from the pci (parent) module. Vendor::as_raw() Vendor: fmt::Display for Vendor Cc: Danilo Krummrich Cc: Alexandre Courbot Cc: Elle Rhumsaa Signed-off-by: John Hubbard Reviewed-by: Alexandre Courbot --- rust/kernel/pci.rs | 2 +- rust/kernel/pci/id.rs | 349 +++++++++++++++++++++++++++++++++++++++++- 2 files changed, 349 insertions(+), 2 deletions(-) diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs index 212c4a6834fb..f15cfd0e76d9 100644 --- a/rust/kernel/pci.rs +++ b/rust/kernel/pci.rs @@ -25,7 +25,7 @@ =20 mod id; =20 -pub use self::id::{Class, ClassMask}; +pub use self::id::{Class, ClassMask, Vendor}; =20 /// An adapter for the registration of PCI drivers. pub struct Adapter(T); diff --git a/rust/kernel/pci/id.rs b/rust/kernel/pci/id.rs index 55d9cdcc6658..4b0ad8d4edc6 100644 --- a/rust/kernel/pci/id.rs +++ b/rust/kernel/pci/id.rs @@ -2,7 +2,7 @@ =20 //! PCI device identifiers and related types. //! -//! This module contains PCI class codes and supporting types. +//! This module contains PCI class codes, Vendor IDs, and supporting types. =20 use crate::{bindings, error::code::EINVAL, error::Error, prelude::*}; use core::fmt; @@ -109,6 +109,69 @@ fn try_from(value: u32) -> Result { } } =20 +/// PCI vendor IDs. +/// +/// Each entry contains the 16-bit PCI vendor ID as assigned by the PCI SI= G. +/// +/// # Examples +/// +/// ``` +/// # use kernel::{device::Core, pci::{self, Vendor}, prelude::*}; +/// fn log_device_info(pdev: &pci::Device) -> Result<()> { +/// // Compare raw vendor ID with known vendor constant +/// let vendor_id =3D pdev.vendor_id(); +/// if vendor_id =3D=3D Vendor::NVIDIA.as_raw() { +/// dev_info!( +/// pdev.as_ref(), +/// "Found NVIDIA device: 0x{:x}\n", +/// pdev.device_id() +/// ); +/// } +/// Ok(()) +/// } +/// ``` +#[derive(Debug, Clone, Copy, PartialEq, Eq)] +#[repr(transparent)] +pub struct Vendor(u16); + +macro_rules! define_all_pci_vendors { + ( + $($variant:ident =3D $binding:expr,)+ + ) =3D> { + + impl Vendor { + $( + #[allow(missing_docs)] + pub const $variant: Self =3D Self($binding as u16); + )+ + } + }; +} + +/// Once constructed, a `Vendor` contains a valid PCI Vendor ID. +impl Vendor { + /// Create a Vendor from a raw 16-bit vendor ID. + /// Only accessible from the parent pci module. + #[expect(dead_code)] + #[inline] + pub(super) fn from_raw(vendor_id: u16) -> Self { + Self(vendor_id) + } + + /// Get the raw 16-bit vendor ID value. + #[inline] + pub const fn as_raw(self) -> u16 { + self.0 + } +} + +impl fmt::Display for Vendor { + #[inline] + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { + write!(f, "0x{:04x}", self.0) + } +} + define_all_pci_classes! { NOT_DEFINED =3D bindings::PCI_CLASS_NOT_DEFINED, = // 0x000000 NOT_DEFINED_VGA =3D bindings::PCI_CLASS_NOT_DEFINED_VGA, = // 0x000100 @@ -230,3 +293,287 @@ fn try_from(value: u32) -> Result { =20 OTHERS =3D bindings::PCI_CLASS_OTHERS, = // 0xff0000 } + +define_all_pci_vendors! { + PCI_SIG =3D bindings::PCI_VENDOR_ID_PCI_SIG, = // 0x0001 + LOONGSON =3D bindings::PCI_VENDOR_ID_LOONGSON, = // 0x0014 + SOLIDIGM =3D bindings::PCI_VENDOR_ID_SOLIDIGM, = // 0x025e + TTTECH =3D bindings::PCI_VENDOR_ID_TTTECH, = // 0x0357 + DYNALINK =3D bindings::PCI_VENDOR_ID_DYNALINK, = // 0x0675 + UBIQUITI =3D bindings::PCI_VENDOR_ID_UBIQUITI, = // 0x0777 + BERKOM =3D bindings::PCI_VENDOR_ID_BERKOM, = // 0x0871 + ITTIM =3D bindings::PCI_VENDOR_ID_ITTIM, = // 0x0b48 + COMPAQ =3D bindings::PCI_VENDOR_ID_COMPAQ, = // 0x0e11 + LSI_LOGIC =3D bindings::PCI_VENDOR_ID_LSI_LOGIC, = // 0x1000 + ATI =3D bindings::PCI_VENDOR_ID_ATI, = // 0x1002 + VLSI =3D bindings::PCI_VENDOR_ID_VLSI, = // 0x1004 + ADL =3D bindings::PCI_VENDOR_ID_ADL, = // 0x1005 + NS =3D bindings::PCI_VENDOR_ID_NS, = // 0x100b + TSENG =3D bindings::PCI_VENDOR_ID_TSENG, = // 0x100c + WEITEK =3D bindings::PCI_VENDOR_ID_WEITEK, = // 0x100e + DEC =3D bindings::PCI_VENDOR_ID_DEC, = // 0x1011 + CIRRUS =3D bindings::PCI_VENDOR_ID_CIRRUS, = // 0x1013 + IBM =3D bindings::PCI_VENDOR_ID_IBM, = // 0x1014 + UNISYS =3D bindings::PCI_VENDOR_ID_UNISYS, = // 0x1018 + COMPEX2 =3D bindings::PCI_VENDOR_ID_COMPEX2, = // 0x101a + WD =3D bindings::PCI_VENDOR_ID_WD, = // 0x101c + AMI =3D bindings::PCI_VENDOR_ID_AMI, = // 0x101e + AMD =3D bindings::PCI_VENDOR_ID_AMD, = // 0x1022 + TRIDENT =3D bindings::PCI_VENDOR_ID_TRIDENT, = // 0x1023 + AI =3D bindings::PCI_VENDOR_ID_AI, = // 0x1025 + DELL =3D bindings::PCI_VENDOR_ID_DELL, = // 0x1028 + MATROX =3D bindings::PCI_VENDOR_ID_MATROX, = // 0x102B + MOBILITY_ELECTRONICS =3D bindings::PCI_VENDOR_ID_MOBILITY_ELECTRON= ICS, // 0x14f2 + CT =3D bindings::PCI_VENDOR_ID_CT, = // 0x102c + MIRO =3D bindings::PCI_VENDOR_ID_MIRO, = // 0x1031 + NEC =3D bindings::PCI_VENDOR_ID_NEC, = // 0x1033 + FD =3D bindings::PCI_VENDOR_ID_FD, = // 0x1036 + SI =3D bindings::PCI_VENDOR_ID_SI, = // 0x1039 + HP =3D bindings::PCI_VENDOR_ID_HP, = // 0x103c + HP_3PAR =3D bindings::PCI_VENDOR_ID_HP_3PAR, = // 0x1590 + PCTECH =3D bindings::PCI_VENDOR_ID_PCTECH, = // 0x1042 + ASUSTEK =3D bindings::PCI_VENDOR_ID_ASUSTEK, = // 0x1043 + DPT =3D bindings::PCI_VENDOR_ID_DPT, = // 0x1044 + OPTI =3D bindings::PCI_VENDOR_ID_OPTI, = // 0x1045 + ELSA =3D bindings::PCI_VENDOR_ID_ELSA, = // 0x1048 + STMICRO =3D bindings::PCI_VENDOR_ID_STMICRO, = // 0x104A + BUSLOGIC =3D bindings::PCI_VENDOR_ID_BUSLOGIC, = // 0x104B + TI =3D bindings::PCI_VENDOR_ID_TI, = // 0x104c + SONY =3D bindings::PCI_VENDOR_ID_SONY, = // 0x104d + WINBOND2 =3D bindings::PCI_VENDOR_ID_WINBOND2, = // 0x1050 + ANIGMA =3D bindings::PCI_VENDOR_ID_ANIGMA, = // 0x1051 + EFAR =3D bindings::PCI_VENDOR_ID_EFAR, = // 0x1055 + MOTOROLA =3D bindings::PCI_VENDOR_ID_MOTOROLA, = // 0x1057 + PROMISE =3D bindings::PCI_VENDOR_ID_PROMISE, = // 0x105a + FOXCONN =3D bindings::PCI_VENDOR_ID_FOXCONN, = // 0x105b + UMC =3D bindings::PCI_VENDOR_ID_UMC, = // 0x1060 + PICOPOWER =3D bindings::PCI_VENDOR_ID_PICOPOWER, = // 0x1066 + MYLEX =3D bindings::PCI_VENDOR_ID_MYLEX, = // 0x1069 + APPLE =3D bindings::PCI_VENDOR_ID_APPLE, = // 0x106b + YAMAHA =3D bindings::PCI_VENDOR_ID_YAMAHA, = // 0x1073 + QLOGIC =3D bindings::PCI_VENDOR_ID_QLOGIC, = // 0x1077 + CYRIX =3D bindings::PCI_VENDOR_ID_CYRIX, = // 0x1078 + CONTAQ =3D bindings::PCI_VENDOR_ID_CONTAQ, = // 0x1080 + OLICOM =3D bindings::PCI_VENDOR_ID_OLICOM, = // 0x108d + SUN =3D bindings::PCI_VENDOR_ID_SUN, = // 0x108e + NI =3D bindings::PCI_VENDOR_ID_NI, = // 0x1093 + CMD =3D bindings::PCI_VENDOR_ID_CMD, = // 0x1095 + BROOKTREE =3D bindings::PCI_VENDOR_ID_BROOKTREE, = // 0x109e + SGI =3D bindings::PCI_VENDOR_ID_SGI, = // 0x10a9 + WINBOND =3D bindings::PCI_VENDOR_ID_WINBOND, = // 0x10ad + PLX =3D bindings::PCI_VENDOR_ID_PLX, = // 0x10b5 + MADGE =3D bindings::PCI_VENDOR_ID_MADGE, = // 0x10b6 + THREECOM =3D bindings::PCI_VENDOR_ID_3COM, = // 0x10b7 + AL =3D bindings::PCI_VENDOR_ID_AL, = // 0x10b9 + NEOMAGIC =3D bindings::PCI_VENDOR_ID_NEOMAGIC, = // 0x10c8 + TCONRAD =3D bindings::PCI_VENDOR_ID_TCONRAD, = // 0x10da + ROHM =3D bindings::PCI_VENDOR_ID_ROHM, = // 0x10db + NVIDIA =3D bindings::PCI_VENDOR_ID_NVIDIA, = // 0x10de + IMS =3D bindings::PCI_VENDOR_ID_IMS, = // 0x10e0 + AMCC =3D bindings::PCI_VENDOR_ID_AMCC, = // 0x10e8 + AMPERE =3D bindings::PCI_VENDOR_ID_AMPERE, = // 0x1def + INTERG =3D bindings::PCI_VENDOR_ID_INTERG, = // 0x10ea + REALTEK =3D bindings::PCI_VENDOR_ID_REALTEK, = // 0x10ec + XILINX =3D bindings::PCI_VENDOR_ID_XILINX, = // 0x10ee + INIT =3D bindings::PCI_VENDOR_ID_INIT, = // 0x1101 + CREATIVE =3D bindings::PCI_VENDOR_ID_CREATIVE, = // 0x1102 + TTI =3D bindings::PCI_VENDOR_ID_TTI, = // 0x1103 + SIGMA =3D bindings::PCI_VENDOR_ID_SIGMA, = // 0x1105 + VIA =3D bindings::PCI_VENDOR_ID_VIA, = // 0x1106 + SIEMENS =3D bindings::PCI_VENDOR_ID_SIEMENS, = // 0x110A + VORTEX =3D bindings::PCI_VENDOR_ID_VORTEX, = // 0x1119 + EF =3D bindings::PCI_VENDOR_ID_EF, = // 0x111a + IDT =3D bindings::PCI_VENDOR_ID_IDT, = // 0x111d + FORE =3D bindings::PCI_VENDOR_ID_FORE, = // 0x1127 + PHILIPS =3D bindings::PCI_VENDOR_ID_PHILIPS, = // 0x1131 + EICON =3D bindings::PCI_VENDOR_ID_EICON, = // 0x1133 + CISCO =3D bindings::PCI_VENDOR_ID_CISCO, = // 0x1137 + ZIATECH =3D bindings::PCI_VENDOR_ID_ZIATECH, = // 0x1138 + SYSKONNECT =3D bindings::PCI_VENDOR_ID_SYSKONNECT, = // 0x1148 + DIGI =3D bindings::PCI_VENDOR_ID_DIGI, = // 0x114f + XIRCOM =3D bindings::PCI_VENDOR_ID_XIRCOM, = // 0x115d + SERVERWORKS =3D bindings::PCI_VENDOR_ID_SERVERWORKS, = // 0x1166 + ALTERA =3D bindings::PCI_VENDOR_ID_ALTERA, = // 0x1172 + SBE =3D bindings::PCI_VENDOR_ID_SBE, = // 0x1176 + TOSHIBA =3D bindings::PCI_VENDOR_ID_TOSHIBA, = // 0x1179 + TOSHIBA_2 =3D bindings::PCI_VENDOR_ID_TOSHIBA_2, = // 0x102f + ATTO =3D bindings::PCI_VENDOR_ID_ATTO, = // 0x117c + RICOH =3D bindings::PCI_VENDOR_ID_RICOH, = // 0x1180 + DLINK =3D bindings::PCI_VENDOR_ID_DLINK, = // 0x1186 + ARTOP =3D bindings::PCI_VENDOR_ID_ARTOP, = // 0x1191 + ZEITNET =3D bindings::PCI_VENDOR_ID_ZEITNET, = // 0x1193 + FUJITSU_ME =3D bindings::PCI_VENDOR_ID_FUJITSU_ME, = // 0x119e + MARVELL =3D bindings::PCI_VENDOR_ID_MARVELL, = // 0x11ab + MARVELL_EXT =3D bindings::PCI_VENDOR_ID_MARVELL_EXT, = // 0x1b4b + V3 =3D bindings::PCI_VENDOR_ID_V3, = // 0x11b0 + ATT =3D bindings::PCI_VENDOR_ID_ATT, = // 0x11c1 + SPECIALIX =3D bindings::PCI_VENDOR_ID_SPECIALIX, = // 0x11cb + ANALOG_DEVICES =3D bindings::PCI_VENDOR_ID_ANALOG_DEVICES, = // 0x11d4 + ZORAN =3D bindings::PCI_VENDOR_ID_ZORAN, = // 0x11de + COMPEX =3D bindings::PCI_VENDOR_ID_COMPEX, = // 0x11f6 + MICROSEMI =3D bindings::PCI_VENDOR_ID_MICROSEMI, = // 0x11f8 + RP =3D bindings::PCI_VENDOR_ID_RP, = // 0x11fe + CYCLADES =3D bindings::PCI_VENDOR_ID_CYCLADES, = // 0x120e + ESSENTIAL =3D bindings::PCI_VENDOR_ID_ESSENTIAL, = // 0x120f + O2 =3D bindings::PCI_VENDOR_ID_O2, = // 0x1217 + THREEDX =3D bindings::PCI_VENDOR_ID_3DFX, = // 0x121a + AVM =3D bindings::PCI_VENDOR_ID_AVM, = // 0x1244 + STALLION =3D bindings::PCI_VENDOR_ID_STALLION, = // 0x124d + AT =3D bindings::PCI_VENDOR_ID_AT, = // 0x1259 + ASIX =3D bindings::PCI_VENDOR_ID_ASIX, = // 0x125b + ESS =3D bindings::PCI_VENDOR_ID_ESS, = // 0x125d + SATSAGEM =3D bindings::PCI_VENDOR_ID_SATSAGEM, = // 0x1267 + ENSONIQ =3D bindings::PCI_VENDOR_ID_ENSONIQ, = // 0x1274 + TRANSMETA =3D bindings::PCI_VENDOR_ID_TRANSMETA, = // 0x1279 + ROCKWELL =3D bindings::PCI_VENDOR_ID_ROCKWELL, = // 0x127A + ITE =3D bindings::PCI_VENDOR_ID_ITE, = // 0x1283 + ALTEON =3D bindings::PCI_VENDOR_ID_ALTEON, = // 0x12ae + NVIDIA_SGS =3D bindings::PCI_VENDOR_ID_NVIDIA_SGS, = // 0x12d2 + PERICOM =3D bindings::PCI_VENDOR_ID_PERICOM, = // 0x12D8 + AUREAL =3D bindings::PCI_VENDOR_ID_AUREAL, = // 0x12eb + ELECTRONICDESIGNGMBH =3D bindings::PCI_VENDOR_ID_ELECTRONICDESIGNG= MBH, // 0x12f8 + ESDGMBH =3D bindings::PCI_VENDOR_ID_ESDGMBH, = // 0x12fe + CB =3D bindings::PCI_VENDOR_ID_CB, = // 0x1307 + SIIG =3D bindings::PCI_VENDOR_ID_SIIG, = // 0x131f + RADISYS =3D bindings::PCI_VENDOR_ID_RADISYS, = // 0x1331 + MICRO_MEMORY =3D bindings::PCI_VENDOR_ID_MICRO_MEMORY, = // 0x1332 + DOMEX =3D bindings::PCI_VENDOR_ID_DOMEX, = // 0x134a + INTASHIELD =3D bindings::PCI_VENDOR_ID_INTASHIELD, = // 0x135a + QUATECH =3D bindings::PCI_VENDOR_ID_QUATECH, = // 0x135C + SEALEVEL =3D bindings::PCI_VENDOR_ID_SEALEVEL, = // 0x135e + HYPERCOPE =3D bindings::PCI_VENDOR_ID_HYPERCOPE, = // 0x1365 + DIGIGRAM =3D bindings::PCI_VENDOR_ID_DIGIGRAM, = // 0x1369 + KAWASAKI =3D bindings::PCI_VENDOR_ID_KAWASAKI, = // 0x136b + CNET =3D bindings::PCI_VENDOR_ID_CNET, = // 0x1371 + LMC =3D bindings::PCI_VENDOR_ID_LMC, = // 0x1376 + NETGEAR =3D bindings::PCI_VENDOR_ID_NETGEAR, = // 0x1385 + APPLICOM =3D bindings::PCI_VENDOR_ID_APPLICOM, = // 0x1389 + MOXA =3D bindings::PCI_VENDOR_ID_MOXA, = // 0x1393 + CCD =3D bindings::PCI_VENDOR_ID_CCD, = // 0x1397 + EXAR =3D bindings::PCI_VENDOR_ID_EXAR, = // 0x13a8 + MICROGATE =3D bindings::PCI_VENDOR_ID_MICROGATE, = // 0x13c0 + THREEWARE =3D bindings::PCI_VENDOR_ID_3WARE, = // 0x13C1 + IOMEGA =3D bindings::PCI_VENDOR_ID_IOMEGA, = // 0x13ca + ABOCOM =3D bindings::PCI_VENDOR_ID_ABOCOM, = // 0x13D1 + SUNDANCE =3D bindings::PCI_VENDOR_ID_SUNDANCE, = // 0x13f0 + CMEDIA =3D bindings::PCI_VENDOR_ID_CMEDIA, = // 0x13f6 + ADVANTECH =3D bindings::PCI_VENDOR_ID_ADVANTECH, = // 0x13fe + MEILHAUS =3D bindings::PCI_VENDOR_ID_MEILHAUS, = // 0x1402 + LAVA =3D bindings::PCI_VENDOR_ID_LAVA, = // 0x1407 + TIMEDIA =3D bindings::PCI_VENDOR_ID_TIMEDIA, = // 0x1409 + ICE =3D bindings::PCI_VENDOR_ID_ICE, = // 0x1412 + MICROSOFT =3D bindings::PCI_VENDOR_ID_MICROSOFT, = // 0x1414 + OXSEMI =3D bindings::PCI_VENDOR_ID_OXSEMI, = // 0x1415 + CHELSIO =3D bindings::PCI_VENDOR_ID_CHELSIO, = // 0x1425 + EDIMAX =3D bindings::PCI_VENDOR_ID_EDIMAX, = // 0x1432 + ADLINK =3D bindings::PCI_VENDOR_ID_ADLINK, = // 0x144a + SAMSUNG =3D bindings::PCI_VENDOR_ID_SAMSUNG, = // 0x144d + GIGABYTE =3D bindings::PCI_VENDOR_ID_GIGABYTE, = // 0x1458 + AMBIT =3D bindings::PCI_VENDOR_ID_AMBIT, = // 0x1468 + MYRICOM =3D bindings::PCI_VENDOR_ID_MYRICOM, = // 0x14c1 + MEDIATEK =3D bindings::PCI_VENDOR_ID_MEDIATEK, = // 0x14c3 + TITAN =3D bindings::PCI_VENDOR_ID_TITAN, = // 0x14D2 + PANACOM =3D bindings::PCI_VENDOR_ID_PANACOM, = // 0x14d4 + SIPACKETS =3D bindings::PCI_VENDOR_ID_SIPACKETS, = // 0x14d9 + AFAVLAB =3D bindings::PCI_VENDOR_ID_AFAVLAB, = // 0x14db + AMPLICON =3D bindings::PCI_VENDOR_ID_AMPLICON, = // 0x14dc + BCM_GVC =3D bindings::PCI_VENDOR_ID_BCM_GVC, = // 0x14a4 + BROADCOM =3D bindings::PCI_VENDOR_ID_BROADCOM, = // 0x14e4 + TOPIC =3D bindings::PCI_VENDOR_ID_TOPIC, = // 0x151f + MAINPINE =3D bindings::PCI_VENDOR_ID_MAINPINE, = // 0x1522 + ENE =3D bindings::PCI_VENDOR_ID_ENE, = // 0x1524 + SYBA =3D bindings::PCI_VENDOR_ID_SYBA, = // 0x1592 + MORETON =3D bindings::PCI_VENDOR_ID_MORETON, = // 0x15aa + VMWARE =3D bindings::PCI_VENDOR_ID_VMWARE, = // 0x15ad + ZOLTRIX =3D bindings::PCI_VENDOR_ID_ZOLTRIX, = // 0x15b0 + MELLANOX =3D bindings::PCI_VENDOR_ID_MELLANOX, = // 0x15b3 + DFI =3D bindings::PCI_VENDOR_ID_DFI, = // 0x15bd + QUICKNET =3D bindings::PCI_VENDOR_ID_QUICKNET, = // 0x15e2 + ADDIDATA =3D bindings::PCI_VENDOR_ID_ADDIDATA, = // 0x15B8 + PDC =3D bindings::PCI_VENDOR_ID_PDC, = // 0x15e9 + FARSITE =3D bindings::PCI_VENDOR_ID_FARSITE, = // 0x1619 + ARIMA =3D bindings::PCI_VENDOR_ID_ARIMA, = // 0x161f + BROCADE =3D bindings::PCI_VENDOR_ID_BROCADE, = // 0x1657 + SIBYTE =3D bindings::PCI_VENDOR_ID_SIBYTE, = // 0x166d + ATHEROS =3D bindings::PCI_VENDOR_ID_ATHEROS, = // 0x168c + NETCELL =3D bindings::PCI_VENDOR_ID_NETCELL, = // 0x169c + CENATEK =3D bindings::PCI_VENDOR_ID_CENATEK, = // 0x16CA + SYNOPSYS =3D bindings::PCI_VENDOR_ID_SYNOPSYS, = // 0x16c3 + USR =3D bindings::PCI_VENDOR_ID_USR, = // 0x16ec + VITESSE =3D bindings::PCI_VENDOR_ID_VITESSE, = // 0x1725 + LINKSYS =3D bindings::PCI_VENDOR_ID_LINKSYS, = // 0x1737 + ALTIMA =3D bindings::PCI_VENDOR_ID_ALTIMA, = // 0x173b + CAVIUM =3D bindings::PCI_VENDOR_ID_CAVIUM, = // 0x177d + TECHWELL =3D bindings::PCI_VENDOR_ID_TECHWELL, = // 0x1797 + BELKIN =3D bindings::PCI_VENDOR_ID_BELKIN, = // 0x1799 + RDC =3D bindings::PCI_VENDOR_ID_RDC, = // 0x17f3 + GLI =3D bindings::PCI_VENDOR_ID_GLI, = // 0x17a0 + LENOVO =3D bindings::PCI_VENDOR_ID_LENOVO, = // 0x17aa + QCOM =3D bindings::PCI_VENDOR_ID_QCOM, = // 0x17cb + CDNS =3D bindings::PCI_VENDOR_ID_CDNS, = // 0x17cd + ARECA =3D bindings::PCI_VENDOR_ID_ARECA, = // 0x17d3 + S2IO =3D bindings::PCI_VENDOR_ID_S2IO, = // 0x17d5 + SITECOM =3D bindings::PCI_VENDOR_ID_SITECOM, = // 0x182d + TOPSPIN =3D bindings::PCI_VENDOR_ID_TOPSPIN, = // 0x1867 + COMMTECH =3D bindings::PCI_VENDOR_ID_COMMTECH, = // 0x18f7 + SILAN =3D bindings::PCI_VENDOR_ID_SILAN, = // 0x1904 + RENESAS =3D bindings::PCI_VENDOR_ID_RENESAS, = // 0x1912 + SOLARFLARE =3D bindings::PCI_VENDOR_ID_SOLARFLARE, = // 0x1924 + TDI =3D bindings::PCI_VENDOR_ID_TDI, = // 0x192E + NXP =3D bindings::PCI_VENDOR_ID_NXP, = // 0x1957 + PASEMI =3D bindings::PCI_VENDOR_ID_PASEMI, = // 0x1959 + ATTANSIC =3D bindings::PCI_VENDOR_ID_ATTANSIC, = // 0x1969 + JMICRON =3D bindings::PCI_VENDOR_ID_JMICRON, = // 0x197B + KORENIX =3D bindings::PCI_VENDOR_ID_KORENIX, = // 0x1982 + HUAWEI =3D bindings::PCI_VENDOR_ID_HUAWEI, = // 0x19e5 + NETRONOME =3D bindings::PCI_VENDOR_ID_NETRONOME, = // 0x19ee + QMI =3D bindings::PCI_VENDOR_ID_QMI, = // 0x1a32 + AZWAVE =3D bindings::PCI_VENDOR_ID_AZWAVE, = // 0x1a3b + REDHAT_QUMRANET =3D bindings::PCI_VENDOR_ID_REDHAT_QUMRANET, = // 0x1af4 + ASMEDIA =3D bindings::PCI_VENDOR_ID_ASMEDIA, = // 0x1b21 + REDHAT =3D bindings::PCI_VENDOR_ID_REDHAT, = // 0x1b36 + WCHIC =3D bindings::PCI_VENDOR_ID_WCHIC, = // 0x1c00 + SILICOM_DENMARK =3D bindings::PCI_VENDOR_ID_SILICOM_DENMARK, = // 0x1c2c + AMAZON_ANNAPURNA_LABS =3D bindings::PCI_VENDOR_ID_AMAZON_ANNAPURNA_= LABS, // 0x1c36 + CIRCUITCO =3D bindings::PCI_VENDOR_ID_CIRCUITCO, = // 0x1cc8 + AMAZON =3D bindings::PCI_VENDOR_ID_AMAZON, = // 0x1d0f + ZHAOXIN =3D bindings::PCI_VENDOR_ID_ZHAOXIN, = // 0x1d17 + ROCKCHIP =3D bindings::PCI_VENDOR_ID_ROCKCHIP, = // 0x1d87 + HYGON =3D bindings::PCI_VENDOR_ID_HYGON, = // 0x1d94 + META =3D bindings::PCI_VENDOR_ID_META, = // 0x1d9b + FUNGIBLE =3D bindings::PCI_VENDOR_ID_FUNGIBLE, = // 0x1dad + HXT =3D bindings::PCI_VENDOR_ID_HXT, = // 0x1dbf + TEKRAM =3D bindings::PCI_VENDOR_ID_TEKRAM, = // 0x1de1 + RPI =3D bindings::PCI_VENDOR_ID_RPI, = // 0x1de4 + ALIBABA =3D bindings::PCI_VENDOR_ID_ALIBABA, = // 0x1ded + CXL =3D bindings::PCI_VENDOR_ID_CXL, = // 0x1e98 + TEHUTI =3D bindings::PCI_VENDOR_ID_TEHUTI, = // 0x1fc9 + SUNIX =3D bindings::PCI_VENDOR_ID_SUNIX, = // 0x1fd4 + HINT =3D bindings::PCI_VENDOR_ID_HINT, = // 0x3388 + THREEDLABS =3D bindings::PCI_VENDOR_ID_3DLABS, = // 0x3d3d + NETXEN =3D bindings::PCI_VENDOR_ID_NETXEN, = // 0x4040 + AKS =3D bindings::PCI_VENDOR_ID_AKS, = // 0x416c + WCHCN =3D bindings::PCI_VENDOR_ID_WCHCN, = // 0x4348 + ACCESSIO =3D bindings::PCI_VENDOR_ID_ACCESSIO, = // 0x494f + S3 =3D bindings::PCI_VENDOR_ID_S3, = // 0x5333 + DUNORD =3D bindings::PCI_VENDOR_ID_DUNORD, = // 0x5544 + DCI =3D bindings::PCI_VENDOR_ID_DCI, = // 0x6666 + GLENFLY =3D bindings::PCI_VENDOR_ID_GLENFLY, = // 0x6766 + INTEL =3D bindings::PCI_VENDOR_ID_INTEL, = // 0x8086 + WANGXUN =3D bindings::PCI_VENDOR_ID_WANGXUN, = // 0x8088 + SCALEMP =3D bindings::PCI_VENDOR_ID_SCALEMP, = // 0x8686 + COMPUTONE =3D bindings::PCI_VENDOR_ID_COMPUTONE, = // 0x8e0e + KTI =3D bindings::PCI_VENDOR_ID_KTI, = // 0x8e2e + ADAPTEC =3D bindings::PCI_VENDOR_ID_ADAPTEC, = // 0x9004 + ADAPTEC2 =3D bindings::PCI_VENDOR_ID_ADAPTEC2, = // 0x9005 + HOLTEK =3D bindings::PCI_VENDOR_ID_HOLTEK, = // 0x9412 + NETMOS =3D bindings::PCI_VENDOR_ID_NETMOS, = // 0x9710 + THREECOM_2 =3D bindings::PCI_VENDOR_ID_3COM_2, = // 0xa727 + SOLIDRUN =3D bindings::PCI_VENDOR_ID_SOLIDRUN, = // 0xd063 + DIGIUM =3D bindings::PCI_VENDOR_ID_DIGIUM, = // 0xd161 + TIGERJET =3D bindings::PCI_VENDOR_ID_TIGERJET, = // 0xe159 + XILINX_RME =3D bindings::PCI_VENDOR_ID_XILINX_RME, = // 0xea60 + XEN =3D bindings::PCI_VENDOR_ID_XEN, = // 0x5853 + OCZ =3D bindings::PCI_VENDOR_ID_OCZ, = // 0x1b85 + NCUBE =3D bindings::PCI_VENDOR_ID_NCUBE, = // 0x10ff +} --=20 2.51.0 From nobody Fri Oct 3 18:02:34 2025 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2082.outbound.protection.outlook.com [40.107.100.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04C5B3009E7; Tue, 26 Aug 2025 23:12:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.100.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756249957; cv=fail; b=krkuod3VkRyKSBXX5+TZHiYYR56cuDC/F5yyvfc8RG8eW8vwEuymWGrSzOIMY/DwCjrGk/R9L7ucXUHsOqkWV1Vm0zoXKKq4GMBUSfk5P7kE2qW7JbQNLxG5NdrMZTxdt05Z69lRPoL3ih1sROmTg1f/MpOPKV/DnXnMFVYOdIA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756249957; c=relaxed/simple; bh=1KQAXHwnDQNFYhhVnn0wpTr8ONClJhylYFqvYqtMYCM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=K2nteErRi+xf5uEGSFCRK5A0aHuBvwm7v1k8QeK2GNWTuGF0la5/ymNOuqGrN/5Hm7SkBLIqHG33G+ENeT9vfMUo0Ma6Zzm2rnp1ex6ZLvkoT94C3pAzilnjGBJiQ7z1o485RjcSrhAL9SXPgDHu81RcD2sDmdJd2/gvAQYHcH4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=IGnpB2Ls; arc=fail smtp.client-ip=40.107.100.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="IGnpB2Ls" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Jr0RE3hnm9H1Znz/GaLnaGjngXfKE15jAlksndkt8+hXagx+R8fz12Pl6YIpALkbyY/Mp8Wh94S2TUVMMELRdYVTUxxc5tanbgoRQd3OGK31qGOeS8PbfiuaPjLeWVJQlMALQaY690F4KTHCpJVbQYD8P3LH5k3iS6Z43znkJWhW/8MLlCgbtV0EEdcW40tW92zRlseyKJcoRegwqQh2WgMi6hHg8BSZP6O07QFX2BXYbVeO1J8qFNCp2EQChTeDcC5JKbwVXVkWdGZ35P330R8Nhtx/nJHsdSjJJcy0rmvCpSJ7nGL9+5M+vxymsJaGCDmmhERLSiM8VIi7Dugslw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J7OQ2sik0c99Pqy+Et94x01yXzL/u9SyfUJEEjE81FM=; b=mws2zjwpWB1jon3rJbJzspJS+XYSU6efDmGx1S3hYl34DTIjkXL3+woAFWrmLXVGCXRnBj1VAa8xI34dR4iiSHtk00b4sfS41MkkdJ1K5+gyBnmDarmjFfHBmdmG1OajKyrkkt8VG2axcVWW8abSorB7+ORtEwX+fmO0tNMz4fmRBEsB6I+dSgq+ifPjhKWXrxRob7JpPGbPBO060g9us4FAkM1J1GYfBMMiiNDVPNtHJ70WwqXRpNvXNUgWKSppmrQSApCZbW6no0/GHqmvwgdJvKifTe8SAvzyY/IqmZ5M755efoj2l6tb1Zwo+MXWloW1bcCTg2vEjmnggeMIaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J7OQ2sik0c99Pqy+Et94x01yXzL/u9SyfUJEEjE81FM=; b=IGnpB2Ls2vy4CGtoRfMDyDRO06LAG/jj/skV0wCgVTg/rjzQ/mvmGm0Q/S4FSjXk/BPLD47GDskCfJ529Kyjo4gL8dwf2v+ZbnRv2VeDy8Z1AcrA74y+voE5WBR6cY4f3iE97YQ8SduqgN74EPhRin2qpL3ozmrb9kC3S63CPFcDmB4TK5vwtGNKZLcM3oksZv47U8osq7VhhnxRNwAQngYjBG3T67KKr0abpRquhYj7o2Z2UNU83YQ3X8Evh0G/hJqgfirlTriBcv187Twx3Cq/PseQJWYZdT7FFG0QL3yfov4Wzpm1q4WC9ema0c/ImeYWaGdpfZTHd0KOm7CmOQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) by PH7PR12MB7913.namprd12.prod.outlook.com (2603:10b6:510:27b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.13; Tue, 26 Aug 2025 23:12:33 +0000 Received: from LV2PR12MB5968.namprd12.prod.outlook.com ([fe80::e6dd:1206:6677:f9c4]) by LV2PR12MB5968.namprd12.prod.outlook.com ([fe80::e6dd:1206:6677:f9c4%6]) with mapi id 15.20.9073.010; Tue, 26 Aug 2025 23:12:33 +0000 From: John Hubbard To: Danilo Krummrich Cc: Alexandre Courbot , Joel Fernandes , Timur Tabi , Alistair Popple , David Airlie , Simona Vetter , Bjorn Helgaas , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , nouveau@lists.freedesktop.org, linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, LKML , John Hubbard , Elle Rhumsaa Subject: [PATCH v7 3/6] rust: pci: add DeviceId::from_class_and_vendor() method Date: Tue, 26 Aug 2025 16:12:21 -0700 Message-ID: <20250826231224.1241349-4-jhubbard@nvidia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826231224.1241349-1-jhubbard@nvidia.com> References: <20250826231224.1241349-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BYAPR07CA0088.namprd07.prod.outlook.com (2603:10b6:a03:12b::29) To LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5968:EE_|PH7PR12MB7913:EE_ X-MS-Office365-Filtering-Correlation-Id: 76f69370-ecd1-4b87-1e3d-08dde4f60973 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?aPVqGuaRwG+Dp4SdCrHCMJ8REU3qPBShZava7QmcfU3tT59BFpP6+frE0T+n?= =?us-ascii?Q?ts1UYAq6PAKueBaQMe1TY081dHJmtRmFBOM6aQ7kqPZqQAU9kkdTA039DmYO?= =?us-ascii?Q?56niUkd9lh8p0UhYOWja/CNHyD7tHoxmgBMXT8wi+cBp4SCKLDyeJUNgxbfL?= =?us-ascii?Q?O8h7+/h7HpPG5AK458gbqR2PyRcgHigIJWhMJOa76ELGu/N1NHIKAZhqws95?= =?us-ascii?Q?OoPkfWaCvSG9udcwaYI1vA12ljcoEn8UO4xBchGSPfkGKWYyWQks7vTit0//?= =?us-ascii?Q?qIyWd5QnNNQ31R5pyAle7fvsBxBphBLaM7Fg/X2C512x1kypmchr6Pm9zAky?= =?us-ascii?Q?Vl9PWsXQqQ0HioSOv9a+vs2AjiV+YMVEot9IZy0IKYTxY5HVVU4TXHoJXR2i?= =?us-ascii?Q?GmsR+u9sntkSfxwMcJBFIRNACIB2tYC9wRZY2iN+d4s33fgpfIHA7ryyuct0?= =?us-ascii?Q?e4vonogxb2xTV7VA8BlcMgGqSax6BDlHZq7z7df6GeF9MxGBH4GIt3tHSZyO?= =?us-ascii?Q?l4cJrJ7M7uIyUQxlC9pM4qFXooG1jUQlQ5NM4ggtaLDALcaJg24chljwzXvE?= =?us-ascii?Q?Tth7+yyQ0G6wAjLO9+n1vFiwejFd8s/HKCEAANxFrLenxJAKgWyYkIWszGv3?= =?us-ascii?Q?jl3HvBgbWSly0eA09n+4+vJHE/6bdp0SO8E97VAk5p0k97raeTFp9yYvimVW?= =?us-ascii?Q?bZR/bLGrbvX0aJcrTDv75C4c4M6j2E8TDeP9cz/wFv/HjQMAe3RQBHhYyKdC?= =?us-ascii?Q?kcbRALFjdsqPu67qIdHnS1nvT5oEN4r5XjgjDI3KuUp3uG37WQ4Z09aC0AH6?= =?us-ascii?Q?6FzTbwr1zT20v0RWb25P7w9XfuwNiLRLccVoGTNcujg/nl9+y1BLvrkVeapr?= =?us-ascii?Q?eDqEI7rzn2OncRK8mABgerjotGaqiQoYdbS3X0OE+opc8Ga9Ix16S6WJD90I?= =?us-ascii?Q?ARINVIeD57A4wH00BjjgkHZXkDRSw4psimVEZZz8//s2LXe4YbpaUHvzcIgY?= =?us-ascii?Q?GjZKSUbgCYuhXbOgzbAuxm0PcGw8SbmYfcxsTYnl4YEkcl45y4a1nYSzZ9Ta?= =?us-ascii?Q?8CYT6U8LdZY3YrlcWEIGX38LhbMdhqdyvxexjD/yXlwrMqcaEYppz6yK4tT9?= =?us-ascii?Q?Ln9v4ZR8nWTUGctZak+fRWAEdeMlrhJgYuUbThvzhjgRQC5ojrDqQA98+Gd9?= =?us-ascii?Q?N4+wJ7it0aKQE++OnSMRcdkpQW15HWkHKnA6wrbx2GTbyFM6S9g6f5BHl160?= =?us-ascii?Q?tKgUPS6y+wSe1+7Mq8AvWaeYGMC8d1wNAjhS8S9ZFpqJUBiCzWWYicL3PRjz?= =?us-ascii?Q?nalpcpfJixzTOe4bAlVFkHUhrphW7FLA7HZHwGe5Yr6bZmggXHau5MQ5bnOI?= =?us-ascii?Q?RVMjxmkQEBJ/neHB9JVcGpCgYdVupb343DNF8OLh5q+febkx9rO9vZjKHdpw?= =?us-ascii?Q?jnYj/WkF4+Y=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5968.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?I6HsiPMOMHKUnTI3k9IcfNpg3J3Me375psLYEG6YlFkTEe0py7OSi2ilYisR?= =?us-ascii?Q?chJ0eLqLC+iZejq5KrTrCeycGCy0jyLD6LaUgsFazPhqRs4rogSmM99YFs8o?= =?us-ascii?Q?CJ+RgtevgAt8RqZoz9dikseUJvoK1Z4JFfr2clhUJVdJTf4de/M6rJvoMxSU?= =?us-ascii?Q?k1gK5FZv9pJqRGEcKbxlL+yuCDmT8wCbJhhCc7BNPb8RWJ4+JnpmNnRVRX4t?= =?us-ascii?Q?MxTOrpE8d2kpL1AkSXrUyJefou0GqLPpt9umjPmbOBshXHQVGqIkShxwFxwE?= =?us-ascii?Q?qeVnez4Si90vKsWsB8Cuukkj5jFSXJRPGg7eSTgWY5L/t7PtD1upqH6mYd4a?= =?us-ascii?Q?mvlTkCl7lM1bAiWAjg6VoKrl6NaIvK5OjhwzD/MtRymRYHP3nf2o6HYSN/ge?= =?us-ascii?Q?Zgo+FapHZZ2O08bQjRhmI0vxYzK4IanRGEN9op49myrdRbyhPdgoIJuyDjSZ?= =?us-ascii?Q?X2fQi2spsMXwYDRd2XtlTxDr5PB06jGRTJ/6eWnIjEhKByNX7T+11anLerRS?= =?us-ascii?Q?lS948rqruOGrZQn315Vpde7I9Y28AnHXV3Kgld8oPPb3ZB6DfRWP6FW5eQ1q?= =?us-ascii?Q?1LMmLZtSNjU7tZsKCOLnvwNRPV7mKmmb5w+fjcSv7VXSuRfMHMP71BD8Ey1g?= =?us-ascii?Q?S5X/0m3HoRurSNZmTsIr+HAUjscWrwHdpJuWdoQ7kn1zRpHtd/QFTBt+nP2q?= =?us-ascii?Q?Nxbxq8I6kVpP3JJBdVyf/0hp/DlMTcwVwKtIL43jufilNEFa9Aqj6GGuXmKo?= =?us-ascii?Q?ib8YGh9V4Rq4PBxYhOdB2YW+UNyOkQy0wNRy9V9ZZvRQ0ycdqusKujzgAxxK?= =?us-ascii?Q?6MpNUY4H53ucJP7c72wZZBuHGJo/ZMCVJb0NWZaVVki6bz+3RacNWd0GBHLl?= =?us-ascii?Q?oZdmqYx4f5HfWjfTYwxCmg6++JFYN3YORIVkCqLW5nPIVnCd3emPhHDlG+nS?= =?us-ascii?Q?EEymjC7wKAtF4xCBJ22mygvL3aBgt9vLb6X5B/hmc/zwQXMN1D3GgC2kozmP?= =?us-ascii?Q?5bdbZU7oMUKiBRvdeoc4l899UWMIJEuMwUaSRfh4mOgo63m9Y1K9bCvkFAfc?= =?us-ascii?Q?QzgTW98AUQau0eyoF8vEceZn+1XQa7xaPxqNrZ74NbkTsY/tZ1Rb7CiCcQvQ?= =?us-ascii?Q?vv6Mh0z99H7cxmpqfDFWoPJu4oC6J9yOVLXYeinbVWiyHWdoJ5CflY1gs+h4?= =?us-ascii?Q?oH2sH+SE8ZUMJ3eGO/MlSDjIqKMyrl3tOYxsa1XlL2/HuLw/Dpot+QjDpzlZ?= =?us-ascii?Q?iCAHUkawMtx9N3b/x1xQSgeHB6c2u1Ho2x+V0IYI1ab4d5Da251HJwMp+Yp8?= =?us-ascii?Q?e9Hk359jkJJdsQTmZCgLpo8GtRAYt0jiieR4Qf/TS2fy9R2UlM8EO73p4GFf?= =?us-ascii?Q?gSf4gBhbGE7qlD5aT0lzgYSX25RNcaS0Y8SF2k8s7Fg31ONbpUQVcuPDC95F?= =?us-ascii?Q?PmAnkO1riHjktamsidKHUydqraNcW29WEm+pzMg2E8qf3NXuAvu31kqaKDS/?= =?us-ascii?Q?BWHmZqqe41JN2Waaz4IgnnbwQLGPVy4Q/EAPmrnGjSPdCmqu8haYwbkoAtdz?= =?us-ascii?Q?Eumtbc6f34xLwZiznC0NTFScx/e8d/To340e2y3P?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76f69370-ecd1-4b87-1e3d-08dde4f60973 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5968.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2025 23:12:32.9707 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RU77q1c2L1sbbESqyI56OsqD3uQqkBq84MgtM1OPS4wDY+IAyAnCVU3ksv7wR5IQAx4r0XQC0uZ0H6j6m77iww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7913 Content-Type: text/plain; charset="utf-8" Add a new method to create PCI DeviceIds that match both a specific vendor and PCI class. This is more targeted than the existing from_class() method as it filters on both vendor and class criteria. Cc: Danilo Krummrich Cc: Alexandre Courbot Cc: Elle Rhumsaa Signed-off-by: John Hubbard Reviewed-by: Alexandre Courbot --- rust/kernel/pci.rs | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs index f15cfd0e76d9..26974cae4a22 100644 --- a/rust/kernel/pci.rs +++ b/rust/kernel/pci.rs @@ -161,6 +161,28 @@ pub const fn from_class(class: u32, class_mask: u32) -= > Self { override_only: 0, }) } + + /// Create a new `pci::DeviceId` from a class number, mask, and specif= ic vendor. + /// + /// This is more targeted than [`DeviceId::from_class`]: in addition t= o matching by Vendor, it + /// also matches the PCI Class (up to the entire 24 bits, depending on= the mask). + #[inline] + pub const fn from_class_and_vendor( + class: Class, + class_mask: ClassMask, + vendor: Vendor, + ) -> Self { + Self(bindings::pci_device_id { + vendor: vendor.as_raw() as u32, + device: DeviceId::PCI_ANY_ID, + subvendor: DeviceId::PCI_ANY_ID, + subdevice: DeviceId::PCI_ANY_ID, + class: class.as_raw(), + class_mask: class_mask.as_raw(), + driver_data: 0, + override_only: 0, + }) + } } =20 // SAFETY: `DeviceId` is a `#[repr(transparent)]` wrapper of `pci_device_i= d` and does not add --=20 2.51.0 From nobody Fri Oct 3 18:02:34 2025 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2082.outbound.protection.outlook.com [40.107.100.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF75F301466; Tue, 26 Aug 2025 23:12:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.100.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756249959; cv=fail; b=hYnLBcB0qVTFolKHmzmjxtk0XuyJyTgzqyAcsnOrqZJQWnKTkqs3ADNTukWToRZMFjv5eErfTHAUjLn7LNlGEYysXll9gCEJvBmXw+aCNpkS3qMmL1UOgMHweTkhoPp6B5dWBLa/BBgzc77/lRdSlkAIbHagG/w/2kPbEGOoLIU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756249959; c=relaxed/simple; bh=khDQw2moEMjqFviEp8B0aXXXCfsJvxaawghGP0Sl9LQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=kcutp6loHtMGIkpf1PHzR7I95MhUrpT65ut1UjxkD1QFJ2UFMl+iAu+G8pQ3/DfaXVZP3IsJZPnqsIGSS7+mNxvtxArqVf0erGYoaIytB+ZoDwy0XeSeKEL/s4oz0wno1vPHcOl6VQHI+4rnR3S9JCjhWgNKTGWvdDxB0O5yvFY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ncXPlWrW; arc=fail smtp.client-ip=40.107.100.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ncXPlWrW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gaWAvSswzRSqoX3BppFGr/6e4BJRsIyZk4NXRKdR3ZDutY0DYbliByKUY7TZFLYLWpSI5+oXG6Hzct9i6LeNBNwIcj67q2BEbKwev5GqtO1CHzqRd/sDSxOD6tr6VbSHDwy0187ZNjg6bKPK8YjTF8AIBHWp5ROvdY7gJr21urVTEGk2ZtM7k/Tww/T38Oqy/J/SRmXFkIijo3X7shxIXQ5VpnkTjeznZnaLjX86oMjydk4SkxMzV1wxLXDhdQzq1UYwI0sZ2JNqjb6G8HSqpXmseSZ8R0HpIvHqJ+FBK2AjuSnzNcB/t4txTG4uQROUhcYtvftwJV5bLRNoMMDySw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c0KlkMAZs8cCIGfnJcfwgPgyRKzpxVoAHdzShyrFt6Q=; b=J2NGCPKjAsdKsCPra0UYbKFPvYipApHrqK5wDKWsidpGanYYuaQ1eMHrpot92KHBZgHD72OMbCR+K0pUsuaFWWxfBq7sbzQHF1ekV1A4TEjKxyfIasF4B9HRWVlcEovRLdHZF0tUy73iV0rHMN0ily3Kpbbai5kHxT40kvx28vLHb7oHrOdUbosTi5vIzw3cg2Ju1GDITRQ+lIjHiuMJfZfVxN1raUs+ZZ7k534XnWGSC5zDRFDHxojzpE43ou96MiHBujmhag2U+sPoqxEpe5GgOla8+22diWJFHROKm6vVs2zL/njWhjh27fonrlpVoZjFjghSQ+1VGYoD1wB0Rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c0KlkMAZs8cCIGfnJcfwgPgyRKzpxVoAHdzShyrFt6Q=; b=ncXPlWrW9L26rKbtel2ei5/cgBFE6TreME6ePO6o2Qlg9/nLkHeXliHoWL2hkvj7/claVz2rI+u64rcQpBERhaW41L5gVcYTBvs1Wcxe2TZh29s3CAgrxDnIlG/Gxxb0lO9GH4j3hII9IP0VZYIhFbJycVsPZIkt+ov5yUkXAITPqbYXLizTdJDj8ZMBgnoX6VTSvFV/57CiYQLnacSISIQyCiG1HpmXMHvKDYOF/eYr0Wz0Oj/O5gHvT+mUACePSwbQSl6FZoR1kdT5AWwF+w8JJQeWFLxw5bXqD+g6d7jkNf7MNi77Bz7FmHi9I2VqqNQhnh/ni36AGtO+MZyZNg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) by PH7PR12MB7913.namprd12.prod.outlook.com (2603:10b6:510:27b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.13; Tue, 26 Aug 2025 23:12:35 +0000 Received: from LV2PR12MB5968.namprd12.prod.outlook.com ([fe80::e6dd:1206:6677:f9c4]) by LV2PR12MB5968.namprd12.prod.outlook.com ([fe80::e6dd:1206:6677:f9c4%6]) with mapi id 15.20.9073.010; Tue, 26 Aug 2025 23:12:34 +0000 From: John Hubbard To: Danilo Krummrich Cc: Alexandre Courbot , Joel Fernandes , Timur Tabi , Alistair Popple , David Airlie , Simona Vetter , Bjorn Helgaas , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , nouveau@lists.freedesktop.org, linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, LKML , John Hubbard , Elle Rhumsaa Subject: [PATCH v7 4/6] gpu: nova-core: avoid probing non-display/compute PCI functions Date: Tue, 26 Aug 2025 16:12:22 -0700 Message-ID: <20250826231224.1241349-5-jhubbard@nvidia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826231224.1241349-1-jhubbard@nvidia.com> References: <20250826231224.1241349-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BYAPR07CA0017.namprd07.prod.outlook.com (2603:10b6:a02:bc::30) To LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5968:EE_|PH7PR12MB7913:EE_ X-MS-Office365-Filtering-Correlation-Id: e74a05ea-95f3-499d-b039-08dde4f60a87 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?691vzTZBA5wUA5TkflOp2G777IO0SPa+xQcUBFtC0yEWSKYbTVRyLevDvD50?= =?us-ascii?Q?dP10P57NBrX7IWwcB/uOXFXcZxhnfxTDjOpjEYFDEmsg57ggVzjdPUwh7uT3?= =?us-ascii?Q?eeZ4sea3g7+497+A+KesJq7KKiRzJG+tJEwTDtVZD7ithSiumrFZuEquzHHp?= =?us-ascii?Q?dse4/zAMLA8/B9e8F4AIP79PD1JIw+HWF76hxAHFPtWfo7mUDhkfBqbf/U8f?= =?us-ascii?Q?s7jF9ZXYDOwsRozjJ15cLK3C2/gWMvwzaPef2yqm9D2DZttBnVfQu9qyYocf?= =?us-ascii?Q?k9NlzGXsUm5hhbBM4v9KGUbX/F44TWG2rE6yeL7DyIMRtVKAYXsfNxcrCqoK?= =?us-ascii?Q?fgP25fKQJRcUMWczXzBOTyDx1jh675jt37AuP62f+P8GkkcTDa7crGKAD5Cp?= =?us-ascii?Q?YTg3uPvZ7z0dbj34i7ditHpXHF69DBsoPX/AAwi9AudLB7xSMxZA8HCnJHoz?= =?us-ascii?Q?NTXRdaRXtiHWvN0x7HO01d3KL+8CPiNb60yzeZSUijTYZo9KiqO3LSldEWCN?= =?us-ascii?Q?eHUog885kniLbM1AqhH46hxvSUb19wfzbXkQbW2l+JIgxKWX9zSV3yMF33O+?= =?us-ascii?Q?LHqEzo4maV+q18CSsNdK+Vim3vgvHmZc3YrFFrPLSYXIyV8aLAJhFx87sv9+?= =?us-ascii?Q?NRPxfCenDJzkzO2zffU5PvUKijGZWAloepdJgKsqqf/wmmV18g1w1UFGSUsc?= =?us-ascii?Q?k6D/0C/UeXyI8Fb6NvSGbbC9d/ANA3z5wObiXOxk73uM6TrK1CuVk+yZEopi?= =?us-ascii?Q?4o9akHqE12EwQh3ihT/wkyUBMzpjCm56FTEZbbaAhMrNL9iPTv0I61EhDylY?= =?us-ascii?Q?cML1wpaZQDt7ZL1l2cFZ0byJYJqOcKg8UhN8jxM6RuuCLyDouO1wdzu2RiRo?= =?us-ascii?Q?NF1wLrEtyrUvF/ngnrw8h2Tw5uilqsr50Iy/DspcVfDxQtr6rPgTX5UL3k7x?= =?us-ascii?Q?9hFDtscsgkZ8VhBv5tvDeQL/jwEd37GrSNWb+HMDzv/4kqggd4SevlX/1bPR?= =?us-ascii?Q?OKGUZjLTDAb3iiFfhdHkcJOeVXOmMDs1h7XqiIdNvfg+J8vFwIUkfR7acT/8?= =?us-ascii?Q?Fgw68vTDFB8AZGEI7WaWUg/WwHOV/tl161xR8hjkS7DXX4LzvObwg8Ox9OB5?= =?us-ascii?Q?a7VSyaq56Fjedjti8ie6+k5eP3351k4i52ENuzhFemXh2mBZatqIliAZzDHZ?= =?us-ascii?Q?eoXsl3CZzhYiscocz5EcYVR2Gtgn5WouoNfOQuDuZJf6hyJb1iHRXtULmYJo?= =?us-ascii?Q?3j7LvBpjJSwCrxeI4/2d+KxNrZxCqLZtVtHnwoyLOBIW/c+HIyX52B7bP87W?= =?us-ascii?Q?yDQpMA6INi1AkZr3l1deVUcfqPoHgGYx34dgwjq+tK0klv9Umo7cJrmkosuA?= =?us-ascii?Q?F96LVxIMLaYZZ7bbfvi7oje+V+sjmYOPnJ1R0SPshVTmnExYo2A0YT84KxRn?= =?us-ascii?Q?ka7a288lvmo=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5968.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9jkmGadGg14x65R2F8qB3dML9APVZ4maCNFklwhoAMwe+k3/H4TaU2FYyPRI?= =?us-ascii?Q?4U4Mgcj1WdO66Uq2swKpd1+6DPnLbOoDRdHAAmR1Aja9SfGkooZqXHgiNY7B?= =?us-ascii?Q?RH7RGWJtdVZ9+iJpfvc685QvrvPezlK2MdGoygIWA080CvXKDLhHNnz+quPv?= =?us-ascii?Q?cWLxCeUE1HZ4BV0aQsl/JNXARV5cavflYbztv3gL+nWZ4KIe8aeeSpC3HWQt?= =?us-ascii?Q?qJs69X2sRFMgH/QNb8qyeuJrpqfVlUAVkKttYcqDQDTjqgMbAZKbRSK7l616?= =?us-ascii?Q?ctlsVoXvcAgyktbwJAAZUztdu4gsLwxVWaXQzqHyfQgKbEBOo6D4FZSuvjgQ?= =?us-ascii?Q?FW5XqNX1cBAw07bLgz2LPnxbg7izD3a4y8N+OhSGYBfBgKSzwruMhKJSjUpa?= =?us-ascii?Q?3slJYT/IQcxN4N/C6z0XsMv773g91o+JTt0m0UTVVe2sFBBlRGSce8v+TqEp?= =?us-ascii?Q?3vdSBkepv2uSOf+ZXPkGaaA1huIOQFPpSGa/Z3c40ExJMfbiaINqnmcr80+6?= =?us-ascii?Q?K8r4dd4lPBR7HG4y0bgeWq7dSGQ2aIU5DBtlHnzFZmEyyJ6a3zlLHSfBegMX?= =?us-ascii?Q?QoAZcIRqMUPRkF2N2VUM2idXEiXIetyO6moTimrHDkfJNL6KigpAVQKL1BaO?= =?us-ascii?Q?03e7JHOmT855hzgQRPKcycwxWXSnDTti3Ki53JMbio5aaUaRwClw08NFI2Ve?= =?us-ascii?Q?XyLpoxkZjO+iZb8LBEm4bPPjBTeyLiDTCCDKtBieyQLW0gJxE0yUo0mTpY77?= =?us-ascii?Q?quKUroq4SrZptx8uP0ktpN05sy4kQ0A6XPgrhgI01/dKi6GRJHOwPa36E5hU?= =?us-ascii?Q?+LZGskhVP2HMh3uG2m/Rls/DCB7VTBcVTYcq0eaRAXG1If8zOjBKThGu82kq?= =?us-ascii?Q?JnVoy4ZOT6pHA7n6kVP2JdkmdpNFb2cPojYrWL/Zi9Hqu5oDGqwwWX5lrByp?= =?us-ascii?Q?0+9i5IR4wIPp0QqhD2x2kY+nqiBPJWcfZwzVu7jLvjaGIVsCu++SPiLVVhpd?= =?us-ascii?Q?Cnz7SxZ3lONsoJxh6uVMdn9s5oFlysh3qEfAkhFWedj3w+SwtJ8NwCWTZwYn?= =?us-ascii?Q?Ib8WeGVe6wffT84DrlB8kgakvmXoOFrmUv0Sw2zmgrDlTn5TJQ9o3SRN93st?= =?us-ascii?Q?Errb6pVGeNeemoF8Xj0xd5AuFSjHTbwvAd1ZhlN4pmzZC5BJer+aSGCeiPl9?= =?us-ascii?Q?lNCHBCfSv92ij3AEDjmB2Yq+XCrm6PTf7miZjpW19NSsLegWv0HgHQR++Enm?= =?us-ascii?Q?HznGAmyCYNUYCNWHLlgmf5zSaQ/HLEFMO1oMyrUkQ6RXitl5IotLrXAsskwv?= =?us-ascii?Q?9mzl76i3N+VunGHs6yG1Mn+26iM0mk8tikJllY7MfpJ4NeJsaxT6ZpkYM/r+?= =?us-ascii?Q?DyuRN9HAkBgHvE6SdO9aJ6j7w9Z/ETYRNHV4B0ihkThKkNTaNBuXr9kQ9eip?= =?us-ascii?Q?Wm/wt1hr4YIRVjYdOCO28WpQmS2vhqn/ZWBejYGi8cT/5Y6DK9KXkH363qwR?= =?us-ascii?Q?FaDsX6FQHySuDGIS3vVI1PbnoJ4P2hTy10HizWyfDPsd1VOBTn8C52Saj/7m?= =?us-ascii?Q?9NomEjK5ksy5Ph7WNAtvYqbm5g1VP6fEx7597bcJ?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: e74a05ea-95f3-499d-b039-08dde4f60a87 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5968.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2025 23:12:34.8284 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bVa6v4XGpWUXTki1mCuedkA7KP59A3sRBvLcTJDn+0kx/l0zhGPJjUp9HKJDU2WNfURvMtiIFFh/09/dARXGxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7913 Content-Type: text/plain; charset="utf-8" NovaCore has so far been too imprecise about figuring out if .probe() has found a supported PCI PF (Physical Function). By that I mean: .probe() sets up BAR0 (which involves a lot of very careful devres and Device details behind the scenes). And then if it is dealing with a non-supported device such as the .1 audio PF on many GPUs, it fails out due to an unexpected BAR0 size. We have been fortunate that the BAR0 sizes are different. Really, we should be filtering on PCI class ID instead. These days I think we can confidently pick out Nova's supported PF's via PCI class ID. And if not, then we'll revisit. The approach here is to filter on "Display VGA" or "Display 3D", which is how PCI class IDs express "this is a modern GPU's PF". Cc: Danilo Krummrich Cc: Alexandre Courbot Cc: Elle Rhumsaa Signed-off-by: John Hubbard Reviewed-by: Alexandre Courbot --- drivers/gpu/nova-core/driver.rs | 33 ++++++++++++++++++++++++++++----- 1 file changed, 28 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/nova-core/driver.rs b/drivers/gpu/nova-core/driver= .rs index 274989ea1fb4..5d23a91f51dd 100644 --- a/drivers/gpu/nova-core/driver.rs +++ b/drivers/gpu/nova-core/driver.rs @@ -1,6 +1,14 @@ // SPDX-License-Identifier: GPL-2.0 =20 -use kernel::{auxiliary, bindings, c_str, device::Core, pci, prelude::*, si= zes::SZ_16M, sync::Arc}; +use kernel::{ + auxiliary, c_str, + device::Core, + pci, + pci::{Class, ClassMask, Vendor}, + prelude::*, + sizes::SZ_16M, + sync::Arc, +}; =20 use crate::gpu::Gpu; =20 @@ -18,10 +26,25 @@ pub(crate) struct NovaCore { PCI_TABLE, MODULE_PCI_TABLE, ::IdInfo, - [( - pci::DeviceId::from_id(bindings::PCI_VENDOR_ID_NVIDIA, bindings::P= CI_ANY_ID as u32), - () - )] + [ + // Modern NVIDIA GPUs will show up as either VGA or 3D controllers. + ( + pci::DeviceId::from_class_and_vendor( + Class::DISPLAY_VGA, + ClassMask::ClassSubclass, + Vendor::NVIDIA + ), + () + ), + ( + pci::DeviceId::from_class_and_vendor( + Class::DISPLAY_3D, + ClassMask::ClassSubclass, + Vendor::NVIDIA + ), + () + ), + ] ); =20 impl pci::Driver for NovaCore { --=20 2.51.0 From nobody Fri Oct 3 18:02:34 2025 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2082.outbound.protection.outlook.com [40.107.100.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1976F303C94; Tue, 26 Aug 2025 23:12:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.100.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756249963; cv=fail; b=NyeWA/PWJ5txvrReu8ww9GShdQIgrmorMFvWfPFTfuFH9FRFlUq5H3+cuu1pdmJ5H+h5zgn9Qcoe4Yg9rhHRMl2Nbec47ItkPPUxqcnWS6F4VShT/kY4YI/1P5h42sXc8emUe6w4fDOv5+eD8+dPPDo8yg0V4a9UtwA8pmNuv/A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756249963; c=relaxed/simple; bh=SR6+PuZJEUBND4pWPc43lDHObweirmQFiK3YprZho6c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=aCUABWGv2bnLPLbIZojASkUcFwlGWC8F62ozzpArmrc2kXp21UR3bj4PXxbLoa40n9JokOkLHsLjgl7DqtAaRivTEpNGETbTCtcuwpCw/Lrz7VLyGzUHiALY61S6eoRJxWdgXVguxHw3NlpurIIKXUxp+JBHbA1OKWWdDjmC01A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=A9rqcHCR; arc=fail smtp.client-ip=40.107.100.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="A9rqcHCR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Wr27Ttm269hMi/8mM/aad6Gev0HasnVH/lntKvMLi7We+ncdQ1eV2WvkF7hUCnSqaVYn7+U/eZHYGZ5DFq4btUfdtupMmu2F9QfkdsTb7WdWTCHhF3jFZ+1/sLR1ysYyYkX74aG81ZRMsDldxkS4yrdQjSopGpI+sz1ZtlOS6L8mw/jLst4W1PgyLByv7G5TSXth9JFcCST9OjhInAhN235auG1IZAXlpAttAV4kyUxQ+x+xNWvC4SlMX/DumzBTyHOPEHLz0Ojup9EId0yTNGexk1gwKhBlcHns43y8N+Ee+YfIQCKKieH86xK5YmC8FSDlqf7mQDxWJELz7mbivw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lt+iICwSSGL53KdpNeOwx+kA98lmP9pHkMhZoHkIx8M=; b=cM2KwFhIYqLVrD1z5AH0cWjnpTfdbZ8S0Efy4zycSRIItWl+rTZb2dgShhqnA3lwTdZZ64Y1DSdzw8yr9SQVS7jic0vhSQa9I1nygiAEgio/ghKuJRPMq/m6HjrbYLHmVQ9KsVRYhdfRp0nR1JjkFgGiBopZ3vWyC1kjb4tG/7nYyIaPmikCoR5kFLJgvH+3T0qcpbcvBEtRzToNgq22SRERFhrjKADbi2ARlOEKUKgHBcFWi7F4aGZWaYHBMAUD1FyRVcOCZSeuVKCMrD8iP0rF0vdAbRO706pSkjMFPFms6eRyi9oHhcsdH2zQLypsOyrpaDJiHSOHfwkYQFrPBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lt+iICwSSGL53KdpNeOwx+kA98lmP9pHkMhZoHkIx8M=; b=A9rqcHCRuSfYq4oTNOCGEahOb/4TAPyZBcimlR3cPMSF6EMYl02esTCI+XHNnCJUar7lospwfyP6NU8dsPv2h6/3XDYBZ3MBPIPIqJUgIPSe1uv7BDIFvnRP+S/e48vH21KWgQiGhh2WBmAOassmuNZEbkQ2/IYX0qVBGUgzKaCNunO+mID6Ok870PO9cVtzpkDMumlCK1F43pI/YlKxp3TapqE7cjMYrmqGROpXf0AkRGWHFU8eFl8LWJGEIzZMOQxFDvTqHhl2c8KY6fdSolwPvuCJ1n5XK0z5YU9LTS9MTVFwll7Uj6eg7DN4931c5FyAhwssFZamy142dXS+Ag== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) by PH7PR12MB7913.namprd12.prod.outlook.com (2603:10b6:510:27b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.13; Tue, 26 Aug 2025 23:12:36 +0000 Received: from LV2PR12MB5968.namprd12.prod.outlook.com ([fe80::e6dd:1206:6677:f9c4]) by LV2PR12MB5968.namprd12.prod.outlook.com ([fe80::e6dd:1206:6677:f9c4%6]) with mapi id 15.20.9073.010; Tue, 26 Aug 2025 23:12:36 +0000 From: John Hubbard To: Danilo Krummrich Cc: Alexandre Courbot , Joel Fernandes , Timur Tabi , Alistair Popple , David Airlie , Simona Vetter , Bjorn Helgaas , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , nouveau@lists.freedesktop.org, linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, LKML , John Hubbard , Elle Rhumsaa Subject: [PATCH v7 5/6] rust: pci: use pci::Vendor instead of bindings::PCI_VENDOR_ID_* Date: Tue, 26 Aug 2025 16:12:23 -0700 Message-ID: <20250826231224.1241349-6-jhubbard@nvidia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826231224.1241349-1-jhubbard@nvidia.com> References: <20250826231224.1241349-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BYAPR07CA0090.namprd07.prod.outlook.com (2603:10b6:a03:12b::31) To LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5968:EE_|PH7PR12MB7913:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f42589a-3bc2-4666-cca1-08dde4f60ba2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4yajm+ahb1duTA1RMN60cIbjDO7NGKVNnuW0RyKEJdYAk+he9tIACKSiX1bP?= =?us-ascii?Q?2HqpsJcz3oy8zcO4bJzemC7XI+T/o+jnSfKHgygkrW9qaUt4jLLeP73FqNgi?= =?us-ascii?Q?8VNlnX06md9ZwTJmo8GlN3bxio8WhfSDv2DgpbMiTPZ0B/Fjv0bL/9a5jTWS?= =?us-ascii?Q?kBkeVWshrAf6n9ntB3jZ57RE3e+1hUqI1qGL9FzgASZGO0rLZC04uD22xLWB?= =?us-ascii?Q?7Deg1E0oa6GnQkSsmbUjVmobzUfkJp83yVjpHuX6/XHpgrltaZG37yFZaI7Y?= =?us-ascii?Q?jJoxbKbI13Ug3igmCpZir4s5RM0oeqXjWtdnxWm/14hFcyv4ErTlgJIjz4Cs?= =?us-ascii?Q?tjHS60TzWYrC2nxktgWruF+vVPzIiDt6mjvjL9m2KurcNonqVPwCHXhGLJKn?= =?us-ascii?Q?zEm+IXls9jUg33r2mu/gziyPMaDZDRk36xZ2ALDyoChrUAeB9hz32yRTNcAl?= =?us-ascii?Q?ybrUgINScM1R18BJEDoq2ljTBIN7VM2FcbbGaVxnF4+z/BwvFT0ksh0UyDLt?= =?us-ascii?Q?LQBHiFRdckDcCY28ulWmVigR2lJLHAXboRxBOmSpks4Xexrs5V+zR4rZ9mhQ?= =?us-ascii?Q?7U5icZgVt7G7OzTtZ5u8ifuKwkFiaaPkoF68eJlfkZP6VgttIuG0Rf3XW2UW?= =?us-ascii?Q?ONp5erZMhrQImz5ruWmts4xoiHsPgYd9w9bXQLty9oGYgUWpmFR9AcgQkwBj?= =?us-ascii?Q?EzVtMsTpR/SUB2/kuWL1s4r6XG9pn1Zn+LeoP5NRrYAriByocJ6KY0mIBoOh?= =?us-ascii?Q?wrgsFnBhc/UPbpaZdAh6+xevWGkVJCdAR9atxd8SIa+T3GGTGRyUPMAuJGSp?= =?us-ascii?Q?6xplEjOh9bx92V1j3D27iOoHvOWrPLYLNKQoOuNvX0/fhw55bgNNj3vufCcb?= =?us-ascii?Q?clWy26no/s9qfYRCycMQpZRG3CLF5M3ZlmlqueznC/Cm6Jx+CE0YMap4gMWB?= =?us-ascii?Q?MF4JmbGnUrw0x4sj9nwvz0baYn1xrkIV9viT7qpKirf3FKZUoFyGI4mteyzM?= =?us-ascii?Q?6HlH61AQAmQG5e5RYWiwX/Ayl3eFNybJjSxZzeLX6nH0gUeaicZl+Dz6mXpw?= =?us-ascii?Q?4Im357ACD++13UmNYU/axJ89L0XEMYIxVQaX7nzYA2qFo1FWysfcFoAybP2E?= =?us-ascii?Q?PbuB7ANrR2y5nIed/6P96w8LVJQxn9bk1zcaKpXZu1CavhjXuydRtIyMNo1T?= =?us-ascii?Q?JZjQeOY5KhWG0rYNklBNAimXjLi6xeuI3r0PHnjAgyJ2u4HUjJQr5I2yAscB?= =?us-ascii?Q?TPweyF+sdQmphpAFsosNdn/To/TqjBdikTw7oXy6ZAMeFYG4D/vUlTEuv1cg?= =?us-ascii?Q?ktiJV+vWseWArefy8JB9WVxOGmX4XR4Q4e4g0rYA9g0eqrR+ZnWBoXrkIEL/?= =?us-ascii?Q?s4qlbQm1JBAX5YTwNPpLoyAhPr5l38uxhKD+ua3fTkELYvgq72cxqi0JtPu9?= =?us-ascii?Q?D4ET8TPy1Us=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5968.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aC9bHpLyfK3YAUFEgXUnFNavvIuhDutkSGu9gFAzw+HJpJtPW/sz0YR+l2in?= =?us-ascii?Q?1sUPbi/iS21vJ6JumiXrS5E6i63AQh4e67c19ccQALj8V0aCON9V3uzhK3z6?= =?us-ascii?Q?DEXZbyZQAlIjQ8fwfQjmTAI/pphDUogptnAFs4EGBeRdGi4i4YzHKhlV+fAP?= =?us-ascii?Q?YtvAb03+wMiYlPoRm9gUPrPqih8sT7F62HzeAYK2IfU3A/W+J2WGnh9zFpnl?= =?us-ascii?Q?7MrvTlV5hIdgPFZaaPvpNeqT3et0cVZ/wkO7O004pMec5MMKefVqQEsqpnhr?= =?us-ascii?Q?vTPp01Zzr11p5LcAPU0LJSpyIHZkp16PAGfxKnZT5noE/KhePiJPWCMmW8fl?= =?us-ascii?Q?Py3ag1fWy2DMEV5+vTT3y3/wD41G/2+v9EhqGg/pqR/CqNcr+z407GFoqUG2?= =?us-ascii?Q?SHB7tFo/+OXTkBA4apKHIUTIVYpWM/Na58dCTtNrIcmDvigBI5W+cFwedsG+?= =?us-ascii?Q?cHR6mCBewsqVRN5oyUXipVJRPJFg1w7sTxm7ZBlYqV5d6/0o5lTxcyGjTJYo?= =?us-ascii?Q?fONQAg0+uYKlHwQSSkdmHGAojzkBUy7OUiz79Q2QJpWpKGMfkQW0J/2aTnIN?= =?us-ascii?Q?Z0e8LD9rK1UwVoSkK2lavd8ge++NzyzGc8jPL3JWqp2UNPbxHWMOMtfVOlvD?= =?us-ascii?Q?IxcaywyN1F12Ri8NulLkecTgNOGlLWhMMvjh5E/tdZxfnHe2htDAXY6/8JBq?= =?us-ascii?Q?+fLWOqBAwpsT/oV02moxNP3wt3gkTjWlnGEwWRMH6jrQnJXUMSXe04BMPjz7?= =?us-ascii?Q?fxTzHZNcP9469n3LsfqipJIIHiZ1yt8JcM/44xht3DTPODB9c0XNHeKQBO3Y?= =?us-ascii?Q?2LxPCEX+RexAMnnYgmlUFFLNc7NpRhKUZ5P3V+w/Ly/86RalX23MmTMWF2YZ?= =?us-ascii?Q?ICD2qvAwhLbRgssVMDRd0PIoM0YKWFgJ0GpS3aegdhg88Xd81HJxIREPMCLF?= =?us-ascii?Q?gz+pNWhkpPMTXMsuTNOfIH3xQyQ/uVwkdtwkY+IlGt/bsqsDk7f107X06Slg?= =?us-ascii?Q?qhPM03wgstwUXV4vi1h2oCqwSbejAMVHDLr9B117y4GRFyvShT8lCoe2ob/e?= =?us-ascii?Q?cb8hqtXpC6a27NNqHleXF41PUnNiWmE/6GWDe2A+txg5e+D9CH8RGo5KEi4m?= =?us-ascii?Q?cgx/oMtIXBAbO/edeGjYrmyTsfeVADTpjnbvRYLE+PnMvZRbnYgQnKUcHEDQ?= =?us-ascii?Q?flW8188uOCdaXxaSS3omdWlBDFrqKgDiW3bStGMPXzdUlEbdiqZbDrVDnDE7?= =?us-ascii?Q?r4J3wO6TMUzdVst/IdP1KZINlTBHfHlMSs3/aozsxfGzw3Ouc+NfHcfPrqzj?= =?us-ascii?Q?abdOgnjONOMRRMtvIthRvS7+4/h/f9yWsPMYv1kGr4uULAxaDeMSBQKtLoVI?= =?us-ascii?Q?/txIy3pbcvAIASWLC55Ij784FN8kYuc/Wgso2kD1OG7PTj5lAh1h0go37ozd?= =?us-ascii?Q?GVha3GvedRzjUs6SIwKIa6YSUM1vPO+BWqrjKtZa4TdmuLKev1q0bEiI4Nl8?= =?us-ascii?Q?mcLtkUaT2eoddCDfsaukwRxqf/BycKrbuViN3anGzQE+jYa6YeaWTcjtOrEY?= =?us-ascii?Q?ZSH3Gkuv6zWghhczIoNNNTHP0Udb/ww7YQQdD1bs?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f42589a-3bc2-4666-cca1-08dde4f60ba2 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5968.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2025 23:12:36.7007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kwFpRwDuFXBOemwJVWSQxyKEBGQkeYgp6NGFLMIdcRIk/u0D6ZAZlScQbEYGfc1wuhOVIxD2fkcEnmowOV23bw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7913 Content-Type: text/plain; charset="utf-8" Change Device::vendor_id() to return a Vendor type, and change DeviceId::from_id() to accept a Vendor type. Use the new pci::Vendor in the various Rust for Linux callers who were previously using bindings::PCI_VENDOR_ID_*. Doing so also allows removing "use kernel::bindings" entirely from most of the affected files here. Also, mark vendor_id() as inline. Cc: Danilo Krummrich Cc: Alexandre Courbot Cc: Elle Rhumsaa Signed-off-by: John Hubbard Reviewed-by: Alexandre Courbot --- rust/kernel/pci.rs | 16 +++++++++------- rust/kernel/pci/id.rs | 18 ++++++++---------- samples/rust/rust_dma.rs | 6 +----- samples/rust/rust_driver_auxiliary.rs | 12 +++++------- samples/rust/rust_driver_pci.rs | 9 +++++---- 5 files changed, 28 insertions(+), 33 deletions(-) diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs index 26974cae4a22..182b938459a4 100644 --- a/rust/kernel/pci.rs +++ b/rust/kernel/pci.rs @@ -132,10 +132,10 @@ impl DeviceId { =20 /// Equivalent to C's `PCI_DEVICE` macro. /// - /// Create a new `pci::DeviceId` from a vendor and device ID number. - pub const fn from_id(vendor: u32, device: u32) -> Self { + /// Create a new `pci::DeviceId` from a vendor and device ID. + pub const fn from_id(vendor: Vendor, device: u32) -> Self { Self(bindings::pci_device_id { - vendor, + vendor: vendor.as_raw() as u32, device, subvendor: DeviceId::PCI_ANY_ID, subdevice: DeviceId::PCI_ANY_ID, @@ -232,7 +232,7 @@ macro_rules! pci_device_table { /// ::IdInfo, /// [ /// ( -/// pci::DeviceId::from_id(bindings::PCI_VENDOR_ID_REDHAT, bin= dings::PCI_ANY_ID as u32), +/// pci::DeviceId::from_id(pci::Vendor::REDHAT, bindings::PCI_= ANY_ID as u32), /// (), /// ) /// ] @@ -413,10 +413,12 @@ fn as_raw(&self) -> *mut bindings::pci_dev { } =20 impl Device { - /// Returns the PCI vendor ID. - pub fn vendor_id(&self) -> u16 { + /// Returns the PCI vendor ID as a validated Vendor. + #[inline] + pub fn vendor_id(&self) -> Vendor { // SAFETY: `self.as_raw` is a valid pointer to a `struct pci_dev`. - unsafe { (*self.as_raw()).vendor } + let vendor_id =3D unsafe { (*self.as_raw()).vendor }; + Vendor::from_raw(vendor_id) } =20 /// Returns the PCI device ID. diff --git a/rust/kernel/pci/id.rs b/rust/kernel/pci/id.rs index 4b0ad8d4edc6..fd7a789e3015 100644 --- a/rust/kernel/pci/id.rs +++ b/rust/kernel/pci/id.rs @@ -118,15 +118,14 @@ fn try_from(value: u32) -> Result { /// ``` /// # use kernel::{device::Core, pci::{self, Vendor}, prelude::*}; /// fn log_device_info(pdev: &pci::Device) -> Result<()> { -/// // Compare raw vendor ID with known vendor constant -/// let vendor_id =3D pdev.vendor_id(); -/// if vendor_id =3D=3D Vendor::NVIDIA.as_raw() { -/// dev_info!( -/// pdev.as_ref(), -/// "Found NVIDIA device: 0x{:x}\n", -/// pdev.device_id() -/// ); -/// } +/// // Get the validated PCI vendor ID +/// let vendor =3D pdev.vendor_id(); +/// dev_info!( +/// pdev.as_ref(), +/// "Device: Vendor=3D{}, Device=3D0x{:x}\n", +/// vendor, +/// pdev.device_id() +/// ); /// Ok(()) /// } /// ``` @@ -152,7 +151,6 @@ impl Vendor { impl Vendor { /// Create a Vendor from a raw 16-bit vendor ID. /// Only accessible from the parent pci module. - #[expect(dead_code)] #[inline] pub(super) fn from_raw(vendor_id: u16) -> Self { Self(vendor_id) diff --git a/samples/rust/rust_dma.rs b/samples/rust/rust_dma.rs index c5e7cce68654..f3385c4a7e5b 100644 --- a/samples/rust/rust_dma.rs +++ b/samples/rust/rust_dma.rs @@ -5,7 +5,6 @@ //! To make this driver probe, QEMU must be run with `-device pci-testdev`. =20 use kernel::{ - bindings, device::Core, dma::{CoherentAllocation, Device, DmaMask}, pci, @@ -45,10 +44,7 @@ unsafe impl kernel::transmute::FromBytes for MyStruct {} PCI_TABLE, MODULE_PCI_TABLE, ::IdInfo, - [( - pci::DeviceId::from_id(bindings::PCI_VENDOR_ID_REDHAT, 0x5), - () - )] + [(pci::DeviceId::from_id(pci::Vendor::REDHAT, 0x5), ())] ); =20 impl pci::Driver for DmaSampleDriver { diff --git a/samples/rust/rust_driver_auxiliary.rs b/samples/rust/rust_driv= er_auxiliary.rs index f2a820683fc3..55ece336ee45 100644 --- a/samples/rust/rust_driver_auxiliary.rs +++ b/samples/rust/rust_driver_auxiliary.rs @@ -5,7 +5,7 @@ //! To make this driver probe, QEMU must be run with `-device pci-testdev`. =20 use kernel::{ - auxiliary, bindings, c_str, device::Core, driver, error::Error, pci, p= relude::*, InPlaceModule, + auxiliary, c_str, device::Core, driver, error::Error, pci, prelude::*,= InPlaceModule, }; =20 use pin_init::PinInit; @@ -50,10 +50,7 @@ struct ParentDriver { PCI_TABLE, MODULE_PCI_TABLE, ::IdInfo, - [( - pci::DeviceId::from_id(bindings::PCI_VENDOR_ID_REDHAT, 0x5), - () - )] + [(pci::DeviceId::from_id(pci::Vendor::REDHAT, 0x5), ())] ); =20 impl pci::Driver for ParentDriver { @@ -81,11 +78,12 @@ fn connect(adev: &auxiliary::Device) -> Result<()> { let parent =3D adev.parent().ok_or(EINVAL)?; let pdev: &pci::Device =3D parent.try_into()?; =20 + let vendor =3D pdev.vendor_id(); dev_info!( adev.as_ref(), - "Connect auxiliary {} with parent: VendorID=3D{:#x}, DeviceID= =3D{:#x}\n", + "Connect auxiliary {} with parent: VendorID=3D{}, DeviceID=3D{= :#x}\n", adev.id(), - pdev.vendor_id(), + vendor, pdev.device_id() ); =20 diff --git a/samples/rust/rust_driver_pci.rs b/samples/rust/rust_driver_pci= .rs index 606946ff4d7f..f3819ac4bad6 100644 --- a/samples/rust/rust_driver_pci.rs +++ b/samples/rust/rust_driver_pci.rs @@ -4,7 +4,7 @@ //! //! To make this driver probe, QEMU must be run with `-device pci-testdev`. =20 -use kernel::{bindings, c_str, device::Core, devres::Devres, pci, prelude::= *, types::ARef}; +use kernel::{c_str, device::Core, devres::Devres, pci, prelude::*, types::= ARef}; =20 struct Regs; =20 @@ -38,7 +38,7 @@ struct SampleDriver { MODULE_PCI_TABLE, ::IdInfo, [( - pci::DeviceId::from_id(bindings::PCI_VENDOR_ID_REDHAT, 0x5), + pci::DeviceId::from_id(pci::Vendor::REDHAT, 0x5), TestIndex::NO_EVENTFD )] ); @@ -66,10 +66,11 @@ impl pci::Driver for SampleDriver { const ID_TABLE: pci::IdTable =3D &PCI_TABLE; =20 fn probe(pdev: &pci::Device, info: &Self::IdInfo) -> Result>> { + let vendor =3D pdev.vendor_id(); dev_dbg!( pdev.as_ref(), - "Probe Rust PCI driver sample (PCI ID: 0x{:x}, 0x{:x}).\n", - pdev.vendor_id(), + "Probe Rust PCI driver sample (PCI ID: {}, 0x{:x}).\n", + vendor, pdev.device_id() ); =20 --=20 2.51.0 From nobody Fri Oct 3 18:02:34 2025 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2082.outbound.protection.outlook.com [40.107.100.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26AFA304967; Tue, 26 Aug 2025 23:12:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.100.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756249965; cv=fail; b=SVjcPi1Oo9gEE55rixGCQgFjom01L2AhyCWGRxu6gf+1M5ZBjQkPBczzm0N/oNXi/ppG9VPHnLh89XwL4D4GsZqLg0N29Ftg62Ru1eXmkkzcFuP6FM4fIpd3+SZxP3wKa9AHuSJwMPzqzcxWSyW6swnpA7YREdINJtAFakNSSzM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756249965; c=relaxed/simple; bh=sDR9EfbIQuIjvJnYKOs1H0Ye1si8DDj9V9jbJPL921U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Me42y9zGG/jF4MFQkz9PmGu+SqHGpquPnYXsJF/iSVynfXa7vhQIplzPGatm1QIelyFVS1dak7G2ncpIPNWwJOUvZtq7Nw7LavndRyowzSiSMaH+od0Jxb+rTBFa4+lAc3lzwEWoFOY7rLHcdzKWbF4qlPvJ02Xug0Q7A4w/BvU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ofzcABIj; arc=fail smtp.client-ip=40.107.100.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ofzcABIj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HYmeuHKP7FE2D6rvG1o+PPEEwCwc7XphmeUlmskmNc44asizxfDzyz1OxCVoOWDhC+0Xxx9v+aAtjNrd6v/vYdkJiEG7E3BrujpeR8/ngylY2krOU9veQXMzuo2+jsMXalx4tO0U/PwrPwAytZg04lSqNDCz94es4QsYqWmiFicsdXBuSvRicrLCApk/tIbFs+VqutjLROQzPNkYHlVdOW20/X2t6/RB/Dw3rhfu14HF7zlzl+Y7ZldTwlaDs1vFufGhkX2zbWCcm8AUPJh5Hkw7MfJtyp9Gf1vKN6ZeHwAZ28rr33fxIn4stpI+qRT322hHxKcDDdyuxsCxeYEZvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e67SOeeD1d3i+6MGq7BWVwfdet1RlBc7kfVpwTI/R8I=; b=hDGt47TsJagDATkVhik5xs/ucoo2z2jpzIa2DZHNyY7hOAI1W5t6e9v1zU3fsVsIpDeiitYYcagqSmBhZg+1Tixn6a8lV7IuO9KyUKu6BwXDOABzw7+mmTGgK2zx0s54Q9lXwfafz9dUHxUHBDxUNUJiS6nJYLXeStmBLAzLTsNtrZKAIwlFeF2gOOTKLW0rL9Fz//AwUFmUt9OqVp5xhHupKealq/q9U67r+MMa9E4tcsKC0/2UN7ygSoHA3MWT43+ULXsdxuZlALrIBcOzf5JGLYfUZe2+8oSIxxaYq31xW7Yn3LNA0PqHkiJia+Bu07bHWj/6a53FmZjQrZHqmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e67SOeeD1d3i+6MGq7BWVwfdet1RlBc7kfVpwTI/R8I=; b=ofzcABIjzcK0VKHX+MaRpBCrGqSTjuRCQfpdNwFR8dRY/0Cs7c18Imu1RnzYWbZDKvc5cFy8WOqS24VHYe3bgVfxN/jVC4ff3RLIvemGU+nJtnomcf2vr4r7pUjLXQHfRyhH6Z1Kbvj6Qs8k3jmH50ceWp2sSxJRf/Ez6PpihB7iZPnrRsHY7qYbxHjD1lPnPyhuDCgRHir1/IV5QoGb0NIRl4j4JTmsfakQr07b1/BB9upRjDFtcn/j1K4yXTu92iO4YEjQq/Oot72qDKojz2KaNDYNczy8EXyWFxIF9JTcmKKZ1ljYuiAEDBdDzWQ0SUaamGsIN/3qRSAGNVgHGw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) by PH7PR12MB7913.namprd12.prod.outlook.com (2603:10b6:510:27b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.13; Tue, 26 Aug 2025 23:12:39 +0000 Received: from LV2PR12MB5968.namprd12.prod.outlook.com ([fe80::e6dd:1206:6677:f9c4]) by LV2PR12MB5968.namprd12.prod.outlook.com ([fe80::e6dd:1206:6677:f9c4%6]) with mapi id 15.20.9073.010; Tue, 26 Aug 2025 23:12:38 +0000 From: John Hubbard To: Danilo Krummrich Cc: Alexandre Courbot , Joel Fernandes , Timur Tabi , Alistair Popple , David Airlie , Simona Vetter , Bjorn Helgaas , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , nouveau@lists.freedesktop.org, linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, LKML , John Hubbard , Elle Rhumsaa Subject: [PATCH v7 6/6] rust: pci: inline several tiny functions Date: Tue, 26 Aug 2025 16:12:24 -0700 Message-ID: <20250826231224.1241349-7-jhubbard@nvidia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826231224.1241349-1-jhubbard@nvidia.com> References: <20250826231224.1241349-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BYAPR07CA0087.namprd07.prod.outlook.com (2603:10b6:a03:12b::28) To LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5968:EE_|PH7PR12MB7913:EE_ X-MS-Office365-Filtering-Correlation-Id: 6fd7791f-0d2d-470f-f550-08dde4f60cf5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5gefdbWuihIkQ7NawuCC9W7n1E37p74l6D7qVim/LW68/k/h242I31FD45mL?= =?us-ascii?Q?1yI6+iUX4w4kC3sR5dJH0098pcs+NDnjrr8uNPPtSXMy02RDS8FZAV7O4QWl?= =?us-ascii?Q?WkW4DF9eky4t2VS1ZOd3x108/0n0gItZPO8METr9rn4x+2TlbReJgllRgyNk?= =?us-ascii?Q?PBXUMAf0nS0BUbprp58TLyQk4t0vRc4n9TK2OG2Xfdf3Htm5deRVYzOlRlws?= =?us-ascii?Q?GPB+fYl2qOFZRQ0lr7M9fZxYK6142BQvX2wg68pzjwqAQ0cgj/axb6GIM2uG?= =?us-ascii?Q?Jqjc7ZDMlq71kb+GIonew+UaDZA1tb6y/ynAf64GYS5uaMumz4m/NMlKxup6?= =?us-ascii?Q?Pr9+OUBctUTNwi/o926OiBj3NvZt+pq5qNVHpjbhQPhBZ6gwoPVN4S6Zvd6U?= =?us-ascii?Q?0S+P5ZZm0N26ZvWKKL3qYmTMkfdF81Xsr4aBuYqj/roam38qxuGSGDQfjX9W?= =?us-ascii?Q?qE4i9UdMXf3bjc6e76J3hGKkehwwCr8c03V0x6jASFnuaAwLKgcbpnMglCV2?= =?us-ascii?Q?d31T5MtbaIEIbyZawYyAWBQRZmFxQHUpTKW9gHoUsP6Vff5eOARwEbhsh2VY?= =?us-ascii?Q?TJbCunoCzNLlfkrgliqQDSHQUxxwW4DtKHGavGteOP22pd9pdX149PQaqX4b?= =?us-ascii?Q?Q9CR9OfRg+/VdUx8xbPREnPCxCEtEkyIUuqefW3izJhV2yGuAkaTR22Nq37V?= =?us-ascii?Q?N+PMG7nbuBrRq3TIXW6nTHl7jZy1YpPbXfNugT5fWga5mUXZM87pIekZ9FIA?= =?us-ascii?Q?2fQgLsdIQRHzv8ZCeP1B0MfaLKG7oYcVICsyQTjmyEPzs5RgrRZkTGC4Nf9q?= =?us-ascii?Q?mER9FjrUlto/yB3ltisgDVIrrE1jwVCuog6+YApFdn02NxoA6zmgmy5ZqNMg?= =?us-ascii?Q?u6fKwECxpGLj7uVpBKjqPFBgCQo/o8bHdpxDxaI+qZZ4M5v7RbpKIC4Euwfh?= =?us-ascii?Q?Zo2tt75F8ymFD7EZoTG5BzUuYvpB9jfbVu/olDW0vXhbdApqmD9HaG/qej3r?= =?us-ascii?Q?iUXW8nHMaHR586IBgg4Rergy47ah882eNHYbHFgsMKn/TogMkdWclcYI667n?= =?us-ascii?Q?XKCy645644xsHAgHltjdFkxpVYL1VClL3cJuHxXaWt02JML7xYDZFqh/SyVa?= =?us-ascii?Q?Yb1z5rEcBJ1gr7djpN8zT6FLez1FieKgMYT1X2JDCcT8b/wu7796k7hqzW97?= =?us-ascii?Q?HcJbB2pYQ5hMZqhF7+Ws/xqnNVXlhVkj40ZVFZStlUB3j5POsTToYFQh/N6S?= =?us-ascii?Q?VEKVyBuqO0t82T5Op2GNMNYsWq0iIkXzWiZTV+ylr5w6+kOuWjp5zV8r4JYY?= =?us-ascii?Q?6H42vC+Eu5+5eJ5OvnacQj1hbSAKtAqnXnbPn8TKzzbMDl99sP0R0CWdZX1w?= =?us-ascii?Q?EgkZhVKG9TOhD0Wlb8s90WZO5avYe/x9UDlMjY1io5didAVUUGIqVHg7s7TG?= =?us-ascii?Q?y4BDCeY3lbE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5968.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JfCOVn1o92hfeuVPzmQSejwsL+AUkff0C4CZLTVqyrwsGIHHrG29HfmlChV3?= =?us-ascii?Q?OYiniZ4IGKryPKEOXyOr3dxE5bmrYo4GQ/Nm++YRY2JQ4AObsD4OWiL2lsm4?= =?us-ascii?Q?GeVCTv49zzbJRGvhccSVUoL80bPpFggb7T6/WgF7olF7fHLlhdvyf6Mv06lR?= =?us-ascii?Q?2cKJZvKkaSTWle2m/QMQUnGZyC9i2nNdGiU+auB8vMf0qwGpMNTxL/P0BxOb?= =?us-ascii?Q?luRliw2HPm1DVuIHy83YMrA+47TdudNmPe12GXHpn0OhKws5eCet787KdQzE?= =?us-ascii?Q?k3QrD7UW1DNT3uTYrGdsuOPTjrsto0lw4eS6vOaNzTFZR2ndw/o5vB14ss0c?= =?us-ascii?Q?c4/ehzXjNOc5ZdltgYWKrKc5ZY8rCetHLPI+hkhnjfy7s0qreUODZAle1HYu?= =?us-ascii?Q?fUWEUt2SOxDly1YO07vfHI5rn9gNa1MUOEiCrpTKfuqQwYoY+ZBM5m9e99Cu?= =?us-ascii?Q?zTiO07IQCcdrHf7UjOGDHXS8+E8XqniMJlkzd9XUtHo3UgPIwHWpnof72/LK?= =?us-ascii?Q?qF9N2f/z/O/b99DK7FI0Cyds50D8elWr1L4ayI/RCAolmFMApBXyIsD0vqgU?= =?us-ascii?Q?mUbgU5rtLmMUdfiy6SWNG9zy1QjhiownsnGtrO1E0BihJPyMQym69t6tKISo?= =?us-ascii?Q?7z/Zr37AamrpFLkBffJsmv2NH91RomtwY5a9AuraZm8TevT8qPEYeyotyL08?= =?us-ascii?Q?5UkeGOxM20E/SRGlYcQJMrXqk96u191zOaNfyQtrSD2FDP9CFeQAzVICkUlz?= =?us-ascii?Q?F4Tg7GjosYWF00GGlezG7WGZRqC1ZcKWg/Iw3OCPcX1i0nbGidnaiBK1re3r?= =?us-ascii?Q?izCliXoHu0ckMGSv6LF77DxSbY+wP2ITfdWPNhbtI3h1egaUUFXYk7ABCtmd?= =?us-ascii?Q?+YUYKpnl1sKr+rUDmbo8gT/ioxea8nKv4D8KIBAqpDnsnSQqsmRy48kj6mHR?= =?us-ascii?Q?PZdR1TesF8qPTjks+4Upc9L3p15IATn2YC1UphoC5MCYuZQk73VKF4czbWwW?= =?us-ascii?Q?JmoRawB5/PicAz3zcWz3Tdnjhy1n8LtMLkBKJKIEhOryzKmk9addMT6xeb1/?= =?us-ascii?Q?KQJU1WmW3Y7YdWH5eS3I+YIIxKWrg9ReEcxRMgc7LtIgiuFsDKruf1vf0J9G?= =?us-ascii?Q?HaCT1CPVqQlOjEFB5hXgCKsG0LKiiR5/PKevBlLc6s0eXBN/WVlU9duk845F?= =?us-ascii?Q?PhXQVNyNOir/QPnYat14GFKazAw1/IT45SDUbvrGKsA43gukOsXArTOSF64A?= =?us-ascii?Q?SLRCHO0CZU2ptrMGYjTsI8l4n+xfnzi+dF2SUC78QY+QuBINvyHlRRvXuPXS?= =?us-ascii?Q?jE9qkwujGgzx86ERraJjw/aH9lYJ4SDLfAF/9mF5SulvNgQgv+ucjH01FL9c?= =?us-ascii?Q?mdxoPyYixihKfnjF8GlVlm2rOtNL3I9cHoQXryqtQFjGXUqzoSObBlAgF9Yj?= =?us-ascii?Q?YOM7QfK3UGZuNsHIfb7/b0XWSXKvWQ4O4VGAkQhCcaNgrBg8lckpuxVc9uBs?= =?us-ascii?Q?UoIu3nE3pJwpQdBqmxE//0STRsrX6wNOD0SPCNN5WqBJ3aZRi2dMnnKg+DyE?= =?us-ascii?Q?voKj3yLgVkkTXHSYMWaN8ZmWawz+vgpI1CCpTR0P?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fd7791f-0d2d-470f-f550-08dde4f60cf5 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5968.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2025 23:12:38.8627 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NsugjC7EHznpqlkkhPWjHrnoLJK0qY81xQKXJ8otd5TIK9XdUKqD2ty2JV7EBB8NYhdHR3wyjMN3evKGclQYlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7913 Content-Type: text/plain; charset="utf-8" Several previous commits added Vendor and Class functionality. As part of that, the new functions were inlined where appropriate. But that left this file with inconsistent use of inlining. Fix that by inlining the remaining items that should be. Cc: Danilo Krummrich Cc: Alexandre Courbot Cc: Elle Rhumsaa Signed-off-by: John Hubbard Reviewed-by: Alexandre Courbot --- rust/kernel/pci.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs index 182b938459a4..ee2215614dc7 100644 --- a/rust/kernel/pci.rs +++ b/rust/kernel/pci.rs @@ -133,6 +133,7 @@ impl DeviceId { /// Equivalent to C's `PCI_DEVICE` macro. /// /// Create a new `pci::DeviceId` from a vendor and device ID. + #[inline] pub const fn from_id(vendor: Vendor, device: u32) -> Self { Self(bindings::pci_device_id { vendor: vendor.as_raw() as u32, @@ -149,6 +150,7 @@ pub const fn from_id(vendor: Vendor, device: u32) -> Se= lf { /// Equivalent to C's `PCI_DEVICE_CLASS` macro. /// /// Create a new `pci::DeviceId` from a class number and mask. + #[inline] pub const fn from_class(class: u32, class_mask: u32) -> Self { Self(bindings::pci_device_id { vendor: DeviceId::PCI_ANY_ID, @@ -385,6 +387,7 @@ fn release(&self) { } =20 impl Bar { + #[inline] fn index_is_valid(index: u32) -> bool { // A `struct pci_dev` owns an array of resources with at most `PCI= _NUM_RESOURCES` entries. index < bindings::PCI_NUM_RESOURCES @@ -407,6 +410,7 @@ fn deref(&self) -> &Self::Target { } =20 impl Device { + #[inline] fn as_raw(&self) -> *mut bindings::pci_dev { self.0.get() } @@ -422,6 +426,7 @@ pub fn vendor_id(&self) -> Vendor { } =20 /// Returns the PCI device ID. + #[inline] pub fn device_id(&self) -> u16 { // SAFETY: `self.as_raw` is a valid pointer to a `struct pci_dev`. unsafe { (*self.as_raw()).device } @@ -476,6 +481,7 @@ pub fn enable_device_mem(&self) -> Result { } =20 /// Enable bus-mastering for this device. + #[inline] pub fn set_master(&self) { // SAFETY: `self.as_raw` is guaranteed to be a pointer to a valid = `struct pci_dev`. unsafe { bindings::pci_set_master(self.as_raw()) }; --=20 2.51.0