From nobody Fri Oct 3 18:10:06 2025 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EAE72FA0E8; Tue, 26 Aug 2025 21:24:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756243460; cv=none; b=eK09mM8QccbiH+qRXVggyNt0eG5WxkDkeWL7AFiajDse+IxG9DgJcjx0768rjwaW8pdov7lv2uMUp1NWq4oIKvIg6BHAAOfhRW/b4joBSaRKTV2/JWEjnBjEhacJRDI6v0+fuCEM+sVyQbcjXY0ZCcpbDCQ0/8//p8Ws574KfDU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756243460; c=relaxed/simple; bh=RAcy7NWxWBhxPVzmCf1xn9p74TqGBPwpt2JNZ6oZ//0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OjDAhGqMEAp/qefn35UHS/jrp/mrJfa8AZWVnYCXq7bwysVYso1r8bqDn+eMBEx1bkcIbjN9vJaWPMI1SL6cMJMxbso3c6n3LF9Hg8A3NhMGYSab9napAk3YHqZ+st/nj4MFDXIsfX5xgdMzzDCCJ6uVi/FguQBCXQzEbu2CRhY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ksA6dj/i; arc=none smtp.client-ip=209.85.160.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ksA6dj/i" Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-4b109c58e29so115198291cf.3; Tue, 26 Aug 2025 14:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756243458; x=1756848258; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8tf54ARgykYebw1T/qEQsnrX9CWrnnjsUdUJCfBDXds=; b=ksA6dj/iWODfTMs5Yg+JEGTShJVrrYbbbKGNYF798PVmuXSP8C3aG0l6bZDxgr53Gz rBDfMzeP3qWvrIFBJ58vAbRySvEVbegneu01ekouSxo2Cxz3AIeKRwKe+rNmzGia+U4S O8HUzpG8iHzaxqVf1I1g9zbXUtCdP/CkimB/u9/w8uDbGdcAs/wLPoGYObmswCZdkWrj gaUVN2kr7rRS0UWqv7/8qIUG+6txgh63LhXRILrrimJMJnW6T2Ej7ToAsFRq1eiht35L 0YnqP4m6wkOzSamh4HPrFtTvUCIeyCn4k7tn9AoUiQUOrROxOwKGnUvGHzWHiJO/6rqB +dsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756243458; x=1756848258; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8tf54ARgykYebw1T/qEQsnrX9CWrnnjsUdUJCfBDXds=; b=cAGB2I6fqwhHizSIhspgs760o9TOnLjPtkmL6jNGeFSNIN4QvWkziS3P6AGa775M9Q mYZEZW6Pfmzo0EUFK9e71BwC/8b+7CE9WwPpMzIMEMyP6IWXzhWRlbqv2ZB0q18h35te zb1VZ3oc5JdMOF+cSdQtZI49ONpuEtu8EL+ZzJa/98q66bOtVTmSk9ut069gS4mgpcKk KL1FFVe9rc6PrUJquL50OnJPUUn1Sd/pktHfoPN+UruMEO5dOpbq9Ua1+iv5gKb6at+s rAn3+Fr4QjL8IAOQdGCAQYOxeLjcD1DHuQHYUtCBGF3UCYoPIxvrCgbjwnweeG6lvPUz 6trg== X-Forwarded-Encrypted: i=1; AJvYcCVjFI2Yd8Jn64zaqab7tNoNwM+sO0hyDXPqTI52peVSH8Cd6Rjxyi/MG6+Derlalpy4Vp5ZXI9PcEPXpHY=@vger.kernel.org X-Gm-Message-State: AOJu0YwdRavi1yIa5K3YmxPQLwLqblAJADxXgSXKNJ2aypvOsjhlbUJ7 3Jyv3yw+YQK7eRSNc8iZfkfibXUo122WMfBPl3hoGFxLOnKD+0Oc+MwlaCZU3w== X-Gm-Gg: ASbGncsi8fs+09YugbLNgi9c7tfBa4QeIgRm/5DMK3cDVeXSEMKWfMBNGz/FjtPzKzc wHeoco8RtiaNe2FHZypNl33LGrw9x4K3C3VlsveyxmwjMr9MJk8psotSs7RfNJ8nnEn0nWYkohR yfHEft+CeI/NduTczdrmBK2A3fJAg9NF+7huKqLJW5ZwYUgj5dddUZiHXR8Fgp1SUHBbnEvnDUe y3ig11bT8tAcTUij1z5GUTyR/DRVhDGBa137mYskYaTeVkhSwAlsOYG2GrsuGlD4nl5+nVQi6GN ZADsj3FmD8ROzDsfR9q30RCl6L2UuA4yFxulDLQbAGcm65+vy7cBO2dlPBojqn05Hu/w+h+Jy7z OaowERgo3MD1FV3LJdDST4fY0lF2s/BPczG8UzHh2LFpZAoPBpSpAaTtImQTWL8TyHeQVvugrDT f/ X-Google-Smtp-Source: AGHT+IFO6U57WJ0FUsQI8L/4P9yAzKSF+aNckD4lA+M45DpSyS0/lewNKzbGRVmrO9ABzQF1r5rtew== X-Received: by 2002:ac8:590a:0:b0:4b0:6a0d:bbde with SMTP id d75a77b69052e-4b2aab666d5mr219564761cf.55.1756243458047; Tue, 26 Aug 2025 14:24:18 -0700 (PDT) Received: from archlinux.lan ([2601:644:8200:acc7::1f6]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ebe6069a17sm758731685a.0.2025.08.26.14.24.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 14:24:17 -0700 (PDT) From: Rosen Penev To: linux-spi@vger.kernel.org Cc: Mark Brown , j4g8y7@gmail.com, linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 1/3] spi: rb4xx: depend on OF Date: Tue, 26 Aug 2025 14:24:11 -0700 Message-ID: <20250826212413.15065-2-rosenp@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826212413.15065-1-rosenp@gmail.com> References: <20250826212413.15065-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There's no support for non OF platforms. Better to depend on OF explicitly. Also fixes a warning/error about the dt table being unused because of of_match_ptr on non OF platforms. Signed-off-by: Rosen Penev --- drivers/spi/Kconfig | 1 + drivers/spi/spi-rb4xx.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 891729c9c564..cdeaa8e711fd 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -917,6 +917,7 @@ config SPI_ROCKCHIP_SFC config SPI_RB4XX tristate "Mikrotik RB4XX SPI master" depends on SPI_MASTER && ATH79 + depends on OF help SPI controller driver for the Mikrotik RB4xx series boards. =20 diff --git a/drivers/spi/spi-rb4xx.c b/drivers/spi/spi-rb4xx.c index e71d3805b150..a795e263299e 100644 --- a/drivers/spi/spi-rb4xx.c +++ b/drivers/spi/spi-rb4xx.c @@ -199,7 +199,7 @@ static struct platform_driver rb4xx_spi_drv =3D { .remove =3D rb4xx_spi_remove, .driver =3D { .name =3D "rb4xx-spi", - .of_match_table =3D of_match_ptr(rb4xx_spi_dt_match), + .of_match_table =3D rb4xx_spi_dt_match, }, }; =20 --=20 2.50.1 From nobody Fri Oct 3 18:10:06 2025 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDEDD2FDC49; Tue, 26 Aug 2025 21:24:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756243462; cv=none; b=nnUED05RNlTF/fWi+By/WfZIMOxOeAMClDyvxR4Sv1Q8sc13jEoho1th4qrNq9UpV+cU1/bfIyTcJpbgUUR6Sf9/B6lARCcu3E2TLpUhEUvDLVqnbp8537bJC6fhfagvIWLQY16WlPWohFJHPZZc6QJXrK9JgDmtARvPjr//DVE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756243462; c=relaxed/simple; bh=rGM5oFrpE7IZ/wiiDmdO6yKZ6jGKP7Ou4X1ZQdPS+ko=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EjUZ4u1/fGc+cCd/PWzutGYPs3cV4q3saK5hnyVlkhaI+w2WVvDhGi2Os/uG70v1ZPvVIUlpb2Jf+SfnIfMDOTzr/2YunY9PM+52FVsFUupJ1Pvzzd6HMUvGkN2/qC42FYlYm3DVegLUBtcZImuyNMOhKYJGeMHIE+H9kkShm4M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MeCJURSi; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MeCJURSi" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-4b297962b24so61047481cf.2; Tue, 26 Aug 2025 14:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756243459; x=1756848259; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9pX6DnEQUDsZd/6WXGhQUCkCmFvOmnaGnVWybHzRyIY=; b=MeCJURSiePO96NLk43UmtzgRiTBFQrw0nmMLlzXM0YLS8jTkJOQc/PiqAAs7zkXaF/ SlblxADRrGTEYKIby4ocrah7FXnV/GHo3WWPwrqGmbT/n0ZDpTsOprDmB45GAum7NMpj iMBlymHRi7YBZiisSILxEuma6KMaGSirmnjMufLGl8zQ4+zO7QQzFpW04qAtW1h5vIVc tvmWdGf/ycYN6eyoWIQab1XsTewKtSxvYXWXJDCK2joApwfNbo51DcBYREer8J2QuUve pJbR5WtolxqAPUU+f7ZyCwSiEdlcpEixOGjGYXXTJu10PyBgeO4eS6LyFxenxAFo9+Py VI3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756243459; x=1756848259; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9pX6DnEQUDsZd/6WXGhQUCkCmFvOmnaGnVWybHzRyIY=; b=SuGWOGCXimckkncsU4+QxTjS+0vjLuVaXCVgtKSnIXFiqmDARJagQ5bXtJDVfRKMVK 1pE9+DmXsyGcqa8QNoBRHL9V9fwtjg0/yLxkIu2gvjoheg7kIxsgrwRsVCEo7dGqNQm5 4bnddEMoXXdZmeL91yu6xt0Q/20xLjEJOmZcMMRTrmD+A/tMcyBiY6/8uOfCHlZSrOGN Ki+Wnlip8UPI0EuZSyoWZyKO0JIxgQfpEW0HeAbqg0HUNbTIKZIB5RhahHrnzTfqZJnI tjhUrNQz28Bdb1UQaNwGgUIydbUeYh1sBF2LR8i+Rds1YHc5ELogRdXyzughe0iHzcFO jPcA== X-Forwarded-Encrypted: i=1; AJvYcCXjZZ3HdLJqJfLxaZedXBWhKxcypl6M0haWa3B6VAezO+v1wcmabNCg/TClxdOyQqX80MZ39CJOx5JlFd4=@vger.kernel.org X-Gm-Message-State: AOJu0YxtpI+hI1xiHFv5L/wKeQJmyeAIs0x6bqnPGa0+CO+fTxlai0FK nD3EvITQGgRSJPrnWl/z83wgLpjgIPx0UI5EVdyoxhOCwNczyRAvQMnTMG/JiA== X-Gm-Gg: ASbGncuoUlS9THlBm8fucKKDzb5o5VCF/1HQvzKw10n71pdhBaDZ4x0ppyM7Lq9LYHn Qlh4TRLFrzGZAYHYN8OBb9C/RNFVyYo+JidDLxdSXGshvRdx2JZpEoGXEvZaRv4en1WwYcR6YGR XzOfaT2oxqfjUN9ePOyVrRiHoTX2vq8GCvrWA2swZckyX/hBmxPiNpw22+7NNx2A4I4KoreyXbE sLYZmUmJ8Jp42A8k76tXsZLnJX0A6/OsPK1l4y5PcccePFI/mPp2V1UcXot6bI9krHTF03Y0uOa SLVl+jgPqv4CEyGe+8BYnYoCFJhBPco1vTDzhYECZDLTKtJwOx7P+Gy1dLqmP9sbd+tFDFXGtPv Op7ljy5mcR1WU9aXmx/sYw/WNY2EiAAvQGe5BLzqrvMfYE6JzWsW8DYvOvrLY0vuJjA== X-Google-Smtp-Source: AGHT+IEYSECETbIPCVwcTqb4Djf799ep/SzYEE0PgmZU1aQo/unByov+jzSqVUxUqcO4GcN5jI2LVQ== X-Received: by 2002:a05:622a:cf:b0:4ab:63f7:9a80 with SMTP id d75a77b69052e-4b2aaa28036mr286861281cf.13.1756243459343; Tue, 26 Aug 2025 14:24:19 -0700 (PDT) Received: from archlinux.lan ([2601:644:8200:acc7::1f6]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ebe6069a17sm758731685a.0.2025.08.26.14.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 14:24:18 -0700 (PDT) From: Rosen Penev To: linux-spi@vger.kernel.org Cc: Mark Brown , j4g8y7@gmail.com, linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 2/3] spi: rb4xx: add COMPILE_TEST support Date: Tue, 26 Aug 2025 14:24:12 -0700 Message-ID: <20250826212413.15065-3-rosenp@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826212413.15065-1-rosenp@gmail.com> References: <20250826212413.15065-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Copy macros from ath79 SPI driver to allow compilation on all platforms and remove ath79 specific header. Signed-off-by: Rosen Penev --- drivers/spi/Kconfig | 2 +- drivers/spi/spi-rb4xx.c | 19 ++++++++++++++----- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index cdeaa8e711fd..f7020d35b3a5 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -916,7 +916,7 @@ config SPI_ROCKCHIP_SFC =20 config SPI_RB4XX tristate "Mikrotik RB4XX SPI master" - depends on SPI_MASTER && ATH79 + depends on SPI_MASTER && (ATH79 || COMPILE_TEST) depends on OF help SPI controller driver for the Mikrotik RB4xx series boards. diff --git a/drivers/spi/spi-rb4xx.c b/drivers/spi/spi-rb4xx.c index a795e263299e..bae802e94226 100644 --- a/drivers/spi/spi-rb4xx.c +++ b/drivers/spi/spi-rb4xx.c @@ -16,7 +16,16 @@ #include #include =20 -#include +#define AR71XX_SPI_REG_FS 0x00 /* Function Select */ +#define AR71XX_SPI_REG_CTRL 0x04 /* SPI Control */ +#define AR71XX_SPI_REG_IOC 0x08 /* SPI I/O Control */ +#define AR71XX_SPI_REG_RDS 0x0c /* Read Data Shift */ + +#define AR71XX_SPI_FS_GPIO BIT(0) /* Enable GPIO mode */ + +#define AR71XX_SPI_IOC_DO BIT(0) /* Data Out pin */ +#define AR71XX_SPI_IOC_CLK BIT(8) /* CLK pin */ +#define AR71XX_SPI_IOC_CS(n) BIT(16 + (n)) =20 struct rb4xx_spi { void __iomem *base; @@ -63,7 +72,7 @@ static inline void do_spi_clk_two(struct rb4xx_spi *rbspi= , u32 spi_ioc, if (value & BIT(1)) regval |=3D AR71XX_SPI_IOC_DO; if (value & BIT(0)) - regval |=3D AR71XX_SPI_IOC_CS2; + regval |=3D AR71XX_SPI_IOC_CS(2); =20 rb4xx_write(rbspi, AR71XX_SPI_REG_IOC, regval); rb4xx_write(rbspi, AR71XX_SPI_REG_IOC, regval | AR71XX_SPI_IOC_CLK); @@ -89,7 +98,7 @@ static void rb4xx_set_cs(struct spi_device *spi, bool ena= ble) */ if (enable) rb4xx_write(rbspi, AR71XX_SPI_REG_IOC, - AR71XX_SPI_IOC_CS0 | AR71XX_SPI_IOC_CS1); + AR71XX_SPI_IOC_CS(0) | AR71XX_SPI_IOC_CS(1)); } =20 static int rb4xx_transfer_one(struct spi_controller *host, @@ -109,10 +118,10 @@ static int rb4xx_transfer_one(struct spi_controller *= host, */ if (spi_get_chipselect(spi, 0) =3D=3D 2) /* MMC */ - spi_ioc =3D AR71XX_SPI_IOC_CS0; + spi_ioc =3D AR71XX_SPI_IOC_CS(0); else /* Boot flash and CPLD */ - spi_ioc =3D AR71XX_SPI_IOC_CS1; + spi_ioc =3D AR71XX_SPI_IOC_CS(1); =20 tx_buf =3D t->tx_buf; rx_buf =3D t->rx_buf; --=20 2.50.1 From nobody Fri Oct 3 18:10:06 2025 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21C5E34F48A; Tue, 26 Aug 2025 21:24:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756243463; cv=none; b=JlzhMkEO38/FRdeSHlYf++qvqaMfDdxeCIkoMVTzrqml7bQI1yfzZQKT3hMBsgj/OuokriNhVcoYsaJvOce04bs0UY/6cs/+R9pWVRX3dJwACyhOzH0eUwTBKzXrfzlKm+hMI+EHhmLh8JZENhf9hyLedZg0oIviYgd7h2C9GVQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756243463; c=relaxed/simple; bh=aYw6MofnHAvKaEH1PElA/MNTzS+F9tHNM86+sFZV9ms=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=remsbl1Fz+1jwx2kvyx8wLsM+2zqwIADVRfOEfDGPGWgX47KeLXiRUEefLBXrttqtQdGsI2vCwJj7ExtRyEbwedO4ZuG33cNDnsp94tfPjPisrNxMkKXJ5KrmC9cTyK3ArLb7UAyfcsEhYQcbeIecwQnJO8xrmll6g/gwuBB9+I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O8sMuH6W; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O8sMuH6W" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-7f04816589bso235387685a.3; Tue, 26 Aug 2025 14:24:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756243461; x=1756848261; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kgXAMQGqr0Izd0AMNgry0Bz28MBpgtkqZJm6I2t+UrE=; b=O8sMuH6W4ReMcj1kVdOAMQg6ePU/tdkRmgABQO6c9ESXa8X16fhMk50DRHOgcdTsmO ffWGfKB/ACNZeL8L3A1BDhA2e/Luj+5VRN0wFmUeyrcBImp4d+o41TT+W3p5S/urbNE+ Bwrz9VdSfPY2/I74olvKVBkEVQJ/muaQY2+iRcAT9zQqnksrJZWqmxYbNe4kbp/qaBzq gAndXrdnbYR+rhYSrnhDj61vI0pNBbzMYQnzmBt3t2d7i4M21gOqqb8i0XjwNTbq3zyD q5blhW00HNbclc386rL2kj8Tg75XeFjLH/emu/CspXaaPBF+BgLenxe2d6/rm9EsMnEH zYKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756243461; x=1756848261; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kgXAMQGqr0Izd0AMNgry0Bz28MBpgtkqZJm6I2t+UrE=; b=ahe9iHkgvNS/dow2qOHeWvBCUnlxan2IrSFl9+n72i2CgIH/4MVSWYUpS6j9ZNZnWp a7UW5gjE24k9F42MVK2h3dJnNsLXFZCEwBghtMoeHv5VfuZM7TW+vAeMee+kYk/+yzUW pFxXpYYd4feUXLxJmQKhCHP3QqagbOquaqKCpQESaA50T2GcmppdgW4XTXqdd9AjGfQ7 uArMVuCnC9hGR7zt9jB9NN/Qg0Yp3XGwHTZM4cfP0AwJJs41v0WQvoxfsEgAfsOjtMYh VrWGi3z8uR0fdcY2FzQRbxd2LZjJDxefykYDarBhhwTwr3g48GGgMRXnXEnAbL+/QakT hR6g== X-Forwarded-Encrypted: i=1; AJvYcCVs03gEhgn/Af2e+4H5G8Hb19nbmuJoaPbkiKwuut2q8qgX5mFKTq6ryFHeW4ALROKRSUjFoBOTaFMzfyc=@vger.kernel.org X-Gm-Message-State: AOJu0YyjRmeW0N+HuMCpCuDA2E4AZV7fDNcULnGOHQSz62qdD0ySpFFa 0rVkOn5YLgyln5OTLKd7BG9VakxMyjJXnBUrRXpdyDn8NnkfA7zKttKkGEHyLg== X-Gm-Gg: ASbGncu4SO7hs1fevMlw1CBSPfDOM7rsIsTopp1YbQ5/LLquvb63ZTZc3FwIpi4qTf4 OBYK1CN5ie4cZkZRpv40acnMaU+kLacMo0/voPp92FKstkToV57szK9xnckf7Kaog5ltlefAoCU G2rlE+6vAqzTUZMoK3YFtkBB014DJJyQzvf2UMtHalOcpD5OVOyhJnaIHBih5Rej+f1Taxa31Wy INZ9AcX2isDIMpTsgeAPYd7vdG5ocE5EraunA6wYxMTnIGXyDKC4JNBnOAYUroeKvBpkho+iCbU Kv390rzSjJBZlie4DSdiJUKo+EOLXiOQyjh2Jwdg/blm20kUPepuHRZqME6qZMMW99pOkWWDwEQ uAmQo5dDICASFpVDGRKwF1VLz8Lxt9t65EguiDMweVbzpLFB8vg2Ecf9v4OghqVg2yQ== X-Google-Smtp-Source: AGHT+IGYBX4kaWboCu+DoR53isVds5bF1CvBSNM+ml56+QxJ48bWshjlkrRl8VG7WMuBPEtzNZGrkg== X-Received: by 2002:a05:620a:1a10:b0:7e6:3460:5b03 with SMTP id af79cd13be357-7ea10eb4859mr1949079685a.0.1756243460599; Tue, 26 Aug 2025 14:24:20 -0700 (PDT) Received: from archlinux.lan ([2601:644:8200:acc7::1f6]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ebe6069a17sm758731685a.0.2025.08.26.14.24.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 14:24:20 -0700 (PDT) From: Rosen Penev To: linux-spi@vger.kernel.org Cc: Mark Brown , j4g8y7@gmail.com, linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 3/3] spi: rb4xx: use devm for clk_prepare_enable Date: Tue, 26 Aug 2025 14:24:13 -0700 Message-ID: <20250826212413.15065-4-rosenp@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826212413.15065-1-rosenp@gmail.com> References: <20250826212413.15065-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the remove function as it no longer does anything useful. Also remove platform_set_drvdata as get becomes completely unused. Signed-off-by: Rosen Penev --- drivers/spi/spi-rb4xx.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/spi/spi-rb4xx.c b/drivers/spi/spi-rb4xx.c index bae802e94226..22b86fc89132 100644 --- a/drivers/spi/spi-rb4xx.c +++ b/drivers/spi/spi-rb4xx.c @@ -156,7 +156,7 @@ static int rb4xx_spi_probe(struct platform_device *pdev) if (!host) return -ENOMEM; =20 - ahb_clk =3D devm_clk_get(&pdev->dev, "ahb"); + ahb_clk =3D devm_clk_get_enabled(&pdev->dev, "ahb"); if (IS_ERR(ahb_clk)) return PTR_ERR(ahb_clk); =20 @@ -172,7 +172,6 @@ static int rb4xx_spi_probe(struct platform_device *pdev) rbspi =3D spi_controller_get_devdata(host); rbspi->base =3D spi_base; rbspi->clk =3D ahb_clk; - platform_set_drvdata(pdev, rbspi); =20 err =3D devm_spi_register_controller(&pdev->dev, host); if (err) { @@ -180,23 +179,12 @@ static int rb4xx_spi_probe(struct platform_device *pd= ev) return err; } =20 - err =3D clk_prepare_enable(ahb_clk); - if (err) - return err; - /* Enable SPI */ rb4xx_write(rbspi, AR71XX_SPI_REG_FS, AR71XX_SPI_FS_GPIO); =20 return 0; } =20 -static void rb4xx_spi_remove(struct platform_device *pdev) -{ - struct rb4xx_spi *rbspi =3D platform_get_drvdata(pdev); - - clk_disable_unprepare(rbspi->clk); -} - static const struct of_device_id rb4xx_spi_dt_match[] =3D { { .compatible =3D "mikrotik,rb4xx-spi" }, { }, @@ -205,7 +193,6 @@ MODULE_DEVICE_TABLE(of, rb4xx_spi_dt_match); =20 static struct platform_driver rb4xx_spi_drv =3D { .probe =3D rb4xx_spi_probe, - .remove =3D rb4xx_spi_remove, .driver =3D { .name =3D "rb4xx-spi", .of_match_table =3D rb4xx_spi_dt_match, --=20 2.50.1