From nobody Fri Oct 3 18:10:15 2025 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2BDE2253FE for ; Tue, 26 Aug 2025 20:56:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756241791; cv=none; b=nuAvOxavehHpl/l1e4NWvviSRqirmykOt9r0XLR/hI1MKSZsy4QiOLUSsGYQat485cL0idqoWn+N6OIeSio7vX3iBwii89zQjNstRsbyuXPa8PZo1YL4KeVkOMr/EBPrxRO0AztneALscQKLV8QMcP0/lLN+cGspA3cjuUaUBlY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756241791; c=relaxed/simple; bh=nI8xu3KIEajYGlBiYCqw1m4Zcn63CxE5+8UzDzA5g2o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hhdoA7Wfn+WZwRo0UN+VuMlFMKX/mDFwguMuFmxCHQKa4at2jfkGR3ZTivMEau7q1uwKlmkx6nJ8DDZSaYT4igmNgqNyrwlTMuui+i4RsPeGBJ6U08ouan/Y6CuiLgVhE3GixZF3djcb+RDkLWROpoweOR53uW8xQnfZTl8QF+0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XRgdwATw; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XRgdwATw" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-770530175b2so2514285b3a.3 for ; Tue, 26 Aug 2025 13:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756241789; x=1756846589; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=13eUYaWgF2/Nh4T0vIZSvkzZBvGNF1e6n77XFGF+zTg=; b=XRgdwATwXckwJZs/vV+OmToIdvp4h4YfWGKho2MZPKa5lpdlgBFiSZ/Jn8QPFP779j ZfSg8f2JRWk/lrB1VcJlOKbYTtLIuG/OAm3YksH9o2dSO8lmPQZ/pviRv5zYgQct9SuI tJ52OI4DdNHbeC0g1DwXrDtJYCnjSmbYUkoUcGdZfiKYGiqY4teEsR8ozHKt/8Ltt7gh mCdP42oWsIRN2i7Wc212IqYCemBywUYuUN4ScfmVDNQWN48rRQ26AG8PCNLSSdHkLmWr nmVivUB8ZV1GwbwKzl0hO9x5HazpCk9+lWdOtmG1OYyR4QqBhcSNcN7/h7WDVbBaNlQ/ ECiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756241789; x=1756846589; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=13eUYaWgF2/Nh4T0vIZSvkzZBvGNF1e6n77XFGF+zTg=; b=rEvJOJH1x4SIjz/tofVD2fFHsPuKx6/fV5cI21t7enEH4351K/dudxAwK2U1beriRs 7UvGWv0dm6Jj6Po01bpvBDadZML5TuEOblZOUUBFTieL7vrvU6SG0sAkWLtbPPsncvWe /D2BLyn/dkNU14xhO1mw6m1dm0u47iaelfcjFFszuXuKUYc8yDq6lfFPt8XSTNTrG4Ax dNOAsh7PBmnXBJzDz2aNG8abMdu7nL+ZwBV6q4lN/kt2XieIR0EUpbgkj2QLtJLLYZb2 epq88gc8f+BZl+A7pzY9gVbqJAEMr9L77S3Sf8rYxv+RyoqTkdRCYIIvI6D2qzcKOjYl 7G+w== X-Gm-Message-State: AOJu0YwqYZ+zzOwRvNPoKJjSyYhKqj97JBNzac6Tn7Lo8HwyZvO01sE6 8auXVVB5swMrg9hH0bMOtekf2PbEcKv9oVw9sMqA/KlDZUbuWcscb0+m X-Gm-Gg: ASbGncsoufivxcA7IBoTyxYFOyW6ou52P1Ov5+4VTPlYjmBT4GYaEfTgVHQlDfpMofR PUR8xjOL2rUyJ4lPz5sQCX50eiEYBcBGm9pew479aSPbqb3VJgA2OQQlrELCa97xD/37Z9GPRRV EQe3IxwaXmUjbfx+muKb4QV14C4Rfvzuf9b0qdkrdAFIZoElHBakRHDHGwevKIDaOfUMfDS03+i /mE83shfyu4Usqum7ltwrTkXTM7ie0rA0pBHkrvgqiwDZ2SjHpH3ThgVmipDlezNResKdzjKwp3 RammF2GWOfQkJUi3o+9Fz7UHytIAhRC9mOI63VYbru8KBoGLXkXxMFBmnombhllWksq0YyczLIG x6alywMcrjmfplReumh8Fjz+5GRUHII4iegHvRrNbg//lTa8oz5Zd0A== X-Google-Smtp-Source: AGHT+IFhlIB5+rmQM4mUW5f08KcYHWotYT+bmRUhVcM2aNuDqBXEScj2FBR386dOVdHUaSBcALsk5g== X-Received: by 2002:a05:6a00:13aa:b0:771:edda:1b9c with SMTP id d2e1a72fcca58-771edda1de7mr8650847b3a.14.1756241789054; Tue, 26 Aug 2025 13:56:29 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-771e814cbccsm5817935b3a.35.2025.08.26.13.56.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 13:56:28 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Vishal Moola (Oracle)" , "Matthew Wilcox (Oracle)" Subject: [PATCH v2 1/7] mm/page_alloc: Add kernel-docs for free_pages() Date: Tue, 26 Aug 2025 13:56:11 -0700 Message-ID: <20250826205617.1032945-2-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826205617.1032945-1-vishal.moola@gmail.com> References: <20250826205617.1032945-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add kernel-docs to free_pages(). This will help callers understand when to use it instead of __free_pages(). Signed-off-by: Vishal Moola (Oracle) Reviewed-by: Matthew Wilcox (Oracle) Acked-by: SeongJae Park --- mm/page_alloc.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index baead29b3e67..f5ab7d5bcbd7 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5270,6 +5270,15 @@ void free_pages_nolock(struct page *page, unsigned i= nt order) ___free_pages(page, order, FPI_TRYLOCK); } =20 +/** + * free_pages - Free pages allocated with __get_free_pages(). + * @addr: The virtual address tied to a page returned from __get_free_page= s(). + * @order: The order of the allocation. + * + * This function behaves the same as __free_pages(). Use this function + * to free pages when you only have a valid virtual address. If you have + * the page, call __free_pages() instead. + */ void free_pages(unsigned long addr, unsigned int order) { if (addr !=3D 0) { --=20 2.51.0 From nobody Fri Oct 3 18:10:16 2025 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2566287252 for ; Tue, 26 Aug 2025 20:56:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756241792; cv=none; b=C/XkP7N4q3+dCKRjgTs4C1OOMfNL8cxzcmDsz2dDG5XIxaYz3rsMuhAqpsVjFWC7hTngA+pAliOOV/OmneS4hIp/a6K02rrciR/JzBTIttxVlwMYCW4lVdd+KFgBFaJeno5JGwsYY8cxCtSazzkAvaJQ4fiNlq1j/rj6Qy78QII= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756241792; c=relaxed/simple; bh=L9mBqIG1TiHreIDV8a0dfjkIxduVLSZagZOu8X4AsI0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ORxNRgcsM6QQVXlOCA0tqBO9rz9rSiHsafZGQCM9HTRUnpiOLypPOUiWxiYS0IsVMvSuHepT/hGJpVxOHfuhRfEeGGcMFTAAJfRfDLFUAiyApLVA/sCMohAF/IkUg02rBjqfLbSZOYo9a6qq8Lan7djRvWqFo0b8zYSCyM9eBK8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bG+njCu0; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bG+njCu0" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-771ff6f117aso860128b3a.2 for ; Tue, 26 Aug 2025 13:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756241790; x=1756846590; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p96JFKpspRPKBmH2rgBynj/gu4bh0EGooQeUZ0NhcIU=; b=bG+njCu09Q0gg3MORvVbazy5TRZ3xu+yMKXQ+CWOCRoyNWIHUixAoTVxJE2dodewWq bOOhFKjAe3JXn2TSkXOzGbsXjVGQgUxpLhZOOyJ8GIlcAgzkz7chMujVSyM0uBF9TAMS hZJAWAYM0vRY0VoH1U7D5zxlWBIpW4tO9Yck8LtVaNzbsvMy53t9NB+5iYqIsn0vMv2J c/cddTu6TPsY58D7/uGqBYGa+P6LjxA9yGp8ZB6kGqV3dY5pFRk+hb3BYmshplLZztYZ /6CnYUpIMM7eIks8X15zRr8jN1kIqMJWtcoUbYRgcjsLlPPD3dB+OIlCh6/7ITTK74xE 1RVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756241790; x=1756846590; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p96JFKpspRPKBmH2rgBynj/gu4bh0EGooQeUZ0NhcIU=; b=lu93f+eK4+rCXaBYL7YEDPiyn0XmhcJtFVCH0gIcSGxLXohdWrRYL/bSVqxPHADiyh cTrydnRWc0jIfbBSC+Q2kSYf3CqlsoDYtaetIHfUAm7QwF42ug3db+BFuZmOONndBnMs gSI050L5k5dULOn2JT/1IYIkobjl7z4lpCaPKyYALGcsCGYfP7YihpkUfiTkVozAPbGm s4l8jjkmZ3sP+h7gnqCKuw/QZYS5Pf4nemNw6+iiZBnV/Fg/eF8rOYjUlm8u1x1yhwMa kg8tpV2Mpsb9NuyslwDLQ9RWT6HKyne4hxJhgEwxbLRwMUZB/KY7dvMDDaxElbjIm/gY TjkA== X-Gm-Message-State: AOJu0YwYZB5PUsNLQCvW37h6ojmzHGVjZDBtNS/4uoPvPA/6saft+qf4 W6+3wTZcb/6Z66XU2ZCfQ9i2GPbQz0My48S6sgkJ7ERvAB7pucGtE5Ri X-Gm-Gg: ASbGncvZ7FA1Z4IhcQOBt34wRKZLmSCpYeESt/Fc1H92dtdz5C6f4CSM2CEQPgpBgNk pZ9lYGoh7xySaiTBR20B8/PaOrb/nPPJBNU/QIBKNFeZNiHa2ebnBj7WzO2pP3//7ztA5X4s3us MyutjU3CZ2oJiz29nsSVOYlpQmqQGSf3w19OOK6SikfZbvuAa1tUab19kKc8c09yMAa5pn5+xEp pQeTg78fdGs8/dLP3nd0F01SKSszFNCZjAs+VFOESve3nmVc3KupQTs8SVYYKmfAKy7PPxOaPCa +6kr6N2Okpc8l39akb702+DeA5SjwNTU8/H1QCNosr/z6qBxRyNe/uaFTRUCh0akXaCS9sUMXeY FyJDqOHohSMpyqD412zoT8ibAm7FvWW+PaDF+egbL+8CDl7llfFLLNA== X-Google-Smtp-Source: AGHT+IFOjLvK0nFgsEOyBO46ifHUqODgHu2tpGV0k80H0vvFtGAR4qckJwDeMLRyP7djf61/uqXYGQ== X-Received: by 2002:a05:6a00:1387:b0:736:5e28:cfba with SMTP id d2e1a72fcca58-7702faa6402mr23492301b3a.18.1756241790196; Tue, 26 Aug 2025 13:56:30 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-771e814cbccsm5817935b3a.35.2025.08.26.13.56.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 13:56:29 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Vishal Moola (Oracle)" , Justin Sanders , Jens Axboe , "Matthew Wilcox (Oracle)" Subject: [PATCH v2 2/7] aoe: Stop calling page_address() in free_page() Date: Tue, 26 Aug 2025 13:56:12 -0700 Message-ID: <20250826205617.1032945-3-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826205617.1032945-1-vishal.moola@gmail.com> References: <20250826205617.1032945-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_page() should be used when we only have a virtual address. We should call __free_page() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) Reviewed-by: Matthew Wilcox (Oracle) --- drivers/block/aoe/aoecmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index 6298f8e271e3..a9affb7c264d 100644 --- a/drivers/block/aoe/aoecmd.c +++ b/drivers/block/aoe/aoecmd.c @@ -1761,6 +1761,6 @@ aoecmd_exit(void) kfree(kts); kfree(ktiowq); =20 - free_page((unsigned long) page_address(empty_page)); + __free_page(empty_page); empty_page =3D NULL; } --=20 2.51.0 From nobody Fri Oct 3 18:10:16 2025 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FF9E2D3A9E for ; Tue, 26 Aug 2025 20:56:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756241793; cv=none; b=g5kARQ4gT2PAJo7slOurF6yo1fPdN2TKXY/uLjpMhvZoqVJ3Xir3dxTM7yjZDrIsrMUy3j1vriKhl3hvZfzvi77KJ3OQ2bae4UrKfDcIZM+1/zgxW/tUxUywryFCc0C3FSMxndKXhj/6D0dyqnDBpUlU/797C2WxSHFkm/Z9vhA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756241793; c=relaxed/simple; bh=b/wlUMk4IKuAZ2GTwA8nDxHIbo2jrk1gE4wdCrMx7R4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KCG9ei28Q+LSLVxhbIjQ19orKNeZKa/bNRS+8A3juCDSlNwwY+dx6umbVmkVUxP8IQOHQfAduxwVkxwxhguABZV+/GDIKREO93NpODNIAi+NNSdeVNSbT9coGrSgG1DSUls8y+WztVrgc8ZH6lmpaObEUd6BNqqkYjWHm2bW5Zc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nDwmr/dk; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nDwmr/dk" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-76e2e6038cfso6892694b3a.0 for ; Tue, 26 Aug 2025 13:56:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756241791; x=1756846591; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u3RZecD6lOIXMEN4BMHwXQ5RekIY8XyyevlTW2TRt7g=; b=nDwmr/dkL6QDBsRQjdIJIKfJvIlPoqn8IwlQ3tewsEXr5FBDCgjpa5nH/8HWKY6H7B vXj8LixWm3L7AaVo/5+8bTFMmOHZ6OpOwRm6Q9wNVhU8C1SKusyBixX7cli8fme1I/EM LoAz3SQUoDZ5sA/qlYgIA73QYWv+oN1+obux/GFSTHgXRlfxWKfcLwd+NNr2y58rTy1X Qk9OFJVxHl8LVydFaHuci9MlF+c97K6pPEbN9gkxmP8HdL16QzLUgMNzM+TxR9KO4NXA 5uMZ1I/acQOoXKbQsoO2xI0/bTZSFP6Azo/JBM115uvWFKYE01Q93l2MZDEOt/uLjmUz MgcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756241791; x=1756846591; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u3RZecD6lOIXMEN4BMHwXQ5RekIY8XyyevlTW2TRt7g=; b=ExlHbKuVYAtcBBKr3VVT4vjKb2Y7zEaHJ0FlJGuicu+obF24HcuIUQP16GHPyIblmE F4MMXjTqAe5ZJFg9KsPvxM+LXXf5C0Q3mvfiX1iumyP3cBPzNHPYMA/Mz7myKY3Rx3Fj 5mt9WBZO9UuW2juQKCtvuzq0DtO8rqJh2lSMBDFdLwdTuAeZtPF2apybok/emaM2DxBA JIR9Niu2SsVXpYo7cbFMyxbEoou09yxIWM50DuEBWp4QUe9qp38MwTCyIN8NabcfvVxw GQKsTDqh7SL67QHHRs0dX2vOOp6QKYe34xHIhRAn34V+jmEkAxZ3tN6vORLVQz3xkDv1 ZxEw== X-Gm-Message-State: AOJu0YzQ/rw0cFNUfTYTy03fnHWLL7euSELhkeLu1WyAer7wiIS3FgL5 7TY+pqzpXxRWFP4vEGF1srkpNl2R1TQgNe2I+g27Kt6rMzmC5y7Y1zIK X-Gm-Gg: ASbGncuQXPtv3ryNxeiBjg8J1so77YIouFxLr7V7Hxq/R2tOB8sNlSrrRz/z5mO32q4 ot8KBCJPuDWbNT4JbWa5UjmUxFW3RWh6xJdVTloQpn+jeBbhPUg92nFyzGauOLZNvUmkdD05HPr kdL8nd5bKHby9+QnO3UeCiX1KMPjoJaucQKfZCqOy9FpdT1UiK52L1u2zzitWLoFddZFXuUNLHl +YrnpGo1lSuQqOIsmV3coIPzoaQc4XDlx674HMM/b0ewJxsTZKvz/y/qxHaddkLjvEjLdqyl+Mr 7GGh+AbpaAl+gODgfxEoTvDRdH1QZTnuxbuC2ke5QYNnL+pZm8JtRN2CQim6QgpYIN+DQg+mRPM hxrA/4NXawYNCxTyDYpA5/mR6pk9SFaq/SZGgFDZJgVxnUzFMSoFZhA== X-Google-Smtp-Source: AGHT+IFkbp2G3sEZhy+jI4BFP7keK5NV3wYCFzstA/KajI6AkUNi7BbF/X/7dqdbsObKoDZF8Sv3xg== X-Received: by 2002:a17:903:32c7:b0:246:b47f:9b01 with SMTP id d9443c01a7336-246b47f9ee6mr129856455ad.17.1756241791330; Tue, 26 Aug 2025 13:56:31 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-771e814cbccsm5817935b3a.35.2025.08.26.13.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 13:56:30 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Vishal Moola (Oracle)" , Dave Hansen , Andy Lutomirski , Peter Zijlstra Subject: [PATCH v2 3/7] x86: Stop calling page_address() in free_pages() Date: Tue, 26 Aug 2025 13:56:13 -0700 Message-ID: <20250826205617.1032945-4-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826205617.1032945-1-vishal.moola@gmail.com> References: <20250826205617.1032945-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_pages() should be used when we only have a virtual address. We should call __free_pages() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) Acked-by: Dave Hansen --- arch/x86/mm/init_64.c | 2 +- arch/x86/platform/efi/memmap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index b9426fce5f3e..0e4270e20fad 100644 --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c @@ -1031,7 +1031,7 @@ static void __meminit free_pagetable(struct page *pag= e, int order) free_reserved_pages(page, nr_pages); #endif } else { - free_pages((unsigned long)page_address(page), order); + __free_pages(page, order); } } =20 diff --git a/arch/x86/platform/efi/memmap.c b/arch/x86/platform/efi/memmap.c index 061b8ecc71a1..023697c88910 100644 --- a/arch/x86/platform/efi/memmap.c +++ b/arch/x86/platform/efi/memmap.c @@ -42,7 +42,7 @@ void __init __efi_memmap_free(u64 phys, unsigned long siz= e, unsigned long flags) struct page *p =3D pfn_to_page(PHYS_PFN(phys)); unsigned int order =3D get_order(size); =20 - free_pages((unsigned long) page_address(p), order); + __free_pages(p, order); } } =20 --=20 2.51.0 From nobody Fri Oct 3 18:10:16 2025 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 428392F7468 for ; Tue, 26 Aug 2025 20:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756241794; cv=none; b=bh/IQI9aVlZOzKFq8M9nZmIoFzxZg7QDphaYRnChvP+m4UHiN1KK2wKE5mO0Myl64QgRNN+TcsE1BaqPo7A4FSiOgjr3ygM9A8RVNG4HeV74GObDSP6I4wmrF+Fk5IgNxfRTaXbJQDMX2a491vKHe4qCawDW0sDTVAVMHLpQj5Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756241794; c=relaxed/simple; bh=hMxsFCbfS4FNJ5KpQPQ814MUfYn5DLMes7LkACjORbM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZH0dGmW3JE47iZQpVKtS0Os8GCGESG+KDaVSol9P280pO1eN5hfMl+n3VP17/i9SFiPgcjqd/ILdongFhPYWBIO+tI5ZhLuaA2bY+gYxO68tIK1matevHPHDgD3VDskfX54zLNWgZHmu9vB7PCviy9PZITfkhcV8qaBZfJfvTsY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H6Hdri7B; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H6Hdri7B" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-76e434a0118so7084283b3a.0 for ; Tue, 26 Aug 2025 13:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756241792; x=1756846592; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tE4h8lAMatl8zOgx47ZsHYZprqFSGIay3bVnFsp5zpE=; b=H6Hdri7B9nt9poRXEIAJgsb7/fDLImstBpVxp0c031FYVFkJCHjDpF0eXR4Pf1sTT4 CkZeW+kpA3v0X4F5k3360D/nWK5R3L+mmtDsldtwUQ1ofMaeBAB5+qs0IRV0qwOgdbvI Wf4jWjZpXp2pU+JEtb94aeXG2xiAuUF7ZzutpMAFy/GjsDO3/YyUjEFWl3Y0BRSC5Xk2 xXiq6qFBTN8QulMjzhMdLfqgBBVv245E2MrNZS4Bvqt0+aN9W1T2dIAN7p/xtQME2N9C R+Ls2fa+Dfddv4OrGSobfmlVOs9LhXGvIXkzUe57SzOG8/5+OxrlpzPfgVluZU6Dxqty U2nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756241792; x=1756846592; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tE4h8lAMatl8zOgx47ZsHYZprqFSGIay3bVnFsp5zpE=; b=FvGz+t5aKNEZqhbDXdD9undK/gzjIqwyAfKGOduRLfehjeDmJ63DY36GChgNfcH9tf K2jcgz98Qk9C3lUd9h87Ix7PfiBQyFp5XxTiZOIp+16jI4GPM9LxnxzfQge1wa5y8Ln5 TFfIyDDTd2rxMz0QAeI+/NXuAe0vPbCU+O9ZwP8koaN+kj9BcwsOclrdbsVcrrc0fcUK 7iXit0OepsM0v1j4aC7Y4ThsIXO7bhgRoQPyRFU5ycfC1olkNWgU039ktiyf4IResz6+ x0fkWJ9gJwoQi/8QLulTXpPHZ5dyliRDg6UBf8FH+7gx5O3IEDEP1jgkEC/0PvBD9rVo Ejjw== X-Gm-Message-State: AOJu0YxqqMF2qwOL6Rir16Y9YzYTyrb+efahLwJdLrQsAlONAKJi5Whf 8noBguIqLuQCdIuSUWMr3ldlUCz/nvah1PyjPp31aLPgQwlOx836B1Uv X-Gm-Gg: ASbGncv0WGGEhJWLo79SYr3LwIAzeO0Bc0EdXSIjqN3N6Nk5kr2BgcdBWA6ExuxNrZc Eo/7RPBAro4JbKiF/w43ydEpxCcWihnAmn2SzmIc3MBQs6BeHC14luFCNDJ+2lpT+927icgT/RF NMP0A2QjRFFU36+UTPkuNTCH/GjviYKaBLMEQ7BdQVEm2ZXyEnVeLQzpOuQhv1bddHdGLlnX1yI +z4CN/g3EX1yEerHbjry7OUlOS+5FZg+eoGj1brbQvBuyYpHT/x+rDzs2RSu7DrcQvrDURn2rw/ DLnxTkxwFWRkDQ0YrZHUy0iLlbRTj0hk1KQ8+sClex3FCqeTLgkKquQoNGFWkvTtYuxfQpm54Xj LZtoM7AvWoAyJFNmuJiQx79KfRlkZHxBe2BKJs+5Nyn1QYf6hvXuWJg== X-Google-Smtp-Source: AGHT+IE/cTRK/9DLrD6W7x7VSwKVtmRq+MEUMw7J+ZbQGu720fz9Ao2X05nVX2flS6X87Ne4tC/Vag== X-Received: by 2002:a05:6a00:10d2:b0:76e:386d:94c5 with SMTP id d2e1a72fcca58-7702f9df076mr17387498b3a.5.1756241792456; Tue, 26 Aug 2025 13:56:32 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-771e814cbccsm5817935b3a.35.2025.08.26.13.56.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 13:56:32 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Vishal Moola (Oracle)" , Paul Walmsley , Palmer Dabbelt , Albert Ou Subject: [PATCH v2 4/7] riscv: Stop calling page_address() in free_pages() Date: Tue, 26 Aug 2025 13:56:14 -0700 Message-ID: <20250826205617.1032945-5-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826205617.1032945-1-vishal.moola@gmail.com> References: <20250826205617.1032945-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_pages() should be used when we only have a virtual address. We should call __free_pages() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) --- arch/riscv/mm/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index 15683ae13fa5..1056c11d3251 100644 --- a/arch/riscv/mm/init.c +++ b/arch/riscv/mm/init.c @@ -1624,7 +1624,7 @@ static void __meminit free_pud_table(pud_t *pud_start= , p4d_t *p4d) if (PageReserved(page)) free_reserved_page(page); else - free_pages((unsigned long)page_address(page), 0); + __free_pages(page, 0); p4d_clear(p4d); } =20 @@ -1646,7 +1646,7 @@ static void __meminit free_vmemmap_storage(struct pag= e *page, size_t size, return; } =20 - free_pages((unsigned long)page_address(page), order); + __free_pages(page, order); } =20 static void __meminit remove_pte_mapping(pte_t *pte_base, unsigned long ad= dr, unsigned long end, --=20 2.51.0 From nobody Fri Oct 3 18:10:16 2025 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48D1D2F9C32 for ; Tue, 26 Aug 2025 20:56:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756241795; cv=none; b=g+rCbDDsuc49JnMWA9+vlasFuaJnjTmbC5u5iiLjqSpte46/8UG+01pxsm0XcjPKR9tcs3jFBQdatXSlzwetFwZA3nk9gC4RkC1jid++C+yA2pA92cduQ1FWM18rbzu5/g313gqJ+dcz6lJ/y7idgBnC+oPr4n0lxL6sTqD/muA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756241795; c=relaxed/simple; bh=pnFkkjiQb7RHUiaHaDH2a5S7Nv0DdMBx4OFEHLl460U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VGwT0CEXRLRkHLlTVliJptAs/QR+uj0thLUP3Ftf+68+6fB8hsc5EO1tkTqmdb5HLpAz0Trs7cB/fb2QuiW+/f+sBNXymbB4JW7ySlgIpJfvL4QDp3zxwfVRINC+eP8K4t6ITJwjyEFLIC0JNarOXcCtmJ3kxiIS7UPIK4xqGpY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dSG8NVPE; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dSG8NVPE" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-771eecebb09so2566846b3a.3 for ; Tue, 26 Aug 2025 13:56:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756241793; x=1756846593; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QhymPbMl1maujeQhGMIXlLhMPhVkZ1BpuEab9k3C4eo=; b=dSG8NVPEIn9t1GrlZosoSMuhd3bIgve0m4qvz5aVF2dFK3l9FWfdQc6McqXfBP30WA rCp3Gn03HMudj5D6zHqYTjaFEnafJyK0UiOaoM3OBxGUnQ7LsWWDeC6xMfPTlcH+HpSm ISiFfvKhen518dXK6vwGVLBcJU2m9b287eyRPFgIFoSu7dPtHbG9Q1iRAWyh1UFpFmrJ 33tHQR1F7lVM7nN7hr/5lx7bQRTxlWok9XzER7khJDIu+niZ1JKZi10voH4Sa4LGqWDi voDPVYXdof8SWKNPzE1Ihp0UItpJDsId48fQocW0mnpQY5cXZ/xgfmC6Z//o01HW6/O0 GzYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756241793; x=1756846593; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QhymPbMl1maujeQhGMIXlLhMPhVkZ1BpuEab9k3C4eo=; b=wG3W9qUqkB6rjnweJ1c8gpGDa4aJJSZTi4T/t+bykq+bVhzkA5nwBaCTq7ZZ2dYL+k Xy3tqptnB2BOd7toX2LjiHzjgRoPcGkWFlbFA/EX91F94WMW5K7QRyVVBrwDPG7vp4zP V/dfxjyW3JMy/4vfq9C6ivDm67pGMRpofjsM3mBUVpMtfeRWeRJ2BXW4Sh7Iu4kk9G2a 2QzoQ6VcSM8yi99DDOg7es4IdYj1JLwaXrmSzO6cobYK1YPIdFfN6FkLGijWPNzpj4Q3 geiRtGo9HLn0AbuDJe4yPf7LCn9mmRMz/NejP/XawCD5AX7mHXmu4EUePtGhLg+N444C KclA== X-Gm-Message-State: AOJu0YwJo/LgxM1HOvpZZuriYqt0zA9nXL0DNBbAD9Z51l+NtA4VZbkY vY+gT/rmznEiKDL4rR8Kspp4yZ7ORS908bOKm/anG36n5eVljl8p0/GG X-Gm-Gg: ASbGncvwYXCENgzBEUKk05OnslVqkMm3gu96iMgW/xgA32wP/VPeJYSVjkE79Mi/h/B 16iiIKyLD1wumNtAVP2C2EDDZf74n7CjhziNMenqcl4ZVqXCf3a5l05YGxUoLKqeqZ9TaKGAlHL /DQcu8fVQkM4JfpdYyLJHFzG1uw4B2x5QRQ3E16tlqW9Md/xrxaw5iZ222pxFizkv0OvG60W6HU taAjpE5d/wG1K45QcizkUHYfPH9qrdB8m0XkByS952veSg3wXKFi41my3vASeJ8ELJUMbeGSI1H iRf1l58cXtAMPApJRuPv76Ndl9ZcbWhhf6R6XXBFEuffVYSah505gI3PgvBCSOjz2weYwT3bSNH pXQ5Tmki20fIdNqQJfyI0qWsVOgAKWNKLqgNQaOajHHZ5Spdxvir8dHzLjjY5aqoU X-Google-Smtp-Source: AGHT+IHyoITETX3mMO6OFZ+cbZSRTX/76LzPMEuMpyUTUsY4GlXP9qWB1WRt/5lzMarXBlKb/H7nPQ== X-Received: by 2002:a05:6a00:2441:b0:771:ead8:dcdb with SMTP id d2e1a72fcca58-771ead8f33amr9122485b3a.8.1756241793611; Tue, 26 Aug 2025 13:56:33 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-771e814cbccsm5817935b3a.35.2025.08.26.13.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 13:56:33 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Vishal Moola (Oracle)" , Madhavan Srinivasan , Michael Ellerman Subject: [PATCH v2 5/7] powerpc: Stop calling page_address() in free_pages() Date: Tue, 26 Aug 2025 13:56:15 -0700 Message-ID: <20250826205617.1032945-6-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826205617.1032945-1-vishal.moola@gmail.com> References: <20250826205617.1032945-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_pages() should be used when we only have a virtual address. We should call __free_pages() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) Reviewed-by: Ritesh Harjani (IBM) --- arch/powerpc/mm/book3s64/radix_pgtable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/mm/book3s64/radix_pgtable.c b/arch/powerpc/mm/boo= k3s64/radix_pgtable.c index be523e5fe9c5..73977dbabcf2 100644 --- a/arch/powerpc/mm/book3s64/radix_pgtable.c +++ b/arch/powerpc/mm/book3s64/radix_pgtable.c @@ -780,7 +780,7 @@ static void __meminit free_vmemmap_pages(struct page *p= age, while (nr_pages--) free_reserved_page(page++); } else - free_pages((unsigned long)page_address(page), order); + __free_pages(page, order); } =20 static void __meminit remove_pte_table(pte_t *pte_start, unsigned long add= r, --=20 2.51.0 From nobody Fri Oct 3 18:10:16 2025 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABEA931A560 for ; Tue, 26 Aug 2025 20:56:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756241797; cv=none; b=JS4HdEfVb2mpM+WrIy3JrGZH6Uqm6rh8PrzAwv73C410X2EyiBJAPu/wSgjciywJwCaVOW+/qpETLgglFX2p5R2sE/uGWANRurV+/lLluraV9c9DtJz+bzE8Ml8vPVq1/ucgKAbTD7tXmnFR/CmbciPKku2JU010745Imb7kmiI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756241797; c=relaxed/simple; bh=EF782+62IHDbVLD3KMl5vNoUe2viHMRQ2eStiiAsIR0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y29wGr8GXR3X/t5gZd4gmss2CTVF3tILp73Ic3Ul/FkeqoPeeZTbRQOfbi0KxkQbiJTTuRYsd03KHJdL32FrSwnTGLtf65H6e7nMXztdLV7c34ad560eJ0DW/VTkwfNOv/aWMBGgpIXGEmYDUEo1dBAOZx4iZUud66S0tJyja14= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SrUQP6jh; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SrUQP6jh" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-771eecebb09so2566868b3a.3 for ; Tue, 26 Aug 2025 13:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756241795; x=1756846595; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YzlN+dsEa0DyjaimvacceBZBAxpbehfow7bvljEAvnc=; b=SrUQP6jhOCQZuLDzFWSHhMPVGwzEIuG8quWnOrOboB7lzywOcQ7o7uqiYaSPVBcnzD tkakv14gnvVmNINoX5lkSxY0H2jIIe083wuXK3pOdH3mEj3MzlCJKHaDDMXSDHBgJW4z cBfpsFVoTcMasopraoSpnNrQ720RZThjiSKslXjiW2E2lLHQv/9iN04XezCpRIA09M48 efONZKKxc1e1iZR1Q8N13sGw6xg5BerVX6KvkOvfnmGCt5jqF6jg3M6S0cotLHNnPkJJ wqmmPWbXPl2IXTC0yI5yT3vs16EEVVkMIVJdHkAfTpESXhUlmjmc/NEcSesYnst6N/3a JAGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756241795; x=1756846595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YzlN+dsEa0DyjaimvacceBZBAxpbehfow7bvljEAvnc=; b=xIKUZ6uGmz2MD1AQCIMF4TE3ZkrLWHF13GbxnrmCZmYayr5Lhy1s+cyoLF7sXHlXFP m9ES9sNiMIqhObEdAy3bhBhEXogYJw6zUMeQKZCAK+lusAiM6hwDpl8mhKEC29XEln+V ctR4P1lNnyQYtacG3tyzasS+eMluG5RhEiTqN5ObEysXUP7XmktMZQ4xiQBFK2MPGoSl Di9I90l+VSmKpVRfz0FgoTL5Mmix4CVnV3lZewtHyHkj3SNe8UTvijDSsdnTB7dvMd9h yE/mD5HJn1sreG+K+RMyRNcotxnW4+CLFl2+mwYlEo+vvuX0//U7ar96hvVLv3WJ8rXO /8Iw== X-Gm-Message-State: AOJu0YzmykQMafHJZD9nTvdzn7n2+z/AdEiOnxzXr8If7zMz2Gk5J5iR qJ7vLJoVZCRI+qSN1Lr7mkv8AH+PIlI9HFAGbztEvHfcyaJaVXmHlYjT X-Gm-Gg: ASbGncvAn97Mc3PiFR9RDx5cdrKy9dBNWFVUpGeduFqtQWZDhZ7xgkE1zNHsZ2R1Q2v D0QxZk1zK/UBKx62KSgaY6GqeYpHmU8rdbngOAIHUmgNwalRDX3VTRfJlCdmlzAS+mk+8NSyelJ R9wNRXr2lVI4mD9LtbwP/XHownW39Ezf9MfMUhIiMJQTFTxQ5Wftf9Qn7hO9amUfJmHbQ1yXtrW EC8Svd5Hui2RtAMLQ7OL0XOukoBSOM3fHJ2EL7WNLYfZ7oGX0crIwepGtpUn6dua1OKaVffWSmL BukYBy8CfXX/jatkmlgWHR8c2nX1/vxEsT540KzbZeblbjkLggCjcDAmBtJynvMMelBroidcY1p Z2+eB727l8NtTsAxzYdVnbj7Gv0JtoE+DAkI8Dr+BOSzLSFFpwi6URlaVZFMLx7+v X-Google-Smtp-Source: AGHT+IE6v8CNLQIgw+Ku+i/WxqO4TvinQJJMdkDw3LTLIMW5yYdgZnYjPm9+vx14ZzpiizsAY7GNkA== X-Received: by 2002:a05:6a00:10ce:b0:76b:f01c:fefd with SMTP id d2e1a72fcca58-7702f9df093mr22128819b3a.7.1756241794935; Tue, 26 Aug 2025 13:56:34 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-771e814cbccsm5817935b3a.35.2025.08.26.13.56.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 13:56:34 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Vishal Moola (Oracle)" , Catalin Marinas , Will Deacon Subject: [PATCH v2 6/7] arm64: Stop calling page_address() in free_pages() Date: Tue, 26 Aug 2025 13:56:16 -0700 Message-ID: <20250826205617.1032945-7-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826205617.1032945-1-vishal.moola@gmail.com> References: <20250826205617.1032945-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_pages() should be used when we only have a virtual address. We should call __free_pages() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) Acked-by: Catalin Marinas --- arch/arm64/mm/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index 34e5d78af076..e14a75d0dbd3 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -843,7 +843,7 @@ static void free_hotplug_page_range(struct page *page, = size_t size, vmem_altmap_free(altmap, size >> PAGE_SHIFT); } else { WARN_ON(PageReserved(page)); - free_pages((unsigned long)page_address(page), get_order(size)); + __free_pages(page, get_order(size)); } } =20 --=20 2.51.0 From nobody Fri Oct 3 18:10:16 2025 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C96AC2D3A9E for ; Tue, 26 Aug 2025 20:56:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756241798; cv=none; b=ffntFesQI2fjeTUxyolgHf/+PIcJ07L39RKygsJzOUOgkQNnkVnNhL21cXNMJtivHw0D+rXnrukaSLYqtfOgwiUAJ7vPtVqKww4meacikDEevWTPCN05yHdRJkUJkBJMLd8WySCxGIKHlP5Fz8LOn1lFDxz2Q7Mfl0sQTKw3UGg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756241798; c=relaxed/simple; bh=I3YlcR743UmBO/A5EEOfxkHhiTlsZGKfV4Y4DnxMy6M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dDrkw77eneT1XKuaN00YSDoFYCMfOxPoe0RvfZRJvd+JtSYqUJvKx3+iadFQaStYF+GTqEEMu0XEonf2zPjowaDAuSDYsQg2NsY4bqj6B/b9H7IrihwJyqqfEE7uzBCnLxPBzYUnusM8uZ8ZhEQwS8OoBjC+0bKt7wg1xbYjUc0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dTVzSWM3; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dTVzSWM3" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-770593ba164so2627040b3a.3 for ; Tue, 26 Aug 2025 13:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756241796; x=1756846596; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UgrS4RlDzmuPVEoYRuL5n3FdVX6RzYDiuXN16UyzzCo=; b=dTVzSWM3Glsgo+xOjmq0C32He7qHq3aR7jn5j4VfSo/uIL6uEqCMqiycRmn58AQDfL nNP+199ESl4Gw9YdnY9FH4WgqZPcmve4WYRTiSNC0WMdjh4tmotToEa+Mgv7WqqfFPUl SyN5OR3emZ16144ehcgvfxQuBdKjDr43YVGFPAJ6NysFB4kAtdSHtQocHSALEGJVlqvH LCwOokyjpj+4p0iI1HjYVW1r0NUK5hJinKpCycKkfdbE/YCfjGBIOXvPQ4goPZ0QZJ+z /eqOvPv5vxeodKeJJVeEeUr5YwDMMVXwtwGBoV2WvVzTQYz21+bu0lg7x3vIR8uxYfVM cStQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756241796; x=1756846596; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UgrS4RlDzmuPVEoYRuL5n3FdVX6RzYDiuXN16UyzzCo=; b=wT2auomS8EqFNNQ7xR3yHC/TcIv0U9mF7yHpcpAaAXFC7QfshHAgAe1E/aZa/QFWY7 NR027h1Y3ByDkYuSGOg7LzQrGD431bjwHNN3xTloqRYlOMC8O0A2jGTAsmJ3ziwYL2gO nn4Rjo3AyoyMUWE77L8QKxSBhna+E6NQ7wkJt9UouPzVYWnUS3tfKFTboSlnBXVCXoK+ Da5o2Ztx6KjC1QXBiIoAGgUOTjEXWbbNz/sXimg1F+alec+Oxz3ZA5yHB8yQTRBThMqd xSCpuuo9h1ag8nLd53HYWqdVLrewd4HSwC1ovt0xRxIc3zYO7th5yQBe/19gZhKIn3rC gxvQ== X-Gm-Message-State: AOJu0Yyd2vNYzDX67tLIOiR5VygcGQq3gtztnREqM6vFviYlTdxIaoLw notj+Rakebl51yebwR+wnMVyXyCRtAJ4RJMWLzK8nkfA/K3G/r3MSRFP X-Gm-Gg: ASbGncvaCJtKX3YIVBfeYNHgzVMMQrfisWePEJlWLlJA0bsDEHE6gygP6OjXRhRkVLD 9wQ4k/yh9nsc8WtJDKfae3w7LFPYsJvUOa1TA5tAUf8Mru+sFaP3ntlZxVqTopSdzAyTe51bfcR McIP+r0UOuSVYL5x6GMkKAK6QzzyGeG/yOoqNalIiMwuExZRw/SJW6a1Hl7X2flPSBL9DGvPX8t lqgoIuicGH6Wf+7NMaHhDIAbmgSmF7UhlHnu3MUb/aTrikaUNxBWCB8jCqC09l41Qe14BdHJqsU 3+NkprEYmAMv1szVEhHilgY17kNDkgXef68ERQ7GMyYydr5JqL7r6uOV9nm143vJZHLOvBQqQoh QocT/5Lhu3goAogyoABD7EIW9d3mpwMndE9n3RVHVh03LkImrGkZYUQ== X-Google-Smtp-Source: AGHT+IEbOPgwcWY4znAzk+xsxvGrwmBJQhhbWaA2d4cWZJEHNQJ6Rz2YR1r4+4mBHFS8WJ+nt+eFzQ== X-Received: by 2002:a05:6a00:398a:b0:76b:c882:e0a with SMTP id d2e1a72fcca58-7702f9d8ebamr18348240b3a.5.1756241796134; Tue, 26 Aug 2025 13:56:36 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-771e814cbccsm5817935b3a.35.2025.08.26.13.56.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 13:56:35 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Vishal Moola (Oracle)" , "Michael S. Tsirkin" , David Hildenbrand Subject: [PATCH v2 7/7] virtio_balloon: Stop calling page_address() in free_pages() Date: Tue, 26 Aug 2025 13:56:17 -0700 Message-ID: <20250826205617.1032945-8-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826205617.1032945-1-vishal.moola@gmail.com> References: <20250826205617.1032945-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_pages() should be used when we only have a virtual address. We should call __free_pages() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) --- drivers/virtio/virtio_balloon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloo= n.c index eae65136cdfb..d4e6865ce355 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -488,8 +488,7 @@ static unsigned long return_free_pages_to_mm(struct vir= tio_balloon *vb, page =3D balloon_page_pop(&vb->free_page_list); if (!page) break; - free_pages((unsigned long)page_address(page), - VIRTIO_BALLOON_HINT_BLOCK_ORDER); + __free_pages(page, VIRTIO_BALLOON_HINT_BLOCK_ORDER); } vb->num_free_page_blocks -=3D num_returned; spin_unlock_irq(&vb->free_page_list_lock); --=20 2.51.0