From nobody Fri Oct 3 18:10:14 2025 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7092286D75 for ; Tue, 26 Aug 2025 19:33:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756236838; cv=none; b=cKDCKpxYh0Mt4TcN+Yi6Dnt2kcy650nqqZjQnuFMTXR1JcQXPP0kDHZQREwRjhJcAMzSBg7LDW04d+GZMEGTjb9yqNtWudpCVtgB+oej2KSPBZG6a1yS/LeDUIsrVvd+kf7DZBnlmlEBEwBneKmybAgMOfqno1VDa0oZEFXxAmI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756236838; c=relaxed/simple; bh=XEUtA178Np+YuNPcMuKC0ZZIcWb4D73TaClMxlLUWj0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ouq5YcymHYyrAwQJv/xeb11p4sY89kyMJZsFMwc4PgrEd1L7adKNGsHOzXug+FlXTmiO97buG3HY3oEIQP+PeKl9KUF9MThJxftKPzTfxLHxp/RWpkxLzkLQ2c8OwW+zDjoMWalMatsc7se1qYFpGz5xNx9UMMpvP3VHLvRjfuM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=efJU/Kqh; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="efJU/Kqh" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-771f69fd6feso1723223b3a.1 for ; Tue, 26 Aug 2025 12:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756236836; x=1756841636; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=csL4vcqUsLMqelmQE03dlwxPXsPoNvqKRUsp+93HhyE=; b=efJU/KqhYt/RMs0QZYk6h7RIs4Wa2hpbkVOF+TYxDr5halKH+qFAccrE6+kDRq+9W1 Y1Wx/rvigFyhGkoheKJnmxj6aR/1Vis2q4tEAVTUHoFkB9ObnB8rl8YDzLChS1DP+BRR V2mgBTe46js3JB2KW7SK0lveTQed0XSDsyv3IaSR5MFhc30/ZlYX3G9vBLk2fq6h5d+b C8gLns1g3zSCfe98L2/QvWW54WN9x8WL4BmzLCoQoaaiomnM7zgoCF4Xb3BDMlvqbbES FhumJ3xEP5JqqYqJSBpfjEctvEcV9QIb2KiwFTddUEFPAP81IeqDraRrN06VkPBwDtdH s8tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756236836; x=1756841636; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=csL4vcqUsLMqelmQE03dlwxPXsPoNvqKRUsp+93HhyE=; b=SslKYuAHaAO1PqjKzWnOns3FXdIm86D0I8rQkNOccJ1qQLsCZDV3EvcHNCdgUrie00 MKvMJC+g+MF1hX8YecZWoo/hCOlzAfCm18OJJIDvditBx/CpL7jYttuAvSKNkqcK2xfF 3aAeDPru7uUJoQ2yE+S+z9eAHW0tee0LHqsM8iEeCwl+Hx2nM4SGUCXLAHdxaFHmcRY8 HBqLbtu3M/4AcRaAxnABII7MMDghFhO0LajCLXB+dSC8DojCrHmnJ7Rugn7IN4BwPGHK fdNKdUD9n+fy/sM+aDZnhokYvqPcSu+5n/cMiWOqQh79qHDqBLFNJ0PByLEe5ZddZMut /YMg== X-Gm-Message-State: AOJu0YwKPhcyDw/JWFiWv6Bd78L6jiRbFxO8z6CKtRea5TxUBT/b6phh mw06/um/qZrTnMgT5Z5ia+Dt7tWkQ4tdMVFNsrMi4l1CxB7yoFbT5wVq X-Gm-Gg: ASbGncsMQUEedJW95Ra9IUJisOwMAKAw9U/uVaOxB3DiBXrPhjTzISJaaYKR+hxuiSB Wp52zS4EHC8J5LxJuo39EGtsM82xlkI8JUtrB9rD8c7FRhGyZwibDcAXR2jrQgf9GSC5bsbFFn4 IRfYQC0b9B808GFWdotbWZflwdZanoOxoEpTUmnovm3HYXeeAVZGaS4gir+kv9JoP3rUErTyjA/ aN4UO9zW5k9WcwhQrvvkg7XPA+nyxz0xs9iPlsroRFvUzWV2sn5Xl6uGOlIiY7dLGIU3UNrJkso qSxXGU12L51+K+Pof5Z1G1a26aAQbsDbnau1QLcSEZjNJMDwR2SRf+PE/yoCxXVgwqO8DAaXdom Q8fULLyO4iRt9U6aalBS2Q4RdD0Mlwjk1DBnKTxlBIYSGwFdvfwbiHg== X-Google-Smtp-Source: AGHT+IFvzr6myYSmZn7HrektYJv4R8WVw1CR1DW/e8DWy+bQK20FC1CA0a5NGejv86A+cns81qBXwA== X-Received: by 2002:a05:6a00:2991:b0:770:374c:6c60 with SMTP id d2e1a72fcca58-770375bb1b7mr20607989b3a.12.1756236836077; Tue, 26 Aug 2025 12:33:56 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7705647e03esm8054053b3a.59.2025.08.26.12.33.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 12:33:55 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Vishal Moola (Oracle)" Subject: [PATCH 1/7] mm/page_alloc: Add kernel-docs for free_pages() Date: Tue, 26 Aug 2025 12:32:52 -0700 Message-ID: <20250826193258.902608-2-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826193258.902608-1-vishal.moola@gmail.com> References: <20250826193258.902608-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add kernel-docs to free_pages(). This will help callers understand when to use it instead of __free_pages(). Signed-off-by: Vishal Moola (Oracle) Reviewed-by: Matthew Wilcox (Oracle) --- mm/page_alloc.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index baead29b3e67..6ee8f450c078 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5270,6 +5270,15 @@ void free_pages_nolock(struct page *page, unsigned i= nt order) ___free_pages(page, order, FPI_TRYLOCK); } =20 +/** + * free_pages - Free pages allocated with alloc_pages(). + * @addr: The virtual address tied to a page returned from alloc_pages(). + * @order: The order of the allocation. + * + * This function behaves the same as __free_pages(). Use this function + * to free pages when you only have a valid virtual address. If you have + * the page, call __free_pages() instead. + */ void free_pages(unsigned long addr, unsigned int order) { if (addr !=3D 0) { --=20 2.51.0 From nobody Fri Oct 3 18:10:14 2025 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ABE42F3603 for ; Tue, 26 Aug 2025 19:33:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756236840; cv=none; b=CwdbCu96o3tQPlHFPj0OvsoYfIKyWIxp2drOI7HDXM4Kq6WFmDGCmBY6OpXwq86QpiJOeVUDElTVMkDGzEd/DbBqBsJKLw1+a7C9rm3OyroxppZ0YICXRttNR3413HUOPgs0a/iFZ91UHdkiUU/F0/AxPAuhPLPYh7R1Wrdmuro= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756236840; c=relaxed/simple; bh=5v73ecJqH0S1coNLyxMXXxj9qAe7vvsx0XftmkhBJiU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j97J2FLbbb/x/QZ8HTc/iEbi5d9+j3al3PmLzryet+6P5VVznVBbz0Ysfl2/U2DlcgCcV8GGOkhLDSGOVxVkhf9bssf17bTpKALOKorXBKIcHLHcJ7KazxQeBUbY3p0Ig65RUL9ANuFCHKuuQZidAUpA2m2jvUp+81yPOEb7VPQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vzhc+x5f; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vzhc+x5f" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7704799d798so2656169b3a.3 for ; Tue, 26 Aug 2025 12:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756236837; x=1756841637; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i+rwqTqsm/ZsZGDIt2sbK5HdEEIm0ZDAp49YtE2Ezew=; b=Vzhc+x5fZl9z8JL6x4zhizJuvSYoGktOPjniNmAT0R8fg6iQps4YiKJG7Iwt8Q6I4x EWnyEXjfVjbDXtVwUJ4icoM0NtA1H2LpLxWYk6RtlQ++r+7IX7pKZdEr3bRvg+PJL04+ ElNYRTfWJtyTY7tK7Y0x3MyqvAQYA+yFMZrQv+mRjaGzJNal0hU/BqbQXzSkK18F5OqR Vvz9WIUqrARgrxOHd9fsyUee4BPrJxVKE3N6tVtBCjy9pQZdJQyCz5j/UZhT+ASwzFop kKCRhuxnaAsTLkD64AsHDmlXbeoNu3yCtNCHEpckj1mCTBvH7DNGisrp+rQDrQRsu4Ci rLRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756236837; x=1756841637; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i+rwqTqsm/ZsZGDIt2sbK5HdEEIm0ZDAp49YtE2Ezew=; b=u3KuE4Iha197t75VK1fQ/E0LejCe+st48++o8KeXd3PNpr+iirkP6LrMF3dsWL36tj zksKeYEmA666zU6oqV31st6JpYGRScVCBziqn679hTOoMiE5LrrVDpQBEmhsL4wYPO/S 2z5/HQZ7siGh4R0XOFVPHAHkSFCdsk7xTkeo8eFRSftKT9MtoR8/iUvHTiusY1q5lMPf LmrxgldtOvO5Z7xFRIJ6x5tDz2VwTvBQo10puBe8MDwOWdyLN20zNlhuTyaQBRk0wdNf y6/RENF2xJagTHTJI5oYJsTwYUfJP7LRQ2Y/9O+tTJ/eJHDhOTPKC0VHziT04FIe2jwK rvUQ== X-Gm-Message-State: AOJu0Yykv4EcN/AEVfbhOcbEgn/+TwK0VCHWGWcMYo9YqfR+zRK2nH5L 5WxNs1k67c1Rb66SVPqLSJl86zwZSDBasDnJWVytQ1BQNCf2L9MoBmk6FB5ZZw== X-Gm-Gg: ASbGncsgWMRNgbHoWhFG99AzBLCY6RNQWXA3Npl4Un+4fSRmxcyAeGm5HuwnSsegLTP bGARvPRxcDH8puCcZB7fmsgQA/l8EOXQB2odaQFFf6rSIJzNKtu6ELBpWvgKhz8BS8wsfrYY7sR u2BXL5rJSiE23UnVPBEWHHWnbniliExGPoLgvdm5wSwjlEOmj5MhsmCn+ys/6Ju1M3KEUEpfAH6 YtIkBPCQo1xwANXZWwmjB3nhkvoi6l4pX6HgcyNdvd+f4eEpHr0hW5vZ6QYU079S7Nb8fd6fqmn 6y1gqXyEWq2JQncH9LjfXmj8sKDn4UeMfWlLKi2u+Hbk2gbGImkYRD8+69PD2rmk75EpFuK60RU gQDKjeS2ck8xaidqutlrfNvwZjDK5eSomlLn9e8EpQzeumrfNCy5VxQ== X-Google-Smtp-Source: AGHT+IFXNiHeLyR9ad6ENnhydukRYpHfL7W+c4d3otcDgB4qLzLTcun64OhpwzDFr6oUuvRj1X+e/Q== X-Received: by 2002:a05:6a20:a124:b0:23d:6956:26e1 with SMTP id adf61e73a8af0-24340d72883mr23281699637.46.1756236837321; Tue, 26 Aug 2025 12:33:57 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7705647e03esm8054053b3a.59.2025.08.26.12.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 12:33:56 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Vishal Moola (Oracle)" Subject: [PATCH 2/7] aoe: Stop calling page_address() in free_page() Date: Tue, 26 Aug 2025 12:32:53 -0700 Message-ID: <20250826193258.902608-3-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826193258.902608-1-vishal.moola@gmail.com> References: <20250826193258.902608-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_page() should be used when we only have a virtual address. We should call __free_page() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) Reviewed-by: Matthew Wilcox (Oracle) --- drivers/block/aoe/aoecmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index 6298f8e271e3..a9affb7c264d 100644 --- a/drivers/block/aoe/aoecmd.c +++ b/drivers/block/aoe/aoecmd.c @@ -1761,6 +1761,6 @@ aoecmd_exit(void) kfree(kts); kfree(ktiowq); =20 - free_page((unsigned long) page_address(empty_page)); + __free_page(empty_page); empty_page =3D NULL; } --=20 2.51.0 From nobody Fri Oct 3 18:10:14 2025 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F2D037288F for ; Tue, 26 Aug 2025 19:33:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756236840; cv=none; b=mRm1yGs+TkM99i0ZbLFJLYc8C2HJHFDg3K3ix4Bcmoms2LVo7iJ0tjIgZMi1ZagQbUANr+vBUvNzELchGav0p2V59iX/iirDiflfXJUdMUWmwmK41tmxQqxSHH2rca+m15bcLsj0GSNmWKrVUoqbodBZhpvGJeUKrBk+8NoFnCo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756236840; c=relaxed/simple; bh=b/wlUMk4IKuAZ2GTwA8nDxHIbo2jrk1gE4wdCrMx7R4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HE0tdqJUPpLWCkLztstg2wvXhEC4WyXiD6aS1J/tfl+nDM98A8GcHMGPzJaFYUeqrf9R6lT6ViDqKefo669nYjfbKtQwoJ//5UjSb5KQyZRJ4SU9mIHpmaTqx81rrbcYzzGnc6JopQ1ve0KqSfT/6eeuua4B59b97RHCGBHIGw4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WHrGdUL3; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WHrGdUL3" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-771f3f89952so242389b3a.0 for ; Tue, 26 Aug 2025 12:33:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756236839; x=1756841639; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u3RZecD6lOIXMEN4BMHwXQ5RekIY8XyyevlTW2TRt7g=; b=WHrGdUL3FJSoSAVGTXGMv4DRGOMlEmt2VmvNCsHj0OXMtHuPDnJ7F3S/A5XhvOVq8Q leYiunZxw4P4Kw41h2OCRu2M7s2Tvyeu6QRmcx601iu1BU2kZZe9fADjIwYbFY2JQ0s5 cb5TDJRQbfiAVvo8qSkkJ8ewQL3pOvzyHBrb5prnDGJZZWSGZTat2NQDAI/wArV9MLJ0 LbhArQjnVuxFAUkAUjcxLQsQN6CDzRbp1ge/ETH3KvhSsFad8AdwSiTLaTTHk9HKiVcY plS1AsYxhZA9rT/6WZUye7gf4A/422JlAZ/BS9Oss8bB0rsOeReLIvLRQRfBnm0c11NW yx2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756236839; x=1756841639; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u3RZecD6lOIXMEN4BMHwXQ5RekIY8XyyevlTW2TRt7g=; b=TAQCE+yAvr2eEruyXZl0R9BhR0SN3EsWdCVvGlyxhOrt3zxPQ5e/TEOcUY/SYTHNGP 1DRa4VJKuBb1FpN0l181FUU/31ZAHict+PIrEhFD9MyyevzajELQ6WAQiHJifsICK3V8 lRzMiFTVU5+GAkHSCpfv+5CGn8uzAaCt0iZkrMx1czdrnpq63Zv/JySwzxBOsujEt86p /T90rsTXPdyAwyYw83q/GFaiUCnAtO6AACYf1zTau7GrUFD6Y5nMKDd2Vm9xnjqiQDFA K8b3Rg45cUIp2V6iXNesjWSm/v8CcUEmTktQ7bZgOyE4aDHft7jd+LA/k8iWAb6zHx/C vH7w== X-Gm-Message-State: AOJu0YyNezOOU3FwCZMrDctfecHu8fzZd9Eg5I5+XSKC7ToSCNPatxUc p/CkkEZotcVLlL4WVRBkYrD1eb08vhptdEVqM56a0iRQfvCONwoXWIep X-Gm-Gg: ASbGncvwKtg8Cr8j/W1IMiJz+78Qk1gHrdZeQBOUFC4Ryl3n93TAbQlM03U0wJ5yw2y IO/glplFZk19OayG9+u4QfmszGkvvDZ9g7pnKHqSzNGbP4624hTGqOkrn4d7O5uN5of1RYNmF5T yYDQACTDOMhBNI6Z5pRnqvpE7h1BxSbExGRb6BNLWSUMEW9qmEUEa+oxyi+a3EdgqyKStOc+6Ae gaset4869uayMF/+Jl2+5n8Hwvg0cYrNQOHGtPR4DDE+GMGBUYEWih5unyPU05rmi8TBC0vZsJf PT11Lk+lQS9Vd0wGDI8O69HEZTkyaCTc1gPsuA3MWbpWCfDq70nZE8hjwvCLYLgoFnIy5UDiMSu 8A94UwNcYnfizwGZsNd5d1LdA51O+6LGAq6lueSbuTHz5CT1RrK9JUw== X-Google-Smtp-Source: AGHT+IHlNUyW55X01A0f5EEFBXuViJGDeQdu3GLU6vSJt5YhnhB0dXsh/ZnXWPC1g92p9Hw5k0RjEw== X-Received: by 2002:a05:6a21:6d93:b0:243:27d2:61cd with SMTP id adf61e73a8af0-2438fad28f4mr3498164637.27.1756236838595; Tue, 26 Aug 2025 12:33:58 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7705647e03esm8054053b3a.59.2025.08.26.12.33.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 12:33:57 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Vishal Moola (Oracle)" Subject: [PATCH 3/7] x86: Stop calling page_address() in free_pages() Date: Tue, 26 Aug 2025 12:32:54 -0700 Message-ID: <20250826193258.902608-4-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826193258.902608-1-vishal.moola@gmail.com> References: <20250826193258.902608-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_pages() should be used when we only have a virtual address. We should call __free_pages() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) --- arch/x86/mm/init_64.c | 2 +- arch/x86/platform/efi/memmap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index b9426fce5f3e..0e4270e20fad 100644 --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c @@ -1031,7 +1031,7 @@ static void __meminit free_pagetable(struct page *pag= e, int order) free_reserved_pages(page, nr_pages); #endif } else { - free_pages((unsigned long)page_address(page), order); + __free_pages(page, order); } } =20 diff --git a/arch/x86/platform/efi/memmap.c b/arch/x86/platform/efi/memmap.c index 061b8ecc71a1..023697c88910 100644 --- a/arch/x86/platform/efi/memmap.c +++ b/arch/x86/platform/efi/memmap.c @@ -42,7 +42,7 @@ void __init __efi_memmap_free(u64 phys, unsigned long siz= e, unsigned long flags) struct page *p =3D pfn_to_page(PHYS_PFN(phys)); unsigned int order =3D get_order(size); =20 - free_pages((unsigned long) page_address(p), order); + __free_pages(p, order); } } =20 --=20 2.51.0 From nobody Fri Oct 3 18:10:14 2025 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9438D37427A for ; Tue, 26 Aug 2025 19:34:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756236842; cv=none; b=WX1qgH9ChkLinvWJKH+pfzURHdpo1au7s9yWpH8b/AdeAEOxFpD7cZfp4kQCo+Q4eAyEUdpmo0K0c9rUmYytVVNsXuv1Z58B7xtd0147GaFA4az8vXzudMpLgfe+8O/Eitzc235dawk7gUrCKVTsYJcb6dpjghuQmFBaxnqFkOQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756236842; c=relaxed/simple; bh=hMxsFCbfS4FNJ5KpQPQ814MUfYn5DLMes7LkACjORbM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O5qjcGLGn8nHcax8VSjaVTqRvUptxXKGwqzxvhc8dVSrYEdOTPAWHB7Ty5kSUUfW9Mko0BHWAc49jPt2hlXs5TPVoqnTYKb/vQPpnNPqz8Nw5EBXdk6pUPsUBE7emDZLps6ysG4z2ejaz0UZrEFTng3CzFlScCwED+V83BgGtQ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QFDhNyMc; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QFDhNyMc" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7704f3c4708so3994266b3a.1 for ; Tue, 26 Aug 2025 12:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756236840; x=1756841640; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tE4h8lAMatl8zOgx47ZsHYZprqFSGIay3bVnFsp5zpE=; b=QFDhNyMcZmjGSdzm1abnV/YLxKhJSGgfcXzRvN70wRE5/L8fQhBjXbDztCrbKfKK8N fe5XR+vFmMtWw/SB2Zu/9m7kFgnOVtImREUeIUIPx7oMdeoRXkf3be0fBMemj9jIjtgq 4LSvONwfYgm8PjBm0DVp89nYUxKevVryZTVbS0h3DJcYmWIcdkVUe3eSZV9FLwVzYvGQ l33s/hKKQM5gC53ZGrBFQndRL0cDYt3zUIKBRuyrrw0e7XeFoZdcSXChxb3rliiDZooy t9NYDAc8fQeBONUcGyh7z0Sn0Q8SI2FrbIgNbknXXDbJgY/bZ4Jy3ho6syueV4qkt6hE rLzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756236840; x=1756841640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tE4h8lAMatl8zOgx47ZsHYZprqFSGIay3bVnFsp5zpE=; b=KWSat3KqZBhzU0n+Cr1fbNWzj7Oo4GqD18WWrqGV7GhKvGYY3ZwX9gXdavtI7nHyMD 6jyUZmMscm6HXTMAJKGngjQ61YISaclQ1F7v/APS9sP9eOqmhQXaUNgtnALYvDDWQGfL 6MtSKJuE4sLGm5PgZ2NQ+aSVrGxJANkyzpafxYG8Y7DCJ3A1lPut1ibdDiBxDDjrMXE8 BhzzoI6LDhmtkgQYMCEGhZDKuAifBJjkIXh5w62L5x38kIhui5Dy2AVsiPGjzL9SmS7Q I7p3Ray8Bf5O/u7IrlLBnMhdeiGVWrW7Y4GHDy6z/h2s2NxYxhZClvceuDyRg0558KM0 PRtw== X-Gm-Message-State: AOJu0YyRAt38sjU6L9FBUeCneIoeH2FXR2eq9s2d3ZPnO3TtFGhcrksa 3c+MNYBbU0sSSRrQaCUX5GCfJhmG0zN4yrXdgDMGR+tHvRHH7atsKIgu X-Gm-Gg: ASbGnct/BL02yk7qa+hLnmJVOsrrJP0Ll/x71vlE1bb8JaxT5y5afFYBEzNivFe5tUe kT7yMLB3c5Ez33PrCBstobcWLf+smp9oM5x2xeAjOZiRe2ZBDt2KwFFV3MlO+Nsprumlur3mWsb xPa7k6sG4cIN8ebLnUCkaIBuLBLzaGUG6aEBTMhzhohxt1kL4S5FLROQC+m7LMReyrmg35KCd64 2h75JiuGsg63FSEVDL0WbSmc6LL8TV85WjT0S7HW+dihGH/MaKRoTQNU6jSXqnnIAoD5Qo7uKaP uIy7sAwPqyPMMlO9PxWhQ1SQmHzuV8kFrUY3o8eu1xYiqwB6Y/ByPRwGSUdFidE7RoPsbz/d7YR b9YrS+KvXfnRm2/Tn0/IMDaMiWky5c+O01iOYrouOiYd51VfuzNlMgw== X-Google-Smtp-Source: AGHT+IEt51Fm84l0Nhom4aT3TpUwGphsXYN6NCk7M5kBdV97xqhaPC/zdbIbDC37KHt+mBDSbo30wg== X-Received: by 2002:a05:6a20:729a:b0:240:a53:79fc with SMTP id adf61e73a8af0-24340d15c16mr25501499637.29.1756236839809; Tue, 26 Aug 2025 12:33:59 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7705647e03esm8054053b3a.59.2025.08.26.12.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 12:33:59 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Vishal Moola (Oracle)" Subject: [PATCH 4/7] riscv: Stop calling page_address() in free_pages() Date: Tue, 26 Aug 2025 12:32:55 -0700 Message-ID: <20250826193258.902608-5-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826193258.902608-1-vishal.moola@gmail.com> References: <20250826193258.902608-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_pages() should be used when we only have a virtual address. We should call __free_pages() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) --- arch/riscv/mm/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index 15683ae13fa5..1056c11d3251 100644 --- a/arch/riscv/mm/init.c +++ b/arch/riscv/mm/init.c @@ -1624,7 +1624,7 @@ static void __meminit free_pud_table(pud_t *pud_start= , p4d_t *p4d) if (PageReserved(page)) free_reserved_page(page); else - free_pages((unsigned long)page_address(page), 0); + __free_pages(page, 0); p4d_clear(p4d); } =20 @@ -1646,7 +1646,7 @@ static void __meminit free_vmemmap_storage(struct pag= e *page, size_t size, return; } =20 - free_pages((unsigned long)page_address(page), order); + __free_pages(page, order); } =20 static void __meminit remove_pte_mapping(pte_t *pte_base, unsigned long ad= dr, unsigned long end, --=20 2.51.0 From nobody Fri Oct 3 18:10:14 2025 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0E8F374294 for ; Tue, 26 Aug 2025 19:34:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756236844; cv=none; b=OyvcMWAknwz7qCNrDx16zH4M8gXwXgu6bUNI1XQUvofASEd3zEG/E+hWz09mACyXHGJXOSawlsXIFztR2hz4U88EuBslEFTLJdmH+3BH0jlih/VS+L2U/1esKw+ibvICeXweE721gk7bxqk0dgfQdk8yjfo9tYNUwkYbHhmDFs8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756236844; c=relaxed/simple; bh=pnFkkjiQb7RHUiaHaDH2a5S7Nv0DdMBx4OFEHLl460U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FEtCQIhgqqcwA1rl1S6pMuSJWYaken7I5sjCIouc30HYI+2ecMMlWyuGQQabuGmvmWpnm2caxR4cMktzo01ug2C9qnHNOHHx25xHVZ7IFlIWTygYuHBpYojGMYJjl/gIKS4b3/IFlKMjVMsUMSu9zib/WX66rVXtx/l05TqBKKg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lhZUp++w; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lhZUp++w" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-771ff6f117aso786117b3a.2 for ; Tue, 26 Aug 2025 12:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756236841; x=1756841641; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QhymPbMl1maujeQhGMIXlLhMPhVkZ1BpuEab9k3C4eo=; b=lhZUp++wtAPmgwglaE+TEMDABQlF+3NihGsfn0dmAZDOSLsuUVUn2R11P3eJqG+Qj2 nS3xPAzGlZ6p4TabmqKyO8xEhTPTuG9vE09hEqeariwIBl39XZzA2hnG81eULdYz4jri ecsjuuM//UJt7dSYuEG65zzI/IWwRh57YHh1Bh0ON970X23a4WuxcNwjeMLCs8jiH6kW MrlXVtthvSi6/H4P4VBe/fPpqpDyPcp/73bwhykjRin8tezSqGPuf1vfZdX7unsdLQV7 YMgxgvLUNOYgY14LV7NiF8MApjgpurO713Dmd0GChyCUy/6F5IYcUJmFHMDZULkbm8bP 8zdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756236841; x=1756841641; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QhymPbMl1maujeQhGMIXlLhMPhVkZ1BpuEab9k3C4eo=; b=go1orJOftq6/4kC5Dzo2ZqYYMrwaRuP5w5EBG5jqOFyyt9ronJtPx9QWbqnxjXa/hu 5E7l10q8G8FSqLGRLNN1McrpFs8PCVnmac5Sm8fyR0tIk9iSucusxGujmfW+zu6yduWu WRfyZibX6VvqJkZJkHzZ9/IIrARU77oLOakR9qce6lKHUpz8el8dL+ZW0ScsTdmoq2vv h5mKyliFPUcpMmE9KdgwkZxRWTzL1Z2rtYpEU8B3lHEt+2gN1rPo3fyu90Rwm4QExM7T b7t1dVcRGNxFhsNdny6hbTETqudRM/FypuivVDZGm2/Se4DHQ9CTtimYAsNnuvJRsK0N dYbg== X-Gm-Message-State: AOJu0YxqzKSYyBizgapDawLD3rVTHz//G29ea3VPHOi63jdZ+6/xcPQp 2oHYnzaX5q0UnOrAeayrX6tOBw4yoe8OHSnBufIWWyeX5mKe5T7w9BUL X-Gm-Gg: ASbGnct/B9eo74z06+DwCfvvkUl2WNjdSuj02AQCb8LLJcwlavsVIbQPd1bfYsi0Fkz 8vu5zFTk0kONI5zrhTSaTOPa9yQ18HJpCJm8G1mhIs8Ihlhmp1UxhWxr0caiM8L1lPUDzAfTbrR TbtNpTalP5iAlX04dD6059GvMqNO3XhSlzg05CU/X0HbLKaRnkhxPkYsCO1KOIlzCzLP9au7x1h n3GNBQSvO8jl0xDTpoF3AWv6UL6RkqQoZERiAV8+XCQvxhIkxzHFhAhKZvWxTRIKAUsK31kytLj Ne/TXjLP8iPRgnO4Hfx9aVC2xUqPQCrVnCNe8TrGoRhxQSlOwD+lbcxLW0s7KXMHQXYHDlrPm23 3RYX5jR14cqlq7Adm4P85sb9wFJm9wWmhOyjC+ihwUbJl+Plh7Wc2zQ== X-Google-Smtp-Source: AGHT+IFCoX76El2Mf5sfrILAjK6lmue1KJd0eRu5drBUMEuKmWziund+YR4+bkdXsg+VCXD6lKKhgw== X-Received: by 2002:a05:6a00:1a89:b0:770:5683:cc56 with SMTP id d2e1a72fcca58-7705683cd6amr10201780b3a.26.1756236841011; Tue, 26 Aug 2025 12:34:01 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7705647e03esm8054053b3a.59.2025.08.26.12.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 12:34:00 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Vishal Moola (Oracle)" Subject: [PATCH 5/7] powerpc: Stop calling page_address() in free_pages() Date: Tue, 26 Aug 2025 12:32:56 -0700 Message-ID: <20250826193258.902608-6-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826193258.902608-1-vishal.moola@gmail.com> References: <20250826193258.902608-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_pages() should be used when we only have a virtual address. We should call __free_pages() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) --- arch/powerpc/mm/book3s64/radix_pgtable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/mm/book3s64/radix_pgtable.c b/arch/powerpc/mm/boo= k3s64/radix_pgtable.c index be523e5fe9c5..73977dbabcf2 100644 --- a/arch/powerpc/mm/book3s64/radix_pgtable.c +++ b/arch/powerpc/mm/book3s64/radix_pgtable.c @@ -780,7 +780,7 @@ static void __meminit free_vmemmap_pages(struct page *p= age, while (nr_pages--) free_reserved_page(page++); } else - free_pages((unsigned long)page_address(page), order); + __free_pages(page, order); } =20 static void __meminit remove_pte_table(pte_t *pte_start, unsigned long add= r, --=20 2.51.0 From nobody Fri Oct 3 18:10:14 2025 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DB022F6572 for ; Tue, 26 Aug 2025 19:34:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756236846; cv=none; b=k0qxNssgVKmnfYpQ2VqvwwURTsmairssZ51Go+d4KXbvJR/bA4h1/Sc0LxxxMIljUstLySuZUJyBtvAYGHjf0naCD7tGOra9H+N9xFhMmwstgC5VlnrO1MuQHAfFtkz9qiZwrco8E4FC10k9NRg4sSgI9YqXBaQT9pwwslPzemY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756236846; c=relaxed/simple; bh=EF782+62IHDbVLD3KMl5vNoUe2viHMRQ2eStiiAsIR0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OrFGsDm+OKgVsS/MT9KPzh//QBcVceo2883wzfEwX3S6TsUXeBEY8jBbUGPrAb+qrXsadP7ETjKbtt53TLw/Ge5LqfbgGqEAOBvoQ0W7HbN0b+SuQqoFrF02qvShBCwh74PMBDAQZ2CeDXMG5WIdo8NpXCq5rx03SvdWZKeuvms= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JWhVuO0M; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JWhVuO0M" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-77033293ed8so3912313b3a.0 for ; Tue, 26 Aug 2025 12:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756236842; x=1756841642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YzlN+dsEa0DyjaimvacceBZBAxpbehfow7bvljEAvnc=; b=JWhVuO0M+xucjGleO6duyqw53sAMNJfDGGRajtTQXj4nddRuIFkxygGRVkINN+Sver zz3gpCxwcnFxWOPr83eI2G+mde3xoi38cldghj7s4UmCFhgJXPrzTgAUOxDOauoOW+kg wu34EbNVVq3yBdxCMfrm7UJ4L05WQ4RlqPfNpdFGDEnsI5BBO7oC/rKym/xe+Ev1JzzG f6aKM9uwV3eAfqB+Zm0j8xs2cB0uKIwizAI3rwWzw3/1IKbIOozjoXnB/js/L7/V79O4 807BNSasIOLc9eLGwqf8f23jJLXVS8owiGxF3Mz/w1suBYEKoMr/QCPSSYCMjBozpZ3z JNpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756236842; x=1756841642; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YzlN+dsEa0DyjaimvacceBZBAxpbehfow7bvljEAvnc=; b=cGl1u+8JAsXqrs1b+a5m7ce+411uWsnhT23o+6esDmzpCg5l1+2/rtaXwjUKLIYfum iCzjNsZGw8mu4rpMSnvq8wwx4aNSlKu/8poyVzU6P98ko1Va7Efn0y0OvsS+wETIQiEE //VqA1DXzCNu24jERVo0Iji2OYuwilHkIfte6IRjZGAyVtWH1FgHkqabqSVPJ0fFIBna 99AKgZoKrFKXDmEW+GNr37iVdaPMhKtQROWDXf+Am5Esp2yPZ/AR+dideqbiTMAYhOmn b666qy4EXWq59x+fWvG4eRMAiyMm2QLSpmz7zp3ilxYJ9z2N+Dh+P0Q5cYw7pDePWJtt jg9Q== X-Gm-Message-State: AOJu0YyW5UeXuxNq6msqjBiKl8YaftJChbXXU6Q8H2jl2CdTFppqHm3H rZs5COpIUOKZH6KOhpRnNTYj78r0TLCJZYH0T8FG6Sdu9HIYDSK5JQ2F X-Gm-Gg: ASbGnct9X+0X8GWNDALstOkqrEW+dpw7JUF3DgYt5OqYoIB/ivBGTmHliXdmY1FruIW 1zW888cLV3Yb0+AmmGc4Juz3DQp1+Qg8IqoFowTB2b8NjdelBg7R2a4HnKk/XxGvcDVPbvq+y4O cCbLkO59x6Wfx/m5pKYh2Bu08uum61kU0GOLbkG/tjehiJjk24QEssFTyyzrd2zf4FJQdA6vSQj DdAFsRr1nG4ZtjCM8fKXmZkGOhBayqi3GHxPQOnnDTJlfk01gHCx9uFJxF70BIasDowzNUTFXKS 8EmNv9AIdH8Chy0UJqr5ADVg/JZDuQH/ru2CeHCw01rpbPWoXA8i19IabBa2tIANePZVPXvagcH GAc4qPB4oM38tnVb77vSEPYZZ7vF3NAyin9zmbtYSYOjR2/vBAFU3oQ== X-Google-Smtp-Source: AGHT+IH4BJZMpmDBwjTODxEVoRjvrj3wIA0wcVLqavVX3GxXvO9+C4C22HXp1pSwIPrS0jFhWI5imA== X-Received: by 2002:a05:6a00:1954:b0:76e:885a:c344 with SMTP id d2e1a72fcca58-7702fad491bmr17378055b3a.26.1756236842358; Tue, 26 Aug 2025 12:34:02 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7705647e03esm8054053b3a.59.2025.08.26.12.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 12:34:01 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Vishal Moola (Oracle)" Subject: [PATCH 6/7] arm64: Stop calling page_address() in free_pages() Date: Tue, 26 Aug 2025 12:32:57 -0700 Message-ID: <20250826193258.902608-7-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826193258.902608-1-vishal.moola@gmail.com> References: <20250826193258.902608-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_pages() should be used when we only have a virtual address. We should call __free_pages() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) --- arch/arm64/mm/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index 34e5d78af076..e14a75d0dbd3 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -843,7 +843,7 @@ static void free_hotplug_page_range(struct page *page, = size_t size, vmem_altmap_free(altmap, size >> PAGE_SHIFT); } else { WARN_ON(PageReserved(page)); - free_pages((unsigned long)page_address(page), get_order(size)); + __free_pages(page, get_order(size)); } } =20 --=20 2.51.0 From nobody Fri Oct 3 18:10:14 2025 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9905237D5BD for ; Tue, 26 Aug 2025 19:34:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756236846; cv=none; b=eXNIz3eFfnqEBWKkFDOVVpN7PFMa+L2YBvJgDxnqE4qVwlwqmvIluQyM7QGKzpY4yzmpSu59OACXW6SJM058dfvZ3ipnhkdnJTRUuD/sra5wKdlU6wp3Q9CgKewkpZIjVDSrtkhzq+sTf2Ax7YFHCSK6c5QviRNYufir1Ls839o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756236846; c=relaxed/simple; bh=I3YlcR743UmBO/A5EEOfxkHhiTlsZGKfV4Y4DnxMy6M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CtLIM1IkOdeT26q8lJ098wmBLTL7jefDnKvuCc7wQR5ha1kcvQDn591/T6AQmK0yI81icbjiHa29/L3q51EVAOG6vcB6DUyLG8G9cXnnLxmzw1FV8yZqXtn8c3OuTSModBm3+x91zOc/f7N6r77W5Q3OsIwiz5Z11TrELw4ABEo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PJ1gMsyf; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PJ1gMsyf" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-76e1fc69f86so230911b3a.0 for ; Tue, 26 Aug 2025 12:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756236844; x=1756841644; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UgrS4RlDzmuPVEoYRuL5n3FdVX6RzYDiuXN16UyzzCo=; b=PJ1gMsyfHX4/J4XqlauKwVb8AeY5Z2NeCOLKFRKzn9scYqcdv84FZ/PVRfD11gMcqh 5MvlleOXndX/H/ch+3hhcBydQj5oOk6Vw9U4FWV4wbx4lwCbraJGPEaKBxnFiKf3PL18 +G2HcKNMNf2X6H/AuYEBLI4+CQoP8Iqcg9y0JBgr9ErwN3QOvt3IbMvIYjnRPMDipUcV CoC+8tr9NVvIjiX7xwqomZvw2zGTSnJnR64Doz6GIWlfmKfzHHMNdef6uiCFl17DsUc9 EBDpY2nEPRrx8Cxl/pYENgtWar7TgdTGtCkP3AKWThqTxOs4YBVt2Ne2XOCusF5hiLSQ fg9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756236844; x=1756841644; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UgrS4RlDzmuPVEoYRuL5n3FdVX6RzYDiuXN16UyzzCo=; b=ECrXZO6K66i2A3RPEMyVzr8CHjibUopDrIAHMTLbuU5QZc09TAJSxXnYm2F8x31bBT O7QyCIrZJbbxrUDwQ1eLCsRdNNakqI9PHIpnc6rnupmLvcpYXdlx6twgCp356xS/XzWq CZgfP5b4OlL8M4/dB5MSBtBVZIYtB0ac10qHu67SGIGrfaRiiy5/lB6CkG7gSKoeK50M qIKMgK9OlW5naChSUzM0lH1cTncJkhaE9gSichxq3EnJH9OeGR4SIHFkkquawX/BresR UKGADpvjINdNxNQsXDo63Z2Crsw11Exv9R/ssLbxZhyTKFVz8reGH2EWfW2u6gCozC4k i1qg== X-Gm-Message-State: AOJu0YxYIqtSSmQO/E/g98GcyPmA5zuAsEUWib1ca1KpV83H+6IPNUGi uJJnkCtu6JOb3maHbZne9h4pgwV3DOlQiU+GmmuunvAMfu6IrOcTSriTS90rvg== X-Gm-Gg: ASbGncu5KyKyMg23HHEHAeTxOJUQ5SUOukhfoAYP+z8wnCBiRkXDceDpqBnplTqLTwU SfIZVhovQZcGH3Gk+MZk8v3eC9Y5quRMh2x+WFvyKou3qaBiNCiaz89gbnA2oYDA9nLst5JM6x9 16tZf7+S/uewzV+nnH5ko8vEppIqRzIStGNrObjAoKgmLyDntD+QnomZnHeC+tiuaiUMzWyIA4i kvZ2U/WBTEd9ge9RozZES1OzJYXikXg6xbzWB2yvX8QbDQUWv3oY8cCJrcY+5bVFcTpA86vz7cC NLarFunBxNrGNLEM8/mxTUCHZ0u2tslvuTBbqJSpc8H8rVKUro1k6r1HDMpshiTplArcxhQ+06i HcVTCZguOLzM87woASuFwiIVqpeTFc6GcwtnBYA2WS1xYjZFSx+gk4A== X-Google-Smtp-Source: AGHT+IH/E8LX9DdP14eamZ2LRF4BG3tJOFJ+GpntOt1nypltTCHQQ8wSzlJBqbosmyTo6axuqcj0Nw== X-Received: by 2002:a05:6a20:a12c:b0:240:d246:dacc with SMTP id adf61e73a8af0-2438fad3083mr3720822637.10.1756236843741; Tue, 26 Aug 2025 12:34:03 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7705647e03esm8054053b3a.59.2025.08.26.12.34.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 12:34:02 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Vishal Moola (Oracle)" Subject: [PATCH 7/7] virtio_balloon: Stop calling page_address() in free_pages() Date: Tue, 26 Aug 2025 12:32:58 -0700 Message-ID: <20250826193258.902608-8-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250826193258.902608-1-vishal.moola@gmail.com> References: <20250826193258.902608-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" free_pages() should be used when we only have a virtual address. We should call __free_pages() directly on our page instead. Signed-off-by: Vishal Moola (Oracle) --- drivers/virtio/virtio_balloon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloo= n.c index eae65136cdfb..d4e6865ce355 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -488,8 +488,7 @@ static unsigned long return_free_pages_to_mm(struct vir= tio_balloon *vb, page =3D balloon_page_pop(&vb->free_page_list); if (!page) break; - free_pages((unsigned long)page_address(page), - VIRTIO_BALLOON_HINT_BLOCK_ORDER); + __free_pages(page, VIRTIO_BALLOON_HINT_BLOCK_ORDER); } vb->num_free_page_blocks -=3D num_returned; spin_unlock_irq(&vb->free_page_list_lock); --=20 2.51.0