From nobody Fri Oct 3 18:02:36 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.4]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9872E2E2DCF; Tue, 26 Aug 2025 17:03:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756227838; cv=none; b=sy/2rrweLnHC+1RaphjQsJOYAEgyhy9wMQ7HRQPY3IcQ63MXLbb5ZGPEVyLwjAzSUJgkI5gqErQwlJDp89ky0qYGmXxENo/rnKQ0RLy715F156FTe1nUh8U/tugFxBlff0mK/sa1U6ffya/La6+Ieqh5nLV7JUx17edOs1slgr4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756227838; c=relaxed/simple; bh=O7cKFTO7QqpMBpb90+ZeyEjE5vWm5wRDSmrWherjG/I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Ea+65ui9GLoYdFRIFTHE4qsrpguCWjC7/LnLtB6geLe+HeYEiVHRVTJO/pK8R7YbJINsFjt6GyIgfJAf3MBnVptkJHVC61IZDbmXDuWFXBTsdovEj5/yq3HTqKUdh54NHKRx9kBOh63ohvY6uDg/CPiQvBhSMEtHD4fGPkwTBXc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=jsYbY/1S; arc=none smtp.client-ip=220.197.31.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="jsYbY/1S" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=IH Yy5mF+8CJT7S/nW24UwyCSGso7dtsA3nfIjCqd0D4=; b=jsYbY/1SjK+snDp4kM rD8IgDs2iCU8umBlPqnwS4FG7J6MiQkzWLdc39aIqMPvGzMowrCoujpBIsuT+8rx +J8YwCcGplyntYQSLlLr8ZyO439RK9kojvrH2kZ/b63s+fUANR4Vwn5oz3kSDeov WrmLgZEm4PGPtgBCe8mZDo0Lc= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wAH5Svt6K1o9DIiEg--.25085S3; Wed, 27 Aug 2025 01:03:42 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: bhelgaas@google.com, helgaas@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Hans Zhang <18255117159@163.com> Subject: [PATCH v3 1/8] PCI: Add macro for secondary bus reset delay Date: Wed, 27 Aug 2025 01:03:08 +0800 Message-Id: <20250826170315.721551-2-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250826170315.721551-1-18255117159@163.com> References: <20250826170315.721551-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wAH5Svt6K1o9DIiEg--.25085S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7KrWxCr4rCF45KryfWF17ZFb_yoW8XF15pF Z8CFy8AF1rJa15Xrs5Aa18u34rG3ZI9FWjkF48K3sa93W3Aa4Du3y3KFW5WrnFqrWxXr13 Aas8C34UJFW5trDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pNJP__UUUUU= X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/1tbiWxO1o2it3wnvHQACs9 Content-Type: text/plain; charset="utf-8" Add PCI_T_RST_SEC_BUS_DELAY_MS macro for the secondary bus reset delay value according to PCIe r7.0 spec, section 7.5.1.3.13. Signed-off-by: Hans Zhang <18255117159@163.com> --- drivers/pci/pci.c | 7 ++----- drivers/pci/pci.h | 3 +++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index b0f4d98036cd..c05a4c2fa643 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -4963,11 +4963,8 @@ void pci_reset_secondary_bus(struct pci_dev *dev) ctrl |=3D PCI_BRIDGE_CTL_BUS_RESET; pci_write_config_word(dev, PCI_BRIDGE_CONTROL, ctrl); =20 - /* - * PCI spec v3.0 7.6.4.2 requires minimum Trst of 1ms. Double - * this to 2ms to ensure that we meet the minimum requirement. - */ - msleep(2); + /* Double this to 2ms to ensure that we meet the minimum requirement */ + msleep(2 * PCI_T_RST_SEC_BUS_DELAY_MS); =20 ctrl &=3D ~PCI_BRIDGE_CTL_BUS_RESET; pci_write_config_word(dev, PCI_BRIDGE_CONTROL, ctrl); diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 34f65d69662e..4d7e9c3f3453 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -60,6 +60,9 @@ struct pcie_tlp_log; #define PCIE_LINK_WAIT_MAX_RETRIES 10 #define PCIE_LINK_WAIT_SLEEP_MS 90 =20 +/* PCIe r7.0, sec 7.5.1.3.13, requires minimum Trst of 1ms */ +#define PCI_T_RST_SEC_BUS_DELAY_MS 1 + /* Message Routing (r[2:0]); PCIe r6.0, sec 2.2.8 */ #define PCIE_MSG_TYPE_R_RC 0 #define PCIE_MSG_TYPE_R_ADDR 1 --=20 2.25.1 From nobody Fri Oct 3 18:02:36 2025 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.2]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 20F462E1757; Tue, 26 Aug 2025 17:04:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.2 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756227844; cv=none; b=lFiS7O1sq2lTzmszgKhMbGOMiFRQZz73bYLHE0qQ4D5N3e6AT5D3rCdLQDbG9iwPphz/THWhJ1Gn+rO4vwrL+rsZAui3dG01VwMfjE2S35WA0oMpGQuXj9ywf08U//7Teu9ISOLaxJghR9px3L4rm3WGzEOAXoa0wJtocSNTIF8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756227844; c=relaxed/simple; bh=/lThjq42KooyqmXlxMvKPMrJ08XRA5pAEZauVmshh6g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qF9mJz3r1WT6KQHNc9Kb9NpeKO10u/9XzTdNyQBP5iJrJQdPR73r0hJF7IaewSP5dOD/24LCWdI0FuUdawYNCmjtT6R7LHpMtABUzYr32z9DAp6LpTeNZL/uJInF2LrDi66YfL71GqOvRoeYNJfpoqfPUie6/AatY4HfvdZ1OPY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=qb/tuKmQ; arc=none smtp.client-ip=117.135.210.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="qb/tuKmQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=s5 9stUkZ2Vi7i0+if4thqpzTsJlJVwgNFTSLSvzvQiE=; b=qb/tuKmQTZjpwrrUqz HWKDvh5jvPvEvzpMKDXKysl0Xbg0khmYRe9/cRrnJi/KeVuTA59YllotL+C13bKG UWFuaMH7UWG3KBxP8uc30kWkgT+pZK2Za1JXlKljhgd2xtVOmExsd8NXY9HYxInD F1V5RzzSAUaEIl747BnNHondo= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wAH5Svt6K1o9DIiEg--.25085S4; Wed, 27 Aug 2025 01:03:42 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: bhelgaas@google.com, helgaas@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Hans Zhang <18255117159@163.com> Subject: [PATCH v3 2/8] PCI: Replace msleep with fsleep for precise secondary bus reset Date: Wed, 27 Aug 2025 01:03:09 +0800 Message-Id: <20250826170315.721551-3-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250826170315.721551-1-18255117159@163.com> References: <20250826170315.721551-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wAH5Svt6K1o9DIiEg--.25085S4 X-Coremail-Antispam: 1Uf129KBjvJXoWxJr18Aw45ZFW5KrWUtw1xGrg_yoW5JrWfpF Z8GFyIyFn5JayfJws7A3W8CFy5JanxuFWUCF4xK3sYv3WayrWDuF45KFW5XrnrXFWxZr15 ZFWrC3yUJayYyrDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRYLv_UUUUU= X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/1tbiOhe1o2it5y8lCwABsZ Content-Type: text/plain; charset="utf-8" The msleep() function with small values (less than 20ms) may not sleep for the exact duration due to the kernel's timer wheel design. According to the comment in kernel/time/sleep_timeout.c: "The slack of timers which will end up in level 0 depends on sleep duration (msecs) and HZ configuration. For example, with HZ=3D1000 and a requested sleep of 2ms, the slack can be as high as 50% (1ms) because the minimum slack is 12.5% but the actual calculation for level 0 timers is slack =3D MSECS_PER_TICK / msecs. This means that msleep(2) can actually take up to 3ms (2ms + 1ms) on a system with HZ=3D1000." This unnecessary delay can impact system responsiveness during PCI operations, especially since the PCIe r7.0 specification, section 7.5.1.3.13, requires only a minimum Trst of 1ms. We double this to 2ms to ensure we meet the minimum requirement, but using msleep(2) may actually wait longer than needed. Using fsleep() provides a more precise delay that matches the stated intent of the code. The fsleep() function uses high-resolution timers where available to achieve microsecond precision. Replace msleep(2 * PCI_T_RST_SEC_BUS_DELAY_MS) with fsleep(2 * PCI_T_RST_SEC_BUS_DELAY_US) to ensure the actual delay is closer to the intended 2ms delay. Signed-off-by: Hans Zhang <18255117159@163.com> --- drivers/pci/pci.c | 2 +- drivers/pci/pci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index c05a4c2fa643..81105dfc2f62 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -4964,7 +4964,7 @@ void pci_reset_secondary_bus(struct pci_dev *dev) pci_write_config_word(dev, PCI_BRIDGE_CONTROL, ctrl); =20 /* Double this to 2ms to ensure that we meet the minimum requirement */ - msleep(2 * PCI_T_RST_SEC_BUS_DELAY_MS); + fsleep(2 * PCI_T_RST_SEC_BUS_DELAY_US); =20 ctrl &=3D ~PCI_BRIDGE_CTL_BUS_RESET; pci_write_config_word(dev, PCI_BRIDGE_CONTROL, ctrl); diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 4d7e9c3f3453..9d38ef26c6a9 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -61,7 +61,7 @@ struct pcie_tlp_log; #define PCIE_LINK_WAIT_SLEEP_MS 90 =20 /* PCIe r7.0, sec 7.5.1.3.13, requires minimum Trst of 1ms */ -#define PCI_T_RST_SEC_BUS_DELAY_MS 1 +#define PCI_T_RST_SEC_BUS_DELAY_US 1000 =20 /* Message Routing (r[2:0]); PCIe r6.0, sec 2.2.8 */ #define PCIE_MSG_TYPE_R_RC 0 --=20 2.25.1 From nobody Fri Oct 3 18:02:36 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.3]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F1C9A2E285B; Tue, 26 Aug 2025 17:03:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756227838; cv=none; b=H2pwXsxW5ArKOyq4E5QZSj3z3VKPbYKxEIpouSF42W/6+0ShP9I1kbrsDISIwvH+QFxu4FN+8ag2pP1BtxGvPh+rbpCr+yc2QADDV4t1pn0NzIcWE+wiEw0UYXSW8aLc24LF27oubj0aYF1lbxlL/PGBl83OCZCVZpwISih/TXs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756227838; c=relaxed/simple; bh=/WFpPBskMWBkdGVSacMhxhni4z2VHYUPoxSJMhvCRps=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RApVZNHukpF78U9VqbAjawTp0jJWbJ/jGz+cdaBs6CRgbIhd2EL0Wz/Z5TAIjdQWqFAjiEVhMSJ1UlM+PEZvjmpM78tjtE9hruKu1vJn009VNklcZ1OBon4gqsUH2vxax9ZYkJy0lyPtbSlC5OkyZfi2uMupvmjnYQeTx9zgdyU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=MuECljJ9; arc=none smtp.client-ip=220.197.31.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="MuECljJ9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=k9 vi2+U0ISlZpQf9ZsfxllqYwUzu1si7Y3nLS7lJb8g=; b=MuECljJ9l463ApcpWq oh1Ut2twyhVL3ktcTc5N4XUFpxCeea8KJ5bYwn0cbtSGniMlUizohCBB1xICvls2 JbngcfFBE0Vui8vk81vmaGRWOqfSnvErvqqBGIcthb72k17ExCeO6UbqidcKGAnF S9VDFT1zpL9r2eI1tckc3RDQU= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wAH5Svt6K1o9DIiEg--.25085S5; Wed, 27 Aug 2025 01:03:43 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: bhelgaas@google.com, helgaas@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Hans Zhang <18255117159@163.com> Subject: [PATCH v3 3/8] PCI: Add macro for link status check delay Date: Wed, 27 Aug 2025 01:03:10 +0800 Message-Id: <20250826170315.721551-4-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250826170315.721551-1-18255117159@163.com> References: <20250826170315.721551-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wAH5Svt6K1o9DIiEg--.25085S5 X-Coremail-Antispam: 1Uf129KBjvdXoW7GF1UKw1xur1fCF13trW8WFg_yoWDJrX_u3 sFvF4xWrW0kF9xK3y29r1fZrya93Z3WF4xuF97tFyfAFy7GryY9Fyjvr1DJa13WayrAF12 v3srtF1rCrn2kjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUUxR67UUUUU== X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/1tbiQxi1o2it56YcgAAAsV Content-Type: text/plain; charset="utf-8" Add PCIE_LINK_STATUS_CHECK_MS macro for link status check delay. Signed-off-by: Hans Zhang <18255117159@163.com> --- drivers/pci/pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 81105dfc2f62..f5f5474d9aba 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -77,6 +77,8 @@ struct pci_pme_device { */ #define PCIE_RESET_READY_POLL_MS 60000 /* msec */ =20 +#define PCIE_LINK_STATUS_CHECK_MS 1 + static void pci_dev_d3_sleep(struct pci_dev *dev) { unsigned int delay_ms =3D max(dev->d3hot_delay, pci_pm_d3hot_delay); @@ -4683,7 +4685,7 @@ static int pcie_wait_for_link_status(struct pci_dev *= pdev, pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnksta); if ((lnksta & lnksta_mask) =3D=3D lnksta_match) return 0; - msleep(1); + msleep(PCIE_LINK_STATUS_CHECK_MS); } while (time_before(jiffies, end_jiffies)); =20 return -ETIMEDOUT; --=20 2.25.1 From nobody Fri Oct 3 18:02:36 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.4]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E44E72E2DFB; Tue, 26 Aug 2025 17:03:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756227839; cv=none; b=YZUOJV+2kOrv5jOREd2wvK5aDN0mPDSLm2TaCM58E8WBXt8StGYdtEBFmfezD7OzvRUGF5OnrZ5JfOOud9lXSPkzoA69D/5uGv5pFzmL674tv0RtPPMaQSCF+G9it/RS7NYreRwdDF4vY4Ao74wsHT6bQowsDxTSfTSDRcq0HsQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756227839; c=relaxed/simple; bh=8SeQr4D4EiGpfposJmSR0Ueorh7PiGNe8AHplaaSQBw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ASHbcoXZ6kWqDni6TjcUny7Feh3C8ZK20GspOVNE5uFRKrSPjC7y+tjBI2L9M99N7LdvbUFS6TaWIzPIyIdDHUfYkSWrNNwKN91z4KGnGnpwuuBEZxT8ZeGvTsYrQsaoXM6MloXGmr0JR7NDg/anfWN+pApcgQ7B77QNXtFO2xU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=JyKHiyez; arc=none smtp.client-ip=220.197.31.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="JyKHiyez" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=fI Ms65ZBsalDj93zvT/al+hRSFG0BgGv7ziNOHFxRQ4=; b=JyKHiyezTBkyMrWUer a540WorBsVP9ri5h10uj7VGqLQn6PYu0795qsY5AiiY0LRVw6qwpoY5SqNL4jMkM VGFoNnBR3w2wkJC7DPuvDiAiODY4Uwl1w9xrGp3CQ/mJRkclH/9ldAHcoXan8dSu gh1ITapaIEKu/WnL00IpKfN3I= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wAH5Svt6K1o9DIiEg--.25085S6; Wed, 27 Aug 2025 01:03:43 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: bhelgaas@google.com, helgaas@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Hans Zhang <18255117159@163.com> Subject: [PATCH v3 4/8] PCI: rcar-host: Add macro for speed change monitoring delay Date: Wed, 27 Aug 2025 01:03:11 +0800 Message-Id: <20250826170315.721551-5-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250826170315.721551-1-18255117159@163.com> References: <20250826170315.721551-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wAH5Svt6K1o9DIiEg--.25085S6 X-Coremail-Antispam: 1Uf129KBjvdXoWrurW7WFy8WFyDZF15ur4rZrb_yoWfWrg_u3 4a9F4xCrZrCFyakFyjkw4aqr90ka4jqrnYgasYqas3ZFZrX34kJrs2vrWDZr1rCa15Ja4x t3Z8tr10kr47CjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRGfOzUUUUUU== X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/1tbiOgK1o2it5y8lJQABsi Content-Type: text/plain; charset="utf-8" Add RCAR_SPEED_CHANGE_CHECK_MS macro for speed change monitoring delay. Signed-off-by: Hans Zhang <18255117159@163.com> --- drivers/pci/controller/pcie-rcar-host.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controll= er/pcie-rcar-host.c index fe288fd770c4..77f45637b0fe 100644 --- a/drivers/pci/controller/pcie-rcar-host.c +++ b/drivers/pci/controller/pcie-rcar-host.c @@ -34,6 +34,8 @@ =20 #include "pcie-rcar.h" =20 +#define RCAR_SPEED_CHANGE_CHECK_MS 1 + struct rcar_msi { DECLARE_BITMAP(used, INT_PCI_MSI_NR); struct irq_domain *domain; @@ -339,7 +341,7 @@ static void rcar_pcie_force_speedup(struct rcar_pcie *p= cie) goto done; } =20 - msleep(1); + msleep(RCAR_SPEED_CHANGE_CHECK_MS); } =20 dev_err(dev, "Speed change timed out\n"); --=20 2.25.1 From nobody Fri Oct 3 18:02:36 2025 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.4]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7B65E3164C3; Tue, 26 Aug 2025 17:04:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756227843; cv=none; b=VXhV0Cmr3aVOgdvfS9w1bqbHcoM1v9IxryDXWf6bj05Q4fK35faYHzZ5ebMErr7SyUOsr7IVxVPaUrytIwLzzUsjPhYpuPb8S8z95AjGuLGg9/JFkzMUdXsomAGNXrj4l+A5wlTP644ncwozSyeiUDwmlE8tiDWIyT9RrLTYldg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756227843; c=relaxed/simple; bh=PzxB7EXeBBq9X2O62z17uIS37bPvHgJop7R2XpFEmRw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jBEe469ZyDq1tiMLlegrNTvULuSpuEAMVx8RWyNNhw/C/HiVNXfiBD7pADIR2jZP+Mr5aem7zxghSYvNEolNpgJcXigd1T0CSbNkz/CbJENH5RCzljh/arI/znLD+6mh7XDozgtmKza6s4oZq8SXYacHNGaiK26ElReupAQOYm8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=mE0XzSHl; arc=none smtp.client-ip=117.135.210.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="mE0XzSHl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=4g 5VH9wjrprzlXPzrZWyAbKi8qn1R+gMZhJCUpetlS8=; b=mE0XzSHlA938S0khqF VJvVS+1HYEKH/oBmJ0LKacE9nYG23k7CoU2LEDPSKyrDHZ0eRskyBPlJfPiIogs2 v8/aKvKuzIvdsSxIZKSDJoqSbKVJb4MkGPBytuuWBngQEykC2co6L4wDZhC3xTog QifynpIF+m/kx+4gDSgx1UwMg= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wAH5Svt6K1o9DIiEg--.25085S7; Wed, 27 Aug 2025 01:03:44 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: bhelgaas@google.com, helgaas@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Hans Zhang <18255117159@163.com> Subject: [PATCH v3 5/8] PCI: brcmstb: Add macro for link up check delay Date: Wed, 27 Aug 2025 01:03:12 +0800 Message-Id: <20250826170315.721551-6-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250826170315.721551-1-18255117159@163.com> References: <20250826170315.721551-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wAH5Svt6K1o9DIiEg--.25085S7 X-Coremail-Antispam: 1Uf129KBjvdXoWrtF48Ww45Kr4xWFW3GryUWrg_yoWDXwb_ua yjkrn7Cr1j9ryfArnay3yFvr9Yy3WxXr1vv3Z5KF1SyF9Iqr1kZryrZrZ3Xa1kuF48KFy2 yFsFyF1j9FyxAjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRdWrX5UUUUU== X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/1tbiQwi1o2it56YclQAAsQ Content-Type: text/plain; charset="utf-8" Add BRCM_PCIE_LINK_UP_CHECK_MS macro for link up check delay. Signed-off-by: Hans Zhang <18255117159@163.com> --- drivers/pci/controller/pcie-brcmstb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller= /pcie-brcmstb.c index 9afbd02ded35..dd682c5e5f49 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -214,6 +214,8 @@ #define PCIE_DVT_PMU_PCIE_PHY_CTRL_DAST_PWRDN_MASK 0x1 #define PCIE_DVT_PMU_PCIE_PHY_CTRL_DAST_PWRDN_SHIFT 0x0 =20 +#define BRCM_PCIE_LINK_UP_CHECK_MS 5 + /* Forward declarations */ struct brcm_pcie; =20 @@ -1365,7 +1367,7 @@ static int brcm_pcie_start_link(struct brcm_pcie *pci= e) * total of 100ms. */ for (i =3D 0; i < 100 && !brcm_pcie_link_up(pcie); i +=3D 5) - msleep(5); + msleep(BRCM_PCIE_LINK_UP_CHECK_MS); =20 if (!brcm_pcie_link_up(pcie)) { dev_err(dev, "link down\n"); --=20 2.25.1 From nobody Fri Oct 3 18:02:36 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.5]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 537A33164DA; Tue, 26 Aug 2025 17:04:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756227844; cv=none; b=o34oD6wDsgVLPi2tESNSS+ZyerAHwzuE81lxzUVEZmsm0hNRUUCZekkfEcePv/jbEGZ3cugsClAv5BCSQUmfDQPDkRxN6iUBfr29NgJt5D5X+WBpG6iwhFeRlt8dqDfq0acMRpyD/Oli3dVIlRY1qzJzmfkSoSg27DfUVoC3DGk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756227844; c=relaxed/simple; bh=5NR28lI11iFijrgUk/8tzY1zztMvrg2JzA0KBOA00Yc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=T9Zg8pMzC0OwvGACDSC0C6B3K+L8/jtwKHYjILzJTTQ/1IaWQf9ftjlqubo0CunJ9IvvydSVwRC62LYncCB8xPtM9d6k6gVhKFLmymcMEsMi777IaIdwUf2Mfq8Wa/B9Loa3fEsv867WDH8C3P/UaKRe1N71oOWaL0SH8Ov5zPA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=gf00mUz2; arc=none smtp.client-ip=220.197.31.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="gf00mUz2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=ow MJQKXmGYRfKLERYLkLgzgQGOHR8lVXvt5FN5sY0r4=; b=gf00mUz23/HIqu4vYg lcQjrlFhgpQSnvkh0fLXz2prZUmbmOshgDClIlYKHqW/nroTC4IcV52NDqvLCez6 uXJOzgxWlegbfT4HRjQZLgZsL52/V8xGNniHXHtkaUPL/WjzSGHLLVGk0uRWxrT6 M539tFBNknxP4uNeR11+d5qs0= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wAH5Svt6K1o9DIiEg--.25085S8; Wed, 27 Aug 2025 01:03:44 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: bhelgaas@google.com, helgaas@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Hans Zhang <18255117159@163.com> Subject: [PATCH v3 6/8] PCI: rcar: Add macro for PHY ready check delay Date: Wed, 27 Aug 2025 01:03:13 +0800 Message-Id: <20250826170315.721551-7-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250826170315.721551-1-18255117159@163.com> References: <20250826170315.721551-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wAH5Svt6K1o9DIiEg--.25085S8 X-Coremail-Antispam: 1Uf129KBjvdXoW7Gry7Zw1fZr13uw4kAw4UCFg_yoWfWrb_u3 yY9a17CrWqkFyakF12yw4IvF95A3WSq3WDXa4rtFyfAa13X348J3s2vrWDXrZ5Gws3Jr17 tr1qyr48JrW7GjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sR_F4EJUUUUU== X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/1tbiOgu1o2it5y8lQgAAsN Content-Type: text/plain; charset="utf-8" Add RCAR_PCIE_PHYRDY_CHECK_MS macro for PHY ready check delay. Signed-off-by: Hans Zhang <18255117159@163.com> --- drivers/pci/controller/pcie-rcar.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-rcar.c b/drivers/pci/controller/pc= ie-rcar.c index 7583699ef7b6..653f13d82934 100644 --- a/drivers/pci/controller/pcie-rcar.c +++ b/drivers/pci/controller/pcie-rcar.c @@ -11,6 +11,8 @@ =20 #include "pcie-rcar.h" =20 +#define RCAR_PCIE_PHYRDY_CHECK_MS 5 + void rcar_pci_write_reg(struct rcar_pcie *pcie, u32 val, unsigned int reg) { writel(val, pcie->base + reg); @@ -39,7 +41,7 @@ int rcar_pcie_wait_for_phyrdy(struct rcar_pcie *pcie) if (rcar_pci_read_reg(pcie, PCIEPHYSR) & PHYRDY) return 0; =20 - msleep(5); + msleep(RCAR_PCIE_PHYRDY_CHECK_MS); } =20 return -ETIMEDOUT; --=20 2.25.1 From nobody Fri Oct 3 18:02:36 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.5]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3C4152E1723; Tue, 26 Aug 2025 17:04:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756227843; cv=none; b=Xb4u6RKqmjJGHxHISxt6CsNGROyGnWItvWWsOr65hqo/tr0ZQOouKxyWhQIGYn5WVlxtNyrJINUEu/yir/TVm4+b+rbs7eDAK1+dMFduuYKRERweRCiCvR3v1IEiAbp3srgHDhFKrCSnJfq35fcCCfJjkrV8o2gbWxuLfBHr9AY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756227843; c=relaxed/simple; bh=4SI0MJ5mgxVQkPAkeiebRKJQyIwK0f+4OTRw8yrlbwE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ouwgdp3KuMtY5zHsGWbxeKQOvtumH2zDbcSaJ21lrovK5BRzUbm0FZZRC2FNImLKZ1lGo/LnJUbWqIm0AJ5VWCPcnnWsxrK443scsVBipigKUI5ybk0He/ymZpB9Wa9GgZ7BMwcz3bVXJ1zN71YzzmjNQxoCQeVZ63lTjck7vrI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=b2+jd8If; arc=none smtp.client-ip=220.197.31.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="b2+jd8If" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=nw yxpltjqOypW6UJIjeruKh1/jVz4ohv3HjBGe7Vdm4=; b=b2+jd8IfT7Z1JFajmQ NFf+n5lAESsSiu8ybAwY+PYHutfU8/1AJBO6wwCBNRHwHGQ/22Q1osG3UupVGung dfmWeJTpR66b8X01QT9RWYYYFQZ9meFvxuAWRk1cuWHbKoTzmcgVhRr/CVVGgHoZ pylr6TJRgOyG4jjYgn36g0WgI= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wAH5Svt6K1o9DIiEg--.25085S9; Wed, 27 Aug 2025 01:03:45 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: bhelgaas@google.com, helgaas@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Hans Zhang <18255117159@163.com> Subject: [PATCH v3 7/8] PCI: pciehp: Add macros for hotplug operation delays Date: Wed, 27 Aug 2025 01:03:14 +0800 Message-Id: <20250826170315.721551-8-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250826170315.721551-1-18255117159@163.com> References: <20250826170315.721551-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wAH5Svt6K1o9DIiEg--.25085S9 X-Coremail-Antispam: 1Uf129KBjvJXoW7trWrZr1ruw17Ar4kJr4UCFg_yoW8JFW7p3 yxArWUtF1rKrs8Cws5Za1DWr98CasxCrZrCrWUu3s3ZF97Aw4DA3WfKa4jqFy3ArW5Cr15 WFWrAFy5Ja1UAr7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zM2NtgUUUUU= X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/1tbiOgC1o2it5y8lTQAAsJ Content-Type: text/plain; charset="utf-8" Add WAIT_PDS_TIMEOUT_MS and POLL_CMD_TIMEOUT_MS macros for hotplug operation delays to improve code readability. Signed-off-by: Hans Zhang <18255117159@163.com> --- drivers/pci/hotplug/pciehp_hpc.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_= hpc.c index bcc51b26d03d..15b09c6a8d6b 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c @@ -28,6 +28,9 @@ #include "../pci.h" #include "pciehp.h" =20 +#define WAIT_PDS_TIMEOUT_MS 10 +#define POLL_CMD_TIMEOUT_MS 10 + static const struct dmi_system_id inband_presence_disabled_dmi_table[] =3D= { /* * Match all Dell systems, as some Dell systems have inband @@ -103,7 +106,7 @@ static int pcie_poll_cmd(struct controller *ctrl, int t= imeout) smp_mb(); return 1; } - msleep(10); + msleep(POLL_CMD_TIMEOUT_MS); timeout -=3D 10; } while (timeout >=3D 0); return 0; /* timeout */ @@ -283,7 +286,7 @@ static void pcie_wait_for_presence(struct pci_dev *pdev) pcie_capability_read_word(pdev, PCI_EXP_SLTSTA, &slot_status); if (slot_status & PCI_EXP_SLTSTA_PDS) return; - msleep(10); + msleep(WAIT_PDS_TIMEOUT_MS); timeout -=3D 10; } while (timeout > 0); } --=20 2.25.1 From nobody Fri Oct 3 18:02:36 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.5]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E5CBC2E1C6B; Tue, 26 Aug 2025 17:04:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756227846; cv=none; b=scfXp8gJuYUHtgkb4CPoEOMHY8nv31/z4T9c8GkNWdVLc/NS3FzH5Jn10He3NOx/pCmaRLSZIjA3hBpwnkxfat2yxgsD5sWkv2reLx7cYIOmh/hkEB3T4g+FulKNM6LE8Ca70hZu4yJIAY6pgnj4/uUnIma0GucGiVfIHwc0EwI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756227846; c=relaxed/simple; bh=RxbC6PRS5UWfVRhBWgHNMi2OVDBcE6RBrjCc4GiojgM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LbuL0z01oZrTeBr+OYWO7rwxqp1evxfubyQsgbyNfb2l6f5hnYIONGjgTwacX2t0PcvfQtJPpMJrSFollLSB/+uhB0BdDmlO7rg5zqHgFC6qtlyZRqjuWx2v+wcLwqpv7mK1L8U1AkVMeI5g0316jLLSRRZzwh6Ot5mXX/1dopk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=hu/amXSM; arc=none smtp.client-ip=220.197.31.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="hu/amXSM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=Uo wts4zfhr1/6N6PWGm/8Hg/npgCEGN+e6f6uoDvA5c=; b=hu/amXSM7XLdQPpe7l i+P+6dog+H2WCavBl60be1kawaf193WAkTdk28pVOiztE7/0kUCk3jXfUuvubFvc YVDBf+FsgvoX8CToIx9YVTnJChoWRdr/MrmiXDKKWOWrvtMEYaMxGlcQHbrZ1Kt1 5rIPolhigc+gGNdkRRtwdX8uE= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wAH5Svt6K1o9DIiEg--.25085S10; Wed, 27 Aug 2025 01:03:45 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: bhelgaas@google.com, helgaas@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Hans Zhang <18255117159@163.com> Subject: [PATCH v3 8/8] PCI/DPC: Add macro for RP busy check delay Date: Wed, 27 Aug 2025 01:03:15 +0800 Message-Id: <20250826170315.721551-9-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250826170315.721551-1-18255117159@163.com> References: <20250826170315.721551-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wAH5Svt6K1o9DIiEg--.25085S10 X-Coremail-Antispam: 1Uf129KBjvdXoWrKrykKrW8CF4UZF18Kw17Jrb_yoWkAwb_uF yFvryIyrW5CF97C3yYv3ySy34UA3Z7Zr1xWa1FyFWfZr17trnrJrZ2vw15trZ8W3y5XFy5 Aw4DJ34Yyr9rGjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sR_wvtJUUUUU== X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/1tbiOgC1o2it5y8lTQABsI Content-Type: text/plain; charset="utf-8" Add PCIE_EXP_DPC_BUSY_CHECK_MS macro for RP busy check delay. Signed-off-by: Hans Zhang <18255117159@163.com> --- drivers/pci/pcie/dpc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c index fc18349614d7..bd5e8cd9e43e 100644 --- a/drivers/pci/pcie/dpc.c +++ b/drivers/pci/pcie/dpc.c @@ -21,6 +21,8 @@ #define PCI_EXP_DPC_CTL_EN_MASK (PCI_EXP_DPC_CTL_EN_FATAL | \ PCI_EXP_DPC_CTL_EN_NONFATAL) =20 +#define PCIE_EXP_DPC_BUSY_CHECK_MS 10 + static const char * const rp_pio_error_string[] =3D { "Configuration Request received UR Completion", /* Bit Position 0 */ "Configuration Request received CA Completion", /* Bit Position 1 */ @@ -135,7 +137,7 @@ static int dpc_wait_rp_inactive(struct pci_dev *pdev) pci_read_config_word(pdev, cap + PCI_EXP_DPC_STATUS, &status); while (status & PCI_EXP_DPC_RP_BUSY && !time_after(jiffies, timeout)) { - msleep(10); + msleep(PCIE_EXP_DPC_BUSY_CHECK_MS); pci_read_config_word(pdev, cap + PCI_EXP_DPC_STATUS, &status); } if (status & PCI_EXP_DPC_RP_BUSY) { --=20 2.25.1