From nobody Fri Oct 3 19:11:47 2025 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C208131813A for ; Tue, 26 Aug 2025 09:54:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756202087; cv=none; b=rpnYZOXGtM3LwPH2yQj37SQUYf28BVE2k1vye0oXE96hPetmo4vtNe6a7qoH39X7cxzQjzayzzPlnTTK2vt3wqUxMqEggbZb0y/AThBYUDd6xzlAOyNqGe0i0K+u9xIQfrdKt0YcgLhWWJ83oz07w2UMa7K4nDC9c3/8miSjJ+A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756202087; c=relaxed/simple; bh=CjedZyIKNMMMuPAne4ckGf14fUj8WSZo5DQuAPPyWdY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=g7PzCFyrz3Aohx0iumGyKtSiJC2uWP2liIEHfY2lq/b4fWsUP9SamVs1JDNt5zLJZHKHuDhwdFtQTdamdqT292G6zAMeZ5E+h3tbJA2bpY+HhJdiJ8vZxpwebYjCOs7jB+bsLoLdnBPbgnFrTh2zYQ2l3W1p3owRqjoeq56BOXk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=EBIMWzaW; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="EBIMWzaW" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-45b627ea685so11635615e9.1 for ; Tue, 26 Aug 2025 02:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1756202084; x=1756806884; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=q67A6dEiGrYDiWG1Ph6/tY11Zd+/g6UDAqeQXHMdpI8=; b=EBIMWzaWXDn6l1el2mtV5Qa8oDCxZhCTYdhcrzot1siuDFaVZMjfx/TiBDfT37XsFU fjZHkPKHL2df5SlMSgsuo5jCIXExbGEgZTgu5sodsRnoTdvTmkN/Hq6iFnsUN5blFZ3U bcc8QYB6f6tiPMIWWcCb6VUzVEVISRz/Zom134OILZtsrYD2Zb27j15gdRpvXwxJITkr VtzvXgubQTXYxiOlMUz32/VHMtmwgimxeZMjCf1pgW4YI9hm9/BHDvEaDiL+pwss26Du +qiSS2KEXF2AxbymsBOMpqm6vXH3LZksYn8ZAHyQ58xsNK0YFGpPydEroLCS0X5pAltN Uerw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756202084; x=1756806884; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q67A6dEiGrYDiWG1Ph6/tY11Zd+/g6UDAqeQXHMdpI8=; b=GVtsrI3lzDLxkwQgnblEt+4OkyHSxcSa166yLRH+jVHVziETzX+zHWVulSc/Yyo9cK oNTLzJ9CH9kvPY6SdTyIuhFRYmFh+ocYeYB1/+MOxLdhThl4YTseLLLviW2KqR69OxiY QoRB6b54Uuop7qkWdKz0qwSRHNYpOhwCTWzUMHE2GM2vKDmPKVDHUBiPRfYbWitvINNN kPDWcTvC6dUe13vMUN4vsdd/RSH2Fjccly8aDRmmseLLAe0Qhh0WLwGd07fDibuS+mSw pdJPWVPILu7WP49OZPaReTs20w1FBUXMceYdknYCFJtWK8UAZFAZtdBvfCaZLRh1OYCP 9zdg== X-Forwarded-Encrypted: i=1; AJvYcCU6cg6QY/NY9oS/LepuWpMi793PUARy0Q5d9ofoCaQ+eQO9N+NB/SYUWXX8+nct8MqFwZOSwtsaVxTJvtM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7qPcuVSPfMRy+H9Z1h1xJ0CjqGR85YNf9vosdVD4cT8uU+7jk 0FenzNh0kja8pcaw84znfHIzsn0ZP108fPHvoWr0i05LMMslfNUvHDgY6F773q9O/N8= X-Gm-Gg: ASbGnct7I6jwXtL96B8FZj347ao6BHSlQS8eLdl3aReAj0gYJBcgMFlmwYiGzxwLiPR 3qT4HHcicgxQ4IxFelnYP022v4KEDpb/zrRDkcx3kwruYOTwgA25LAIzLdXGEcc7Mksq9T7zCm1 eSGVjmJgwmTHFpN6FYLTKVixd4wYpvpjc05kr8xM+oiwPRVfX1IR94gjl3XxnNVfIh7wRSHhzNn kWEvsjkzPhPZV11RBZpdM0jC9Ep5Ybql9Rek10x3G2XzJlTo4kNm2c3n1s4h1DLbJnYDVe+FUdT WzekLHWgcKUXIvOEJsufmo49zFZKXNGkrKLKxYGME756qpGBjHCaC9Nr/BKdUbquF2Rptoh+Olx vDyv8iyNx/lMt1/eR3Hf7wVi0IQMk X-Google-Smtp-Source: AGHT+IGbWWgfy4oVGNVw2G0/m0zq0IcbBhHudnTL2tazbGOxJcFH5HyRp6Ol0cIcccqIvQx6y5xP+g== X-Received: by 2002:a05:600c:4747:b0:45b:627a:60cf with SMTP id 5b1f17b1804b1-45b627a62cbmr53835625e9.24.1756202084036; Tue, 26 Aug 2025 02:54:44 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:fed4:79fc:9440:6629]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c7117d5977sm15708447f8f.51.2025.08.26.02.54.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 02:54:43 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 26 Aug 2025 11:54:35 +0200 Subject: [PATCH 1/6] gpio: stmpe: don't print out global GPIO numbers in debugfs callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250826-gpio-dbg-show-base-v1-1-7f27cd7f2256@linaro.org> References: <20250826-gpio-dbg-show-base-v1-0-7f27cd7f2256@linaro.org> In-Reply-To: <20250826-gpio-dbg-show-base-v1-0-7f27cd7f2256@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-pwm@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2113; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=po0oP7+JqvmBUahZ4Cqs/cpV/Mj5xJP4shR7qEp8+ho=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBorYRgPBjr2HKTi0bsdoQ+b83BxncLsMVofdaqL bBCOoX3jOuJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaK2EYAAKCRARpy6gFHHX cjpsD/9JA2Mu641ojLPtH3ELxbd1lMoD5z7nrGO7pgXSg3MrQTP3xEwfO960EIqZR329r7Z1QBW kgEI1Y9ntL0D9F2svgaOi7m77AL0fTt6DRGpXOeR6mck2ggG23Nl6NR+iXkFRaMUsLMh24VLl7f +TREbodVkT0wQO7Cms6iqxY+ok9xpZxm3q/RU5cUzMGvAybGlwifBuMwsUhXR0XfF5Cw+GC49u+ K/09nsJ74+pwONQQJiUtzozSB5D/dkhRLdj1qUrMUDd5ctDD73jO31BDAmIgG1VKAyftQ9V3Wlg 03KcmUwnODwAbhoQ3SZUgr0he2NGnEGekLPUjxxvcbKlwL3V6b5QvtaO4OwehJBb27wcmBANz8L CH0u/KdL/FAiqpAxaTKFLj4sPdgha+zuZRQaf37umOn3j9zl/IXlGtyj+KtP+fRR2IjU9/kpaza ahfnJHw3sbyOOcFycHXrgEUIpB6lYk/AZy8tUTTiGCzHqma44jp5C3bJhZQeqd4Rq14wyTvxER5 fLK2WVpD09m17FcOX+f9Ok071nbFOnedGUkbLlHh0RLZf+5zazE7W6ZgTPSf1edBzJ+inVhaYIO KdFZSLDzy7ovq9Zmi5AaE3NkrCBlTI7WJy53WCGnsYGgkrZTB6FS+PRfWjXjVXeFjBoFCJ34hB6 UIn+EnuvmR2BIkA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski In order to further limit the number of references to the GPIO base number stored in struct gpio_chip, replace the global GPIO numbers in the output of debugfs callbacks by hardware offsets. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpio-stmpe.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-stmpe.c b/drivers/gpio/gpio-stmpe.c index 7bf270af07fe49e7a778e91134b5bc5e7d0a13a5..6faf30347a36396fe9ab14ab4ef= b7331f78e95e3 100644 --- a/drivers/gpio/gpio-stmpe.c +++ b/drivers/gpio/gpio-stmpe.c @@ -262,9 +262,8 @@ static void stmpe_gpio_irq_unmask(struct irq_data *d) stmpe_gpio->regs[REG_IE][regoffset] |=3D mask; } =20 -static void stmpe_dbg_show_one(struct seq_file *s, - struct gpio_chip *gc, - unsigned offset, unsigned gpio) +static void stmpe_dbg_show_one(struct seq_file *s, struct gpio_chip *gc, + unsigned int offset) { struct stmpe_gpio *stmpe_gpio =3D gpiochip_get_data(gc); struct stmpe *stmpe =3D stmpe_gpio->stmpe; @@ -286,7 +285,7 @@ static void stmpe_dbg_show_one(struct seq_file *s, =20 if (dir) { seq_printf(s, " gpio-%-3d (%-20.20s) out %s", - gpio, label ?: "(none)", str_hi_lo(val)); + offset, label ?: "(none)", str_hi_lo(val)); } else { u8 edge_det_reg; u8 rise_reg; @@ -354,7 +353,7 @@ static void stmpe_dbg_show_one(struct seq_file *s, irqen =3D !!(ret & mask); =20 seq_printf(s, " gpio-%-3d (%-20.20s) in %s %13s %13s %25s %25s", - gpio, label ?: "(none)", + offset, label ?: "(none)", str_hi_lo(val), edge_det_values[edge_det], irqen ? "IRQ-enabled" : "IRQ-disabled", @@ -366,10 +365,9 @@ static void stmpe_dbg_show_one(struct seq_file *s, static void stmpe_dbg_show(struct seq_file *s, struct gpio_chip *gc) { unsigned i; - unsigned gpio =3D gc->base; =20 - for (i =3D 0; i < gc->ngpio; i++, gpio++) { - stmpe_dbg_show_one(s, gc, i, gpio); + for (i =3D 0; i < gc->ngpio; i++) { + stmpe_dbg_show_one(s, gc, i); seq_putc(s, '\n'); } } --=20 2.48.1 From nobody Fri Oct 3 19:11:47 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 221CD321446 for ; Tue, 26 Aug 2025 09:54:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756202089; cv=none; b=ssvn4K1KIyeEvO9RMJz7Wx9hZuJCswWoxZ7Nuf0TLZIZKBlmUt7OSfGA80R3p497S4P3zUaRJBoNBXW9GQzIzy6bku5e2t+GaKW3kLbHpmhyNpV+vZLE/21YLFIwqKGJCFM90BFqKoI7iYaSpH8gxAV/prZ6lF/TmWfuvA9RdoI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756202089; c=relaxed/simple; bh=RPdlxmA8pQzezikqTMuokP+plWsLo1uTn6qI2eFWVGM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HjhRzy4uaGnEfuZCDWaoIp4pgN8elMRLnF1908whxI/tOu6Q+MRKjM93NJQxpQzv8udqcoDaWPP7RIL+PGxUSOy5b/+e3M90BOMTYFWrAmkcR7Qde8r+D7QQyn23M0oaxz7rdHoBBJs3wDbJAWk+ag3MGPOqB/9zYXZAgyyMTmE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=l3BnuU5f; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="l3BnuU5f" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3c380aa1ad0so2676362f8f.3 for ; Tue, 26 Aug 2025 02:54:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1756202085; x=1756806885; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EpYS93HuS2Ws4ibadqFyYNPcNkc+D/2ZRLQIn3G55gg=; b=l3BnuU5frjykkkArGkg9JD+wva46fo7SZxUGXx/m6M6jIG1R9Rl8P+lUbFMIo8Jyhg mGzQEVM6D3HZbiE2sEkltW99P6o61cjon0gDdfQJ/xwTqIYPWi2H5HFq7tRViik33Cor hVaE9LHRB9ec9fWl4lz8qWd9xTqnzinUcrby5DTlMo6Gz/g+o6WO+rlCP+VYYMNxWkhc mH2dDDae2e8kX/Mv1tn97KmcX6MATOhESnHN/xWvXOzAbSiEFT8MlRBFvV2t/wBtQH3m IcphwMZLEkiYUYz9vSRtrkrDulKCJhQptoJzngYoyFMIOQWYaQNV1Fwd9LrkPN4dxvBO 1S9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756202085; x=1756806885; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EpYS93HuS2Ws4ibadqFyYNPcNkc+D/2ZRLQIn3G55gg=; b=PV6SV0DbMMOMX3pNwd8oUxw4WdCOa9zgyI6TtUhNfZXGJeGUJdFaPAo3JVZlEf+nCz CxOVxIGXFLM5c0motpDi87d3h8nW8ydDr/wJxthNsx4fGV+FLtHFu9GSTR5oKYskE6ub 5wRd9INqGAKxHgsSBjz7GzTCHEFYv4jCqVwjJqoxoXKcZSSH7A0O28Rj+jFRFEhVqdSP QLuwgyqWgSNAkiVwdlDYQOstVM+EOAYEL+w0TwlmhUwHIH+3/YtJUA2P83tgtEhnPyOO SK+8HZmnOktfl398EQS7FTgpmdIuhDWRVCIYabQgSP3C2LqEFax4jLO6YooFajSqzfm2 60iw== X-Forwarded-Encrypted: i=1; AJvYcCVwOSlbsxd1Qo14sumUFIbCfpY9hvbAI+NEjqM70FG3Vuyx0w5m4eTgbjtxS1Xh2J0RNgkr6HELqAZ0kHA=@vger.kernel.org X-Gm-Message-State: AOJu0YzbpMkoLEn2aggeK4Lgy8jNUh0+p2QaF1Mr9gH1a2Tpq4/5wLNv 9HJqC/rWzKXKZXKxmoGo2mZQIExVfqfeSBqIg08ZUtOAX2SarOMHNU0NQUWH2hMaboc= X-Gm-Gg: ASbGncthzvfbHiTC+KZiZWB5O315kpLvkilEGaLcCEF/vzOplNBo9cRr0zNimuFu9zU cslfwXPLOoP78Tgfoy6tSIsfSD6pkTwLLxbf71zkTjiGnMr4WDLLYcS6xLafw1HAHze51s8R+vL kYwtkkuaSkUkcMpCEtXiRDSkvyGS1QQhTybStub+FXFi/JNQih2OScIC8j1bhUqqDiD72FJ9o8M uqsatpZT/moNGr3ic9cnpVZCKzcecy+yzK0EQf6KkQOcmUjeHUTCZ5eE3/l/G1FPyW1Pw9SwE66 dlvyDMZDx/zabISG85XelsvrnsVsPian8IIk94Kh/13t8e8qrMjNwnLcCudE/oMgnUGeT/7cdI1 KkhtCtx1uqMcSg9MnwWOFqtHiS01J X-Google-Smtp-Source: AGHT+IH+zImocM00pe6xCRWyWfzSwlePAUzY6aZ/dvMer4YnerGXKYc/WZlxM7P5Y+5mqjP1ZLVAkA== X-Received: by 2002:a05:6000:40d9:b0:3ca:5a3f:4182 with SMTP id ffacd0b85a97d-3ca5a3f47cbmr4448457f8f.63.1756202085222; Tue, 26 Aug 2025 02:54:45 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:fed4:79fc:9440:6629]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c7117d5977sm15708447f8f.51.2025.08.26.02.54.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 02:54:44 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 26 Aug 2025 11:54:36 +0200 Subject: [PATCH 2/6] gpio: nomadik: don't print out global GPIO numbers in debugfs callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250826-gpio-dbg-show-base-v1-2-7f27cd7f2256@linaro.org> References: <20250826-gpio-dbg-show-base-v1-0-7f27cd7f2256@linaro.org> In-Reply-To: <20250826-gpio-dbg-show-base-v1-0-7f27cd7f2256@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-pwm@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4312; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=oBcKb5RM1YnckG7cnSsJVl/Lpv59j4+skQx80n0XNRw=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBorYRgtssbMNuvtdq9VaXj9texeQjs6T84FYRzh GIOLMeOaHOJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaK2EYAAKCRARpy6gFHHX cqp1D/9DHh5rBMhO3+JDLKv38OKZVQIWchApIdXx916/Wf5pq10ueE3pLb5m4Vvikj3RHMIu+iy u+F2qBtWL9EmQqGOhRB9PF3Eg02DRPX/bg+4lUWsKZp+7wvOYpkcLeFAuh7QxiOU/QrIDBpqYP8 DYikMquUwOx/GfXEFHSj4poi7RRQGmWXMwlppIcoyEB03q+mQ1cSNmaFUCEJLLJcNHq0N5Trf0A Xt8XmE/QBLi/OXEM0i+IKbaZbsyBlBjitj1gxGJE7QwyyCUbaD7KPYkIS7n0uBlocqCGcG6WzFc I1cGSIGXVmxEGbOyDn0CTIK4lFcT3lS1KHH/4FmNKYxwyIpuEyO8EUjvjz/tOjdnmWXtqGnCFF1 DudpHu4USyrl59LUT98mAqDQAjAuFdXINsoBJ7ZJKUoXyrk3Oko+P87+tQe5lB2TW/72TQL+9wr F15l/ynM6W7UkXSgTllBhtbdawKwKlM/7ZRlkG7KV1KoVC36SPl4bBbu36JoB2k9R48IELQs3iJ o3N3fZ3GGG+NzjADIoJaDXKcpgJkIeCvwSSmJWOZE4ZGyCL6ugws4pkhiykdjA09jQTKUFTJf/X aBnefpuUk7NfMbDt+V2JwNcvjp4XUkQNGD0uL533DMg7drYCwBrKkmb4YqeamMzb7QMYllOGPQq eeDaj8vM/Qle7eA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski In order to further limit the number of references to the GPIO base number stored in struct gpio_chip, replace the global GPIO numbers in the output of debugfs callbacks by hardware offsets. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpio-nomadik.c | 25 ++++++++++++------------- drivers/pinctrl/nomadik/pinctrl-nomadik.c | 2 +- include/linux/gpio/gpio-nomadik.h | 3 +-- 3 files changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/gpio/gpio-nomadik.c b/drivers/gpio/gpio-nomadik.c index bcf4b07dd4584f884992ae35caa8aa1aaacb619e..fde4b416faa81816ee554f85e56= 65f16d5defa06 100644 --- a/drivers/gpio/gpio-nomadik.c +++ b/drivers/gpio/gpio-nomadik.c @@ -20,6 +20,7 @@ */ #include #include +#include #include #include #include @@ -396,10 +397,10 @@ static int nmk_gpio_get_mode(struct nmk_gpio_chip *nm= k_chip, int offset) } =20 void nmk_gpio_dbg_show_one(struct seq_file *s, struct pinctrl_dev *pctldev, - struct gpio_chip *chip, unsigned int offset, - unsigned int gpio) + struct gpio_chip *chip, unsigned int offset) { struct nmk_gpio_chip *nmk_chip =3D gpiochip_get_data(chip); + struct gpio_desc *desc; int mode; bool is_out; bool data_out; @@ -425,15 +426,15 @@ void nmk_gpio_dbg_show_one(struct seq_file *s, struct= pinctrl_dev *pctldev, data_out =3D !!(readl(nmk_chip->addr + NMK_GPIO_DAT) & BIT(offset)); mode =3D nmk_gpio_get_mode(nmk_chip, offset); #ifdef CONFIG_PINCTRL_NOMADIK - if (mode =3D=3D NMK_GPIO_ALT_C && pctldev) - mode =3D nmk_prcm_gpiocr_get_mode(pctldev, gpio); + if (mode =3D=3D NMK_GPIO_ALT_C && pctldev) { + desc =3D gpio_device_get_desc(chip->gpiodev, offset); + mode =3D nmk_prcm_gpiocr_get_mode(pctldev, desc_to_gpio(desc)); + } #endif =20 if (is_out) { seq_printf(s, " gpio-%-3d (%-20.20s) out %s %s", - gpio, - label ?: "(none)", - str_hi_lo(data_out), + offset, label ?: "(none)", str_hi_lo(data_out), (mode < 0) ? "unknown" : modes[mode]); } else { int irq =3D chip->to_irq(chip, offset); @@ -445,9 +446,7 @@ void nmk_gpio_dbg_show_one(struct seq_file *s, struct p= inctrl_dev *pctldev, }; =20 seq_printf(s, " gpio-%-3d (%-20.20s) in %s %s", - gpio, - label ?: "(none)", - pulls[pullidx], + offset, label ?: "(none)", pulls[pullidx], (mode < 0) ? "unknown" : modes[mode]); =20 val =3D nmk_gpio_get_input(chip, offset); @@ -479,10 +478,10 @@ void nmk_gpio_dbg_show_one(struct seq_file *s, struct= pinctrl_dev *pctldev, =20 static void nmk_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) { - unsigned int i, gpio =3D chip->base; + unsigned int i; =20 - for (i =3D 0; i < chip->ngpio; i++, gpio++) { - nmk_gpio_dbg_show_one(s, NULL, chip, i, gpio); + for (i =3D 0; i < chip->ngpio; i++) { + nmk_gpio_dbg_show_one(s, NULL, chip, i); seq_puts(s, "\n"); } } diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/no= madik/pinctrl-nomadik.c index 8940e04fcf4cc4898cda5a5734574bfed6a175c6..db0311b14132276b9020bf3331f= d9bb7a4f73a59 100644 --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c @@ -584,7 +584,7 @@ static void nmk_pin_dbg_show(struct pinctrl_dev *pctlde= v, struct seq_file *s, seq_printf(s, "invalid pin offset"); return; } - nmk_gpio_dbg_show_one(s, pctldev, chip, offset - chip->base, offset); + nmk_gpio_dbg_show_one(s, pctldev, chip, offset - chip->base); } =20 static int nmk_dt_add_map_mux(struct pinctrl_map **map, unsigned int *rese= rved_maps, diff --git a/include/linux/gpio/gpio-nomadik.h b/include/linux/gpio/gpio-no= madik.h index b5a84864650d0c228de6e7350a28449537a829d9..7ba53b499e164edf410475cf62d= 60f399aaaa0c7 100644 --- a/include/linux/gpio/gpio-nomadik.h +++ b/include/linux/gpio/gpio-nomadik.h @@ -261,8 +261,7 @@ struct platform_device; * true. */ void nmk_gpio_dbg_show_one(struct seq_file *s, struct pinctrl_dev *pctldev, - struct gpio_chip *chip, unsigned int offset, - unsigned int gpio); + struct gpio_chip *chip, unsigned int offset); =20 #else =20 --=20 2.48.1 From nobody Fri Oct 3 19:11:47 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 053A7321F5E for ; Tue, 26 Aug 2025 09:54:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756202089; cv=none; b=DFP1xSwjt+krsq74GNZgrlTuqBIANFj+PAR10ugNgTJfy2clKgox8sSGrspcHKHIBUuqZ7Hm2qzINFqtQUT4vCHEbLPSZzkJFlVQCNGk765D/FgnXZ84BthpgIBysC53xImHpIcRW9FikRQZJkS0LbpceNrw19KhZxSwu14DO38= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756202089; c=relaxed/simple; bh=+DluEEQpDv5mv+wbchOBlw1mfwuVuCWh3IvBbqKoweo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rLxYK85D3YClB2x2qAlrTsYj0uHWzrR74lm5+XOpcZhH/bFOrDVVGJkiDzQJ8RnemlY7gCmoKizc0R8OjViGDIrbhJfzKtb1MKbwVbZmCZiiaAsJdPll0ZY/B3uj2ag6LjLR9XM8pBG77bDwenv5TufyVe3dU5/Ln2g6ccn16l8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=N8vzcdQf; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="N8vzcdQf" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3c6743a10e3so2191500f8f.0 for ; Tue, 26 Aug 2025 02:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1756202086; x=1756806886; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QUzxj3AwlFMn/Cb4ZnmJ6RjeXFL5y1o/ilqQYnR/MVw=; b=N8vzcdQf2IFpR6d8nemE8YHYMaMb5riEZY6SC56BXU2y8gXzgGdZQIBzAsG7gaTQ1Q IzUDUtu4tvPYNiuPLrpzBokYpvXX7BwwcZaqZsOmmbbTRAFKPvGisFjL2WLvl7X7tW3z ndHdQRaoikB4CPOQEFd98OLWFJrPcgLk2h4u+CIarZivQCyXiLPyEChy/Ha77U5K5V68 O8bU8C2n11bz8U0ZGq27jWo79E72wZHcEijGl2nhJdbx17as0BiG6zD1GYEUgL6K9bv8 vAUwkrkBvOLtdrYez0rTA1El88u6YKHWQ7hpmEvxYqPpceLwPjQCWGFKdMr5ZX7BvQIE t5LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756202086; x=1756806886; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QUzxj3AwlFMn/Cb4ZnmJ6RjeXFL5y1o/ilqQYnR/MVw=; b=EMsMbr+D+l0Z9Egq/V7ANMg08qSKYbyuVIyADUC6NXH6TJCzeCjRVeSv7DGkz92NA/ LJYKJ6DP+UzhMA+2ggjtLlgnwR9p5RqBElPxI9v01GE4feuGzych/DIKE9eadOhob8RG 9NecviQwR6axJBg2o/6sBre1WJlw/WHu4ggt9R31rE15Ssa/F4cCZi30NTAPix0PJ34e 3l5vXRC3r6y4OXKWUH8Q+hW85BpLsjF0/oVV5ZSscL3zkV8oPpRSEVdsvfBjC2kvu7tF Woqhv02rbs3VDYC+JoPY7mnfrNkkmarcc5X4f0Hq8CFu8RWQz0HES5s2Qih+ZOtMiw1l MBBw== X-Forwarded-Encrypted: i=1; AJvYcCXHTa9e2rvdxWpOw5j+U9k5ST+t3mIEsQsAhiYq6kSYi6tVyHjQzg9DLJQvghBBCFT84n5NdUuG2Cw/4Mk=@vger.kernel.org X-Gm-Message-State: AOJu0YwGCXcr5TGLJwJtLAWrzGgIMiXXnD/I6oaXU4Lmp7yDYoVru3dm LNXfvgIbiMdXNsaex9cVJU6G30B3Csy3LpO1HiNS0Z4j2O9Xv9ou8KBSD7pM1822yHg= X-Gm-Gg: ASbGncs5b8P7Ee7ZOsrXtz7Ce84hfMggmir9kzgtWNZUqkV67cvYa9tz+Fb987D+Xtj vAukmjOvgA7mXl9hTHbCYiUtuKg1wvaggDLLmTM/cQjjIkGxtNmnll98qB4OdXZUJHXNN02XZms yAqm9JQBJOGsRwkItkCBpNmk98kVFNQscEPP46AwgNMQ3xqemaok2GXT45ggOHITctLo0g7vkfh SwFdxOQdNnqsPg+ahgKYQQeErJe1Q/KNLHzRmbrTjBVQVcmCwLAUUQ6wSDX23m0UQSg0vvwRK+v SAZj392A6RX7acNV1k/JB7g/FpmTQRgQqFSnvVvtho0fMeHtZXMNJMYaphZhdeAmRi9M2Su5Qzn jOy9nJQX3NXcptfmWnw== X-Google-Smtp-Source: AGHT+IEq7Pdf+yKsvkWm+MwW4ovsbwrrSZre17IZ6PflaifIEPCYnP/bAcdG3LE+PYHL5F83Vsr22Q== X-Received: by 2002:a05:6000:26c8:b0:3c8:e436:a5c6 with SMTP id ffacd0b85a97d-3c8e436aaccmr5104411f8f.23.1756202086354; Tue, 26 Aug 2025 02:54:46 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:fed4:79fc:9440:6629]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c7117d5977sm15708447f8f.51.2025.08.26.02.54.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 02:54:46 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 26 Aug 2025 11:54:37 +0200 Subject: [PATCH 3/6] gpio: wm831x: don't print out global GPIO numbers in debugfs callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250826-gpio-dbg-show-base-v1-3-7f27cd7f2256@linaro.org> References: <20250826-gpio-dbg-show-base-v1-0-7f27cd7f2256@linaro.org> In-Reply-To: <20250826-gpio-dbg-show-base-v1-0-7f27cd7f2256@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-pwm@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1313; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=0doGTq4jVCHH5hAlopIUV2rywiE5EAOXG6MofWNOqdk=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBorYRgPCC7iTt/8LaCLZ4zIye40qfjGVFVH5elC XqjSnKoEeKJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaK2EYAAKCRARpy6gFHHX chxeD/0Z4DZnn9ZzUFJ05Yd1652M+GEyzC29T6CIFKaE/dlhyax7hUNfKtRHYE7U+/Spudq+OPU vJpWBxUSWpqDHubZ2+FPbYRFosDePbdOqRMxdp6PogyXJ6HA0eWV9lh/DRkC+YMUdAVFZkgHWCt EHFhnQDH9SorKiEdPmOueFadYPqipZA6k/dJTyGQBqAhZbymA0vEDlHdPZlIwzciFLnGrFaDEaF E4Mb5Z642juTfhqJTlMTtqqH4YpCM7hA+I8TehIxj3asLn8h03M6Uv/wndoaanBjNzP+3IVvXTJ MAe7b1pfQmMSdvjjcJCOJI1YJlkMfpzj9MT5QsNb3N790NaJqK9ADIUAyEBK5y8AVbK9fc4cQt4 CKOND2GqpYC7JfJzlizaV7LUtlSDc/HCRZiZq5LuZYiojlL2MzexXaLVgbKzJaQwmtzRvLAJzDE Tz7aeHvkzd1zExLGalCuHKHq5VBgf8ER6svb5hI74wr9dF1MYN87PkOERip+qF0spc5T6TDwvO8 JiUwldshiqUlKmLFe/jhOAeFGDSqFn7UdHbFe4oNKtPwQA5Km8D353wRUjpBGbc26wCZYou+zH8 c6rkZ/kNTgnFo9mYAVMVY1J2JlFZf0AF6uNaP4/Ho19bN9924Iah7g1D96Yxentnt61AeCveARD tThXGIwo2MT83dQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski In order to further limit the number of references to the GPIO base number stored in struct gpio_chip, replace the global GPIO numbers in the output of debugfs callbacks by hardware offsets. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax Reviewed-by: Linus Walleij --- drivers/gpio/gpio-wm831x.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-wm831x.c b/drivers/gpio/gpio-wm831x.c index f03c0e808fab27349c39f9efc41e5ea420b2d03b..489479d6f32b3a8bcd7592e46ad= 61ec70794a2ab 100644 --- a/drivers/gpio/gpio-wm831x.c +++ b/drivers/gpio/gpio-wm831x.c @@ -159,7 +159,6 @@ static void wm831x_gpio_dbg_show(struct seq_file *s, st= ruct gpio_chip *chip) int i, tristated; =20 for (i =3D 0; i < chip->ngpio; i++) { - int gpio =3D i + chip->base; int reg; const char *pull, *powerdomain; =20 @@ -175,13 +174,13 @@ static void wm831x_gpio_dbg_show(struct seq_file *s, = struct gpio_chip *chip) } =20 seq_printf(s, " gpio-%-3d (%-20.20s) ", - gpio, label ?: "Unrequested"); + i, label ?: "Unrequested"); =20 reg =3D wm831x_reg_read(wm831x, WM831X_GPIO1_CONTROL + i); if (reg < 0) { dev_err(wm831x->dev, "GPIO control %d read failed: %d\n", - gpio, reg); + i, reg); seq_putc(s, '\n'); continue; } --=20 2.48.1 From nobody Fri Oct 3 19:11:47 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7445B327790 for ; Tue, 26 Aug 2025 09:54:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756202092; cv=none; b=WAScUd/KzUGhx6tPnSn9rzniyspmWMp3V8ii8NHVB3bQH4/ekGEggWy9KmP3GKL3jABVujO1hdaP4qfCmc5jdiQ1wl7/NwQrVy9hwtlW+Ll94MVMsrc76ZUQbpVRA6jt7d9K4mvO816owioJ6778iXuZvLzYaKrV61pcF8VfdVk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756202092; c=relaxed/simple; bh=QD0kfyNxuvyOuW5PIlZnDrSaU1LLSm7x29aIhGnXwdE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iWvOPGVW+aFwLwVubL8upyXlKr2J0HKjh0sdYs6rLMxgtOEZKsUZB/EzKDwLc4tE5kgaWoGEW5ZVLuDE8neVHg87F0aovdX1UgRoSnqc4oezcamRWsX0WmK4fyzD+aoj5Z8BYWNY2XZIerUg4S0Ea9KTUd+Fo1bVaO8pIKJjiGQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=xpir+IF/; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="xpir+IF/" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-45a1b0bde14so28931115e9.2 for ; Tue, 26 Aug 2025 02:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1756202088; x=1756806888; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Hr9ezDvbabWM+JIoWhpxzu2N2664G4DRU3GkdP0Hsaw=; b=xpir+IF/P1VyF1dAWPInLtIACb95qUdleoEP/tyy7uMk00q1Zmj/KangX/r0gzITsB OzGIcOrSzXDoG1NWc1yzc79qMJQCLaO2JEZNIbAUIz3nOraqwjBNK3mopVPfCSpUYdHP xzvUEEYfTtIWFkcOB6Ux6x1dneAPLeMSrzNhSBZdfy9Yt9YDpSfw1HyhlzyuWh6FaFAj KH3LsuNigocVXrqHCqlY+WrJ2rWys6KVDzv7W4PcVfGePteEIOiota1k9bKJdPy4/qja jenCHjs/wku5Q1mVCEc8blhKQOqx2MEGrB2TyjmK1uNlRw1ogg1ijQQAO+57QSHzFw5o 6Txw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756202088; x=1756806888; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hr9ezDvbabWM+JIoWhpxzu2N2664G4DRU3GkdP0Hsaw=; b=XycM7k9GQLppxozi6hcBaooNlWFnQcNNewsGm2AfISXGVGxAZ/4kLu1jCmBIFHpWDV 14ArtlmZgn9kRNlAVOF3EX6lqKw459O8UB87coDmE2TX1RpVNyyxJejMWPw+CdeCDnij tPIYQFss6cSDhElILZf9fmCsUJ1Nz4j2GRhR5M917/2zhjqfAJqMRhB4NllbUkgYb6Zk 0FIojDNqabsySFs0Lphub/jLxNVauTrnlsDa/IRD5zzDbWLvf7W1i3gBCbrpekeq5Mff 6wpu3JCDz4hJL9mygola3q1L6XH/HtzbnD+5gd8kBYZlnkLgcD1NAD3RA1JRrID7KMVs t26w== X-Forwarded-Encrypted: i=1; AJvYcCXzDEEH7zPKWrUSCuaNBvpJ1LV5HC9KM+r82Mx/VfCPdiHBFvbH+wLWSxNO81jJF5xSIILNSUz3IfMNLDg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9kmxMIS4W21Qnw0jUgRNXFNixykWHe9KChxOToke9I5jspk8q g3pMyLLS1t9ZhDMa9zd3DSw6n07bn2TEFHn1QQj4dgtKFWUwk7S7860kpQ9rKijjmlE= X-Gm-Gg: ASbGncvlx/1AdB+VIhzVYHK0waBxr6/FUjLglOugkTLshxhDvlhR2UM2dTA0+TiOZAa hpxIOPVwovTO/jgtWRzdHBhVQCUa/wgamNspX0BTS2LQ9hR9ZpohFfzDiRtHlZnf6HtBYCAsN2n bAf7p1dQZer+hDRLDKZAh0iLq/P0El6GC+oAcCEQS6MQOEn0GRp3heNO20HCnAkPpVaxpvW7v0a tcEo/fp6i4KqbJoPhb4xIA7TNSWuDatKxcYWEwJ9dxuSySLX3uAHZ/ekVbfOjFxbTfucX3YztqB TOE76Ohb/jnYCvTIoiFBHno7lwYPZ4yo8TMOwWWIcu/2ZC6vPgyh7CrL/HFKAhAoxVG37CD3yqa 1Dsf/+6vgCQ52ohfIxNqc3YnptIxf X-Google-Smtp-Source: AGHT+IEbmQ0wfHfNzU9A3vt56aJAW/TBqrp+wvsnCIpOz+MxEDmOeIEf5KV7QmY38nQb25bnONIElQ== X-Received: by 2002:a5d:5f81:0:b0:3b8:f2f2:e417 with SMTP id ffacd0b85a97d-3c5dcdfc643mr11727394f8f.51.1756202087749; Tue, 26 Aug 2025 02:54:47 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:fed4:79fc:9440:6629]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c7117d5977sm15708447f8f.51.2025.08.26.02.54.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 02:54:47 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 26 Aug 2025 11:54:38 +0200 Subject: [PATCH 4/6] gpio: wm8994: don't print out global GPIO numbers in debugfs callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250826-gpio-dbg-show-base-v1-4-7f27cd7f2256@linaro.org> References: <20250826-gpio-dbg-show-base-v1-0-7f27cd7f2256@linaro.org> In-Reply-To: <20250826-gpio-dbg-show-base-v1-0-7f27cd7f2256@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-pwm@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1384; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=EvQ1SYQWer3RkO4fMSasYvVhk1H3yin4vuMK3XRhqvo=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBorYRhUQXOMPagC4V/EkuzJhJIamLzxI+KALqfB q+9XnyzgSqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaK2EYQAKCRARpy6gFHHX chyoEADLBUcH51ZCT1TXPLgWv7MXnlLoympGVuWzAFP9Pii3SX74H3kEVV+0Tmba/cDTVmJSNzm 2TaTrIzWerfU3YhuqiLeRkzA/mvIQWWL54Gl8Q2m9i9Ff52r0rTdNiq06a02hMBGmfN0rP8koT3 axInx/kv5tIUpzfUuWlQSzhfSA4A84rEw5exxvxFxzoradZcvjs+GLRkZrVwXIKpNVNDCzYcvSc TccxQGCFVYff0ZND0qqLyAWYy5gwO2LufjeBzw5GiY9cBhiZMYm3Xuw+MBJAXrApo+3LPwU9PBy tDjmwsNpbgaRCwQyEEGbR7C1ifbrZwzf/taYJA1u5BvEXbFrFfFVpANN23Nj32K0Oj0qKOPwfkM 1cwDE+Iq6omUOPOh8Df4UPmMisd3PiEhH0p77kt3MjOoIbdJhi7LNWJKLg2HOrFQEGBD3BTMdUZ +8dK0PQ9QVJlenx3Ah02EY5H8G/yfhPdhQp0e6sy8tnvKW+kErc00iJ8monRSd5t6gXJGHs/oz/ Vifi0VfWOAimS0AklTN8w2ITiOxsp3wi6kozrnyZCVBe40tGIyGhbA+MIAb3nk9xTvZY9/DTYWe 4FrpxochWDmvq/SFr5tuIVd+69KtLXOdTFeZa5CrnFMZaKeHtyXRDYUGk5yU/+qG3JVi1OSegyL PsyR0iUxyMNOVbg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski In order to further limit the number of references to the GPIO base number stored in struct gpio_chip, replace the global GPIO numbers in the output of debugfs callbacks by hardware offsets. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax Reviewed-by: Linus Walleij --- drivers/gpio/gpio-wm8994.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-wm8994.c b/drivers/gpio/gpio-wm8994.c index df47a27f508d94d53056bbe666a67e887637f516..a0665cf3ff2f45640cef740deca= 7712606791f47 100644 --- a/drivers/gpio/gpio-wm8994.c +++ b/drivers/gpio/gpio-wm8994.c @@ -194,7 +194,6 @@ static void wm8994_gpio_dbg_show(struct seq_file *s, st= ruct gpio_chip *chip) int i; =20 for (i =3D 0; i < chip->ngpio; i++) { - int gpio =3D i + chip->base; int reg; =20 /* We report the GPIO even if it's not requested since @@ -208,14 +207,13 @@ static void wm8994_gpio_dbg_show(struct seq_file *s, = struct gpio_chip *chip) continue; } =20 - seq_printf(s, " gpio-%-3d (%-20.20s) ", gpio, + seq_printf(s, " gpio-%-3d (%-20.20s) ", i, label ?: "Unrequested"); =20 reg =3D wm8994_reg_read(wm8994, WM8994_GPIO_1 + i); if (reg < 0) { dev_err(wm8994->dev, - "GPIO control %d read failed: %d\n", - gpio, reg); + "GPIO control %d read failed: %d\n", i, reg); seq_printf(s, "\n"); continue; } --=20 2.48.1 From nobody Fri Oct 3 19:11:47 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E43FD326D62 for ; Tue, 26 Aug 2025 09:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756202092; cv=none; b=N5LzyRjLY9cqN1iabBV4Ss9NmQ8wNpmpTlGATDhFYi6YIQ+t3iNmhCtnoixxjaDuEIZtDwBrcxJkXIK4M++phqel7WULafNQqTNr0XwLi8nImzSb6KtlIho2EXdeiNiIldycwjlEtmxRgxRYnYAHna5FJpom86PkIVz229fABfM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756202092; c=relaxed/simple; bh=VZG22Y7WwpUKvg+GiHO5Hhl1+8C24TfueSt7vEtoG1A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MuRvzltYqxYyllYvG2+7nOI8fW5/ocI3IivYC/GFA4b8SEtbkj+er9B2cQMST9+7vFrfHM1lKBgJ5xydZg1ZT8nZva4UM63XtiifsAGOiT3RrccHSmFFN/5qvttYnq217LR5hu0+5KWhBd4wLfvjnNsDnYSd0cV0boCLhFYy2zc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=rqeMuLeq; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="rqeMuLeq" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-45b627ea685so11636355e9.1 for ; Tue, 26 Aug 2025 02:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1756202089; x=1756806889; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CYPPBVbCADpKhi1bi9q9qzWJoLo8lysoUYAIi1sKWso=; b=rqeMuLeq9HFlTZshfBWL0C74BXWxp0GT3m/IzpDm8H3KBoFYDLpW5mLLiN5KqaNudm VOA3gkfTBLK0j3ofkSXUnnzsEHPQx3D/S66kcZBikl3qfk3aoz8OesNUPkiIbVtmRM+k om/MokLRt3Rdf1PSJ8z3ZjLlEIy/gtPg0Iyr8DAjPYDdqEvEdbvj7SNR2eC/aKjXoDl9 BA1KOIzGdSn/zTA7xSOlnyEu8hkaBhodpIbKWmgADApTcDkYMSN2NzwpI6ym3vhnLuzj 2Viv7VBDxtQmWr3EmA8YpZiUBVnw+r8JIVtd0BLMPYHraMMKjhSLacEku+cjO60dq7GV dr0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756202089; x=1756806889; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CYPPBVbCADpKhi1bi9q9qzWJoLo8lysoUYAIi1sKWso=; b=Fyitektys3Rbl7EhngCTwV2iVPNFmzhWOPpgOhB84h9H5jSVD5ZiINBSKKRK+Ko6V9 uPC7Gw7yrE0dDm4kaUE0v0oHjknXRoPE/EwEBII9h1NbHG/ZXO0cv/feSyUF0Zqdtr8O gq4mclv0Gfuz1tiRFfi0WZTYx2iwfLrXK2k7pbqAeaJfx/C8LpXCGhvSvEv/WAddi6OY lIqK4mgyxiBNwhAJMx9wmfppQPsMhQRXJWVMsZED8gD6P1gZDDHka4aUZpAsxA+gnyxW X49ZFQbtlKYPaE+1wkbZquIoAywptTtMVaq/Nzls7SymuKVigGJqjZt1DxOlHJsRrRIV 0rVA== X-Forwarded-Encrypted: i=1; AJvYcCW3NMLvjCidQSPap3DbfxkgMFxAEjtJE3pupJ5NlKg5piD0teq30/H5lFAh7yjiUPaSlk4nITDFQrh/JnQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8Hfu4dX/K9pTix/6mVzrvHb60N6NtandcqTm3y3vnuejSXagE 8xe1Rwl5aI8iloBo06PeSpDCsQoOBdOTkRxryVSfRuinpehNEh92jV7zKJyDdj/IeTs= X-Gm-Gg: ASbGncsV5xiPxmqBtIN0bKuIgNcKAmxikAk3tvs4XIZqQ9y/JUbrKKpggOG8hQ96T6R /Ke9pvySXCDbBkQ2uSLYhgXV2izLOHW6pZ45nBMlPKI/mJJSQaMTqNfXBZ7Qo80/0GtCkJHJCDZ 8UyUL7RJWUtIyn/fTsR/F2UM756Mpvyvk7SlHLHsXSYHBfmpZMLNI2J4ou5qL0+XWmajEcSxATK HxDs5EUwWsMHIlw+XnV1jSqxMcOyisJs0sy2lAt4AWEJfPOPk0wsFIz63iN9rZycjfDCEfI8RZC UgxnVjMqW81oifOPy4M9UXq9nLRgotX+jMCls6qhd/se5xpacZGe/4VUIio/ju4R9wiqHbxVFqm c/7vVyRt27l7OvBbsfw== X-Google-Smtp-Source: AGHT+IGpWBizMY//MBhSvlr9tBPYwg0Y5CIU4h89Pdi4ol5gUDn6YVkBG9JRn0IY9DS4Uz+pdj2F+w== X-Received: by 2002:a05:600c:a4b:b0:459:d3d0:650e with SMTP id 5b1f17b1804b1-45b56f781f1mr93995895e9.13.1756202089140; Tue, 26 Aug 2025 02:54:49 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:fed4:79fc:9440:6629]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c7117d5977sm15708447f8f.51.2025.08.26.02.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 02:54:48 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 26 Aug 2025 11:54:39 +0200 Subject: [PATCH 5/6] gpio: mvebu: don't print out global GPIO numbers in debugfs callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250826-gpio-dbg-show-base-v1-5-7f27cd7f2256@linaro.org> References: <20250826-gpio-dbg-show-base-v1-0-7f27cd7f2256@linaro.org> In-Reply-To: <20250826-gpio-dbg-show-base-v1-0-7f27cd7f2256@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-pwm@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=927; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Ih0doZjhwnqEDQvY4BwLNFHdMVjlZY2PNt5pCcC7YMw=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBorYRhcpj4kqrJ8fCQz7UztTDjdV8EBVimDDXsl 58MvqCng/aJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaK2EYQAKCRARpy6gFHHX clN6EADhb6sNqywomuQGbo2ieaNoLgLHDA7EmFyphMzWXyAawSNEGuBX4/n0ThtHi25Yi4innjv mCr991m26FZq3T/hcccGRbWPXAF5EvVzn8oFTa3ABrM9hxRg1uGzD6d6vdwzo9kp18GW0HfyQcs Fz+md/af5QDQzJRHzG2w4D2NDTc+iWdT0lX2nd8Vr08n3FPtw+yJvnaJbavDtGdCgpD41gTLUd8 3vyl33Idw2mbNroYq2RQFezk84pCh5Y65qYyJAu/8cugvbwXkyFJ8qBHDQqKX6kiYOFGRUsyxuX A3wepapXNcOKLKAwA9b3s8SQJug6czXExk29z2Rv9ijJuPxArPScEv5LdYdwIhAEad7u43YpZm/ sHfCTKhb3PbsY1R6u0J9EQ4GS7rScCaWU/L3ulx/aR8ocK2D+3mSEnIchmuHmmL5PRGzAS0E535 H5ieprNvRn8jxG+T7OLs+3W70GIYk53ud0qSyduu6VUuN9Nul1eEtgKZplHMjiNkM05iIzDRY+t Ggl5wWu2ww+8AjSJnjxEtuTZS4DnKwSg+f4z4sN//F10F0SFquqsVrklUQxSQXFzutLCzrKbg4r t6/BU4KTwKIxNB+VFO2hx4KL0iKISjpUkEb7pNTtM6oDhaErh0AULImXD3xg5rgVRmQcToBtyN1 X2vSa8ptjrUp0zQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski In order to further limit the number of references to the GPIO base number stored in struct gpio_chip, replace the global GPIO numbers in the output of debugfs callbacks by hardware offsets. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpio-mvebu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index 261ffd0c614b7189287c361f392f3df6d1b0bc57..ac799fced950e306a967d1965a1= 3f8e1802e77b4 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -898,7 +898,7 @@ static void mvebu_gpio_dbg_show(struct seq_file *s, str= uct gpio_chip *chip) msk =3D BIT(i); is_out =3D !(io_conf & msk); =20 - seq_printf(s, " gpio-%-3d (%-20.20s)", chip->base + i, label); + seq_printf(s, " gpio-%-3d (%-20.20s)", i, label); =20 if (is_out) { seq_printf(s, " out %s %s\n", --=20 2.48.1 From nobody Fri Oct 3 19:11:47 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25B56338F26 for ; Tue, 26 Aug 2025 09:54:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756202095; cv=none; b=ovV7FmDYYxL83Yp2XCaMAHpY6uVbcru3VGF4YuHJI96AsCXqZXQ9L0nxDGX9x2YML1UygbkQjzAnPAFJu8hBoW4QOkjwyJ/XlU3e8Xmf/XQejOy3yYp3FvIiqpBLJK48nQFv9Fngs6IeNnZwKn590XbEHazGpXh8mrdmwUVcOyQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756202095; c=relaxed/simple; bh=5PrN4kXWgSkhbgdmlbmnuhGMZyU6jWrz60oOZarPmr0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UOeooeMMbsqkspspjb6Usz9E/gO2dFCffw/jqCk2C8Z7aqsp4rdd7QS+ehqzYQ99SCDI9Uz3qINdE93gt4eemDYWJWTdiyNhSBVTGXluHZJVHigstRWnQIOVaBj3cStWUKY26giZBlOja89JsKMDSgYsep1I5PwzZV1ETh4NkT0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=z+c8El79; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="z+c8El79" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3c6743a10e3so2191541f8f.0 for ; Tue, 26 Aug 2025 02:54:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1756202090; x=1756806890; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xaRZ3orPuVdXJjVO7RddRtX98nkKU7skjLyME4PeVHk=; b=z+c8El79FvVytEi2Y+isBZboxl+N6Obfi0gSwNtkrwO+lfndYG+e4syCeOxdw6ZrcY 1fgYBt9pCzU4yDeHCeC1dFJ5N7DmUskr5sqP0EYsawlJ6kXxwzcjozwlhwew7NNmDDPb UPHPHcQsMCPiojkKK1NGFVPS1njaVhZ6PzndqxxlLD7UHD/0DWsNbwBwVY1C7illdeRP HUDJrHHHxruHxab7IQB4FXGah6OLQnqxmrv1HI8A6MfQfKk0qNEJcdkndlPE/X/AzkvU 3TCBa8FeO9P6p9yOtJdwnypFytZ/H6m2PGRqQaqCqvfky868YLEJtF/pmtHT8iCK48gd rkCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756202090; x=1756806890; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xaRZ3orPuVdXJjVO7RddRtX98nkKU7skjLyME4PeVHk=; b=BcrxkW58iXYuwi/GufqrB6yjPIxRcHl3uvMVuhnbyILB81ZXsQlEGFovuUYN3Ruv2D r+2NcwofUqNzl5p8apDGlQrnjNl30aefjO0AMKC3an/qTtJMdfCsEs7z0Hy5kvLPsjJn LFHSkfy+naPQpYfYYKbQ2eCswWr7fnXU3slHQBy/eIdgJTWHLBABD6+AR8/59q3fMh2T S/AS1vBpdsIQUOQUpXErHxmLcmi76NLvT4nKTmAZyoWhdr6QmcA/2Bh+Ldgb/R4SwLSZ W5JfKhktW/bEx8WBVt8NcN/V9GN4iymjL4fbRPmZTRtSgGLKPLw9Hd7MZv7FS8oNjw1n EOvg== X-Forwarded-Encrypted: i=1; AJvYcCVq4tYGnIHoonpdXXPGw5qccDDjJYErC8uBFbY3+V/BtPiCwGH/+3V0v6jGnM3UHp7W0SybENqngbB3gKY=@vger.kernel.org X-Gm-Message-State: AOJu0YxnxGoYPL5+CKYqcoR4ZpQhjpomL6JQ+mZg8ZwjvVNYsjP8APVN JIYZMxt/USOApg8byl/uX7uskkrKFpBcrH30J50TdH7hc51st+dVTYF6RkCU/C5a/2o= X-Gm-Gg: ASbGncvsFTF5+rUnwkV8BX7c71b3x5iUE228W7PlagMjoYdD0OIEdY0kTwuNjumUrAY LHThaA3FN2/VByW/k3oJT+XYDA2Pv77lWt6AuAQQd2i2NnSqCfSy9NJwhTg0sPaTJtQqUV6xRNJ meN9odanwFntoJqax6TVQzdwb2FGUJWht5PLN+kTi2C+yvSClEYPXtPFvQKMi6iYosaDpyfhMoq tKE5TcKtGz+4wa9sbMfNBb5K7CJ/QzSMDF7XAfawW98Pqmi542J7mo8f+uapkGRUvPDnN70E3x7 nGj7xipZiwgfQOfvGPmD+EgdWKq/2KJiPu7m1fXenLGfnznC+eP96+HXHFiJp/Hopq25Qnjf4H3 OViR/3lDmryaWYi95Uw== X-Google-Smtp-Source: AGHT+IGn0GRxBvM+WD5O7v7/hNVOsDJAMieISnJTHVWyn0GlU/XBWButKenSU4mlUYhOne1RniJKdQ== X-Received: by 2002:a05:6000:25ee:b0:3c7:44eb:dd77 with SMTP id ffacd0b85a97d-3c744ebe211mr9929433f8f.12.1756202090400; Tue, 26 Aug 2025 02:54:50 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:fed4:79fc:9440:6629]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c7117d5977sm15708447f8f.51.2025.08.26.02.54.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 02:54:50 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 26 Aug 2025 11:54:40 +0200 Subject: [PATCH 6/6] gpio: xra1403: don't print out global GPIO numbers in debugfs callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250826-gpio-dbg-show-base-v1-6-7f27cd7f2256@linaro.org> References: <20250826-gpio-dbg-show-base-v1-0-7f27cd7f2256@linaro.org> In-Reply-To: <20250826-gpio-dbg-show-base-v1-0-7f27cd7f2256@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-pwm@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1069; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=pqwEZ6klxsSv4inQWR27IXYKVls3Qm/tc/R/XY/nCmk=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBorYRhrRtwf1VkVEx/r9gY3Cm0Cya/2HLTxHfso Z84jtpt+hSJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaK2EYQAKCRARpy6gFHHX ctnOD/9TINMbHZubtrb6oT50/GRpHQJ063AdQj7zfSKZ59ymB2wM/mX8Pl1NkWFkEcxS9+JVk4Q lPCGUt2qfdhvXm5FVVMLwUbmtM9xF3GyeqiUrPPM80PrH0YhwCSOhpd8ghSm6QU6/mcbPNIAxnz iHZQDZsDHSgZhL6rcYIzKqG1T6MnBHYERna6eOUJvJflW6t1z+OV3LWM3rbImRGtgzgExtv7SLC 30vj3gnkMzlCC3/9UutUGDNB1kPT2iIHcQlPVPX3NT2J2i9c4JjsPzRHKmOJ/tf23t6sF/WcQY8 0K/+WFMJgJCYuA+BBeBvluPlLQadUddZSRNVLac8YMfZVbYS+GJgQvIH/51XCZKdmHV4LmsRxW8 OWeFH5Gxi2NYcqQOuJm92rLshkHQtFYUp9EdF6UniY5jyq2cMRjDlptaZX5r3544iUHG5UFl/px k4HJTHxyqPdHLwJDjbPrvddnDgcVqx4s1Jqth/Bz+apACEuyHb6IQAX6QQMzRFNLyE9VSnUNa9C iFFiyE1jb5ZspnxT+439i1UlBmTqgbQv2KXU1/QCJAba6Xalc2I3GIjoFd3cmf0xgJ4uhW2RytJ GepfYgtLR5FAxX02LJpbPuWxSPU83zXmv7NVjSnrk/lHcncdZLC4mtHIwKf+gcVHuW31WpU23Na lZ8o9Gcmx7zGsjA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski In order to further limit the number of references to the GPIO base number stored in struct gpio_chip, replace the global GPIO numbers in the output of debugfs callbacks by hardware offsets. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpio-xra1403.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-xra1403.c b/drivers/gpio/gpio-xra1403.c index faadcb4b0b2df0744711b4a8d211adf71ce49a38..7f3c98f9f902013cb4f1c9109da= b331609b28997 100644 --- a/drivers/gpio/gpio-xra1403.c +++ b/drivers/gpio/gpio-xra1403.c @@ -135,8 +135,7 @@ static void xra1403_dbg_show(struct seq_file *s, struct= gpio_chip *chip) gcr =3D value[XRA_GCR + 1] << 8 | value[XRA_GCR]; gsr =3D value[XRA_GSR + 1] << 8 | value[XRA_GSR]; for_each_requested_gpio(chip, i, label) { - seq_printf(s, " gpio-%-3d (%-12s) %s %s\n", - chip->base + i, label, + seq_printf(s, " gpio-%-3d (%-12s) %s %s\n", i, label, (gcr & BIT(i)) ? "in" : "out", str_hi_lo(gsr & BIT(i))); } --=20 2.48.1