From nobody Fri Oct 3 21:05:04 2025 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E0262FF659 for ; Mon, 25 Aug 2025 14:58:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756133886; cv=none; b=ifV5jsUJvBzW7pHUmOz3JNr6LwFGU8hlrdFcuKA4AOCA1OFCojKWv8VASGscKpRy485/3P59NwABVeEzpbZrCG/p12nLxnl7ImhjEdmQwp7NI8NC6OeKOMULIWtn5muAvso0+bzmYpfgTVZEdjNmG0EX+nGOHtEZQpXjAOKz6y8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756133886; c=relaxed/simple; bh=ZCOA1dM21DunNLDV0WZf6KhjFBCppPrsp5+Kx8CnzlY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dwwkvhyPTLSmYgO6s8u8VcM3hDMOqqeHf4LMxAbRIcnBKCJKhm/1pQ62Rid5MNaTIfrlMurAf5yoJf64Jo+gUo3i9jod8Jce6St1Eg7/8ruBxCcVG+Vg6npnrgPboqG0cnpYqRXIcBDcYOKzS+Aueql0T5NVEtZzdHs5rCp6MbE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=egCByvB0; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="egCByvB0" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-afcb78da8a7so705813366b.1 for ; Mon, 25 Aug 2025 07:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1756133883; x=1756738683; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xTzQ3AFf99voNBq9nE295ufzA7UoytsbpCDnPP4k4Ho=; b=egCByvB0CGJv2O2i+vnX/mCEY6YET4BBQSJ2uSBc7qceE+r3mr5w8QgvJ8+fycnKjL 7WMiTYwj+r4vytFFSKI9ZnzF8xS868dHTyabUSALHBtjf0RIHNzJaLps9sd6AdVbxP2c 6JkECXldd0VdLe6qxJ1AfU2HMkIgutSAITyII= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756133883; x=1756738683; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xTzQ3AFf99voNBq9nE295ufzA7UoytsbpCDnPP4k4Ho=; b=sznOEADvNhSPSxYyfCIzlnw4lhGSQCYtk1rwKMfFbgxgg1UjtRxm3bBvFtQsPfp8C8 QhdxQajP4vT0ldAYgozTuYuw/OEC1PkzZY7QVFuOxO7ODVWvZYeOwpQBl+MkSoExik0N XoM9ITtJBskhla8M4A0lQZuXd7jBwZK+ztvrgiecbj8yhrEwUIDCtxp/fy9fUw3QTSeo 4CrnQxieraEBrB0TsH/tF+0lZXn2Lm5t11ZhhYeUKKUPPftbIcSnKVQ6BCHjjHqRIG6U 9tQPqAdpyWg+Kr1qvzZDIR0BMy7qJc4AUZTya+nQ6DpChlxG2DEHTQCLDvGp9JG+go1Q jsUA== X-Forwarded-Encrypted: i=1; AJvYcCWvnBawY9JsX77r5HBVYDYFh4eeGMBVAib12TgFTBoekuu0lGAuQ1mvipigkJl70l7KxFV8J73mD/6Gbs4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw412iSevEs88fkha4us2EeQjSlEDOrWLyBLNaoNbZHND7gLLHE RDuRwJgzTbQAyLwqlHFzwttjXtP0la2LpWGZSl4NQEkmEOWWX1SkilD699jKPw4cqA== X-Gm-Gg: ASbGncvujfiWdNsbdWtc4jKObTYO9BrWRmb75b+Z52k5Y61UUzYEDY8bXKe5FDYo9lj j79ZECmSi0BATzaLV/Q4g0ArwQHkFCzgyMwEr7DkmLqhib+ci7J4OOwmdb/ANsiwlYj2x5WY05I f05fI8BXsCQpC22LKHbufePhTXoD7/MsWvlA93BUxDiiJ0Mf+uD6x36xU24cG7XvpNiC12nh2PW 8dq3+bXlDmqGewZsG1FUGIeddecAW6rhnFCaVzyBAeHKlnXZYzGGcCWZZ/18QWusKrZVXf0TDcV tGsLXm2rRFt2wy2D2YTnY1CfTCbTzGbcDoBdVMr7jHP9SyGGWXLMwofwmyHi8BqTuQlY09o5wYC tEinyGiFWyfB1zd69PnNlXAiRt86fuEY11CqahVjJc63RAqI6mF8C4uGPmXRDJ5QY4jUtxMxYji YF5qtTlwrmXj5b X-Google-Smtp-Source: AGHT+IFBnjzL8FuKILHR8m1mMoFjA8Jca/gOoCCUsOrFaj7AmltK/a12XxOh8THN9ShkNgEj13D5rg== X-Received: by 2002:a17:906:6a04:b0:ae6:f564:18b5 with SMTP id a640c23a62f3a-afe29047b49mr1141748466b.19.1756133882714; Mon, 25 Aug 2025 07:58:02 -0700 (PDT) Received: from akuchynski.c.googlers.com.com (168.23.91.34.bc.googleusercontent.com. [34.91.23.168]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe8d03f981sm117294166b.60.2025.08.25.07.58.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Aug 2025 07:58:02 -0700 (PDT) From: Andrei Kuchynski To: Heikki Krogerus , Abhishek Pandit-Subedi , Benson Leung , Jameson Thies , Tzung-Bi Shih , linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev Cc: Guenter Roeck , Greg Kroah-Hartman , Dmitry Baryshkov , "Christian A. Ehrhardt" , Venkat Jayaraman , linux-kernel@vger.kernel.org, Andrei Kuchynski Subject: [PATCH v2 1/5] usb: typec: Add alt_mode_override field to port property Date: Mon, 25 Aug 2025 14:57:46 +0000 Message-ID: <20250825145750.58820-2-akuchynski@chromium.org> X-Mailer: git-send-email 2.51.0.rc2.233.g662b1ed5c5-goog In-Reply-To: <20250825145750.58820-1-akuchynski@chromium.org> References: <20250825145750.58820-1-akuchynski@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This new field in the port properties dictates whether the Platform Policy Manager (PPM) allows the OS Policy Manager (OPM) to change the currently active, negotiated alternate mode. Signed-off-by: Andrei Kuchynski --- drivers/usb/typec/class.c | 9 ++++++--- drivers/usb/typec/class.h | 2 ++ include/linux/usb/typec.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c index 67a533e35150..9f86605ce125 100644 --- a/drivers/usb/typec/class.c +++ b/drivers/usb/typec/class.c @@ -457,11 +457,13 @@ static umode_t typec_altmode_attr_is_visible(struct k= object *kobj, struct attribute *attr, int n) { struct typec_altmode *adev =3D to_typec_altmode(kobj_to_dev(kobj)); + struct typec_port *port =3D typec_altmode2port(adev); =20 if (attr =3D=3D &dev_attr_active.attr) - if (!is_typec_port(adev->dev.parent) && - (!adev->ops || !adev->ops->activate)) - return 0444; + if (!is_typec_port(adev->dev.parent)) { + if (!port->mode_control || !adev->ops || !adev->ops->activate) + return 0444; + } =20 return attr->mode; } @@ -2681,6 +2683,7 @@ struct typec_port *typec_register_port(struct device = *parent, } =20 port->pd =3D cap->pd; + port->mode_control =3D !cap->no_mode_control; =20 ret =3D device_add(&port->dev); if (ret) { diff --git a/drivers/usb/typec/class.h b/drivers/usb/typec/class.h index db2fe96c48ff..c53a04b9dc75 100644 --- a/drivers/usb/typec/class.h +++ b/drivers/usb/typec/class.h @@ -80,6 +80,8 @@ struct typec_port { */ struct device *usb2_dev; struct device *usb3_dev; + + bool mode_control; }; =20 #define to_typec_port(_dev_) container_of(_dev_, struct typec_port, dev) diff --git a/include/linux/usb/typec.h b/include/linux/usb/typec.h index 252af3f77039..cbc94282e45e 100644 --- a/include/linux/usb/typec.h +++ b/include/linux/usb/typec.h @@ -304,6 +304,7 @@ struct typec_capability { enum typec_accessory accessory[TYPEC_MAX_ACCESSORY]; unsigned int orientation_aware:1; u8 usb_capability; + bool no_mode_control; =20 struct fwnode_handle *fwnode; void *driver_data; --=20 2.51.0.rc2.233.g662b1ed5c5-goog