From nobody Fri Oct 3 20:25:52 2025 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E0262FF659 for ; Mon, 25 Aug 2025 14:58:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756133886; cv=none; b=ifV5jsUJvBzW7pHUmOz3JNr6LwFGU8hlrdFcuKA4AOCA1OFCojKWv8VASGscKpRy485/3P59NwABVeEzpbZrCG/p12nLxnl7ImhjEdmQwp7NI8NC6OeKOMULIWtn5muAvso0+bzmYpfgTVZEdjNmG0EX+nGOHtEZQpXjAOKz6y8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756133886; c=relaxed/simple; bh=ZCOA1dM21DunNLDV0WZf6KhjFBCppPrsp5+Kx8CnzlY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dwwkvhyPTLSmYgO6s8u8VcM3hDMOqqeHf4LMxAbRIcnBKCJKhm/1pQ62Rid5MNaTIfrlMurAf5yoJf64Jo+gUo3i9jod8Jce6St1Eg7/8ruBxCcVG+Vg6npnrgPboqG0cnpYqRXIcBDcYOKzS+Aueql0T5NVEtZzdHs5rCp6MbE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=egCByvB0; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="egCByvB0" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-afcb78da8a7so705813366b.1 for ; Mon, 25 Aug 2025 07:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1756133883; x=1756738683; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xTzQ3AFf99voNBq9nE295ufzA7UoytsbpCDnPP4k4Ho=; b=egCByvB0CGJv2O2i+vnX/mCEY6YET4BBQSJ2uSBc7qceE+r3mr5w8QgvJ8+fycnKjL 7WMiTYwj+r4vytFFSKI9ZnzF8xS868dHTyabUSALHBtjf0RIHNzJaLps9sd6AdVbxP2c 6JkECXldd0VdLe6qxJ1AfU2HMkIgutSAITyII= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756133883; x=1756738683; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xTzQ3AFf99voNBq9nE295ufzA7UoytsbpCDnPP4k4Ho=; b=sznOEADvNhSPSxYyfCIzlnw4lhGSQCYtk1rwKMfFbgxgg1UjtRxm3bBvFtQsPfp8C8 QhdxQajP4vT0ldAYgozTuYuw/OEC1PkzZY7QVFuOxO7ODVWvZYeOwpQBl+MkSoExik0N XoM9ITtJBskhla8M4A0lQZuXd7jBwZK+ztvrgiecbj8yhrEwUIDCtxp/fy9fUw3QTSeo 4CrnQxieraEBrB0TsH/tF+0lZXn2Lm5t11ZhhYeUKKUPPftbIcSnKVQ6BCHjjHqRIG6U 9tQPqAdpyWg+Kr1qvzZDIR0BMy7qJc4AUZTya+nQ6DpChlxG2DEHTQCLDvGp9JG+go1Q jsUA== X-Forwarded-Encrypted: i=1; AJvYcCWvnBawY9JsX77r5HBVYDYFh4eeGMBVAib12TgFTBoekuu0lGAuQ1mvipigkJl70l7KxFV8J73mD/6Gbs4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw412iSevEs88fkha4us2EeQjSlEDOrWLyBLNaoNbZHND7gLLHE RDuRwJgzTbQAyLwqlHFzwttjXtP0la2LpWGZSl4NQEkmEOWWX1SkilD699jKPw4cqA== X-Gm-Gg: ASbGncvujfiWdNsbdWtc4jKObTYO9BrWRmb75b+Z52k5Y61UUzYEDY8bXKe5FDYo9lj j79ZECmSi0BATzaLV/Q4g0ArwQHkFCzgyMwEr7DkmLqhib+ci7J4OOwmdb/ANsiwlYj2x5WY05I f05fI8BXsCQpC22LKHbufePhTXoD7/MsWvlA93BUxDiiJ0Mf+uD6x36xU24cG7XvpNiC12nh2PW 8dq3+bXlDmqGewZsG1FUGIeddecAW6rhnFCaVzyBAeHKlnXZYzGGcCWZZ/18QWusKrZVXf0TDcV tGsLXm2rRFt2wy2D2YTnY1CfTCbTzGbcDoBdVMr7jHP9SyGGWXLMwofwmyHi8BqTuQlY09o5wYC tEinyGiFWyfB1zd69PnNlXAiRt86fuEY11CqahVjJc63RAqI6mF8C4uGPmXRDJ5QY4jUtxMxYji YF5qtTlwrmXj5b X-Google-Smtp-Source: AGHT+IFBnjzL8FuKILHR8m1mMoFjA8Jca/gOoCCUsOrFaj7AmltK/a12XxOh8THN9ShkNgEj13D5rg== X-Received: by 2002:a17:906:6a04:b0:ae6:f564:18b5 with SMTP id a640c23a62f3a-afe29047b49mr1141748466b.19.1756133882714; Mon, 25 Aug 2025 07:58:02 -0700 (PDT) Received: from akuchynski.c.googlers.com.com (168.23.91.34.bc.googleusercontent.com. [34.91.23.168]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe8d03f981sm117294166b.60.2025.08.25.07.58.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Aug 2025 07:58:02 -0700 (PDT) From: Andrei Kuchynski To: Heikki Krogerus , Abhishek Pandit-Subedi , Benson Leung , Jameson Thies , Tzung-Bi Shih , linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev Cc: Guenter Roeck , Greg Kroah-Hartman , Dmitry Baryshkov , "Christian A. Ehrhardt" , Venkat Jayaraman , linux-kernel@vger.kernel.org, Andrei Kuchynski Subject: [PATCH v2 1/5] usb: typec: Add alt_mode_override field to port property Date: Mon, 25 Aug 2025 14:57:46 +0000 Message-ID: <20250825145750.58820-2-akuchynski@chromium.org> X-Mailer: git-send-email 2.51.0.rc2.233.g662b1ed5c5-goog In-Reply-To: <20250825145750.58820-1-akuchynski@chromium.org> References: <20250825145750.58820-1-akuchynski@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This new field in the port properties dictates whether the Platform Policy Manager (PPM) allows the OS Policy Manager (OPM) to change the currently active, negotiated alternate mode. Signed-off-by: Andrei Kuchynski --- drivers/usb/typec/class.c | 9 ++++++--- drivers/usb/typec/class.h | 2 ++ include/linux/usb/typec.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c index 67a533e35150..9f86605ce125 100644 --- a/drivers/usb/typec/class.c +++ b/drivers/usb/typec/class.c @@ -457,11 +457,13 @@ static umode_t typec_altmode_attr_is_visible(struct k= object *kobj, struct attribute *attr, int n) { struct typec_altmode *adev =3D to_typec_altmode(kobj_to_dev(kobj)); + struct typec_port *port =3D typec_altmode2port(adev); =20 if (attr =3D=3D &dev_attr_active.attr) - if (!is_typec_port(adev->dev.parent) && - (!adev->ops || !adev->ops->activate)) - return 0444; + if (!is_typec_port(adev->dev.parent)) { + if (!port->mode_control || !adev->ops || !adev->ops->activate) + return 0444; + } =20 return attr->mode; } @@ -2681,6 +2683,7 @@ struct typec_port *typec_register_port(struct device = *parent, } =20 port->pd =3D cap->pd; + port->mode_control =3D !cap->no_mode_control; =20 ret =3D device_add(&port->dev); if (ret) { diff --git a/drivers/usb/typec/class.h b/drivers/usb/typec/class.h index db2fe96c48ff..c53a04b9dc75 100644 --- a/drivers/usb/typec/class.h +++ b/drivers/usb/typec/class.h @@ -80,6 +80,8 @@ struct typec_port { */ struct device *usb2_dev; struct device *usb3_dev; + + bool mode_control; }; =20 #define to_typec_port(_dev_) container_of(_dev_, struct typec_port, dev) diff --git a/include/linux/usb/typec.h b/include/linux/usb/typec.h index 252af3f77039..cbc94282e45e 100644 --- a/include/linux/usb/typec.h +++ b/include/linux/usb/typec.h @@ -304,6 +304,7 @@ struct typec_capability { enum typec_accessory accessory[TYPEC_MAX_ACCESSORY]; unsigned int orientation_aware:1; u8 usb_capability; + bool no_mode_control; =20 struct fwnode_handle *fwnode; void *driver_data; --=20 2.51.0.rc2.233.g662b1ed5c5-goog From nobody Fri Oct 3 20:25:52 2025 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB3B13002AE for ; Mon, 25 Aug 2025 14:58:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756133889; cv=none; b=l1doMcrYn9xH4eu49++7L8f15en5h0LRyHOnuxiUXsY86b5Y8vdzj/98cSfxFcHb7dST3nFaO/phwJgMgu809D0ETwW2batHoGa4r6CYOHjENDL23JRnI2eZE7lZq3vLgZoutEHV1RXoG+dIrDv/5YV3njFUoZLRcDBQsVCJQv4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756133889; c=relaxed/simple; bh=tkimgEY4C8jjn4oRfroM6cLsK17WffIXDAl9IE7NHq4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rdlBWWJENm9eCax/cfySbQ8vzcwDLCIjc1W75Y9XOLvGDl5fHux3h79CwygMVfrbE9cqPYR2x5UkpZK0VM4xfNFOYrtpgvXopYoC9+qF3QNOoltIdzy0kAnd93resSsgNpR2WQChuw9llKUK7stz11Q80WXkN1THqoHlXYgHKI0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=VDbqnCk6; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="VDbqnCk6" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-afcb7ae31caso822951966b.3 for ; Mon, 25 Aug 2025 07:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1756133886; x=1756738686; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qhhWTF/hAYz+kqb7eG5oSk05Be3U3tovVz6EKeBpeMI=; b=VDbqnCk6jwaqWXC12jUfgzaKWOlOSzV4moyqkx7FrPWdjORbOTV7LlWNOLXp+W+voU mkQAaPJeQX6A1dkDDiabFx+m9CKYzpnYL93QsGSu6RODH64p+GDj3aXbJln8swo077Ou FrO/PTyKXja79XfveOi4ltsx4qZaikggdgehw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756133886; x=1756738686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qhhWTF/hAYz+kqb7eG5oSk05Be3U3tovVz6EKeBpeMI=; b=NYwn8NQLMXg2h5XR1gw/piT+E5C+zPHNG3+2TyeKm8S/lU3Sin4ZxKtyhbpjXORdHS 3o81/bOUzGwtvUzgrtkb0lbu3sbZbGAtzckM5ciwahaneP7hvKnThohPhjUt5CA+fyd8 eVUu7KJhcq8Dao2kZC3ofEHBRmNrYD7lTPcvTjMncFy8iag8E+Cy/gvsmyyxWXoAxbh2 qUShb8BVOcmnXm52I8ag7kXWCXKojjHNAFU60XITL8rBI5eIYj/o58Hwl0hQz6CxWFAv 4GstjrWgIdNzOLXSCDX/SYeMTPuHq7QWOHwhzJR5Mc79ysYwcHA6BNHvm6+RBVYCSRTA 3CZw== X-Forwarded-Encrypted: i=1; AJvYcCXj+TY33nKozjYL5dyeBpROD6A9qBzdBbiFLuFllRKMfbsJgQ0fc19tdgWzqVDOFeHQrWbNCSkQSVKJtsg=@vger.kernel.org X-Gm-Message-State: AOJu0YyHu6t71fHNxkW8cKROMCiN97dXOpRuNr04ns7mwLbqupPfn3fc 0Zhp47kR7cC0El5mFgoJJlJzSbqkyDZKetX10CAd7Ct9h1XVEMKtpHAaVh6Iwg3JnQ== X-Gm-Gg: ASbGncvhcCEgnJGnTQzQSjwLl6RK0lg1YUnS2QvFzAhYmyVAzG8qXDoG/QX9TfkrDdg ZDnr3BIKf8mowDmzFKCkhoE4pGnh43G2kIvKWY3yRHF+FfQtOF1oJCED4aQOmNMMmisFIALTWF1 ESdRgwYIGpX2BX/XHXXEMBTFXvaYaXWcyXPWkYAb0HchstqXnjytLRHLAxVOR6VFd2URW6eiEOy Z8r53nvd8XHa+UOdRNlIKvz/mDkO2UuY13jTfD5ZPFDlS9PnvsUWYwUq95s5/cBgjl7I2nQIZYg 5K88MJ3MrtrbBUlJTa1kh429sD4OoIn0+JF5JKiwqOM24Xy2KEBckio0gKFSsE/4KPjZ7avnGI6 y8t7PxQXUJ18ygOs6DMWRHRrJW9nfNckbA2p98OraTocQbAJ070udX1iSE8nXa+aNvljlFh5ff3 hMzXqnqGZVDFuP X-Google-Smtp-Source: AGHT+IEzjvHrN1iQIq8FAKzUqb34qM6bbiS8410ZZtrIWblYT3InjbPAMTBFJWEl9Bykqq/40gzsjQ== X-Received: by 2002:a17:906:6a0f:b0:ae3:635c:53c1 with SMTP id a640c23a62f3a-afe2974ea3bmr1211128166b.54.1756133886030; Mon, 25 Aug 2025 07:58:06 -0700 (PDT) Received: from akuchynski.c.googlers.com.com (168.23.91.34.bc.googleusercontent.com. [34.91.23.168]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe8d03f981sm117294166b.60.2025.08.25.07.58.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Aug 2025 07:58:05 -0700 (PDT) From: Andrei Kuchynski To: Heikki Krogerus , Abhishek Pandit-Subedi , Benson Leung , Jameson Thies , Tzung-Bi Shih , linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev Cc: Guenter Roeck , Greg Kroah-Hartman , Dmitry Baryshkov , "Christian A. Ehrhardt" , Venkat Jayaraman , linux-kernel@vger.kernel.org, Andrei Kuchynski Subject: [PATCH v2 2/5] platform/chrome: cros_ec_typec: Set alt_mode_override flag Date: Mon, 25 Aug 2025 14:57:47 +0000 Message-ID: <20250825145750.58820-3-akuchynski@chromium.org> X-Mailer: git-send-email 2.51.0.rc2.233.g662b1ed5c5-goog In-Reply-To: <20250825145750.58820-1-akuchynski@chromium.org> References: <20250825145750.58820-1-akuchynski@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This flag specifies that the Embedded Controller (EC) must receive explicit approval from the Application Processor (AP) before initiating Type-C alternate modes or USB4 mode. Signed-off-by: Andrei Kuchynski Reviewed-by: Heikki Krogerus --- drivers/platform/chrome/cros_ec_typec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chr= ome/cros_ec_typec.c index b712bcff6fb2..c0806c562bb9 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -491,6 +491,7 @@ static int cros_typec_init_ports(struct cros_typec_data= *typec) =20 cap->driver_data =3D cros_port; cap->ops =3D &cros_typec_usb_mode_ops; + cap->no_mode_control =3D !typec->ap_driven_altmode; =20 cros_port->port =3D typec_register_port(dev, cap); if (IS_ERR(cros_port->port)) { --=20 2.51.0.rc2.233.g662b1ed5c5-goog From nobody Fri Oct 3 20:25:52 2025 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E75223009F5 for ; Mon, 25 Aug 2025 14:58:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756133892; cv=none; b=ZpeAfFvie5xu3GLfh9SqsUBR9EI25WAbei6a5DouVVxExkHmIzpwvH+ZgHuWWb20RPD3WKJ80EXUiwC5UWH9gcL9ZjgXKqCn7o+P3oAoNTSjCxMAOW0wuRpvruVTn5AetBlKSq3mLVFBJesOLZDX2prncfpcr5r/xOkRsNJIgYU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756133892; c=relaxed/simple; bh=sCzcaHvyNBs2XDXKynfkNcDEJnlMJJf0GaVUdmsnhSQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JeDk4qTC/0NhnIctVhmC0kEjT25xOlyjGbBHqZSWVj90XhZCOCIrwrQFaNikOQr+GAPn5U51R1dUtoVHKQGTf7LGCp8dNJWO7QweRBzR8y09e979D9BoDI9J0PGlWm6vcYkMvqfwZVBW0mq86E21O6yiTg2vHnNQylYhuA9bVBA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=nQFjRF/m; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nQFjRF/m" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-afe84202bc2so145049966b.2 for ; Mon, 25 Aug 2025 07:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1756133889; x=1756738689; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xEe7YY1Cpi7JTuOOA0pZSF33Y12/vgAOx6rgD/OGWgw=; b=nQFjRF/mRIKyWLqe4gUhep7kBD7cpHUrxARXwiwcusgeBPJEa43vJsFuH0qayHH//C Cy2iJKpKBVGjDirQ0nxfGPW9IY6OB5zio8PCWshuztPN8h6I2dogJQb87EGVanyMefpY QTPtzeDnNpHa1cU1ueGq+AApabEiW8ax2c+6o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756133889; x=1756738689; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xEe7YY1Cpi7JTuOOA0pZSF33Y12/vgAOx6rgD/OGWgw=; b=Zy7dAoWSM2ZVr903HcryZY1Vw0P0y2onE3+QK/lXJhq5hQWYBxL0fodcUGAqHx6+Q2 eqKiP3iCXN59Lavhl0d9ps9d+xIHP4oYCvVAGL0TmmVaE6G9o+ZPhGMe/tiZ/9xln42k 4IVM7jtiWsYrIwMMD00qWjzCKuicwN5/fBg8jHGZC1dmjg6or/IVYi3XVZJl7CV6FaIH 2i6GKC9SKJY5O4gxtdRXURFmspEY12VCL4uC94E+rzb0ceBo8tXGJi/zRn7SDaz7TeH3 TRT9ZEUfts4tuPyY8bpKi4WL1IM3d4jOxdLPB+4ifIbKMjB9n7KJMcFTehc22nlFgucR qf3Q== X-Forwarded-Encrypted: i=1; AJvYcCXWV9gTAeLGiiblN5dqnj1MDxDe/3mHI62ib9WUEnQrwybs7DouKMUuMgXavYvoOc2jtLOte+JSZzGrXQk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxomi3aLJ4NTQTiQrcjN8mPSUbzuxG099l0dawAP3vcXzTwFfcB E/fYSU60w0MNpo4tqA/PMse0DJq0v0TtpMhrRXpc0REYhwQY5rpzAWOuth4te8K01A== X-Gm-Gg: ASbGnctQGrlOSRKi73kFvrYP/6euFtEoFqpPFzX/oXNuLtHIj5uH9XaGFdO8FQq7+M+ GZblGcY8nM3XybEloxr2wCQuLL9ygROIzuEiD9vTmf9AZdlw7QYZzxLaW3bPB5yyRspj/JAB/NL ZhgyGkVS1TnwgbDMrv4FOD6d3ho7Aty/+mw4QM6mya6/szhARFr/rjlqix3FWK2tbmjfFUUAFf+ g9rdHn8Ny0/aSw5nCebvD+gKmFjRPZSczqWhoSjkZoPOa9vVoel0D9AWsjn65rsgu1ekfp0irDq 1p2RZt/G9V2ZKDJ8I114qVCjbzrVKqLG5OBUAH8BP49w8rLCectLKRZTDZuQ+F+aglkPkEfr8w/ QTvAKXwVY6ihMNpMwO/yl7weAYwnKaG7dqbGjrC6yjDmXZw3ttoOdSiH2re2JQM2fHX+lnZL1bS dLis4yzG2fkfB+ X-Google-Smtp-Source: AGHT+IFyGVkJn7Pe4QajoYR658kFpe1L884A54RCJlaO5lAZ/VrHyO1MunmHlcOvbaeR2ixPy/zAag== X-Received: by 2002:a17:907:86a1:b0:afe:735a:fdf with SMTP id a640c23a62f3a-afe735a1362mr500412866b.36.1756133889266; Mon, 25 Aug 2025 07:58:09 -0700 (PDT) Received: from akuchynski.c.googlers.com.com (168.23.91.34.bc.googleusercontent.com. [34.91.23.168]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe8d03f981sm117294166b.60.2025.08.25.07.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Aug 2025 07:58:08 -0700 (PDT) From: Andrei Kuchynski To: Heikki Krogerus , Abhishek Pandit-Subedi , Benson Leung , Jameson Thies , Tzung-Bi Shih , linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev Cc: Guenter Roeck , Greg Kroah-Hartman , Dmitry Baryshkov , "Christian A. Ehrhardt" , Venkat Jayaraman , linux-kernel@vger.kernel.org, Andrei Kuchynski Subject: [PATCH v2 3/5] usb: typec: ucsi: Set alt_mode_override flag Date: Mon, 25 Aug 2025 14:57:48 +0000 Message-ID: <20250825145750.58820-4-akuchynski@chromium.org> X-Mailer: git-send-email 2.51.0.rc2.233.g662b1ed5c5-goog In-Reply-To: <20250825145750.58820-1-akuchynski@chromium.org> References: <20250825145750.58820-1-akuchynski@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This flag indicates that the PPM allows the OPM to change the currently negotiated alternate mode using the SET_NEW_CAM command. Signed-off-by: Andrei Kuchynski --- drivers/usb/typec/ucsi/ucsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index 0d6b0cf5a7cd..85a6b7fc6d93 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -1632,6 +1632,8 @@ static int ucsi_register_port(struct ucsi *ucsi, stru= ct ucsi_connector *con) =20 cap->driver_data =3D con; cap->ops =3D &ucsi_ops; + cap->no_mode_control =3D + !(con->ucsi->cap.features & UCSI_CAP_ALT_MODE_OVERRIDE); =20 if (ucsi->ops->update_connector) ucsi->ops->update_connector(con); --=20 2.51.0.rc2.233.g662b1ed5c5-goog From nobody Fri Oct 3 20:25:52 2025 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CD59301037 for ; Mon, 25 Aug 2025 14:58:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756133895; cv=none; b=j7Bj0KC/9q8lijxuFKCuwuK1KMB1hwGvbPz3aNneYWUKwnx3nf4R8Lg+zmztVlNmY/pKBgdZNgY6pja9Dc+6uQkFzv1Est+M6kUkle4DvMYZ6FP91JMXdazdGrLBrmFsz6gMJpUXfw9G9UVxOADN1kfOj+5vLChfsLIaUwfGqXM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756133895; c=relaxed/simple; bh=0BGpDIvSRWnL+9XoMN9WOJgDbPiOu14Iony9ATZBpSs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DN8LjdZ5+8C53Es7cuBMv1/eF0Oqfak/SQnBIn/hiNzLfvAMd6gtjmPaUrauN2VkRKCLhLvLMZPjXY4kPO1fkKx4KrkrIrdxybpoAe+p7i++So+ht0qOlyUREtV+2BLfkxpOFyk3onuwN/G2kppB/eXRHvC5QLEVcAkllAf2xDI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=GcvgPcRE; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="GcvgPcRE" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-afcb7a0442bso739018566b.2 for ; Mon, 25 Aug 2025 07:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1756133892; x=1756738692; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RtPmPO5XNYkE7V8xoQ7flpHn7rik8pyLeIH7/5dO6qM=; b=GcvgPcRElz5dzOBuUxwmPvGTSfJ+77Sxe9H+5XF+T6pcK8k/BD4SdFck9LsS1f/QyI PIR9Rpn8KINW0aEKbKt1Ed0pX62i5tR+NDETkiR51fnblNS1LtlOAIqC86ftBcZ7Rn4o E7ESOge8DCsoo2PiQUW21rm1WoaGZCj7AXLzo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756133892; x=1756738692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RtPmPO5XNYkE7V8xoQ7flpHn7rik8pyLeIH7/5dO6qM=; b=dx7G8GQ4s2ZHUR2rw3CUMGwWQLG5U7fPrlSBydoMw1PkHOb1iBgRz8C1BNvM4krzjp 4VNY8TI7gAKZX794Q+3BQOknbsUa+vtXNNsbDu0BJ9qQgpc/pVl8dSES380OAgRIU4cZ O5pFcCGa6OkadmH6/NMQcsUsG+BlBXAvUScxnCUa6q+KnX8v0BY8fY8ZDCEy8WCKxIRg 6rwwII+oz6rVPrtW+6p2mspTri4npcqkGGDdUgcUX0+N/e5UYm2PuJOjQrp5op31r1lX HNlNZ06G12Ro5cT/R+P6MsR3nKJYrTSKKQX6hwKdOV5BpjYz6T+jScCsUa0obGxRlqFB JlRw== X-Forwarded-Encrypted: i=1; AJvYcCUJ5rDetdjXJYjZey+lQqZexqbfvwmwqbCMTJrQm3sC2bjbJFtkcZFBlrzx+k8+Tk7/NTeENGnW0HXG83E=@vger.kernel.org X-Gm-Message-State: AOJu0Yxh2yJ1SGibI/YsBxHDhdbIOWmb0se3K5aF4N4bPCNePDRJ2P8G ADUSrm6WZUq2ChtXAXPxvrmjyRhkTAIqeSX00yDwQplxA7RbggYe1oanwZIdXacZzw== X-Gm-Gg: ASbGnctLq+30vE3qyu/PqZXr1Zp0qR4UkE469Y7IZwU4+HymlPF3etsH/Ty6Z+SOkZP mktgYRdLM0SOyZSG82mICJyeoF3rwq8QmiaRZMy2zU9+5b4/G9sGCA4CY/x88zA3N1kW6pufLlR dI6s3Pa6/dFxOdqEnID/uCUfDKVp2518zbxHEx/2bovfO+OeBNnQJM/Rewaz3s/UIQx3SKAUDCb 7mm2Gn4oxoat9yN+AatUGOBvrER6J6NIGogUDPtTeom/AJH7mmcKZGRmKKiG1G5HY1LSEvp3rml so23CcsLdZfIpeTOLe/KIIyPc/+U6KZjHB/aHrjVqVNijf4wOGYccKwqOnYAuB0rWRfFh1jF3nO KW/1nVNsGe/aOE6hn1clA3LXWaH0KnsIMgNqZ8WP2g7YCLDuAQtEn0kgti22IxfYE2yVsj9VFQw jOQ6JwFBikkoKG X-Google-Smtp-Source: AGHT+IFHIKJNDrGoroZVVpWmctlQ9FpQ8lFadPfFf19Uh7Mtgvrs7j6pKi3bP2ml+nSy2qOMBnyr+A== X-Received: by 2002:a17:907:6e92:b0:af9:5b3f:2dfc with SMTP id a640c23a62f3a-afe2965ac9fmr1000432766b.47.1756133892254; Mon, 25 Aug 2025 07:58:12 -0700 (PDT) Received: from akuchynski.c.googlers.com.com (168.23.91.34.bc.googleusercontent.com. [34.91.23.168]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe8d03f981sm117294166b.60.2025.08.25.07.58.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Aug 2025 07:58:11 -0700 (PDT) From: Andrei Kuchynski To: Heikki Krogerus , Abhishek Pandit-Subedi , Benson Leung , Jameson Thies , Tzung-Bi Shih , linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev Cc: Guenter Roeck , Greg Kroah-Hartman , Dmitry Baryshkov , "Christian A. Ehrhardt" , Venkat Jayaraman , linux-kernel@vger.kernel.org, Andrei Kuchynski Subject: [PATCH v2 4/5] usb: typec: Implement alternate mode priority handling Date: Mon, 25 Aug 2025 14:57:49 +0000 Message-ID: <20250825145750.58820-5-akuchynski@chromium.org> X-Mailer: git-send-email 2.51.0.rc2.233.g662b1ed5c5-goog In-Reply-To: <20250825145750.58820-1-akuchynski@chromium.org> References: <20250825145750.58820-1-akuchynski@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch introduces APIs to manage the priority of USB Type-C alternate modes. These APIs allow for setting and retrieving a priority number for each mode. If a new priority value conflicts with an existing mode's priority, the priorities of the conflicting mode and all subsequent modes are automatically incremented to ensure uniqueness. Signed-off-by: Andrei Kuchynski --- drivers/usb/typec/Makefile | 2 +- drivers/usb/typec/mode_selection.c | 38 ++++++++++++++++++++++++++++++ drivers/usb/typec/mode_selection.h | 6 +++++ include/linux/usb/typec_altmode.h | 1 + 4 files changed, 46 insertions(+), 1 deletion(-) create mode 100644 drivers/usb/typec/mode_selection.c create mode 100644 drivers/usb/typec/mode_selection.h diff --git a/drivers/usb/typec/Makefile b/drivers/usb/typec/Makefile index 7a368fea61bc..8a6a1c663eb6 100644 --- a/drivers/usb/typec/Makefile +++ b/drivers/usb/typec/Makefile @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_TYPEC) +=3D typec.o -typec-y :=3D class.o mux.o bus.o pd.o retimer.o +typec-y :=3D class.o mux.o bus.o pd.o retimer.o mode_selection.o typec-$(CONFIG_ACPI) +=3D port-mapper.o obj-$(CONFIG_TYPEC) +=3D altmodes/ obj-$(CONFIG_TYPEC_TCPM) +=3D tcpm/ diff --git a/drivers/usb/typec/mode_selection.c b/drivers/usb/typec/mode_se= lection.c new file mode 100644 index 000000000000..2179bf25f5d4 --- /dev/null +++ b/drivers/usb/typec/mode_selection.c @@ -0,0 +1,38 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright 2025 Google LLC. + */ + +#include "mode_selection.h" +#include "class.h" +#include "bus.h" + +static int increment_duplicated_priority(struct device *dev, void *data) +{ + struct typec_altmode **alt_target =3D (struct typec_altmode **)data; + + if (is_typec_altmode(dev)) { + struct typec_altmode *alt =3D to_typec_altmode(dev); + + if (alt !=3D *alt_target && alt->priority =3D=3D (*alt_target)->priority= ) { + alt->priority++; + *alt_target =3D alt; + return 1; + } + } + + return 0; +} + +void typec_mode_set_priority(struct typec_altmode *alt, + const unsigned int priority) +{ + struct typec_port *port =3D to_typec_port(alt->dev.parent); + int res =3D 1; + + alt->priority =3D priority; + + while (res) + res =3D device_for_each_child(&port->dev, &alt, + increment_duplicated_priority); +} diff --git a/drivers/usb/typec/mode_selection.h b/drivers/usb/typec/mode_se= lection.h new file mode 100644 index 000000000000..cbf5a37e6404 --- /dev/null +++ b/drivers/usb/typec/mode_selection.h @@ -0,0 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#include + +void typec_mode_set_priority(struct typec_altmode *alt, + const unsigned int priority); diff --git a/include/linux/usb/typec_altmode.h b/include/linux/usb/typec_al= tmode.h index b3c0866ea70f..571c6e00b54f 100644 --- a/include/linux/usb/typec_altmode.h +++ b/include/linux/usb/typec_altmode.h @@ -28,6 +28,7 @@ struct typec_altmode { int mode; u32 vdo; unsigned int active:1; + unsigned int priority; =20 char *desc; const struct typec_altmode_ops *ops; --=20 2.51.0.rc2.233.g662b1ed5c5-goog From nobody Fri Oct 3 20:25:52 2025 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 098E1301495 for ; Mon, 25 Aug 2025 14:58:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756133899; cv=none; b=Ml+G1+y+4mRDHX2wL85E7XdsX1icmR9DBGCuJi6ZurElBRCgYeHmkVYvE0vWOmp17Ctf+ik8XM96NEcaCilJsoIzX8Lwb0Z1+Bk8D9u93C/m9OO2O+Am7J6H8vvm1r0iR12bsTlYD3v1aG+CqUEWP8Zm+00YUEnM3N0H/Edum9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756133899; c=relaxed/simple; bh=XF1HMt7dKr2pKHf61hV+dMVYlJL1q20sHlne9+/cMD8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n/HDDU+2WdPuLsx9LcTsGqFEUrRyocamMIyqa2USbRYX7hNBOqB/CiEeVO7Ed9Oqj0wOLvPYe7WN36h9kSURMRPImkx1cqmZgG0JELF1F/LYuZzJbPvfejXlImgpIYYHbJSoxcpqf49CBGxCr9DSIYmrT4clnruzpDDONlue/Hg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=IgSX/PBm; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="IgSX/PBm" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-afcb7aea37cso579169566b.3 for ; Mon, 25 Aug 2025 07:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1756133895; x=1756738695; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q03fJibhKtDh3Ep473H06zamAbGTx2QJY+Jsovc71/Q=; b=IgSX/PBmrfE9IeRxR7sXEgZ/hCpJmvjQSwIf+y8zziwdRpcMZ9AlbMbSwNY3pFfFzg k6cHiEslq4PNVBqiIVxRtVOsca8anSZF/l+k0qkUfI5OWgGNmxIs8eSBWa1zADJSssK0 6yIaEBT1N+0uq4RZJcIvv3GHSqzXXOSGu12nc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756133895; x=1756738695; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q03fJibhKtDh3Ep473H06zamAbGTx2QJY+Jsovc71/Q=; b=koTnjPgQ1Ej9/U1qv77p6RtLXw4q1tbLFdGqpjTvItmO+IVt2FixSzHqZIKt7BNaKW 7b5b55bjKKKh+/rH2xf8nMhUZHvEMH76VQ7HZeaLHjKNn39jqep7TQ1bvX/SravxN3bI jsRowyBAPjeGBOtsculV29V2+gBFbFVvhc2I6QJJs3SYdpykmj1jFS8EIayrHCHz07Np eGaNxeFMN2/lEzpEkbT+fOGwVA3BRzFGT8p9+KqpauYVeZljF2iBYkfVNsZZ8MvL12P7 uZQGLMijtfeXLnp8sD8V6MeLv6to6/iTpDewTdORSOGK+BvFvro+YabPlJgTibXBrWY0 uCgg== X-Forwarded-Encrypted: i=1; AJvYcCVGEFREIMR36KqJpqYqXx9bVlegQqySj4pRDpok4cUtF23ZFD+2XO1igGJy0/+W7OWVxiD8a0tbUbHWisE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4jcpryI7JkIjwAbihbCQRe5keyPxUS8QW+Tm+lanOStF9CMs4 VHHwpv8rpu5V0YJB/z24YP2IWLfzttf8BLtMJcnLd+EJJbbs/ftPxKCRsc7fADSdTw== X-Gm-Gg: ASbGncsUIRAiFa331cKt52Iqr4xiKKCo0r+4kZv5sTb5wunwxRhHnP1VGsvRQZJi/Qu vAjjAI03kZXu967sDE/pwu5mFfYK4gojJliZs1Uw6bwbq2uRrUe7ZNqfiRCLMWu1DBFpvte6V6b 6QkRwkdljYL695bc5m6Jz/zMAAlVaHr345ZqF45cPYCYI0OCIDUMTeDD7wnsaY8LymsTahS25vQ 6QPr8yXuC49gp8vDR1hq46/6F4fZvl7BZbe74gYdY477hQB4DpDawyY4lli7BRmzNXSHZoFlY4F EHM/hGhDva3p2OGr8uaerd7kPYzvbaeqYJTRrqFp2+H426uWffxKwBhJQRknnn6V+CyJMGAdT4/ O3FD1TG7qPYuvIFpON1J0mnX4rBCs6Ln7u+QtOgabNlUz3tLofVn9Ng200QjImlexJHNgupEfX6 MnU3rHNQBmfPnVHsfNkEkm0k907rjWcKRxAw== X-Google-Smtp-Source: AGHT+IFQk16CgrOBqQfmn0Kw8YzFpuW8oHF6Fa5HEls+UObeDgxxUHP9Lle73RVTSHFp8RT//Y03tg== X-Received: by 2002:a17:907:9611:b0:afd:be7d:725 with SMTP id a640c23a62f3a-afe296e8771mr1244313266b.61.1756133895202; Mon, 25 Aug 2025 07:58:15 -0700 (PDT) Received: from akuchynski.c.googlers.com.com (168.23.91.34.bc.googleusercontent.com. [34.91.23.168]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe8d03f981sm117294166b.60.2025.08.25.07.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Aug 2025 07:58:14 -0700 (PDT) From: Andrei Kuchynski To: Heikki Krogerus , Abhishek Pandit-Subedi , Benson Leung , Jameson Thies , Tzung-Bi Shih , linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev Cc: Guenter Roeck , Greg Kroah-Hartman , Dmitry Baryshkov , "Christian A. Ehrhardt" , Venkat Jayaraman , linux-kernel@vger.kernel.org, Andrei Kuchynski Subject: [PATCH v2 5/5] usb: typec: Expose alternate mode priority via sysfs Date: Mon, 25 Aug 2025 14:57:50 +0000 Message-ID: <20250825145750.58820-6-akuchynski@chromium.org> X-Mailer: git-send-email 2.51.0.rc2.233.g662b1ed5c5-goog In-Reply-To: <20250825145750.58820-1-akuchynski@chromium.org> References: <20250825145750.58820-1-akuchynski@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch introduces a priority sysfs attribute to the USB Type-C alternate mode port interface. This new attribute allows user-space to configure the numeric priority of alternate modes managing their preferred order of operation. Signed-off-by: Andrei Kuchynski Reviewed-by: Heikki Krogerus --- Documentation/ABI/testing/sysfs-class-typec | 11 +++++++ drivers/usb/typec/class.c | 32 ++++++++++++++++++++- 2 files changed, 42 insertions(+), 1 deletion(-) diff --git a/Documentation/ABI/testing/sysfs-class-typec b/Documentation/AB= I/testing/sysfs-class-typec index 38e101c17a00..dab3e4e727b6 100644 --- a/Documentation/ABI/testing/sysfs-class-typec +++ b/Documentation/ABI/testing/sysfs-class-typec @@ -162,6 +162,17 @@ Description: Lists the supported USB Modes. The defaul= t USB mode that is used - usb3 (USB 3.2) - usb4 (USB4) =20 + What: /sys/class/typec///priority +Date: July 2025 +Contact: Andrei Kuchynski +Description: + Displays and allows setting the priority for a specific alt-mode. + When read, it shows the current integer priority value. Lower numerical + values indicate higher priority (0 is the highest priority). + If the new value is already in use by another mode, the priority of the + conflicting mode and any subsequent modes will be incremented until they + are all unique. + USB Type-C partner devices (eg. /sys/class/typec/port0-partner/) =20 What: /sys/class/typec/-partner/accessory_mode diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c index 9f86605ce125..aaab2e1e98b4 100644 --- a/drivers/usb/typec/class.c +++ b/drivers/usb/typec/class.c @@ -19,6 +19,7 @@ #include "bus.h" #include "class.h" #include "pd.h" +#include "mode_selection.h" =20 static DEFINE_IDA(typec_index_ida); =20 @@ -445,11 +446,34 @@ svid_show(struct device *dev, struct device_attribute= *attr, char *buf) } static DEVICE_ATTR_RO(svid); =20 +static ssize_t priority_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t size) +{ + unsigned int val; + int err =3D kstrtouint(buf, 10, &val); + + if (!err) { + typec_mode_set_priority(to_typec_altmode(dev), val); + return size; + } + + return err; +} + +static ssize_t priority_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + return sprintf(buf, "%u\n", to_typec_altmode(dev)->priority); +} +static DEVICE_ATTR_RW(priority); + static struct attribute *typec_altmode_attrs[] =3D { &dev_attr_active.attr, &dev_attr_mode.attr, &dev_attr_svid.attr, &dev_attr_vdo.attr, + &dev_attr_priority.attr, NULL }; =20 @@ -459,11 +483,15 @@ static umode_t typec_altmode_attr_is_visible(struct k= object *kobj, struct typec_altmode *adev =3D to_typec_altmode(kobj_to_dev(kobj)); struct typec_port *port =3D typec_altmode2port(adev); =20 - if (attr =3D=3D &dev_attr_active.attr) + if (attr =3D=3D &dev_attr_active.attr) { if (!is_typec_port(adev->dev.parent)) { if (!port->mode_control || !adev->ops || !adev->ops->activate) return 0444; } + } else if (attr =3D=3D &dev_attr_priority.attr) { + if (!is_typec_port(adev->dev.parent) || !port->mode_control) + return 0; + } =20 return attr->mode; } @@ -2491,6 +2519,8 @@ typec_port_register_altmode(struct typec_port *port, to_altmode(adev)->retimer =3D retimer; } =20 + typec_mode_set_priority(adev, 0); + return adev; } EXPORT_SYMBOL_GPL(typec_port_register_altmode); --=20 2.51.0.rc2.233.g662b1ed5c5-goog