From nobody Fri Oct 3 20:58:17 2025 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4A542D0616; Mon, 25 Aug 2025 09:15:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756113358; cv=none; b=NK/baH1WK2BeGf+BFdcl0/BFFDh7IAPwFcRr0+6O6eCJkomcxFNMg8L7rcXCAiUmxmmujiFVbk0gwolWL0/9ABnMlhzyCuAYOKZ8AZvOU1uXUeS4wt/52FXGGIoniIkDF6O0eIkZiL+YEyt7Wvf9qZmC72xZQzVdTjDbjKLsXz4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756113358; c=relaxed/simple; bh=CNNW8H+2jwpH7GuBz/IxBha2q6AgpHxi1qIELosPvSU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FKJ4HXmSTyV7jZ4zweCHOcAF1vmmrp5pQxzv+kUbfFLGUIxslRNv1t8ucw9uxNay4dUu5DkgFJ3fvnhSEOuf7NgCAdTMKDZErrn5j2Z7cdimonP07TYMP6SnKk1NZoo7qcqRlJYRP/8dzF3Gz21ypSYFBn1oihpkJMb9O68PwuU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FfM6ij7m; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FfM6ij7m" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2469e32f7c1so7801495ad.2; Mon, 25 Aug 2025 02:15:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756113356; x=1756718156; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V9HlGwGT0pLc+kAXQgdPzsVmtLcDrXDu6GbAvNPTmaE=; b=FfM6ij7mlWaHTiXhH9ACKwcMCx1Bldzy6n1APkX8NdFOKlsrMUUwPJr1XFFEBWItCa gqS3TnD7I+WNWaqQXan7YyqVdb9J8IFozSgRAyaTfQuWSpWGY2IS0Dd7Nlfp15ajwE+i II29cXO6L4YqpQIGCzru5/MQ7wRlcxq+jID3MkvFyYdFw1Sd5nmtvR3DAHa/oanideqh FTlbBOeaf6CoDtSStVuxdkmzKzDS2Se8m4joR5B2QfosGiz8gRZTqupCU4VCD50mXhlN AX2dGcY+ZderPNsLSOWRhjy9SXdnaoqoU4J1OaQ4kGCMSoJ10nSOOLD+wUjuJPb1IyEj OAcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756113356; x=1756718156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V9HlGwGT0pLc+kAXQgdPzsVmtLcDrXDu6GbAvNPTmaE=; b=Nhb/f3tguVi/76umL52ZE4Nq/uTglbnuoR+mX9rvnrGYz2HTET7py/HZQIEfcl/Phm C0k7W8uxAt6zOypLwAVze02H9k5yUmDvalU4pl/pMfH4TAsKz2gzF74WjzOAUjUKuDZ5 u4hxrF8J0SkG1n7h11KNkEzLC7SmL6VCnPrdPwhk83a37cgWwMpb8EaADyI7nJyui0Cj b33kNVhednye3cQ5lfd8yqeEPvHX+STgY7i/mHOYabOsGW/jPQOa3OgihHqMypq11cw9 qJX2GKDQEfwGTt8LmQhgjQVKdfLypws7GHEifT8Y37Rr/jF7OyuwGFdrLUDG/Ss5H11g q9JQ== X-Forwarded-Encrypted: i=1; AJvYcCVE7mTr/rYQDYsv3Vsqz7xT5q/aqmpYNF9SwsnR5jvi59BRygiII72ClIaUx7q9cMkqh4u4b+DiK0CD778=@vger.kernel.org, AJvYcCW9230s/eAu+47GI0CDddF/F6BdcEaUfoCDBvPukxOwj6CaBsawBalGj25LTGumBSSqAtKVmcKFNfohonSKvw==@vger.kernel.org X-Gm-Message-State: AOJu0YyPR5ZCm3mrEWyMOfna7odii26y291qEnhiwIo9D9i127L3Mh/9 d+kFUbKlWrk6OBAuKDPkoSGcuxu3hgLEvW6a2Cp8GHEC2hm+H51ZordKBgMP9v7DnKc= X-Gm-Gg: ASbGncvgKyDRHkyCizwyV1u2Q9B7eXL+svzD7myuZG9OW7OoxeSr5X16HjOoYj165cR ojincZWMULyG5X45dBQVkrB4VFDiD1LSKAfJ1NOiBR9lFectmSozIciwoLaD8jkOyrDEp+47uRL H/yfuzVN456fL9rCJh0gFDNbJIcHYK3x+kyjzToa5gMStBbxoRpiHoJm0LDq3BTU5AVBVdzmuMU ixREk2/TJ2i/33nnqyZb6LhtBRCR6o5D3w6Yojf12d/Xnp2xTcs/m0B2XaurI8SOqKmc2fR9E2h 0e3YteuI0iDKBbVwAXDUKsu4HP8Fq+12vuZe6gjgeMaZqgKg6vT/H0TC/DIY3Od8vF24GUm/4sb /i15wwrNWaiEV8jwDeqOXaucqddrLZmo53YIlo6/0yIZ2a0YpL3FU+OETuUdEluJ+p59groMbnu RBab5Q3NghtA== X-Google-Smtp-Source: AGHT+IHTkmLu/6zWl/V1gBMnBb8A3FYn+iQoodvtElUwS+H0DmmNzK5GohGgBbsY+0JWSNKI/Rc0yw== X-Received: by 2002:a17:903:22ce:b0:246:e885:46cf with SMTP id d9443c01a7336-246e8854977mr24568255ad.16.1756113355887; Mon, 25 Aug 2025 02:15:55 -0700 (PDT) Received: from localhost.localdomain ([114.242.33.243]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-246687b1525sm62792245ad.54.2025.08.25.02.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Aug 2025 02:15:55 -0700 (PDT) From: Jinchao Wang To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v2 1/4] module: signing: Use pr_err for signature rejection Date: Mon, 25 Aug 2025 17:15:32 +0800 Message-ID: <20250825091545.18607-2-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250825091545.18607-1-wangjinchao600@gmail.com> References: <20250825091545.18607-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make module signature rejection messages more visible by using pr_err instead of pr_notice. Signed-off-by: Jinchao Wang --- kernel/module/signing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/module/signing.c b/kernel/module/signing.c index a2ff4242e623..557cb795fa31 100644 --- a/kernel/module/signing.c +++ b/kernel/module/signing.c @@ -117,7 +117,7 @@ int module_sig_check(struct load_info *info, int flags) } =20 if (is_module_sig_enforced()) { - pr_notice("Loading of %s is rejected\n", reason); + pr_err("Loading of %s is rejected\n", reason); return -EKEYREJECTED; } =20 --=20 2.43.0 From nobody Fri Oct 3 20:58:17 2025 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 840902D0C72; Mon, 25 Aug 2025 09:15:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756113360; cv=none; b=D4AIusnI5kMYAd7e0psouo0j3uM3OzRUg3/10e7Sj2bVTFnBp8dh1dSaxG1QTeaeUdWnYO/S/r3U/X7JFLPXCLTzJmqiBgAQBMSUM+ud4PGmhPH9YF3/MVmrSiIZNP6e/dHeZHjVRNT6TvZ9AvoOpZwJV6TaVG5llG6C7isq6FA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756113360; c=relaxed/simple; bh=8jjYGS5PeFKcozsVZLXrvKIwWo7k8S7vhYJP/tMr/ss=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HaWEnaKspLNPh9wFaE6PJdsFMntJshudZWS8Wi0Gircm537o7LqEONbOOlq+qesMriu7BLkwPiyErUOGR2PCxfXX743Z6GFGgRGkNht8iziAs08DFZVK/iWR/cV4MKYZA/zR8ZqW3bndZYzqHCZgF6nT/cltn59atFJ4wboH+iE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Tnz870b+; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tnz870b+" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-24458272c00so47785505ad.3; Mon, 25 Aug 2025 02:15:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756113359; x=1756718159; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EAU8pFNlFHyGhl4ZEBlmiIHJhRLnwySKV8rZz4maxqE=; b=Tnz870b+4ZyUktpooIoWxXM/7kq5tPZ6G9y9wAx4tAQ4AepBYizP9RSyUTyn5Uw6zi SR5ygkLf9VzhtK+WP+P4UjwPNBJZHqd/JTrVJQ/x1wTUDMmTV5HcdybfkIG8nmhZwZJ9 2mb4mfvHv/BzJs54Q+kT4cAChIsTrOt+PN8X96QaH9yCDDar981M5blI/kDKaS2Pljn/ zknK5zrJ0Ex7HS630UxtS6sa/bEM/5m3FyjQytPfiQ/mQbZawj7spStoiJWLdnprMZud FZlxT11gwjnoDTm9qKa6YujUHv0hkXJaBEyqPF6+YvXdrhSyTfRV9yWOHbrpCPBEQC7Y Ai5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756113359; x=1756718159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EAU8pFNlFHyGhl4ZEBlmiIHJhRLnwySKV8rZz4maxqE=; b=fCLkQtedCiRrEApRyJD4SqOnRSdtK26g1U6G0h5h3Ki2vPLtlbz4MNsnsWoeIm2V2j B3NGeU4LRZ58ByFckJlCcZiEReCQ1zcfTYxHjEFM1pmMCFrbiw9wUGJxaVfF22xtdUmb Zzmu8rPZczF0Wmfu40c2/LZsuk8L5BdwjGIkmtiaxbQMSBoWyHjhk60liqEjsIDT9tDW ssVISVHIRXZbbIG7WkldrL3rR8i8LtVjpouWhyBY4wEK2pnYXBtd97diocnXrTZaDxcR GNfCPpvej/QOYeZi8irzHnsJEcKC9d5h2OhN50j5TzSBCxLmRzSsaSiHiJ527/pLSSEN Ojfw== X-Forwarded-Encrypted: i=1; AJvYcCUcm8vGXu86gO9hSZj3Vy+RgPvwBuAy8vJcMRuHmOlf9VD7OkI42GI18gJNEbGp57Fuwy6gAtt9u63E7Ig=@vger.kernel.org, AJvYcCV7anEzbckqjCCKiCx2X9UpWUsCh/yDwUTV5c58SfaMlBf2wRHMqqL8MlkoQYRLpPjwRRRDOIY9HlLGXuNb6g==@vger.kernel.org X-Gm-Message-State: AOJu0YyMcuLWABR5PLbtIN9FAIdpvNG4rgg98GjAqLmF09GTxnHE/YF3 8v+KtzXDopGh08Y2lR4dJQjlv2MwEk2dTiIGmNAQlNwD+Ru3FSnCYoHU X-Gm-Gg: ASbGnctB6YT8IXWtoaYDN1fBOOc41qsOWk69ypXmLJwtQp28SsECM05drJZUh9rDL5n XauYvphY+2dnnGyiRXJU1Xm7WPek+dqEYBVtlNm4l8tZBZYagZzS/jjUjN6vo210xQSMdnlCHww Z09rbNn9uu/2TlVi4K8lnB9lWCoLkKqtPj26iYSf9zX1zI3J8FG/rE0o252X3zc8rTex9O3HkEA kfYGoAvPz7sFiKwXypIphbuEhIjdoWF9akPPDM/SAanWxU8RvO2eAAQXdRa78/CDOB2HAUYa6IN rZWmDqDG/dMXhBTSz73EccIQK9tRYqi4gnKfUY+iiUDK8qE45f+U2RUqPPl83moZHeU4RV94jKY HF+S2eDFLAgHXzYDsxJUGpduI9ITT8ZZ1DBo/puMjC4FM34LQ/L1eClzdp9GFpaG5OLYhyBYKgv s= X-Google-Smtp-Source: AGHT+IEg7ykv7ujiyp9Mc0OjHNZy9+fuqP5eB4cL+6mJPmvrW2dGXYWnsywrHVst3J50rChKKyiemA== X-Received: by 2002:a17:902:f689:b0:246:d98e:64e with SMTP id d9443c01a7336-246d98e0aa8mr35280235ad.36.1756113358626; Mon, 25 Aug 2025 02:15:58 -0700 (PDT) Received: from localhost.localdomain ([114.242.33.243]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-246687b1525sm62792245ad.54.2025.08.25.02.15.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Aug 2025 02:15:58 -0700 (PDT) From: Jinchao Wang To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v2 2/4] module: show why force load fails Date: Mon, 25 Aug 2025 17:15:33 +0800 Message-ID: <20250825091545.18607-3-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250825091545.18607-1-wangjinchao600@gmail.com> References: <20250825091545.18607-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Include reason in error message when force loading is disabled. Signed-off-by: Jinchao Wang --- kernel/module/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/module/main.c b/kernel/module/main.c index c66b26184936..a426bd8a18b5 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -1083,6 +1083,7 @@ int try_to_force_load(struct module *mod, const char = *reason) add_taint_module(mod, TAINT_FORCED_MODULE, LOCKDEP_NOW_UNRELIABLE); return 0; #else + pr_err("%s force load is not supported\n", reason); return -ENOEXEC; #endif } --=20 2.43.0 From nobody Fri Oct 3 20:58:17 2025 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 574C62D131D; Mon, 25 Aug 2025 09:16:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756113363; cv=none; b=aYyZ63weycPrWnHsd0TK93KRV3RfMcIfn+ZGNPdqkBALwG8LOBEP+ZpaYtO3Vhb7OaJZHaJAGOvLRVLXvoCTconxAA6XdvbdIvssZ7Iyt3gVAxjnvgVcG9zpgG4JNn+UJrBh+nyGWkcO5tKaw78wS8a8AOJmPXNMo0V9bw3iP0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756113363; c=relaxed/simple; bh=WIZhDf7mzHY4XXBEi7WlI+/ym2i2jl+fPcoagVQ5+8o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r8fO+xkPGNUDNt9f+UnuGM4mob2ILKIbR9UOXFJDDrbGERa+yeDoHSOshpMraMCbZX+tEWDJIC6RhNoBjEbwpA0RI31n+Bny0sdIPslwDHZ776yHesDl4GFVL/VQUArJyVrwhoTCHdL7gV5HCesGV/EtoM8BU5sRXZbaCU7R0zQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jCx04K3o; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jCx04K3o" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-76e4fc419a9so3626378b3a.0; Mon, 25 Aug 2025 02:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756113361; x=1756718161; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7jM/+V6EEGOLi+0vxxWavU3+I5kcXvL1gGtdXlfilR8=; b=jCx04K3o/FgR67ckFFdLceGWv16tBsGkCuUVRwIWSg1GPPWqzNi/KdI5rdX4pTJX0x 5TPcmFEgzu+u2DpChDMgX7lPiNkSoVbc/ROW+irZmkqd/v06KOGizzWtbr9EL2d4sdpH yzV4P670h20EZmjc5FxHkXRPPWFaJGJXVMIDKVxnMuZ0kz6+aveXLm4g6iL71ScPOF2y Dpr9qNvbCb5yJbUWI3nH45LJ+aK8m6eu8t+c3kpTkdtQxYVfOSBNyYD3Rq3wKczRv4Bi Kw9A1OyPOgnL6NhO7KTii8Qlc+yQ8J3YzA9l3diQXddPKI3FLVLzexbQw9UTe2LVC0wp rygQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756113361; x=1756718161; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7jM/+V6EEGOLi+0vxxWavU3+I5kcXvL1gGtdXlfilR8=; b=w3sRXPhhte2Yr7rDzlTlOFAMo906pSThhkrGGTSz219L/zhM4DuAKoZpzWykt5Jjrx c1UaJGzxY32n9ksZVeRkW1JF9EkEQ7kSqrhJQO9dSZsGO028jTnrVbOXS3QJyJVUv67J 7AllNl56iYZsF3Dm8Ou6VBhAwoJBEuQFsWpXcUbBZPYXIloFthF6mrUecU26vgh2efU/ vtz8KIi6b5Zh3HrbBfVt05fYGwCdgex95joKn1vN9wXwPYoiGd7g1hYziKQul4cSuJrD ek89Gs750JEgU5ra0h7cHI6ZBaIhcFxX9e2amNHuNb+2jB90z6ot6hha5zEAiV2gL1R5 XolA== X-Forwarded-Encrypted: i=1; AJvYcCU5mLFq6KCgXuPzDFhVnq1ySoE0hzLSLFU8i8uUhuFU3XDwuY4k960l6bIBsPo6gTMlK00UnMDf3dHchO7rFA==@vger.kernel.org, AJvYcCXrVqFZ3aVvf0pLHc5r7/vosR1jAaPI92IgSBhvsJbqa63AzMw9G34XXfURTTH5+74Ma0tINo5iLla1L6M=@vger.kernel.org X-Gm-Message-State: AOJu0YwjAk4VRx0TDjuYcnl5ND6RRrBzsXeIs8l58fIGfRSoQiuQnH4F 498wf3ecuuth5jSwKqtx2hlYK2JxcekFbhyh3KyhbNrs1/YZYrcQ7BDb X-Gm-Gg: ASbGncsw8os8plwmYF65WnezldtSdxi2q1RFyz2fgWdXtyX5vefXDf69DpvxKTz38tZ mid0GBex3xgYLjGy5Pmapu9NdgMORpduFeoQNsvT03Bs0Ib/CwC+iWYWi6WEQsqR+rBJSlArD5U A/kXL7X4Wfpe+0iwXESs4ilVnLpDxIohizaGGrCKgCAvyZe19DmwLX7sD60m4oJgReUI9/dMgO4 CcFSJS5oHJIt6QX1Dez9Vf0EEQLgozKp5VLKhsHQqp8PzeGRP6YJAYpIMgAwbI2eDUheWFDUbGR o3qHCspRXvi7ND1nZcM3ocFnLoz4Pl2XVu2PYI2j7uC/PlfvFudjgF+4xtRPN9pyLK9CpbnI+6o XkSEOL9PV7iU73cHuL58ebuFxGTk+BfE7gIXsaZD2DUi8Xud8HSZo0sI74+1JrMqWm6+z4NmutP 8= X-Google-Smtp-Source: AGHT+IG+ZZidOrbvpreUm0ZWlnRxIEvBjsw1po70jKNNk3h0Gi9XZAQca/R+zcj5sbdtPNN0Qucotw== X-Received: by 2002:a17:902:db0e:b0:246:edc9:3a80 with SMTP id d9443c01a7336-246edc93d95mr15667165ad.5.1756113361540; Mon, 25 Aug 2025 02:16:01 -0700 (PDT) Received: from localhost.localdomain ([114.242.33.243]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-246687b1525sm62792245ad.54.2025.08.25.02.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Aug 2025 02:16:01 -0700 (PDT) From: Jinchao Wang To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v2 3/4] module: centralize no-versions force load check Date: Mon, 25 Aug 2025 17:15:34 +0800 Message-ID: <20250825091545.18607-4-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250825091545.18607-1-wangjinchao600@gmail.com> References: <20250825091545.18607-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move try_to_force_load() call from check_version() to check_modstruct_version() to handle "no versions" case only once before other version checks. This prevents duplicate force load attempts and makes the error message show the proper reason. Signed-off-by: Jinchao Wang --- kernel/module/version.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/kernel/module/version.c b/kernel/module/version.c index 2beefeba82d9..3f07fd03cb30 100644 --- a/kernel/module/version.c +++ b/kernel/module/version.c @@ -41,10 +41,6 @@ int check_version(const struct load_info *info, return 1; } =20 - /* No versions at all? modprobe --force does this. */ - if (versindex =3D=3D 0) - return try_to_force_load(mod, symname) =3D=3D 0; - versions =3D (void *)sechdrs[versindex].sh_addr; num_versions =3D sechdrs[versindex].sh_size / sizeof(struct modversion_info); @@ -81,6 +77,11 @@ int check_modstruct_version(const struct load_info *info, }; bool have_symbol; =20 + /* No versions at all? modprobe --force does this. */ + if (info->index.vers =3D=3D 0 && + try_to_force_load(mod, "no versions module")) + return 1; + /* * Since this should be found in kernel (which can't be removed), no * locking is necessary. Regardless use a RCU read section to keep --=20 2.43.0 From nobody Fri Oct 3 20:58:17 2025 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24C342D130A; Mon, 25 Aug 2025 09:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756113366; cv=none; b=b498WRHdO3mUHiWmJWojX1hrh2Tg+qKgeJi7JaHN9jCpE0zys8/umLg5I9KKHesex8mxc8tppVAuvRbST4T6NaWc31XpGjCP3N9Fx7BKW+PSuTWQyaKotWBqCAaRLymyLrijG69haxBv044sOuMFNH0msgvcIgxVjBFpKY7eiYo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756113366; c=relaxed/simple; bh=fS7tcc3pbTtPPamWit3eOd5Xqy7QnEiA95Q4HrebIfE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ab4pPEZzyv353XiTqgd9ZVk+v/2q4FahHZCUmZVL5dK1Rf01WSBVpZRxzeO1RMmftFpds7VDTaKlzh3IcZ7ibdNBFgsXzJBxQE7arvbXXjr0cohMT3lXjphiKG0MrX849CZlfpbSkLsdugdjpWB6dJO0EhBrM7vuvwec/xfoQzU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O9+VOXXS; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O9+VOXXS" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-b4c29d2ea05so88987a12.0; Mon, 25 Aug 2025 02:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756113364; x=1756718164; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X0BMKCDKNzT45IkwjHH8qIV9wptfqQdqs3ianpNZIF8=; b=O9+VOXXS9/gkYCBse5LYrNSwN4gtYLPeRG7hPkuAC58TulvcE+MtCeh1S90prvt6xj ZwjE+j1cQvwKZuW3jZ3JjA0d+Vxb7LsX4RnidehkeJl6PTWC1/OnA37KlWp93kDfCltE uHc0IZ4zDsqWVqIAEZA8EHBQWUKjtEm3yNN6bHCR5Xt0M9b5BZwQrMXA56Ri39r5rZkf 1q3wl/bxr/S2C/ic3RN01s/KFq6+bV5tuq79Nq4nT5ApmfeDh7yrISGPVB9lNeCVfdZP MPwMgcrLheo7f/Joj/7hsjWmjdptnb7M6/MT4/5QyDI9wrKwmuOqx937gRp1YeH3sU0h uuvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756113364; x=1756718164; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X0BMKCDKNzT45IkwjHH8qIV9wptfqQdqs3ianpNZIF8=; b=Dn6Kwt1EFsK7tF4aT7fSmbejsBPQBiCCl/6Vr6F+2jl75NDg1pmUTNlG2e7lXUaexZ XcIZro1GfXBA1cibVAf1oAFFru4/vXuJBt12IBbdn+tmU87hsAfLoOU7ETwxSUYv6v5e 78OulvX/zmFhLGe3ogTYvp5jpM/2e4eZEb1d4GM0Ekbt4DS580k6W8CuwfMPQTROaX+Y Bwt8wc2aI8ixdDvuRZuzwUbhdyf3mfLzncXqG87bkOAWLQQDP9/gH3jI5K5EM0gyVmrX ZHxRfnMKWymJ/O+uUOwt1qTNi/SC9TjnauzmyxI29027LzKBJSOu48jKuDGJEFD8qquO dglg== X-Forwarded-Encrypted: i=1; AJvYcCVbvWNQJyC4Jb/5eCZcD1Pn2d0nVyqK949asjeVPa6s0PVeK0z1g7HXBxy29pxvk9jOU/uqUxuPn2AwTC4=@vger.kernel.org, AJvYcCWXsIoRp3/HJPS2m+x2A4DZv34SJ1fcjdJMdrUe2dkJUfEUCLGKkkew4wRhjxghL8+SpaYRusb2KlFM6zRiGQ==@vger.kernel.org X-Gm-Message-State: AOJu0YxgpJ0yvPnl7GzcwTCCHbSd+4k1//2fL3ck9uWnutjgehXVj9ne 5yHs3mIWNBh5lvcfF543upkIeiOKccQGs5V1olSagwYrPLhtfjNb+JiO X-Gm-Gg: ASbGncvNbZ+W8YfAQhGmiTF6V0razPBz/InLsu8RnbEemLGpoPYglgEhBhVPMAxASVs 5liDEpHik1XDIyL3t2E1q4TWay8VX+eTOrX1N4oBmFU+ypd803oqFvq63rpr44TwhS7LMqorPdQ ZN6GbMLnA4lV/lxpRREyHw98MxfwEonyVWCtnk1OOZH3zHi8PQtjALlrKe05fjILzF/rf8vbads JsnAiH0rOskjLGjUS7lZia8qtzubOKDQqp/GZ9wrijFNsW9nzFk5ekgTPyDR34b67+/tvulqxib 0V2rBn+CUpN85PB/etw6O0KiiTutcLMtuSjy8NnlptMXl7UetyB0hZYIPY07Qev5zkN0uYVAH/a Lwnd0MDvctNMQRCHDiiz63Wyke+JYCENvRqVJho4LmaavHvSvTmbkn28eSov1afOrnAS0lAeOCC M= X-Google-Smtp-Source: AGHT+IFiMVR6n5YCwf3x1l6BkQWj7LzzSrKOIaeNlshr8fQWRjk2TwLMdhbhLrPE9XefhDQGzaEqHA== X-Received: by 2002:a17:902:cf09:b0:231:9817:6ec1 with SMTP id d9443c01a7336-24632a36020mr137426105ad.17.1756113364450; Mon, 25 Aug 2025 02:16:04 -0700 (PDT) Received: from localhost.localdomain ([114.242.33.243]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-246687b1525sm62792245ad.54.2025.08.25.02.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Aug 2025 02:16:04 -0700 (PDT) From: Jinchao Wang To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v2 4/4] module: separate vermagic and livepatch checks Date: Mon, 25 Aug 2025 17:15:35 +0800 Message-ID: <20250825091545.18607-5-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250825091545.18607-1-wangjinchao600@gmail.com> References: <20250825091545.18607-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename check_modinfo() to check_modinfo_vermagic() to clarify it only checks vermagic compatibility. Move livepatch check to happen after vermagic check in early_mod_check(), creating proper separation of concerns. This makes the module loading sequence more logical: - First verify module vermagic - Then check livepatch-specific requirements No functional changes, just clearer code organization. Signed-off-by: Jinchao Wang --- kernel/module/main.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/module/main.c b/kernel/module/main.c index a426bd8a18b5..d30bffeef63e 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -2571,7 +2571,7 @@ static void module_augment_kernel_taints(struct modul= e *mod, struct load_info *i =20 } =20 -static int check_modinfo(struct module *mod, struct load_info *info, int f= lags) +static int check_modinfo_vermagic(struct module *mod, struct load_info *in= fo, int flags) { const char *modmagic =3D get_modinfo(info, "vermagic"); int err; @@ -2590,10 +2590,6 @@ static int check_modinfo(struct module *mod, struct = load_info *info, int flags) return -ENOEXEC; } =20 - err =3D check_modinfo_livepatch(mod, info); - if (err) - return err; - return 0; } =20 @@ -3334,7 +3330,11 @@ static int early_mod_check(struct load_info *info, i= nt flags) if (!check_modstruct_version(info, info->mod)) return -ENOEXEC; =20 - err =3D check_modinfo(info->mod, info, flags); + err =3D check_modinfo_vermagic(info->mod, info, flags); + if (err) + return err; + + err =3D check_modinfo_livepatch(info->mod, info); if (err) return err; =20 --=20 2.43.0