From nobody Fri Oct 3 21:41:51 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.5]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B2BD928F1; Mon, 25 Aug 2025 02:20:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756088452; cv=none; b=gkjO3oJ0+9st9L/HXifiAmWagBkGRs5G6lU7CfWV3ce6G/zGpyFAflfB2rasufIwvkVIjOsjTdEVgCM7SA7EC4pUvYfI1DhgXPOTfrCMYJ6AbEMMNICWG7O4lqeYw1VE3MDYV1Xd4SUBSzwc8nQSYkgD9PQrkNnnqVJJbJt/kUY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756088452; c=relaxed/simple; bh=Bbcu1m0flpjmK26MgmyjM+c786Kfvt2oVaIP44MAlQM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VAfCEa7+HUbTXhLGsvx5Fz98PUGtEzZGoO9Mrr3DHYF2Fs6GxT0kkVM427pIOihVGg9xZspLjoc2yxyZExuPkBNXoIl/m7s0HpRgzarKdc+SPw0hrahf2A62MM7ymIlDYq1c3DD+nDH6/J4s6JPtvtJr+pwg9Jp1zbOAeMEyMGM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=WCZDmgt2; arc=none smtp.client-ip=220.197.31.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="WCZDmgt2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=2d 9W8qmudwvDnN1OXDiZN8AeTof1uFS9/qSDeSl+dRw=; b=WCZDmgt2rDFa4baE8f RERtyiO6wUZyxyMc3OCH87qStPfNdvgzgKl4Ah9R9msWGeN6xoJb7DOlRzsTB12V euia410FxW4/BMlBL6o8D3tDK0izXXpOBou9Lib0ykxT8iBN13D9alJf1IpbXBVw MV9O8ntD1Yq+dmhnHb+33pMCc= Received: from 163.com (unknown []) by gzsmtp5 (Coremail) with SMTP id QCgvCgCnA_ZUyKto6PbuAQ--.6728S3; Mon, 25 Aug 2025 10:20:10 +0800 (CST) From: chenyuan_fl@163.com To: olsajiri@gmail.com Cc: aef2617b-ce03-4830-96a7-39df0c93aaad@kernel.org, andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, chenyuan@kylinos.cn, chenyuan_fl@163.com, daniel@iogearbox.net, linux-kernel@vger.kernel.org, qmo@kernel.org, yonghong.song@linux.dev Subject: [PATCH v7 1/2] bpftool: Refactor kernel config reading into common helper Date: Mon, 25 Aug 2025 03:20:01 +0100 Message-Id: <20250825022002.13760-2-chenyuan_fl@163.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250825022002.13760-1-chenyuan_fl@163.com> References: <20250825022002.13760-1-chenyuan_fl@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: QCgvCgCnA_ZUyKto6PbuAQ--.6728S3 X-Coremail-Antispam: 1Uf129KBjvJXoW3Jw1xCF43GF48JF1UJr15CFg_yoW3Jr43pF Z5Ga45Jry8XF1fuw4xtFs5CrWrGwn7J3yUKrZrW3yrZrnFyryqva18KFnaqFy3ZrWvgr17 ZrZY9Fyq9w4UXr7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0z_6wZUUUUUU= X-CM-SenderInfo: xfkh05pxdqswro6rljoofrz/xtbBSR20vWirwXq4lwAAsK Content-Type: text/plain; charset="utf-8" From: Yuan Chen Extract the kernel configuration file parsing logic from feature.c into a new read_kernel_config() function in common.c. This includes: 1. Moving the config file handling and option parsing code 2. Adding required headers and struct definition 3. Keeping all existing functionality The refactoring enables sharing this logic with other components while maintaining current behavior. This will be used by subsequent patches that need to check kernel config options. Signed-off-by: Yuan Chen Acked-by: Yonghong Song --- tools/bpf/bpftool/common.c | 93 +++++++++++++++++++++++++++++++++++++ tools/bpf/bpftool/feature.c | 86 ++-------------------------------- tools/bpf/bpftool/main.h | 9 ++++ 3 files changed, 106 insertions(+), 82 deletions(-) diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c index b07317d2842f..e8daf963ecef 100644 --- a/tools/bpf/bpftool/common.c +++ b/tools/bpf/bpftool/common.c @@ -21,6 +21,7 @@ #include #include #include +#include =20 #include #include @@ -31,6 +32,7 @@ #include #include /* libbpf_num_possible_cpus */ #include +#include =20 #include "main.h" =20 @@ -1208,3 +1210,94 @@ int pathname_concat(char *buf, int buf_sz, const cha= r *path, =20 return 0; } + +static bool read_next_kernel_config_option(gzFile file, char *buf, size_t = n, + char **value) +{ + char *sep; + + while (gzgets(file, buf, n)) { + if (strncmp(buf, "CONFIG_", 7)) + continue; + + sep =3D strchr(buf, '=3D'); + if (!sep) + continue; + + /* Trim ending '\n' */ + buf[strlen(buf) - 1] =3D '\0'; + + /* Split on '=3D' and ensure that a value is present. */ + *sep =3D '\0'; + if (!sep[1]) + continue; + + *value =3D sep + 1; + return true; + } + + return false; +} + +int read_kernel_config(const struct kernel_config_option *requested_option= s, + size_t num_options, char **out_values, + const char *define_prefix) +{ + struct utsname utsn; + char path[PATH_MAX]; + gzFile file =3D NULL; + char buf[4096]; + char *value; + size_t i; + int ret =3D 0; + + if (!requested_options || !out_values || num_options =3D=3D 0) + return -1; + + if (!uname(&utsn)) { + snprintf(path, sizeof(path), "/boot/config-%s", utsn.release); + + /* gzopen also accepts uncompressed files. */ + file =3D gzopen(path, "r"); + } + + if (!file) { + /* Some distributions build with CONFIG_IKCONFIG=3Dy and put the + * config file at /proc/config.gz. + */ + file =3D gzopen("/proc/config.gz", "r"); + } + + if (!file) { + p_info("skipping kernel config, can't open file: %s", + strerror(errno)); + return -1; + } + + if (!gzgets(file, buf, sizeof(buf)) || !gzgets(file, buf, sizeof(buf))) { + p_info("skipping kernel config, can't read from file: %s", + strerror(errno)); + ret =3D -1; + goto end_parse; + } + + if (strcmp(buf, "# Automatically generated file; DO NOT EDIT.\n")) { + p_info("skipping kernel config, can't find correct file"); + ret =3D -1; + goto end_parse; + } + + while (read_next_kernel_config_option(file, buf, sizeof(buf), &value)) { + for (i =3D 0; i < num_options; i++) { + if ((define_prefix && !requested_options[i].macro_dump) || + out_values[i] || strcmp(buf, requested_options[i].name)) + continue; + + out_values[i] =3D strdup(value); + } + } + +end_parse: + gzclose(file); + return ret; +} diff --git a/tools/bpf/bpftool/feature.c b/tools/bpf/bpftool/feature.c index 24fecdf8e430..0f6070a0c8e7 100644 --- a/tools/bpf/bpftool/feature.c +++ b/tools/bpf/bpftool/feature.c @@ -10,7 +10,6 @@ #ifdef USE_LIBCAP #include #endif -#include #include =20 #include @@ -18,7 +17,6 @@ =20 #include #include -#include =20 #include "main.h" =20 @@ -327,40 +325,9 @@ static void probe_jit_limit(void) } } =20 -static bool read_next_kernel_config_option(gzFile file, char *buf, size_t = n, - char **value) -{ - char *sep; - - while (gzgets(file, buf, n)) { - if (strncmp(buf, "CONFIG_", 7)) - continue; - - sep =3D strchr(buf, '=3D'); - if (!sep) - continue; - - /* Trim ending '\n' */ - buf[strlen(buf) - 1] =3D '\0'; - - /* Split on '=3D' and ensure that a value is present. */ - *sep =3D '\0'; - if (!sep[1]) - continue; - - *value =3D sep + 1; - return true; - } - - return false; -} - static void probe_kernel_image_config(const char *define_prefix) { - static const struct { - const char * const name; - bool macro_dump; - } options[] =3D { + struct kernel_config_option options[] =3D { /* Enable BPF */ { "CONFIG_BPF", }, /* Enable bpf() syscall */ @@ -435,52 +402,11 @@ static void probe_kernel_image_config(const char *def= ine_prefix) { "CONFIG_HZ", true, } }; char *values[ARRAY_SIZE(options)] =3D { }; - struct utsname utsn; - char path[PATH_MAX]; - gzFile file =3D NULL; - char buf[4096]; - char *value; size_t i; =20 - if (!uname(&utsn)) { - snprintf(path, sizeof(path), "/boot/config-%s", utsn.release); - - /* gzopen also accepts uncompressed files. */ - file =3D gzopen(path, "r"); - } - - if (!file) { - /* Some distributions build with CONFIG_IKCONFIG=3Dy and put the - * config file at /proc/config.gz. - */ - file =3D gzopen("/proc/config.gz", "r"); - } - if (!file) { - p_info("skipping kernel config, can't open file: %s", - strerror(errno)); - goto end_parse; - } - /* Sanity checks */ - if (!gzgets(file, buf, sizeof(buf)) || - !gzgets(file, buf, sizeof(buf))) { - p_info("skipping kernel config, can't read from file: %s", - strerror(errno)); - goto end_parse; - } - if (strcmp(buf, "# Automatically generated file; DO NOT EDIT.\n")) { - p_info("skipping kernel config, can't find correct file"); - goto end_parse; - } - - while (read_next_kernel_config_option(file, buf, sizeof(buf), &value)) { - for (i =3D 0; i < ARRAY_SIZE(options); i++) { - if ((define_prefix && !options[i].macro_dump) || - values[i] || strcmp(buf, options[i].name)) - continue; - - values[i] =3D strdup(value); - } - } + if (read_kernel_config(options, ARRAY_SIZE(options), values, + define_prefix)) + return; =20 for (i =3D 0; i < ARRAY_SIZE(options); i++) { if (define_prefix && !options[i].macro_dump) @@ -488,10 +414,6 @@ static void probe_kernel_image_config(const char *defi= ne_prefix) print_kernel_option(options[i].name, values[i], define_prefix); free(values[i]); } - -end_parse: - if (file) - gzclose(file); } =20 static bool probe_bpf_syscall(const char *define_prefix) diff --git a/tools/bpf/bpftool/main.h b/tools/bpf/bpftool/main.h index a2bb0714b3d6..374cac2a8c66 100644 --- a/tools/bpf/bpftool/main.h +++ b/tools/bpf/bpftool/main.h @@ -275,4 +275,13 @@ int pathname_concat(char *buf, int buf_sz, const char = *path, /* print netfilter bpf_link info */ void netfilter_dump_plain(const struct bpf_link_info *info); void netfilter_dump_json(const struct bpf_link_info *info, json_writer_t *= wtr); + +struct kernel_config_option { + const char *name; + bool macro_dump; +}; + +int read_kernel_config(const struct kernel_config_option *requested_option= s, + size_t num_options, char **out_values, + const char *define_prefix); #endif --=20 2.39.5