From nobody Fri Oct 3 21:53:31 2025 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBA1D2620D2 for ; Sun, 24 Aug 2025 09:58:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756029522; cv=none; b=Xp5dae8/w0kkDWZSn86FICBU7LubVRKMlCrgSHt6OINNcVucbsqvZynSxnGQ4TpYk54lZ2ctV4Syw9kSVxBDo58zM18Ba2F+8QLDG91gSnGgpWG5hFGCpEgyFPBSuTvVtB5RfHZg4ZllouQP37QOtZ4vQNVK7BP2VH/ZfxUrCFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756029522; c=relaxed/simple; bh=9vKO6y/q0kB3TamnCzON4DvVOC9PmEnOciXyI0pj7zk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KKxiC7EUTmIAG5u9xIISscChifxtdOlNXZTwLDeSidyHFzEJNQ12BxacGMZPDZ/Q8mqbP4NPUkX61HHhpfX69AEDRgxGhxAkXdoVnrNoynoIzrhaZeFuby9WXXsrK+hObWoGpA2X4TDCZS4QdTqgUfHdk0k319RUMHHSAupeTj4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fGPTsY3+; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fGPTsY3+" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-afcb7af30a5so590226666b.3 for ; Sun, 24 Aug 2025 02:58:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756029518; x=1756634318; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wZKX5iGNtzUg18kwP/R5sStYV/khRElhDeGAve6BvqI=; b=fGPTsY3+fgbb5xXBpUxjgv1975XRrVRrniblek+Ly5smK42gac4y7QYzhyYyJSQTgS uZTrt3m5Ao50liRGhnRTDfx6JFnCkFr4aua81+MBgTz9DBOOVgg3KTNRApeINFUKxBAZ 6Q6tNhhD5+l5xKiznaXSDhoW0DwfJzwIfFrulYie+LQOhHKsoS8rghQP2bMZUMTI3PPz e/ZZJqRKLcx6yUrUQDDxwXIe6KsNn+E1OzK4CV5vDUzQB1/6+rsXbo7OJ+0Ieua6kIxz 6QIHgaqgL7y9PBk1x2mHc6OIMBZTc+/3UcLdXyxMTnQssdwfUHQsgR4A/6Rw2DnHAENq xaeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756029518; x=1756634318; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wZKX5iGNtzUg18kwP/R5sStYV/khRElhDeGAve6BvqI=; b=gREbC6lhL+dUhk9U9TNqViA057nVwZcWEeplRLaJrksxncrHKxEm39YZRvNl0ueGwq EloHn89t3q4fNimurvNrS5MSOYY+hxmWTgu9OQelPJ6B0Dq9S11advFROzcrV9Yamvud gXJEaQ+PjvKpS1iTLQVIM4ur7OF0/Lpsdomn1t5zTuB6zzVLEcQmYS0A6XnKwd/abXlj uBhjS+js3cMytx2fSlKiz3WsvBlSC7f5eMzYKkoF404AV9J1GK/2oc3DoyimS5kpND+1 M4LTPvPxqEp6sjRTC8M70eC69dpbCPOmXR+46IUtOIc7X4Vk1XzlVgnfAqWdmklQmVG0 tjdA== X-Forwarded-Encrypted: i=1; AJvYcCXblzxcSJfprr8MUT8Nfa4+/0uXNN8awbOeDfbGLhar5bRpRXcVA+E8O0TZNSJrasbtyjD1GeSF2YYiT30=@vger.kernel.org X-Gm-Message-State: AOJu0YwaRT7+toHrOQcrARJBVA/CsttXFNvuTmVbyOFbsFcvczSh9FNK cz6r0Nv/yNp2vIQqigJI9r+TY6BT1Xv1bttRVEiUnZvr1XhUbFQGPyd5 X-Gm-Gg: ASbGncv/T71qu6y8M0hJNl7x4WecB8bb9vY00GKyXNpsz2gT1eWJZ2+qaMgzyJYI2O5 ea8qo+zTcHygHhdnfDOlQ02NOQmzBkBkh5hm5vgE9nDG6i77n0OBRk6r5ZsKW7v1TZbQyv3pTph ZqCQglhXrzo7K4qJl3pMRXvKVl1YHk8tNXIQwLT5pDiQCetVeipS2Rxqrl4x4xo9qG+kkDvOXsp N7kznPdLJ01zvcFn/i4YrXATl+0Loq1NnFallhqdnuncpx5UY7UHV2aNC5hUtfGkMvwDpMwbJvC vcSN5jYuzdGTS8/45NsO/ZAfWJTd6A9RcNPdoVb97MuXp7hoqCgB3u4KGomTOHaibN38mo2EOAn x5CqWYUe02nsL+CKHIWEkO2uEZw== X-Google-Smtp-Source: AGHT+IElT045z23ULaqJLlbU6nriQbkGsElcteR0wlVYWXnPAJOezIwza8EGMC5PaY11b8LoP6Xbhg== X-Received: by 2002:a17:907:6d27:b0:afd:d9e4:5a4b with SMTP id a640c23a62f3a-afe296bce93mr854042666b.63.1756029517762; Sun, 24 Aug 2025 02:58:37 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe79fba62dsm41314766b.100.2025.08.24.02.58.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Aug 2025 02:58:37 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 1/4] staging: rtl8723bs: remove wrapper Efuse_PowerSwitch Date: Sun, 24 Aug 2025 11:58:27 +0200 Message-ID: <20250824095830.79233-2-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250824095830.79233-1-straube.linux@gmail.com> References: <20250824095830.79233-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function Efuse_PowerSwitch is just a wrapper around Hal_EfusePowerSwitch. Remove the wrapper and use Hal_EfusePowerSwitch directly. Signed-off-by: Michael Straube Tested-by: Philipp Hortmann # Trendbook Next= 14 --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 31 ++----------------- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 +-- drivers/staging/rtl8723bs/include/rtw_efuse.h | 2 -- 3 files changed, 4 insertions(+), 33 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/r= tl8723bs/core/rtw_efuse.c index e39032b45c35..f0c705ccdbdc 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -29,33 +29,6 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] =3D {0}; #define REG_EFUSE_CTRL 0x0030 #define EFUSE_CTRL REG_EFUSE_CTRL /* E-Fuse Control. */ =20 -/*------------------------------------------------------------------------= ----- - * Function: Efuse_PowerSwitch - * - * Overview: When we want to enable write operation, we should change to - * pwr on state. When we stop write, we should switch to 500k mode - * and disable LDO 2.5V. - * - * Input: NONE - * - * Output: NONE - * - * Return: NONE - * - * Revised History: - * When Who Remark - * 11/17/2008 MHC Create Version 0. - * - */ -void -Efuse_PowerSwitch( -struct adapter *padapter, -u8 bWrite, -u8 PwrState) -{ - Hal_EfusePowerSwitch(padapter, bWrite, PwrState); -} - /* 11/16/2008 MH Add description. Get current efuse area enabled word!!. = */ u8 Efuse_CalculateWordCnts(u8 word_en) @@ -191,13 +164,13 @@ static void Efuse_ReadAllMap(struct adapter *padapter= , u8 efuseType, u8 *Efuse) { u16 mapLen =3D 0; =20 - Efuse_PowerSwitch(padapter, false, true); + Hal_EfusePowerSwitch(padapter, false, true); =20 Hal_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *)&= mapLen); =20 Hal_ReadEFuse(padapter, efuseType, 0, mapLen, Efuse); =20 - Efuse_PowerSwitch(padapter, false, false); + Hal_EfusePowerSwitch(padapter, false, false); } =20 /*------------------------------------------------------------------------= ----- diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 94492743ea34..66ba3bcd22e4 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -1474,9 +1474,9 @@ void Hal_EfuseParsePackageType_8723B( u8 package; u8 efuseContent; =20 - Efuse_PowerSwitch(padapter, false, true); + Hal_EfusePowerSwitch(padapter, false, true); efuse_OneByteRead(padapter, 0x1FB, &efuseContent); - Efuse_PowerSwitch(padapter, false, false); + Hal_EfusePowerSwitch(padapter, false, false); =20 package =3D efuseContent & 0x7; switch (package) { diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/stagin= g/rtl8723bs/include/rtw_efuse.h index 5251ecc855d7..904369705ed7 100644 --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h @@ -93,8 +93,6 @@ extern u8 fakeBTEfuseModifiedMap[]; u8 Efuse_CalculateWordCnts(u8 word_en); u8 efuse_OneByteRead(struct adapter *padapter, u16 addr, u8 *data); =20 -void Efuse_PowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState); - u8 EFUSE_Read1Byte(struct adapter *padapter, u16 Address); void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType); void EFUSE_ShadowRead(struct adapter *padapter, u8 Type, u16 Offset, u32 *= Value); --=20 2.51.0 From nobody Fri Oct 3 21:53:31 2025 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B2B82641FC for ; Sun, 24 Aug 2025 09:58:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756029522; cv=none; b=NFK3aBibTVyAgYJFQks2rr2V0KHWs9ojK89lT2Jfah0JZlByq7P6/A6geC2ndshCQuIzJkyPTUPKTUC6cOUz7y7eYZxbiAK3GVtWGYgGStb8ojayiIbczOddRfKyNctCwYkvfbg7nm1+FbdfZNGQmmL/E7MNRx8MeAzO68Ai47c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756029522; c=relaxed/simple; bh=ldbo9YYAOT7pxAUaEDrlbL+4YuIsDyCnu0vvNTDKWvc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ajIT9Z8jLnYA4zxA4Y8R0V0+z7CWuEwrFkjpj9ZGf1lVUQmH8PpUz5ImM5g/poZtoHDYszw9dh0rHU66qibOiDv6I1HXxTJ5kMxRlQ2uJw64a9ntJ9cnVJVbbVBiprua89yFl3AQGa845i5EyH6ii9Y5sX8XhcL95Co04VoaoWQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XxZx7ypw; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XxZx7ypw" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-afcb7a7bad8so472301466b.3 for ; Sun, 24 Aug 2025 02:58:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756029518; x=1756634318; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1fGiG7/VSnTA1owBp74Wd5IB4bdDfmXxntCUjoYB1M8=; b=XxZx7ypweAJtSUoAuLKDCklawUhlrPfk14GlW0BlKF2pF2kR+urI/fcuqY5dlNBuoZ XiozCleb7KsgFFBC7qaf8Vs3gTCXM3SIoPzezzLqzwobEhJL3N9Z9Fz7HMwfbom5BD3s wfqU5VFEyBaD18e+jTnzKmlWYtCT8h+7lS5pLe0Ytqhe+0HcRLai8za4X+J1WJeU29J0 qGgU1/tGgzYPf8Gwznzxme76xQtQtAiWR4UyTZiPE8EW0hV1jEGnuJrSy2UTb4dORh0C LVcnn8xi/ix53xdgTT+skhl8+TZ3iPQW9axzbObSjjFbyDmsUo6NIEoVjSBbPXtqrC36 eW5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756029518; x=1756634318; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1fGiG7/VSnTA1owBp74Wd5IB4bdDfmXxntCUjoYB1M8=; b=LY72VrgC+rwGxEzA0Y/walpLksd9qVWFYo+FHK2ujXeL4yYQaxhWfmPJVPBNanyULh W5UCxp/Qxsk82dlNlfCLfjcsofSad/rti7diXnXRp7+qSs90efbQeMWd86H5ER85Wg4Q 1XFjYm3ZaoAM+C1tST91H5zwt0sGoJi7wVLUro7cdz8QeduezRCAequUYmKIuZmtZ/o2 /3KmwSfvduZJBaERwFj8NPI6qnSnUl5Oia4GxaArUAtZ1zfB0f67bn0xtNyF7uuiTuDG 8/trqzmFEPpPNvAlytNat8FDP+/r2rA7NkSMVsPMShkpXuRsP+ERCfzuDi2/iPpx0/zR x1lg== X-Forwarded-Encrypted: i=1; AJvYcCUoHrbcn1cXoA2tYu0aYk9LhE47gxihkWoy+E0rjeCcom8jRn+d1GzjlS7w1d8vepMszufhF0NBHfFfS50=@vger.kernel.org X-Gm-Message-State: AOJu0YyVIYetqikLx5mFkuQvrrRw65H3C/LRwrTCBDGTt3BCgGf9x3fJ b5Vg88SH2fYWrz9KNjTKypo6iNLT0t1PlT9l5tKb5BzKDUgTRp0bl/CK X-Gm-Gg: ASbGnct2CateZ77fvFVNf4cxvcF3nSS4/PK3ZFdYrsfEmL6RGxTy85PQpkugth2dfZ0 E8K/EjTO2G1xstTbt8rrr7tGMcj3fsZxJIAPG1F1RJn1kDQ2Zdq37C2s1DYzBDVbNqVOPtezuXu b7Nrpng+Ng9Udi8syEVN4hBvpRJomz5wSnDnKjodwOQjYu0siNb0i0vz3pTHx60aRvz6d2YjU7Z X9baW4Wz62YVzleyTXBd1kA28iPLVWSxVodqvSVfftorKr3cuZjT2zNQnCpPKLhkYLcEgWxnSEx +AGzu18qkN/ZcAOk6jwjV8kT8yvxL1UK8ElUSBof7n0oIho0/m0rUahvlkGZYV2KjDU6ntuX51G B0/fNCFAy1K7HvtlNGGrkJlLJug== X-Google-Smtp-Source: AGHT+IEChKPlkeYc+u70DNblLlkC7GNSA1YYbKn+4HtbpIDoAJGxZs5hUdLvvGsztjC+LEpHLFdh4A== X-Received: by 2002:a17:907:80c:b0:afd:d94b:830e with SMTP id a640c23a62f3a-afe29513a3amr629745866b.63.1756029518387; Sun, 24 Aug 2025 02:58:38 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe79fba62dsm41314766b.100.2025.08.24.02.58.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Aug 2025 02:58:38 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 2/4] staging: rtl8723bs: remove bWrite from Hal_EfusePowerSwitch Date: Sun, 24 Aug 2025 11:58:28 +0200 Message-ID: <20250824095830.79233-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250824095830.79233-1-straube.linux@gmail.com> References: <20250824095830.79233-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function Hal_EfusePowerSwitch is always called with bWrite set to false. Remove the pWrite parameter and reomve resulting dead code to reduce code complexity. Signed-off-by: Michael Straube Tested-by: Philipp Hortmann # Trendbook Next= 14 --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 +-- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 25 +++---------------- drivers/staging/rtl8723bs/include/hal_intf.h | 2 +- 3 files changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/r= tl8723bs/core/rtw_efuse.c index f0c705ccdbdc..d5c53b614f61 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -164,13 +164,13 @@ static void Efuse_ReadAllMap(struct adapter *padapter= , u8 efuseType, u8 *Efuse) { u16 mapLen =3D 0; =20 - Hal_EfusePowerSwitch(padapter, false, true); + Hal_EfusePowerSwitch(padapter, true); =20 Hal_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *)&= mapLen); =20 Hal_ReadEFuse(padapter, efuseType, 0, mapLen, Efuse); =20 - Hal_EfusePowerSwitch(padapter, false, false); + Hal_EfusePowerSwitch(padapter, false); } =20 /*------------------------------------------------------------------------= ----- diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 66ba3bcd22e4..36680ecb5897 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -568,8 +568,6 @@ void Hal_GetEfuseDefinition( } } =20 -#define VOLTAGE_V25 0x03 - /* */ /* The following is for compile ok */ /* That should be merged with the original in the future */ @@ -578,7 +576,7 @@ void Hal_GetEfuseDefinition( #define REG_EFUSE_ACCESS_8723 0x00CF /* Efuse access protection for RTL= 8723 */ =20 void Hal_EfusePowerSwitch( - struct adapter *padapter, u8 bWrite, u8 PwrState + struct adapter *padapter, u8 PwrState ) { u8 tempval; @@ -626,25 +624,8 @@ void Hal_EfusePowerSwitch( tmpV16 |=3D (LOADER_CLK_EN | ANA8M); rtw_write16(padapter, REG_SYS_CLKR, tmpV16); } - - if (bWrite) { - /* Enable LDO 2.5V before read/write action */ - tempval =3D rtw_read8(padapter, EFUSE_TEST+3); - tempval &=3D 0x0F; - tempval |=3D (VOLTAGE_V25 << 4); - rtw_write8(padapter, EFUSE_TEST+3, (tempval | 0x80)); - - /* rtw_write8(padapter, REG_EFUSE_ACCESS, EFUSE_ACCESS_ON); */ - } } else { rtw_write8(padapter, REG_EFUSE_ACCESS, EFUSE_ACCESS_OFF); - - if (bWrite) { - /* Disable LDO 2.5V after read/write action */ - tempval =3D rtw_read8(padapter, EFUSE_TEST+3); - rtw_write8(padapter, EFUSE_TEST+3, (tempval & 0x7F)); - } - } } =20 @@ -1474,9 +1455,9 @@ void Hal_EfuseParsePackageType_8723B( u8 package; u8 efuseContent; =20 - Hal_EfusePowerSwitch(padapter, false, true); + Hal_EfusePowerSwitch(padapter, true); efuse_OneByteRead(padapter, 0x1FB, &efuseContent); - Hal_EfusePowerSwitch(padapter, false, false); + Hal_EfusePowerSwitch(padapter, false); =20 package =3D efuseContent & 0x7; switch (package) { diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index 4fe48cccb889..2fa2382ad5f3 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -265,7 +265,7 @@ u8 GetHalDefVar8723BSDIO(struct adapter *Adapter, enum = hal_def_variable eVariabl u8 SetHalDefVar8723BSDIO(struct adapter *Adapter, enum hal_def_variable eV= ariable, void *pValue); void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_le= vel); void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter); -void Hal_EfusePowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState= ); +void Hal_EfusePowerSwitch(struct adapter *padapter, u8 PwrState); void Hal_ReadEFuse(struct adapter *padapter, u8 efuseType, u16 _offset, u16 _size_byte, u8 *pbuf); void Hal_GetEfuseDefinition(struct adapter *padapter, u8 efuseType, u8 typ= e, --=20 2.51.0 From nobody Fri Oct 3 21:53:31 2025 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACF5A264614 for ; Sun, 24 Aug 2025 09:58:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756029522; cv=none; b=EOglExehMQq4GykJJbOmxWXb9yDDXGOg8AD26hYt3wOJOBmcbN86Z+lG1SUPYvSCwRPREogrDHmiDE0G+LGg3eY9fT8H44T3JWEmHdnFYoPvPo5xJ0I9FYsQVRvRcfp52Bk/UcX7gg9btjY0ppErpbw4vqzun0+I3tWrk3AByy0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756029522; c=relaxed/simple; bh=CXpEwzcOgts0UYKdQU3OZhreVhHUKwGYoANggirmlPM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jh3vkRsM92xS8pt6Hu5faLIDceGKgMp7jdDXZKAJ2VqpVjdXRfVLghEhi0WgEZTve7WNszFYvTWRbzT603nKyeqHEVbh/n2dj+wNIoGDlse0ipB+F0wqRxOnFnzuzWpnEtKsDppo32T4319fUGvJ+WpuZp++DXfknWJtnA2BCHw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k9oGXbKk; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k9oGXbKk" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-afcb78f5df4so586927366b.1 for ; Sun, 24 Aug 2025 02:58:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756029519; x=1756634319; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CB3jyeOTf+YX3hjwKO9p+5RPKcTVpxOior2qXXRyptY=; b=k9oGXbKkDjUCeUzLvIhhTKMzerehq4X0Wzxj4npP81NaL3NVznUvnuY5Pz3GHL5CIB pIciww46TaPGFFUCJY12HzBSa4FvUVUJMzcY6ZTiBwsczdNMNu5B16XD+1+sIAuApvi5 nkQU1Ej/0CvBJnQT29S5wA5RV+o5ODkJnwhOFKOOTBL/+TTtau7srYcPPCzMInY7dxO5 EVEEoa0cahvla4Owry7b99j1ASZYL/rfEQ9+6cfb+UhbxhR14jIggY1YpzjtTzfCPUg1 XQwr/4UyX4DhmaU0awHOoftGDdKLlZSDEVBDZsAYikSayEoD2u0cnm0bUg9Enc5DDnP4 DluA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756029519; x=1756634319; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CB3jyeOTf+YX3hjwKO9p+5RPKcTVpxOior2qXXRyptY=; b=xLIVjGkdOUer1Dik1yjHj5fzMWiuiYLMZQpzZOPD6hMYjtqbl6lxckBFXBZZzqlT2i TWfCr5p+QWQxLqUmBDqdPZG2qnpZendY3GG+SYH0ddBzDlr+0KjtwdZLtQTWXFXb4+V0 R+d7i0iy3xJ/P8coAMXQZ+2g/n7QRCGI3AsL+y7sSqj9pbqbezPnL30OaHCZnPQ6IMz/ w1J9yrFAXh9/VulKI68RB2YhgKVj4g4SbDVukiEE9h3bFtWyDKSg11q9p/344W8Mi7/7 81vnE192JLmZXwQ9FtAnBbb9GnRd/c0haa9tOk0EIsBfobN2FtGRFcfk8tH/bbaGx7a0 i6tQ== X-Forwarded-Encrypted: i=1; AJvYcCXRzQ6NG9oN7/d0vSNsMKq6VIyMS/XyCgjK7MK170u8xWyqg2pJOoEZJVXhsRX8/8BXEArzIJVQrSKyj/U=@vger.kernel.org X-Gm-Message-State: AOJu0YxWcyWDb1Zedh6GSa5fOoBFsEa739DTMeaM3zVzi/bUN12f6TX3 8so3W4cQyiTvCMjG99cJ0QJ9ofMSZGNNY4BRZYzKpWjXqoBTcFS8hZDJ X-Gm-Gg: ASbGnctNWLNaomF+NJublQzfJ8wBPL8YM1bouKMdpa3/f/tptknJ7aWyGejrtWlR8v9 Ipv0NVDWCxcxDJy6MDa8sQ+LRSy9Eu2kS629QZd8fYfwRcYYMqukOVFkMFAP2sFiXMwqad9c41B v51vlVtpMgNtTmDau7sNbwGbPxNBZPFfsZj6vJV9VL3V3Km0VwygWHImn/0JGXOenUYG2F23e2H rfAiBb1nJ23KOHEAXLCIK4ep9TSyCUXwGQVPH+p4mipGXNypbxhW+/lKxLrvBL4bOWRLKC8qpP8 Zo8FcK+sK1XV7ahpgIxCM8L/1zagjj+yI3HvQgffrY2plUm/a0mDDjXxq+3+kbG09SmHqd9M9+B vI0rro8vddsG85fTE2ud/KzgRJg== X-Google-Smtp-Source: AGHT+IGQeXBOoeK68ALXLYtOAYAecYc2sLvZHTeB0Ue7szRlW3hJU4FCo/iL21WNNcmTopTbWW8RtA== X-Received: by 2002:a17:906:6a1f:b0:ae6:f087:953 with SMTP id a640c23a62f3a-afe28f8581cmr819070766b.12.1756029518977; Sun, 24 Aug 2025 02:58:38 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe79fba62dsm41314766b.100.2025.08.24.02.58.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Aug 2025 02:58:38 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 3/4] staging: rtl8723bs: remove REG_EFUSE_ACCESS_8723 and EFUSE_ACCESS_ON_8723 Date: Sun, 24 Aug 2025 11:58:29 +0200 Message-ID: <20250824095830.79233-4-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250824095830.79233-1-straube.linux@gmail.com> References: <20250824095830.79233-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The macros REG_EFUSE_ACCESS_8723 and EFUSE_ACCESS_ON_8723 are redundant, both are already defined in header files without the _8723 suffix. Remove them and use the marcos from the header files. rtl8723b_hal.h:138: #define EFUSE_ACCESS_ON 0x69 /* For RTL8723 only. */ hal_com_reg.h:35: #define REG_EFUSE_ACCESS 0x00CF /* Efuse access protection for RTL8723 */ Signed-off-by: Michael Straube Tested-by: Philipp Hortmann # Trendbook Next= 14 --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 36680ecb5897..45cd2291f83d 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -568,13 +568,6 @@ void Hal_GetEfuseDefinition( } } =20 -/* */ -/* The following is for compile ok */ -/* That should be merged with the original in the future */ -/* */ -#define EFUSE_ACCESS_ON_8723 0x69 /* For RTL8723 only. */ -#define REG_EFUSE_ACCESS_8723 0x00CF /* Efuse access protection for RTL= 8723 */ - void Hal_EfusePowerSwitch( struct adapter *padapter, u8 PwrState ) @@ -609,7 +602,7 @@ void Hal_EfusePowerSwitch( } while (1); } =20 - rtw_write8(padapter, REG_EFUSE_ACCESS_8723, EFUSE_ACCESS_ON_8723); + rtw_write8(padapter, REG_EFUSE_ACCESS, EFUSE_ACCESS_ON); =20 /* Reset: 0x0000h[28], default valid */ tmpV16 =3D rtw_read16(padapter, REG_SYS_FUNC_EN); --=20 2.51.0 From nobody Fri Oct 3 21:53:31 2025 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A140269806 for ; Sun, 24 Aug 2025 09:58:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756029523; cv=none; b=Zby6Scu4gw9vFQ1//DRmoh6LykOTY/VCJQbHdHQB0BlTSNatq/SPNgBL/92IZQiDUJittW70VS3X4lJzmK6NVIj25Ea0lNoDGl6sR9wY+z+FhRqw7+OWti9bgJ3meaPy7mEs2vF0bmm3t+lCQpUDbp0ak+Ig/Ibac8UNlbA1CG8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756029523; c=relaxed/simple; bh=qCuohedTig+dBflD+bJqbTY8MVe0rkaexM5kYM0D4ww=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VGk2U7kIbiMcXoLfXMYlgV8Oj3oP0cvIpmvNMojYXqG6EdUXFg/yk7otU+UlFfO90FrntFPQ0qDWsJRfmLCoOzSZwLS0ABED4/OC0cIPTUBw25aGWI9cd8sp42LY2g6/AvyoHhACrgIl50bQm9+qzGJ0mLchebLReHD9wTMH9hs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FxXFUOSu; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FxXFUOSu" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-afcb7a0442bso553655566b.2 for ; Sun, 24 Aug 2025 02:58:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756029519; x=1756634319; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DvYsuGKgwDJ3CdZTywUVsaFMO2gJDf2toz0PGf3ll9M=; b=FxXFUOSu640QA8VBpmhks0HmKGXVtBtaQ7rWaecww9ni7pk6Pyu0fe+BWKux5YG8b7 pXuMoliOeYjIVxoCiVWDV/imsu+1UOP67hrfGYEj/wM+8P2y8VdJVTksfvmwRTPf7iZD 6N3PJw5xryfQlpz0wFxw25VzV8T5+TqqcbOtM337OjgiHCyqlrdGArhEgVYBbe4hMEm4 qEg3YUkS+2QziWRBljvzlVb9joKinsE6ZOYh9wanQTzvHFCPgxdQgpkHsPnM+rLg40Gl EjPa4ztQFJiXi6rGqaZDpPpyImct7Z4ecJesMnqelMgXowjQMM2/WLHH3O9OE0Qm4IK7 Ct3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756029519; x=1756634319; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DvYsuGKgwDJ3CdZTywUVsaFMO2gJDf2toz0PGf3ll9M=; b=WAj5Is5/mryB9JJ8I/CTO3YqL5wUMJDBPz/kmST9wMc7kAap30dtn+ns34F+nEwTAg NIFydM8eLsE5m26xeddq+oulWKZ7tZ9jurQS4aJlISNc+eEz01CcyU3b4IUvxFMritq2 BETSf74gVWIZe8zEJlHtApWHvr7XKximrz394dEq/PAwb6JroQPjY77yBzvurWnmaXg2 CxSdreEn/BFU7aQknUSUTQVjb1MG9tmevulWvaqaRdn+DJ/vcsVGw5DkRCHTI4DyV010 X3RQaZdCNH50T6arzNHD/W+dqhAVtQLwp7aXf+zmj14WPn7HHSYKzlMh9PNPaNYAydeM bfgQ== X-Forwarded-Encrypted: i=1; AJvYcCUrHeeEFVZzD2i5LFMtcxuqpKU9q6MI50csul8wDTx84DcI2bRimyiGRPmRZD4RoXfuSI2s6cH+AopNVU4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+dpWm+T4TKGhCzfdo2dyxyQKm/tNG3rFYTDKBJMNicHp2aEwm lQiAv/E+dU4vO1wQFUB5yzfNO+MQBUjlh9Oos/fRbwuILPisdzqCOBR6jFb1eg== X-Gm-Gg: ASbGncuCzx/+pQtfYYmkj/DhZRQ7u6WOYRYMfv/NB2H26LwEgLyQW/j50UjivqN1Oq2 oy8EEqGPRPjL7FZ9nYL6t+aHH8A7UhLUv+vwFH8pArPIqpeYx4rmldp3nanEE1WPt7CVnW7ofrv /Q2jhCiEdGh1/Av5Bc3bLYK8k9Mwr85jPaUIMdaJT3SAtnz/EWTMnM1zlQO2hfn4lWyBq/DSIcR n/nhWo1P/5C3P9NXvgGIeK4AZPf77jzWkex8GKL2hkmTIcaIlBRlBb+RCO7Ghco6Lx2lCBwFcmT bjuNBQgrZxyKR8S3U36HnDQArFYCEy/x4HytxWng183sWLR9wmMiWkFNrtVwon7+RjRLVZtuIoP MHHYSMFuySRZDXDFQpXY9JnL+tw== X-Google-Smtp-Source: AGHT+IHUgjHdJG8CmX711Go0qGjiVzBIzdUGCqALRPhnVIpluUA/K+SKc88aZMbU60nTK1rgX0/ztg== X-Received: by 2002:a17:907:3f08:b0:ae6:f163:5d75 with SMTP id a640c23a62f3a-afe28ffbfcemr819307966b.11.1756029519535; Sun, 24 Aug 2025 02:58:39 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe79fba62dsm41314766b.100.2025.08.24.02.58.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Aug 2025 02:58:39 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 4/4] staging: rtl8723bs: Hal_EfuseParseAntennaDiversity_8723B is empty Date: Sun, 24 Aug 2025 11:58:30 +0200 Message-ID: <20250824095830.79233-5-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250824095830.79233-1-straube.linux@gmail.com> References: <20250824095830.79233-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function Hal_EfuseParseAntennaDiversity_8723B is empty, remove it. Signed-off-by: Michael Straube Tested-by: Philipp Hortmann # Trendbook Next= 14 --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 8 -------- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 1 - drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 2 -- 3 files changed, 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 45cd2291f83d..18244adad9e0 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -1511,14 +1511,6 @@ void Hal_EfuseParseCustomerID_8723B( pHalData->EEPROMCustomerID =3D 0; } =20 -void Hal_EfuseParseAntennaDiversity_8723B( - struct adapter *padapter, - u8 *hwinfo, - bool AutoLoadFail -) -{ -} - void Hal_EfuseParseXtal_8723B( struct adapter *padapter, u8 *hwinfo, bool AutoLoadFail ) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 73561a63401e..7fcb874d0eb3 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -1071,7 +1071,6 @@ static void _ReadEfuseInfo8723BS(struct adapter *pada= pter) Hal_EfuseParseChnlPlan_8723B(padapter, hwinfo, pEEPROM->bautoload_fail_fl= ag); Hal_EfuseParseXtal_8723B(padapter, hwinfo, pEEPROM->bautoload_fail_flag); Hal_EfuseParseThermalMeter_8723B(padapter, hwinfo, pEEPROM->bautoload_fai= l_flag); - Hal_EfuseParseAntennaDiversity_8723B(padapter, hwinfo, pEEPROM->bautoload= _fail_flag); Hal_EfuseParseCustomerID_8723B(padapter, hwinfo, pEEPROM->bautoload_fail_= flag); =20 Hal_EfuseParseVoltage_8723B(padapter, hwinfo, pEEPROM->bautoload_fail_fla= g); diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h b/drivers/sta= ging/rtl8723bs/include/rtl8723b_hal.h index 40ff96d3cf74..2ed1fc8549ec 100644 --- a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h +++ b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h @@ -210,8 +210,6 @@ void Hal_EfuseParseChnlPlan_8723B(struct adapter *padap= ter, u8 *hwinfo, bool AutoLoadFail); void Hal_EfuseParseCustomerID_8723B(struct adapter *padapter, u8 *hwinfo, bool AutoLoadFail); -void Hal_EfuseParseAntennaDiversity_8723B(struct adapter *padapter, u8 *hw= info, - bool AutoLoadFail); void Hal_EfuseParseXtal_8723B(struct adapter *padapter, u8 *hwinfo, bool AutoLoadFail); void Hal_EfuseParseThermalMeter_8723B(struct adapter *padapter, u8 *hwinfo, --=20 2.51.0