From nobody Fri Oct 3 21:56:41 2025 Received: from mail-m1973189.qiye.163.com (mail-m1973189.qiye.163.com [220.197.31.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 299B8245023 for ; Sun, 24 Aug 2025 07:00:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.89 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756018813; cv=none; b=kOV2/SGSmqExc++vlR8lS+GDY21ug+cMd6jDxXaUZLxka0+FH40qOuBbiP40ZhmASyo2JwevnPVrObupTxArxOixfMCraHnpVpwMt7f9kQwnnXJr033yDNeCRjNKc2KXVYYniZQ2aA8OyfeTUA/VH5EoLVawLGwZftRYu+yb/og= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756018813; c=relaxed/simple; bh=TS+iKMQ8m3lp3MMoqbseCMqbxU5PyNfjGtVdljnAgcM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=u6jsyEnt2d3YcEiRzKbNK8N31SifnmSPe0cRQwfsJbVeul1DA6QZ7Z/51xfJtbXbUllU8nN3o1ypwwPzb11ncX9glChTWqysG2j4AJqM/tBt3zDIj3R5TYg5cn+dK5w3VCR7iWTTkwkUN7W1L+ut0xKuiq/jp9EyYMRDOIWmwj4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=aWZurvWE; arc=none smtp.client-ip=220.197.31.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="aWZurvWE" Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 20635ce14; Sun, 24 Aug 2025 14:54:53 +0800 (GMT+08:00) From: Damon Ding To: heiko@sntech.de, andy.yan@rock-chips.com, hjc@rock-chips.com Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.baryshkov@oss.qualcomm.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Damon Ding Subject: [PATCH v2] drm/rockchip: analogix_dp: Apply devm_clk_get_optional() for &rockchip_dp_device.grfclk Date: Sun, 24 Aug 2025 14:54:41 +0800 Message-Id: <20250824065441.3220852-1-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0a98dadbc60903a3kunm3ac07d9129ef6a X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGktLTlZNSU0ZSUodQxoZSBpWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0 hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=aWZurvWEga4kNz/cNldCLoewF0HF8QPtT2dh5tGraPGsD/zd+2KstAZNu2IrmmTqtJH+k0p2weANjaAZzr/yenypcxh//+DOOWqsKCuE+/qNZm9c2Cqdu2zHk9zwIJB+P1YuPVVGpf4xv985YrpZYB2ftVI5JBQlWc3c9U62uWU=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=OpejVT+/A4NMaugqkBklXTUATQceFhLY7R1EMZdVWEA=; h=date:mime-version:subject:message-id:from; Content-Type: text/plain; charset="utf-8" The "grf" clock is optional for Rockchip eDP controller(RK3399 needs while RK3288 and RK3588 do not). It can make the code more consice to use devm_clk_get_optional() instead of devm_clk_get() with extra checks. In addtion, DRM_DEV_ERROR() is replaced by dev_err_probe(). Signed-off-by: Damon Ding Reviewed-by: Sebastian Reichel ------ Changes in v2: - Replace DRM_DEV_ERROR() with dev_err_probe(). --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/= drm/rockchip/analogix_dp-rockchip.c index d30f0983a53a..937f83cf42fc 100644 --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c @@ -335,15 +335,9 @@ static int rockchip_dp_of_probe(struct rockchip_dp_dev= ice *dp) return PTR_ERR(dp->grf); } =20 - dp->grfclk =3D devm_clk_get(dev, "grf"); - if (PTR_ERR(dp->grfclk) =3D=3D -ENOENT) { - dp->grfclk =3D NULL; - } else if (PTR_ERR(dp->grfclk) =3D=3D -EPROBE_DEFER) { - return -EPROBE_DEFER; - } else if (IS_ERR(dp->grfclk)) { - DRM_DEV_ERROR(dev, "failed to get grf clock\n"); - return PTR_ERR(dp->grfclk); - } + dp->grfclk =3D devm_clk_get_optional(dev, "grf"); + if (IS_ERR(dp->grfclk)) + return dev_err_probe(dev, PTR_ERR(dp->grfclk), "failed to get grf clock\= n"); =20 dp->pclk =3D devm_clk_get(dev, "pclk"); if (IS_ERR(dp->pclk)) { --=20 2.34.1