From nobody Fri Oct 3 21:53:26 2025 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C328241668 for ; Sat, 23 Aug 2025 12:43:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953022; cv=none; b=XtenpcoRF2Wu+XaVCDiyXEzWDHFwFm5txweGt0vmwI0KcUZ8ir6lr4tWdAt9Rg2QF1bPAY1TU0cKKn7CTBc3PEjVpf220pqL0m2NzsTRO8KdDGKFKz68z7jYnYGpKm1mEOz5DYDnkA4BzvVgOWaAYZibqsgayvIHigDFSRRNnxc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953022; c=relaxed/simple; bh=nznVPVV1oW8RI0ysSjFO0IF3ye9S9TcnQ8RsmxBEwJM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JLEUs10ZFmFuj10AkRBu5+U+d7T5ym1euUmivi23v918LPhzpcztdWz1IqzEfjWZygGfj+Yg2E+BnBzcTm/UJlro8TzKYdTwfWMb//eZBVFv0gCIxwODtP+0Fd3+uuI2S3mXBH5wl4OsR3nofsUV8wTF1+MnhBTqZp8CTGnQmNc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DlstgTwf; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DlstgTwf" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-afcb61f6044so555329866b.0 for ; Sat, 23 Aug 2025 05:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755953017; x=1756557817; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9Z2TZ8sXO8/N8zS0gdcv8jeOIWY2VQYSICdu1a/1qRE=; b=DlstgTwfwZyIk4S5ILnEoPmGLvoyB5RrfFefANEM+XudEHxTz7fZ6xjq18y+rxNHaP TQw7Jm+t4ZrF/exQt4F8Wnupn/T4gpZhcnx6lLFu5aoyLgfgwVaxpRnAaL2XyWBjTS7L cM7p26nFRZW/1bG+r5AUNzoanS9mg99eP65QqaHeLCKckwM/MmonJ9xr6B/6N8JxJB6g 5yjTwbjSQA/HXIyUXPaHINrYaHG8c+NUKd5c4hp2KLGGNwVT00cuNGP0z9YlosykuYH1 68o+o9/iKPAMFL8Lru5MzVzIemiZeNfbnSPChGjB6ow7x/Gv3dTf4uGDYP290txX46Ux S/mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755953017; x=1756557817; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9Z2TZ8sXO8/N8zS0gdcv8jeOIWY2VQYSICdu1a/1qRE=; b=kFSXJJGC3yivDV1tWOcFjP7tJIrrGCTg9Gyvie4eeznh4rO+S+d/uBFI+gkN3PIEC3 2KRW2uTd8ANuc7jd6VfWLgHYvvAN3FiGa1CJ1uhNDZUL3Q+lGtU97ngYFKR46KIOmmGk BW4F7ruv0GvTAHM36c8hlZVpCcK+WOHgYuFbaiexhTq/+ruDTlLlZlOx66ev3oHxetWN 4EJS92pAMtI+h7+QXB0VKSeTVnQxoTsWZfU10JyRo0zDZjp0k9W8RLcEQHvbV6geWbNY SZXImFKRgIDyY8X3JIyG+dc6Uw3nQETtYbri1ee5Y5f441aegjgH2ke7a81Ipx0h1AXX Rw1w== X-Forwarded-Encrypted: i=1; AJvYcCV46+Qeb0boG4hFgCRHeiECRWvSflPz7rQ50jLkx+HIWLV8hWmxR0J3j8vhrp+jb97gNoL1UIBiBR4n/As=@vger.kernel.org X-Gm-Message-State: AOJu0YwXogNeHF+HZAof87+/TLYVmkAI9fFpmBOKWJc22mTvVIAHDEGL XlqKXbg1aaOX3HrzRxj8PTMotfgfU5TmLDvq+YT+WJWns2jxaYd2G7r6 X-Gm-Gg: ASbGncswdGEsot1FPmR/j1D80IHEMm+6RWI5UOTouQrvyKrvFuDfNO8JyeCACVjrz8g OD+rSnlYFFSZWZ9u2nXiPnhzfO8iFzQVeeX1x4f4GLZ/Sp3YrzGcZbmQtiO6O96km1jys1LLFau 3iKe6cCmYokMgbN+9qQeZiQFIzT5FCBkkak/xqUI9F/BFiIwM0XGR+zLjfkf4/5UhkQKiERXenB uJg6droWuk5rzEDHoXQL6vh4DeCVYld5Nnqc8vVVBQZsiXoJ5NePSTRN+kzfy01lxjtKuJeqCzF 3GxvRst7JZg6mrCbkusMDQdN/E3sJanY4yG4D96lGTS7Xbq638W00g6LBcXWS2hoVNZ1y8vyFzc RAkQJenGZM0n5BjWkq/qC7fQyug== X-Google-Smtp-Source: AGHT+IHRpKv/D9CHOevfjwnioo0z/Iv1Zr9GBpRkzn1JcjAQVLITUj5WgDhgpwI81f4cG+vFjTQnaw== X-Received: by 2002:a17:906:c145:b0:afd:eb4f:d5cc with SMTP id a640c23a62f3a-afe0b4ade1fmr866551266b.31.1755953017336; Sat, 23 Aug 2025 05:43:37 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe49a1f5a6sm165076466b.111.2025.08.23.05.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 05:43:37 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 01/14] staging: rtl8723bs: remove bPseudoTest from EFUSE_ShadowMapUpdate Date: Sat, 23 Aug 2025 14:43:08 +0200 Message-ID: <20250823124321.485910-2-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250823124321.485910-1-straube.linux@gmail.com> References: <20250823124321.485910-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function EFUSE_ShadowMapUpdate is always called with bPseudoTest set to false. Remove the pPseudoTest parameter and replace its usage in the function with false to reduce code complexity. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 6 +++--- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 ++-- drivers/staging/rtl8723bs/include/rtw_efuse.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/r= tl8723bs/core/rtw_efuse.c index 208373113a62..d28298fa2853 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -386,17 +386,17 @@ static void efuse_ShadowRead4Byte(struct adapter *pad= apter, u16 Offset, u32 *Val * 11/13/2008 MHC Create Version 0. * */ -void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType, bool bP= seudoTest) +void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType) { struct eeprom_priv *pEEPROM =3D GET_EEPROM_EFUSE_PRIV(padapter); u16 mapLen =3D 0; =20 - EFUSE_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *= )&mapLen, bPseudoTest); + EFUSE_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *= )&mapLen, false); =20 if (pEEPROM->bautoload_fail_flag) memset(pEEPROM->efuse_eeprom_data, 0xFF, mapLen); else - Efuse_ReadAllMap(padapter, efuseType, pEEPROM->efuse_eeprom_data, bPseud= oTest); + Efuse_ReadAllMap(padapter, efuseType, pEEPROM->efuse_eeprom_data, false); =20 /* PlatformMoveMemory((void *)&pHalData->EfuseMap[EFUSE_MODIFY_MAP][0], */ /* void *)&pHalData->EfuseMap[EFUSE_INIT_MAP][0], mapLen); */ diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 1608bc71bd71..4a0423182f9e 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -1438,12 +1438,12 @@ void Hal_InitPGData(struct adapter *padapter, u8 *P= ROMContent) if (!pEEPROM->bautoload_fail_flag) { /* autoload OK. */ if (!pEEPROM->EepromOrEfuse) { /* Read EFUSE real map to shadow. */ - EFUSE_ShadowMapUpdate(padapter, EFUSE_WIFI, false); + EFUSE_ShadowMapUpdate(padapter, EFUSE_WIFI); memcpy((void *)PROMContent, (void *)pEEPROM->efuse_eeprom_data, HWSET_M= AX_SIZE_8723B); } } else {/* autoload fail */ if (!pEEPROM->EepromOrEfuse) - EFUSE_ShadowMapUpdate(padapter, EFUSE_WIFI, false); + EFUSE_ShadowMapUpdate(padapter, EFUSE_WIFI); memcpy((void *)PROMContent, (void *)pEEPROM->efuse_eeprom_data, HWSET_MA= X_SIZE_8723B); } } diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/stagin= g/rtl8723bs/include/rtw_efuse.h index 669565fa1c69..7bc8de3af1f9 100644 --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h @@ -98,7 +98,7 @@ u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr,= u8 data, bool bPseudo void Efuse_PowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState); =20 u8 EFUSE_Read1Byte(struct adapter *padapter, u16 Address); -void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType, bool bP= seudoTest); +void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType); void EFUSE_ShadowRead(struct adapter *padapter, u8 Type, u16 Offset, u32 *= Value); void Rtw_Hal_ReadMACAddrFromFile(struct adapter *padapter); u32 Rtw_Hal_readPGDataFromConfigFile(struct adapter *padapter); --=20 2.51.0 From nobody Fri Oct 3 21:53:26 2025 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3C64255E26 for ; Sat, 23 Aug 2025 12:43:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953021; cv=none; b=hsOY5zsa0jIkh00fK/Ys1Sa09+/brHWDS9tta6cSmAXpVc98VKaYmADOzyLskPqeTbI+BbJbuBN5fy/HIjNtrhooEhBtua50Zaq7uFCQdfU1mPtwPycOD4fGm7/FENhiWFuzTUxvNpegqtxXBP0Tt06imL1xj+VD/BvakT6baNo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953021; c=relaxed/simple; bh=Q0yzuR/i79OwBtVvMq1n9QC1kcnPbq976kLG8+CKJv4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nz8aHmrG3zmpAVKUNhM7hhnfLAcadfBSz21dvPis6HTvA3fOLwdd8fTtLw2ZAqdJOb458VhZjZshmwafrn/mtYCMbEOQlfsnjd5kZQwwQ69rYMblm4ADCmAFSI99+33qJtbSLZG7h46PMuMLe+Uw3EAwdVj8C9AMZs9P3EWil9Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F3rC91d4; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F3rC91d4" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-afcb72d51dcso397993966b.0 for ; Sat, 23 Aug 2025 05:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755953018; x=1756557818; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zB9qSruL7ILHa9+FTZbiJBxaeqZc7/PdYKJSFKSL6Vc=; b=F3rC91d4etqaDmOQitf3BAfhI+6qgmF1lp8XvZa50HRp+pxRuM4OrO8CK2WcVVxKMg 1ykIpRfwjwEZ31+8X0AObRorYzN2h37oS8YFYDZzSF1jJ/60eG4rdCgDe+jJcdRF0cZT lNDm8oGv6MaA4duemp7axZaPk+SMIQ6EJRk1AwbEUQNL53ZWhJM77jjJ5pUnPj5AZ7KY UrGf45CthScDSEr8lJhNWz6JKF1iNxY7xKqRXYZ0xEnqP6G7MTCl5u6/MHAO0QejQ49Y yX3deIc5Z6kO7D1pemPYgo3cGEpIcm6j3tZzKkpoC93/MC1lmLXL9buBfFu95RTtCI8T 71oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755953018; x=1756557818; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zB9qSruL7ILHa9+FTZbiJBxaeqZc7/PdYKJSFKSL6Vc=; b=GPgl4yBd+m0Km/fZZh6Bj+UiS/hjNPjxqA73Pt3WEJkG9Ek4c5WokzOucR38r0vTbA VadmK8ilGvzMVgePzUZdj0fnntXWjwtkka6LFKfPG+HuhVxYAO46LEWHp+Xpb46AphEJ a+5/8h9BmsTJqN0wyMXjF+farhVy4SoLT/vix8NYxgcXBTATuBfdUt0pc4yh+I52LpLt erZl8A/rpSI+sbP+PtnFwLn/lnUx6bB1D8jJPz6MiFeS2oppmXRPfNHvpin8l7F56h6K R98PooHlwfA2ow6hHnEgQd2WgsgC4d6SdzVgxjd683uqxaqmckX/juS1QTyAnhPmRrxA wC0Q== X-Forwarded-Encrypted: i=1; AJvYcCVjeTU2YfElGDUvllvipMUSuBju8RzlpofBfTKtzVyYHGeAwP1p37nNlvNSNaSklSWHXg9K92wb1HnrFAY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3Z9Eu2w8K88AmBZOEm0mnmR91j60Ww9nIyiyAWDM0Eo5Y/YzB OtJ0hgOw2ZiFLkTp33zKMn3Tjc9dQiJoMQZvbhahFsnb+dO3Q9bMaK79 X-Gm-Gg: ASbGncsf31Ztai75iFhkE3nh9qTH3iPzbacX8MiZ6AuVJaUL9ewgLXz2V98cBh7vKCP ZiWoJQb6jFrNRjvCCr+KThFVZ9GYndZSH3FYDJvX0u+zIvsfHOA5ugCMaJGfbkx2c08IXgy5JyL M+hgmVxTTNmm4SuHrZI6tN+IHU0CZrr69jIIZBJ7do0Xw+RezK0eJBgq9ZaE8dZWtkDk8+2PWdj 1kn/2zR8QZQf1dPcRk16KzQJnnOyPu/Exg+tYVjOU6a12TZ6mDlUqLZbB8pMQhCBc3agvrGUIOo oDRWCMWLV5OJHGuO0ApUbgxAdeKwfr4rdJrRYy6FtT7MI1hDICYdwx8QXu1wdXOPg0rEidzzCBt LakJnqDXDG7qI+g0nn1YBbYNSFw== X-Google-Smtp-Source: AGHT+IFutx0nnw0Arhk2mibJLHYoSwyZEPHjy/OfHDEcHOJcV10CoLPaHLuGQ9DC4/TRQUtPY3vQXQ== X-Received: by 2002:a17:907:7f89:b0:adf:7740:9284 with SMTP id a640c23a62f3a-afe294ce4cfmr600917066b.57.1755953017904; Sat, 23 Aug 2025 05:43:37 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe49a1f5a6sm165076466b.111.2025.08.23.05.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 05:43:37 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 02/14] staging: rtl8723bs: make Efuse_ReadAllMap static Date: Sat, 23 Aug 2025 14:43:09 +0200 Message-ID: <20250823124321.485910-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250823124321.485910-1-straube.linux@gmail.com> References: <20250823124321.485910-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make the function Efuse_ReadAllMap static and remove its unnecessary forawrd declaration. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/r= tl8723bs/core/rtw_efuse.c index d28298fa2853..2c0dc55fb20e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -303,13 +303,7 @@ u8 efuse_OneByteWrite(struct adapter *padapter, u16 ad= dr, u8 data, bool bPseudoT * 11/11/2008 MHC Create Version 0. * */ -void -Efuse_ReadAllMap( - struct adapter *padapter, - u8 efuseType, - u8 *Efuse, - bool bPseudoTest); -void Efuse_ReadAllMap(struct adapter *padapter, u8 efuseType, u8 *Efuse, b= ool bPseudoTest) +static void Efuse_ReadAllMap(struct adapter *padapter, u8 efuseType, u8 *E= fuse, bool bPseudoTest) { u16 mapLen =3D 0; =20 --=20 2.51.0 From nobody Fri Oct 3 21:53:26 2025 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CB09258CEF for ; Sat, 23 Aug 2025 12:43:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953023; cv=none; b=tgYaIdRdMJA26S4SMq1AN7+bgVX92XSZOTXPqc8X9HSudMVazx/n83uIshpI5DQDG40iSIDVvIMzaIOVTx3stnA/AG8vz9gz1c0UIq/bcXK46l9aO2raDfCO1RQk0beURqK/HOkqZG73qWHEMyYSQjMrKCJ0NvBC4JKGAZW8QYU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953023; c=relaxed/simple; bh=B5WuxuwbtaSLBjDtJWQ/gsFwN7RDDeo7jZrKiyfSn6A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i29jn+T1oybNssbLnDFXuED0ox6M2bGolbJfWn0wCrg4/JKE581UAiu7JWIYlF7vM+eTkYIvToXCayYD5s49oKhHahhrlgV8PWZWWiumVa5iuyBDjayn8zhq2ES1Y5rv8hqBYXLo7SZLSHIhPT8RIJv7m7DjX/BXrtnRUACpMj0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Mvt//Sai; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Mvt//Sai" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-afcb61f6044so555347266b.0 for ; Sat, 23 Aug 2025 05:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755953019; x=1756557819; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9og3+uRw64r/MDppjSYN2NDzI0VJAzl5jXkEcD/Diyo=; b=Mvt//SaiQuq+J/Tp9HlLQJaQgZbmMw4Yni0NdRpFoHI4GaWpOXC7Phkp+ZgyJoyToJ mOYDZNPcq51nB/4Ws4P6sHft3o5hbSl8m+v4aiojP0yFzhYZq5REkffZQKUVGWKZX4V3 B6Ph6GL+D6ZWxVmo6m5xnWlQbva5NNESU33DVDEToE37RQoqBirGMRP9tiqnmW7P3EHo Y1PY881gXpIYTqS/wCjk2BgyUDqmSxGw0bn3BbFvQYh3uvPopZHMn481TuVCIlqL4Wyu 0K9DfZ6/YACDKxNpS5LfiyYbbWzJnWssYUFr+m8wJSLD33ZBP9QLn+V1sztmNdHOnw4s ZNTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755953019; x=1756557819; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9og3+uRw64r/MDppjSYN2NDzI0VJAzl5jXkEcD/Diyo=; b=K84jB2LicQ8Ynwehx2VI1oEwjrG5vsY0iIjgGYCdeYAs+1MoiBAp5AF9gjkqsMLbm+ 1gnWh6cQ5MXL05Oi+IYE2Uz69JBJ2+StBHV9Zjuw7ohH5vLk2swF+SNDh8W0GFwC99Hi mVs7e3Zb582X/nYB1sJ/uHt7qGW229sRXzAF8LdGTonzmiHG/zt5lZB1zv9PvvGzPClI NNHpaoonogPescc68tC+nutsXJahHCJapPn7euoogKGehIk7XWwL5Z+jYj8OBzUGVD4g KMAmNSzdMc+v/u63XxkjXiid9a6rGGIaZQTQ7GNmhkqBXZ88MNIq8DNWyP9B0S9p7CQt m/eg== X-Forwarded-Encrypted: i=1; AJvYcCUJg9XNhwKs9J+H4fzcPSAz4zrwaL2ZsyXzvisXPvwY8baYV/+Pl7O+dpSzWLly45QijmbXIig3TDpqcpk=@vger.kernel.org X-Gm-Message-State: AOJu0Yyam23iqgqiLeEAdFaYJ6VPL+YQ4R4Cx00U3FWZq6H3NG4xSSGB PGIdozo1gcWk4jOiHOv5f62RX9WGRpLGBVvAupN38Y3XBaob/J1jC5P0 X-Gm-Gg: ASbGncvUAjH+EJJ6Lb7kDxkxJlmT22pwYU3QZYTz/0GOl6yM4pRsWVfgcl0FKVbR4jO 3KFtVWfLHJo4ZjEz/Z7sRT3jlvgqeJBm5bj5cUbIMUO+KnqQdvku3ZnWIdBTnOY7SPym3C9f0C0 m2LHw71zG/TTIT38uYY8CcCS3eya75eegLSRfBZ98Qy8k5WT3VRXW0Nf2gkP8WDXRL0RKRKIGT3 jVpNZM5jG9ZOfeKzBCtnsGMrqxcmdgPKIFrVfdW455ZZ7JcxAxv/2mlWiiTw/9eNw4y17hPIfgn 01GtzVIhu4HW2ULieOtZ0NuOp0x6BvyrfuQMARKkSb6ZCvlZpQC26cRzgmZjnTWqKs6uhPgXViI xzwxdSILxoqWU4zpukVu1iSXSNg== X-Google-Smtp-Source: AGHT+IEq8dkXUNPFJ4bVxwzfFI0ohs17PD6BvkhvEnlnS4v8bLD4YT9K9JDLzB01tdP1ORVEKWzggw== X-Received: by 2002:a17:907:868c:b0:afc:a330:3318 with SMTP id a640c23a62f3a-afe0afff566mr876260066b.3.1755953018559; Sat, 23 Aug 2025 05:43:38 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe49a1f5a6sm165076466b.111.2025.08.23.05.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 05:43:38 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 03/14] staging: rtl8723bs: remove bPseudoTest from Efuse_ReadAllMap Date: Sat, 23 Aug 2025 14:43:10 +0200 Message-ID: <20250823124321.485910-4-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250823124321.485910-1-straube.linux@gmail.com> References: <20250823124321.485910-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function Efuse_ReadAllMap is always called with bPseudoTest set to false. Remove the pPseudoTest parameter and replace its usage in the function with false to reduce code complexity. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/r= tl8723bs/core/rtw_efuse.c index 2c0dc55fb20e..e865f83c0967 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -303,15 +303,15 @@ u8 efuse_OneByteWrite(struct adapter *padapter, u16 a= ddr, u8 data, bool bPseudoT * 11/11/2008 MHC Create Version 0. * */ -static void Efuse_ReadAllMap(struct adapter *padapter, u8 efuseType, u8 *E= fuse, bool bPseudoTest) +static void Efuse_ReadAllMap(struct adapter *padapter, u8 efuseType, u8 *E= fuse) { u16 mapLen =3D 0; =20 Efuse_PowerSwitch(padapter, false, true); =20 - EFUSE_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *= )&mapLen, bPseudoTest); + EFUSE_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *= )&mapLen, false); =20 - efuse_ReadEFuse(padapter, efuseType, 0, mapLen, Efuse, bPseudoTest); + efuse_ReadEFuse(padapter, efuseType, 0, mapLen, Efuse, false); =20 Efuse_PowerSwitch(padapter, false, false); } @@ -390,7 +390,7 @@ void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8= efuseType) if (pEEPROM->bautoload_fail_flag) memset(pEEPROM->efuse_eeprom_data, 0xFF, mapLen); else - Efuse_ReadAllMap(padapter, efuseType, pEEPROM->efuse_eeprom_data, false); + Efuse_ReadAllMap(padapter, efuseType, pEEPROM->efuse_eeprom_data); =20 /* PlatformMoveMemory((void *)&pHalData->EfuseMap[EFUSE_MODIFY_MAP][0], */ /* void *)&pHalData->EfuseMap[EFUSE_INIT_MAP][0], mapLen); */ --=20 2.51.0 From nobody Fri Oct 3 21:53:26 2025 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2158D259CBA for ; Sat, 23 Aug 2025 12:43:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953022; cv=none; b=ZqKNYJgJowaJgcaCxk2GAeeg4xHpJB1l5VbVpsh8KrtdiakL5YNqcsiL9sZOQqv5FJK1Fxd37gqSuqdRoQr6E0bj9XrUdSG/z/K7bruDBnek9PpuJhXVZPZKoaYorfi1K9ECSX9uaJmUMVi9faIbooK6hm7OsSQGZnG8KC8LDfU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953022; c=relaxed/simple; bh=K2GtzP1Tp6PLlfmQr1Kp1P75OZIn7IvpZyIysY3IAnE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RXpaQx6aGOER7oGbXG7ONU0f3HDNKPE3rBWfQKrc8QMLAUgZ6vwhUCfOU9iAT+HyaYwJHYp54OXboVlXo0rhA5BFpLmkpUAhQ3XPkdIa8y4BA13A5wfXkBES+y0BwBNklq9n5KHwEMbOzLyyzko/S9UwI7SPMKG+ThOPJvpIAbg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V2rz1Jfy; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V2rz1Jfy" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-afcb6856dfbso540080066b.1 for ; Sat, 23 Aug 2025 05:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755953019; x=1756557819; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d/T8DTnsDa48J8Nw09VdyHPo/w3+O0UEktrhRhKVLZc=; b=V2rz1Jfynm40GV+DpqdWZd+NL5qG1DJZmlrA3b4Qw59O+9scm//yH+JO8hmsS/VOn+ lGWqmYW/PKtv/8uWDunaBr627saz9WqRZnfTEyAW4d8EJfcmNiq/SNES1iU8BvpPCYsV B8CumTk45fM+pJzEQoymOPfdXsmf99iafiw7+5sdscrMsesqhZfamKnvh43NnOMYMDWe TvABnuSyq9D/a20IzRWWSqGZsJn65TH4qaqZlWkVsStQPfZ6s8AUMwt5IcDkejOAXr6r fOmlrGO5I8P2V8OF3w2osqRw6qsxnxhc1cUy+t+Onm94bNOfDkOZucIbcashCTm6WiE5 rWig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755953019; x=1756557819; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d/T8DTnsDa48J8Nw09VdyHPo/w3+O0UEktrhRhKVLZc=; b=vvJN8W3wOMuVc88T2JPiSQqGcPZMh9DwKh/i5nngoNaWu1v3hmwUyARmCD3HR8G/gg R1NPuMzlJVnZmdvEyEZpn3h0JjQu4hx0qNIpS32xD0AvQsWU8GhskF9PEWa9POnLzhf9 rbMQ10OIXP1mOQw2ikAEyv+AoRJmaI+xyNTQVP2ll0MOVHIu8N8mnV1+aY7jR7PD3U8e xhGQOpn8b54zf3JQd/C61u60SbBtHTVDMDpgEjTLTyG49fBJ+u2Q4ejVN6d4FAllqlFw M6j0cyXzed+rl7dbpg51giEKSiYV60DEEfyQ9SYiZ96y2bK6zalFBysaZJANNNV723R4 ztVA== X-Forwarded-Encrypted: i=1; AJvYcCX1QYZdsqPxBJGlEuQYELh4pvyBOjkQZ8Qc3hj1WAT5Z1+3iLSQ60U5PxW0I4xPC+LEVAplaSa5MyCOrwA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3z56ShFcPRv5AyZe5jE+gQ03GHfeaIZ/TpG6x0AkRfq/cpUl4 7Z6rxbvlR3AlaaE+v5f0kBrnpiZoKja2rmGJ3HINmn/cIFNyZqRuZ52X X-Gm-Gg: ASbGnctyMoM7oECCIrLpe1mrs7UeJMOQDV3g9+G+xNqbq8uAZyko8gb3ws1YN5+LeGe J1oG7qjhD9e/VkufveTHLo+9y/Dc8r7+4lte9NI/Q/sCJqd9ukspPdq+RgdVadqkIYUPGqnvrpD nSFnodH8wbRT2FVDM1ILg77Kb7Pdf1pqTXIXR96McT5xS1u72tlYlBQYm12lypgtAwNnrjTBWjk ofmXiNfjREoa1fH+FpHwQSzxpSrIVr8pLMOPaMphgDkVrOR50TIIs6fGeGGL/jxcIFbaOKVxPF8 D+l2VVLhAP82xSska25kFlJ17KcWy8C0ouGSWm18AqKmwcDFunSMTd3zRBWIvm1r+TIhwcSKyqC WXd7b5CG3RGwwTY0htNIjRS7FeA== X-Google-Smtp-Source: AGHT+IEheKPxRuuoJ+c7oqo62GuSN8YIYg1PG8sW6j7mepnpvA8qCpSnad+S6HjtVsMmkKwECfvCew== X-Received: by 2002:a17:907:9693:b0:afe:5765:2012 with SMTP id a640c23a62f3a-afe576604e0mr183099966b.15.1755953019144; Sat, 23 Aug 2025 05:43:39 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe49a1f5a6sm165076466b.111.2025.08.23.05.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 05:43:38 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 04/14] staging: rtl8723bs: remove wrapper efuse_ReadEFuse Date: Sat, 23 Aug 2025 14:43:11 +0200 Message-ID: <20250823124321.485910-5-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250823124321.485910-1-straube.linux@gmail.com> References: <20250823124321.485910-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function efuse_ReadEFuse is just a wrapper around Hal_ReadEFuse. Remove the wrapper and use Hal_ReadEFuse directly. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 42 +--------------------- 1 file changed, 1 insertion(+), 41 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/r= tl8723bs/core/rtw_efuse.c index e865f83c0967..1079e2bc3287 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -97,46 +97,6 @@ Efuse_CalculateWordCnts(u8 word_en) return word_cnts; } =20 -/* */ -/* Description: */ -/* 1. Execute E-Fuse read byte operation according as map offset and */ -/* save to E-Fuse table. */ -/* 2. Referred from SD1 Richard. */ -/* */ -/* Assumption: */ -/* 1. Boot from E-Fuse and successfully auto-load. */ -/* 2. PASSIVE_LEVEL (USB interface) */ -/* */ -/* Created by Roger, 2008.10.21. */ -/* */ -/* 2008/12/12 MH 1. Reorganize code flow and reserve bytes. and add descri= ption. */ -/* 2. Add efuse utilization collect. */ -/* 2008/12/22 MH Read Efuse must check if we write section 1 data again!!!= Sec1 */ -/* write addr must be after sec5. */ -/* */ - -void -efuse_ReadEFuse( - struct adapter *Adapter, - u8 efuseType, - u16 _offset, - u16 _size_byte, - u8 *pbuf, -bool bPseudoTest - ); -void -efuse_ReadEFuse( - struct adapter *Adapter, - u8 efuseType, - u16 _offset, - u16 _size_byte, - u8 *pbuf, -bool bPseudoTest - ) -{ - Hal_ReadEFuse(Adapter, efuseType, _offset, _size_byte, pbuf, bPseudoTest); -} - void EFUSE_GetEfuseDefinition( struct adapter *padapter, @@ -311,7 +271,7 @@ static void Efuse_ReadAllMap(struct adapter *padapter, = u8 efuseType, u8 *Efuse) =20 EFUSE_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *= )&mapLen, false); =20 - efuse_ReadEFuse(padapter, efuseType, 0, mapLen, Efuse, false); + Hal_ReadEFuse(padapter, efuseType, 0, mapLen, Efuse, false); =20 Efuse_PowerSwitch(padapter, false, false); } --=20 2.51.0 From nobody Fri Oct 3 21:53:26 2025 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBC8225B1FF for ; Sat, 23 Aug 2025 12:43:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953023; cv=none; b=Q5jTSwJbUJnxaeMzUr6DefV3YsyqZnlMydlmGJ8F7mYoxLJt6kpUv7nngl6U2duTiTXtrWvfXpyb327ZWTzRPDPt8amomcZRJDnQsXMh7ToDkmbx39SqiVmSALuvcMp6df3SAqYo7ZNEnu8Mcn8utBaXy75sjybPe7zbHkVctCg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953023; c=relaxed/simple; bh=roanaskB8oiM/AncCs6OPMtvzR+UvubYsGnl124M0yc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C6yrSPpIIAx2ITfHFPkP9atS1f9AI/SsqmjhgA1+AYTUG/ejY36eRg10ZyIpWO76ojp5xBLyooGIYG2PjLFLkz9YGIBsAIbcjYg56X+ioY3l/M7xMrvkwa0wXVmvvAujhE6IL9m9KSzQLn5theW3pw+NX2C7oXG0BhC73XCuylA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Nz+OVDsS; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nz+OVDsS" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-afcb7a2befdso424518666b.2 for ; Sat, 23 Aug 2025 05:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755953020; x=1756557820; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mhPbh306uA+mZWGyZJvI2krS7O9T1n16n8YRZur58lw=; b=Nz+OVDsSseUnTdmLHR4hFCYDY2K6peVn43sF1OC/XlpDcENxAhhOMgdr/EnVscxGMB /ylX/8QQthX5RhsWFBtFohNzD1SmOO3D8NoGf95viif2FwRP9en0Wrf+xKDx82zVIvOS IG89L17mRleXPePJzCRGhweuTb5cp0R8zsgOQciseinQjDCJEt6DiFBczIaIC1Djvbpk 3xgF2AkaDLiRuRpR6YDbX8mWxL3IIodoq2Kw6jtuezT4rjaCRUJmVjp9/XCqYHsHh5IX kCpDoqkyjFtD7OPoKOxegnX/DPaJuFSrFVXtRn+sB84pYkdsyFRyIs+1Ly/tgvH9T7wV tVdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755953020; x=1756557820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mhPbh306uA+mZWGyZJvI2krS7O9T1n16n8YRZur58lw=; b=nxpKxB5kWjEv1+kZPcWGEe6bqGbV70+5gebVC7TFlb1NbRrFeEVWW6wm+kk9VBoyYA y3nlpNxBKsznN34IntExr8KlAwG4DWT8Obf52xaNvjMXGo/hP05OA5oEIpQmjlUVVpeu QZMvMyUYTrnFXIUz1STCvJ2Mirtqxuno7Yw5Faq6gvdHEmHUrWrgYgJjEJ7LNaEEWwHX HMSdFYgPOtrlezTvvB9RolX5/WHzh0WpXaL3a0QCUC01Hpcl4q3pwWx9i3r5I46c4SAC AKkndkH78lzd+mnbHGO4SzL3G1VFOM+lmCoATFE+aH0ZC1LZJ6qp7mamMwsp5AxEpLVJ SMGQ== X-Forwarded-Encrypted: i=1; AJvYcCUBcBzx/hq2iSws1E6yrNOip9bP/8+KsjCDsnEv1ZEcX5s1VWFe4hv2EokE+/bKdkdz4j95BQZXZx2TojA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy716dU3+j+56lJV1oYmagApqNXTqP16gUp6BwDVn5X9GGej27V Vk/0/fAjPFF5y99qmQb8alA72DV11BC+PAUnMSTfN/WmMQOQy1E4giKq X-Gm-Gg: ASbGncu684QF/+RSFCukBWPWxYhxxaDunWa/eDkW+DH2rhZPdPSdNrkL9InIDOQt0/X j1THE6w4i+2+YMwGVH/05LcVnKIFo7kQqpP5LJ5Jdzz4t2K6YbGNTcW00bnQgdMsCc5eik3QUz2 qCs8eqZfD4TvT0PLPGAHfBh8YsWDiN8NTqibXkXQNOWUL6QoRL+2pZP23KYjyuAv0JPmuArIo/P gXanpqP0lzY0hkFUbU60iXrI/MuVpIrD/AOHHAfBhPa2fIijbbqBv/ICWmgRgdM4023Mhos1IHN BdCb4R6ZsXMiBpd7Vn8ep+sLT5y5Ysttum9arnOyfZ7Ac4jJZNh8ejjHT+pvT+ND4uu1ye71RFh CuTCu64cj1sJefTvBE4K4LUdJEQ== X-Google-Smtp-Source: AGHT+IF8QpcsQjg3wQz9UpkXvukBigrUxbie1Cl/dEgUT/7krFaNF7F4bkJeHH7UN63rH251d5SH+Q== X-Received: by 2002:a17:906:c10d:b0:ae0:a590:bc64 with SMTP id a640c23a62f3a-afe294c7236mr550080266b.18.1755953019782; Sat, 23 Aug 2025 05:43:39 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe49a1f5a6sm165076466b.111.2025.08.23.05.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 05:43:39 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 05/14] staging: rtl8723bs: remove bPseudoTest from Hal_ReadEFuse Date: Sat, 23 Aug 2025 14:43:12 +0200 Message-ID: <20250823124321.485910-6-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250823124321.485910-1-straube.linux@gmail.com> References: <20250823124321.485910-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function Hal_ReadEFuse is always called with bPseudoTest set to false. Remove the pPseudoTest parameter and replace its usage in the function with false to reduce code complexity. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 7 +++---- drivers/staging/rtl8723bs/include/hal_intf.h | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/r= tl8723bs/core/rtw_efuse.c index 1079e2bc3287..388d885c938f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -271,7 +271,7 @@ static void Efuse_ReadAllMap(struct adapter *padapter, = u8 efuseType, u8 *Efuse) =20 EFUSE_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *= )&mapLen, false); =20 - Hal_ReadEFuse(padapter, efuseType, 0, mapLen, Efuse, false); + Hal_ReadEFuse(padapter, efuseType, 0, mapLen, Efuse); =20 Efuse_PowerSwitch(padapter, false, false); } diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 4a0423182f9e..002648a8fd81 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -883,14 +883,13 @@ void Hal_ReadEFuse( u8 efuseType, u16 _offset, u16 _size_byte, - u8 *pbuf, - bool bPseudoTest + u8 *pbuf ) { if (efuseType =3D=3D EFUSE_WIFI) - hal_ReadEFuse_WiFi(padapter, _offset, _size_byte, pbuf, bPseudoTest); + hal_ReadEFuse_WiFi(padapter, _offset, _size_byte, pbuf, false); else - hal_ReadEFuse_BT(padapter, _offset, _size_byte, pbuf, bPseudoTest); + hal_ReadEFuse_BT(padapter, _offset, _size_byte, pbuf, false); } =20 static u16 hal_EfuseGetCurrentSize_WiFi( diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index 67d51e55bd44..2e97a918445c 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -267,7 +267,7 @@ void UpdateHalRAMask8723B(struct adapter *padapter, u32= mac_id, u8 rssi_level); void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter); void Hal_EfusePowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState= ); void Hal_ReadEFuse(struct adapter *padapter, u8 efuseType, u16 _offset, - u16 _size_byte, u8 *pbuf, bool bPseudoTest); + u16 _size_byte, u8 *pbuf); void Hal_GetEfuseDefinition(struct adapter *padapter, u8 efuseType, u8 typ= e, void *pOut, bool bPseudoTest); u16 Hal_EfuseGetCurrentSize(struct adapter *padapter, u8 efuseType, bool b= PseudoTest); --=20 2.51.0 From nobody Fri Oct 3 21:53:26 2025 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E29525C821 for ; Sat, 23 Aug 2025 12:43:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953024; cv=none; b=f+XAuFb/bkah2MSZNWYXdt0h8eUtO8z3VAdU0X1HnlAYarnkdj6h6wi9/rgBtVouHlr7s4LvELl0RWuNQIEbyJFsM9vThUQnAYabzB32HD4eIg8xVOlof7CnTuzJ+3g67MWPIZRm7SXyRfLHPUDxobxk1bNDPrxIriEutJzf5Fg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953024; c=relaxed/simple; bh=99WVo19afdz1JIRRG4oj49qBaDsrneCNsX5B1FHuSy8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bkcDPG55yoDXk5ax5dKrubDOPx6ZKCgK8QEUPOvDqEuWR1CGFdPvuc3C4uWuoeKnDcmAT7YISOU/T1mH5wipx4g3APAXd2yX7pmBJa9ItCmV2T0edwi/sMEZ3rUVHVsHPfVOmaiUYTcZ0DdMwrFCRN9f38yr5uqXgnrZsUmzGxY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TtOuupfr; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TtOuupfr" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-afcb7acfde3so449094366b.3 for ; Sat, 23 Aug 2025 05:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755953020; x=1756557820; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oh3OTq9cM6mb9Y0x2jVB+Qtv+usV8rcusK90cvfpk5c=; b=TtOuupfr2B8vuDA2KVoQtvIr3Ve8oPgc+2v8l5CbR4+GkubBKKyTG6eBZ9oyGvg9Br Y6amyDCSzPiYJhkHOVplQ2DZa12udoU2sNhm8zUHYaaWEYAZVjw6CkmmXickJPwmHB/7 CacPdTm+S44GnA1WacFUd0vnchdmw+A2aX24uucIP5JZtxO86rU/az+YrJ/eUou5Hcnh WhHurYFCF/D7lBBiHdixUm9qSG7eZ3o7eg2cz3VJ0eWpgI48udvUMn6/nbAN56tope97 R+E+ye4k13OcbAMlKDqWSx4aBAar4uOfLEV4Zo6J+e8dG1KlyXpFa6QqJb2kD0ZgurFb IlLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755953020; x=1756557820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oh3OTq9cM6mb9Y0x2jVB+Qtv+usV8rcusK90cvfpk5c=; b=sm6QGQaNfz0iOtRGpYgOrrlRUglsDiaGqjWNfyWq4DfhbQZ+3P848iTUpIRmo6W7DB WZcNp2/9PIQTSYsiyNwyp0u1pEdzXdan+YrPzI1Rn9NXMVCqFardJJnsEpBgx0gIOMk7 kXrWwZSlSBa+nfo3v0KVylhT30Xj1OYaZzM0y2QHm0mVUiFlVxGpVtiyZth6yTqBI9Fu 4IezyCJ7WCv6G1xDJgH4I/zYVB6wAKjMSb+ZNhqlZsTI1c9z5r4dwkqVn3jxi8HRT5jV 9CHmqUlfFcpRhw/flH20w1wLTzSDSSUjnmf6vVG6/c8yQlAcni92keOLPCdJeP+QTl5z 0SLQ== X-Forwarded-Encrypted: i=1; AJvYcCWtPgIX0SquYIMecnl3JXxptwMXaN39l6Okyp+bNISETINIzlVqLeNKgL46QUjXsqtJ5qk6ZQbfXyD9wHs=@vger.kernel.org X-Gm-Message-State: AOJu0YxMmwIz6AVk3+1EGf+rTyzcXHnIYNynIXplfQBkRf6naM1C1z2G zGsGaniapP6kV/N7hSEctwxrRbuRycs5SfURad7ckXkt2sMnqX66Pqng X-Gm-Gg: ASbGncsgWPs1lv1Ly0/6PvbhiW7iwGCDj+ld8u8MP+24ZWe5DE03OG1DsW9JahxLeCs b7MUqwifzyCkBAb6bSAUDVUmlwJyBZ3n2CnBA9Y/XNDatjM/RYfcLN6JlQ6M13l37p1GVsEnn/l EPs+qJWnlXZdRYClnL4b6usSZrLpM2MkVfKZT/TYb7r5Z+bJFisJyLvQivyofD8oC6YuRAqDTAP rLryt1JdGFKtH8xt4PQGap2fXeQH+EVtAAYhRMFJex59KdelqW/ICeMDhDoR4eEs/tb6e1sz0en yAOcSxsj5whCy5LGSTqn09nPNFQyG7yAb6FAkbJqs/IvmbrNhHpGAAImSueGw5TK3aEuNxqrATR cHNsn85KUS8o9m21oMywDqWiE7+iIdFEDF9Rk X-Google-Smtp-Source: AGHT+IE8n4m+meZknAuGPSp9YYvhKmxlh6lB/MpTdULlL3Gv7pr7EZXuT1CXGj7hXfxa41kGFnpMQA== X-Received: by 2002:a17:907:728d:b0:afd:d9e3:9540 with SMTP id a640c23a62f3a-afe296b1f49mr523921366b.64.1755953020458; Sat, 23 Aug 2025 05:43:40 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe49a1f5a6sm165076466b.111.2025.08.23.05.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 05:43:40 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 06/14] staging: rtl8723bs: remove bPseudoTest from hal_ReadEFuse_WiFi Date: Sat, 23 Aug 2025 14:43:13 +0200 Message-ID: <20250823124321.485910-7-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250823124321.485910-1-straube.linux@gmail.com> References: <20250823124321.485910-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function hal_ReadEFuse_WiFi is always called with bPseudoTest set to false. Remove the pPseudoTest parameter, replace its usage in the function with false, and reomve resulting dead code to reduce code complexity. Signed-off-by: Michael Straube --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 34 ++++++------------- 1 file changed, 11 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 002648a8fd81..c40d447c04d2 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -669,14 +669,9 @@ static void hal_ReadEFuse_WiFi( struct adapter *padapter, u16 _offset, u16 _size_byte, - u8 *pbuf, - bool bPseudoTest + u8 *pbuf ) { -#ifdef HAL_EFUSE_MEMORY - struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - struct efuse_hal *pEfuseHal =3D &pHalData->EfuseHal; -#endif u8 *efuseTbl =3D NULL; u16 eFuse_Addr =3D 0; u8 offset, wden; @@ -698,10 +693,10 @@ static void hal_ReadEFuse_WiFi( memset(efuseTbl, 0xFF, EFUSE_MAX_MAP_LEN); =20 /* switch bank back to bank 0 for later BT and wifi use. */ - hal_EfuseSwitchToBank(padapter, 0, bPseudoTest); + hal_EfuseSwitchToBank(padapter, 0, false); =20 while (AVAILABLE_EFUSE_ADDR(eFuse_Addr)) { - efuse_OneByteRead(padapter, eFuse_Addr++, &efuseHeader, bPseudoTest); + efuse_OneByteRead(padapter, eFuse_Addr++, &efuseHeader, false); if (efuseHeader =3D=3D 0xFF) break; =20 @@ -709,7 +704,7 @@ static void hal_ReadEFuse_WiFi( if (EXT_HEADER(efuseHeader)) { /* extended header */ offset =3D GET_HDR_OFFSET_2_0(efuseHeader); =20 - efuse_OneByteRead(padapter, eFuse_Addr++, &efuseExtHdr, bPseudoTest); + efuse_OneByteRead(padapter, eFuse_Addr++, &efuseExtHdr, false); if (ALL_WORDS_DISABLED(efuseExtHdr)) continue; =20 @@ -728,10 +723,10 @@ static void hal_ReadEFuse_WiFi( for (i =3D 0; i < EFUSE_MAX_WORD_UNIT; i++) { /* Check word enable condition in the section */ if (!(wden & (0x01<fakeEfuseUsedBytes =3D used; -#else - fakeEfuseUsedBytes =3D used; -#endif - } else { - rtw_hal_set_hwreg(padapter, HW_VAR_EFUSE_BYTES, (u8 *)&used); - rtw_hal_set_hwreg(padapter, HW_VAR_EFUSE_USAGE, (u8 *)&efuse_usage); - } + + rtw_hal_set_hwreg(padapter, HW_VAR_EFUSE_BYTES, (u8 *)&used); + rtw_hal_set_hwreg(padapter, HW_VAR_EFUSE_USAGE, (u8 *)&efuse_usage); =20 kfree(efuseTbl); } @@ -887,7 +875,7 @@ void Hal_ReadEFuse( ) { if (efuseType =3D=3D EFUSE_WIFI) - hal_ReadEFuse_WiFi(padapter, _offset, _size_byte, pbuf, false); + hal_ReadEFuse_WiFi(padapter, _offset, _size_byte, pbuf); else hal_ReadEFuse_BT(padapter, _offset, _size_byte, pbuf, false); } --=20 2.51.0 From nobody Fri Oct 3 21:53:26 2025 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E427825E448 for ; Sat, 23 Aug 2025 12:43:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953024; cv=none; b=XvbnhrHA+was2Gj2zbPLiVhLcp8LpDwkGbjUXW5/dicno256AvbFh9v1HOvuR75i9g3Orz82iBuWUEFDqLyVkU1HcSg9KvrHtOqehlresi4u/FxQiGp13w6HzXtBjXLxPgOSXhwiylLTVx3tMx0CIyqIfP0xKamru5Qk+omEtic= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953024; c=relaxed/simple; bh=XYDT8ZOTnQxbxYmv/f6mFEmi+5cv/e0YHVfg05WEN7U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TiZCxz/LtlOMTlJCKGAGKIdPGml/WqheQPDOtegiUlFw3aRSIXagL0Dh1zhK07295w2bFa5J4GzVxCuVqS4VAUl0ij1XCdb3Q0Ja+0ISt0FYx6iTHFsfCNBxRrEVBxREZSksf2kB9AL6MKZ75/AgakYFFpWe3/nmtR9M9Bptpng= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OIDR+w35; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OIDR+w35" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-afcb72d51dcso397998866b.0 for ; Sat, 23 Aug 2025 05:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755953021; x=1756557821; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w8yurgLbPr3IHtTft2ct/QRPqVcIbgbSyThd3cfoEIM=; b=OIDR+w35hSMvxOo5QZgGL5YzYtcRqAu6OKs5eoO8SqBlhZ4DRLWFZvYih1V5KbJfUq /5E3VaLTaRLluLyax8MmIsiXwOCXTTisw3aUuG/bSaJ27hKrnjaTdxtcbJy/7BjcYunz OmT38qb2G1sAQ6ZStgaV+1ebEdcuaI72zFpKjyBLqREAIWCln5zFRk54cwZoPwD3D9/r K8jsShQO+CwhGTjV0FJIZuKJta1arN7Q2VCUdUh9q2oPPN8hLJ6V53t6Fb1M0RWDF2OF tRzgLyfxqJtMIW6uhoGLzfuOvaK1c7lSLvdXqATFxlMCXeV9gxSBvd9dyIXngugpB8Iy 5xwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755953021; x=1756557821; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w8yurgLbPr3IHtTft2ct/QRPqVcIbgbSyThd3cfoEIM=; b=cre9ZjF2g42WODgexRrHfK+K7sV0Kw/Zr4w5/xMJcI92NJPYS9ztuCveqOHgT3dpjU K6tTAcdUgDlBIOKlhhDRlkNcHafppvScM3lgi1rv8QDFn7UogzbaqIQP7cwdpknKwxHo O+E0ns/Gm6eblJ6wUpO5/kgdy3381T6XjxBHXMvtYcVDzmJCe/XkEj4ihniNMNUeV9CA aGlNB7TyCuW52BK3CliLBIotMXx+Z+KJc5Zrfl193rGz7MPxNGPFAdQsGVpcoYUQccTZ 00DSTE4NOvtGasdgS2TFPZda0iOKCnE7yEn8PkAyMS0JIepE6QiW7vb0DJ52+FcqbdZY pMlA== X-Forwarded-Encrypted: i=1; AJvYcCURJbRSKr6alqvBybBMA0ppgTlhqKRv2RA+uOc6DUPNzumgDD+VYUWl9BJlUN14PD3REwpMe8nsYquG08E=@vger.kernel.org X-Gm-Message-State: AOJu0Ywnp8olh8q6B59DAObYPJwNptOXKPPpesOftaEjSjvvYlgwgpLb rXFWPiwhTlIrPeGDi9948HE7vXUf8UsAMjG4w0XMRwcmKQgB7otCkGkQX+4fUQ== X-Gm-Gg: ASbGncvEL5EYaCBCWVSDvOebzEmneskkvgb6OqpgT34fg2b7nT2tn2ZpFd6FTo9mciX 7IoN79hTsSteqW5Nr8geV7ElEKNRZITLNFFDYzZ9AzkTq2QuT4RXYCEbiMywQiXdsKwxCgzPB2z AGK9e7tbaGPZn/Mxu0Z+OZb03wLPghajZmN6//512lvcFWNd4vIU9UEBWPI5i7Jb7MkZ9NgCntt o8eBePi6E35vge33e2faJmT1xaCrTDHfP5jt6nujjw79b4XdlZUU+ltdS7c2CBFVBAfNNRCZPGC RNt5rRg5AC+xkHUGu3BQoyV01d7HGHaCU34cZNJ3XxFeJ8xv00I/xWv3XzO16JI6rqWdeQQ2BQY 5IKgEIR7JJc4FbiuXALEWBlQNSA== X-Google-Smtp-Source: AGHT+IHAzv1MMgc0gFfWXhwPq/A8HO45MupcnjPCPrRmtfDqTvL16u2WrA1HnUyNcdS27dCv2oYpNA== X-Received: by 2002:a17:907:972a:b0:afd:d62f:939 with SMTP id a640c23a62f3a-afe29047b3emr565020366b.36.1755953021120; Sat, 23 Aug 2025 05:43:41 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe49a1f5a6sm165076466b.111.2025.08.23.05.43.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 05:43:40 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 07/14] staging: rtl8723bs: remove bPseudoTest from hal_ReadEFuse_BT Date: Sat, 23 Aug 2025 14:43:14 +0200 Message-ID: <20250823124321.485910-8-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250823124321.485910-1-straube.linux@gmail.com> References: <20250823124321.485910-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function hal_ReadEFuse_BT is always called with bPseudoTest set to false. Remove the pPseudoTest parameter, replace its usage in the function with false, and reomve resulting dead code to reduce code complexity. Signed-off-by: Michael Straube --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 38 +++++++------------ 1 file changed, 13 insertions(+), 25 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index c40d447c04d2..fe6a3dd84aca 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -755,14 +755,9 @@ static void hal_ReadEFuse_BT( struct adapter *padapter, u16 _offset, u16 _size_byte, - u8 *pbuf, - bool bPseudoTest + u8 *pbuf ) { -#ifdef HAL_EFUSE_MEMORY - struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - struct efuse_hal *pEfuseHal =3D &pHalData->EfuseHal; -#endif u8 *efuseTbl; u8 bank; u16 eFuse_Addr; @@ -785,16 +780,16 @@ static void hal_ReadEFuse_BT( /* 0xff will be efuse default value instead of 0x00. */ memset(efuseTbl, 0xFF, EFUSE_BT_MAP_LEN); =20 - EFUSE_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_B= ANK, &total, bPseudoTest); + EFUSE_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_B= ANK, &total, false); =20 for (bank =3D 1; bank < 3; bank++) { /* 8723b Max bake 0~2 */ - if (hal_EfuseSwitchToBank(padapter, bank, bPseudoTest) =3D=3D false) + if (hal_EfuseSwitchToBank(padapter, bank, false) =3D=3D false) goto exit; =20 eFuse_Addr =3D 0; =20 while (AVAILABLE_EFUSE_ADDR(eFuse_Addr)) { - efuse_OneByteRead(padapter, eFuse_Addr++, &efuseHeader, bPseudoTest); + efuse_OneByteRead(padapter, eFuse_Addr++, &efuseHeader, false); if (efuseHeader =3D=3D 0xFF) break; =20 @@ -802,7 +797,7 @@ static void hal_ReadEFuse_BT( if (EXT_HEADER(efuseHeader)) { /* extended header */ offset =3D GET_HDR_OFFSET_2_0(efuseHeader); =20 - efuse_OneByteRead(padapter, eFuse_Addr++, &efuseExtHdr, bPseudoTest); + efuse_OneByteRead(padapter, eFuse_Addr++, &efuseExtHdr, false); if (ALL_WORDS_DISABLED(efuseExtHdr)) continue; =20 @@ -820,10 +815,10 @@ static void hal_ReadEFuse_BT( for (i =3D 0; i < EFUSE_MAX_WORD_UNIT; i++) { /* Check word enable condition in the section */ if (!(wden & (0x01<fakeBTEfuseUsedBytes =3D used; -#else - fakeBTEfuseUsedBytes =3D used; -#endif - } else { - rtw_hal_set_hwreg(padapter, HW_VAR_EFUSE_BT_BYTES, (u8 *)&used); - rtw_hal_set_hwreg(padapter, HW_VAR_EFUSE_BT_USAGE, (u8 *)&efuse_usage); - } + + rtw_hal_set_hwreg(padapter, HW_VAR_EFUSE_BT_BYTES, (u8 *)&used); + rtw_hal_set_hwreg(padapter, HW_VAR_EFUSE_BT_USAGE, (u8 *)&efuse_usage); =20 exit: kfree(efuseTbl); @@ -877,7 +865,7 @@ void Hal_ReadEFuse( if (efuseType =3D=3D EFUSE_WIFI) hal_ReadEFuse_WiFi(padapter, _offset, _size_byte, pbuf); else - hal_ReadEFuse_BT(padapter, _offset, _size_byte, pbuf, false); + hal_ReadEFuse_BT(padapter, _offset, _size_byte, pbuf); } =20 static u16 hal_EfuseGetCurrentSize_WiFi( --=20 2.51.0 From nobody Fri Oct 3 21:53:26 2025 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8771F25FA24 for ; Sat, 23 Aug 2025 12:43:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953025; cv=none; b=BKnjkFD4RjKTYT8YBKe4gmdDjWTMu8+BU2QVUxMrn5cfuS354TZSvDp3RIh2T8Envjf7tqyvZ0hs4Qo20zkVs2lIpg4zUUReCsnWb/GHNLi4BDA4ue9eYJhBHKckll608IXcrhOGUnV7Wo1E8pyhWBcSPNl2wy5IAgsSDpj2Hi4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953025; c=relaxed/simple; bh=PkXGQpIu3CT9MkDPjbhrfHERe13KeKCUlk4Eka85HsM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l8l6m2ekuGQ4h4yJnIb0ArO95fqHdowVy5RQ1QLnLj8CU2l05yE/G4D48NH0L/oMp0oA8Z3gluz/0L/kYYusQgPr34D+ZbKfN2MdQTVCOFSnfp5Pw8Pvddx5gwFmiCMKkTe2wXsRWfXNwzyhGsDVS4g+5n7ZMvxPm+KSBeZ1qNo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EYhXab7G; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EYhXab7G" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-afcb731ca8eso473013066b.0 for ; Sat, 23 Aug 2025 05:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755953022; x=1756557822; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zBvCvb23Z+9Bc2OcwtiN+FlqbAuREfquDJGcbDfAlSY=; b=EYhXab7GjBcbWuhcGvnOZK397CPKhwxX6MWZVxdnZiYukgi0pU8CWx/4taNJdV9+2+ Akn+xaQC8psNfY1D2sBWU7IACZyEi1aHgsn+OVl078Xk5snGWRkon1nBKIQo31i9H32F OhVFyXdAKsuPeUb5vABnalkBsk2o0pTpmC+s3c3QOAilBchvWIywqU67PtDirbnHpoHm qbKLb3PZNacXdwlBqPQKA+TR4QKi4wt+q1m2ywWcqJqekB4/SEla3T28C17wf/2Yzv+M v0P26fU4vNMqMltDeBzQOePriqeIcsPIVbr2Qw9Tu4XP68UNqJY9POnaipsezilh48U5 rdKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755953022; x=1756557822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zBvCvb23Z+9Bc2OcwtiN+FlqbAuREfquDJGcbDfAlSY=; b=CGLz+FXIYXTIE4HyT2mXDdX7bfZXx+1j+jUrgQEmHZy0p/yAzgmP6cBclocHNzRyrQ wLAAu5pG809NiG/+pAd0L08mrE4FCdTJoL8XThfhHdWFiVfU+1zxj506r9fq2hhAUFHJ eY+95Xt9gKVj2O2fQnYhylJu/nAe0rNraV2OPsrVIMsObjbgME4hSSvXHFTnbVp3fVd+ nikuD3SZwxp/5f7zhkOIU36S/eXJ0zDsPgSs+DYBBO6D+523oFEN8GbFyd+Dl4mXJibQ j3O3T8ph45ssJPGIBGE4Kq04pyNT2L56oWifHcyaIj2SLpKb2h1TozENrqp4DEop1m1l AFXA== X-Forwarded-Encrypted: i=1; AJvYcCUTePr5+V8D+P1DM5Z9He8Z7qlIdh/3gmp/+oLVgs1uV25K4OlRnCPiDvgjU1CAgRw0HI+I90NTLwiw2Bc=@vger.kernel.org X-Gm-Message-State: AOJu0YyTeiZ5Wupx3ZUje7DFA6BBhtzQfas+H/4AJ7xSZl5N7I9bimz3 Fu07VPUBryiWfaCRSbATyz/k8eBNqtvmRGjY4Wp2MZL8dLPbQR3D2RhJ X-Gm-Gg: ASbGncsQ039Nh1lgM/lrsgJTcnCK9D5n7cUKMvp8z1GIFBKjgwpON3gSZTwGuPLetU9 13CZt/G7iNc4zsPli/IU/aBOFsu1bCRWpQkZU4mEsP1ni/wtAh/8wE004Q70lR6peBGvZHa3b1a 9nO7C6OgsX1zhfNwXZE8YEC9JOK0hdwY85N5jYbDrZaNGwRmN/q20wMMjfgoeegCPHH0t1iD8j/ 0C0GWjlKEckceqYVEtWZiM0ruKCdjmpcKY+yzM1Uz/tFizApBexOO0a+Jd6fs3RJywBFMNczGwt d6b1lc+q0qMQa3TtPkw31Z/NWKBZn6Nyc+vn6fDuAKDYDNdgP+Nx6w0DsV9n9XZLDKJlIv6vXVA dH2NIeXyFwQ8WK6KwfbR7OM8UlA== X-Google-Smtp-Source: AGHT+IGcDrKg1c3I3k2qWHrMI/GPriAUQeuJB2oG7JtfMQiUYFwCepN5YYM9fY0UzXW4NF+sHAPPMA== X-Received: by 2002:a17:906:491:b0:afe:57e0:e421 with SMTP id a640c23a62f3a-afe57e0e9c1mr111976566b.26.1755953021752; Sat, 23 Aug 2025 05:43:41 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe49a1f5a6sm165076466b.111.2025.08.23.05.43.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 05:43:41 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 08/14] staging: rtl8723bs: remove wrapper EFUSE_GetEfuseDefinition Date: Sat, 23 Aug 2025 14:43:15 +0200 Message-ID: <20250823124321.485910-9-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250823124321.485910-1-straube.linux@gmail.com> References: <20250823124321.485910-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function EFUSE_GetEfuseDefinition is just a wrapper around Hal_GetEfuseDefinition. Remove the wrapper and use Hal_GetEfuseDefinition directly. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 18 +++--------------- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 10 +++++----- drivers/staging/rtl8723bs/include/rtw_efuse.h | 1 - 3 files changed, 8 insertions(+), 21 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/r= tl8723bs/core/rtw_efuse.c index 388d885c938f..25ec7278b815 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -97,18 +97,6 @@ Efuse_CalculateWordCnts(u8 word_en) return word_cnts; } =20 -void -EFUSE_GetEfuseDefinition( - struct adapter *padapter, - u8 efuseType, - u8 type, - void *pOut, - bool bPseudoTest - ) -{ - Hal_GetEfuseDefinition(padapter, efuseType, type, pOut, bPseudoTest); -} - /*------------------------------------------------------------------------= ----- * Function: EFUSE_Read1Byte * @@ -135,7 +123,7 @@ u16 Address) u32 k =3D 0; u16 contentLen =3D 0; =20 - EFUSE_GetEfuseDefinition(Adapter, EFUSE_WIFI, TYPE_EFUSE_REAL_CONTENT_LEN= , (void *)&contentLen, false); + Hal_GetEfuseDefinition(Adapter, EFUSE_WIFI, TYPE_EFUSE_REAL_CONTENT_LEN, = (void *)&contentLen, false); =20 if (Address < contentLen) {/* E-fuse 512Byte */ /* Write E-fuse Register address bit0~7 */ @@ -269,7 +257,7 @@ static void Efuse_ReadAllMap(struct adapter *padapter, = u8 efuseType, u8 *Efuse) =20 Efuse_PowerSwitch(padapter, false, true); =20 - EFUSE_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *= )&mapLen, false); + Hal_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *)&= mapLen, false); =20 Hal_ReadEFuse(padapter, efuseType, 0, mapLen, Efuse); =20 @@ -345,7 +333,7 @@ void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8= efuseType) struct eeprom_priv *pEEPROM =3D GET_EEPROM_EFUSE_PRIV(padapter); u16 mapLen =3D 0; =20 - EFUSE_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *= )&mapLen, false); + Hal_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *)&= mapLen, false); =20 if (pEEPROM->bautoload_fail_flag) memset(pEEPROM->efuse_eeprom_data, 0xFF, mapLen); diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index fe6a3dd84aca..5355bb80b676 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -741,7 +741,7 @@ static void hal_ReadEFuse_WiFi( pbuf[i] =3D efuseTbl[_offset+i]; =20 /* Calculate Efuse utilization */ - EFUSE_GetEfuseDefinition(padapter, EFUSE_WIFI, TYPE_AVAILABLE_EFUSE_BYTES= _TOTAL, &total, false); + Hal_GetEfuseDefinition(padapter, EFUSE_WIFI, TYPE_AVAILABLE_EFUSE_BYTES_T= OTAL, &total, false); used =3D eFuse_Addr - 1; efuse_usage =3D (u8)((used*100)/total); =20 @@ -780,7 +780,7 @@ static void hal_ReadEFuse_BT( /* 0xff will be efuse default value instead of 0x00. */ memset(efuseTbl, 0xFF, EFUSE_BT_MAP_LEN); =20 - EFUSE_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_B= ANK, &total, false); + Hal_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_BAN= K, &total, false); =20 for (bank =3D 1; bank < 3; bank++) { /* 8723b Max bake 0~2 */ if (hal_EfuseSwitchToBank(padapter, bank, false) =3D=3D false) @@ -843,7 +843,7 @@ static void hal_ReadEFuse_BT( /* */ /* Calculate Efuse utilization. */ /* */ - EFUSE_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_T= OTAL, &total, false); + Hal_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_TOT= AL, &total, false); used =3D (EFUSE_BT_REAL_BANK_CONTENT_LEN*(bank-1)) + eFuse_Addr - 1; efuse_usage =3D (u8)((used*100)/total); =20 @@ -952,7 +952,7 @@ static u16 hal_EfuseGetCurrentSize_WiFi( =20 error: /* report max size to prevent write efuse */ - EFUSE_GetEfuseDefinition(padapter, EFUSE_WIFI, TYPE_AVAILABLE_EFUSE_BYTES= _TOTAL, &efuse_addr, bPseudoTest); + Hal_GetEfuseDefinition(padapter, EFUSE_WIFI, TYPE_AVAILABLE_EFUSE_BYTES_T= OTAL, &efuse_addr, bPseudoTest); =20 exit: =20 @@ -984,7 +984,7 @@ static u16 hal_EfuseGetCurrentSize_BT(struct adapter *p= adapter, u8 bPseudoTest) efuse_addr =3D (u16)((btusedbytes%EFUSE_BT_REAL_BANK_CONTENT_LEN)); startBank =3D (u8)(1+(btusedbytes/EFUSE_BT_REAL_BANK_CONTENT_LEN)); =20 - EFUSE_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_B= ANK, &retU2, bPseudoTest); + Hal_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_BAN= K, &retU2, bPseudoTest); =20 for (bank =3D startBank; bank < 3; bank++) { if (hal_EfuseSwitchToBank(padapter, bank, bPseudoTest) =3D=3D false) diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/stagin= g/rtl8723bs/include/rtw_efuse.h index 7bc8de3af1f9..a5c338c67245 100644 --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h @@ -91,7 +91,6 @@ extern u8 fakeBTEfuseModifiedMap[]; /*------------------------Export global variable--------------------------= --*/ =20 u8 Efuse_CalculateWordCnts(u8 word_en); -void EFUSE_GetEfuseDefinition(struct adapter *padapter, u8 efuseType, u8 t= ype, void *pOut, bool bPseudoTest); u8 efuse_OneByteRead(struct adapter *padapter, u16 addr, u8 *data, bool b= PseudoTest); u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool b= PseudoTest); =20 --=20 2.51.0 From nobody Fri Oct 3 21:53:26 2025 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 259222641CA for ; Sat, 23 Aug 2025 12:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953026; cv=none; b=blxDw14YQ6wGfA2JLk6MWqhK//A//65ZrTfrc+OTKZNvwOEOzhaMt0DPzk+DekrkreloROmcfsXh82G1RnH3o9WdlSKqbVXhvRjyIBMK+IMwKExB7LufATCWwWHsucOV23INYsSCCF+aP7od5WEufMvPA1JhvVC052WNnfE2MiU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953026; c=relaxed/simple; bh=yKqwH5a6Nz+pa77SkUNK6+bxeAf7vNAaaZiTcMwKWHU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=irgP+Bb3QrlD+TBzV0wqR9cDYUNCvVHqzNWhSn2UteabH7fzugJCt6M+85T/rV75fLLesYHx/3IVqRhGW0MGSZi6EWaPG7isDzoWe/8X3Blo0tHjfzJy3wrg6y3J0BBDsJRN6HUX1oQ1J6HZKP6I2f/1kae2n4rA8JZ+YCl8ECc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JIBvGHGm; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JIBvGHGm" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-afcb78da8a7so448941466b.1 for ; Sat, 23 Aug 2025 05:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755953022; x=1756557822; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xzIetETHYWHivxrw/pp5DLuF943UAIx59/qdlutf55Y=; b=JIBvGHGmFKvYxUizSHEcOiNrPp0k1SiwzpnTuGMBx69EP2vL4u+GB0QbjFEi9KoLiX pgzbJDSPycRAzNEFb/Jjs/LB8QXPQQZNgCWywVxOYUx4seBQLwwQXTJTUKXHWcWbzque dblPwntJRF9ab/SeWBVTw/CD4S8VNSyg3dBjoXzgFUHMsXiPdiiDG5umY1V0KLw9scHU Coxu82sEfxg5WY9maM2C5CZuikBqWont0utZJeEnId0XgISqILYZN/1DA5rHnkB/Gpim bPAQwJcmSPQdifS37geLXDd/sFbu3Kvn1GF2rR7Y4WMte+u56CUB2CtFcRXzoA484x2a GbTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755953022; x=1756557822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xzIetETHYWHivxrw/pp5DLuF943UAIx59/qdlutf55Y=; b=lChu0BK5/OixADMXaHQ58M5k9xTnDQbzdkq7R8KPMQUQ/lqN5HSUDuoG1/aUTvaYCB MnMhjYusirGVE/LSgpFINzmEVBgIbRYwCBtFzFWRka5GN1E257kSWOFRFhVCvYAT1DZT 55rHqPwLUjPwbEPq1IU/G7LKiHHTmbu1SNdIGUsfCx39ztu3QafcvceWYCExWaPHGFXm 2RW2bKzt1jzGvzHCKw88VrnVAukvtlnq9uGDHi4E1UQkI/gAPZ3m8p+y2RnClovCLrA8 /YrwaocxVjU8QfBL6Wm+us4uFIViwbnX8Q3gZVu6ZxKpBcqKq46fEN+hx+UKAwzz1gFE TKcg== X-Forwarded-Encrypted: i=1; AJvYcCVXjNFbh/FqffA3E5H0fLWWomdINQR93XLJBKOTPg8IaIuKazCEquaupnKW06QFRgScuoZauSpxOqI7sO0=@vger.kernel.org X-Gm-Message-State: AOJu0YzOsVnZHklGZmyV1fyv0P+9v9VB/YP1rhcz2Ko+N4y2MBh6rS36 WDyfL6xL36ZKpy0bo9Sxsjqmmt04yt1GBywbDyjcF5MidcOVqELCZL+J X-Gm-Gg: ASbGncvybqqRO1UOY0XeKQ/XCJf4oGvqwBYMiDdMzLOLV0lgPTQoiODqBgBqdCzmn8b QpR95EGSfd25AqJnRFLKTe56sBsOy1GXifFaR828uktad+34FqcwqpHZV3EAlQ38jdemT0SK1dU 2tp9cjjCmcbJ/hdpRmnxELU79LCG0ZQYQ3mkAtjeX5aMQmcBUbZiJnA4lXP9J0I2koOJKDQM9fX 6w+RthdHP6f4LI+Q5CEgvGkgT7T4IljycFEUGA9HYg/2cumfVP8Nb92pz0jBvso0o6g3WZmj9hD L1r43wwClQySMsGHXZrXFOlyPJQe0Q0QZjMpsOfz1sg4HFFp+a8suUmYEkwRLbOmpVQYccp+G8M ImRt6/7bwOgTgU48b2FUd7PCEZg== X-Google-Smtp-Source: AGHT+IGoWn0EzUfWZg7qbR8GjlLBISJjayqiLGwRwZ01kRQx/zgS9Ft3sPxThIfe1JhSI6idF2vlyg== X-Received: by 2002:a17:907:1b29:b0:afa:1b3f:37a2 with SMTP id a640c23a62f3a-afe295d2b84mr583479466b.37.1755953022331; Sat, 23 Aug 2025 05:43:42 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe49a1f5a6sm165076466b.111.2025.08.23.05.43.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 05:43:42 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 09/14] staging: rtl8723bs: remove bPseudoTest from Hal_GetEfuseDefinition Date: Sat, 23 Aug 2025 14:43:16 +0200 Message-ID: <20250823124321.485910-10-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250823124321.485910-1-straube.linux@gmail.com> References: <20250823124321.485910-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The bPseudoTEst parameter is not used in Hal_GetEfuseDefinition. Remove the unused parameter and adjust the function calls. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 6 +++--- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 13 ++++++------- drivers/staging/rtl8723bs/include/hal_intf.h | 2 +- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/r= tl8723bs/core/rtw_efuse.c index 25ec7278b815..9d065721c28a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -123,7 +123,7 @@ u16 Address) u32 k =3D 0; u16 contentLen =3D 0; =20 - Hal_GetEfuseDefinition(Adapter, EFUSE_WIFI, TYPE_EFUSE_REAL_CONTENT_LEN, = (void *)&contentLen, false); + Hal_GetEfuseDefinition(Adapter, EFUSE_WIFI, TYPE_EFUSE_REAL_CONTENT_LEN, = (void *)&contentLen); =20 if (Address < contentLen) {/* E-fuse 512Byte */ /* Write E-fuse Register address bit0~7 */ @@ -257,7 +257,7 @@ static void Efuse_ReadAllMap(struct adapter *padapter, = u8 efuseType, u8 *Efuse) =20 Efuse_PowerSwitch(padapter, false, true); =20 - Hal_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *)&= mapLen, false); + Hal_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *)&= mapLen); =20 Hal_ReadEFuse(padapter, efuseType, 0, mapLen, Efuse); =20 @@ -333,7 +333,7 @@ void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8= efuseType) struct eeprom_priv *pEEPROM =3D GET_EEPROM_EFUSE_PRIV(padapter); u16 mapLen =3D 0; =20 - Hal_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *)&= mapLen, false); + Hal_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *)&= mapLen); =20 if (pEEPROM->bautoload_fail_flag) memset(pEEPROM->efuse_eeprom_data, 0xFF, mapLen); diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 5355bb80b676..af61730cff14 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -494,8 +494,7 @@ void Hal_GetEfuseDefinition( struct adapter *padapter, u8 efuseType, u8 type, - void *pOut, - bool bPseudoTest + void *pOut ) { switch (type) { @@ -741,7 +740,7 @@ static void hal_ReadEFuse_WiFi( pbuf[i] =3D efuseTbl[_offset+i]; =20 /* Calculate Efuse utilization */ - Hal_GetEfuseDefinition(padapter, EFUSE_WIFI, TYPE_AVAILABLE_EFUSE_BYTES_T= OTAL, &total, false); + Hal_GetEfuseDefinition(padapter, EFUSE_WIFI, TYPE_AVAILABLE_EFUSE_BYTES_T= OTAL, &total); used =3D eFuse_Addr - 1; efuse_usage =3D (u8)((used*100)/total); =20 @@ -780,7 +779,7 @@ static void hal_ReadEFuse_BT( /* 0xff will be efuse default value instead of 0x00. */ memset(efuseTbl, 0xFF, EFUSE_BT_MAP_LEN); =20 - Hal_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_BAN= K, &total, false); + Hal_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_BAN= K, &total); =20 for (bank =3D 1; bank < 3; bank++) { /* 8723b Max bake 0~2 */ if (hal_EfuseSwitchToBank(padapter, bank, false) =3D=3D false) @@ -843,7 +842,7 @@ static void hal_ReadEFuse_BT( /* */ /* Calculate Efuse utilization. */ /* */ - Hal_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_TOT= AL, &total, false); + Hal_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_TOT= AL, &total); used =3D (EFUSE_BT_REAL_BANK_CONTENT_LEN*(bank-1)) + eFuse_Addr - 1; efuse_usage =3D (u8)((used*100)/total); =20 @@ -952,7 +951,7 @@ static u16 hal_EfuseGetCurrentSize_WiFi( =20 error: /* report max size to prevent write efuse */ - Hal_GetEfuseDefinition(padapter, EFUSE_WIFI, TYPE_AVAILABLE_EFUSE_BYTES_T= OTAL, &efuse_addr, bPseudoTest); + Hal_GetEfuseDefinition(padapter, EFUSE_WIFI, TYPE_AVAILABLE_EFUSE_BYTES_T= OTAL, &efuse_addr); =20 exit: =20 @@ -984,7 +983,7 @@ static u16 hal_EfuseGetCurrentSize_BT(struct adapter *p= adapter, u8 bPseudoTest) efuse_addr =3D (u16)((btusedbytes%EFUSE_BT_REAL_BANK_CONTENT_LEN)); startBank =3D (u8)(1+(btusedbytes/EFUSE_BT_REAL_BANK_CONTENT_LEN)); =20 - Hal_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_BAN= K, &retU2, bPseudoTest); + Hal_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_BAN= K, &retU2); =20 for (bank =3D startBank; bank < 3; bank++) { if (hal_EfuseSwitchToBank(padapter, bank, bPseudoTest) =3D=3D false) diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index 2e97a918445c..fbf0b01780ea 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -269,7 +269,7 @@ void Hal_EfusePowerSwitch(struct adapter *padapter, u8 = bWrite, u8 PwrState); void Hal_ReadEFuse(struct adapter *padapter, u8 efuseType, u16 _offset, u16 _size_byte, u8 *pbuf); void Hal_GetEfuseDefinition(struct adapter *padapter, u8 efuseType, u8 typ= e, - void *pOut, bool bPseudoTest); + void *pOut); u16 Hal_EfuseGetCurrentSize(struct adapter *padapter, u8 efuseType, bool b= PseudoTest); void hal_notch_filter_8723b(struct adapter *adapter, bool enable); #endif /* __HAL_INTF_H__ */ --=20 2.51.0 From nobody Fri Oct 3 21:53:26 2025 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAF7226563F for ; Sat, 23 Aug 2025 12:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953027; cv=none; b=ZEe6CVx5tMbjtoR2RIL0PfP+qZnYc+tY52Yv3UY602hzboYhHFtqGBqNn1smi96vsIvj7Cej/W/UMm8AG0CErbAfdQZssIV7vk30M4hXaz85TNzkb7b4f0Rnjq3H1GUV/TpiGaRTGBXcRCqW1I2hn1pn3BdQESk+QVF8uiB2cuw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953027; c=relaxed/simple; bh=h6WCjiBW+6Abga5OJ3bJ1nYtqaNiePuXBUvjxd/SJ2w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uK8w/N2g4A8p61pgf1Omu74IkcJLCwV3XePxO151zuA1chn27G2cZpLXmVtsX4G/ijoDZr1EyBVqh1w8CokzsJ6VAinB8MKAZZrfSICup/wYhWCBu+RwoIz8M72nH1+P+D2Qv8KGPwIEwDLEZom0/aq+1ZYd/Jqa1VJHrozAqgE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DzGPwrt1; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DzGPwrt1" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-afcb7322da8so445824066b.0 for ; Sat, 23 Aug 2025 05:43:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755953023; x=1756557823; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wlbqi7N+RKHadOcJXN6QLsUwNa0JB43/lNVhOpXVRbM=; b=DzGPwrt1uCNnb5eRBHR3S/IqNorWPffqx2GINDYY7FAKIJ5EEYwAH7lVTiAAeoFp9j kz6QEw8s2vA2UVgIXMEsRzLVVKfMFA7+c42iFUyq2DU3FPCLf/TPDZbcSzGTy42hOmdu ElIeU01lM9aSUczcrFhJ9V4e3Y7MGJUoiPKhwn9u/rZ5UAM0Em+RMM+3MuQtceCcTlYp AyivYHt0Je/GHA6w/Zi9KNSZniR9ZUAk5VpILyRW3ZIZ3LdNfStS2gDh1xYaKE8j/lIB 55maXRT2NhyAPSea76yW9uauTplN1X/fkXhGjAyHzqlXVA8u7xqEyaqp51wV9r1GBkYk bKtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755953023; x=1756557823; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wlbqi7N+RKHadOcJXN6QLsUwNa0JB43/lNVhOpXVRbM=; b=CUN5oemZCTFivN4S808xzXI93J6FdZfugwmejGC1Z5nYGdnlYoL8W/mXZ1Oi/gVMbJ z9SOHGqZXz5oms1TnLGUsl9btQelh8XlMBzF088K6bAGSjx8mONNL+8UufEX6w7fmp0h g5p2VLPEkuzvtYk1d8lwxFRLosLGXEmrvSuTvPBz23HzW9e4QZdNTitWEDplr9iICssW 58VdTUtbVdrETqHylj/i4ExJzEiykUpu+/nKrabvOWSNtlAIYR3/+WO+q0aZ5BI5aVqx YUfhSn0MZofmwDNFoaUQeZ8gGe7rNSEcp4zg8w1g9py9LsHnL0yHDOd5oywLawDmIUqU plyg== X-Forwarded-Encrypted: i=1; AJvYcCVTWOZb2IcOZQDeHxSvjrPBs+HlsVIws9MsWx8DBP5HfjHAGFjcrBXW+yojm5uqhnOKQP3zEa5E6H7gIrs=@vger.kernel.org X-Gm-Message-State: AOJu0YzSf+kl+S0kXF7+IcworeNi1kFqKfIin/kFq2fXmoytFX5nsKxr C1aBMjP129v0g9oHWn83/4qAhCVI556t/IO2OJrVnnxHqPPqMSC44R97OEq+xA== X-Gm-Gg: ASbGncu7Q//p9ju+xHRr7cq7m5lrEfGhzQn5D9q7iiZjvXSi2NWEYdHcizcQ4F7Z0VC qT8JKtQ7C6GYLWTniiD0LA8UmY6/8faRRkzp370Ft4w1KtpXm3efjZhQR4elZT6bgEF8VMJVsnQ hpEIZX3O39kTQ+/ba+4x94dCHlgvk2qm+ovS2s7gbtscurdxEClvPZkb/sKjux0EI/az7M+uIe8 +WgAh0Wcfq0IAAFnuJo2zmm+PDbjm5N55EvU8hzAom8J7QUr5nSTE0Zh4+u3aU5uJa2DMKeAjZY 8HpFnfG6yG/QrTPxBX3hkCNjKfIdr6ZG5JZmzc9iY6ILEj+vsdSgdaNv+7x/xovd9t2gN02OsRe EX9mABrkC8iBiSLLfrhF5DACiFQ== X-Google-Smtp-Source: AGHT+IFEWdtvLaf9Gdw4oi4jZxvxE286Zlt9Kn5xDdd7umB2HylCgAGuay9Q64yUjphtsNAfkce+7A== X-Received: by 2002:a17:907:94cf:b0:af9:c1f7:802 with SMTP id a640c23a62f3a-afe295d2502mr640932766b.31.1755953023059; Sat, 23 Aug 2025 05:43:43 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe49a1f5a6sm165076466b.111.2025.08.23.05.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 05:43:42 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 10/14] staging: rtl8723bs: remove Hal_EfuseGetCurrentSize Date: Sat, 23 Aug 2025 14:43:17 +0200 Message-ID: <20250823124321.485910-11-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250823124321.485910-1-straube.linux@gmail.com> References: <20250823124321.485910-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function Hal_EfuseGetCurrentSize is not used in the driver code, remove it to get rid of dead code. As Hal_EfuseGetCurrentSize is the only caller of hal_EfuseGetCurrentSize_WiFi and hal_EfuseGetCurrentSize_BT we can remove these two functions as well. Signed-off-by: Michael Straube --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 184 ------------------ drivers/staging/rtl8723bs/include/hal_intf.h | 1 - 2 files changed, 185 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index af61730cff14..0679f77e3498 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -867,190 +867,6 @@ void Hal_ReadEFuse( hal_ReadEFuse_BT(padapter, _offset, _size_byte, pbuf); } =20 -static u16 hal_EfuseGetCurrentSize_WiFi( - struct adapter *padapter, bool bPseudoTest -) -{ -#ifdef HAL_EFUSE_MEMORY - struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - struct efuse_hal *pEfuseHal =3D &pHalData->EfuseHal; -#endif - u16 efuse_addr =3D 0; - u16 start_addr =3D 0; /* for debug */ - u8 hworden =3D 0; - u8 efuse_data, word_cnts =3D 0; - u32 count =3D 0; /* for debug */ - - - if (bPseudoTest) { -#ifdef HAL_EFUSE_MEMORY - efuse_addr =3D (u16)pEfuseHal->fakeEfuseUsedBytes; -#else - efuse_addr =3D (u16)fakeEfuseUsedBytes; -#endif - } else - rtw_hal_get_hwreg(padapter, HW_VAR_EFUSE_BYTES, (u8 *)&efuse_addr); - - start_addr =3D efuse_addr; - - /* switch bank back to bank 0 for later BT and wifi use. */ - hal_EfuseSwitchToBank(padapter, 0, bPseudoTest); - - count =3D 0; - while (AVAILABLE_EFUSE_ADDR(efuse_addr)) { - if (efuse_OneByteRead(padapter, efuse_addr, &efuse_data, bPseudoTest) = =3D=3D false) - goto error; - - if (efuse_data =3D=3D 0xFF) - break; - - if ((start_addr !=3D 0) && (efuse_addr =3D=3D start_addr)) { - count++; - - efuse_data =3D 0xFF; - if (count < 4) { - /* try again! */ - - if (count > 2) { - /* try again form address 0 */ - efuse_addr =3D 0; - start_addr =3D 0; - } - - continue; - } - - goto error; - } - - if (EXT_HEADER(efuse_data)) { - efuse_addr++; - efuse_OneByteRead(padapter, efuse_addr, &efuse_data, bPseudoTest); - if (ALL_WORDS_DISABLED(efuse_data)) - continue; - - hworden =3D efuse_data & 0x0F; - } else { - hworden =3D efuse_data & 0x0F; - } - - word_cnts =3D Efuse_CalculateWordCnts(hworden); - efuse_addr +=3D (word_cnts*2)+1; - } - - if (bPseudoTest) { -#ifdef HAL_EFUSE_MEMORY - pEfuseHal->fakeEfuseUsedBytes =3D efuse_addr; -#else - fakeEfuseUsedBytes =3D efuse_addr; -#endif - } else - rtw_hal_set_hwreg(padapter, HW_VAR_EFUSE_BYTES, (u8 *)&efuse_addr); - - goto exit; - -error: - /* report max size to prevent write efuse */ - Hal_GetEfuseDefinition(padapter, EFUSE_WIFI, TYPE_AVAILABLE_EFUSE_BYTES_T= OTAL, &efuse_addr); - -exit: - - return efuse_addr; -} - -static u16 hal_EfuseGetCurrentSize_BT(struct adapter *padapter, u8 bPseudo= Test) -{ -#ifdef HAL_EFUSE_MEMORY - struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - struct efuse_hal *pEfuseHal =3D &pHalData->EfuseHal; -#endif - u16 btusedbytes; - u16 efuse_addr; - u8 bank, startBank; - u8 hworden =3D 0; - u8 efuse_data, word_cnts =3D 0; - u16 retU2 =3D 0; - - if (bPseudoTest) { -#ifdef HAL_EFUSE_MEMORY - btusedbytes =3D pEfuseHal->fakeBTEfuseUsedBytes; -#else - btusedbytes =3D fakeBTEfuseUsedBytes; -#endif - } else - rtw_hal_get_hwreg(padapter, HW_VAR_EFUSE_BT_BYTES, (u8 *)&btusedbytes); - - efuse_addr =3D (u16)((btusedbytes%EFUSE_BT_REAL_BANK_CONTENT_LEN)); - startBank =3D (u8)(1+(btusedbytes/EFUSE_BT_REAL_BANK_CONTENT_LEN)); - - Hal_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_BAN= K, &retU2); - - for (bank =3D startBank; bank < 3; bank++) { - if (hal_EfuseSwitchToBank(padapter, bank, bPseudoTest) =3D=3D false) - /* bank =3D EFUSE_MAX_BANK; */ - break; - - /* only when bank is switched we have to reset the efuse_addr. */ - if (bank !=3D startBank) - efuse_addr =3D 0; - - while (AVAILABLE_EFUSE_ADDR(efuse_addr)) { - if (efuse_OneByteRead(padapter, efuse_addr, - &efuse_data, bPseudoTest) =3D=3D false) - /* bank =3D EFUSE_MAX_BANK; */ - break; - - if (efuse_data =3D=3D 0xFF) - break; - - if (EXT_HEADER(efuse_data)) { - efuse_addr++; - efuse_OneByteRead(padapter, efuse_addr, &efuse_data, bPseudoTest); - - if (ALL_WORDS_DISABLED(efuse_data)) { - efuse_addr++; - continue; - } - - hworden =3D efuse_data & 0x0F; - } else { - hworden =3D efuse_data & 0x0F; - } - - word_cnts =3D Efuse_CalculateWordCnts(hworden); - /* read next header */ - efuse_addr +=3D (word_cnts*2)+1; - } - - /* Check if we need to check next bank efuse */ - if (efuse_addr < retU2) - break; /* don't need to check next bank. */ - } - - retU2 =3D ((bank-1)*EFUSE_BT_REAL_BANK_CONTENT_LEN)+efuse_addr; - if (bPseudoTest) { - pEfuseHal->fakeBTEfuseUsedBytes =3D retU2; - } else { - pEfuseHal->BTEfuseUsedBytes =3D retU2; - } - - return retU2; -} - -u16 Hal_EfuseGetCurrentSize( - struct adapter *padapter, u8 efuseType, bool bPseudoTest -) -{ - u16 ret =3D 0; - - if (efuseType =3D=3D EFUSE_WIFI) - ret =3D hal_EfuseGetCurrentSize_WiFi(padapter, bPseudoTest); - else - ret =3D hal_EfuseGetCurrentSize_BT(padapter, bPseudoTest); - - return ret; -} - static struct hal_version ReadChipVersion8723B(struct adapter *padapter) { u32 value32; diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index fbf0b01780ea..4fe48cccb889 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -270,6 +270,5 @@ void Hal_ReadEFuse(struct adapter *padapter, u8 efuseTy= pe, u16 _offset, u16 _size_byte, u8 *pbuf); void Hal_GetEfuseDefinition(struct adapter *padapter, u8 efuseType, u8 typ= e, void *pOut); -u16 Hal_EfuseGetCurrentSize(struct adapter *padapter, u8 efuseType, bool b= PseudoTest); void hal_notch_filter_8723b(struct adapter *adapter, bool enable); #endif /* __HAL_INTF_H__ */ --=20 2.51.0 From nobody Fri Oct 3 21:53:26 2025 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C8A6266EF1 for ; Sat, 23 Aug 2025 12:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953028; cv=none; b=i97XOLsRy+B78nDog/o6bbRttQz9CxoZatOrxemkfKWV1EjyjiSJeDaPiRuSQiV6s0LfLq3osKw2TsWSjuHxxBLpcLWN1PWZ0BdPN4GcOikaGVNA5mamyAGrdRoExmC3832Isvd3Wk4X+hZGlOALIGAFZWuCawYxpcTUcR5YNLY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953028; c=relaxed/simple; bh=EHd+pho2CKEgo1TnShr+E4CGerzPl5OLtXmFsDyNtVA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rZ/6XtOTdnPq4vE/CWYMt/heywpceIKX85zm61HEpkDHFz9s4RZv45GbpmHPd77R5zequ8PubHUNqhCZarmPU8UqdCVTqTtNbmENl3G53bIDG0KbjrpXfp0JyFljrVv/21Ht5oYm3MIdcHtSJrbugytN1BhnoQgJ/rvZtxclVEc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dM9P3J75; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dM9P3J75" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-afcb7acfde3so449098966b.3 for ; Sat, 23 Aug 2025 05:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755953024; x=1756557824; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xBzxzKnHxbIaunAwDeVnqD0gBKox3dXJJ/Rscg6vwsQ=; b=dM9P3J75uZOo6fm3sJI0PZW1bANL1fNHDDmJcc3a3pnuwd86avzmLbr0s9r6RIXqdu WCXmUnSDcC2i9m0Py1BD1HM39h/sVoFNkyKf+p41qpzSA5+nl/LtOQHUKmOINeQCGrQ/ A4ihrKFY2segW2fOwNCt6V+RkC1SMgsjPmPG/GEC7dtybTZiqTWqwpAPCjnB8lQm6KZc ZyLwRyCRXwecVdUF6m8P1qR1I6OPji+1nx1+/hiw1d7G3fiVWCLBNdy/gR15Jayn3EZ/ 4SyNnxri+3tASx9rcBD8Q13d3Pt0Q2qU0oVjEVqYtHPSGIUfFRc8GWAewsB8QsxEn/BS DT+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755953024; x=1756557824; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xBzxzKnHxbIaunAwDeVnqD0gBKox3dXJJ/Rscg6vwsQ=; b=RgxPXWBwP9JgTG19iZB1NxSInU21+99tSKsIp6Yl1K+RUAlUDFhcyo2+fa4//7sz+b icTfTEIT8i8b/0oOKuM6MRHVfS6ogKDGiKlFdYsqo4MZxRBt1L3p2eYgjv8Gv4fMfGqo eKIEHfnhoeJcbUpRo3zMxuF/1NdbUw7ZMU4GirPS34QQuPXwZAzpv8FYYEVm+YjC6OZR cyVqcIT/7YYkrzEWh9lKXgIM6a/HAmiNjYzkqldX+ZFPTKvilGEn05ZGHDkkucOAhECv tXI4C0aJHgBenkvQvil/O5+vcYBDkNCNnu54uDQo/wBU5CfCTGdXIaAB7gT58sxRPvl9 nn5w== X-Forwarded-Encrypted: i=1; AJvYcCXaeH3kkAM7fgESEAzTTX8ACt/uHbIWecAFzrpwnovuqutKlptSiA+8aKfRY8tTqkeIAMTgKx2Li5t6eQQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywf0if9i1rJO2f5Ha689jbflpnq/bcHUZEZzTlP/q3Xo2lN1fyy Ytttxeaa+JDPaX2gK/AwYpdwefnnsG910NqVGeZeoxExIwUkuXt2Wufv X-Gm-Gg: ASbGncuD9vqFregxF84EhXGLXUNIYCJGwp1U8DZUbPpjCRRIYPtNYuhQPA4Ykzl9N7E krc1XRm2iNNPQdmUEpocF9megarm+gKidUdTqj/RSbJKajHrYRqRelYO9/s4l2ae6kO+WN6dyRG bwdhzXJdIkfwU/0M+M5H+VrBhUPnGr15hMrrLn1dNiEokQv+XRI0Cznx5p8Lp1lbdxfWb5tUWks TzYvja1GSzxCAA2kTds2wItVlcvDcWzQHCypjg8TJQUl7cmAP1E4D0VvF71h8L0T5flfMZGtrzF /Ls0NRqUgdbCitsAauE/eXc3ZoW0CtRa9SyWNveyipizyL+oFFQvd/OowpoIOJBjnS/oM8iGkpN lNU4h5BBH1ZjiBbJ5VAe56juUNw== X-Google-Smtp-Source: AGHT+IGOPYK8nbUxDZ882SzO7ZNhbK6L59vKLT7JZZ2ydjpaNIC9KyWvkjge3qksvdjnHlfHLmfpqg== X-Received: by 2002:a17:907:ea8:b0:afd:e687:d280 with SMTP id a640c23a62f3a-afe295d7033mr515436866b.44.1755953023654; Sat, 23 Aug 2025 05:43:43 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe49a1f5a6sm165076466b.111.2025.08.23.05.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 05:43:43 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 11/14] staging: rtl8723bs: remove bPseudoTest from hal_EfuseSwitchToBank Date: Sat, 23 Aug 2025 14:43:18 +0200 Message-ID: <20250823124321.485910-12-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250823124321.485910-1-straube.linux@gmail.com> References: <20250823124321.485910-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function hal_EfuseSwitchToBank is always called with bPseudoTest set to false. Remove the pPseudoTest parameter and reomve resulting dead code to reduce code complexity. Signed-off-by: Michael Straube --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 62 +++++++------------ 1 file changed, 24 insertions(+), 38 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 0679f77e3498..014d94894de9 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -445,47 +445,33 @@ void rtl8723b_InitializeFirmwareVars(struct adapter *= padapter) /* Efuse related code */ /* */ static u8 hal_EfuseSwitchToBank( - struct adapter *padapter, u8 bank, bool bPseudoTest + struct adapter *padapter, u8 bank ) { u8 bRet =3D false; u32 value32 =3D 0; -#ifdef HAL_EFUSE_MEMORY - struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - struct efuse_hal *pEfuseHal =3D &pHalData->EfuseHal; -#endif =20 - - if (bPseudoTest) { -#ifdef HAL_EFUSE_MEMORY - pEfuseHal->fakeEfuseBank =3D bank; -#else - fakeEfuseBank =3D bank; -#endif - bRet =3D true; - } else { - value32 =3D rtw_read32(padapter, EFUSE_TEST); - bRet =3D true; - switch (bank) { - case 0: - value32 =3D (value32 & ~EFUSE_SEL_MASK) | EFUSE_SEL(EFUSE_WIFI_SEL_0); - break; - case 1: - value32 =3D (value32 & ~EFUSE_SEL_MASK) | EFUSE_SEL(EFUSE_BT_SEL_0); - break; - case 2: - value32 =3D (value32 & ~EFUSE_SEL_MASK) | EFUSE_SEL(EFUSE_BT_SEL_1); - break; - case 3: - value32 =3D (value32 & ~EFUSE_SEL_MASK) | EFUSE_SEL(EFUSE_BT_SEL_2); - break; - default: - value32 =3D (value32 & ~EFUSE_SEL_MASK) | EFUSE_SEL(EFUSE_WIFI_SEL_0); - bRet =3D false; - break; - } - rtw_write32(padapter, EFUSE_TEST, value32); + value32 =3D rtw_read32(padapter, EFUSE_TEST); + bRet =3D true; + switch (bank) { + case 0: + value32 =3D (value32 & ~EFUSE_SEL_MASK) | EFUSE_SEL(EFUSE_WIFI_SEL_0); + break; + case 1: + value32 =3D (value32 & ~EFUSE_SEL_MASK) | EFUSE_SEL(EFUSE_BT_SEL_0); + break; + case 2: + value32 =3D (value32 & ~EFUSE_SEL_MASK) | EFUSE_SEL(EFUSE_BT_SEL_1); + break; + case 3: + value32 =3D (value32 & ~EFUSE_SEL_MASK) | EFUSE_SEL(EFUSE_BT_SEL_2); + break; + default: + value32 =3D (value32 & ~EFUSE_SEL_MASK) | EFUSE_SEL(EFUSE_WIFI_SEL_0); + bRet =3D false; + break; } + rtw_write32(padapter, EFUSE_TEST, value32); =20 return bRet; } @@ -692,7 +678,7 @@ static void hal_ReadEFuse_WiFi( memset(efuseTbl, 0xFF, EFUSE_MAX_MAP_LEN); =20 /* switch bank back to bank 0 for later BT and wifi use. */ - hal_EfuseSwitchToBank(padapter, 0, false); + hal_EfuseSwitchToBank(padapter, 0); =20 while (AVAILABLE_EFUSE_ADDR(eFuse_Addr)) { efuse_OneByteRead(padapter, eFuse_Addr++, &efuseHeader, false); @@ -782,7 +768,7 @@ static void hal_ReadEFuse_BT( Hal_GetEfuseDefinition(padapter, EFUSE_BT, TYPE_AVAILABLE_EFUSE_BYTES_BAN= K, &total); =20 for (bank =3D 1; bank < 3; bank++) { /* 8723b Max bake 0~2 */ - if (hal_EfuseSwitchToBank(padapter, bank, false) =3D=3D false) + if (hal_EfuseSwitchToBank(padapter, bank) =3D=3D false) goto exit; =20 eFuse_Addr =3D 0; @@ -833,7 +819,7 @@ static void hal_ReadEFuse_BT( } =20 /* switch bank back to bank 0 for later BT and wifi use. */ - hal_EfuseSwitchToBank(padapter, 0, false); + hal_EfuseSwitchToBank(padapter, 0); =20 /* Copy from Efuse map to output pointer memory!!! */ for (i =3D 0; i < _size_byte; i++) --=20 2.51.0 From nobody Fri Oct 3 21:53:26 2025 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDA6026B771 for ; Sat, 23 Aug 2025 12:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953029; cv=none; b=D8wELKxk9jNNyAQGgwUTYgN2tldsFayGR5SISbaFHD5Qo5HOOxCYBADRGENbeS2yE6smFD7zDi8n359MFknR6va24JK29lv8/RALR4gyfSJ4y6IcLPm3TT0CTH0FE62o4+BVGiQh1lBo2mv2T4e+AuYOqgAxfATVMp5FTz9ifuI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953029; c=relaxed/simple; bh=IanlrOwnnjBBrz4JaH6rwyvteh8W9IK5cImbmNuzYw8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cghtzKwTiK+aEsVh+uxmTr4cUXlSpISwhlsYrQ3MCum84F3PXjT8hK49+yq+ERtBJtY1+Ef+f0oCmR1/gZQ5AN5R154UC3/7NYLfE/SjAzSEvfPtPkzKXTH25YFFX02ymme0nTCjjcxbp+1koWNyWXavruHX4MNtco2KmwuCFL8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U/6hYafg; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U/6hYafg" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-afcb78da8a7so448943566b.1 for ; Sat, 23 Aug 2025 05:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755953024; x=1756557824; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BlpWMFNb27oGthpW/T6mneIPKbt2sHdUQYK8r4ZWK0g=; b=U/6hYafgdZ+wGYW29H6LmIK/GraWugBuW/hdBcJydLAuwC4Nrm7wSnB1v4bIh+oX3t AokQngqKUl8EluhoJcEfEY048QlaneD3PuQhXvtJowr7FTCBa3dP9SHQth0VIu4JAAdo Omc4qnNX/4WVFexrZROxGNvrs72TcYi6Anjmq35PgsIIYpWPrCdcWkZIKT/gpcySdxOS YuT5T5ySM1yw2GjrKU1FMPhovam2UC/YTYQ8/kkekibJiSiXq6pHAaH6k/xwLRk3A/vX B6ZmjS3eXuTS2tgpLSDCanNkNhawO61HyA4pXPbn/sOQkK0zYMQy2Bxa9/OT1HGXyeg8 JHEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755953024; x=1756557824; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BlpWMFNb27oGthpW/T6mneIPKbt2sHdUQYK8r4ZWK0g=; b=Sr7iknPbYUusVFp4yThIhE0l6Ueg6sqqtWuAErpwu6vDxAcfqG2zidhIoyDdcekaX7 K4n6l1vuyBxFvfScOx+FKYsmgbkGRQy2jurY4hivGQaOGFCMqhZFVFGfuFqU7edFssDB 3OcFZZATOqfnvwgDwHOtVGq3LXOe5rNgF6sp6lmyNSq9S4tlz7dt7274fADHbRLHkCMF 3h5sEKwXDHb8JqTGawPbxAtQU2kfZK65t/fU4cc/6bm0cC4Cc04UQtP/kO6xRtEoBX23 cYqNrch2SB1L87eNasyfRsrwYQCFCG9CZKYwQq4SY1vNKxaOKDgNXFHJTury1LEir0zL i38Q== X-Forwarded-Encrypted: i=1; AJvYcCWLVwZCHqtr29z/yJCNRAiE7m0dZieTGgCYmr6kluh/sOfWBq0IB4Upr4cFiti67ywyqo+MOknO74P7eUM=@vger.kernel.org X-Gm-Message-State: AOJu0YzascGNHhFZD695eaXPtD5n4govdo+IRRZpdhMHsWaCDDtSmeOG ugWNgREuIarDU+l7gnH6gQqlTPMNay2EuxaZ9Mdrtmadq6Z6mJ+WEZ3C X-Gm-Gg: ASbGncvFasa25LByXd9BbopAdM4VMlb4DrpXVDdGe/JcJ8RcbvFN9+PtRK9GMUeWI7a UN8Z3X3mUzyYU2DBfmMPZr2+p/dlZjzsMyk0JSqR8v1hbCTOmXy8ZNArK+OB2koOEP1jHaATOzY KxCVF4qre4EpRnzINp4OO4JNKi2geq8hyj5BZesm6g6MywKrbyABSmtnmxZxEd84Q0BWpJXlHSx yWnJTVznXS8J+dZY+aFUDzsZCZy9V5X8AK0rGnUYmd2dk9R6l5IgJu59e5ozMshcc+/XQUh7HqU 4K4z7yEUOS9T0YLXi0ZO0lIdv1ZUA3O1Z2y3S4ISU0ZN/SUELK9KQrOaf0L1mWDjqY8qMwMJFJb GCmKv/1G9FUghdUBH4ye1RZ6VGA== X-Google-Smtp-Source: AGHT+IHaVisegjQ9un4mzCp0ZhRFxVs2znau0+RrxU5O9zNvz+u1VqtORNXI6y8NK2V/NUg74HclLQ== X-Received: by 2002:a17:907:96a9:b0:ad8:9e80:6bc3 with SMTP id a640c23a62f3a-afe28ffcdf4mr585948666b.1.1755953024284; Sat, 23 Aug 2025 05:43:44 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe49a1f5a6sm165076466b.111.2025.08.23.05.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 05:43:43 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 12/14] staging: rtl8723bs: clean up variable initializations Date: Sat, 23 Aug 2025 14:43:19 +0200 Message-ID: <20250823124321.485910-13-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250823124321.485910-1-straube.linux@gmail.com> References: <20250823124321.485910-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After previous cleanup patches the variable initializations in hal_EfuseSwitchToBank are messed up a little, but were left as-is to make reviewing easier. For example bRet is initialized to false and immediately set to true. This patch cleans up the variable initializations. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 014d94894de9..ab30d2598825 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -448,11 +448,9 @@ static u8 hal_EfuseSwitchToBank( struct adapter *padapter, u8 bank ) { - u8 bRet =3D false; - u32 value32 =3D 0; + u8 bRet =3D true; + u32 value32 =3D rtw_read32(padapter, EFUSE_TEST); =20 - value32 =3D rtw_read32(padapter, EFUSE_TEST); - bRet =3D true; switch (bank) { case 0: value32 =3D (value32 & ~EFUSE_SEL_MASK) | EFUSE_SEL(EFUSE_WIFI_SEL_0); --=20 2.51.0 From nobody Fri Oct 3 21:53:26 2025 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C93362641D8 for ; Sat, 23 Aug 2025 12:43:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953029; cv=none; b=gC4LXVtKdBtaojZi+DuM0u+xJPLnp3FDZKTklF/W3dXiAZF0+KtuirefvxQpRqCgWGJ3hOkf9C5TO+swEaGQc1TVmri7EpsWuooWW7YqHOerDbdN2g8baHC43BD7pysonj4XTgfnf3Ii1/0NzAWUFP5ut2ov+Sgn8MxdwC/woGk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953029; c=relaxed/simple; bh=1iD4N72zpEvrDT/vkabmBpqrXAD7v9kigY0P6Ya3BJU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OuiSnYnzJp6ZLwkJnd3SWbWaVscVgpLnkjDENckSzWnpRwrk/pRDIZNoYJEduy9F5LUEDt/vQ8E0zHlTSCq7XNR+evg6dFalEwb4xuqK3USYJqLt+Z+o2Zoacw+EwWmf9ZOie5ljrywZfCdNQ7K7EX4GKjZ8xnYq7jGllKRIkrY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eql9XZPy; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eql9XZPy" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-6188b6f501cso3335495a12.2 for ; Sat, 23 Aug 2025 05:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755953025; x=1756557825; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/OM/rkBuH9r5TAbmD24hZvuqqZlQB7lq4axdod89JEA=; b=eql9XZPy6cAxwTIDqpq1jWZRYxOOxekBHrJU7x1TFi64RWwDj1g2vTg2O6TbfzK1IW QVZktPcmpj13Rrr6tt7Og7ux2Puvntsntgk9s7N8bEEPnisnwtl8VJPl9hk39K+9VtrX lZO5afP5gElMc8rUUfy56JB6jkuXmYpoEqEkwzNW7c91dyHowK0PFyijbDOqzmn0rth7 jlR9HTT3JljOG6ALkshVm8odSXvBMiM6mrqfwyy94s5sPbd0011A9sDSM3IkWzUxmCsj jRvhLokHFItPi+lkfy//BZZLuc86oYBwjfmeuZwRw5/NLzmLjWjakNoscWK5QY6jYd3J GQkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755953025; x=1756557825; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/OM/rkBuH9r5TAbmD24hZvuqqZlQB7lq4axdod89JEA=; b=eTMDapzBbV/5YIAN7tI3h84OkiZpV07eZvd7ojqwsB1/WqSxUmws9ur+sFfi6Qks5I iZeOENoPNN1jItNqk2Tw+hkwsi2vDuTBtb/BiV7ZKUhtvcavxy2hIbWmZARnaEifWwby gUXtJAR1f0dw0KN3cB4Qq7k+WWMqlpUFKGJAitGqvdnD2cltcvyJ3VsfCa8yMRBqrSQN 83Ja7cIN8SeQoAXlwF3XdL/+G/PbJ5DLd7lAUpGRrJLdKsfJyY07R6PtiTbWmjpcVy+n ujkpZq2GUw2BbCQ1e++yau53F7XFkux5WZNxa5C3rAq/EI82SBO9va0FuoxjddvP5j3t hwyQ== X-Forwarded-Encrypted: i=1; AJvYcCVje2BqQumW8aA/b28ZqVSYtWYbVVk5IPtjbbMFgvzwGULFfHmsEq7lUVb8tNU1TN+qyOMPHd7Wm7KeEMI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1T9WifzVRK2gT6i0ssqwBmvOd82a4egYgL5LCwI4VaNmKiA1A pXeQhEl/Se6gjze9y1KW5CEOAahyc0UiCa71Ir/agW0eSTN9ARNEc6Cv X-Gm-Gg: ASbGncsYF7P2EJwRS1SEhdDZKw5wmgSVOYH9bDZCnHfS73CJvWSkhmCURGIWk7Fz/MM bmoewrHFRMTv+ZRqFfcRiL6VqF6z/x7JuNa+BUtBconOpdDufppVL/wpB00a9ZJ5wy+3cqLKEUx pkJAvoM6V8iuJ+WkCu6LuIpETE1FGtQ9CneXSACgknF+NnEcofEntcJTb5byfhRCuCSv6MNSCzV IvHwLdtxvZ34lipS4n/G0NrfBPBkuxR+oRZfHHC3ZSFb0aa8NbOg4KXBLlBlJGCs7j3UWZa6bTo dAleNqXiYzCaL9o+q6U1NzsH5UnPag/TgkrQRYwh9I79B+KCFQzkgK0m/opp/32HcSkzQ2+EDL2 jzTrQJFAiWEh85hKEHQOAQvHolfLaMPYeIM0B X-Google-Smtp-Source: AGHT+IF+fUUJ00qonInRkhsPMbg8I8eHguAEM0CaE8rrqXu0ZRPWU8WGRNM2MArAExnDQI9PVF7R7w== X-Received: by 2002:a17:906:c10f:b0:af6:3248:62bb with SMTP id a640c23a62f3a-afe29046a6amr581207866b.30.1755953024916; Sat, 23 Aug 2025 05:43:44 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe49a1f5a6sm165076466b.111.2025.08.23.05.43.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 05:43:44 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 13/14] staging: rtl8723bs: remove bPseudoTest from efuse_OneByteRead Date: Sat, 23 Aug 2025 14:43:20 +0200 Message-ID: <20250823124321.485910-14-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250823124321.485910-1-straube.linux@gmail.com> References: <20250823124321.485910-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function efuse_OneByteRead is always called with bPseudoTest set to false. Remove the pPseudoTest parameter and reomve resulting dead code to reduce code complexity. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 18 +----------------- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 18 +++++++++--------- drivers/staging/rtl8723bs/include/rtw_efuse.h | 2 +- 3 files changed, 11 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/r= tl8723bs/core/rtw_efuse.c index 9d065721c28a..c4542e00c730 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -29,18 +29,6 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] =3D {0}; #define REG_EFUSE_CTRL 0x0030 #define EFUSE_CTRL REG_EFUSE_CTRL /* E-Fuse Control. */ =20 -static bool -Efuse_Read1ByteFromFakeContent(u16 Offset, u8 *Value) -{ - if (Offset >=3D EFUSE_MAX_HW_SIZE) - return false; - if (fakeEfuseBank =3D=3D 0) - *Value =3D fakeEfuseContent[Offset]; - else - *Value =3D fakeBTEfuseContent[fakeEfuseBank - 1][Offset]; - return true; -} - static bool Efuse_Write1ByteToFakeContent(u16 Offset, u8 Value) { @@ -158,16 +146,12 @@ u8 efuse_OneByteRead( struct adapter *padapter, u16 addr, -u8 *data, -bool bPseudoTest) +u8 *data) { u32 tmpidx =3D 0; u8 bResult; u8 readbyte; =20 - if (bPseudoTest) - return Efuse_Read1ByteFromFakeContent(addr, data); - /* <20130121, Kordan> For SMIC EFUSE specificatoin. */ /* 0x34[11]: SW force PGMEN input of efuse to high. (for the bank selecte= d by 0x34[9:8]) */ /* PHY_SetMacReg(padapter, 0x34, BIT11, 0); */ diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index ab30d2598825..94492743ea34 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -679,7 +679,7 @@ static void hal_ReadEFuse_WiFi( hal_EfuseSwitchToBank(padapter, 0); =20 while (AVAILABLE_EFUSE_ADDR(eFuse_Addr)) { - efuse_OneByteRead(padapter, eFuse_Addr++, &efuseHeader, false); + efuse_OneByteRead(padapter, eFuse_Addr++, &efuseHeader); if (efuseHeader =3D=3D 0xFF) break; =20 @@ -687,7 +687,7 @@ static void hal_ReadEFuse_WiFi( if (EXT_HEADER(efuseHeader)) { /* extended header */ offset =3D GET_HDR_OFFSET_2_0(efuseHeader); =20 - efuse_OneByteRead(padapter, eFuse_Addr++, &efuseExtHdr, false); + efuse_OneByteRead(padapter, eFuse_Addr++, &efuseExtHdr); if (ALL_WORDS_DISABLED(efuseExtHdr)) continue; =20 @@ -706,10 +706,10 @@ static void hal_ReadEFuse_WiFi( for (i =3D 0; i < EFUSE_MAX_WORD_UNIT; i++) { /* Check word enable condition in the section */ if (!(wden & (0x01<; Sat, 23 Aug 2025 12:43:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953029; cv=none; b=u5W+3Mc55qj93MCURPigpTm7Wg2ZbTRBx6GrZX3tx2rtVg+XUBoS0zhnRDLLzeelqyCL6TkDOm1XJX8DyTSHyFoZ7wGExQ0N4vPG9Pj8FeNAjyQsi1qyzu3VzNokXFq6sbs15IL9sq0no2c6NBVq3L+8xUmG5VvUSgMfXcF2dfk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755953029; c=relaxed/simple; bh=6TMKFvsgcOmBT4IWHGPu6ltkEHCP9W2kyxfMooXoo04=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q5J52goMR146R1awtxYzlPePzW7ihiWHCdQbK+dJxs6fzOfzxS/+Vss4M/1v2eIRqWlo5UDilMZo3GpLdGmfF8JjEitBCoVUGf2ECK5FqEWU0L/CVX0MAtJF7GZqwgvY/0i8a2LQM4IiahqL0WNDzYdn0fuLS57FOLgJXjF3iPs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W6NM5SkV; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W6NM5SkV" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-afcb7abfc5cso466893366b.3 for ; Sat, 23 Aug 2025 05:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755953026; x=1756557826; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VKg6tpfTSdRmNVL9oWWx5/tJnTNrLO7MU62UoNru7CE=; b=W6NM5SkVBE8autsT7I/eLaXdvlVtqeBu6WEPzM6HYX68VgZxw6r97b0b3c55CVlCL9 ByVjp7QOylUEzpLGSoL/e2gBQ0HhGA/tDZy4L2lpRBvvQ02SHHX6rMOw2jJyNa4qlcV0 p59slPh5wlU/87PL0CW2q5LGGMbE+xMk/zJ5YgjWzTIvsGmAr+bsJtdk/xLnZnA5Q0UJ 0AdG5ta/wg83hm794fFdl/XnoyvN869e5TrgSExQeuoIh2HdL3r/I+/KjWGLniljJup4 Bfcn3chBw/4uUfrDwe4rtZcWg0Oxi91OTA0UlzKbYjPL8YZXDwO2jwPOnwTLcZveFGMZ N61g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755953026; x=1756557826; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VKg6tpfTSdRmNVL9oWWx5/tJnTNrLO7MU62UoNru7CE=; b=CdxgNPb+Bq0hbhCoh4Vwiy0mTEblvnLp9lqpKn67HUbDHeGfjAQ/z5tUf75QR6ca+u 1OyjVVBXK7xECgf+3DrU0vJzFcLdi1h6fBs9bEXNN58edSe7iu0QN5HPE0+pf2c0l8Km ODpA+mD874PIbOIPbDSBleIgLTWZgipKPPQ/BP7N0IJJ7QM8U6imrs7dioNOMlBctGrw O0n9XdtfuLEGdalrx8BrzWfLZp+eJTczjrdNKgStC7g6NWiaQcqJBuJcO+CjqV7XaUpz 0njzrnKdc0KG80WMx8BtG6E4rnF2nccV3vQOvN9dr73hDBXyF3Db4KKbWMWKNGrFb+Dp DJ/w== X-Forwarded-Encrypted: i=1; AJvYcCWx6q1xxDGH6Z8+lvVkpFlYlXDMtUSLsK76+P2z5xHO4Eq6Clm3Fvy3ru1s0v5/iPN0VYIWmZoV2q0QFHg=@vger.kernel.org X-Gm-Message-State: AOJu0YxHKN6achWMCP2Ivu5f/JIEv/7Ys82cROEPwwJieV+44eQMVT1I F5GAz3msKgvBEULYf1KhXSYEeqfarYijkajk8lIx+7xSS/jB7a4nAmmw X-Gm-Gg: ASbGncvZ9xBCNLgN0iZchZrDtd+FgH6839W3Ozmkc75/319ZxCAuwmQr/yeI1QQi1Xi +0rceYrOvT5jXdgeu1v5Jcb3s4FlDDSy+oq9rM/gil2QQnCXMzT5mvOAi8n5xPnZQMNV6Uqm2g4 Nb4b8xHVdZCxxY+IJ90QNyneHo5dZmT6oPFz/e1ntLHBSFLf09X/ZXVjvlWmFSOSo6wiaKOcTWr vghOuvEjWujIYqIXrdxzvo+mFzi53KWCdZmo6xelPPgy4XeQ6W6afPHhknKPEBjOHWbwGgHSZHE aB/m6DtrMxT2F5bQzX5cBJ9sqdtxUlfHYQm9SOW4MfvN/+tDv+TZtgOLEVWaRSb5Na/ANfcT7sv zeBX71LW0yakvmNyJpVflr1QUXw== X-Google-Smtp-Source: AGHT+IG3MCS/XQ1i3zCJ1Ac6TjWBul2Y1v2qRKnCvZBiJ+c3h0j7SWN3xftK6mA1RE2UFwtjBHFnEQ== X-Received: by 2002:a17:907:6e89:b0:af9:3116:e104 with SMTP id a640c23a62f3a-afe28ffcd72mr616727166b.3.1755953025569; Sat, 23 Aug 2025 05:43:45 -0700 (PDT) Received: from tumbleweed ([95.90.184.246]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe49a1f5a6sm165076466b.111.2025.08.23.05.43.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 05:43:45 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 14/14] staging: rtl8723bs: remove efuse_OneByteWrite Date: Sat, 23 Aug 2025 14:43:21 +0200 Message-ID: <20250823124321.485910-15-straube.linux@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250823124321.485910-1-straube.linux@gmail.com> References: <20250823124321.485910-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function efuse_OneByteWrite is not used. Remove it and remove related dead code, namely the function Efuse_Write1ByteToFakeContent. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 48 ------------------- drivers/staging/rtl8723bs/include/rtw_efuse.h | 1 - 2 files changed, 49 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/r= tl8723bs/core/rtw_efuse.c index c4542e00c730..e39032b45c35 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -29,18 +29,6 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] =3D {0}; #define REG_EFUSE_CTRL 0x0030 #define EFUSE_CTRL REG_EFUSE_CTRL /* E-Fuse Control. */ =20 -static bool -Efuse_Write1ByteToFakeContent(u16 Offset, u8 Value) -{ - if (Offset >=3D EFUSE_MAX_HW_SIZE) - return false; - if (fakeEfuseBank =3D=3D 0) - fakeEfuseContent[Offset] =3D Value; - else - fakeBTEfuseContent[fakeEfuseBank - 1][Offset] =3D Value; - return true; -} - /*------------------------------------------------------------------------= ----- * Function: Efuse_PowerSwitch * @@ -183,42 +171,6 @@ u8 *data) return bResult; } =20 -/* 11/16/2008 MH Write one byte to reald Efuse. */ -u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool bP= seudoTest) -{ - u8 tmpidx =3D 0; - u8 bResult =3D false; - - if (bPseudoTest) - return Efuse_Write1ByteToFakeContent(addr, data); - - /* -----------------e-fuse reg ctrl --------------------------------- */ - /* address */ - - /* <20130227, Kordan> 8192E MP chip A-cut had better not set 0x34[11] un= til B-Cut. */ - - /* <20130121, Kordan> For SMIC EFUSE specificatoin. */ - /* 0x34[11]: SW force PGMEN input of efuse to high. (for the bank selecte= d by 0x34[9:8]) */ - /* PHY_SetMacReg(padapter, 0x34, BIT11, 1); */ - rtw_write16(padapter, 0x34, rtw_read16(padapter, 0x34) | (BIT11)); - rtw_write32(padapter, EFUSE_CTRL, 0x90600000 | ((addr << 8 | data))); - - while ((0x80 & rtw_read8(padapter, EFUSE_CTRL + 3)) && (tmpidx < 100)) { - mdelay(1); - tmpidx++; - } - - if (tmpidx < 100) - bResult =3D true; - else - bResult =3D false; - - /* disable Efuse program enable */ - PHY_SetMacReg(padapter, EFUSE_TEST, BIT(11), 0); - - return bResult; -} - /*------------------------------------------------------------------------= ----- * Function: Efuse_ReadAllMap * diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/stagin= g/rtl8723bs/include/rtw_efuse.h index 1cee7a8eedf2..5251ecc855d7 100644 --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h @@ -92,7 +92,6 @@ extern u8 fakeBTEfuseModifiedMap[]; =20 u8 Efuse_CalculateWordCnts(u8 word_en); u8 efuse_OneByteRead(struct adapter *padapter, u16 addr, u8 *data); -u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool b= PseudoTest); =20 void Efuse_PowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState); =20 --=20 2.51.0