From nobody Sat Oct 4 00:32:11 2025 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02E4A299950 for ; Fri, 22 Aug 2025 17:47:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755884857; cv=none; b=cB/7e//jH1jZjcQpzjsb4SZ8HCBgtcfeCJr6bWD/xUmbkB2jaVS9lx2Y3iedtovLs+dqTmanHFTP+REItvlIICwapcbWEjYPPStgbWdYqw9xF5TouwCx6soRKo/wTMRaBd2U9aYv1gH8V2deWkAQAogcPiEzt4f7SzbqpyvwjIA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755884857; c=relaxed/simple; bh=OYjInNuDIbxgUr95L691pkXfEg25gucGlrQ1kVE7uI0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lZ4SXaJMGLD2d9CPfmf0oYAMR0KqH0PptQtv7BtkppzBECHXtc0aMQWZIPuAsF10MM624QxntOlIF/DsRE63zIFTN1Lfv1yO2p00/Xpeq1LS95O6QcY8JQJ4NhtPURYwz/+Bo6A9vFZB/ohvDIAEaxfhZ6zdSJjb0SvruduYrGY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc.com header.i=@rivosinc.com header.b=FKwmNFPW; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc.com header.i=@rivosinc.com header.b="FKwmNFPW" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-4b297962b24so23403781cf.2 for ; Fri, 22 Aug 2025 10:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc.com; s=google; t=1755884854; x=1756489654; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1/NZ3invqjYii7VgIefIBIrdQlA4A/NoIleSlxqcTKI=; b=FKwmNFPWHkVyr6Rcfqh0/BrPDjqVgnkZLZ9zud1CQHmIgjmvsGDP7tr7gzM9qM7EDe N1NiWwc1pRReDCQNZCUWYiYvVONU2FChaPjTyYgmFLbF5HvWEpVEgeVESpz8BjMB8QDW 6uehox7PaQn1oLYWxrcThNp24bKU1shtRbLExtWMr83BMHY7YA3Qy59ZdsJcAlU+I+T7 x3T85Nf97UMzcgBrBl6Z63PRar0rHEbBk9UGH5dIjqlCs8YuEpopAk2i/cBC9PjC+U4z /tJYngVx10Vb6JRPHPhdWWUVXd6674/6L9M+YZHWOO2DSWa4DLGG6SNUCFc9ymIw2ZkZ xDWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755884854; x=1756489654; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1/NZ3invqjYii7VgIefIBIrdQlA4A/NoIleSlxqcTKI=; b=HmX2t5nvyoOTONl0LA6hVlEzT7vqh2VSvdzFvHnX7mgJhuBpd7PbQiSA0fIf4x0rz6 26+gvlLQ46nycDu59Ui9Zc8HfewDldrdVCSG8i7HrT5jkeE9wnSUlzgYl2633sNIeZC8 Vtjexx7+9fqRoxpc4JEMys6y69gik8ltWi4luqNFHZmo11KdHob5N+e1lKyiEzD0gq8v w8gGi5M7YUwJpyEC7sOple4cv/wPJRioACGwosKRSTN4Jn2OVRql26hEJ9rVIcEs83oW r3xMx5hyJ591initOJzyeHVs4+3Bk69LlU8afQD6whxUzFMY7E/jLeuzcz/AB6jgaQym 1Hzg== X-Forwarded-Encrypted: i=1; AJvYcCWxekgqkvHfRgy+aYD1Jr2+1RhjIz633MyO5rkjmoJ42TJzFT7twFlx6WQSaF/D9C4OPrgX78p/LhVOfT0=@vger.kernel.org X-Gm-Message-State: AOJu0YzOV0Yx/vgRkxlNZFDmHl2ODHlpTqW7bpec3Loh7LTyBbKnjDAg /+CQIy/w/8fIenJZDSHz3oLmg2gniML/ddGN0lk6nlt2gp5yweWVtiOqsXR/FpiKgEY= X-Gm-Gg: ASbGnctN+YAswO428IgXULArxLKFX3jUkRCTf5cP0NwyNgUrDWjOGJoaLEn6oPCiTDE Uq+Wjl0mGucJNUwvqZ/i2wGHHmiCYFW4fjGk9+VlxiqiMvJAnESXbjXFuZodQ07HptG70+nn1uh tCh+6YfnT9RgQl9LIQwXWCdE2t+aNQxiTf146WuQniP00q3uKedaHcMuk+pEDJhZoTs8YO1ogTY EoCUm/532qbWWVws3guA3w53pKe2KKKxw+cszNcekrMnIcc0UWp31eP6I4ULvlvfmH+Pr6mOhWx 2+VVHP04A1Np1O7EGG7tFb2eKR+cNayP+ZojqxVZmWaRqzmbOt/kV3kPrPt+jkBmTT2Tyr3/vvd tbKeNyQMeiJeuIVL7Lm0fHProlqnuG63zNhQAp5sbUJAB1BAgdPk6Y/yJzaWaAWT8azQ8cc+Nu+ EHEeZXQg== X-Google-Smtp-Source: AGHT+IFZbeEwjqDea0hlGgRVd9Xscw2cIAz+36MfAAXzcnD0U+Bx3mxtHkRwJItm6g9vdsmkz7a3oQ== X-Received: by 2002:a05:622a:50c:b0:4b2:8ac4:ef7c with SMTP id d75a77b69052e-4b2aab4abe8mr43670911cf.75.1755884853830; Fri, 22 Aug 2025 10:47:33 -0700 (PDT) Received: from jesse-lt.jtp-bos.lab (pool-108-26-215-125.bstnma.fios.verizon.net. [108.26.215.125]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4b2b8e6023asm3121361cf.53.2025.08.22.10.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Aug 2025 10:47:33 -0700 (PDT) From: Jesse Taube To: linux-riscv@lists.infradead.org Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Oleg Nesterov , Kees Cook , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang Kan" , Shuah Khan , Jesse Taube , Himanshu Chauhan , Charlie Jenkins , Samuel Holland , Conor Dooley , Deepak Gupta , Andrew Jones , Atish Patra , Anup Patel , Mayuresh Chitale , Evan Green , WangYuli , Huacai Chen , Arnd Bergmann , Andrew Morton , Luis Chamberlain , "Mike Rapoport (Microsoft)" , Nam Cao , Yunhui Cui , Joel Granados , =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= , Sebastian Andrzej Siewior , Celeste Liu , Chunyan Zhang , Nylon Chen , Thomas Gleixner , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= , Vincenzo Frascino , Joey Gouly , Ravi Bangoria , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-kselftest@vger.kernel.org, Joel Stanley Subject: [PATCH 7/8] riscv: ptrace: Add hw breakpoint regset Date: Fri, 22 Aug 2025 10:47:14 -0700 Message-ID: <20250822174715.1269138-8-jesse@rivosinc.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822174715.1269138-1-jesse@rivosinc.com> References: <20250822174715.1269138-1-jesse@rivosinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add ability to setup hw breakpoints using REGSET use the __riscv_hwdebug_state structure to configure breakpoints. Signed-off-by: Jesse Taube --- RFC -> V1: - New commit V1 -> V2: - No change --- arch/riscv/kernel/ptrace.c | 59 ++++++++++++++++++++++++++++++++++ include/uapi/linux/elf.h | 2 ++ tools/include/uapi/linux/elf.h | 1 + 3 files changed, 62 insertions(+) diff --git a/arch/riscv/kernel/ptrace.c b/arch/riscv/kernel/ptrace.c index e097e6a61910..fbd0097ec168 100644 --- a/arch/riscv/kernel/ptrace.c +++ b/arch/riscv/kernel/ptrace.c @@ -33,6 +33,9 @@ enum riscv_regset { #ifdef CONFIG_RISCV_ISA_SUPM REGSET_TAGGED_ADDR_CTRL, #endif +#ifdef CONFIG_HAVE_HW_BREAKPOINT + REGSET_HW_BREAK +#endif }; =20 static int riscv_gpr_get(struct task_struct *target, @@ -280,7 +283,53 @@ static long ptrace_sethbpregs(struct task_struct *chil= d, unsigned long idx, return -EFAULT; =20 return ptrace_hbp_set(child, idx, &state); +} =20 +static int hw_break_set(struct task_struct *target, + const struct user_regset *regset, + unsigned int pos, unsigned int count, + const void *kbuf, const void __user *ubuf) +{ + struct __riscv_hwdebug_state state; + int ret, idx, offset, limit; + + idx =3D offset =3D 0; + limit =3D regset->n * regset->size; + while (count && offset < limit) { + if (count < sizeof(state)) + return -EINVAL; + + ret =3D user_regset_copyin(&pos, &count, &kbuf, &ubuf, &state, + offset, offset + sizeof(state)); + if (ret) + return ret; + ret =3D ptrace_hbp_set(target, idx, &state); + if (ret) + return ret; + offset +=3D sizeof(state); + idx++; + } + + return 0; +} + +static int hw_break_get(struct task_struct *target, + const struct user_regset *regset, + struct membuf to) +{ + int ret, idx =3D 0; + struct __riscv_hwdebug_state state; + + while (to.left) { + ret =3D ptrace_hbp_get(target, idx, &state); + if (ret) + return ret; + + membuf_write(&to, &state, sizeof(state)); + idx++; + } + + return 0; } #endif =20 @@ -324,6 +373,16 @@ static const struct user_regset riscv_user_regset[] = =3D { .set =3D tagged_addr_ctrl_set, }, #endif +#ifdef CONFIG_HAVE_HW_BREAKPOINT + [REGSET_HW_BREAK] =3D { + .core_note_type =3D NT_RISCV_HW_BREAK, + .n =3D sizeof(struct __riscv_hwdebug_state) / sizeof(unsigned long), + .size =3D sizeof(unsigned long), + .align =3D sizeof(unsigned long), + .regset_get =3D hw_break_get, + .set =3D hw_break_set, + }, +#endif }; =20 static const struct user_regset_view riscv_user_native_view =3D { diff --git a/include/uapi/linux/elf.h b/include/uapi/linux/elf.h index 819ded2d39de..7a32073e0d68 100644 --- a/include/uapi/linux/elf.h +++ b/include/uapi/linux/elf.h @@ -545,6 +545,8 @@ typedef struct elf64_shdr { #define NT_RISCV_VECTOR 0x901 /* RISC-V vector registers */ #define NN_RISCV_TAGGED_ADDR_CTRL "LINUX" #define NT_RISCV_TAGGED_ADDR_CTRL 0x902 /* RISC-V tagged address control (= prctl()) */ +#define NN_RISCV_HW_BREAK "LINUX" +#define NT_RISCV_HW_BREAK 0x903 /* RISC-V hardware breakpoint registers */ #define NN_LOONGARCH_CPUCFG "LINUX" #define NT_LOONGARCH_CPUCFG 0xa00 /* LoongArch CPU config registers */ #define NN_LOONGARCH_CSR "LINUX" diff --git a/tools/include/uapi/linux/elf.h b/tools/include/uapi/linux/elf.h index 5834b83d7f9a..b5f35df1de7a 100644 --- a/tools/include/uapi/linux/elf.h +++ b/tools/include/uapi/linux/elf.h @@ -460,6 +460,7 @@ typedef struct elf64_shdr { #define NT_RISCV_CSR 0x900 /* RISC-V Control and Status Registers */ #define NT_RISCV_VECTOR 0x901 /* RISC-V vector registers */ #define NT_RISCV_TAGGED_ADDR_CTRL 0x902 /* RISC-V tagged address control (= prctl()) */ +#define NT_RISCV_HW_BREAK 0x903 /* RISC-V hardware breakpoint registers */ #define NT_LOONGARCH_CPUCFG 0xa00 /* LoongArch CPU config registers */ #define NT_LOONGARCH_CSR 0xa01 /* LoongArch control and status registers */ #define NT_LOONGARCH_LSX 0xa02 /* LoongArch Loongson SIMD Extension regist= ers */ --=20 2.43.0