From nobody Fri Oct 3 23:02:52 2025 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B9842FFDC0; Fri, 22 Aug 2025 12:55:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755867315; cv=none; b=LwBhJ79KsfAU44No6SovjMEA8WplFNHoC9F3Ot1b4k9zsb12cqSM7gEB2qvzgkndwXjFs6DI3ESdcIcFqOsaTdSST+FHOhIDcLIE4dIdbghljxTCVKRRIz8kv7+L8XKBtCYADI9iyQiQGLExQsHUgT7SPPAn3fr3DqH6vr5h2KU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755867315; c=relaxed/simple; bh=cc1YcKNcOVER/BJnebgIiOmQeCW29Uu9swkM5huo7Zw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mt5sB7Nn+zbl0wwOe5gHeR/qEkSCBF+Zt3SFreDkiL+mcSqh5R91ihYeIc3i8ObHU5z2s+bjWxQfpLpDPRIaJPS6NTvodKCpy+XmnfWVJFCpSRuCNz/y6w7P8YKwHvVwSmE+tYEzs7Ya39CE3HhiCsYR5k8SLePEQMRg0DAe7Ng= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WQ8Favpd; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WQ8Favpd" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2445806d44fso16998575ad.1; Fri, 22 Aug 2025 05:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755867313; x=1756472113; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Auao9O9XW0mCi9qR7BGk43RqbCNdwrXU+TczfeHm0X8=; b=WQ8FavpdjF04/k8/xDYOhqvF5PRUCIpf2x5q/lhNC93fNvzJGyREVSxV1F177ObRkS +5+oCeG10pN1+X6cvGzscJ08Qm93eMGReOveRQdMt1xVVCp+AJ6kU2cp4La5nLFKJCqn WhDZpNyUNHI7aphB487f044PEvm6r49Qq131QgYBW8Em2D2OeXzRPCdbFm9dxeKEGFPL OdBbsZlbGKwYLhQ9fe1mEzTPK+KHGN0n03mX9wa7Um+WQ0NWy0cbMgP/fIGo2Jg0K2GP sJGIOstJ6XOxpwpaQi2On61UWcISqdPtP6F1A5JES2fpH+l78E337GFXuOt3Vi3F9Pjy 8URQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755867313; x=1756472113; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Auao9O9XW0mCi9qR7BGk43RqbCNdwrXU+TczfeHm0X8=; b=C1zDChoe1vsFPUha8wUU2i4YpCEWUwkjE8vZ8bMuyMhhQk7YCzzdyMYjskXQ9U772n 8HRjue0VXmB00dHb+sy3g0bSaqA3iuSuIBc2+DDrbPVtadkNNwUJ9ANSyogUccsTzD4I 1GrJRm85SGA7v9k2+w2ED6M8VyW6KOhkpddaGxQfhE6SqcB6FXEM7n0HGrdWtSt+Kpcb CIOQbZLeFoz5y+Ekkwzjuv1JY/niVlwf4CMfrT6T5YYapEA0P6e62jyn22M82YCt6yyv NHPa/liBdR63aBCrO3mMAXpInG/BRnO7zT2jbZhUCZVNOdGgebtcmsNgqLeiBhiNMprD 3kBA== X-Forwarded-Encrypted: i=1; AJvYcCUAs4Cl6tIAiPMqrZKood5nCaWcjJEUCMU5nBiDnA+BHNQ9t4OrPUMFyWcBza1QtOvS5dUWNkzGAjvTwc0=@vger.kernel.org, AJvYcCUTyzx8GILdTXt1ivlQaczcL2vcBJ/zmQzenG07p/Eapj7sZyHZO1dhriZKVR4gqh5X3xNVX2w+N15jljBY6w==@vger.kernel.org X-Gm-Message-State: AOJu0Yzfl3BM9txZMz4BMQZaSClPzKpXgPUAwvoxM2aLaQhExl8hpT4W P1rHtN3jhOmW4z+a2E1wmgB5dBjgBjkViEpN5LQSPp/QS5ZFSU16y9vUR/cQuEeN6ic= X-Gm-Gg: ASbGncuuPH2rnsOtQ5CiQkpMpiYQWFwewBuhSrxKZmmKlPuksxXq4VDkJNHFHNJc1U5 U1CGoevC3y848u536a4nZBh6/JRKF0m0aw5eARlym6RcEm+vBzLlLagGlBlGWRxXJa8/egofpci 8DpFAc0l5AYxWcdQTfMkOJQMADqNulSm7QTCqet6pkIsP8NDyeKEqnCfeZcn83ZAaPQxYX5j2El voU0t/f6E7vCWcejXdHwI8BwtHgbEBUuu7LtTq6qkbI5OBMDmZPFz/46pYFtRilL10Rtgd1U914 cp0naJ8FrpkzVVZ98p+aOoC5fZp2pJby5DXVnUVTJ0U9MX4piIcIVSG8uOoh2PQBX5/MBHwoRL+ VbUpc+qU7K7MdO2k9tlxARcBvFbLpiqcCK+H7aryaP2KxW97iPi//ULtGCXi07oF1Jpc7Mqmk+9 I= X-Google-Smtp-Source: AGHT+IGHI61zvE7JJ234p6bRyxrJOBmVEDE9oigLD8aVog4RR7unS3GkhGneqzRYfXXj/vITAuJ9vQ== X-Received: by 2002:a17:902:ecc6:b0:243:485:26a5 with SMTP id d9443c01a7336-2462eeb70abmr40895455ad.34.1755867313236; Fri, 22 Aug 2025 05:55:13 -0700 (PDT) Received: from localhost.localdomain ([114.242.33.243]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed377843sm83617285ad.57.2025.08.22.05.55.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Aug 2025 05:55:12 -0700 (PDT) From: Jinchao Wang To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH 1/5] module: Fix module_sig_check() for modules with ignored modversions/vermagic Date: Fri, 22 Aug 2025 20:54:50 +0800 Message-ID: <20250822125454.1287066-2-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822125454.1287066-1-wangjinchao600@gmail.com> References: <20250822125454.1287066-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current signature check logic incorrectly fails modules that have valid signatures when the caller specifies MODULE_INIT_IGNORE_MODVERSIONS or MODULE_INIT_IGNORE_VERMAGIC flags. This happens because the code treats these flags as indicating a "mangled module" and skips signature verification entirely. The key insight is that the intent of the caller (to ignore modversions or vermagic) should not affect signature verification. A module with a valid signature should be verified regardless of whether the caller wants to ignore versioning information. The signature represents the authenticity and integrity of the module content, which is independent of version compatibility checks. By removing the mangled_module check, we allow signature verification to proceed for modules that have both valid signatures and are being loaded with version checking disabled. This fixes cases where modules with correct signatures were being rejected when loaded with modversions or vermagic ignored, even though the signature itself was valid and should have been verified. Signed-off-by: Jinchao Wang --- kernel/module/signing.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/kernel/module/signing.c b/kernel/module/signing.c index a2ff4242e623..9e24c79499de 100644 --- a/kernel/module/signing.c +++ b/kernel/module/signing.c @@ -73,15 +73,10 @@ int module_sig_check(struct load_info *info, int flags) const unsigned long markerlen =3D sizeof(MODULE_SIG_STRING) - 1; const char *reason; const void *mod =3D info->hdr; - bool mangled_module =3D flags & (MODULE_INIT_IGNORE_MODVERSIONS | - MODULE_INIT_IGNORE_VERMAGIC); - /* - * Do not allow mangled modules as a module with version information - * removed is no longer the module that was signed. - */ - if (!mangled_module && - info->len > markerlen && - memcmp(mod + info->len - markerlen, MODULE_SIG_STRING, markerlen) =3D= =3D 0) { + + if (info->len > markerlen && + memcmp(mod + info->len - markerlen, MODULE_SIG_STRING, markerlen) =3D= =3D + 0) { /* We truncate the module to discard the signature */ info->len -=3D markerlen; err =3D mod_verify_sig(mod, info); --=20 2.43.0 From nobody Fri Oct 3 23:02:52 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EEE12FFDE5; Fri, 22 Aug 2025 12:55:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755867318; cv=none; b=Mt4yrTgls/8i4plekNed+bGW6xCEK7H7/qcFlINhHY2nAhnxdHc7m26ETCAuUwVGYrK2ld0wJrGY+wjrCXHC6hqtxFlRSwXfEg8v/0/v5GjteVv/fArVAPwY0snxBz/GO9xdd0WL4hasmY6W/Y57V1UwkIsfLISw3xuqI8bkQYI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755867318; c=relaxed/simple; bh=AZOnz1zlxPtwzPyzKyQtxKUFGb8zoqUHrxPJKGoTOfQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BOXNJ8Z47gaGpWAiygdoT+cMOqrxxXXc/cykpP70kbt8IEUhF56xiVbI1H9mk1NXaLX2TLyp+HG+EvvX0+va92ZUhih1CR8K2/f7Zch8DBaZq5fyn9bwiIFYvCwHThXHYDtCoiV+8Adh58tFzXXZ+zrh/rs5C7oewpCo8PgPDJA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dTEY8tni; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dTEY8tni" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2461864f7f8so13975525ad.2; Fri, 22 Aug 2025 05:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755867317; x=1756472117; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/MOC5/63BtcNhL7vYKgaSAFKz3pzzEdi036Le9lmLW0=; b=dTEY8tnis4flnrxCvTdaer/uByh8Fo708txFes0sMEySPdGCWjnW7SVsBjvO3n2gN6 E9KXRNSCCIoZrINw7Y4PP9aPJUCwjQvhhxd8mK/TBUymJ+PIej7di0cHFYJc0zmizVrP EIG6BtgXDMOJwi49SAWmkRRSCm5u7tPGUqWaI+sqSfo2pqfP4HY8DZLttcA2Jpj3dP6Z PFVHvmrG06RyLToUQXcLmrh4yYlBjZWFmoyuy3CSVzPAHdK5+3Fy6WjNTupXy8Qbg6oc RugATgpMOT3g4jc1QBDwUflyFzY3Bn8rfsRxfwNM2EN2TzSKKqGmtA6usFsCFVuo5X91 FFWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755867317; x=1756472117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/MOC5/63BtcNhL7vYKgaSAFKz3pzzEdi036Le9lmLW0=; b=xQEl7Rq7XyOgcQPPZhagEsHdjjal4FUnHxRmiiQFMIa9/7Q0FkwdWqMzDnodwdgpIr 9jL4/ibnMIyj0keevtLppt4AFM5gLHZ7taKEK4iMZ723bi85wFVpSjsTnTdnbS28JJVP w88Mtl+LTSquuEgIPUtXW+y8pdYjQe/3HJpE2d1u5DtzA7DfmUJ+wnyIUF0xaRUhk5aE Ksx67j+xmAkJBEzgOoZm1I6n38guyFPIxuw/V7K2Zh4odSxVxVoNkz+OUK26IKkE1OOC 3tOFzExSk81WoszdK070/RmwXC+utz1m+CDOz6/QM+zg0JbYuL5PW9L89wNDGKppuOsX Jdcg== X-Forwarded-Encrypted: i=1; AJvYcCU0y+mziB1J68u5JNBw7GYM5PLZZOAmkvDFN3If0peMYaOzTsXAEP9OBpG2FzTJJ0klMlYAHoFIRj41FR4=@vger.kernel.org, AJvYcCWfbE+sbK5X3CkkJC5uy1DgRhT/rPxvh69wkMK5Gk5HAhRqkPvBV75W1jcT48b7Zt7okdEtTUHgyAu8JwMCsQ==@vger.kernel.org X-Gm-Message-State: AOJu0YwMsnQ4AWFS+VYjUuHbOYOdboPaq30tkm0y6F5BeQ42haTlsLXy lhJnrGvMjZf2l5yEeK/+wz+KxOouj1k6pGUpjcgJKp5H4bpAym2hxeVB X-Gm-Gg: ASbGncvDlyFs5FJOmJoadnMhghkn7JogemSkDePBhUg+NE7I7NMauHB+E0b19QiFPbd 9MzwxVxztlpj3EL+vvMzjWteGmF8H7vNI7ew/L6ocmakrktcEzEbdXvuWtzwB+7IMKVFFOTxetj BSH3fiVO04N3DzjsfPb9omncjkq7gFGxvXm75xCr/BrYOewHllrZ/U5/er8NfDTZrytHIuU240a E3SrvAYt/t4Hkf4yL1SQCYDVAlYGtauhz+lACyyJwA7xbfyHq5PSxbS0GPlJFuW7zNBB/JsLOsN S66dvH4r4JSGgxjC0yE7aIRw7lPD7bURnPq+ULvsT3AI0YgRMNxObJQjx4tvdsY/sMC0TuUlEaY bDT3Hj3X9tnFF3USyPoFQMh3TMGL/veH4hXJSx0BnfAc1TUkQifxcdvtvIwt+UC068ZwP7wy21E k= X-Google-Smtp-Source: AGHT+IHunU137mEbBlLdIHFX75ERCXzYfs9Y2SkuVa1UjA83/OvrvhnUZlihpUd+AXWeWqWH7vic2g== X-Received: by 2002:a17:902:ceca:b0:242:a0b0:3c39 with SMTP id d9443c01a7336-2462efbd88emr51869585ad.54.1755867316671; Fri, 22 Aug 2025 05:55:16 -0700 (PDT) Received: from localhost.localdomain ([114.242.33.243]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed377843sm83617285ad.57.2025.08.22.05.55.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Aug 2025 05:55:16 -0700 (PDT) From: Jinchao Wang To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH 2/5] module: signing: Use pr_err for signature rejection Date: Fri, 22 Aug 2025 20:54:51 +0800 Message-ID: <20250822125454.1287066-3-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822125454.1287066-1-wangjinchao600@gmail.com> References: <20250822125454.1287066-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make module signature rejection messages more visible by using pr_err instead of pr_notice. Signed-off-by: Jinchao Wang --- kernel/module/signing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/module/signing.c b/kernel/module/signing.c index 9e24c79499de..00f079cafd4f 100644 --- a/kernel/module/signing.c +++ b/kernel/module/signing.c @@ -112,7 +112,7 @@ int module_sig_check(struct load_info *info, int flags) } =20 if (is_module_sig_enforced()) { - pr_notice("Loading of %s is rejected\n", reason); + pr_err("Loading of %s is rejected\n", reason); return -EKEYREJECTED; } =20 --=20 2.43.0 From nobody Fri Oct 3 23:02:52 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE89F304989; Fri, 22 Aug 2025 12:55:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755867322; cv=none; b=mqcW5+Q7pX+JUjlNvuuSYa8U14MfB8yqOCIRs13BNRVoioqYUgAHHA3PJ0A0dyY8SbQ4ps0oS98hWKizX9exNULsmi8LIP1jnBj8yy5de1Rb81yaZu1m+oGoh3X13tvrw/Dg2bihoblaSJtGSn0mGBZ5huvd7NT19JGfCZz++RY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755867322; c=relaxed/simple; bh=8jjYGS5PeFKcozsVZLXrvKIwWo7k8S7vhYJP/tMr/ss=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t76uHYbSfOpsOam4tdKgClNueknahhRdCiL7ZDchN4aTRRVe6sqP5CfEiFqjpak416n/MiMNN1MLKrEcqVpAwV4oXrazeffM+51XRkpU8EiwQcDTBewMoYu3Pf7jNpTAbyIVgw6YWwbkpUvVphbdhcFjmdq3R+hor21yoWHUULU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OImhc/LJ; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OImhc/LJ" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2445811e19dso17147965ad.1; Fri, 22 Aug 2025 05:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755867320; x=1756472120; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EAU8pFNlFHyGhl4ZEBlmiIHJhRLnwySKV8rZz4maxqE=; b=OImhc/LJT1wXu1JtJWB7rf95WULXO7dyLVBFzr/9LXUSdBRSkcn/W7Sy3VCBjUfH6s +GsSHUMtsWBLkXtpUKGI9bwZMp4bGgYg6RDSsRdoqeuMb3J219zo+CM9lPc9IbvoBwZq P6yb8guDcrDzTGfz6/AjMjfL2EGHpxO0EuEn49iPNH15ckSGP1xcjGaOP0GsCql/JInv WINEwZZB78OhvptzaZqI1KorK2/wGRCNhPBKFtuTWy9JdPHOZoHR5/KcVhXS59FglUln +PwN8t7/+alPvBNKkeoiB0AnVQRDJnZQTFSbRwzbZyEljA87VsrrCdLGd5O/AXj6NIEe cbSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755867320; x=1756472120; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EAU8pFNlFHyGhl4ZEBlmiIHJhRLnwySKV8rZz4maxqE=; b=ax50lWNI4GhofiPvSrDSp7SvU37/jIewGUAGUdu6LrhRACIKQmQdP/2AeE8kKrH3Q0 /eML67Q9QJpuJE73AItlxuFpYtRnoAvFlkwgCFMBU3w4B0XkiNd1Jenov7tod+wY8H6R Ggrgu180W2Oamv+m+SSECw0p9ar/+ZxjjGiu3Se7VpaB2q9xbQR2RYKF5NXf4pPlBXls 0+g1rYoHiOl3ZUU+BgsJHSrECHc4oRWE80BKsjLaphFPY9573cnaAEv8CsSyfkawOvoc T8c+Hoh8NgEcravdKNibP6Gs76+9eZVZMhqY4IKHo/RojdKLErVnrEh99dx94eOar89M eGlg== X-Forwarded-Encrypted: i=1; AJvYcCVeZzDVckqJUB5YQek5KJRch+/pqwp9BVYQJg/HfWP7fT29hZbBQQ5GIV1yIcO7lqoPDdr+aEVpq9yfN2qXFw==@vger.kernel.org, AJvYcCX2SHxSDcO78sjvu3UuM4Xk9v2LVZr3CItlHOBUJ307KfswkxaUkBk5ViifijJJnQ2+DK95YVBllaqbAwo=@vger.kernel.org X-Gm-Message-State: AOJu0Ywb+nQvH25QUTdSGO0hPQN7aMttHotv01iZB7ZS5kJ925pHTzT7 F7h/FTEDZM3kqeBMUOBA3aLm4S0z1PDU3AnUpJkiZ9x/GZjGDn37VUiq X-Gm-Gg: ASbGncvuz0paQ42hKJKSQiFiXE/pqFiR8qkhlTO+mzp34/GLfY3Pb4B/EB7Ja9dhWod aSluflNFuTqAmxUJHxx2+ADYl0qZ8XZfPhnAtsHX0UAPUMoEI2IEoGBJlROq20x3ISriuvXKLHX bwVPPNFMvphrlCCbMrUK9t9KvQtpSvR309JiL/8PbdHTwLrSAkSujcE89m9o0KEz2Qi92Nc2kLe XUF5ivS8ksTfVQzEfeEA3cg0MGDuKiZhnAiA7n8FS5HnpafbP6vfcJyPhlE6gcHkcPgSv28u9gC 4AP9AxLYNXTQ2dlk7LjS/qoMPvVxT+Q/YbQb2ao5eI5HsdqnyxbrnJoAZb25oCIRQjQOO+xnbbI TMFAv78h37P+YSQmhuom6GdUB3nxod8VZnocvL2lrIieHyXGp0Kqq26gnd01CaAgu3yeGUb7g0E A= X-Google-Smtp-Source: AGHT+IHsxQLMXCnBGCn/SEkfUyC+Su4X0WaERT4vmagBCKbCjWYWNvIO5t7fXkE6TBOF395yO3CUHA== X-Received: by 2002:a17:902:e744:b0:243:43a:fa34 with SMTP id d9443c01a7336-2462ef706d0mr47925235ad.49.1755867320131; Fri, 22 Aug 2025 05:55:20 -0700 (PDT) Received: from localhost.localdomain ([114.242.33.243]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed377843sm83617285ad.57.2025.08.22.05.55.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Aug 2025 05:55:19 -0700 (PDT) From: Jinchao Wang To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH 3/5] module: show why force load fails Date: Fri, 22 Aug 2025 20:54:52 +0800 Message-ID: <20250822125454.1287066-4-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822125454.1287066-1-wangjinchao600@gmail.com> References: <20250822125454.1287066-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Include reason in error message when force loading is disabled. Signed-off-by: Jinchao Wang --- kernel/module/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/module/main.c b/kernel/module/main.c index c66b26184936..a426bd8a18b5 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -1083,6 +1083,7 @@ int try_to_force_load(struct module *mod, const char = *reason) add_taint_module(mod, TAINT_FORCED_MODULE, LOCKDEP_NOW_UNRELIABLE); return 0; #else + pr_err("%s force load is not supported\n", reason); return -ENOEXEC; #endif } --=20 2.43.0 From nobody Fri Oct 3 23:02:52 2025 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17ECB30507B; Fri, 22 Aug 2025 12:55:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755867325; cv=none; b=agLQP1zR3pXXHp76O2dpCVfmD35XgGEPeyXur8CCOvh3UdFcsFBKArf5l2pjWete8P5XH7XGs2jypfpoL3p5Qb6/SU9AfdgUTdtkbA3Sk4/sLWXpE0RoUp9y1G4oPE/2fGxE8quvbugjMsL1E2el7XpIrUF4pC23J5bNlsmeWa0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755867325; c=relaxed/simple; bh=WIZhDf7mzHY4XXBEi7WlI+/ym2i2jl+fPcoagVQ5+8o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ag4lnwZc74ATv2vkOxgfxPNj1Qt5Co11PV2Zm9y0R6hJ54U3KJnbis6lL45e3XD71lL+CGxXXSg7OrueBXRmd19uPLZLwCYMtQbWbw8B0c9AopIYOC0tGM+7TN6+7MMjn5jdPn9F8+9zVa+yA7xA49+Vpl4ifJztDZfVCqu1Km0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DKFBkCgG; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DKFBkCgG" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-b49c9028f7aso144015a12.1; Fri, 22 Aug 2025 05:55:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755867323; x=1756472123; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7jM/+V6EEGOLi+0vxxWavU3+I5kcXvL1gGtdXlfilR8=; b=DKFBkCgGU7hUn+nCTRmYD0hJEB475D+qTb8ZI+Bt32Ckt+0oF/oadkXvL7jSCSB5OV wbF3g9zmppOGvQPzan8fNsqr4wvbaOQ/nVnuFkETvayf+T2K/bOHS6CoMONqTdbD7nR5 y3Auf6tIKTgvJVFyQXsNsXWL03VUiNsb0qVlWzrFAd9mdzNauU+bNjTUoLuI6QUQBB/5 bIrJdbunU7hAm8Q+CLTBCkrIL82NnFIBP4+qOnf3pI+WN4WSjgikN6im51vrOAru27k/ vM2Cu017GIdcPnwmFx1WL4ywbub8uOrSnYNBOug9ZXMeCKAIGwQSioOISSkfZjP7mHoT j9mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755867323; x=1756472123; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7jM/+V6EEGOLi+0vxxWavU3+I5kcXvL1gGtdXlfilR8=; b=hzDWCd7F7vbvslhx9ZdPrmMAUzTls+ZB3Opny/z47+m7QR6ZVSk4ybhPohz7dsDyak JBu1NIL0K/I4hgD+sfFfk+/eA9Uq08aCDSMRMXi7ok8LsznCVxXAs8cu3LaR+IPjaDSY FHctNQqUTigGmysSC/1hPufWtcWU4N+mBK1YJ9wFBHomlm/6l8A4GUcFEe3FJDLcDUuq q/KSdWIPEcthmQRFktJnRcsh1mYP8OAW4uxCARzRTDChmQtwlj4RLXsE/+wRbxA3YNGg DM19qconVxrbD88HnXJPfQ2aupKUG1RdALAN9d1K9WEPpEf0tprHjn/wpuV4VZeTxJ6K ETyA== X-Forwarded-Encrypted: i=1; AJvYcCU0ZD3zIsvtN6N8kUHqvP4A05GtoSRdo9EWLYnOAasxgVNaAOwf834upyqtKjqsTwxOaTtPImCt//DkkVdrJw==@vger.kernel.org, AJvYcCU5fiOQrR5cEhuAG8VwBk7nUICr2gymF4JF4RP+Vpt4yCAT7B7e/WWzEu9qWfSEttfzbWhJ0ixYPpnT40E=@vger.kernel.org X-Gm-Message-State: AOJu0YxGyc5zyzXMXdcEHh2UQGQXgTikfiJhj38gWK+Zjnu/OLUiWelL vDVdK7mIW1qnM2D1K8d+hOMtFXgYCvHFBV01OGpVLEFjcKwDn0hblbaxOCIlQuVlZKU= X-Gm-Gg: ASbGncv4EJfjPBlTAMDKW+BTxP9G/3xURdJo1oTitB1DfsYRko9tAqS6ulcDOiK5B5Z Dr1c0gbp4+cf7TQj6QP/0yyxDgCGzjyg5XSIRmKEEqqpBoL+5bEOG/LtvlE0+qElgHxla09zEhU yI6zHzdDZACPLgxemT39T8qQ7tU4EGvz/NGXxrC9rcLjx4MPw5wGVLww4DJGDA7Mp/9Y/Wic4Uq uprrEgLam1YqmSwytlIdvuOcND9eQrwbXXeiqhrq68HTayUUq8uFmLC6LXXaAlgfuI8Avl3OjKH rIP1wRuxt2iVlAtng8hye/cHWA51aGhs3iRW4jKq2/ZhG7a7i9YFYnCaMk3U+ZMRI3KyzUhK7Cn PjKr4HmG6XjR0yW+Z24XAwlEeh1A999KdFp/MWpD2MMaF7qrjZb1ulfJS3IVzCPKWbjbuv7zLe4 o= X-Google-Smtp-Source: AGHT+IHlQUIErPrTceEbt6JJyenkgNicDAmZYVylMv9/fpFkT/9KWm6f/UZqXZoTO+9JRhXq14k5ng== X-Received: by 2002:a17:903:b45:b0:23f:d47a:c9d3 with SMTP id d9443c01a7336-2462ee38fa2mr38746855ad.15.1755867323340; Fri, 22 Aug 2025 05:55:23 -0700 (PDT) Received: from localhost.localdomain ([114.242.33.243]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed377843sm83617285ad.57.2025.08.22.05.55.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Aug 2025 05:55:22 -0700 (PDT) From: Jinchao Wang To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH 4/5] module: centralize no-versions force load check Date: Fri, 22 Aug 2025 20:54:53 +0800 Message-ID: <20250822125454.1287066-5-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822125454.1287066-1-wangjinchao600@gmail.com> References: <20250822125454.1287066-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move try_to_force_load() call from check_version() to check_modstruct_version() to handle "no versions" case only once before other version checks. This prevents duplicate force load attempts and makes the error message show the proper reason. Signed-off-by: Jinchao Wang --- kernel/module/version.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/kernel/module/version.c b/kernel/module/version.c index 2beefeba82d9..3f07fd03cb30 100644 --- a/kernel/module/version.c +++ b/kernel/module/version.c @@ -41,10 +41,6 @@ int check_version(const struct load_info *info, return 1; } =20 - /* No versions at all? modprobe --force does this. */ - if (versindex =3D=3D 0) - return try_to_force_load(mod, symname) =3D=3D 0; - versions =3D (void *)sechdrs[versindex].sh_addr; num_versions =3D sechdrs[versindex].sh_size / sizeof(struct modversion_info); @@ -81,6 +77,11 @@ int check_modstruct_version(const struct load_info *info, }; bool have_symbol; =20 + /* No versions at all? modprobe --force does this. */ + if (info->index.vers =3D=3D 0 && + try_to_force_load(mod, "no versions module")) + return 1; + /* * Since this should be found in kernel (which can't be removed), no * locking is necessary. Regardless use a RCU read section to keep --=20 2.43.0 From nobody Fri Oct 3 23:02:52 2025 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 645823054E6; Fri, 22 Aug 2025 12:55:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755867328; cv=none; b=pJ72064JtjW3TMH6ipP7s3v8E6nOZijBt/h+UtHdz5NmEobMBtPHsYUJ6G51ECjgmg3gLTNQc0UMolxiTNQ01HbyAOHoa9q1jaeXxqq99mYOTyPkWbQCsRbEgxTgawuh8y9vTkbwrb9WXC/EFFZEuil2SvW7OCYMMb5KqfDrNeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755867328; c=relaxed/simple; bh=fS7tcc3pbTtPPamWit3eOd5Xqy7QnEiA95Q4HrebIfE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J3BYK29OHswEU/11pQJzbUGCzQjFcCPtkNiHzzXbfNSE7sKXdGvtA2rJxMsse9Stz9WFSBIuH9OOeb3HZOp8bqBrOCy88X7LTtqHaKjF/MMC2xby3xjlsPkzWwTqK87mgO2GNlGmE0qGLN77X5ws/R96hrCWEzuvCdVrElO7IMQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G9KQ0fpV; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G9KQ0fpV" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-24626e06f04so9294325ad.2; Fri, 22 Aug 2025 05:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755867327; x=1756472127; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X0BMKCDKNzT45IkwjHH8qIV9wptfqQdqs3ianpNZIF8=; b=G9KQ0fpVjJlje5AhI69AaIUjc1LytHsL5WoAZLPdUmzi6NPX7CfGGKwEwx0WcJTh6K qSL5buMr3rzzWgB3sVtG0JXHC7pLmoqXeGk5itRyvGrVW8yizHVCRCx5ZNAhCVew6CzS tUGG38yG6d8kKJKsKtyAvAkAa1sXqpR7TkuvG4jp9GTZ0pLPfmK/j5ykKxRaoaHZStR7 Hze54SH4eaPvhAlEEKjbaNQeUy6iboBAsa6DJV7oho3m9YQpAG7aZ1riXtcButGP+PeQ FHUKAIH3ZBA4sM+ZDCb62xhrl8O9LC3CmsoMRxBc7JJGrQS1Be5pWR1p3wOItHGe8nRs w4+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755867327; x=1756472127; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X0BMKCDKNzT45IkwjHH8qIV9wptfqQdqs3ianpNZIF8=; b=D0IBHKj2ozs6iPmNdWZFTkZf0PBZGMzPxJW/Lyv1nXBcLL5YjCu2BfZ7wORTzG3q5G K6ifDK/u6f9523ZjtGHTss4QRltQVcg80zwexR1/XgUxoPZn88uPveDn53KbTYSMrJcg QagH5MRDNhBo0/GmiqBdeCXxtY2NOFqiz/nSKyzugwtesXUGWg9+YlDFsI4la04OPoRL dE/7QgV46wy3S+TXCUB40z1iTqSI8VHZkW6+1wc7l516FDk8wFRlcEHUc+bU/MHLJYMB eBmriDfyqd8rugvUJM5mKsgj3v34OxJmV1a7KmF5qo/LqY81QGwZvO6E6pWymxWTCMT/ Vjog== X-Forwarded-Encrypted: i=1; AJvYcCVRkVpFGgmSMfpD/CaulDSmANQC9PF4wU6j4B/p1ZigwMioimIYZN7cdOMrUNq6c5ddhy5H/UDhWuGObv7j6w==@vger.kernel.org, AJvYcCW0VKwdaOdvgN2kTaseB01bSPD8QF7IHDYm+aoaDNTTvQTHm4UYdo5JNejWNFXKV/FCsFRLMj3dzzPkv9c=@vger.kernel.org X-Gm-Message-State: AOJu0YxwYQ4rdj5LE7OHHKRpPKK7ligFHPXMX2Prf2zeri3H3cu8otPW zI6jR2brYsPeDSXTSExSsbVH4fT6s/AmX4wZOQVOuLIjw/U0tUgtWYBi6ir7ywxRnR4= X-Gm-Gg: ASbGncs3KXtUxqAC8KBlUF9ld53+aDwxuUEyRKn4wPmeMWyCmIbMNVyWl65TMJCANNI QPdI3jWowkwiK+AWcyu9qCW6YkE50SGTy9TJJLki/cHp1NjLQwogDTD7Qga2F4dHNDBXGYMeR+G 192hI1yDvYeByLYJ/NJWZYLoye/lO+PeqXgsjW16W+XDcRq98YAxUsTiPyMtxO2tIPP242gRyRO PevbDZAaXd46N6TJC4DpBb5CMwRVTMfAQA26bHVuUUwRBB5zXSB5DVa9l4ytyXpJ7BxZ1P8tlzV bDCdv0zJfxJK/FVnu1G26OQU1OkhlSlqZh/UM2st6TBOVjo4IhyryOptIMeVIHPu9lGIAvgEWdk NELpSRcvsxdJ9gg+H8w7UUYxYxv2gPKgDHWvXi0cTCiqg8UXOejz+Yc7LSWGDCk+zOt5rBTRP51 0= X-Google-Smtp-Source: AGHT+IGe9xjvRCbm5KB6XLhgwUqmolb7H5vCwSf1+FeiK1gVWZ3mrj8iBWsJGAOkiE2ig10Kuikt9g== X-Received: by 2002:a17:903:22c5:b0:246:61e:b561 with SMTP id d9443c01a7336-2462efd975dmr41616535ad.58.1755867326536; Fri, 22 Aug 2025 05:55:26 -0700 (PDT) Received: from localhost.localdomain ([114.242.33.243]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed377843sm83617285ad.57.2025.08.22.05.55.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Aug 2025 05:55:26 -0700 (PDT) From: Jinchao Wang To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH 5/5] module: separate vermagic and livepatch checks Date: Fri, 22 Aug 2025 20:54:54 +0800 Message-ID: <20250822125454.1287066-6-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822125454.1287066-1-wangjinchao600@gmail.com> References: <20250822125454.1287066-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename check_modinfo() to check_modinfo_vermagic() to clarify it only checks vermagic compatibility. Move livepatch check to happen after vermagic check in early_mod_check(), creating proper separation of concerns. This makes the module loading sequence more logical: - First verify module vermagic - Then check livepatch-specific requirements No functional changes, just clearer code organization. Signed-off-by: Jinchao Wang --- kernel/module/main.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/module/main.c b/kernel/module/main.c index a426bd8a18b5..d30bffeef63e 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -2571,7 +2571,7 @@ static void module_augment_kernel_taints(struct modul= e *mod, struct load_info *i =20 } =20 -static int check_modinfo(struct module *mod, struct load_info *info, int f= lags) +static int check_modinfo_vermagic(struct module *mod, struct load_info *in= fo, int flags) { const char *modmagic =3D get_modinfo(info, "vermagic"); int err; @@ -2590,10 +2590,6 @@ static int check_modinfo(struct module *mod, struct = load_info *info, int flags) return -ENOEXEC; } =20 - err =3D check_modinfo_livepatch(mod, info); - if (err) - return err; - return 0; } =20 @@ -3334,7 +3330,11 @@ static int early_mod_check(struct load_info *info, i= nt flags) if (!check_modstruct_version(info, info->mod)) return -ENOEXEC; =20 - err =3D check_modinfo(info->mod, info, flags); + err =3D check_modinfo_vermagic(info->mod, info, flags); + if (err) + return err; + + err =3D check_modinfo_livepatch(info->mod, info); if (err) return err; =20 --=20 2.43.0